josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
d52c00a8fe79186013980af0e2caa3fd13c0c5fa
TCPlayerbotCore/src/server/game/Spells/SpellEffects.cpp
T

6007 lines
220 KiB
C++
Raw Normal View History

Remove the accidental additions of CRLF-crap from the header updates
2010-10-07 15:35:36 +02:00
/*
New Year
2020-01-02 06:44:10 +01:00
* This file is part of the TrinityCore Project. See AUTHORS file for Copyright information
Remove the accidental additions of CRLF-crap from the header updates
2010-10-07 15:35:36 +02:00
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
* You should have received a copy of the GNU General Public License along
* with this program. If not, see <http://www.gnu.org/licenses/>.
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
*/
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Spell.h"
#include "AccountMgr.h"
#include "AreaTrigger.h"
Core/Items: Implement azerite empowered items
2019-12-05 00:12:35 +01:00
#include "AzeriteEmpoweredItem.h"
Core/Items: Implement azerite essences
2019-11-22 11:02:04 +01:00
#include "AzeriteItem.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Battleground.h"
#include "BattlegroundMgr.h"
#include "BattlePetMgr.h"
Core/Spells: Fixed spell effect 93 (SPELL_EFFECT_FORCE_DESELECT) (#19001)
2017-02-04 20:21:12 +01:00
#include "CellImpl.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "CombatLogPackets.h"
Core/Players: Implement basics for the honor system
2017-06-04 16:51:47 +02:00
#include "CombatPackets.h"
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
#include "Common.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Conversation.h"
#include "Creature.h"
#include "CreatureAI.h"
Core/DataStores: 9.1.0 db2 structures
2021-08-07 19:40:34 +02:00
#include "CreatureTextMgr.h"
* Remove the last of the realative paths from #include statements
2010-06-08 17:01:03 -06:00
#include "DatabaseEnv.h"
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
#include "DB2Stores.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "DuelPackets.h"
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
#include "DynamicObject.h"
#include "GameObject.h"
Core/AI: implemented SmartScripts System (still beta) not 100% complete
2010-10-27 21:01:47 +02:00
#include "GameObjectAI.h"
Ensure that all actions are compared to fixed point in time (ie. world update start) (#18910)
2017-03-02 02:19:25 +01:00
#include "GameTime.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Garrison.h"
#include "GossipDef.h"
Core/Spells: Fixed spell effect 93 (SPELL_EFFECT_FORCE_DESELECT) (#19001)
2017-02-04 20:21:12 +01:00
#include "GridNotifiers.h"
Core/Grids: Allow customizing packets sent with MessageDistDeliverer and MessageDistDelivererToHostile depending on receiver
2021-04-30 00:08:07 +02:00
#include "GridNotifiersImpl.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Group.h"
#include "Guild.h"
Core/Spells: Allow ProcessEvent hook to run in EffectSendEvent when spell caster is a player
2011-09-30 18:41:30 +02:00
#include "InstanceScript.h"
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
#include "Item.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Language.h"
#include "Log.h"
#include "LootMgr.h"
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
#include "Map.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "MiscPackets.h"
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
#include "MotionMaster.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "ObjectMgr.h"
#include "Opcodes.h"
#include "OutdoorPvPMgr.h"
Core/MMaps: Implement pathed charge effect
2012-09-03 20:30:30 +02:00
#include "PathGenerator.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Pet.h"
Core/Entities: Phasing rewrite
2018-01-28 11:37:20 +01:00
#include "PhasingHandler.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "Player.h"
Core/Misc: Reduction of header dependencies - Step II
2012-11-20 12:30:30 +01:00
#include "ReputationMgr.h"
Core/Scenes: Implemented spell created SceneObjects
2021-10-11 12:59:19 +02:00
#include "SceneObject.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "ScriptMgr.h"
#include "SharedDefines.h"
#include "SkillExtraItems.h"
#include "SocialMgr.h"
#include "SpellAuraEffects.h"
#include "SpellAuras.h"
#include "SpellHistory.h"
#include "SpellMgr.h"
Core/PacketIO: updated SMSG_CLEAR_TARGET and enabled some opcodes
2015-03-10 16:29:52 +01:00
#include "SpellPackets.h"
Core/Players: Implemented new glyph system
2016-08-25 19:12:00 +02:00
#include "TalentPackets.h"
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
#include "TemporarySummon.h"
#include "Totem.h"
#include "Unit.h"
#include "Util.h"
#include "World.h"
#include "WorldPacket.h"
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
#include "WorldSession.h"
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
NonDefaultConstructible<SpellEffectHandlerFn> SpellEffectHandlers[TOTAL_SPELL_EFFECTS] =
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
&Spell::EffectNULL, // 0
&Spell::EffectInstaKill, // 1 SPELL_EFFECT_INSTAKILL
&Spell::EffectSchoolDMG, // 2 SPELL_EFFECT_SCHOOL_DAMAGE
&Spell::EffectDummy, // 3 SPELL_EFFECT_DUMMY
&Spell::EffectUnused, // 4 SPELL_EFFECT_PORTAL_TELEPORT unused
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, // 5 SPELL_EFFECT_5
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectApplyAura, // 6 SPELL_EFFECT_APPLY_AURA
Core: Minor cleanups (here and there)
2011-09-13 14:15:35 +02:00
&Spell::EffectEnvironmentalDMG, // 7 SPELL_EFFECT_ENVIRONMENTAL_DAMAGE
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectPowerDrain, // 8 SPELL_EFFECT_POWER_DRAIN
&Spell::EffectHealthLeech, // 9 SPELL_EFFECT_HEALTH_LEECH
&Spell::EffectHeal, // 10 SPELL_EFFECT_HEAL
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
&Spell::EffectBind, // 11 SPELL_EFFECT_BIND
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectNULL, // 12 SPELL_EFFECT_PORTAL
Core/Spells: Implement SPELL_EFFECT_TELEPORT_TO_RETURN_POINT (#26217)
2021-03-28 02:22:34 +03:00
&Spell::EffectTeleportToReturnPoint, // 13 SPELL_EFFECT_TELEPORT_TO_RETURN_POINT
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, // 14 SPELL_EFFECT_INCREASE_CURRENCY_CAP
Core/Spells: Implemented SPELL_EFFECT_TELEPORT_WITH_SPELL_VISUAL_KIT_LOADING_SCREEN
2021-10-13 11:49:30 +02:00
&Spell::EffectTeleportUnitsWithVisualLoadingScreen, // 15 SPELL_EFFECT_TELEPORT_WITH_SPELL_VISUAL_KIT_LOADING_SCREEN
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectQuestComplete, // 16 SPELL_EFFECT_QUEST_COMPLETE
&Spell::EffectWeaponDmg, // 17 SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL
&Spell::EffectResurrect, // 18 SPELL_EFFECT_RESURRECT
&Spell::EffectAddExtraAttacks, // 19 SPELL_EFFECT_ADD_EXTRA_ATTACKS
&Spell::EffectUnused, // 20 SPELL_EFFECT_DODGE one spell: Dodge
&Spell::EffectUnused, // 21 SPELL_EFFECT_EVADE one spell: Evade (DND)
&Spell::EffectParry, // 22 SPELL_EFFECT_PARRY
&Spell::EffectBlock, // 23 SPELL_EFFECT_BLOCK one spell: Block
&Spell::EffectCreateItem, // 24 SPELL_EFFECT_CREATE_ITEM
&Spell::EffectUnused, // 25 SPELL_EFFECT_WEAPON
&Spell::EffectUnused, // 26 SPELL_EFFECT_DEFENSE one spell: Defense
&Spell::EffectPersistentAA, // 27 SPELL_EFFECT_PERSISTENT_AREA_AURA
&Spell::EffectSummonType, // 28 SPELL_EFFECT_SUMMON
*Move target handling of TARGET_DEST_CASTER_FRONT_LEAP out of SPELL_EFFECT_LEAP handler, this fixes spells with SPELL_EFFECT_LEAP using other target types.
2010-07-21 02:06:51 +02:00
&Spell::EffectLeap, // 29 SPELL_EFFECT_LEAP
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectEnergize, // 30 SPELL_EFFECT_ENERGIZE
&Spell::EffectWeaponDmg, // 31 SPELL_EFFECT_WEAPON_PERCENT_DAMAGE
&Spell::EffectTriggerMissileSpell, // 32 SPELL_EFFECT_TRIGGER_MISSILE
&Spell::EffectOpenLock, // 33 SPELL_EFFECT_OPEN_LOCK
&Spell::EffectSummonChangeItem, // 34 SPELL_EFFECT_SUMMON_CHANGE_ITEM
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
&Spell::EffectUnused, // 35 SPELL_EFFECT_APPLY_AREA_AURA_PARTY
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectLearnSpell, // 36 SPELL_EFFECT_LEARN_SPELL
&Spell::EffectUnused, // 37 SPELL_EFFECT_SPELL_DEFENSE one spell: SPELLDEFENSE (DND)
&Spell::EffectDispel, // 38 SPELL_EFFECT_DISPEL
&Spell::EffectUnused, // 39 SPELL_EFFECT_LANGUAGE
&Spell::EffectDualWield, // 40 SPELL_EFFECT_DUAL_WIELD
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
&Spell::EffectJump, // 41 SPELL_EFFECT_JUMP
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
&Spell::EffectJumpDest, // 42 SPELL_EFFECT_JUMP_DEST
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTeleUnitsFaceCaster, // 43 SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER
&Spell::EffectLearnSkill, // 44 SPELL_EFFECT_SKILL_STEP
Core/Spells: Implemented play movie spell effect
2012-10-26 21:13:00 +02:00
&Spell::EffectPlayMovie, // 45 SPELL_EFFECT_PLAY_MOVIE
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
&Spell::EffectUnused, // 46 SPELL_EFFECT_SPAWN clientside, unit appears as if it was just spawned
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTradeSkill, // 47 SPELL_EFFECT_TRADE_SKILL
&Spell::EffectUnused, // 48 SPELL_EFFECT_STEALTH one spell: Base Stealth
&Spell::EffectUnused, // 49 SPELL_EFFECT_DETECT one spell: Detect
&Spell::EffectTransmitted, // 50 SPELL_EFFECT_TRANS_DOOR
&Spell::EffectUnused, // 51 SPELL_EFFECT_FORCE_CRITICAL_HIT unused
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, // 52 SPELL_EFFECT_SET_MAX_BATTLE_PET_COUNT
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectEnchantItemPerm, // 53 SPELL_EFFECT_ENCHANT_ITEM
&Spell::EffectEnchantItemTmp, // 54 SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY
&Spell::EffectTameCreature, // 55 SPELL_EFFECT_TAMECREATURE
&Spell::EffectSummonPet, // 56 SPELL_EFFECT_SUMMON_PET
&Spell::EffectLearnPetSpell, // 57 SPELL_EFFECT_LEARN_PET_SPELL
&Spell::EffectWeaponDmg, // 58 SPELL_EFFECT_WEAPON_DAMAGE
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
&Spell::EffectCreateRandomItem, // 59 SPELL_EFFECT_CREATE_RANDOM_ITEM create item base at spell specific loot
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectProficiency, // 60 SPELL_EFFECT_PROFICIENCY
&Spell::EffectSendEvent, // 61 SPELL_EFFECT_SEND_EVENT
&Spell::EffectPowerBurn, // 62 SPELL_EFFECT_POWER_BURN
&Spell::EffectThreat, // 63 SPELL_EFFECT_THREAT
&Spell::EffectTriggerSpell, // 64 SPELL_EFFECT_TRIGGER_SPELL
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
&Spell::EffectUnused, // 65 SPELL_EFFECT_APPLY_AREA_AURA_RAID
Core/Spells: Renamed SPELL_EFFECT_CREATE_MANA_GEM to SPELL_EFFECT_RECHARGE_ITEM
2017-07-29 18:01:12 +02:00
&Spell::EffectRechargeItem, // 66 SPELL_EFFECT_RECHARGE_ITEM
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectHealMaxHealth, // 67 SPELL_EFFECT_HEAL_MAX_HEALTH
&Spell::EffectInterruptCast, // 68 SPELL_EFFECT_INTERRUPT_CAST
&Spell::EffectDistract, // 69 SPELL_EFFECT_DISTRACT
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, // 70 SPELL_EFFECT_COMPLETE_AND_REWARD_WORLD_QUEST
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectPickPocket, // 71 SPELL_EFFECT_PICKPOCKET
&Spell::EffectAddFarsight, // 72 SPELL_EFFECT_ADD_FARSIGHT
Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
2010-12-22 20:14:30 +02:00
&Spell::EffectUntrainTalents, // 73 SPELL_EFFECT_UNTRAIN_TALENTS
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
&Spell::EffectApplyGlyph, // 74 SPELL_EFFECT_APPLY_GLYPH
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectHealMechanical, // 75 SPELL_EFFECT_HEAL_MECHANICAL one spell: Mechanical Patch Kit
&Spell::EffectSummonObjectWild, // 76 SPELL_EFFECT_SUMMON_OBJECT_WILD
&Spell::EffectScriptEffect, // 77 SPELL_EFFECT_SCRIPT_EFFECT
&Spell::EffectUnused, // 78 SPELL_EFFECT_ATTACK
&Spell::EffectSanctuary, // 79 SPELL_EFFECT_SANCTUARY
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, // 80 SPELL_EFFECT_MODIFY_FOLLOWER_ITEM_LEVEL
&Spell::EffectNULL, // 81 SPELL_EFFECT_PUSH_ABILITY_TO_ACTION_BAR
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectNULL, // 82 SPELL_EFFECT_BIND_SIGHT
&Spell::EffectDuel, // 83 SPELL_EFFECT_DUEL
&Spell::EffectStuck, // 84 SPELL_EFFECT_STUCK
&Spell::EffectSummonPlayer, // 85 SPELL_EFFECT_SUMMON_PLAYER
&Spell::EffectActivateObject, // 86 SPELL_EFFECT_ACTIVATE_OBJECT
Core/GameObject: Refactored destructible building handling, properly implemented spell effect repair
2011-07-22 21:22:05 +02:00
&Spell::EffectGameObjectDamage, // 87 SPELL_EFFECT_GAMEOBJECT_DAMAGE
&Spell::EffectGameObjectRepair, // 88 SPELL_EFFECT_GAMEOBJECT_REPAIR
&Spell::EffectGameObjectSetDestructionState, // 89 SPELL_EFFECT_GAMEOBJECT_SET_DESTRUCTION_STATE
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
&Spell::EffectKillCreditPersonal, // 90 SPELL_EFFECT_KILL_CREDIT Kill credit but only for single person
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, // 91 SPELL_EFFECT_THREAT_ALL
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectEnchantHeldItem, // 92 SPELL_EFFECT_ENCHANT_HELD_ITEM
Change SPELL_EFFECT_SUMMON_PHANTAS to SPELL_EFFECT_FORCE_DESELECT and allow it to be casted with active pet
2010-01-13 10:27:44 +01:00
&Spell::EffectForceDeselect, // 93 SPELL_EFFECT_FORCE_DESELECT
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectSelfResurrect, // 94 SPELL_EFFECT_SELF_RESURRECT
&Spell::EffectSkinning, // 95 SPELL_EFFECT_SKINNING
*Fix broken charge spells.
2009-05-04 12:11:54 -05:00
&Spell::EffectCharge, // 96 SPELL_EFFECT_CHARGE
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
&Spell::EffectCastButtons, // 97 SPELL_EFFECT_CAST_BUTTON (totem bar since 3.2.2a)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectKnockBack, // 98 SPELL_EFFECT_KNOCK_BACK
&Spell::EffectDisEnchant, // 99 SPELL_EFFECT_DISENCHANT
&Spell::EffectInebriate, //100 SPELL_EFFECT_INEBRIATE
&Spell::EffectFeedPet, //101 SPELL_EFFECT_FEED_PET
&Spell::EffectDismissPet, //102 SPELL_EFFECT_DISMISS_PET
&Spell::EffectReputation, //103 SPELL_EFFECT_REPUTATION
&Spell::EffectSummonObject, //104 SPELL_EFFECT_SUMMON_OBJECT_SLOT1
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //105 SPELL_EFFECT_SURVEY
Core/PacketsIO: Implemented or updated most of party related packets.
2015-05-19 02:55:53 +01:00
&Spell::EffectChangeRaidMarker, //106 SPELL_EFFECT_CHANGE_RAID_MARKER
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //107 SPELL_EFFECT_SHOW_CORPSE_LOOT
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectDispelMechanic, //108 SPELL_EFFECT_DISPEL_MECHANIC
Core/Spells: Rename Spell::EffectSummonDeadPet with Spell::EffectResurrectPet and get rid of two TODO's that are already done.
2014-01-17 17:54:52 +01:00
&Spell::EffectResurrectPet, //109 SPELL_EFFECT_RESURRECT_PET
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectDestroyAllTotems, //110 SPELL_EFFECT_DESTROY_ALL_TOTEMS
&Spell::EffectDurabilityDamage, //111 SPELL_EFFECT_DURABILITY_DAMAGE
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //112 SPELL_EFFECT_112
Core/Spells: Implemented SPELL_EFFECT_CANCEL_CONVERSATION (#27037)
2021-10-11 14:50:04 +02:00
&Spell::EffectCancelConversation, //113 SPELL_EFFECT_CANCEL_CONVERSATION
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTaunt, //114 SPELL_EFFECT_ATTACK_ME
&Spell::EffectDurabilityDamagePCT, //115 SPELL_EFFECT_DURABILITY_DAMAGE_PCT
&Spell::EffectSkinPlayerCorpse, //116 SPELL_EFFECT_SKIN_PLAYER_CORPSE one spell: Remove Insignia, bg usage, required special corpse flags...
&Spell::EffectSpiritHeal, //117 SPELL_EFFECT_SPIRIT_HEAL one spell: Spirit Heal
&Spell::EffectSkill, //118 SPELL_EFFECT_SKILL professions and more
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
&Spell::EffectUnused, //119 SPELL_EFFECT_APPLY_AREA_AURA_PET
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //120 SPELL_EFFECT_TELEPORT_GRAVEYARD
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectWeaponDmg, //121 SPELL_EFFECT_NORMALIZED_WEAPON_DMG
&Spell::EffectUnused, //122 SPELL_EFFECT_122 unused
&Spell::EffectSendTaxi, //123 SPELL_EFFECT_SEND_TAXI taxi/flight related (misc value is taxi path id)
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
&Spell::EffectPullTowards, //124 SPELL_EFFECT_PULL_TOWARDS
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectModifyThreatPercent, //125 SPELL_EFFECT_MODIFY_THREAT_PERCENT
&Spell::EffectStealBeneficialBuff, //126 SPELL_EFFECT_STEAL_BENEFICIAL_BUFF spell steal effect?
&Spell::EffectProspecting, //127 SPELL_EFFECT_PROSPECTING Prospecting spell
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
&Spell::EffectUnused, //128 SPELL_EFFECT_APPLY_AREA_AURA_FRIEND
&Spell::EffectUnused, //129 SPELL_EFFECT_APPLY_AREA_AURA_ENEMY
*Fix misdirection.
2008-12-17 20:07:25 -06:00
&Spell::EffectRedirectThreat, //130 SPELL_EFFECT_REDIRECT_THREAT
Core/Spells: Rename SPELL_EFFECT_PLAYER_NOTIFICATION to SPELL_EFFECT_PLAY_SOUND
2013-01-03 17:58:56 +01:00
&Spell::EffectPlaySound, //131 SPELL_EFFECT_PLAY_SOUND sound id in misc value (SoundEntries.dbc)
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
&Spell::EffectPlayMusic, //132 SPELL_EFFECT_PLAY_MUSIC sound id in misc value (SoundEntries.dbc)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectUnlearnSpecialization, //133 SPELL_EFFECT_UNLEARN_SPECIALIZATION unlearn profession specialization
&Spell::EffectKillCredit, //134 SPELL_EFFECT_KILL_CREDIT misc value is creature entry
&Spell::EffectNULL, //135 SPELL_EFFECT_CALL_PET
&Spell::EffectHealPct, //136 SPELL_EFFECT_HEAL_PCT
* Fix bug that potions and other energize effects make client display twice as much of a gain, by nos4r2zod.
2009-06-08 21:19:34 +02:00
&Spell::EffectEnergizePct, //137 SPELL_EFFECT_ENERGIZE_PCT
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
&Spell::EffectLeapBack, //138 SPELL_EFFECT_LEAP_BACK Leap back
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
&Spell::EffectQuestClear, //139 SPELL_EFFECT_CLEAR_QUEST Reset quest status (miscValue - quest ID)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectForceCast, //140 SPELL_EFFECT_FORCE_CAST
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
&Spell::EffectForceCast, //141 SPELL_EFFECT_FORCE_CAST_WITH_VALUE
&Spell::EffectTriggerSpell, //142 SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
&Spell::EffectUnused, //143 SPELL_EFFECT_APPLY_AREA_AURA_OWNER
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
&Spell::EffectKnockBack, //144 SPELL_EFFECT_KNOCK_BACK_DEST
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
&Spell::EffectPullTowards, //145 SPELL_EFFECT_PULL_TOWARDS_DEST Black Hole Effect
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //146 SPELL_EFFECT_RESTORE_GARRISON_TROOP_VITALITY
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectQuestFail, //147 SPELL_EFFECT_QUEST_FAIL quest fail
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
&Spell::EffectTriggerMissileSpell, //148 SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE
*Rename SPELL_EFFECT_CHARGE_2 to SPELL_EFFECT_CHARGE_DEST, fix its implementation.
2010-07-19 19:22:05 +02:00
&Spell::EffectChargeDest, //149 SPELL_EFFECT_CHARGE_DEST
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
&Spell::EffectQuestStart, //150 SPELL_EFFECT_QUEST_START
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTriggerRitualOfSummoning, //151 SPELL_EFFECT_TRIGGER_SPELL_2
Core/Refer-a-Friend: Finish base work for Refer-a-Friend.
2011-08-03 09:28:12 -07:00
&Spell::EffectSummonRaFFriend, //152 SPELL_EFFECT_SUMMON_RAF_FRIEND summon Refer-a-Friend
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
&Spell::EffectCreateTamedPet, //153 SPELL_EFFECT_CREATE_TAMED_PET misc value is creature entry
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
&Spell::EffectDiscoverTaxi, //154 SPELL_EFFECT_DISCOVER_TAXI
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
&Spell::EffectTitanGrip, //155 SPELL_EFFECT_TITAN_GRIP Allows you to equip two-handed axes, maces and swords in one hand, but you attack $49152s1% slower than normal.
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
&Spell::EffectEnchantItemPrismatic, //156 SPELL_EFFECT_ENCHANT_ITEM_PRISMATIC
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
&Spell::EffectCreateItem2, //157 SPELL_EFFECT_CREATE_ITEM_2 create item or create item template and replace by some randon spell loot item
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
&Spell::EffectMilling, //158 SPELL_EFFECT_MILLING milling
*Switch to support client version 3.1.3
2009-06-11 00:45:59 -05:00
&Spell::EffectRenamePet, //159 SPELL_EFFECT_ALLOW_RENAME_PET allow rename pet once again
Core/Spells: enabled SPELL_EFFECT_160 (#16987)
2016-04-16 15:24:57 +02:00
&Spell::EffectForceCast, //160 SPELL_EFFECT_FORCE_CAST_2
Core/Players: Updated talent specializations
2016-06-09 21:33:18 +02:00
&Spell::EffectNULL, //161 SPELL_EFFECT_TALENT_SPEC_COUNT second talent spec (learn/revert)
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
&Spell::EffectActivateSpec, //162 SPELL_EFFECT_TALENT_SPEC_SELECT activate primary/secondary spec
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //163 SPELL_EFFECT_OBLITERATE_ITEM
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
&Spell::EffectRemoveAura, //164 SPELL_EFFECT_REMOVE_AURA
Core/Spells: Implemented effect SPELL_EFFECT_DAMAGE_FROM_MAX_HEALTH_PCT
2012-12-31 02:10:04 +01:00
&Spell::EffectDamageFromMaxHealthPCT, //165 SPELL_EFFECT_DAMAGE_FROM_MAX_HEALTH_PCT
Core/Spells: Implemented SPELL_EFFECT_GIVE_CURRENCY.
2013-01-01 17:48:09 +01:00
&Spell::EffectGiveCurrency, //166 SPELL_EFFECT_GIVE_CURRENCY
Core/Spells: Implemented spell effects SPELL_EFFECT_UPDATE_PLAYER_PHASE and SPELL_EFFECT_UPDATE_ZONE_AURAS_AND_PHASES (#16957)
2016-04-13 20:24:51 +02:00
&Spell::EffectUpdatePlayerPhase, //167 SPELL_EFFECT_UPDATE_PLAYER_PHASE
Core/Spells: Define some new spell effects
2015-01-05 14:58:17 +02:00
&Spell::EffectNULL, //168 SPELL_EFFECT_ALLOW_CONTROL_PET
Core/Spells: implemented SPELL_EFFECT_DESTROY_ITEM
2015-04-06 14:01:39 +02:00
&Spell::EffectDestroyItem, //169 SPELL_EFFECT_DESTROY_ITEM
Core/Spells: Implemented spell effects SPELL_EFFECT_UPDATE_PLAYER_PHASE and SPELL_EFFECT_UPDATE_ZONE_AURAS_AND_PHASES (#16957)
2016-04-13 20:24:51 +02:00
&Spell::EffectUpdateZoneAurasAndPhases, //170 SPELL_EFFECT_UPDATE_ZONE_AURAS_AND_PHASES
Core/Spells: Implemented summoning a personal gameobject effect (#25917)
2021-01-23 17:44:47 +02:00
&Spell::EffectSummonPersonalGameObject, //171 SPELL_EFFECT_SUMMON_PERSONAL_GAMEOBJECT
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
&Spell::EffectResurrectWithAura, //172 SPELL_EFFECT_RESURRECT_WITH_AURA
Core/Guilds: Fixed 7th and 8th guild bault tabs.
2013-07-06 15:03:23 +02:00
&Spell::EffectUnlockGuildVaultTab, //173 SPELL_EFFECT_UNLOCK_GUILD_VAULT_TAB
Core/Spells: Assign spell effect handles for new apply aura effects
2020-06-22 11:04:57 +02:00
&Spell::EffectApplyAura, //174 SPELL_EFFECT_APPLY_AURA_ON_PET
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //175 SPELL_EFFECT_175
Core/Spells: Fixed Stealth and Vanish
2016-04-29 21:21:58 +02:00
&Spell::EffectSanctuary, //176 SPELL_EFFECT_SANCTUARY_2
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //177 SPELL_EFFECT_DESPAWN_PERSISTENT_AREA_AURA
Core/Misc: Use the proper EffectUnused handler for unused spell effects
2012-08-18 13:39:41 -05:00
&Spell::EffectUnused, //178 SPELL_EFFECT_178 unused
Core/Spells: Implement SPELL_EFFECT_CREATE_AREATRIGGER (effect #179)
2013-05-26 04:47:10 +03:00
&Spell::EffectCreateAreaTrigger, //179 SPELL_EFFECT_CREATE_AREATRIGGER
Core/Spells: Define some new spell effects
2015-01-05 14:58:17 +02:00
&Spell::EffectNULL, //180 SPELL_EFFECT_UPDATE_AREATRIGGER
Core/Spells: Reimplemented automatic spell learning
2015-01-30 23:58:16 +01:00
&Spell::EffectRemoveTalent, //181 SPELL_EFFECT_REMOVE_TALENT
Core/Spells: Renamed some old and new spell effects
2016-08-09 17:21:19 +02:00
&Spell::EffectNULL, //182 SPELL_EFFECT_DESPAWN_AREATRIGGER
Core/Spells: added missing spell effect handler placeholders
2014-11-30 16:51:47 +01:00
&Spell::EffectNULL, //183 SPELL_EFFECT_183
Core/Spells: Define some new spell effects
2015-01-05 14:58:17 +02:00
&Spell::EffectNULL, //184 SPELL_EFFECT_REPUTATION
Core/Spells: added missing spell effect handler placeholders
2014-11-30 16:51:47 +01:00
&Spell::EffectNULL, //185 SPELL_EFFECT_185
&Spell::EffectNULL, //186 SPELL_EFFECT_186
Core/Spells: Define some new spell effects
2015-01-05 14:58:17 +02:00
&Spell::EffectNULL, //187 SPELL_EFFECT_RANDOMIZE_ARCHAEOLOGY_DIGSITES
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //188 SPELL_EFFECT_SUMMON_STABLED_PET_AS_GUARDIAN
Core/Spells: Define some new spell effects
2015-01-05 14:58:17 +02:00
&Spell::EffectNULL, //189 SPELL_EFFECT_LOOT
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //190 SPELL_EFFECT_CHANGE_PARTY_MEMBERS
Core/Spells: Define some new spell effects
2015-01-05 14:58:17 +02:00
&Spell::EffectNULL, //191 SPELL_EFFECT_TELEPORT_TO_DIGSITE
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
&Spell::EffectUncageBattlePet, //192 SPELL_EFFECT_UNCAGE_BATTLEPET
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //193 SPELL_EFFECT_START_PET_BATTLE
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectUnused, //194 SPELL_EFFECT_194
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
&Spell::EffectPlaySceneScriptPackage, //195 SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE
Core/Scenes: Implemented spell created SceneObjects
2021-10-11 12:59:19 +02:00
&Spell::EffectCreateSceneObject, //196 SPELL_EFFECT_CREATE_SCENE_OBJECT
&Spell::EffectCreatePrivateSceneObject, //197 SPELL_EFFECT_CREATE_PERSONAL_SCENE_OBJECT
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE (#19836)
2017-06-04 15:07:34 +02:00
&Spell::EffectPlayScene, //198 SPELL_EFFECT_PLAY_SCENE
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //199 SPELL_EFFECT_DESPAWN_SUMMON
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
&Spell::EffectHealBattlePetPct, //200 SPELL_EFFECT_HEAL_BATTLEPET_PCT
&Spell::EffectEnableBattlePets, //201 SPELL_EFFECT_ENABLE_BATTLE_PETS
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
&Spell::EffectUnused, //202 SPELL_EFFECT_APPLY_AREA_AURA_SUMMONS
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectRemoveAura, //203 SPELL_EFFECT_REMOVE_AURA_2
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //204 SPELL_EFFECT_CHANGE_BATTLEPET_QUALITY
Core/Quests: Implemented player choices
2017-12-17 14:40:04 +01:00
&Spell::EffectLaunchQuestChoice, //205 SPELL_EFFECT_LAUNCH_QUEST_CHOICE
Core/Spells: Define SPELL_EFFECT_ALTER_ITEM
2016-06-02 17:07:07 +03:00
&Spell::EffectNULL, //206 SPELL_EFFECT_ALTER_ITEM
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //207 SPELL_EFFECT_LAUNCH_QUEST_TASK
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //208 SPELL_EFFECT_SET_REPUTATION
&Spell::EffectUnused, //209 SPELL_EFFECT_209
Core/Garrisons: Basics for garrisons
2015-05-08 00:03:15 +02:00
&Spell::EffectLearnGarrisonBuilding, //210 SPELL_EFFECT_LEARN_GARRISON_BUILDING
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //211 SPELL_EFFECT_LEARN_GARRISON_SPECIALIZATION
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //212 SPELL_EFFECT_REMOVE_AURA_BY_SPELL_LABEL
&Spell::EffectJumpDest, //213 SPELL_EFFECT_JUMP_DEST_2
Core/Garrisons: Basics for garrisons
2015-05-08 00:03:15 +02:00
&Spell::EffectCreateGarrison, //214 SPELL_EFFECT_CREATE_GARRISON
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //215 SPELL_EFFECT_UPGRADE_CHARACTER_SPELLS
&Spell::EffectNULL, //216 SPELL_EFFECT_CREATE_SHIPMENT
&Spell::EffectNULL, //217 SPELL_EFFECT_UPGRADE_GARRISON
Core/Spells: added missing spell effect handler placeholders
2014-11-30 16:51:47 +01:00
&Spell::EffectNULL, //218 SPELL_EFFECT_218
Core/Entities : Basic Conversation Implementation (#18010)
2017-05-14 11:40:55 +02:00
&Spell::EffectCreateConversation, //219 SPELL_EFFECT_CREATE_CONVERSATION
Core/Garrisons: Initial work on garrison followers
2015-05-17 18:06:28 +02:00
&Spell::EffectAddGarrisonFollower, //220 SPELL_EFFECT_ADD_GARRISON_FOLLOWER
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //221 SPELL_EFFECT_ADD_GARRISON_MISSION
Core/Player: implemented Heirloom Collection
2015-10-16 22:54:46 +02:00
&Spell::EffectCreateHeirloomItem, //222 SPELL_EFFECT_CREATE_HEIRLOOM_ITEM
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //223 SPELL_EFFECT_CHANGE_ITEM_BONUSES
Core/Garrisons: Implemented activating buildings
2015-06-22 00:02:02 +02:00
&Spell::EffectActivateGarrisonBuilding, //224 SPELL_EFFECT_ACTIVATE_GARRISON_BUILDING
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //225 SPELL_EFFECT_GRANT_BATTLEPET_LEVEL
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //226 SPELL_EFFECT_TRIGGER_ACTION_SET
Core/Spells: Defined new spell effect names
2016-07-30 00:11:44 +02:00
&Spell::EffectNULL, //227 SPELL_EFFECT_TELEPORT_TO_LFG_DUNGEON
Core/Spells: added missing spell effect handler placeholders
2014-11-30 16:51:47 +01:00
&Spell::EffectNULL, //228 SPELL_EFFECT_228
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //229 SPELL_EFFECT_SET_FOLLOWER_QUALITY
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //230 SPELL_EFFECT_230
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //231 SPELL_EFFECT_INCREASE_FOLLOWER_EXPERIENCE
&Spell::EffectNULL, //232 SPELL_EFFECT_REMOVE_PHASE
&Spell::EffectNULL, //233 SPELL_EFFECT_RANDOMIZE_FOLLOWER_ABILITIES
Core/Spells: added missing spell effect handler placeholders
2014-11-30 16:51:47 +01:00
&Spell::EffectNULL, //234 SPELL_EFFECT_234
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectUnused, //235 SPELL_EFFECT_235
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //236 SPELL_EFFECT_GIVE_EXPERIENCE
&Spell::EffectNULL, //237 SPELL_EFFECT_GIVE_RESTED_EXPERIENCE_BONUS
&Spell::EffectNULL, //238 SPELL_EFFECT_INCREASE_SKILL
&Spell::EffectNULL, //239 SPELL_EFFECT_END_GARRISON_BUILDING_CONSTRUCTION
Core/Items: Implemented artifacts
2016-08-15 00:03:38 +02:00
&Spell::EffectGiveArtifactPower, //240 SPELL_EFFECT_GIVE_ARTIFACT_POWER
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectUnused, //241 SPELL_EFFECT_241
Core/Items: Implemented artifacts
2016-08-15 00:03:38 +02:00
&Spell::EffectGiveArtifactPowerNoBonus, //242 SPELL_EFFECT_GIVE_ARTIFACT_POWER_NO_BONUS
Core/Spells: Implemented spell effect 243 - SPELL_EFFECT_APPLY_ENCHANT_ILLUSION (and fixed enchant visuals, for real this time)
2016-04-07 21:36:36 +02:00
&Spell::EffectApplyEnchantIllusion, //243 SPELL_EFFECT_APPLY_ENCHANT_ILLUSION
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //244 SPELL_EFFECT_LEARN_FOLLOWER_ABILITY
Core/Player: implemented Heirloom Collection
2015-10-16 22:54:46 +02:00
&Spell::EffectUpgradeHeirloom, //245 SPELL_EFFECT_UPGRADE_HEIRLOOM
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //246 SPELL_EFFECT_FINISH_GARRISON_MISSION
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //247 SPELL_EFFECT_ADD_GARRISON_MISSION_SET
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //248 SPELL_EFFECT_FINISH_SHIPMENT
Core/Spells: Renamed some old and new spell effects
2016-08-09 17:21:19 +02:00
&Spell::EffectNULL, //249 SPELL_EFFECT_FORCE_EQUIP_ITEM
Core/Spells: Defined names for some new spell effects
2015-05-05 00:47:17 +02:00
&Spell::EffectNULL, //250 SPELL_EFFECT_TAKE_SCREENSHOT
Core/PacketIO: Updated spell packets
2015-07-18 00:45:21 +02:00
&Spell::EffectNULL, //251 SPELL_EFFECT_SET_GARRISON_CACHE_SIZE
Core/Spells: Defined new spell effect names
2016-07-30 00:11:44 +02:00
&Spell::EffectTeleportUnits, //252 SPELL_EFFECT_TELEPORT_UNITS
Core/Players: Implement basics for the honor system
2017-06-04 16:51:47 +02:00
&Spell::EffectGiveHonor, //253 SPELL_EFFECT_GIVE_HONOR
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //254 SPELL_EFFECT_JUMP_CHARGE
Core/Transmog: Implemented transmog sets
2017-08-24 20:39:22 +02:00
&Spell::EffectLearnTransmogSet, //255 SPELL_EFFECT_LEARN_TRANSMOG_SET
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectUnused, //256 SPELL_EFFECT_256
&Spell::EffectUnused, //257 SPELL_EFFECT_257
Core/Spells: Add missing spell and aura effect handler array entries
2019-02-04 16:47:41 +01:00
&Spell::EffectNULL, //258 SPELL_EFFECT_MODIFY_KEYSTONE
Core/Items: Implement azerite empowered items
2019-12-05 00:12:35 +01:00
&Spell::EffectRespecAzeriteEmpoweredItem, //259 SPELL_EFFECT_RESPEC_AZERITE_EMPOWERED_ITEM
Core/Spells: Add missing spell and aura effect handler array entries
2019-02-04 16:47:41 +01:00
&Spell::EffectNULL, //260 SPELL_EFFECT_SUMMON_STABLED_PET
&Spell::EffectNULL, //261 SPELL_EFFECT_SCRAP_ITEM
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectUnused, //262 SPELL_EFFECT_262
Core/DataStores: Updated db2 structures to 8.1.5
2019-06-08 13:19:48 +02:00
&Spell::EffectNULL, //263 SPELL_EFFECT_REPAIR_ITEM
&Spell::EffectNULL, //264 SPELL_EFFECT_REMOVE_GEM
Core/Items: Implement azerite essences
2019-11-22 11:02:04 +01:00
&Spell::EffectLearnAzeriteEssencePower, //265 SPELL_EFFECT_LEARN_AZERITE_ESSENCE_POWER
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //266 SPELL_EFFECT_SET_ITEM_BONUS_LIST_GROUP_ENTRY
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
&Spell::EffectCreatePrivateConversation, //267 SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
Core/Spells: Fixed crash when casting spells with effect type > 264
2019-11-21 13:58:58 +01:00
&Spell::EffectNULL, //268 SPELL_EFFECT_APPLY_MOUNT_EQUIPMENT
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //269 SPELL_EFFECT_INCREASE_ITEM_BONUS_LIST_GROUP_STEP
Core/Spells: Fixed crash when casting spells with effect type > 264
2019-11-21 13:58:58 +01:00
&Spell::EffectNULL, //270 SPELL_EFFECT_270
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
&Spell::EffectUnused, //271 SPELL_EFFECT_APPLY_AREA_AURA_PARTY_NONRANDOM
Core/DataStores: Updated db2 structures to 9.0.2
2020-12-01 21:08:06 +01:00
&Spell::EffectNULL, //272 SPELL_EFFECT_SET_COVENANT
&Spell::EffectNULL, //273 SPELL_EFFECT_CRAFT_RUNEFORGE_LEGENDARY
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectUnused, //274 SPELL_EFFECT_274
&Spell::EffectUnused, //275 SPELL_EFFECT_275
Core/DataStores: Updated db2 structures to 9.0.2
2020-12-01 21:08:06 +01:00
&Spell::EffectNULL, //276 SPELL_EFFECT_LEARN_TRANSMOG_ILLUSION
&Spell::EffectNULL, //277 SPELL_EFFECT_SET_CHROMIE_TIME
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //278 SPELL_EFFECT_278
Core/DataStores: Updated db2 structures to 9.0.2
2020-12-01 21:08:06 +01:00
&Spell::EffectNULL, //279 SPELL_EFFECT_LEARN_GARR_TALENT
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectUnused, //280 SPELL_EFFECT_280
Core/DataStores: Updated db2 structures to 9.0.2
2020-12-01 21:08:06 +01:00
&Spell::EffectNULL, //281 SPELL_EFFECT_LEARN_SOULBIND_CONDUIT
&Spell::EffectNULL, //282 SPELL_EFFECT_CONVERT_ITEMS_TO_CURRENCY
Core/Spells: Updated spell effect type definitions to match latest client version
2021-03-04 20:30:50 +01:00
&Spell::EffectNULL, //283 SPELL_EFFECT_COMPLETE_CAMPAIGN
Core/DataStores: 9.1.0 db2 structures
2021-08-07 19:40:34 +02:00
&Spell::EffectSendChatMessage, //284 SPELL_EFFECT_SEND_CHAT_MESSAGE
&Spell::EffectNULL, //285 SPELL_EFFECT_MODIFY_KEYSTONE_2
Core/DataStores: Updated db2 structures to 9.1.5
2021-11-01 22:17:12 +01:00
&Spell::EffectNULL, //286 SPELL_EFFECT_GRANT_BATTLEPET_EXPERIENCE
&Spell::EffectNULL, //287 SPELL_EFFECT_SET_GARRISON_FOLLOWER_LEVEL
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
};
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectNULL()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "WORLD: Spell Effect DUMMY");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUnused()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
A great purge of obsolete macros.
2010-02-05 00:31:28 +01:00
// NOT USED BY ANY SPELL OR USELESS OR IMPLEMENTED IN DIFFERENT WAY IN TRINITY
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectResurrectNew()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->IsInWorld())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
REPO: Code-style clean-ups
2011-10-07 19:45:43 -05:00
Player* target = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
2014-05-25 21:52:27 +02:00
if (target->IsResurrectRequested()) // already have one active request
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 health = damage;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 mana = effectInfo->MiscValue;
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectResurrect(SpellEffectName(effectInfo->Effect), target);
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
target->SetResurrectRequestData(m_caster, health, mana, 0);
REPO: Code-style clean-ups
2011-10-07 19:45:43 -05:00
SendResurrectRequest(target);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectInstaKill()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Commands: Fix .cheat kill and add instakill immunity to it
2012-09-01 00:36:26 +01:00
if (unitTarget->GetTypeId() == TYPEID_PLAYER)
if (unitTarget->ToPlayer()->GetCommandStatus(CHEAT_GOD))
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster == unitTarget) // prevent interrupt message
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
finish();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/PacketIO: updated structure of CMSG_RESET_INSTANCES, SMSG_INSTANCE_RESET, SMSG_INSTANCE_RESET_FAILED and SMSG_SPELL_INSTAKILL_LOG
2015-06-07 17:08:45 +02:00
WorldPackets::CombatLog::SpellInstakillLog data;
data.Target = unitTarget->GetGUID();
data.Caster = m_caster->GetGUID();
data.SpellID = m_spellInfo->Id;
m_caster->SendMessageToSet(data.Write(), true);
*Send SMSG_SPELLINSTAKILLLOG on SPELL_EFFECT_INSTAKILL(1), thanks to Zor for base packet info.
2010-08-28 00:30:07 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Unit::DealDamage(unitCaster, unitTarget, unitTarget->GetHealth(), nullptr, NODAMAGE, SPELL_SCHOOL_MASK_NORMAL, nullptr, false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnvironmentalDMG()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive())
Core/Spells: Use correct spell target in Spell::EffectEnvirinmentalDMG - fixes area damage of spells using this.
2011-07-27 21:23:15 +02:00
return;
Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks
2016-10-26 02:16:11 -03:00
// CalcAbsorbResist already in Player::EnvironmentalDamage
Core/Spells: Use correct spell target in Spell::EffectEnvirinmentalDMG - fixes area damage of spells using this.
2011-07-27 21:23:15 +02:00
if (unitTarget->GetTypeId() == TYPEID_PLAYER)
Core/PacketIO: Exclude DamageDealt/DamageTaken script hook results from damage sent in SMSG_SPELL_NON_MELEE_DAMAGE_LOG
2015-08-10 17:46:31 +02:00
unitTarget->ToPlayer()->EnvironmentalDamage(DAMAGE_FIRE, damage);
Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks
2016-10-26 02:16:11 -03:00
else
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
DamageInfo damageInfo(unitCaster, unitTarget, damage, m_spellInfo, m_spellInfo->GetSchoolMask(), SPELL_DIRECT_DAMAGE, BASE_ATTACK);
Core/Auras: removed caster dependency from core
2018-01-13 06:45:21 -03:00
Unit::CalcAbsorbResist(damageInfo);
Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks
2016-10-26 02:16:11 -03:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
SpellNonMeleeDamage log(unitCaster, unitTarget, m_spellInfo, m_SpellVisual, m_spellInfo->GetSchoolMask(), m_castId);
Core/PacketIO: Updated packet structures to 8.0.1
2018-10-04 18:50:21 +02:00
log.damage = damageInfo.GetDamage();
log.originalDamage = damage;
Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks
2016-10-26 02:16:11 -03:00
log.absorb = damageInfo.GetAbsorb();
log.resist = damageInfo.GetResist();
Core/PacketIO: Implemented advanced combat logging
2015-08-08 15:15:14 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster)
unitCaster->SendSpellNonMeleeDamageLog(&log);
Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks
2016-10-26 02:16:11 -03:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSchoolDMG()
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
Core/Spells: Fixed typo breaking SPELL_AURA_MOD_AOE_DAMAGE_AVOIDANCE and SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE
2011-10-06 14:22:11 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (unitTarget && unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core: Fix many "errors"/warnings and coding style (3)
2012-08-30 22:44:33 +01:00
bool apply_direct_bonus = true;
Core/Spells: SPELL_ATTR0_CU_SHARE_DAMAGE no longer depend on SpellFamily
2017-01-01 03:05:33 +01:00
// Meteor like spells (divided damage to targets)
if (m_spellInfo->HasAttribute(SPELL_ATTR0_CU_SHARE_DAMAGE))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: SPELL_ATTR0_CU_SHARE_DAMAGE no longer depend on SpellFamily
2017-01-01 03:05:33 +01:00
// divide to all targets
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
if (int64 count = GetUnitTargetCountForEffect(SpellEffIndex(effectInfo->EffectIndex)))
Core/Spells: SPELL_ATTR0_CU_SHARE_DAMAGE no longer depend on SpellFamily
2017-01-01 03:05:33 +01:00
damage /= count;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: SPELL_ATTR0_CU_SHARE_DAMAGE no longer depend on SpellFamily
2017-01-01 03:05:33 +01:00
switch (m_spellInfo->SpellFamilyName)
{
case SPELLFAMILY_GENERIC:
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
///@todo: move those to scripts
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (m_spellInfo->Id) // better way to check unknown
[svn] Add SpellExtraInfoMap. Currently support:
2008-10-25 15:46:52 -05:00
{
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
// Consumption
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 28865:
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
damage = 2750;
if (m_caster->GetMap()->IsHeroic())
damage = 4250;
*Add some scripted spells for naxx.
2009-05-18 15:04:05 -05:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// percent from health with min
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 25599: // Thundercrash
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
damage = unitTarget->GetHealth() / 2;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage < 200)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
damage = 200;
break;
}
*Fix arcane charge.
2008-11-24 15:15:09 -06:00
// arcane charge. must only affect demons (also undead?)
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 45072:
[svn] Fix spell 45072: should only affect demons.
2008-10-19 14:47:43 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!(unitTarget->GetCreatureTypeMask() & CREATURE_TYPEMASK_DEMON_OR_UNDEAD))
[svn] Fix spell 45072: should only affect demons.
2008-10-19 14:47:43 -05:00
return;
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
case SPELLFAMILY_WARRIOR:
{
break;
}
case SPELLFAMILY_WARLOCK:
{
break;
}
*Update to Mangos 6982.
2008-12-29 17:27:50 -06:00
case SPELLFAMILY_PRIEST:
{
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case SPELLFAMILY_DRUID:
{
break;
}
*Fix Improved Moonkin Form and Blood Boil disease bonus.
2009-07-06 00:51:50 +02:00
case SPELLFAMILY_DEATHKNIGHT:
{
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster && apply_direct_bonus)
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
{
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
uint32 bonus = unitCaster->SpellDamageBonusDone(unitTarget, m_spellInfo, (uint32)damage, SPELL_DIRECT_DAMAGE, *effectInfo);
Core/Spells: Implemented varying damage for spells with no base value
2014-12-19 18:55:09 +01:00
damage = bonus + uint32(bonus * variance);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
damage = unitTarget->SpellDamageBonusTaken(unitCaster, m_spellInfo, (uint32)damage, SPELL_DIRECT_DAMAGE);
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix the bug that some spells have too high damage.
2009-01-10 09:29:22 -06:00
m_damage += damage;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDummy()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (!unitTarget && !gameObjTarget && !itemTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// pet auras
Core/Entities: moved PetAura handling to Player where it belongs
2017-04-28 18:11:23 -03:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
if (PetAura const* petSpell = sSpellMgr->GetPetAura(m_spellInfo->Id, effectInfo->EffectIndex))
Core/Entities: moved PetAura handling to Player where it belongs
2017-04-28 18:11:23 -03:00
{
m_caster->ToPlayer()->AddPetAura(petSpell);
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Modified spell_scripts table, it is now possible to add different scripts for each spell effect
2010-07-24 21:51:25 +02:00
// normal DB scripted effect
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
TC_LOG_DEBUG("spells", "Spell ScriptStart spellid %u in EffectDummy(%u)", m_spellInfo->Id, effectInfo->EffectIndex);
m_caster->GetMap()->ScriptsStart(sSpellScripts, uint32(m_spellInfo->Id | (effectInfo->EffectIndex << 24)), m_caster, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTriggerSpell()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET
&& effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 triggered_spell_id = effectInfo->TriggerSpell;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo move those to spell scripts
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->Effect == SPELL_EFFECT_TRIGGER_SPELL
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
&& effectHandleMode == SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
{
// special cases
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (triggered_spell_id)
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
{
// Demonic Empowerment -- succubus
case 54437:
{
Implemented binary resistances and some more (#18933)
2017-02-04 23:50:32 +01:00
unitTarget->RemoveMovementImpairingAuras(true);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
unitTarget->RemoveAurasByType(SPELL_AURA_MOD_STALKED);
unitTarget->RemoveAurasByType(SPELL_AURA_MOD_STUN);
// Cast Lesser Invisibility
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(unitTarget, 7870, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
Core/Spells: Fix Vanish's stealth trigger and Demonic Empowerment's invisibility trigger
2011-09-27 00:36:23 +02:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
}
// Brittle Armor - (need add max stack of 24575 Brittle Armor)
case 29284:
{
// Brittle Armor
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spell = sSpellMgr->GetSpellInfo(24575, GetCastDifficulty());
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (!spell)
return;
for (uint32 j = 0; j < spell->StackAmount; ++j)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(unitTarget, spell->Id, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
}
// Mercurial Shield - (need add max stack of 26464 Mercurial Shield)
case 29286:
{
// Mercurial Shield
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spell = sSpellMgr->GetSpellInfo(26464, GetCastDifficulty());
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (!spell)
return;
for (uint32 j = 0; j < spell->StackAmount; ++j)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(unitTarget, spell->Id, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
}
}
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal case
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(triggered_spell_id, GetCastDifficulty());
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Logs: Fine tunning some logs
2016-08-05 21:22:12 +02:00
TC_LOG_ERROR("spells.effecttriggerspell", "Spell::EffectTriggerSpell spell %u tried to trigger unknown spell %u", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
SpellCastTargets targets;
if (effectHandleMode == SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
{
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
if (!spellInfo->NeedsToBeTriggeredByCaster(m_spellInfo))
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
targets.SetUnitTarget(unitTarget);
}
else //if (effectHandleMode == SPELL_EFFECT_HANDLE_LAUNCH)
{
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
if (spellInfo->NeedsToBeTriggeredByCaster(m_spellInfo) && (effectInfo->GetProvidedTargetMask() & TARGET_FLAG_UNIT_MASK))
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (spellInfo->GetExplicitTargetMask() & TARGET_FLAG_DEST_LOCATION)
targets.SetDst(m_targets);
Core/Spell:
2014-01-27 20:26:34 +01:00
if (Unit* target = m_targets.GetUnitTarget())
targets.SetUnitTarget(target);
else
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
{
if (Unit* unit = m_caster->ToUnit())
targets.SetUnitTarget(unit);
else if (GameObject* go = m_caster->ToGameObject())
targets.SetGOTarget(go);
}
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
}
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes
2021-10-03 14:58:35 +02:00
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
args.SetOriginalCaster(m_originalCasterGUID);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// set basepoints for trigger with value effect
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->Effect == SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE)
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
for (uint32 i = 0; i < MAX_SPELL_EFFECTS; ++i)
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SpellValueMod(SPELLVALUE_BASE_POINT0 + i), damage);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// original caster guid only for GO cast
Core/Spells: Reduce number of CastSpell overloads to 1
2021-10-03 19:58:03 +02:00
m_caster->CastSpell(std::move(targets), spellInfo->Id, args);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTriggerMissileSpell()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET
&& effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 triggered_spell_id = effectInfo->TriggerSpell;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// normal case
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(triggered_spell_id, GetCastDifficulty());
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Logs: Fine tunning some logs
2016-08-05 21:22:12 +02:00
TC_LOG_ERROR("spells.effecttrigermissilespell", "Spell::EffectTriggerMissileSpell spell %u tried to trigger unknown spell %u.", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
SpellCastTargets targets;
if (effectHandleMode == SPELL_EFFECT_HANDLE_HIT_TARGET)
{
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
if (!spellInfo->NeedsToBeTriggeredByCaster(m_spellInfo))
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
targets.SetUnitTarget(unitTarget);
}
else //if (effectHandleMode == SPELL_EFFECT_HANDLE_HIT)
{
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
if (spellInfo->NeedsToBeTriggeredByCaster(m_spellInfo) && (effectInfo->GetProvidedTargetMask() & TARGET_FLAG_UNIT_MASK))
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
if (spellInfo->GetExplicitTargetMask() & TARGET_FLAG_DEST_LOCATION)
targets.SetDst(m_targets);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (Unit* unit = m_caster->ToUnit())
targets.SetUnitTarget(unit);
else if (GameObject* go = m_caster->ToGameObject())
targets.SetGOTarget(go);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
}
Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes
2021-10-03 14:58:35 +02:00
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
args.SetOriginalCaster(m_originalCasterGUID);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// set basepoints for trigger with value effect
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->Effect == SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE)
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
for (uint32 i = 0; i < MAX_SPELL_EFFECTS; ++i)
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SpellValueMod(SPELLVALUE_BASE_POINT0 + i), damage);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// original caster guid only for GO cast
Core/Spells: Reduce number of CastSpell overloads to 1
2021-10-03 19:58:03 +02:00
m_caster->CastSpell(std::move(targets), spellInfo->Id, args);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectForceCast()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 triggered_spell_id = effectInfo->TriggerSpell;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal case
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(triggered_spell_id, GetCastDifficulty());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "Spell::EffectForceCast of spell %u: triggering unknown spell id %i.", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->Effect == SPELL_EFFECT_FORCE_CAST && damage)
*better handle effect 140. do not consider bp > 0 as custom damage.
2009-08-15 20:36:21 -05:00
{
Scripts/Icecrown Citadel
2011-01-12 22:50:51 +01:00
switch (m_spellInfo->Id)
*better handle effect 140. do not consider bp > 0 as custom damage.
2009-08-15 20:36:21 -05:00
{
Core/Spells: use spell caster as a target of spells triggered by SPELL_EFFECT_FORCE_CAST
2011-07-07 18:02:04 +02:00
case 52588: // Skeletal Gryphon Escape
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
case 48598: // Ride Flamebringer Cue
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
unitTarget->RemoveAura(damage);
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
break;
case 52463: // Hide In Mine Car
case 52349: // Overtake
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
{
Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes
2021-10-03 14:58:35 +02:00
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
args.SetOriginalCaster(m_originalCasterGUID);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SPELLVALUE_BASE_POINT0, damage);
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
unitTarget->CastSpell(unitTarget, spellInfo->Id, args);
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
return;
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
}
*better handle effect 140. do not consider bp > 0 as custom damage.
2009-08-15 20:36:21 -05:00
}
}
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
Scripts/ICC: fixed Festergut Malleable Goo (thx @ManuFe)
2014-07-23 17:24:50 +02:00
switch (spellInfo->Id)
{
case 72298: // Malleable Goo Summon
Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes
2021-10-03 14:58:35 +02:00
unitTarget->CastSpell(unitTarget, spellInfo->Id, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
.SetOriginalCaster(m_originalCasterGUID)
.SetOriginalCastId(m_castId));
Scripts/ICC: fixed Festergut Malleable Goo (thx @ManuFe)
2014-07-23 17:24:50 +02:00
return;
}
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->Effect == SPELL_EFFECT_FORCE_CAST_WITH_VALUE)
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
for (uint32 i = 0; i < MAX_SPELL_EFFECTS; ++i)
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SpellValueMod(SPELLVALUE_BASE_POINT0 + i), damage);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
unitTarget->CastSpell(m_caster, spellInfo->Id, args);
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTriggerRitualOfSummoning()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 triggered_spell_id = effectInfo->TriggerSpell;
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(triggered_spell_id, GetCastDifficulty());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "EffectTriggerRitualOfSummoning of spell %u: triggering unknown spell id %i.", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
finish();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(nullptr, spellInfo->Id, CastSpellExtraArgs()
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
inline void CalculateJumpSpeeds(SpellEffectInfo const* effInfo, float dist, float& speedXY, float& speedZ)
{
if (effInfo->MiscValue)
speedZ = float(effInfo->MiscValue) / 10;
else if (effInfo->MiscValueB)
speedZ = float(effInfo->MiscValueB) / 10;
else
speedZ = 10.0f;
speedXY = dist * 10.0f / speedZ;
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectJump()
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
if (unitCaster->IsInFlight())
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (!unitTarget)
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
float speedXY, speedZ;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
CalculateJumpSpeeds(effectInfo, unitCaster->GetExactDist2d(unitTarget), speedXY, speedZ);
Core/Movement: Implement SpellEffectExtraData curve modifiers
2017-02-18 21:55:28 +01:00
JumpArrivalCastArgs arrivalCast;
arrivalCast.SpellId = effectInfo->TriggerSpell;
arrivalCast.Target = unitTarget->GetGUID();
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetMotionMaster()->MoveJump(*unitTarget, speedXY, speedZ, EVENT_JUMP, false, &arrivalCast);
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectJumpDest()
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
if (unitCaster->IsInFlight())
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (!m_targets.HasDst())
return;
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
float speedXY, speedZ;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
CalculateJumpSpeeds(effectInfo, unitCaster->GetExactDist2d(destTarget), speedXY, speedZ);
Core/Movement: Implement SpellEffectExtraData curve modifiers
2017-02-18 21:55:28 +01:00
JumpArrivalCastArgs arrivalCast;
arrivalCast.SpellId = effectInfo->TriggerSpell;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetMotionMaster()->MoveJump(*destTarget, speedXY, speedZ, EVENT_JUMP, !m_targets.GetObjectTargetGUID().IsEmpty(), &arrivalCast);
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTeleportUnits()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || unitTarget->IsInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix teleport spells.
2008-11-01 15:08:12 -05:00
// If not exist data for dest location - return
*Add virtual bool IsEscorted() to escort_ai.h
2009-10-30 18:54:38 -07:00
if (!m_targets.HasDst())
[svn] Fix teleport spells.
2008-11-01 15:08:12 -05:00
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "Spell::EffectTeleportUnits - does not have a destination for spellId %u.", m_spellInfo->Id);
*Fix build.
2009-03-09 19:17:12 -06:00
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix build.
2009-03-09 19:17:12 -06:00
// Init dest coordinates
Core/Spells: fix logic error causing near teleports to drop combat for players
2018-02-04 22:47:53 -03:00
WorldLocation targetDest(*destTarget);
if (targetDest.GetMapId() == MAPID_INVALID)
targetDest.m_mapId = unitTarget->GetMapId();
if (!targetDest.GetOrientation() && m_targets.GetUnitTarget())
targetDest.SetOrientation(m_targets.GetUnitTarget()->GetOrientation());
Player* player = unitTarget->ToPlayer();
// Custom loading screen
if (player)
Core/Spell: Implement and use SMSG_CUSTOM_LOAD_SCREEN (#19310)
2017-03-17 18:50:11 +01:00
if (uint32 customLoadingScreenId = effectInfo->MiscValue)
player->SendDirectMessage(WorldPackets::Spells::CustomLoadScreen(m_spellInfo->Id, customLoadingScreenId).Write());
Core/Spells: fix logic error causing near teleports to drop combat for players
2018-02-04 22:47:53 -03:00
if (targetDest.GetMapId() == unitTarget->GetMapId())
unitTarget->NearTeleportTo(targetDest, unitTarget == m_caster);
else if (player)
player->TeleportTo(targetDest, unitTarget == m_caster ? TELE_TO_SPELL : 0);
Core/Transports: Fixed players taking fall damage when teleporting from transports
2013-10-22 17:02:01 +02:00
else
{
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_ERROR("spells", "Spell::EffectTeleportUnits - spellId %u attempted to teleport creature to a different map.", m_spellInfo->Id);
Core/Transports: Fixed players taking fall damage when teleporting from transports
2013-10-22 17:02:01 +02:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: update the core to the changes from 1fb1988d46 . To make your custom code work with those changes simply lookup the value of Targets enum value from prev rev, and update the name in your code.
2011-08-16 19:44:18 +02:00
// post effects for TARGET_DEST_DB
Core/Spells: fix logic error causing near teleports to drop combat for players
2018-02-04 22:47:53 -03:00
/// @todo: awful hacks, move this to spellscripts
*Add virtual bool IsEscorted() to escort_ai.h
2009-10-30 18:54:38 -07:00
switch (m_spellInfo->Id)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Dimensional Ripper - Everlook
case 23442:
{
int32 r = irand(0, 119);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (r >= 70) // 7/12 success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (r < 100) // 4/12 evil twin
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 23445, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else // 1/12 fire
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 23449, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
return;
}
// Ultrasafe Transporter: Toshley's Station
case 36941:
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (roll_chance_i(50)) // 50% success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
int32 rand_eff = urand(1, 7);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
switch (rand_eff)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case 1:
// soul split - evil
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36900, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 2:
// soul split - good
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36901, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 3:
// Increase the size
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36895, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 4:
// Decrease the size
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36893, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 5:
// Transform
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_caster->ToPlayer()->GetTeam() == ALLIANCE)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36897, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36899, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
case 6:
// chicken
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36940, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 7:
// evil twin
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 23445, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
}
return;
}
// Dimensional Ripper - Area 52
case 36890:
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (roll_chance_i(50)) // 50% success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
int32 rand_eff = urand(1, 4);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
switch (rand_eff)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case 1:
// soul split - evil
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36900, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 2:
// soul split - good
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36901, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 3:
// Increase the size
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36895, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 4:
Core/ScriptSystem: Extend SpellScript API by spell focus targets accessors.
2010-10-04 20:32:10 +02:00
// Transform
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_caster->ToPlayer()->GetTeam() == ALLIANCE)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36897, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 36899, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
}
}
return;
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented SPELL_EFFECT_TELEPORT_WITH_SPELL_VISUAL_KIT_LOADING_SCREEN
2021-10-13 11:49:30 +02:00
class DelayedSpellTeleportEvent : public BasicEvent
{
public:
explicit DelayedSpellTeleportEvent(Unit* target, WorldLocation const& targetDest, uint32 options, uint32 spellId)
: _target(target), _targetDest(targetDest), _options(options), _spellId(spellId){ }
bool Execute(uint64 /*e_time*/, uint32 /*p_time*/) override
{
if (_targetDest.GetMapId() == _target->GetMapId())
_target->NearTeleportTo(_targetDest, (_options & TELE_TO_SPELL) != 0);
else if (Player* player = _target->ToPlayer())
player->TeleportTo(_targetDest, _options);
else
TC_LOG_ERROR("spells", "Spell::EffectTeleportUnitsWithVisualLoadingScreen - spellId %u attempted to teleport creature to a different map.", _spellId);
return true;
}
private:
Unit* _target;
WorldLocation _targetDest;
uint32 _options;
uint32 _spellId;
};
void Spell::EffectTeleportUnitsWithVisualLoadingScreen()
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget)
return;
// If not exist data for dest location - return
if (!m_targets.HasDst())
{
TC_LOG_ERROR("spells", "Spell::EffectTeleportUnitsWithVisualLoadingScreen - does not have a destination for spellId %u.", m_spellInfo->Id);
return;
}
// Init dest coordinates
WorldLocation targetDest(*destTarget);
if (targetDest.GetMapId() == MAPID_INVALID)
targetDest.m_mapId = unitTarget->GetMapId();
if (!targetDest.GetOrientation() && m_targets.GetUnitTarget())
targetDest.SetOrientation(m_targets.GetUnitTarget()->GetOrientation());
if (effectInfo->MiscValueB)
if (Player* playerTarget = unitTarget->ToPlayer())
playerTarget->SendDirectMessage(WorldPackets::Spells::SpellVisualLoadScreen(effectInfo->MiscValueB, effectInfo->MiscValue).Write());
unitTarget->m_Events.AddEventAtOffset(new DelayedSpellTeleportEvent(unitTarget, targetDest, unitTarget == m_caster ? TELE_TO_SPELL : 0, m_spellInfo->Id),
Milliseconds(effectInfo->MiscValue));
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectApplyAura()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
if (!_spellAura || !unitTarget)
Update aura system:
2010-01-10 01:23:15 +01:00
return;
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
Core/Spells: register and apply individual aura effects on hit handler
2018-03-10 00:58:48 -03:00
// register target/effect on aura
AuraApplication* aurApp = _spellAura->GetApplicationOfTarget(unitTarget->GetGUID());
if (!aurApp)
aurApp = unitTarget->_CreateAuraApplication(_spellAura, 1 << effectInfo->EffectIndex);
else
aurApp->UpdateApplyEffectMask(aurApp->GetEffectsToApply() | 1 << effectInfo->EffectIndex);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUnlearnSpecialization()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: Fixed compile broken in 11fb0beaf0 and renamed _player to player.
2011-12-10 15:40:55 +01:00
Player* player = unitTarget->ToPlayer();
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 spellToUnlearn = effectInfo->TriggerSpell;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Renamed a few spell and skill line related methods to follow tc coding standards
2014-07-12 17:28:35 +02:00
player->RemoveSpell(spellToUnlearn);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Fourth part of removing GetGUIDLow() uses
2014-10-22 21:22:04 +02:00
TC_LOG_DEBUG("spells", "Spell: %s has unlearned spell %u from %s", player->GetGUID().ToString().c_str(), spellToUnlearn, m_caster->GetGUID().ToString().c_str());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPowerDrain()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->MiscValue < 0 || effectInfo->MiscValue >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
Powers powerType = Powers(effectInfo->MiscValue);
Core/Misc: Added helper function Unit::SetFullPower
2018-01-03 16:39:00 +01:00
if (!unitTarget || !unitTarget->IsAlive() || unitTarget->GetPowerType() != powerType || damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
// add spell damage bonus
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster)
{
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
uint32 bonus = unitCaster->SpellDamageBonusDone(unitTarget, m_spellInfo, uint32(damage), SPELL_DIRECT_DAMAGE, *effectInfo);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
damage = bonus + uint32(bonus * variance);
damage = unitTarget->SpellDamageBonusTaken(unitCaster, m_spellInfo, uint32(damage), SPELL_DIRECT_DAMAGE);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/StatsSystem: Resilience updates.
2012-12-20 19:22:14 +01:00
int32 newDamage = -(unitTarget->ModifyPower(powerType, -damage));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/StatsSystem: Resilience updates.
2012-12-20 19:22:14 +01:00
// Don't restore from self drain
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
float gainMultiplier = 0.f;
if (unitCaster && unitCaster != unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
gainMultiplier = effectInfo->CalcValueMultiplier(unitCaster, this);
int32 const gain = int32(newDamage * gainMultiplier);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->EnergizeBySpell(unitCaster, m_spellInfo, gain, powerType);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectTakeTargetPower(SpellEffectName(effectInfo->Effect), unitTarget, powerType, newDamage, gainMultiplier);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSendEvent()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// we do not handle a flag dropping or clicking on flag in battleground by sendevent system
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET
&& effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Fix EffectSendEvent to work if target is GO or Unit.
2010-01-21 23:57:14 +01:00
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
WorldObject* target = nullptr;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Core/Spells: Use better check for target type in Spell::EffectSendEvent - SpellEffect::GetProvidedTargetMask() is much more accurate than hardcoded dbc index.
2011-12-23 23:52:22 +01:00
// call events for object target if present
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode == SPELL_EFFECT_HANDLE_HIT_TARGET)
{
if (unitTarget)
target = unitTarget;
else if (gameObjTarget)
target = gameObjTarget;
}
Core/Spells: Use better check for target type in Spell::EffectSendEvent - SpellEffect::GetProvidedTargetMask() is much more accurate than hardcoded dbc index.
2011-12-23 23:52:22 +01:00
else // if (effectHandleMode == SPELL_EFFECT_HANDLE_HIT)
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
{
Core/Spells: Use better check for target type in Spell::EffectSendEvent - SpellEffect::GetProvidedTargetMask() is much more accurate than hardcoded dbc index.
2011-12-23 23:52:22 +01:00
// let's prevent executing effect handler twice in case when spell effect is capable of targeting an object
// this check was requested by scripters, but it has some downsides:
// now it's impossible to script (using sEventScripts) a cast which misses all targets
// or to have an ability to script the moment spell hits dest (in a case when there are object targets present)
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->GetProvidedTargetMask() & (TARGET_FLAG_UNIT_MASK | TARGET_FLAG_GAMEOBJECT_MASK))
Core/Spells: Use better check for target type in Spell::EffectSendEvent - SpellEffect::GetProvidedTargetMask() is much more accurate than hardcoded dbc index.
2011-12-23 23:52:22 +01:00
return;
// some spells have no target entries in dbc and they use focus target
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (focusObject)
target = focusObject;
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo there should be a possibility to pass dest target to event script
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
}
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
TC_LOG_DEBUG("spells", "Spell ScriptStart %u for spellid %u in EffectSendEvent ", effectInfo->MiscValue, m_spellInfo->Id);
Fix EffectSendEvent to work if target is GO or Unit.
2010-01-21 23:57:14 +01:00
Core/GameObject: Refactored destructible building handling, properly implemented spell effect repair
2011-07-22 21:22:05 +02:00
if (ZoneScript* zoneScript = m_caster->GetZoneScript())
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
zoneScript->ProcessEvent(target, effectInfo->MiscValue);
Core/Spells: Allow ProcessEvent hook to run in EffectSendEvent when spell caster is a player
2011-09-30 18:41:30 +02:00
else if (InstanceScript* instanceScript = m_caster->GetInstanceScript()) // needed in case Player is the caster
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
instanceScript->ProcessEvent(target, effectInfo->MiscValue);
Core/ZoneScript: Implemented ProcessEvent function for units.
2011-01-20 12:27:08 -03:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
m_caster->GetMap()->ScriptsStart(sEventScripts, effectInfo->MiscValue, m_caster, target);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPowerBurn()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->MiscValue < 0 || effectInfo->MiscValue >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
Powers powerType = Powers(effectInfo->MiscValue);
Core/Misc: Added helper function Unit::SetFullPower
2018-01-03 16:39:00 +01:00
if (!unitTarget || !unitTarget->IsAlive() || unitTarget->GetPowerType() != powerType || damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/StatsSystem: Resilience updates.
2012-12-20 19:22:14 +01:00
int32 newDamage = -(unitTarget->ModifyPower(powerType, -damage));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
// NO - Not a typo - EffectPowerBurn uses effect value multiplier - not effect damage multiplier
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
float dmgMultiplier = effectInfo->CalcValueMultiplier(unitCaster, this);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed power burn effects showing mana restored to caster
2010-09-25 15:03:48 +02:00
// add log data before multiplication (need power amount, not damage)
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectTakeTargetPower(SpellEffectName(effectInfo->Effect), unitTarget, powerType, newDamage, 0.0f);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 4: iterate over effects first
2018-02-01 13:10:51 -03:00
newDamage = int32(newDamage * dmgMultiplier);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
*Allow SPELL_EFFECT_POWER_BURN(64) to proc with damage.
2010-08-29 05:26:32 +02:00
m_damage += newDamage;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectHeal()
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitTarget || !unitTarget->IsAlive() || damage < 0)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
// Skip if m_originalCaster not available
if (!unitCaster)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
int32 addhealth = damage;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
// Vessel of the Naaru (Vial of the Sunwell trinket)
///@todo: move this to scripts
if (m_spellInfo->Id == 45064)
{
// Amount of heal - depends from stacked Holy Energy
int32 damageAmount = 0;
if (AuraEffect const* aurEff = unitCaster->GetAuraEffect(45062, 0))
Core/Spells: Implemented varying damage for spells with no base value
2014-12-19 18:55:09 +01:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
damageAmount += aurEff->GetAmount();
unitCaster->RemoveAurasDueToSpell(45062);
Core/Spells: Implemented varying damage for spells with no base value
2014-12-19 18:55:09 +01:00
}
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
addhealth += damageAmount;
}
// Runic Healing Injector (heal increased by 25% for engineers - 3.2.0 patch change)
else if (m_spellInfo->Id == 67489)
{
if (Player* player = unitCaster->ToPlayer())
if (player->HasSkill(SKILL_ENGINEERING))
AddPct(addhealth, 25);
}
// Death Pact - return pct of max health to caster
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_DEATHKNIGHT && m_spellInfo->SpellFamilyFlags[0] & 0x00080000)
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
addhealth = unitCaster->SpellHealingBonusDone(unitTarget, m_spellInfo, int32(unitCaster->CountPctFromMaxHealth(damage)), HEAL, *effectInfo);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
else
{
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
uint32 bonus = unitCaster->SpellHealingBonusDone(unitTarget, m_spellInfo, addhealth, HEAL, *effectInfo);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
addhealth = bonus + uint32(bonus * variance);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
addhealth = unitTarget->SpellHealingBonusTaken(unitCaster, m_spellInfo, addhealth, HEAL);
Fix Grievious bite (48920): now if removed when target is fully healed
2010-06-20 00:37:02 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
// Remove Grievious bite if fully healed
if (unitTarget->HasAura(48920) && (unitTarget->GetHealth() + addhealth >= unitTarget->GetMaxHealth()))
unitTarget->RemoveAura(48920);
m_healing += addhealth;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectHealPct()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive() || damage < 0)
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
uint32 heal = unitTarget->CountPctFromMaxHealth(damage);
if (unitCaster)
{
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
heal = unitCaster->SpellHealingBonusDone(unitTarget, m_spellInfo, heal, HEAL, *effectInfo);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
heal = unitTarget->SpellHealingBonusTaken(unitCaster, m_spellInfo, heal, HEAL);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
m_healing += heal;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectHealMechanical()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive() || damage < 0)
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
uint32 heal = damage;
if (unitCaster)
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
heal = unitCaster->SpellHealingBonusDone(unitTarget, m_spellInfo, heal, HEAL, *effectInfo);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented varying damage for spells with no base value
2014-12-19 18:55:09 +01:00
heal += uint32(heal * variance);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster)
heal = unitTarget->SpellHealingBonusTaken(unitCaster, m_spellInfo, heal, HEAL);
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
m_healing += heal;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectHealthLeech()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive() || damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
uint32 bonus = 0;
if (unitCaster)
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
bonus = unitCaster->SpellDamageBonusDone(unitTarget, m_spellInfo, uint32(damage), SPELL_DIRECT_DAMAGE, *effectInfo);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Core/Spells: Implemented varying damage for spells with no base value
2014-12-19 18:55:09 +01:00
damage = bonus + uint32(bonus * variance);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster)
damage = unitTarget->SpellDamageBonusTaken(unitCaster, m_spellInfo, uint32(damage), SPELL_DIRECT_DAMAGE);
Core/Spells: Fixed damage from warlock's Death Coil
2011-05-10 22:28:28 +07:00
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "HealthLeech :%i", damage);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
float healMultiplier = effectInfo->CalcValueMultiplier(unitCaster, this);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Health Leech effect, should not apply healing multiplier to damage done
2010-09-02 15:34:36 +02:00
m_damage += damage;
// get max possible damage, don't count overkill for heal
uint32 healthGain = uint32(-unitTarget->GetHealthGain(-damage) * healMultiplier);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster && unitCaster->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
healthGain = unitCaster->SpellHealingBonusDone(unitCaster, m_spellInfo, healthGain, HEAL, *effectInfo);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
healthGain = unitCaster->SpellHealingBonusTaken(unitCaster, m_spellInfo, healthGain, HEAL);
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
HealInfo healInfo(unitCaster, unitCaster, healthGain, m_spellInfo, m_spellSchoolMask);
unitCaster->HealBySpell(healInfo);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::DoCreateItem(uint32 itemId, ItemContext context /*= ItemContext::NONE*/, std::vector<int32> const& bonusListIDs /*= std::vector<int32>()*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Player* player = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
uint32 newitemid = itemId;
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
ItemTemplate const* pProto = sObjectMgr->GetItemTemplate(newitemid);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pProto)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
player->SendEquipError(EQUIP_ERR_ITEM_NOT_FOUND, nullptr, nullptr);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Drop old item amount calculation. by Vladimir
2010-04-14 12:22:35 +04:00
uint32 num_to_add = damage;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (num_to_add < 1)
num_to_add = 1;
[7015] Implement support -1 in item_template.stackable and item_template.maxcount fields. By VladimirMangos.
2009-01-03 11:06:51 -06:00
if (num_to_add > pProto->GetMaxStackSize())
num_to_add = pProto->GetMaxStackSize();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Merge pull request #15495 from Treeston/3.3.5-gemperfection
2015-10-11 11:40:05 +02:00
/* == gem perfection handling == */
Core/DataStores: Updated db2 structures to 7.2.0
2017-04-06 23:39:34 +02:00
// this is bad, should be done using spell_loot_template (and conditions)
Merge pull request #15495 from Treeston/3.3.5-gemperfection
2015-10-11 11:40:05 +02:00
// the chance of getting a perfect result
float perfectCreateChance = 0.0f;
// the resulting perfect item if successful
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
uint32 perfectItemType = itemId;
Merge pull request #15495 from Treeston/3.3.5-gemperfection
2015-10-11 11:40:05 +02:00
// get perfection capability and chance
if (CanCreatePerfectItem(player, m_spellInfo->Id, perfectCreateChance, perfectItemType))
if (roll_chance_f(perfectCreateChance)) // if the roll succeeds...
newitemid = perfectItemType; // the perfect item replaces the regular one
/* == gem perfection handling over == */
/* == profession specialization handling == */
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// init items_count to 1, since 1 item will be created regardless of specialization
int items_count=1;
// the chance to create additional items
float additionalCreateChance=0.0f;
// the maximum number of created additional items
uint8 additionalMaxNum=0;
// get the chance and maximum number for creating extra items
Core: More Function Renaming.
2013-06-11 21:25:12 -02:30
if (CanCreateExtraItems(player, m_spellInfo->Id, additionalCreateChance, additionalMaxNum))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// roll with this chance till we roll not to create or we create the max num
Code Style (game + scripts only):
2010-04-07 23:56:35 +02:00
while (roll_chance_f(additionalCreateChance) && items_count <= additionalMaxNum)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
++items_count;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// really will be created more items
num_to_add *= items_count;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Merge pull request #15495 from Treeston/3.3.5-gemperfection
2015-10-11 11:40:05 +02:00
/* == profession specialization handling over == */
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// can the player store the new item?
ItemPosCountVec dest;
uint32 no_space = 0;
Core: use enum InventoryResult as return type for functions working with player items.
2011-04-29 16:48:15 +06:00
InventoryResult msg = player->CanStoreNewItem(NULL_BAG, NULL_SLOT, dest, newitemid, num_to_add, &no_space);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (msg != EQUIP_ERR_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// convert to possible store amount
Core/Items: Updated InventoryResult enum
2012-08-20 15:54:55 +02:00
if (msg == EQUIP_ERR_INV_FULL || msg == EQUIP_ERR_ITEM_MAX_COUNT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
num_to_add -= no_space;
else
{
// if not created by another reason from full inventory or unique items amount limitation
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
player->SendEquipError(msg, nullptr, nullptr, newitemid);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (num_to_add)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// create the new item and store it
Core/Items: Drop item random property and suffix - all random stats must be given using bonus lists
2019-06-04 22:36:17 +02:00
Item* pItem = player->StoreNewItem(dest, newitemid, true, GenerateItemRandomBonusListId(newitemid), GuidSet(), context, bonusListIDs);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// was it successful? return error if not
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
player->SendEquipError(EQUIP_ERR_ITEM_NOT_FOUND, nullptr, nullptr);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// set the "Crafted by ..." property of the item
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
if (pItem->GetTemplate()->GetClass() != ITEM_CLASS_CONSUMABLE && pItem->GetTemplate()->GetClass() != ITEM_CLASS_QUEST && newitemid != 6265 && newitemid != 6948)
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
pItem->SetCreator(player->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// send info to the client
Core/Spells: Delete ancient bg mark code from create item spell effect
2019-10-18 19:38:03 +02:00
player->SendNewItem(pItem, num_to_add, true, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/DataStores: Updated DBC and DB2 structures to 6.2.2.20444
2015-09-07 18:03:33 +02:00
if (pItem->GetQuality() > ITEM_QUALITY_EPIC || (pItem->GetQuality() == ITEM_QUALITY_EPIC && pItem->GetItemLevel(player) >= MinNewsItemLevel))
Core/Guilds: Multiple changes
2012-11-07 23:21:19 +01:00
if (Guild* guild = player->GetGuild())
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
guild->AddGuildNews(GUILD_NEWS_ITEM_CRAFTED, player->GetGUID(), 0, pProto->GetId());
Core/Guilds: Multiple changes
2012-11-07 23:21:19 +01:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// we succeeded in creating at least one item, so a levelup is possible
Core/Spells: Delete ancient bg mark code from create item spell effect
2019-10-18 19:38:03 +02:00
player->UpdateCraftSkill(m_spellInfo->Id);
* Trailing whitespace removed.
2009-04-06 21:14:51 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateItem()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
DoCreateItem(effectInfo->ItemType, m_spellInfo->HasAttribute(SPELL_ATTR0_TRADESPELL) ? ItemContext::Trade_Skill : ItemContext::NONE);
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectCreateItem(SpellEffectName(effectInfo->Effect), effectInfo->ItemType);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateItem2()
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
[7881] More types with random generated item at recipe casting. Cleanups code. Author: VladimirMangos
2009-05-24 11:17:41 -05:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Player* player = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 item_id = effectInfo->ItemType;
Core/Items: Add ItemContext param to Item::Create function
2019-11-23 00:03:42 +01:00
ItemContext context = m_spellInfo->HasAttribute(SPELL_ATTR0_TRADESPELL) ? ItemContext::Trade_Skill : ItemContext::NONE;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
if (item_id)
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
DoCreateItem(item_id, context);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7881] More types with random generated item at recipe casting. Cleanups code. Author: VladimirMangos
2009-05-24 11:17:41 -05:00
// special case: fake item replaced by generate using spell_loot_template
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
if (m_spellInfo->IsLootCrafting())
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
{
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
if (item_id)
{
Core/Misc: Add default count param to HasItemCount
2012-10-23 13:11:08 +02:00
if (!player->HasItemCount(item_id))
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
// remove reagent
uint32 count = 1;
player->DestroyItemCount(item_id, count, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
// create some random items
Core/Items: Add ItemContext param to Item::Create function
2019-11-23 00:03:42 +01:00
player->AutoStoreLoot(m_spellInfo->Id, LootTemplates_Spell, context);
Fixed spells with EffectCreateItem2 that do not have EffectItemType set in dbc and should pick it from spell_loot_template table (like 69412 Abyssal Shatter)
2010-06-16 20:10:42 +02:00
}
else
Core/Items: Add ItemContext param to Item::Create function
2019-11-23 00:03:42 +01:00
player->AutoStoreLoot(m_spellInfo->Id, LootTemplates_Spell, context); // create some random items
Core/Spells: Abyssal Shatter should have a chance to skill up
2016-08-01 04:53:27 -03:00
player->UpdateCraftSkill(m_spellInfo->Id);
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
}
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo ExecuteLogEffectCreateItem(i, m_spellInfo->Effects[i].ItemType);
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateRandomItem()
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Player* player = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
// create some random items
Core/Items: Add ItemContext param to Item::Create function
2019-11-23 00:03:42 +01:00
player->AutoStoreLoot(m_spellInfo->Id, LootTemplates_Spell, m_spellInfo->HasAttribute(SPELL_ATTR0_TRADESPELL) ? ItemContext::Trade_Skill : ItemContext::NONE);
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo ExecuteLogEffectCreateItem(i, m_spellInfo->Effects[i].ItemType);
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPersistentAA()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
// only handle at last effect
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
for (size_t i = effectInfo->EffectIndex + 1; i < m_spellInfo->GetEffects().size(); ++i)
if (m_spellInfo->GetEffect(SpellEffIndex(i)).IsEffect(SPELL_EFFECT_PERSISTENT_AREA_AURA))
return;
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
ASSERT(!_dynObjAura);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
float radius = effectInfo->CalcRadius(unitCaster);
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
// Caster not in world, might be spell triggered from aura removal
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster->IsInWorld())
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
return;
DynamicObject* dynObj = new DynamicObject(false);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!dynObj->CreateDynamicObject(unitCaster->GetMap()->GenerateLowGuid<HighGuid::DynamicObject>(), unitCaster, m_spellInfo, *destTarget, radius, DYNAMIC_OBJECT_AREA_SPELL, m_SpellVisual))
*Use one dynobj to handle multiple aura effects.
2009-08-27 16:41:10 -05:00
{
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
delete dynObj;
return;
}
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
AuraCreateInfo createInfo(m_castId, m_spellInfo, GetCastDifficulty(), MAX_EFFECT_MASK, dynObj);
createInfo
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
.SetCaster(unitCaster)
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
.SetBaseAmount(m_spellValue->EffectBasePoints)
.SetCastItem(m_castItemGUID, m_castItemEntry, m_castItemLevel);
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
if (Aura* aura = Aura::TryCreate(createInfo))
{
_dynObjAura = aura->ToDynObjAura();
_dynObjAura->_RegisterForTargets();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
else
return;
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
2018-01-27 03:45:40 -03:00
ASSERT(_dynObjAura->GetDynobjOwner());
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
_dynObjAura->_ApplyEffectForTargets(effectInfo->EffectIndex);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnergize()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->MiscValue < 0 || effectInfo->MiscValue >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
Powers power = Powers(effectInfo->MiscValue);
Core/Spells: Implement SPELL_ATTR7_CAN_RESTORE_SECONDARY_POWER
2014-06-16 01:32:52 +02:00
if (unitTarget->GetMaxPower(power) == 0)
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Some level depends spells
switch (m_spellInfo->Id)
{
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
case 24571: // Blood Fury
Core/Spells: Removed obsolete spell fixes
2018-01-03 18:10:47 +01:00
// Instantly increases your rage by ${(300-10*$max(0,$PL-60))/10}.
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
damage -= 10 * std::max(0, std::min(30, unitCaster->getLevel() - 60));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
case 24532: // Burst of Energy
Core/Spells: Removed obsolete spell fixes
2018-01-03 18:10:47 +01:00
// Instantly increases your energy by ${60-4*$max(0,$min(15,$PL-60))}.
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
damage -= 4 * std::max(0, std::min(15, unitCaster->getLevel() - 60));
*Fix a typo in Spell::EffectEnergize.
2009-08-13 14:36:50 +02:00
break;
Core/Spells: Fix Runic Healing/Mana Injector bonus for engineers
2011-11-02 19:23:59 +07:00
case 67490: // Runic Mana Injector (mana gain increased by 25% for engineers - 3.2.0 patch change)
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (Player* player = unitCaster->ToPlayer())
Core/Spells: Remove not needed check added in 9229b878f2
2011-11-03 17:08:30 +07:00
if (player->HasSkill(SKILL_ENGINEERING))
Core/Utilities: Use generic templates with AddPct, ApplyPct and CalculatePct
2012-10-02 12:17:42 +02:00
AddPct(damage, 25);
Core/Spells: Fix Runic Healing/Mana Injector bonus for engineers
2011-11-02 19:23:59 +07:00
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->EnergizeBySpell(unitTarget, m_spellInfo, damage, power);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnergizePct()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->MiscValue < 0 || effectInfo->MiscValue >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
Powers power = Powers(effectInfo->MiscValue);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 maxPower = unitTarget->GetMaxPower(power);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!maxPower)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
uint32 const gain = CalculatePct(maxPower, damage);
unitCaster->EnergizeBySpell(unitTarget, m_spellInfo, gain, power);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Use ObjectGuid class in game project
2014-09-14 16:14:12 +02:00
void Spell::SendLoot(ObjectGuid guid, LootType loottype)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
2010-12-26 16:35:29 +01:00
Player* player = m_caster->ToPlayer();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!player)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (gameObjTarget)
{
Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation.
2011-01-18 20:02:28 +01:00
// Players shouldn't be able to loot gameobjects that are currently despawned
Core: More Function Renaming.
2013-06-11 21:25:12 -02:30
if (!gameObjTarget->isSpawned() && !player->IsGameMaster())
Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation.
2011-01-18 20:02:28 +01:00
{
Core/Logs: Fine tune more logs
2016-08-11 09:10:20 +02:00
TC_LOG_ERROR("entities.player.cheat", "Possible hacking attempt: Player %s [%s] tried to loot a gameobject [%s] which is on respawn times without being in GM mode!",
Core/Entities: Fourth part of removing GetGUIDLow() uses
2014-10-22 21:22:04 +02:00
player->GetName().c_str(), player->GetGUID().ToString().c_str(), gameObjTarget->GetGUID().ToString().c_str());
Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation.
2011-01-18 20:02:28 +01:00
return;
}
Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
2010-12-26 16:35:29 +01:00
// special case, already has GossipHello inside so return and avoid calling twice
if (gameObjTarget->GetGoType() == GAMEOBJECT_TYPE_GOOBER)
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
gameObjTarget->Use(player);
Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
2010-12-26 16:35:29 +01:00
return;
}
Core/Scripts: unified scripted gossip/quest api
2017-05-01 18:19:36 -03:00
player->PlayerTalkClass->ClearMenus();
Core/AI: segregate GameObject ReportUse from normal Use (lock open/normal click)
2017-06-06 20:36:01 +02:00
if (gameObjTarget->AI()->GossipHello(player))
Core/Spells: Fixed Soulwell getting two charges removed (or more) per click.
2012-09-22 21:28:37 +02:00
return;
Core/AI: implemented SmartScripts System (still beta) not 100% complete
2010-10-27 21:01:47 +02:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
switch (gameObjTarget->GetGoType())
{
case GAMEOBJECT_TYPE_DOOR:
case GAMEOBJECT_TYPE_BUTTON:
Core/SAI: Linked events should be executed after the event that linked them is executed.
2012-01-22 20:36:01 -05:00
gameObjTarget->UseDoorOrButton(0, false, player);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_QUESTGIVER:
Core/Gossips: Fix usage of PrepareGossipMenu with GOs
2013-04-04 19:32:45 +02:00
player->PrepareGossipMenu(gameObjTarget, gameObjTarget->GetGOInfo()->questgiver.gossipID, true);
Core/Gossips: Fixed gossip menu displaying for gameobjects with type GAMEOBJECT_TYPE_QUESTGIVER, closes #4488
2012-01-05 21:41:17 -05:00
player->SendPreparedGossip(gameObjTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_SPELL_FOCUS:
// triggering linked GO
Core/GameObjects: Updated GameObjectTemplate data structure
2014-10-30 20:02:42 +01:00
if (uint32 trapEntry = gameObjTarget->GetGOInfo()->spellFocus.linkedTrap)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
gameObjTarget->TriggeringLinkedGameObject(trapEntry, player);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_CHEST:
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo possible must be moved to loot release (in different from linked triggering)
Core/GameObjects: Updated GameObjectTemplate data structure
2014-10-30 20:02:42 +01:00
if (gameObjTarget->GetGOInfo()->chest.triggeredEvent)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Entities: Reworked guid scopes
2015-02-25 00:13:14 +01:00
TC_LOG_DEBUG("spells", "Chest ScriptStart id %u for GO " UI64FMTD, gameObjTarget->GetGOInfo()->chest.triggeredEvent, gameObjTarget->GetSpawnId());
Core/GameObjects: Updated GameObjectTemplate data structure
2014-10-30 20:02:42 +01:00
player->GetMap()->ScriptsStart(sEventScripts, gameObjTarget->GetGOInfo()->chest.triggeredEvent, player, gameObjTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// triggering linked GO
Core/GameObjects: Updated GameObjectTemplate data structure
2014-10-30 20:02:42 +01:00
if (uint32 trapEntry = gameObjTarget->GetGOInfo()->chest.linkedTrap)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
gameObjTarget->TriggeringLinkedGameObject(trapEntry, player);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Don't return, let loots been taken
[7745] Fixed gcc warnings. Author: AlexDereka
2009-05-03 22:21:46 -05:00
default:
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Send loot
player->SendLoot(guid, loottype);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectOpenLock()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Small cleanup in SpellEffects, spells always have caster
2010-12-22 20:18:34 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "WORLD: Open Lock - No Player Caster!");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Player* player = m_caster->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 lockId = 0;
Core/Entities: Use ObjectGuid class in game project
2014-09-14 16:14:12 +02:00
ObjectGuid guid;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Get lockId
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (gameObjTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/ObjectMgr: Refactor sGOStorage
2011-04-28 22:54:30 +02:00
GameObjectTemplate const* goInfo = gameObjTarget->GetGOInfo();
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
// Arathi Basin banner opening. /// @todo Verify correctness of this check
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if ((goInfo->type == GAMEOBJECT_TYPE_BUTTON && goInfo->button.noDamageImmune) ||
Core/GameObjects: Updated GameObjectTemplate data structure
2014-10-30 20:02:42 +01:00
(goInfo->type == GAMEOBJECT_TYPE_GOOBER && goInfo->goober.requireLOS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
//CanUseBattlegroundObject() already called in CheckCast()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// in battleground check
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
if (Battleground* bg = player->GetBattleground())
DB/BGs: Fix capturing of Snowball GY - AV
2011-09-06 21:20:14 +01:00
{
bg->EventPlayerClickedOnFlag(player, gameObjTarget);
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
else if (goInfo->type == GAMEOBJECT_TYPE_FLAGSTAND)
{
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
//CanUseBattlegroundObject() already called in CheckCast()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// in battleground check
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
if (Battleground* bg = player->GetBattleground())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add support for random battlegrounds - port by n0n4me, original code by Vladimir and Griffonheart (Big thanks to all of you!)
2010-05-26 11:34:37 +02:00
if (bg->GetTypeID(true) == BATTLEGROUND_EY)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
bg->EventPlayerClickedOnFlag(player, gameObjTarget);
return;
}
Core/Misc: Fix some warnings and logic mistakes found by static code analysis
2012-09-05 17:17:45 +02:00
}
else if (m_spellInfo->Id == 1842 && gameObjTarget->GetGOInfo()->type == GAMEOBJECT_TYPE_TRAP && gameObjTarget->GetOwner())
Support for spell Disarm Trap.
2010-03-26 22:04:38 -03:00
{
Removed tabs
2010-05-23 18:20:10 -03:00
gameObjTarget->SetLootState(GO_JUST_DEACTIVATED);
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo Add script for spell 41920 - Filling, becouse server it freze when use this spell
[svn] * Merge Temp dev SVN with Assembla.
2008-10-14 11:57:03 -05:00
// handle outdoor pvp object opening, return true if go was registered for handling
// these objects must have been spawned by outdoorpvp!
Core/Entities: Reworked guid scopes
2015-02-25 00:13:14 +01:00
else if (gameObjTarget->GetGOInfo()->type == GAMEOBJECT_TYPE_GOOBER && sOutdoorPvPMgr->HandleOpenGo(player, gameObjTarget))
[svn] * Merge Temp dev SVN with Assembla.
2008-10-14 11:57:03 -05:00
return;
[8183] Some gameobject despanw related fixes Author: VladimirMangos
2009-07-16 12:06:07 +08:00
lockId = goInfo->GetLockId();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
guid = gameObjTarget->GetGUID();
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (itemTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
lockId = itemTarget->GetTemplate()->GetLockID();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
guid = itemTarget->GetGUID();
}
else
{
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "WORLD: Open Lock - No GameObject/Item Target!");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
SkillType skillId = SKILL_NONE;
int32 reqSkillValue = 0;
int32 skillValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
SpellCastResult res = CanOpenLock(*effectInfo, lockId, skillId, reqSkillValue, skillValue);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (res != SPELL_CAST_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
SendCastResult(res);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Cleaned up item flags: separated item proto flags and item field flags
2010-08-04 10:34:30 +02:00
if (gameObjTarget)
SendLoot(guid, LOOT_SKINNING);
Core/Misc: Fix some warnings and logic mistakes found by static code analysis
2012-09-05 17:17:45 +02:00
else if (itemTarget)
Core/Items: Fixed saving item after unlocking
2017-11-26 23:38:17 +01:00
{
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
itemTarget->AddItemFlag(ITEM_FIELD_FLAG_UNLOCKED);
Core/Items: Fixed saving item after unlocking
2017-11-26 23:38:17 +01:00
itemTarget->SetState(ITEM_CHANGED, itemTarget->GetOwner());
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Use SpellCastResult and finaly fix SPELL_CAST_OK value (255 custom value now). By VladimirMangos.
2009-03-16 12:00:14 -06:00
// not allow use skill grow at item base open
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_CastItem && skillId != SKILL_NONE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
// update skill if really known
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint32 pureSkillValue = player->GetPureSkillValue(skillId))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (gameObjTarget)
Replace hack code in Spell::EffectOpenLock by generic way for check lock key items/skills
2009-03-15 17:18:59 -06:00
{
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
// Allow one skill-up until respawned
Core/Entities: Fourth part of removing GetGUIDLow() uses
2014-10-22 21:22:04 +02:00
if (!gameObjTarget->IsInSkillupList(player->GetGUID()) &&
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue))
Core/Entities: Fourth part of removing GetGUIDLow() uses
2014-10-22 21:22:04 +02:00
gameObjTarget->AddToSkillupList(player->GetGUID());
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (itemTarget)
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
{
// Do one skill-up
player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue);
Replace hack code in Spell::EffectOpenLock by generic way for check lock key items/skills
2009-03-15 17:18:59 -06:00
}
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectOpenLock(SpellEffectName(effectInfo->Effect), gameObjTarget ? (Object*)gameObjTarget : (Object*)itemTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonChangeItem()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Player* player = m_caster->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// applied only to using item
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (!m_CastItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// ... only to item in own inventory/bank/equip_slot
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_CastItem->GetOwnerGUID() != player->GetGUID())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 newitemid = effectInfo->ItemType;
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (!newitemid)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint16 pos = m_CastItem->GetPos();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items: Add ItemContext param to Item::Create function
2019-11-23 00:03:42 +01:00
Item* pNewItem = Item::CreateItem(newitemid, 1, m_CastItem->GetContext(), player);
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (!pNewItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
for (uint8 j = PERM_ENCHANTMENT_SLOT; j <= TEMP_ENCHANTMENT_SLOT; ++j)
if (m_CastItem->GetEnchantmentId(EnchantmentSlot(j)))
[7716] Fixed some typos and possible crashes. Author: AlexDereka
2009-04-27 18:42:35 -05:00
pNewItem->SetEnchantment(EnchantmentSlot(j), m_CastItem->GetEnchantmentId(EnchantmentSlot(j)), m_CastItem->GetEnchantmentDuration(EnchantmentSlot(j)), m_CastItem->GetEnchantmentCharges(EnchantmentSlot(j)));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
if (*m_CastItem->m_itemData->Durability < *m_CastItem->m_itemData->MaxDurability)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
double lossPercent = 1 - *m_CastItem->m_itemData->Durability / double(m_CastItem->m_itemData->MaxDurability);
Misc: Some engrish fixes, thanks to ZxBiohazardZx, closes issue 4740
2010-11-14 23:46:34 +02:00
player->DurabilityLoss(pNewItem, lossPercent);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (player->IsInventoryPos(pos))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
ItemPosCountVec dest;
Core: use enum InventoryResult as return type for functions working with player items.
2011-04-29 16:48:15 +06:00
InventoryResult msg = player->CanStoreItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), dest, pNewItem, true);
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (msg == EQUIP_ERR_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
player->DestroyItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent crash at access and unexpected charges counting with item update queue corrupt
Core/Spells: Cleanup in Spell.h:
2011-06-23 13:28:52 +02:00
if (m_CastItem == m_targets.GetItemTarget())
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
m_targets.SetItemTarget(nullptr);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
m_CastItem = nullptr;
Core/Entities: Use ObjectGuid class in game project
2014-09-14 16:14:12 +02:00
m_castItemGUID.Clear();
Core/Misc: Fix enchants broken in 3aca9e64b3
2014-05-05 20:05:33 +02:00
m_castItemEntry = 0;
Core/Spells: Implemented scaling spell value with item level
2015-11-24 00:16:42 +01:00
m_castItemLevel = -1;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->StoreItem(dest, pNewItem, true);
Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM for quest credit
2016-11-18 03:42:01 -03:00
player->SendNewItem(pNewItem, 1, true, false);
player->ItemAddedQuestCheck(newitemid, 1);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
else if (player->IsBankPos(pos))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
ItemPosCountVec dest;
Core/Misc: MSVC /W4 warning fixes
2016-04-06 18:40:41 +02:00
if (player->CanBankItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), dest, pNewItem, true) == EQUIP_ERR_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
player->DestroyItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent crash at access and unexpected charges counting with item update queue corrupt
Core/Spells: Cleanup in Spell.h:
2011-06-23 13:28:52 +02:00
if (m_CastItem == m_targets.GetItemTarget())
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
m_targets.SetItemTarget(nullptr);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
m_CastItem = nullptr;
Core/Entities: Use ObjectGuid class in game project
2014-09-14 16:14:12 +02:00
m_castItemGUID.Clear();
Core/Misc: Fix enchants broken in 3aca9e64b3
2014-05-05 20:05:33 +02:00
m_castItemEntry = 0;
Core/Spells: Implemented scaling spell value with item level
2015-11-24 00:16:42 +01:00
m_castItemLevel = -1;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->BankItem(dest, pNewItem, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
else if (player->IsEquipmentPos(pos))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint16 dest;
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->DestroyItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), true);
Core/Misc: MSVC /W4 warning fixes
2016-04-06 18:40:41 +02:00
InventoryResult msg = player->CanEquipItem(m_CastItem->GetSlot(), dest, pNewItem, true);
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
Core/Items: Updated InventoryResult enum
2012-08-20 15:54:55 +02:00
if (msg == EQUIP_ERR_OK || msg == EQUIP_ERR_CLIENT_LOCKED_OUT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Items: Updated InventoryResult enum
2012-08-20 15:54:55 +02:00
if (msg == EQUIP_ERR_CLIENT_LOCKED_OUT) dest = EQUIPMENT_SLOT_MAINHAND;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent crash at access and unexpected charges counting with item update queue corrupt
Core/Spells: Cleanup in Spell.h:
2011-06-23 13:28:52 +02:00
if (m_CastItem == m_targets.GetItemTarget())
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
m_targets.SetItemTarget(nullptr);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
m_CastItem = nullptr;
Core/Entities: Use ObjectGuid class in game project
2014-09-14 16:14:12 +02:00
m_castItemGUID.Clear();
Core/Misc: Fix enchants broken in 3aca9e64b3
2014-05-05 20:05:33 +02:00
m_castItemEntry = 0;
Core/Spells: Implemented scaling spell value with item level
2015-11-24 00:16:42 +01:00
m_castItemLevel = -1;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->EquipItem(dest, pNewItem, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
player->AutoUnequipOffhandIfNeed();
Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM for quest credit
2016-11-18 03:42:01 -03:00
player->SendNewItem(pNewItem, 1, true, false);
player->ItemAddedQuestCheck(newitemid, 1);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// fail
delete pNewItem;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectProficiency()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Player* p_target = m_caster->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 subClassMask = m_spellInfo->EquippedItemSubClassMask;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->EquippedItemClass == ITEM_CLASS_WEAPON && !(p_target->GetWeaponProficiency() & subClassMask))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
p_target->AddWeaponProficiency(subClassMask);
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
p_target->SendProficiency(ITEM_CLASS_WEAPON, p_target->GetWeaponProficiency());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->EquippedItemClass == ITEM_CLASS_ARMOR && !(p_target->GetArmorProficiency() & subClassMask))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
p_target->AddArmorProficiency(subClassMask);
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
p_target->SendProficiency(ITEM_CLASS_ARMOR, p_target->GetArmorProficiency());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonType()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 entry = effectInfo->MiscValue;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!entry)
*More work on summon system.
2009-03-20 14:01:46 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
SummonPropertiesEntry const* properties = sSummonPropertiesStore.LookupEntry(effectInfo->MiscValueB);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!properties)
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "EffectSummonType: Unhandled summon type %u.", effectInfo->MiscValueB);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
WorldObject* caster = m_caster;
if (m_originalCaster)
caster = m_originalCaster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented SUMMON_PROP_FLAG_PERSONAL_GROUP_SPAWN
2021-03-28 18:20:57 +02:00
ObjectGuid privateObjectOwner = [&]()
{
if (!(properties->Flags & (SUMMON_PROP_FLAG_PERSONAL_SPAWN | SUMMON_PROP_FLAG_PERSONAL_GROUP_SPAWN)))
return ObjectGuid::Empty;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (caster->IsPrivateObject())
return caster->GetPrivateObjectOwner();
Core/Spells: Implemented SUMMON_PROP_FLAG_PERSONAL_GROUP_SPAWN
2021-03-28 18:20:57 +02:00
if (properties->Flags & SUMMON_PROP_FLAG_PERSONAL_GROUP_SPAWN)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (caster->IsPlayer() && m_originalCaster->ToPlayer()->GetGroup())
return caster->ToPlayer()->GetGroup()->GetGUID();
Core/Spells: Implemented SUMMON_PROP_FLAG_PERSONAL_GROUP_SPAWN
2021-03-28 18:20:57 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
return caster->GetGUID();
Core/Spells: Implemented SUMMON_PROP_FLAG_PERSONAL_GROUP_SPAWN
2021-03-28 18:20:57 +02:00
}();
Core/Spells: Implemented personal summons (#19231)
2018-04-08 20:35:33 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
int32 duration = m_spellInfo->CalcDuration(caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
TempSummon* summon = nullptr;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fix some problems with spells summoning to many objects.
2012-02-09 20:26:30 +01:00
// determine how many units should be summoned
uint32 numSummons;
// some spells need to summon many units, for those spells number of summons is stored in effect value
Core/Spells: Summoning players will now teleport them directly on summoner, not near him
2012-02-10 11:32:33 +01:00
// however so far noone found a generic check to find all of those (there's no related data in summonproperties.dbc
Core/Spells: Fix some problems with spells summoning to many objects.
2012-02-09 20:26:30 +01:00
// and in spell attributes, possibly we need to add a table for those)
// so here's a list of MiscValueB values, which is currently most generic check
Core/DataStores: Updated dbc/db2 to 7.0.1.20914
2016-01-31 19:25:51 +01:00
switch (effectInfo->MiscValueB)
Core/Spells: Fix some problems with spells summoning to many objects.
2012-02-09 20:26:30 +01:00
{
case 64:
case 61:
case 1101:
case 66:
case 648:
case 2301:
case 1061:
case 1261:
case 629:
case 181:
case 715:
Core/Spells: Fix recently broken feral spirit and force of nature. Closes #5278.
2012-02-17 11:44:34 +01:00
case 1562:
case 833:
case 1161:
Core/Spells: Fix Bloodworms summon count
2014-08-02 05:17:42 +02:00
case 713:
Core/Spells: Fix some problems with spells summoning to many objects.
2012-02-09 20:26:30 +01:00
numSummons = (damage > 0) ? damage : 1;
break;
default:
numSummons = 1;
break;
}
Core/DataStores: Fixed db2 structures after 7.3.5
2018-03-12 18:20:26 +01:00
switch (properties->Control)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
case SUMMON_CATEGORY_WILD:
case SUMMON_CATEGORY_ALLY:
Core/Spells: Cast proper vehicle spells on vehicle summon
2011-04-24 10:22:58 +02:00
case SUMMON_CATEGORY_UNK:
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
{
*Implement Aura Type 247 (SPELL_AURA_CLONE_CASTER) and 279 (SPELL_AURA_INITIALIZE_IMAGES)
2009-07-22 17:10:30 +02:00
if (properties->Flags & 512)
*Fix a typo breaking some summon types.
2009-07-22 20:22:36 +02:00
{
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
SummonGuardian(effectInfo, entry, properties, numSummons, privateObjectOwner);
*Implement Aura Type 247 (SPELL_AURA_CLONE_CASTER) and 279 (SPELL_AURA_INITIALIZE_IMAGES)
2009-07-22 17:10:30 +02:00
break;
*Fix a typo breaking some summon types.
2009-07-22 20:22:36 +02:00
}
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Core/Misc: Defined new summon properties titles
2020-04-07 17:27:40 +02:00
switch (SummonTitle(properties->Title))
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
{
Core/Misc: Defined new summon properties titles
2020-04-07 17:27:40 +02:00
case SummonTitle::Pet:
case SummonTitle::Guardian:
case SummonTitle::Runeblade:
case SummonTitle::Minion:
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
SummonGuardian(effectInfo, entry, properties, numSummons, privateObjectOwner);
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
break;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
// Summons a vehicle, but doesn't force anyone to enter it (see SUMMON_CATEGORY_VEHICLE)
Core/Misc: Defined new summon properties titles
2020-04-07 17:27:40 +02:00
case SummonTitle::Vehicle:
case SummonTitle::Mount:
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
{
if (!unitCaster)
return;
summon = unitCaster->GetMap()->SummonCreature(entry, *destTarget, properties, duration, unitCaster, m_spellInfo->Id);
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
break;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
}
Core/Misc: Defined new summon properties titles
2020-04-07 17:27:40 +02:00
case SummonTitle::Lightwell:
case SummonTitle::Totem:
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
summon = unitCaster->GetMap()->SummonCreature(entry, *destTarget, properties, duration, unitCaster, m_spellInfo->Id, 0, privateObjectOwner);
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!summon || !summon->IsTotem())
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
return;
Core/Spells: Fix health for Mana Tide Totem
2011-05-19 01:24:53 +07:00
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
if (damage) // if not spell info, DB values used
{
summon->SetMaxHealth(damage);
summon->SetHealth(damage);
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
Core/Misc: Defined new summon properties titles
2020-04-07 17:27:40 +02:00
case SummonTitle::Companion:
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
summon = unitCaster->GetMap()->SummonCreature(entry, *destTarget, properties, duration, unitCaster, m_spellInfo->Id, 0, privateObjectOwner);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!summon || !summon->HasUnitTypeMask(UNIT_MASK_MINION))
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: add some log messages in CheckCreatureTemplate
2014-01-06 20:30:11 +01:00
summon->SelectLevel(); // some summoned creaters have different from 1 DB data for level/hp
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
summon->SetNpcFlags(NPCFlags(summon->GetCreatureTemplate()->npcflag & 0xFFFFFFFF));
summon->SetNpcFlags2(NPCFlags2(summon->GetCreatureTemplate()->npcflag >> 32));
Hi, I'm Treeston, and welcome to Combat PR Prep Refactors.
2017-07-09 02:07:29 +02:00
summon->SetImmuneToAll(true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Move MoveFollow owner from MoveTargetedHome to enterevademode.
2009-05-12 10:11:54 -05:00
summon->AI()->EnterEvadeMode();
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
default:
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
float radius = effectInfo->CalcRadius();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
TempSummonType summonType = (duration == 0) ? TEMPSUMMON_DEAD_DESPAWN : TEMPSUMMON_TIMED_DESPAWN;
Core/Spells: Fix some problems with spells summoning to many objects.
2012-02-09 20:26:30 +01:00
for (uint32 count = 0; count < numSummons; ++count)
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
Position pos;
if (count == 0)
pos = *destTarget;
else
// randomize position for multiple summons
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
pos = caster->GetRandomPoint(*destTarget, radius);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fix UNIT_CREATED_BY_SPELL in SPELL_EFFECT_SUMMON (#21756)
2018-04-03 08:28:41 -03:00
summon = caster->SummonCreature(entry, pos, summonType, duration, 0, m_spellInfo->Id, privateObjectOwner);
*Fix Piercing Shots - by freeganja.
2009-07-22 22:52:05 +02:00
if (!summon)
continue;
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
Core/DataStores: Fixed db2 structures after 7.3.5
2018-03-12 18:20:26 +01:00
if (properties->Control == SUMMON_CATEGORY_ALLY)
*Fix the bug that summoner cannot attack summoned creatures. This bug was introduced in 4481. Note the difference between "summoner" and "owner".
2009-08-14 22:25:12 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
summon->SetOwnerGUID(caster->GetGUID());
summon->SetFaction(caster->GetFaction());
*Fix the bug that summoner cannot attack summoned creatures. This bug was introduced in 4481. Note the difference between "summoner" and "owner".
2009-08-14 22:25:12 -05:00
}
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), summon);
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
return;
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
}
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
case SUMMON_CATEGORY_PET:
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
SummonGuardian(effectInfo, entry, properties, numSummons, privateObjectOwner);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
case SUMMON_CATEGORY_PUPPET:
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
{
if (!unitCaster)
return;
summon = unitCaster->GetMap()->SummonCreature(entry, *destTarget, properties, duration, unitCaster, m_spellInfo->Id, 0, privateObjectOwner);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
}
Core/Spells: Cast proper vehicle spells on vehicle summon
2011-04-24 10:22:58 +02:00
case SUMMON_CATEGORY_VEHICLE:
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
{
if (!unitCaster)
return;
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
// Summoning spells (usually triggered by npc_spellclick) that spawn a vehicle and that cause the clicker
// to cast a ride vehicle spell on the summoned unit.
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
summon = unitCaster->GetMap()->SummonCreature(entry, *destTarget, properties, duration, unitCaster, m_spellInfo->Id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!summon || !summon->IsVehicle())
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
// The spell that this effect will trigger. It has SPELL_AURA_CONTROL_VEHICLE
Core/Spells: Fix some summon vehicle spells with basepoint 1
2012-08-02 18:38:55 +02:00
uint32 spellId = VEHICLE_SPELL_RIDE_HARDCODED;
Core/Spells: Corrected summon category SUMMON_CATEGORY_VEHICLE (#19052)
2017-02-05 22:24:23 +01:00
int32 basePoints = effectInfo->CalcValue();
if (basePoints > MAX_VEHICLE_SEATS)
{
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(basePoints, GetCastDifficulty());
if (spellInfo && spellInfo->HasAura(SPELL_AURA_CONTROL_VEHICLE))
Core/Spells: Corrected summon category SUMMON_CATEGORY_VEHICLE (#19052)
2017-02-05 22:24:23 +01:00
spellId = spellInfo->Id;
}
Fixed spell casting upon vehicle summoning.
2010-05-13 17:57:59 +02:00
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
Core/Spells: Corrected summon category SUMMON_CATEGORY_VEHICLE (#19052)
2017-02-05 22:24:23 +01:00
// if we have small value, it indicates seat position
if (basePoints > 0 && basePoints < MAX_VEHICLE_SEATS)
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SPELLVALUE_BASE_POINT0, basePoints);
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->CastSpell(summon, spellId, args);
Core/Vehicles: Correct usage of npc_spellclick_spells instead of blatant hacks for vehicle entry.
2011-02-26 23:00:09 +01:00
uint32 faction = properties->Faction;
if (!faction)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
faction = unitCaster->GetFaction();
Core/Vehicles: Correct usage of npc_spellclick_spells instead of blatant hacks for vehicle entry.
2011-02-26 23:00:09 +01:00
Core/Misc: camelize GetFaction/SetFaction properly
2017-04-28 02:24:04 -03:00
summon->SetFaction(faction);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
}
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (summon)
Fix SPELL_AURA_CLONE_CASTER on summoned creatures, it will now properly clone the appearance of the caster.
2010-06-07 01:59:04 +02:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
summon->SetCreatorGUID(caster->GetGUID());
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), summon);
Fix SPELL_AURA_CLONE_CASTER on summoned creatures, it will now properly clone the appearance of the caster.
2010-06-07 01:59:04 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLearnSpell()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:01:18 +02:00
if (unitTarget->ToPet())
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
EffectLearnPetSpell();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:01:18 +02:00
Player* player = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items: Refactored learning spells from items to check for ITEM_SPELLTRIGGER_LEARN_SPELL_ID instead of hardcoded spell ids
2021-10-16 13:22:42 +02:00
if (m_CastItem && !effectInfo->TriggerSpell)
{
for (ItemEffectEntry const* itemEffect : m_CastItem->GetEffects())
{
if (itemEffect->TriggerType != ITEM_SPELLTRIGGER_LEARN_SPELL_ID)
continue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items: Refactored learning spells from items to check for ITEM_SPELLTRIGGER_LEARN_SPELL_ID instead of hardcoded spell ids
2021-10-16 13:22:42 +02:00
player->LearnSpell(itemEffect->SpellID, false);
Core/BattlePets: Fixes when adding pets (#27076)
2021-10-17 00:11:48 +02:00
if (BattlePetSpeciesEntry const* speciesEntry = sSpellMgr->GetBattlePetSpecies(uint32(itemEffect->SpellID)))
player->GetSession()->GetBattlePetMgr()->AddPet(speciesEntry->ID, BattlePetMgr::SelectPetDisplay(speciesEntry), BattlePetMgr::RollPetBreed(speciesEntry->ID), BattlePetMgr::GetDefaultPetQuality(speciesEntry->ID));
Core/Items: Refactored learning spells from items to check for ITEM_SPELLTRIGGER_LEARN_SPELL_ID instead of hardcoded spell ids
2021-10-16 13:22:42 +02:00
}
}
if (effectInfo->TriggerSpell)
{
player->LearnSpell(effectInfo->TriggerSpell, false);
TC_LOG_DEBUG("spells", "Spell: %s has learned spell %u from %s", player->GetGUID().ToString().c_str(), effectInfo->TriggerSpell, m_caster->GetGUID().ToString().c_str());
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDispel()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Create dispel mask by dispel type
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 dispel_type = effectInfo->MiscValue;
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
uint32 dispelMask = SpellInfo::GetDispelMask(DispelType(dispel_type));
Unholy Blight should prevent the dispelling of diseases.
2010-08-06 21:32:42 -07:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
DispelChargesList dispelList;
unitTarget->GetDispellableAuraList(m_caster, dispelMask, dispelList, targetMissInfo == SPELL_MISS_REFLECT);
if (dispelList.empty())
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
size_t remaining = dispelList.size();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Ok if exist some buffs for dispel try dispel it
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
uint32 failCount = 0;
DispelChargesList successList;
successList.reserve(damage);
Core/PacketIO: Updated and enabled SMSG_DISPEL_FAILED
2016-03-18 23:53:29 +01:00
WorldPackets::Spells::DispelFailed dispelFailed;
dispelFailed.CasterGUID = m_caster->GetGUID();
dispelFailed.VictimGUID = unitTarget->GetGUID();
dispelFailed.SpellID = m_spellInfo->Id;
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
// dispel N = damage buffs (or while exist buffs for dispel)
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
for (int32 count = 0; count < damage && remaining > 0;)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
// Random select buff for dispel
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
auto itr = dispelList.begin();
std::advance(itr, urand(0, remaining - 1));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
if (itr->RollDispel())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
auto successItr = std::find_if(successList.begin(), successList.end(), [&itr](DispelableAura& dispelAura) -> bool
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
if (dispelAura.GetAura()->GetId() == itr->GetAura()->GetId())
return true;
return false;
});
if (successItr == successList.end())
successList.emplace_back(itr->GetAura(), 0, 1);
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
else
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
successItr->IncrementCharges();
Core/PacketIO: Updated and enabled SMSG_DISPEL_FAILED
2016-03-18 23:53:29 +01:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
if (!itr->DecrementCharge())
{
--remaining;
std::swap(*itr, dispelList[remaining]);
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
else
{
++failCount;
dispelFailed.FailedSpells.push_back(int32(itr->GetAura()->GetId()));
}
++count;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/PacketIO: Updated and enabled SMSG_DISPEL_FAILED
2016-03-18 23:53:29 +01:00
if (!dispelFailed.FailedSpells.empty())
m_caster->SendMessageToSet(dispelFailed.Write(), true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
if (successList.empty())
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Packets: Updated and enabled SMSG_SPELL_DISPELL_LOG
2016-02-29 01:54:18 +00:00
WorldPackets::CombatLog::SpellDispellLog spellDispellLog;
spellDispellLog.IsBreak = false; // TODO: use me
spellDispellLog.IsSteal = false;
spellDispellLog.TargetGUID = unitTarget->GetGUID();
spellDispellLog.CasterGUID = m_caster->GetGUID();
spellDispellLog.DispelledBySpellID = m_spellInfo->Id;
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
for (DispelableAura const& dispelableAura : successList)
Core/Packets: Updated and enabled SMSG_SPELL_DISPELL_LOG
2016-02-29 01:54:18 +00:00
{
WorldPackets::CombatLog::SpellDispellData dispellData;
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
dispellData.SpellID = dispelableAura.GetAura()->GetId();
Core/Packets: Updated and enabled SMSG_SPELL_DISPELL_LOG
2016-02-29 01:54:18 +00:00
dispellData.Harmful = false; // TODO: use me
dispellData.Rolled = boost::none; // TODO: use me
dispellData.Needed = boost::none; // TODO: use me
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
unitTarget->RemoveAurasDueToSpellByDispel(dispelableAura.GetAura()->GetId(), m_spellInfo->Id, dispelableAura.GetAura()->GetCasterGUID(), m_caster, dispelableAura.GetDispelCharges());
Core/Packets: Updated and enabled SMSG_SPELL_DISPELL_LOG
2016-02-29 01:54:18 +00:00
spellDispellLog.DispellData.emplace_back(dispellData);
}
m_caster->SendMessageToSet(spellDispellLog.Write(), true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
CallScriptSuccessfulDispel(SpellEffIndex(effectInfo->EffectIndex));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDualWield()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
[svn] Provide creature dual wield support.
2008-10-29 20:00:21 -05:00
unitTarget->SetCanDualWield(true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDistract()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Check for possible target
[3.3.5] Combat/Threat rewrite - prep & refactor (#19966)
2017-07-01 20:18:02 +02:00
if (!unitTarget || unitTarget->IsEngaged())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// target must be OK to do this
Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_*
2012-02-03 19:12:41 +02:00
if (unitTarget->HasUnitState(UNIT_STATE_CONFUSED | UNIT_STATE_STUNNED | UNIT_STATE_FLEEING))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Movement: MotionMaster reimplementation (#21888)
2018-06-03 10:06:57 -07:00
unitTarget->GetMotionMaster()->MoveDistract(damage * IN_MILLISECONDS, unitTarget->GetAbsoluteAngle(destTarget));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPickPocket()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// victim must be creature and attackable
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT || m_caster->IsFriendlyTo(unitTarget))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// victim have to be alive and humanoid or undead
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (unitTarget->IsAlive() && (unitTarget->GetCreatureTypeMask() &CREATURE_TYPEMASK_HUMANOID_OR_UNDEAD) != 0)
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->ToPlayer()->SendLoot(unitTarget->GetGUID(), LOOT_PICKPOCKETING);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectAddFarsight()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Player* player = m_caster->ToPlayer();
if (!player)
[svn] * Reimplemented packet/update forwarding in more generic way
2008-11-14 20:40:35 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
float radius = effectInfo->CalcRadius();
Core/Entities: Basic AreaTrigger System (#18035)
2017-01-29 00:00:43 +01:00
int32 duration = m_spellInfo->CalcDuration(m_caster);
Do not allow units that are not in world to create dynamic objects from spell effect handlers
2010-01-24 23:47:17 +01:00
// Caster not in world, might be spell triggered from aura removal
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!player->IsInWorld())
Do not allow units that are not in world to create dynamic objects from spell effect handlers
2010-01-24 23:47:17 +01:00
return;
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
Update grid system. Try to fix some crashes and transport passengers (now they are despawned after a while).
2011-12-20 17:05:08 -05:00
DynamicObject* dynObj = new DynamicObject(true);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!dynObj->CreateDynamicObject(player->GetMap()->GenerateLowGuid<HighGuid::DynamicObject>(), player, m_spellInfo, *destTarget, radius, DYNAMIC_OBJECT_FARSIGHT_FOCUS, m_SpellVisual))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
delete dynObj;
return;
}
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
Update aura system:
2010-01-10 01:23:15 +01:00
dynObj->SetDuration(duration);
Core/DynamicObjects: Change the way how dynamic objects are bound to their owners, fixes some crashes in Aura::GetOwner.
2011-02-04 00:27:43 +01:00
dynObj->SetCasterViewpoint();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUntrainTalents()
Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
2010-12-22 20:14:30 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
2010-12-22 20:14:30 +02:00
if (!unitTarget || m_caster->GetTypeId() == TYPEID_PLAYER)
return;
Core/Opcodes: sync with wpp
2015-01-17 03:55:29 +01:00
unitTarget->ToPlayer()->SendRespecWipeConfirm(m_caster->GetGUID(), sWorld->getBoolConfig(CONFIG_NO_RESET_TALENT_COST) ? 0 : unitTarget->ToPlayer()->GetNextResetTalentsCost());
Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
2010-12-22 20:14:30 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTeleUnitsFaceCaster()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (unitTarget->IsInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
float dis = effectInfo->CalcRadius(m_caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
float fx, fy, fz;
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
2017-03-23 00:43:04 +01:00
m_caster->GetClosePoint(fx, fy, fz, unitTarget->GetCombatReach(), dis);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
unitTarget->NearTeleportTo(fx, fy, fz, -m_caster->GetOrientation(), unitTarget == m_caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLearnSkill()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Players: Update profession rank handling with new split skill values for each expansion
2018-12-02 17:39:41 +01:00
if (damage < 1)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 skillid = effectInfo->MiscValue;
Core/DataStores: Updated dbc/db2 to 7.0.1.20810
2016-01-24 15:56:10 +01:00
SkillRaceClassInfoEntry const* rcEntry = sDB2Manager.GetSkillRaceClassInfo(skillid, unitTarget->getRace(), unitTarget->getClass());
Core/Skills: Check if a skill can be unlearned with SkillRaceClassInfo.dbc data and use max skill level from SkillTiers.dbc
2014-06-25 20:34:10 +02:00
if (!rcEntry)
return;
Core/DataStores: Moved SkillTiers to database - it no longer exists in dbc form
2015-07-05 01:18:57 +02:00
SkillTiersEntry const* tier = sObjectMgr->GetSkillTier(rcEntry->SkillTierID);
Core/Skills: Check if a skill can be unlearned with SkillRaceClassInfo.dbc data and use max skill level from SkillTiers.dbc
2014-06-25 20:34:10 +02:00
if (!tier)
return;
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
uint16 skillval = unitTarget->ToPlayer()->GetPureSkillValue(skillid);
Core/Players: Update profession rank handling with new split skill values for each expansion
2018-12-02 17:39:41 +01:00
unitTarget->ToPlayer()->SetSkill(skillid, damage, std::max<uint16>(skillval, 1), tier->Value[damage - 1]);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPlayMovie()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 movieId = effectInfo->MiscValue;
if (!sMovieStore.LookupEntry(movieId))
return;
unitTarget->ToPlayer()->SendMovieStart(movieId);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTradeSkill()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
// uint32 skillid = m_spellInfo->Effects[i].MiscValue;
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
// uint16 skillmax = unitTarget->ToPlayer()->(skillid);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// m_caster->ToPlayer()->SetSkill(skillid, skillval?skillval:1, skillmax+75);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnchantItemPerm()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!itemTarget)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
if (!player)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// Handle vellums
Core/Items:
2012-08-15 16:30:49 +01:00
if (itemTarget->IsVellum())
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
{
// destroy one vellum from stack
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
uint32 count = 1;
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
player->DestroyItemCount(itemTarget, count, true);
unitTarget = player;
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// and add a scroll
Core/Spells: Force creating only 1 enchanting scroll when targeting a vellum with enchantments
2019-11-26 23:20:11 +01:00
damage = 1;
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
DoCreateItem(effectInfo->ItemType, m_spellInfo->HasAttribute(SPELL_ATTR0_TRADESPELL) ? ItemContext::Trade_Skill : ItemContext::NONE);
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
itemTarget = nullptr;
m_targets.SetItemTarget(nullptr);
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
}
else
{
*Do not apply auras with 4th diminishing level
2009-05-01 17:21:16 +02:00
// do not increase skill if vellum used
Core/Items: Defined all item flags
2016-09-09 10:22:57 +02:00
if (!(m_CastItem && m_CastItem->GetTemplate()->GetFlags() & ITEM_FLAG_NO_REAGENT_COST))
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
player->UpdateCraftSkill(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 enchant_id = effectInfo->MiscValue;
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
if (!enchant_id)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
SpellItemEnchantmentEntry const* pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pEnchant)
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
return;
Copyright header updates - part 3... (and some whitespace cleanups)
2010-10-07 14:00:52 +02:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// item can be in trade slot and have owner diff. from caster
Player* item_owner = itemTarget->GetOwner();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!item_owner)
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/RBAC: Move RBAC code to namespace rbac
2013-09-27 12:46:01 +02:00
if (item_owner != player && player->GetSession()->HasPermission(rbac::RBAC_PERM_LOG_GM_TRADE))
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
{
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
sLog->outCommand(player->GetSession()->GetAccountId(), "GM %s (Account: %u) enchanting(perm): %s (Entry: %d) for player: %s (Account: %u)",
player->GetName().c_str(), player->GetSession()->GetAccountId(),
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
itemTarget->GetTemplate()->GetDefaultLocaleName(), itemTarget->GetEntry(),
Core/Misc: reduced amount of string memory allocations (Step I)
2012-10-24 13:29:34 +02:00
item_owner->GetName().c_str(), item_owner->GetSession()->GetAccountId());
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// remove old enchanting before applying new if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PERM_ENCHANTMENT_SLOT, false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items
2013-05-25 11:09:21 +02:00
itemTarget->SetEnchantment(PERM_ENCHANTMENT_SLOT, enchant_id, 0, 0, m_caster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// add new enchanting if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PERM_ENCHANTMENT_SLOT, true);
Core/Items: Implemented trading soulbound loot items
2010-09-21 21:55:16 +02:00
Core/Items: Remove item from tradeable list when clearing the flag on enchanting/gemming
2012-06-23 12:31:46 +02:00
item_owner->RemoveTradeableItem(itemTarget);
Core/Items: Split SetSoulboundTradeable in two functions (Set and Clear)
2011-10-18 10:44:45 +02:00
itemTarget->ClearSoulboundTradeable(item_owner);
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnchantItemPrismatic()
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
if (!itemTarget)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
if (!player)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 enchantId = effectInfo->MiscValue;
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
if (!enchantId)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
SpellItemEnchantmentEntry const* enchant = sSpellItemEnchantmentStore.LookupEntry(enchantId);
if (!enchant)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// support only enchantings with add socket in this slot
{
bool add_socket = false;
Magic numbers cleanup:
2010-09-28 08:21:51 +03:00
for (uint8 i = 0; i < MAX_ITEM_ENCHANTMENT_EFFECTS; ++i)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
Core/DataStores: Updating spells dbc part 2
2014-11-10 02:51:55 +02:00
if (enchant->Effect[i] == ITEM_ENCHANTMENT_TYPE_PRISMATIC_SOCKET)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
add_socket = true;
break;
}
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!add_socket)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "Spell::EffectEnchantItemPrismatic: attempt to apply the enchant spell %u with SPELL_EFFECT_ENCHANT_ITEM_PRISMATIC (%u), but without ITEM_ENCHANTMENT_TYPE_PRISMATIC_SOCKET (%u), not supported yet.",
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_spellInfo->Id, SPELL_EFFECT_ENCHANT_ITEM_PRISMATIC, ITEM_ENCHANTMENT_TYPE_PRISMATIC_SOCKET);
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// item can be in trade slot and have owner diff. from caster
Player* item_owner = itemTarget->GetOwner();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!item_owner)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/RBAC: Move RBAC code to namespace rbac
2013-09-27 12:46:01 +02:00
if (item_owner != player && player->GetSession()->HasPermission(rbac::RBAC_PERM_LOG_GM_TRADE))
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
sLog->outCommand(player->GetSession()->GetAccountId(), "GM %s (Account: %u) enchanting(perm): %s (Entry: %d) for player: %s (Account: %u)",
player->GetName().c_str(), player->GetSession()->GetAccountId(),
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
itemTarget->GetTemplate()->GetDefaultLocaleName(), itemTarget->GetEntry(),
Core/Misc: reduced amount of string memory allocations (Step I)
2012-10-24 13:29:34 +02:00
item_owner->GetName().c_str(), item_owner->GetSession()->GetAccountId());
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// remove old enchanting before applying new if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PRISMATIC_ENCHANTMENT_SLOT, false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
itemTarget->SetEnchantment(PRISMATIC_ENCHANTMENT_SLOT, enchantId, 0, 0, m_caster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// add new enchanting if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PRISMATIC_ENCHANTMENT_SLOT, true);
Core/Items: Implemented trading soulbound loot items
2010-09-21 21:55:16 +02:00
Core/Items: Remove item from tradeable list when clearing the flag on enchanting/gemming
2012-06-23 12:31:46 +02:00
item_owner->RemoveTradeableItem(itemTarget);
Core/Items: Split SetSoulboundTradeable in two functions (Set and Clear)
2011-10-18 10:44:45 +02:00
itemTarget->ClearSoulboundTradeable(item_owner);
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnchantItemTmp()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Add nullptr itemTarget check in Spell::EffectEnchantItemTmp (#26172)
2021-02-28 19:10:27 +02:00
if (!itemTarget)
return;
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
if (!player)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 enchant_id = effectInfo->MiscValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!enchant_id)
{
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
TC_LOG_ERROR("spells", "Spell %u Effect %u (SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY) has enchanting id 0.", m_spellInfo->Id, effectInfo->EffectIndex);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
SpellItemEnchantmentEntry const* pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pEnchant)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
TC_LOG_ERROR("spells", "Spell %u Effect %u (SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY) has a non-existing enchanting id %u ", m_spellInfo->Id, effectInfo->EffectIndex, enchant_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// select enchantment duration
uint32 duration;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// rogue family enchantments exception by duration
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_spellInfo->Id == 38615)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 1800; // 30 mins
// other rogue family enchantments always 1 hour (some have spell damage=0, but some have wrong data in EffBasePoints)
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_ROGUE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 3600; // 1 hour
// shaman family enchantments
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_SHAMAN)
Core/DataStores: Updated dbc/db2 structures to 6.2.0
2015-07-07 12:13:14 +02:00
duration = 3600; // 30 mins
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// other cases with this SpellVisual already selected
Core/Auras: Implemented SPELL_AURA_OVERRIDE_SPELL_VISUAL
2016-06-29 19:49:23 +02:00
else if (m_spellInfo->GetSpellVisual() == 215)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 1800; // 30 mins
Fixed duration on Glow Worm
2010-05-24 13:56:21 +02:00
// some fishing pole bonuses except Glow Worm which lasts full hour
Core/Auras: Implemented SPELL_AURA_OVERRIDE_SPELL_VISUAL
2016-06-29 19:49:23 +02:00
else if (m_spellInfo->GetSpellVisual() == 563 && m_spellInfo->Id != 64401)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 600; // 10 mins
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->Id == 29702)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 300; // 5 mins
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->Id == 37360)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 300; // 5 mins
// default case
else
duration = 3600; // 1 hour
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// item can be in trade slot and have owner diff. from caster
Player* item_owner = itemTarget->GetOwner();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!item_owner)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/RBAC: Move RBAC code to namespace rbac
2013-09-27 12:46:01 +02:00
if (item_owner != player && player->GetSession()->HasPermission(rbac::RBAC_PERM_LOG_GM_TRADE))
*Update to Mangos 6848. Source: Mangos.
2008-11-25 16:36:50 -06:00
{
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
sLog->outCommand(player->GetSession()->GetAccountId(), "GM %s (Account: %u) enchanting(temp): %s (Entry: %d) for player: %s (Account: %u)",
player->GetName().c_str(), player->GetSession()->GetAccountId(),
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
itemTarget->GetTemplate()->GetDefaultLocaleName(), itemTarget->GetEntry(),
Core/Misc: reduced amount of string memory allocations (Step I)
2012-10-24 13:29:34 +02:00
item_owner->GetName().c_str(), item_owner->GetSession()->GetAccountId());
*Update to Mangos 6848. Source: Mangos.
2008-11-25 16:36:50 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// remove old enchanting before applying new if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, TEMP_ENCHANTMENT_SLOT, false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items
2013-05-25 11:09:21 +02:00
itemTarget->SetEnchantment(TEMP_ENCHANTMENT_SLOT, enchant_id, duration * 1000, 0, m_caster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// add new enchanting if equipped
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
item_owner->ApplyEnchantment(itemTarget, TEMP_ENCHANTMENT_SLOT, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTameCreature()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !unitCaster->GetPetGUID().IsEmpty())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
Creature* creatureTarget = unitTarget->ToCreature();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/SAI: Add check so npc will not send text to pet. Also updated isPet() to IsPet().
2013-06-11 18:39:51 -02:30
if (creatureTarget->IsPet())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster->getClass() != CLASS_HUNTER)
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// cast finish successfully
//SendChannelUpdate(0);
finish();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Pet* pet = unitCaster->CreateTamedPetFrom(creatureTarget, m_spellInfo->Id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pet) // in very specific state like near world end/etc.
[7937] Check OpenSSL lib at server start up. Author: AlexDereka
2009-06-02 17:40:22 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8040] Implement Creature::ForcedDespawn and ACTION_T_FORCE_DESPAWN for EventAI. Author: NoFantasy
2009-06-18 17:05:01 -05:00
// "kill" original creature
Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon
2011-01-02 21:33:37 +01:00
creatureTarget->DespawnOrUnsummon();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Creatures: Implemented Basic Creature Scaling (#20026)
2017-07-29 21:40:28 +02:00
uint8 level = (creatureTarget->GetLevelForTarget(m_caster) < (m_caster->GetLevelForTarget(creatureTarget) - 5)) ? (m_caster->GetLevelForTarget(creatureTarget) - 5) : creatureTarget->GetLevelForTarget(m_caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// prepare visual effect for levelup
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
pet->SetLevel(level - 1);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// add to world
Rename Map::Add to Map::AddToMap, Map::Remove to Map::RemoveFromMap for better management.
2011-10-10 17:39:34 -04:00
pet->GetMap()->AddToMap(pet->ToCreature());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// visual effect for levelup
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
pet->SetLevel(level);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// caster have pet now
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->SetMinion(pet, true);
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster->GetTypeId() == TYPEID_PLAYER)
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
{
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->ToPlayer()->PetSpellInitialize();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonPet()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
Player* owner = nullptr;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster)
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
owner = unitCaster->ToPlayer();
if (!owner && unitCaster->IsTotem())
owner = unitCaster->GetCharmerOrOwnerPlayerOrPlayerItself();
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 petentry = effectInfo->MiscValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!owner)
*Fix the bug that summoned guardians cause crash (do not use the previous one).
2008-12-30 22:01:45 -06:00
{
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
SummonPropertiesEntry const* properties = sSummonPropertiesStore.LookupEntry(67);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (properties)
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
SummonGuardian(effectInfo, petentry, properties, 1, ObjectGuid::Empty);
*Fix the bug that summoned guardians cause crash (do not use the previous one).
2008-12-30 22:01:45 -06:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Some random cleanups and code style fixes
2011-06-20 04:04:20 +07:00
Pet* OldSummon = owner->GetPet();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// if pet requested type already exist
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (OldSummon)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (petentry == 0 || OldSummon->GetEntry() == petentry)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// pet in corpse state can't be summoned
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (OldSummon->isDead())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*use ASSERT macro instead of regular assert for better output.
2010-07-30 20:04:28 +02:00
ASSERT(OldSummon->GetMap() == owner->GetMap());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
//OldSummon->GetMap()->Remove(OldSummon->ToCreature(), false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
float px, py, pz;
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
2017-03-23 00:43:04 +01:00
owner->GetClosePoint(px, py, pz, OldSummon->GetCombatReach());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix a crash caused by recall pet. Thanks to nanouniko
2009-08-26 21:17:47 -05:00
OldSummon->NearTeleportTo(px, py, pz, OldSummon->GetOrientation());
//OldSummon->Relocate(px, py, pz, OldSummon->GetOrientation());
//OldSummon->SetMap(owner->GetMap());
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
//owner->GetMap()->Add(OldSummon->ToCreature());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (owner->GetTypeId() == TYPEID_PLAYER && OldSummon->isControlled())
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
owner->ToPlayer()->PetSpellInitialize();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (owner->GetTypeId() == TYPEID_PLAYER)
Add spaces after commas
2011-04-29 20:47:02 +02:00
owner->ToPlayer()->RemovePet(OldSummon, (OldSummon->getPetType() == HUNTER_PET ? PET_SAVE_AS_DELETED : PET_SAVE_NOT_IN_SLOT), false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
float x, y, z;
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
2017-03-23 00:43:04 +01:00
owner->GetClosePoint(x, y, z, owner->GetCombatReach());
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
Pet* pet = owner->SummonPet(petentry, x, y, z, owner->GetOrientation(), SUMMON_PET, 0);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pet)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() == TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (m_caster->ToCreature()->IsTotem())
*Disable charmed/possessed creature AI.
2009-03-05 18:48:56 -06:00
pet->SetReactState(REACT_AGGRESSIVE);
*Merge from Mangos. Add MapReference. Author: hunuza.
2008-11-18 19:40:06 -06:00
else
*Disable charmed/possessed creature AI.
2009-03-05 18:48:56 -06:00
pet->SetReactState(REACT_DEFENSIVE);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
pet->SetCreatedBySpell(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
// generate new name for summon pet
Core/Misc: Port all the refactors sneaked in master to 3.3.5 include cleanup port
2020-09-04 13:38:24 +02:00
std::string new_name = sObjectMgr->GeneratePetName(petentry);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!new_name.empty())
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
pet->SetName(new_name);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), pet);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLearnPetSpell()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:01:18 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:01:18 +02:00
if (unitTarget->ToPlayer())
{
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
EffectLearnSpell();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:01:18 +02:00
}
Pet* pet = unitTarget->ToPet();
if (!pet)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* learn_spellproto = sSpellMgr->GetSpellInfo(effectInfo->TriggerSpell, DIFFICULTY_NONE);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!learn_spellproto)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pet->learnSpell(learn_spellproto->Id);
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:01:18 +02:00
pet->GetOwner()->PetSpellInitialize();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTaunt()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// this effect use before aura Taunt apply for prevent taunt already attacking target
// for spell as marked "non effective at already attacking target"
Core: Combat/threat system rewrite (PR #19930)
2018-01-03 20:04:19 +01:00
if (!unitTarget || !unitTarget->CanHaveThreatList())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix incorrect threat calculation of taunt spells.
2009-04-17 18:08:52 -05:00
SendCastResult(SPELL_FAILED_DONT_REPORT);
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Combat/threat system rewrite (PR #19930)
2018-01-03 20:04:19 +01:00
ThreatManager& mgr = unitTarget->GetThreatManager();
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (mgr.GetCurrentVictim() == unitCaster)
*Fix incorrect threat calculation of taunt spells.
2009-04-17 18:08:52 -05:00
{
Core: Combat/threat system rewrite (PR #19930)
2018-01-03 20:04:19 +01:00
SendCastResult(SPELL_FAILED_DONT_REPORT);
return;
Merge pull request #14969 from chaodhib/taunt_threat_fixes
2015-06-29 19:53:28 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Combat/threat system rewrite (PR #19930)
2018-01-03 20:04:19 +01:00
if (!mgr.IsThreatListEmpty())
// Set threat equal to highest threat currently on target
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
mgr.MatchUnitThreatToHighestThreat(unitCaster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectWeaponDmg()
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// multiple weapon dmg effect workaround
// execute only the last weapon damage
// and handle all effects at once
Core/Spells: Fixed Spell::EffectWeaponDmg for spells with multiple damage effects
2021-08-28 19:53:53 +02:00
for (size_t j = effectInfo->EffectIndex + 1; j < m_spellInfo->GetEffects().size(); ++j)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
switch (m_spellInfo->GetEffect(SpellEffIndex(j)).Effect)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELL_EFFECT_WEAPON_DAMAGE:
case SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL:
case SPELL_EFFECT_NORMALIZED_WEAPON_DMG:
case SPELL_EFFECT_WEAPON_PERCENT_DAMAGE:
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
return; // we must calculate only at last weapon effect
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
default:
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// some spell specific modifiers
float totalDamagePercentMod = 1.0f; // applied to final bonus+weapon damage
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
int32 fixed_bonus = 0;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 spell_bonus = 0; // bonus specific for spell
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
switch (m_spellInfo->SpellFamilyName)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELLFAMILY_SHAMAN:
{
// Skyshatter Harness item set bonus
// Stormstrike
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (AuraEffect* aurEff = unitCaster->IsScriptOverriden(m_spellInfo, 5634))
unitCaster->CastSpell(nullptr, 38430, aurEff);
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
bool normalized = false;
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
float weaponDamagePercentMod = 1.0f;
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
for (SpellEffectInfo const& spellEffectInfo : m_spellInfo->GetEffects())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
switch (spellEffectInfo.Effect)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELL_EFFECT_WEAPON_DAMAGE:
case SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL:
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
fixed_bonus += CalculateDamage(spellEffectInfo, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case SPELL_EFFECT_NORMALIZED_WEAPON_DMG:
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
fixed_bonus += CalculateDamage(spellEffectInfo, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
normalized = true;
break;
case SPELL_EFFECT_WEAPON_PERCENT_DAMAGE:
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
ApplyPct(weaponDamagePercentMod, CalculateDamage(spellEffectInfo, unitTarget));
[7562] Drop code for now not existed spell support. (Touch of Weakness triggered spell) Author: cccyril
2009-03-28 16:34:34 -06:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
break; // not weapon damage effect, just skip
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CRIT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras
2016-11-20 00:44:49 +01:00
// if (addPctMods) { percent mods are added in Unit::CalculateDamage } else { percent mods are added in Unit::MeleeDamageBonusDone }
// this distinction is neccessary to properly inform the client about his autoattack damage values from Script_UnitDamage
Core/Spells: Defined and implemented some new spell attributes (#18950)
2018-01-08 20:31:21 +01:00
bool const addPctMods = !m_spellInfo->HasAttribute(SPELL_ATTR6_IGNORE_CASTER_DAMAGE_MODIFIERS) && (m_spellSchoolMask & SPELL_SCHOOL_MASK_NORMAL);
Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CRIT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras
2016-11-20 00:44:49 +01:00
if (addPctMods)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
UnitMods unitMod;
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
switch (m_attackType)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
default:
case BASE_ATTACK: unitMod = UNIT_MOD_DAMAGE_MAINHAND; break;
case OFF_ATTACK: unitMod = UNIT_MOD_DAMAGE_OFFHAND; break;
case RANGED_ATTACK: unitMod = UNIT_MOD_DAMAGE_RANGED; break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
float weapon_total_pct = unitCaster->GetPctModifierValue(unitMod, TOTAL_PCT);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (fixed_bonus)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
fixed_bonus = int32(fixed_bonus * weapon_total_pct);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (spell_bonus)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
spell_bonus = int32(spell_bonus * weapon_total_pct);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
int32 weaponDamage = unitCaster->CalculateDamage(m_attackType, normalized, addPctMods);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
// Sequence is important
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
for (SpellEffectInfo const& spellEffectInfo : m_spellInfo->GetEffects())
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
{
// We assume that a spell have at most one fixed_bonus
// and at most one weaponDamagePercentMod
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
switch (spellEffectInfo.Effect)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
{
case SPELL_EFFECT_WEAPON_DAMAGE:
case SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL:
case SPELL_EFFECT_NORMALIZED_WEAPON_DMG:
weaponDamage += fixed_bonus;
break;
case SPELL_EFFECT_WEAPON_PERCENT_DAMAGE:
Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CRIT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras
2016-11-20 00:44:49 +01:00
weaponDamage = int32(weaponDamage * weaponDamagePercentMod);
Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells
2018-02-04 21:28:15 -03:00
break;
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
default:
break; // not weapon damage effect, just skip
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CRIT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras
2016-11-20 00:44:49 +01:00
weaponDamage += spell_bonus;
weaponDamage = int32(weaponDamage * totalDamagePercentMod);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent negative damage
Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells
2018-02-04 21:28:15 -03:00
weaponDamage = std::max(weaponDamage, 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Procflag patch by DiSlord.
2008-11-26 15:14:03 -06:00
// Add melee damage bonuses (also check for negative)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
weaponDamage = unitCaster->MeleeDamageBonusDone(unitTarget, weaponDamage, m_attackType, SPELL_DIRECT_DAMAGE, m_spellInfo);
m_damage += unitTarget->MeleeDamageBonusTaken(unitCaster, weaponDamage, m_attackType, SPELL_DIRECT_DAMAGE, m_spellInfo);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectThreat()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !unitCaster->IsAlive())
return;
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->CanHaveThreatList())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitTarget->GetThreatManager().AddThreat(unitCaster, float(damage), m_spellInfo, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectHealMaxHealth()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
int32 addhealth = 0;
* Core switch to client 3.3.2 (11403)
2010-02-14 19:13:14 -07:00
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
// damage == 0 - heal for caster max health
if (damage == 0)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
addhealth = unitCaster->GetMaxHealth();
*Lay on hands should have heal amount = caster's max health.
2009-05-31 20:45:34 -05:00
else
addhealth = unitTarget->GetMaxHealth() - unitTarget->GetHealth();
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
m_healing += addhealth;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectInterruptCast()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: add Target Processing (SMSG_SPELLLOGEXECUTE) to LAUNCH_TARGET phase.
2016-10-04 23:35:50 -03:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo not all spells that used this effect apply cooldown at school spells
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// also exist case: apply cooldown to interrupted cast only and to all spells
Core/Spells: Use dbc flag to check if channeled spell can be interrupted
2011-11-05 05:21:37 +07:00
// there is no CURRENT_AUTOREPEAT_SPELL spells that can be interrupted
for (uint32 i = CURRENT_FIRST_NON_MELEE_SPELL; i < CURRENT_AUTOREPEAT_SPELL; ++i)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
if (Spell* spell = unitTarget->GetCurrentSpell(CurrentSpellTypes(i)))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
SpellInfo const* curSpellInfo = spell->m_spellInfo;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// check if we can interrupt spell
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
if ((spell->getState() == SPELL_STATE_CASTING
Core/Misc: Rename Spell::CalcCastTime to Spell::GetCastTime as it does not calculate anything
2011-11-05 05:33:52 +07:00
|| (spell->getState() == SPELL_STATE_PREPARING && spell->GetCastTime() > 0.0f))
Core/Spells: Defined and implemented new spell interrupt flags
2021-03-24 23:36:53 +01:00
&& curSpellInfo->CanBeInterrupted(m_caster, unitTarget))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster)
*Let talents such as focused mind have effect on counterspell effects.
2008-12-15 09:55:57 -06:00
{
Add missing change in SpellEffects.cpp
2012-08-03 01:27:39 +03:00
int32 duration = m_spellInfo->GetDuration();
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
unitTarget->GetSpellHistory()->LockSpellSchool(curSpellInfo->GetSchoolMask(), unitTarget->ModSpellDuration(m_spellInfo, unitTarget, duration, false, 1 << effectInfo->EffectIndex));
Core/Spells: Split ProcFlags of PROC_HIT_INTERRUPT
2019-08-01 15:23:08 -03:00
if (m_spellInfo->DmgClass == SPELL_DAMAGE_CLASS_MAGIC)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Unit::ProcSkillsAndAuras(unitCaster, unitTarget, PROC_FLAG_DONE_SPELL_MAGIC_DMG_CLASS_NEG, PROC_FLAG_TAKEN_SPELL_MAGIC_DMG_CLASS_NEG,
Core/Spells: Split ProcFlags of PROC_HIT_INTERRUPT
2019-08-01 15:23:08 -03:00
PROC_SPELL_TYPE_MASK_ALL, PROC_SPELL_PHASE_HIT, PROC_HIT_INTERRUPT, nullptr, nullptr, nullptr);
else if (m_spellInfo->DmgClass == SPELL_DAMAGE_CLASS_MELEE)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Unit::ProcSkillsAndAuras(unitCaster, unitTarget, PROC_FLAG_DONE_SPELL_MELEE_DMG_CLASS, PROC_FLAG_TAKEN_SPELL_MELEE_DMG_CLASS,
Core/Spells: Split ProcFlags of PROC_HIT_INTERRUPT
2019-08-01 15:23:08 -03:00
PROC_SPELL_TYPE_MASK_ALL, PROC_SPELL_PHASE_HIT, PROC_HIT_INTERRUPT, nullptr, nullptr, nullptr);
*Let talents such as focused mind have effect on counterspell effects.
2008-12-15 09:55:57 -06:00
}
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
SendSpellInterruptLog(unitTarget, curSpellInfo->Id);
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
unitTarget->InterruptSpell(CurrentSpellTypes(i), false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonObjectWild()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
WorldObject* target = focusObject;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!target)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
target = m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
float x, y, z;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.HasDst())
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
destTarget->GetPosition(x, y, z);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
2017-03-23 00:43:04 +01:00
m_caster->GetClosePoint(x, y, z, DEFAULT_PLAYER_BOUNDING_RADIUS);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
Map* map = target->GetMap();
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
Position pos = Position(x, y, z, target->GetOrientation());
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
QuaternionData rot = QuaternionData::fromEulerAnglesZYX(target->GetOrientation(), 0.f, 0.f);
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
GameObject* go = GameObject::CreateGameObject(effectInfo->MiscValue, map, pos, rot, 255, GO_STATE_READY);
if (!go)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Phasing rewrite
2018-01-28 11:37:20 +01:00
PhasingHandler::InheritPhaseShift(go, m_caster);
Core/Phases: Preliminary work with correctly implementing the phase system in 4.3.4
2014-06-01 22:27:29 -05:00
Core/Entities: Basic AreaTrigger System (#18035)
2017-01-29 00:00:43 +01:00
int32 duration = m_spellInfo->CalcDuration(m_caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
go->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
go->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), go);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
// Wild object not have owner and check clickable by players
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
map->AddToMap(go);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
if (go->GetGoType() == GAMEOBJECT_TYPE_FLAGDROP)
Core/Battleground: Some minor optimizations here and there.
2012-10-04 12:49:58 +02:00
if (Player* player = m_caster->ToPlayer())
if (Battleground* bg = player->GetBattleground())
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
bg->SetDroppedFlagGUID(go->GetGUID(), player->GetTeam() == ALLIANCE ? TEAM_HORDE: TEAM_ALLIANCE);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
if (GameObject* linkedTrap = go->GetLinkedTrap())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Entities: Phasing rewrite
2018-01-28 11:37:20 +01:00
PhasingHandler::InheritPhaseShift(linkedTrap , m_caster);
Core/Phases: Preliminary work with correctly implementing the phase system in 4.3.4
2014-06-01 22:27:29 -05:00
Core/GameObject: spawn linked traps at gameobject creation instead of using DB spawns. (#18172)
2016-11-01 22:24:03 +01:00
linkedTrap->SetRespawnTime(duration > 0 ? duration / IN_MILLISECONDS : 0);
linkedTrap->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), linkedTrap);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectScriptEffect()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo we must implement hunter pet summon at login there (spell 6962)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
/// @todo: move this to scripts
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (m_spellInfo->SpellFamilyName)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case SPELLFAMILY_GENERIC:
*Update to Mangos 6880. Source: Mangos.
2008-12-06 14:01:44 -06:00
{
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (m_spellInfo->Id)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
[8351] Implement spell 55693. Author: VladimirMangos
2009-08-12 20:47:54 -05:00
case 55693: // Remove Collapsing Cave Aura
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[8351] Implement spell 55693. Author: VladimirMangos
2009-08-12 20:47:54 -05:00
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
unitTarget->RemoveAurasDueToSpell(effectInfo->CalcValue());
[8351] Implement spell 55693. Author: VladimirMangos
2009-08-12 20:47:54 -05:00
break;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Bending Shinbone
case 8856:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!itemTarget && m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
uint32 const spell_id = roll_chance_i(20) ? 8854 : 8855;
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, spell_id, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
}
// Brittle Armor - need remove one 24575 Brittle Armor aura
case 24590:
*Update of aura system.
2009-04-06 13:31:14 +02:00
unitTarget->RemoveAuraFromStack(24575);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
// Mercurial Shield - need remove one 26464 Mercurial Shield aura
case 26465:
*Update of aura system.
2009-04-06 13:31:14 +02:00
unitTarget->RemoveAuraFromStack(26464);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
// Shadow Flame (All script effects, not just end ones to prevent player from dodging the last triggered spell)
case 22539:
case 22972:
case 22975:
case 22976:
case 22977:
case 22978:
case 22979:
case 22980:
case 22981:
case 22982:
case 22983:
case 22984:
case 22985:
{
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || !unitTarget->IsAlive())
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Onyxia Scale Cloak
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->HasAura(22683))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Shadow Flame
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(unitTarget, 22682, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
}
// Mirren's Drinking Hat
case 29830:
{
uint32 item = 0;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
switch (urand(1, 6))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
case 1:
case 2:
case 3:
item = 23584; break; // Loch Modan Lager
case 4:
case 5:
item = 23585; break; // Stouthammer Lite
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case 6:
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
item = 23586; break; // Aerie Peak Pale Ale
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
if (item)
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
DoCreateItem(item);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
}
more updates
2012-06-03 02:35:00 +02:00
case 20589: // Escape artist
case 30918: // Improved Sprint
Fixed spell Spirit Walk. by Ouden
2009-12-24 13:01:39 +01:00
{
// Removes snares and roots.
Implemented binary resistances and some more (#18933)
2017-02-04 23:50:32 +01:00
unitTarget->RemoveMovementImpairingAuras(true);
Fixed spell Spirit Walk. by Ouden
2009-12-24 13:01:39 +01:00
break;
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
// Plant Warmaul Ogre Banner
case 32307:
Compile fix (typo in ceefc8c3d7)
2011-07-08 11:45:18 +02:00
if (Player* caster = m_caster->ToPlayer())
Core/Misc: Replace dynamic_cast<XXX*> with proper ToXXX
2011-07-08 11:12:19 +02:00
{
caster->RewardPlayerAndGroupAtEvent(18388, unitTarget);
if (Creature* target = unitTarget->ToCreature())
Core/Creatures: Various fixes for creatures, regarding combat conditions, despawning, and few others (#18998)
2017-02-05 15:39:22 +01:00
target->DespawnOrUnsummon();
Core/Misc: Replace dynamic_cast<XXX*> with proper ToXXX
2011-07-08 11:12:19 +02:00
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
break;
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
// Mug Transformation
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case 41931:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
uint8 bag = 19;
uint8 slot = 0;
Core/Misc: Replace NULL with nullptr
2020-08-14 17:06:03 +02:00
Item* item = nullptr;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
while (bag) // 256 = 0 due to var type
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
item = m_caster->ToPlayer()->GetItemByPos(bag, slot);
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
if (item && item->GetEntry() == 38587)
break;
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
++slot;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
if (slot == 39)
{
slot = 0;
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
++bag;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
}
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if (bag)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
if (m_caster->ToPlayer()->GetItemByPos(bag, slot)->GetCount() == 1) m_caster->ToPlayer()->RemoveItem(bag, slot, true);
else m_caster->ToPlayer()->GetItemByPos(bag, slot)->SetCount(m_caster->ToPlayer()->GetItemByPos(bag, slot)->GetCount()-1);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Spell 42518 (Braufest - Gratisprobe des Braufest herstellen)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, 42518, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
}
break;
}
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
// Brutallus - Burn
case 45141:
case 45151:
{
//Workaround for Range ... should be global for every ScriptEffect
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
float radius = effectInfo->CalcRadius();
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
if (unitTarget && unitTarget->GetTypeId() == TYPEID_PLAYER && unitTarget->GetDistance(m_caster) >= radius && !unitTarget->HasAura(46394) && unitTarget != m_caster)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(unitTarget, 46394, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
break;
}
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Goblin Weather Machine
case 46203:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7716] Fixed some typos and possible crashes. Author: AlexDereka
2009-04-27 18:42:35 -05:00
uint32 spellId = 0;
Core/Misc: Replace rand() calls with SFMT
2014-07-22 21:43:19 +02:00
switch (rand32() % 4)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
case 0: spellId = 46740; break;
case 1: spellId = 46739; break;
case 2: spellId = 46738; break;
case 3: spellId = 46736; break;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(unitTarget, spellId, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
}
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
// 5,000 Gold
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case 46642:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->ModifyMoney(5000 * GOLD);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
}
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
// Death Knight Initiate Visual
case 51519:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT)
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
uint32 iTmpSpellId = 0;
switch (unitTarget->GetDisplayId())
{
case 25369: iTmpSpellId = 51552; break; // bloodelf female
case 25373: iTmpSpellId = 51551; break; // bloodelf male
case 25363: iTmpSpellId = 51542; break; // draenei female
case 25357: iTmpSpellId = 51541; break; // draenei male
case 25361: iTmpSpellId = 51537; break; // dwarf female
case 25356: iTmpSpellId = 51538; break; // dwarf male
case 25372: iTmpSpellId = 51550; break; // forsaken female
case 25367: iTmpSpellId = 51549; break; // forsaken male
case 25362: iTmpSpellId = 51540; break; // gnome female
case 25359: iTmpSpellId = 51539; break; // gnome male
case 25355: iTmpSpellId = 51534; break; // human female
case 25354: iTmpSpellId = 51520; break; // human male
case 25360: iTmpSpellId = 51536; break; // nightelf female
case 25358: iTmpSpellId = 51535; break; // nightelf male
case 25368: iTmpSpellId = 51544; break; // orc female
case 25364: iTmpSpellId = 51543; break; // orc male
case 25371: iTmpSpellId = 51548; break; // tauren female
case 25366: iTmpSpellId = 51547; break; // tauren male
case 25370: iTmpSpellId = 51545; break; // troll female
case 25365: iTmpSpellId = 51546; break; // troll male
default: return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(unitTarget, iTmpSpellId, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
Creature* npc = unitTarget->ToCreature();
Core/NPCs: Refactor equipments
2013-02-18 12:24:18 +00:00
npc->LoadEquipment();
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
return;
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
// Deathbolt from Thalgran Blightbringer
// reflected by Freya's Ward
// Retribution by Sevenfold Retribution
case 51854:
{
Core/Spells: Small cleanup in SpellEffects, spells always have caster
2010-12-22 20:18:34 +02:00
if (!unitTarget)
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
return;
if (unitTarget->HasAura(51845))
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(m_caster, 51856, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
else
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(unitTarget, 51855, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
break;
}
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
// Summon Ghouls On Scarlet Crusade
case 51904:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_targets.HasDst())
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
float radius = effectInfo->CalcRadius();
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
for (uint8 i = 0; i < 15; ++i)
Core/Spells: Reduce number of CastSpell overloads to 1
2021-10-03 19:58:03 +02:00
m_caster->CastSpell(m_caster->GetRandomPoint(*destTarget, radius), 54522, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
.SetOriginalCastId(m_castId));
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
break;
*Some improvement of DK start zone quests (no new quest fixed)
2009-05-27 23:33:21 -05:00
}
*Fix Coyote Spirit Despawn Aura (52172) and Blood Parrot Despawn Aura (60244) - inspired by Disassembler's patch.
2009-08-05 17:00:01 +02:00
case 52173: // Coyote Spirit Despawn
case 60243: // Blood Parrot Despawn
Core/Misc: Remove unneeded ToCreature() casts
2015-08-12 14:05:14 +02:00
if (unitTarget->GetTypeId() == TYPEID_UNIT && unitTarget->IsSummon())
Make a function(ToTempSummon()) which can convert Creature to TempSummon with a C++ cast(reinterpret_cast) and with a type check(isSummon()).
2010-03-27 16:08:14 +01:00
unitTarget->ToTempSummon()->UnSummon();
*Fix Coyote Spirit Despawn Aura (52172) and Blood Parrot Despawn Aura (60244) - inspired by Disassembler's patch.
2009-08-05 17:00:01 +02:00
return;
*Fix the bug that some traps without charges and spell radius cannot be triggered.
2009-06-03 23:24:57 -05:00
case 52479: // Gift of the Harvester
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitTarget && unitCaster)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitCaster->CastSpell(unitTarget, urand(0, 1) ? damage : 52505, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Fix the bug that some traps without charges and spell radius cannot be triggered.
2009-06-03 23:24:57 -05:00
return;
*Fix spell 53110.
2009-06-14 21:05:37 -05:00
case 53110: // Devour Humanoid
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(m_caster, damage, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Fix spell 53110.
2009-06-14 21:05:37 -05:00
return;
Core/Spells: Partially fix RP-GG
2011-11-12 02:36:18 +07:00
case 57347: // Retrieving (Wintergrasp RP-GG pickup spell)
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT || m_caster->GetTypeId() != TYPEID_PLAYER)
return;
unitTarget->ToCreature()->DespawnOrUnsummon();
return;
}
case 57349: // Drop RP-GG (Wintergrasp RP-GG at death drop spell)
{
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
// Delete item from inventory at death
m_caster->ToPlayer()->DestroyItemCount(damage, 5, true);
return;
}
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
case 58418: // Portal to Orgrimmar
case 58420: // Portal to Stormwind
{
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER || effectInfo->EffectIndex != 0)
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell system updates (no-compile-version_2)
2014-11-17 20:38:56 +01:00
// Effects for 58418 and 58420 are all DIFFICULTY_NONE so always valid
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
uint32 spellID = m_spellInfo->GetEffect(EFFECT_0).CalcValue();
uint32 questID = m_spellInfo->GetEffect(EFFECT_1).CalcValue();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Quests: Resolve ambiguity between QUEST_STATUS_COMPLETED and rewarded state by implementing QUEST_STATUS_REWARDED. The latter is not used in the database explicitly, only in the core. This is to prevent overhead by iterating over the rewarded quests storage multiple times.
2011-01-13 23:06:59 +01:00
if (unitTarget->ToPlayer()->GetQuestStatus(questID) == QUEST_STATUS_COMPLETE)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(unitTarget, spellID, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
return;
}
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
case 59317: // Teleporting
Core/Spells: clean up some code and move to spell script. Closes #7195
2012-09-06 11:00:37 -04:00
{
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
// return from top
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (unitTarget->ToPlayer()->GetAreaId() == 4637)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(unitTarget, 59316, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
// teleport atop
else
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitTarget->CastSpell(unitTarget, 59314, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
return;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
case 62482: // Grab Crate
Restore some commits from trinitycore2 3.1.3
2009-12-17 13:07:38 +01:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (Unit* seat = unitCaster->GetVehicleBase())
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
{
Core/Spells: More research on SPELL_ATTR6_ONLY_CAST_WHILE_POSSESSED and implement new research (original caster should be charmer or owner) and implement QAston's earlier research (only castable while possessed).
2011-08-18 20:24:46 +02:00
if (Unit* parent = seat->GetVehicleBase())
{
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo a hack, range = 11, should after some time cast, otherwise too far
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
unitCaster->CastSpell(parent, 62496, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
unitTarget->CastSpell(parent, damage, CastSpellExtraArgs()
.SetOriginalCastId(m_castId)); // DIFFICULTY_NONE, so effect always valid
Core/Spells: More research on SPELL_ATTR6_ONLY_CAST_WHILE_POSSESSED and implement new research (original caster should be charmer or owner) and implement QAston's earlier research (only castable while possessed).
2011-08-18 20:24:46 +02:00
}
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
}
}
return;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
}
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
case 60123: // Lightwell
*Fix Lightwell. By Elron
2009-08-10 15:52:11 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (m_caster->GetTypeId() != TYPEID_UNIT || !m_caster->ToCreature()->IsSummon())
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
uint32 spell_heal;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (m_caster->GetEntry())
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
{
case 31897: spell_heal = 7001; break;
case 31896: spell_heal = 27873; break;
case 31895: spell_heal = 27874; break;
case 31894: spell_heal = 28276; break;
case 31893: spell_heal = 48084; break;
case 31883: spell_heal = 48085; break;
default:
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "Unknown Lightwell spell caster %u.", m_caster->GetEntry());
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
return;
*Fix Lightwell. By Elron
2009-08-10 15:52:11 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Auras: Add functions for common actions on aura charges.
2011-06-07 17:25:34 +02:00
// proc a spellcast
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (Aura* chargesAura = m_caster->ToCreature()->GetAura(59907))
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
{
Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes
2021-10-03 14:58:35 +02:00
m_caster->CastSpell(unitTarget, spell_heal, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
.SetOriginalCaster(m_caster->ToCreature()->ToTempSummon()->GetSummonerGUID())
.SetOriginalCastId(m_castId));
Core/Auras: Add functions for common actions on aura charges.
2011-06-07 17:25:34 +02:00
if (chargesAura->ModCharges(-1))
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
m_caster->ToCreature()->ToTempSummon()->UnSummon();
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
}
Core/Spells: Fixed spell effect quest complete when quest was already in target's quest log
2011-06-15 20:46:49 +02:00
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
return;
*Fix Lightwell. By Elron
2009-08-10 15:52:11 -05:00
}
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
// Stoneclaw Totem
case 55328: // Rank 1
case 55329: // Rank 2
case 55330: // Rank 3
case 55332: // Rank 4
case 55333: // Rank 5
case 55335: // Rank 6
case 55278: // Rank 7
case 58589: // Rank 8
case 58590: // Rank 9
case 58591: // Rank 10
{
// Cast Absorb on totems
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint8 slot = SUMMON_SLOT_TOTEM; slot < MAX_TOTEM_SLOT; ++slot)
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->m_SummonSlot[slot])
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
continue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
Creature* totem = unitTarget->GetMap()->GetCreature(unitTarget->m_SummonSlot[slot]);
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (totem && totem->IsTotem())
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
{
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SPELLVALUE_BASE_POINT0, damage);
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
m_caster->CastSpell(totem, 55277, args);
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
}
}
break;
}
Fix spell 45668
2010-02-23 23:48:07 +01:00
case 45668: // Ultra-Advanced Proto-Typical Shortening Blaster
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT)
return;
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Fix spell 45668
2010-02-23 23:48:07 +01:00
if (roll_chance_i(50)) // chance unknown, using 50
return;
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Fix spell 45668
2010-02-23 23:48:07 +01:00
static uint32 const spellPlayer[5] =
{
45674, // Bigger!
45675, // Shrunk
45678, // Yellow
45682, // Ghost
45684 // Polymorph
};
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
static uint32 const spellTarget[5] =
{
Fix spell 45668
2010-02-23 23:48:07 +01:00
45673, // Bigger!
45672, // Shrunk
45677, // Yellow
45681, // Ghost
45683 // Polymorph
};
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(m_caster, spellPlayer[urand(0, 4)], CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
unitTarget->CastSpell(unitTarget, spellTarget[urand(0, 4)], CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
Fix spell 45668
2010-02-23 23:48:07 +01:00
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal DB scripted effect
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
TC_LOG_DEBUG("spells", "Spell ScriptStart spellid %u in EffectScriptEffect(%u)", m_spellInfo->Id, effectInfo->EffectIndex);
m_caster->GetMap()->ScriptsStart(sSpellScripts, uint32(m_spellInfo->Id | (effectInfo->EffectIndex << 24)), m_caster, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSanctuary()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Combat/threat system rewrite (PR #19930)
2018-01-03 20:04:19 +01:00
if (unitTarget->GetTypeId() == TYPEID_PLAYER && !unitTarget->GetMap()->IsDungeon())
Core/Spells: Effect sanctuary should stop attackers without threatlist too
2010-11-13 20:23:05 +01:00
{
Core: Combat/threat system rewrite (PR #19930)
2018-01-03 20:04:19 +01:00
// stop all pve combat for players outside dungeons, suppress pvp combat
unitTarget->CombatStop(false, false);
}
else
{
// in dungeons (or for nonplayers), reset this unit on all enemies' threat lists
for (auto const& pair : unitTarget->GetThreatManager().GetThreatenedByMeList())
Core/Threat: Threat system adjustments:
2018-08-27 19:08:17 +02:00
pair.second->ScaleThreat(0.0f);
Core/Spells: Effect sanctuary should stop attackers without threatlist too
2010-11-13 20:23:05 +01:00
}
Core: Combat/threat system rewrite (PR #19930)
2018-01-03 20:04:19 +01:00
// makes spells cast before this time fizzle
Ensure that all actions are compared to fixed point in time (ie. world update start) (#18910)
2017-03-02 02:19:25 +01:00
unitTarget->m_lastSanctuaryTime = GameTime::GetGameTimeMS();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDuel()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Small cleanup in SpellEffects, spells always have caster
2010-12-22 20:18:34 +02:00
if (!unitTarget || m_caster->GetTypeId() != TYPEID_PLAYER || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Some random cleanups and code style fixes
2011-06-20 04:04:20 +07:00
Player* caster = m_caster->ToPlayer();
Player* target = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// caster or target already have requested duel
Core/Social: Use full guid for friend and ignore storage
2014-10-22 12:52:12 +02:00
if (caster->duel || target->duel || !target->GetSocial() || target->GetSocial()->HasIgnore(caster->GetGUID()))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Players: Implemented AREA_FLAG_ALLOW_DUELS. Duels should be possible only at areas with this flag. Tnx to Destalker for pointing out this flag
2011-05-29 02:40:37 +07:00
// Players can only fight a duel in zones with this flag
Core/Maps: Changed the way area data is stored in maps, it now uses ID field from AreaTable.dbc instead AreaBit used for exploration marker (and is not unique anymore on top of simply being stupidly confusing)
2016-02-02 19:13:04 +01:00
AreaTableEntry const* casterAreaEntry = sAreaTableStore.LookupEntry(caster->GetAreaId());
Core/DataStores: Updated AreaTable.dbc
2014-11-13 02:30:19 +02:00
if (casterAreaEntry && !(casterAreaEntry->Flags[0] & AREA_FLAG_ALLOW_DUELS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
SendCastResult(SPELL_FAILED_NO_DUELING); // Dueling isn't allowed here
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Maps: Changed the way area data is stored in maps, it now uses ID field from AreaTable.dbc instead AreaBit used for exploration marker (and is not unique anymore on top of simply being stupidly confusing)
2016-02-02 19:13:04 +01:00
AreaTableEntry const* targetAreaEntry = sAreaTableStore.LookupEntry(target->GetAreaId());
Core/DataStores: Updated AreaTable.dbc
2014-11-13 02:30:19 +02:00
if (targetAreaEntry && !(targetAreaEntry->Flags[0] & AREA_FLAG_ALLOW_DUELS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
SendCastResult(SPELL_FAILED_NO_DUELING); // Dueling isn't allowed here
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//CREATE DUEL FLAG OBJECT
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Map* map = caster->GetMap();
Core/Entities: debloat SummonGameObject parameter list using proper wrappers and enable GO rotation in scripts
2016-07-30 18:50:44 -03:00
Position const pos =
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
caster->GetPositionX() + (unitTarget->GetPositionX() - caster->GetPositionX()) / 2,
caster->GetPositionY() + (unitTarget->GetPositionY() - caster->GetPositionY()) / 2,
caster->GetPositionZ(),
caster->GetOrientation()
Core/Entities: debloat SummonGameObject parameter list using proper wrappers and enable GO rotation in scripts
2016-07-30 18:50:44 -03:00
};
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
QuaternionData rot = QuaternionData::fromEulerAnglesZYX(pos.GetOrientation(), 0.f, 0.f);
Core/Entities: debloat SummonGameObject parameter list using proper wrappers and enable GO rotation in scripts
2016-07-30 18:50:44 -03:00
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
GameObject* go = GameObject::CreateGameObject(effectInfo->MiscValue, map, pos, rot, 0, GO_STATE_READY);
if (!go)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
PhasingHandler::InheritPhaseShift(go, caster);
Core/Phases: Preliminary work with correctly implementing the phase system in 4.3.4
2014-06-01 22:27:29 -05:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
go->SetFaction(caster->GetFaction());
go->SetLevel(caster->getLevel() + 1);
int32 duration = m_spellInfo->CalcDuration(caster);
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
go->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
go->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), go);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
caster->AddGameObject(go);
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
map->AddToMap(go);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//END
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Send request
Core/Packets: Updated and enabled duel opcodes
2015-04-02 18:43:33 +02:00
WorldPackets::Duel::DuelRequested packet;
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
packet.ArbiterGUID = go->GetGUID();
Core/Packets: Updated and enabled duel opcodes
2015-04-02 18:43:33 +02:00
packet.RequestedByGUID = caster->GetGUID();
packet.RequestedByWowAccount = caster->GetSession()->GetAccountGUID();
Core/Packets: Fix writing WorldPackets::Duel::DuelRequested
2015-04-02 18:58:35 +01:00
WorldPacket const* worldPacket = packet.Write();
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
caster->SendDirectMessage(worldPacket);
target->SendDirectMessage(worldPacket);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// create duel-info
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
DuelInfo* duel = new DuelInfo;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duel->initiator = caster;
duel->opponent = target;
duel->startTime = 0;
duel->startTimer = 0;
Scripts/Spells: Fix Argent Tournament mount spells:
2012-01-30 00:21:42 +01:00
duel->isMounted = (GetSpellInfo()->Id == 62875); // Mounted Duel
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
caster->duel = duel;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
DuelInfo* duel2 = new DuelInfo;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duel2->initiator = caster;
duel2->opponent = caster;
duel2->startTime = 0;
duel2->startTimer = 0;
Scripts/Spells: Fix Argent Tournament mount spells:
2012-01-30 00:21:42 +01:00
duel2->isMounted = (GetSpellInfo()->Id == 62875); // Mounted Duel
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
target->duel = duel2;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
caster->SetDuelArbiter(go->GetGUID());
target->SetDuelArbiter(go->GetGUID());
Core/ScriptMgr: Add hooks for duel phases: OnDuelRequest, OnDuelStart, OnDuelEnd
2010-09-13 01:42:14 +03:00
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
sScriptMgr->OnPlayerDuelRequest(target, caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectStuck()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (!sWorld->getBoolConfig(CONFIG_CAST_UNSTUCK))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
if (!player)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "Spell Effect: Stuck");
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_DEBUG("spells", "Player %s (%s) used the auto-unstuck feature at map %u (%f, %f, %f).", player->GetName().c_str(), player->GetGUID().ToString().c_str(), player->GetMapId(), player->GetPositionX(), player->GetPositionY(), player->GetPositionZ());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
if (player->IsInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Update Stuck effect 6.0.3
2015-01-26 20:25:37 +00:00
// if player is dead without death timer is teleported to graveyard, otherwise not apply the effect
if (player->isDead())
{
if (!player->GetDeathTimer())
player->RepopAtGraveyard();
Core/Spells: Reimplemented automatic spell learning
2015-01-30 23:58:16 +01:00
Core/Spells: Update Stuck effect 6.0.3
2015-01-26 20:25:37 +00:00
return;
}
Core/Spells: Correction Stuck effect (6.0.3)
2015-01-27 14:08:13 -06:00
// the player dies if hearthstone is in cooldown, else the player is teleported to home
Core/Spells: Cooldown updates
2015-02-17 01:01:44 +01:00
if (player->GetSpellHistory()->HasCooldown(8690))
Core/Spells: Correction Stuck effect (6.0.3)
2015-01-27 14:08:13 -06:00
{
Core/Auras: removed caster dependency from core
2018-01-13 06:45:21 -03:00
player->KillSelf();
Core/Spells: Correction Stuck effect (6.0.3)
2015-01-27 14:08:13 -06:00
return;
}
Core/Spells: Reimplemented automatic spell learning
2015-01-30 23:58:16 +01:00
Core/Characters: Made homebind location a WorldLocation (this implicitly adds orientation) (#27055)
2021-10-16 01:17:47 +02:00
player->TeleportTo(player->m_homebind, TELE_TO_SPELL);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Stuck spell trigger Hearthstone cooldown
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(8690, GetCastDifficulty());
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Spell spell(player, spellInfo, TRIGGERED_FULL_MASK);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
spell.SendSpellCooldown();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonPlayer()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
// workaround - this effect should not use target map
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitTarget->ToPlayer()->SendSummonRequestFrom(unitCaster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectActivateObject()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!gameObjTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Remove utterly wrong delay on GameObject activate spells
2011-07-05 02:58:14 +01:00
ScriptInfo activateCommand;
activateCommand.command = SCRIPT_COMMAND_ACTIVATE_OBJECT;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
// int32 unk = effectInfo->MiscValue; // This is set for EffectActivateObject spells; needs research
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Remove utterly wrong delay on GameObject activate spells
2011-07-05 02:58:14 +01:00
gameObjTarget->GetMap()->ScriptCommandStart(activateCommand, 0, m_caster, gameObjTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectApplyGlyph()
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
if (!player)
return;
Core/Players: Implemented new glyph system
2016-08-25 19:12:00 +02:00
std::vector<uint32>& glyphs = player->GetGlyphs(player->GetActiveTalentGroup());
std::size_t replacedGlyph = glyphs.size();
for (std::size_t i = 0; i < glyphs.size(); ++i)
{
if (std::vector<uint32> const* activeGlyphBindableSpells = sDB2Manager.GetGlyphBindableSpells(glyphs[i]))
{
if (std::find(activeGlyphBindableSpells->begin(), activeGlyphBindableSpells->end(), m_misc.SpellId) != activeGlyphBindableSpells->end())
{
replacedGlyph = i;
player->RemoveAurasDueToSpell(sGlyphPropertiesStore.AssertEntry(glyphs[i])->SpellID);
break;
}
}
}
uint32 glyphId = effectInfo->MiscValue;
if (replacedGlyph < glyphs.size())
{
if (glyphId)
glyphs[replacedGlyph] = glyphId;
else
glyphs.erase(glyphs.begin() + replacedGlyph);
}
else if (glyphId)
glyphs.push_back(glyphId);
if (GlyphPropertiesEntry const* glyphProperties = sGlyphPropertiesStore.LookupEntry(glyphId))
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
player->CastSpell(player, glyphProperties->SpellID, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
Core/Players: Implemented new glyph system
2016-08-25 19:12:00 +02:00
WorldPackets::Talent::ActiveGlyphs activeGlyphs;
activeGlyphs.Glyphs.emplace_back(m_misc.SpellId, uint16(glyphId));
activeGlyphs.IsFullUpdate = false;
player->SendDirectMessage(activeGlyphs.Write());
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnchantHeldItem()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// this is only item spell effect applied to main-hand weapon of target player (players in area)
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items
2013-05-25 11:09:21 +02:00
Player* item_owner = unitTarget->ToPlayer();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Item* item = item_owner->GetItemByPos(INVENTORY_SLOT_BAG_0, EQUIPMENT_SLOT_MAINHAND);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!item)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// must be equipped
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
if (!item->IsEquipped())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->MiscValue)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 enchant_id = effectInfo->MiscValue;
Merge pull request #15746 from Rushor/Venom
2015-10-20 17:31:21 +02:00
int32 duration = m_spellInfo->GetDuration(); //Try duration index first ..
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!duration)
Merge pull request #15746 from Rushor/Venom
2015-10-20 17:31:21 +02:00
duration = damage;//+1; //Base points after ..
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!duration)
Merge pull request #15746 from Rushor/Venom
2015-10-20 17:31:21 +02:00
duration = 10 * IN_MILLISECONDS; //10 seconds for enchants which don't have listed duration
if (m_spellInfo->Id == 14792) // Venomhide Poison
duration = 5 * MINUTE * IN_MILLISECONDS;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
SpellItemEnchantmentEntry const* pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pEnchant)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Always go to temp enchantment slot
EnchantmentSlot slot = TEMP_ENCHANTMENT_SLOT;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Enchantment will not be applied if a different one already exists
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (item->GetEnchantmentId(slot) && item->GetEnchantmentId(slot) != enchant_id)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Apply the temporary enchantment
Merge pull request #15746 from Rushor/Venom
2015-10-20 17:31:21 +02:00
item->SetEnchantment(slot, enchant_id, duration, 0, m_caster->GetGUID());
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
item_owner->ApplyEnchantment(item, slot, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDisEnchant()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
more updates
2012-06-03 02:35:00 +02:00
if (Player* caster = m_caster->ToPlayer())
{
caster->UpdateCraftSkill(m_spellInfo->Id);
caster->SendLoot(itemTarget->GetGUID(), LOOT_DISENCHANTING);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// item will be removed at disenchanting end
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectInebriate()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Players: Improved alcohol handling, weeeeeeeeeeeeeeeee
2012-08-07 17:45:10 +02:00
Player* player = unitTarget->ToPlayer();
uint8 currentDrunk = player->GetDrunkValue();
uint8 drunkMod = damage;
if (currentDrunk + drunkMod > 100)
Core/Spells: Add barfing to Spell::EffectInebriate.
2012-01-03 13:15:33 +01:00
{
Core/Players: Improved alcohol handling, weeeeeeeeeeeeeeeee
2012-08-07 17:45:10 +02:00
currentDrunk = 100;
if (rand_chance() < 25.0f)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
player->CastSpell(player, 67468, CastSpellExtraArgs()
.SetOriginalCastId(m_castId)); // Drunken Vomit
Core/Spells: Add barfing to Spell::EffectInebriate.
2012-01-03 13:15:33 +01:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
currentDrunk += drunkMod;
Core/Players: Improved alcohol handling, weeeeeeeeeeeeeeeee
2012-08-07 17:45:10 +02:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
player->SetDrunkValue(currentDrunk, m_CastItem ? m_CastItem->GetEntry() : 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectFeedPet()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spell: Fixed compile broken in 11fb0beaf0 and renamed _player to player.
2011-12-10 15:40:55 +01:00
Player* player = m_caster->ToPlayer();
if (!player)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Item* foodItem = itemTarget;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!foodItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: Fixed compile broken in 11fb0beaf0 and renamed _player to player.
2011-12-10 15:40:55 +01:00
Pet* pet = player->GetPet();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pet)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!pet->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectDestroyItem(SpellEffectName(effectInfo->Effect), foodItem->GetEntry());
Core/Spells: Fixed crash in EffectFeedPet
2010-09-02 22:04:08 +02:00
Core/Spells: Removed extra health from feed pet (#26305)
2021-04-22 23:02:19 +03:00
int32 pct;
int32 levelDiff = int32(pet->getLevel()) - int32(foodItem->GetTemplate()->GetBaseItemLevel());
if (levelDiff >= 30)
return;
else if (levelDiff >= 20)
pct = int32(12.5); // we can't pass double so keeping the cast here for future references
else if (levelDiff >= 10)
pct = 25;
else
pct = 50;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 count = 1;
Core/Spell: Fixed compile broken in 11fb0beaf0 and renamed _player to player.
2011-12-10 15:40:55 +01:00
player->DestroyItemCount(foodItem, count, true);
First step of comment style refactoring to doxygen-style.
2013-03-08 21:41:30 +01:00
/// @todo fix crash when a spell has two effects, both pointed at the same item target
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SPELLVALUE_BASE_POINT0, pct);
m_caster->CastSpell(pet, effectInfo->TriggerSpell, args);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDismissPet()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/SAI: Add check so npc will not send text to pet. Also updated isPet() to IsPet().
2013-06-11 18:39:51 -02:30
if (!unitTarget || !unitTarget->IsPet())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Pet* pet = unitTarget->ToPet();
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectUnsummonObject(SpellEffectName(effectInfo->Effect), pet);
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
pet->GetOwner()->RemovePet(pet, PET_SAVE_NOT_IN_SLOT);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonObject()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint8 slot = effectInfo->Effect - SPELL_EFFECT_SUMMON_OBJECT_SLOT1;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
ObjectGuid guid = unitCaster->m_ObjectSlot[slot];
Core/Entities: Second batch of removing implicit conversions of ObjectGuid to uint64
2014-10-21 20:27:00 +02:00
if (!guid.IsEmpty())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (GameObject* obj = unitCaster->GetMap()->GetGameObject(guid))
Backed out changeset 9b89f42ffbd8 - mangos [8219]
2009-07-30 11:45:51 +02:00
{
// Recast case - null spell id to make auras not be removed on object remove from world
if (m_spellInfo->Id == obj->GetSpellId())
obj->SetSpellId(0);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->RemoveGameObject(obj, true);
Backed out changeset 9b89f42ffbd8 - mangos [8219]
2009-07-30 11:45:51 +02:00
}
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->m_ObjectSlot[slot].Clear();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
float x, y, z;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// If dest location if present
*More update about positions.
2009-08-29 23:20:16 -05:00
if (m_targets.HasDst())
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
destTarget->GetPosition(x, y, z);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Summon in random point all other units if location present
else
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetClosePoint(x, y, z, DEFAULT_PLAYER_BOUNDING_RADIUS);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
Map* map = m_caster->GetMap();
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
Position pos = Position(x, y, z, m_caster->GetOrientation());
QuaternionData rot = QuaternionData::fromEulerAnglesZYX(m_caster->GetOrientation(), 0.f, 0.f);
GameObject* go = GameObject::CreateGameObject(effectInfo->MiscValue, map, pos, rot, 255, GO_STATE_READY);
if (!go)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Phasing rewrite
2018-01-28 11:37:20 +01:00
PhasingHandler::InheritPhaseShift(go, m_caster);
Core/Phases: Preliminary work with correctly implementing the phase system in 4.3.4
2014-06-01 22:27:29 -05:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
go->SetFaction(unitCaster->GetFaction());
go->SetLevel(unitCaster->getLevel());
Core/Entities: Basic AreaTrigger System (#18035)
2017-01-29 00:00:43 +01:00
int32 duration = m_spellInfo->CalcDuration(m_caster);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
go->SetRespawnTime(duration > 0 ? duration / IN_MILLISECONDS : 0);
Core/Misc: Fixed some issues found by Coverity Scan
2013-08-01 21:31:11 +02:00
go->SetSpellId(m_spellInfo->Id);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->AddGameObject(go);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), go);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
Core/Misc: Fixed some issues found by Coverity Scan
2013-08-01 21:31:11 +02:00
map->AddToMap(go);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->m_ObjectSlot[slot] = go->GetGUID();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectResurrect()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: convert some spells to SpellScripts
2013-01-20 04:30:17 +01:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (unitTarget->IsAlive() || !unitTarget->IsInWorld())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
REPO: Code-style clean-ups
2011-10-07 19:45:43 -05:00
Player* target = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
2014-05-25 21:52:27 +02:00
if (target->IsResurrectRequested()) // already have one active request
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
REPO: Code-style clean-ups
2011-10-07 19:45:43 -05:00
uint32 health = target->CountPctFromMaxHealth(damage);
Core/Utilities: Use generic templates with AddPct, ApplyPct and CalculatePct
2012-10-02 12:17:42 +02:00
uint32 mana = CalculatePct(target->GetMaxPower(POWER_MANA), damage);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectResurrect(SpellEffectName(effectInfo->Effect), target);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
target->SetResurrectRequestData(m_caster, health, mana, 0);
REPO: Code-style clean-ups
2011-10-07 19:45:43 -05:00
SendResurrectRequest(target);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectAddExtraAttacks()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Trigger extra attacks on proper target
2014-10-18 20:51:00 +01:00
if (!unitTarget || !unitTarget->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (unitTarget->m_extraAttacks)
*Merge.
2009-06-27 16:37:29 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
unitTarget->m_extraAttacks = damage;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectExtraAttacks(SpellEffectName(effectInfo->Effect), unitTarget, damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectParry()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (m_caster->GetTypeId() == TYPEID_PLAYER)
m_caster->ToPlayer()->SetCanParry(true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectBlock()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (m_caster->GetTypeId() == TYPEID_PLAYER)
m_caster->ToPlayer()->SetCanBlock(true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLeap()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (!unitTarget || unitTarget->IsInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_targets.HasDst())
[svn] Disable combat_reach spams.
2008-11-01 18:52:59 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: Change how Position struct is retrieved
2014-04-25 21:19:30 +02:00
Position pos = destTarget->GetPosition();
Core/Spells: Blink wont be able to trespass solid objects anymore (walls/doors)
2012-02-11 19:23:18 -05:00
unitTarget->NearTeleportTo(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ(), pos.GetOrientation(), unitTarget == m_caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectReputation()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: Fixed compile broken in 11fb0beaf0 and renamed _player to player.
2011-12-10 15:40:55 +01:00
Player* player = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Reputation: Implemented new reputation_reward_rate fields for dayily/weekly quests
2012-12-02 16:32:44 +01:00
int32 repChange = damage;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 factionId = effectInfo->MiscValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Reputation: Implemented new reputation_reward_rate fields for dayily/weekly quests
2012-12-02 16:32:44 +01:00
FactionEntry const* factionEntry = sFactionStore.LookupEntry(factionId);
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
if (!factionEntry)
return;
Core/Reputation: Implemented new reputation_reward_rate fields for dayily/weekly quests
2012-12-02 16:32:44 +01:00
repChange = player->CalculateReputationGain(REPUTATION_SOURCE_SPELL, 0, repChange, factionId);
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
Core/Reputation: Implemented new reputation_reward_rate fields for dayily/weekly quests
2012-12-02 16:32:44 +01:00
player->GetReputationMgr().ModifyReputation(factionEntry, repChange);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectQuestComplete()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
Fix SpellEffect Quest Complete: shall work if player is the unitTarget
2010-01-25 20:45:02 +01:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Player* player = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 questId = effectInfo->MiscValue;
Core/Spells: Fixed spell effect quest complete when quest was already in target's quest log
2011-06-15 20:46:49 +02:00
if (questId)
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
{
Core/Spells: Fixed spell effect quest complete when quest was already in target's quest log
2011-06-15 20:46:49 +02:00
Quest const* quest = sObjectMgr->GetQuestTemplate(questId);
if (!quest)
Added check quest conditions in effect EffectQuestComplete(16)
2011-06-15 20:24:47 +03:00
return;
Core/Spells: Fixed spell effect quest complete when quest was already in target's quest log
2011-06-15 20:46:49 +02:00
uint16 logSlot = player->FindQuestSlot(questId);
if (logSlot < MAX_QUEST_LOG_SIZE)
player->AreaExploredOrEventHappens(questId);
Core/Spell: allow SPELL_EFFECT_QUEST_COMPLETE to set a quest to rewarded only if that quest is used as internal flag by the server (has flag 1024 - QUEST_FLAGS_TRACKING).
2016-10-16 22:39:36 +02:00
else if (quest->HasFlag(QUEST_FLAGS_TRACKING)) // Check if the quest is used as a serverside flag.
player->SetRewardedQuest(questId); // If so, set status to rewarded without broadcasting it to client.
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectForceDeselect()
Change SPELL_EFFECT_SUMMON_PHANTAS to SPELL_EFFECT_FORCE_DESELECT and allow it to be casted with active pet
2010-01-13 10:27:44 +01:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
float dist = unitCaster->GetVisibilityRange();
Core/Spells: Fixed spell effect 93 (SPELL_EFFECT_FORCE_DESELECT) (#19001)
2017-02-04 20:21:12 +01:00
// clear focus
Core/Grids: Move packet sending functionality out of MessageDistDeliverer and into separate, customizable class and unify LocalizedPacketDo, LocalizedPacketListDo as generic localizable action
2021-05-01 20:16:10 +02:00
Trinity::PacketSenderOwning<WorldPackets::Combat::BreakTarget> breakTarget;
breakTarget.Data.UnitGUID = m_caster->GetGUID();
breakTarget.Data.Write();
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Trinity::MessageDistDelivererToHostile<Trinity::PacketSenderOwning<WorldPackets::Combat::BreakTarget>> notifierBreak(unitCaster, breakTarget, dist);
Core/Spells: Fixed spell effect 93 (SPELL_EFFECT_FORCE_DESELECT) (#19001)
2017-02-04 20:21:12 +01:00
Cell::VisitWorldObjects(m_caster, notifierBreak, dist);
// and selection
Core/Grids: Move packet sending functionality out of MessageDistDeliverer and into separate, customizable class and unify LocalizedPacketDo, LocalizedPacketListDo as generic localizable action
2021-05-01 20:16:10 +02:00
Trinity::PacketSenderOwning<WorldPackets::Spells::ClearTarget> clearTarget;
clearTarget.Data.Guid = m_caster->GetGUID();
clearTarget.Data.Write();
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Trinity::MessageDistDelivererToHostile<Trinity::PacketSenderOwning<WorldPackets::Spells::ClearTarget>> notifierClear(unitCaster, clearTarget, dist);
Core/Spells: Fixed spell effect 93 (SPELL_EFFECT_FORCE_DESELECT) (#19001)
2017-02-04 20:21:12 +01:00
Cell::VisitWorldObjects(m_caster, notifierClear, dist);
// we should also force pets to remove us from current target
Unit::AttackerSet attackerSet;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
for (Unit::AttackerSet::const_iterator itr = unitCaster->getAttackers().begin(); itr != unitCaster->getAttackers().end(); ++itr)
Core/Spells: Fixed spell effect 93 (SPELL_EFFECT_FORCE_DESELECT) (#19001)
2017-02-04 20:21:12 +01:00
if ((*itr)->GetTypeId() == TYPEID_UNIT && !(*itr)->CanHaveThreatList())
attackerSet.insert(*itr);
for (Unit::AttackerSet::const_iterator itr = attackerSet.begin(); itr != attackerSet.end(); ++itr)
(*itr)->AttackStop();
Change SPELL_EFFECT_SUMMON_PHANTAS to SPELL_EFFECT_FORCE_DESELECT and allow it to be casted with active pet
2010-01-13 10:27:44 +01:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSelfResurrect()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Player* player = m_caster->ToPlayer();
if (!player || !player->IsInWorld() || player->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 health = 0;
uint32 mana = 0;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// flat case
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
health = uint32(-damage);
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
mana = effectInfo->MiscValue;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
// percent case
else
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
health = player->CountPctFromMaxHealth(damage);
if (player->GetMaxPower(POWER_MANA) > 0)
mana = CalculatePct(player->GetMaxPower(POWER_MANA), damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Codestyle clean-up
2011-11-07 11:06:39 -06:00
player->ResurrectPlayer(0.0f);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Codestyle clean-up
2011-11-07 11:06:39 -06:00
player->SetHealth(health);
player->SetPower(POWER_MANA, mana);
player->SetPower(POWER_RAGE, 0);
Core/Misc: Added helper function Unit::SetFullPower
2018-01-03 16:39:00 +01:00
player->SetFullPower(POWER_ENERGY);
Core/Mechanics:
2011-11-25 15:28:36 +01:00
player->SetPower(POWER_FOCUS, 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Codestyle clean-up
2011-11-07 11:06:39 -06:00
player->SpawnCorpseBones();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSkinning()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (unitTarget->GetTypeId() != TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Player* player = m_caster->ToPlayer();
if (!player)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
Creature* creature = unitTarget->ToCreature();
Core/Creatures: Implemented Basic Creature Scaling (#20026)
2017-07-29 21:40:28 +02:00
int32 targetLevel = creature->GetLevelForTarget(m_caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
uint32 skill = creature->GetCreatureTemplate()->GetRequiredLootSkill();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
creature->RemoveUnitFlag(UNIT_FLAG_SKINNABLE);
creature->AddDynamicFlag(UNIT_DYNFLAG_LOOTABLE);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
player->SendLoot(creature->GetGUID(), LOOT_SKINNING);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Updated gathering profession skills
2018-12-07 19:09:10 +01:00
if (skill == SKILL_SKINNING)
{
int32 reqValue;
if (targetLevel <= 10)
reqValue = 1;
else if (targetLevel < 20)
reqValue = (targetLevel - 10) * 10;
else if (targetLevel <= 73)
reqValue = targetLevel * 5;
else if (targetLevel < 80)
reqValue = targetLevel * 10 - 365;
else if (targetLevel <= 84)
reqValue = targetLevel * 5 + 35;
else if (targetLevel <= 87)
reqValue = targetLevel * 15 - 805;
else if (targetLevel <= 92)
reqValue = (targetLevel - 62) * 20;
else if (targetLevel <= 104)
reqValue = targetLevel * 5 + 175;
else if (targetLevel <= 107)
reqValue = targetLevel * 15 - 905;
else if (targetLevel <= 112)
reqValue = (targetLevel - 72) * 20;
else if (targetLevel <= 122)
reqValue = (targetLevel - 32) * 10;
else
reqValue = 900;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Updated gathering profession skills
2018-12-07 19:09:10 +01:00
// TODO: Specialize skillid for each expansion
// new db field?
// tied to one of existing expansion fields in creature_template?
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Updated gathering profession skills
2018-12-07 19:09:10 +01:00
// Double chances for elites
m_caster->ToPlayer()->UpdateGatherSkill(skill, damage, reqValue, creature->isElite() ? 2 : 1);
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCharge()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/MMaps: Implement pathed charge effect
2012-09-03 20:30:30 +02:00
if (!unitTarget)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode == SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
{
Added some missing SetFallInformation calls (#19121)
2017-02-13 21:05:32 +01:00
// charge changes fall time
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster->GetTypeId() == TYPEID_PLAYER)
unitCaster->ToPlayer()->SetFallInformation(0, unitCaster->GetPositionZ());
Added some missing SetFallInformation calls (#19121)
2017-02-13 21:05:32 +01:00
Core/Spells: consider spell speed in SPELL_EFFECT_CHARGE
2014-09-17 23:24:31 +02:00
float speed = G3D::fuzzyGt(m_spellInfo->Speed, 0.0f) ? m_spellInfo->Speed : SPEED_CHARGE;
Core/Spells: Implement SpellMisc::LaunchDelay
2018-08-29 23:50:22 +02:00
Core/Spells: Fixed extra charge effect visuals
2017-03-12 00:40:52 +01:00
Optional<Movement::SpellEffectExtraData> spellEffectExtraData;
if (effectInfo->MiscValueB)
{
spellEffectExtraData = boost::in_place();
spellEffectExtraData->Target = unitTarget->GetGUID();
spellEffectExtraData->SpellVisualId = effectInfo->MiscValueB;
}
Core/Spells: Fixed charge effects with non-explicit targets
2013-02-13 20:21:26 +01:00
// Spell is not using explicit target - no generated path
Core/Spells: fixed crash
2017-06-20 18:31:36 +02:00
if (!m_preGeneratedPath)
Core/MMaps: Implement pathed charge effect
2012-09-03 20:30:30 +02:00
{
Core/Misc: Change how Position struct is retrieved
2014-04-25 21:19:30 +02:00
//unitTarget->GetContactPoint(m_caster, pos.m_positionX, pos.m_positionY, pos.m_positionZ);
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
2017-03-23 00:43:04 +01:00
Position pos = unitTarget->GetFirstCollisionPosition(unitTarget->GetCombatReach(), unitTarget->GetRelativeAngle(m_caster));
Core/Spells: Fixed calling spellhit script hooks on launch when spell hits both caster and target with different effects
2019-08-31 01:29:54 +02:00
if (G3D::fuzzyGt(m_spellInfo->Speed, 0.0f) && m_spellInfo->HasAttribute(SPELL_ATTR9_SPECIAL_DELAY_CALCULATION))
Core/Spells: Implement SpellMisc::LaunchDelay
2018-08-29 23:50:22 +02:00
speed = pos.GetExactDist(m_caster) / speed;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetMotionMaster()->MoveCharge(pos.m_positionX, pos.m_positionY, pos.m_positionZ, speed, EVENT_CHARGE, false, unitTarget, spellEffectExtraData.get_ptr());
Core/MMaps: Implement pathed charge effect
2012-09-03 20:30:30 +02:00
}
else
Core/Spells: Implement SpellMisc::LaunchDelay
2018-08-29 23:50:22 +02:00
{
Core/Spells: Fixed calling spellhit script hooks on launch when spell hits both caster and target with different effects
2019-08-31 01:29:54 +02:00
if (G3D::fuzzyGt(m_spellInfo->Speed, 0.0f) && m_spellInfo->HasAttribute(SPELL_ATTR9_SPECIAL_DELAY_CALCULATION))
Core/Spells: Implement SpellMisc::LaunchDelay
2018-08-29 23:50:22 +02:00
{
G3D::Vector3 pos = m_preGeneratedPath->GetActualEndPosition();
speed = Position(pos.x, pos.y, pos.z).GetExactDist(m_caster) / speed;
}
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetMotionMaster()->MoveCharge(*m_preGeneratedPath, speed, unitTarget, spellEffectExtraData.get_ptr());
Core/Spells: Implement SpellMisc::LaunchDelay
2018-08-29 23:50:22 +02:00
}
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
}
if (effectHandleMode == SPELL_EFFECT_HANDLE_HIT_TARGET)
{
// not all charge effects used in negative spells
if (!m_spellInfo->IsPositive() && m_caster->GetTypeId() == TYPEID_PLAYER)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->Attack(unitTarget, true);
Core/Spells: Implemented casting spells on movement finish from SPELL_EFFECT_JUMP, SPELL_EFFECT_JUMP_DEST and SPELL_EFFECT_CHARGE
2016-01-25 19:35:41 +01:00
if (effectInfo->TriggerSpell)
Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes
2021-10-03 14:58:35 +02:00
m_caster->CastSpell(unitTarget, effectInfo->TriggerSpell, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
.SetOriginalCaster(m_originalCasterGUID)
.SetOriginalCastId(m_castId));
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
}
[8089] Implement SPELL_EFFECT_CHARGE2(149), more correct monster flags use in charge effects. Author: VladimirMangos
2009-07-01 17:36:34 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectChargeDest()
[8089] Implement SPELL_EFFECT_CHARGE2(149), more correct monster flags use in charge effects. Author: VladimirMangos
2009-07-01 17:36:34 -05:00
{
Core/Spells: Fixed extra charge effect visuals
2017-03-12 00:40:52 +01:00
if (!destTarget)
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Core/Spells: Fixed extra charge effect visuals
2017-03-12 00:40:52 +01:00
if (effectHandleMode == SPELL_EFFECT_HANDLE_LAUNCH)
*Fix build.
2009-07-01 17:47:31 -05:00
{
Core/Misc: Change how Position struct is retrieved
2014-04-25 21:19:30 +02:00
Position pos = destTarget->GetPosition();
Core/Scripts: More fixes in boss Lich King (#20147)
2017-08-17 12:03:56 -03:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster->IsWithinLOS(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ()))
Core/Scripts: More fixes in boss Lich King (#20147)
2017-08-17 12:03:56 -03:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
float angle = unitCaster->GetRelativeAngle(pos.GetPositionX(), pos.GetPositionY());
float dist = unitCaster->GetDistance(pos);
pos = unitCaster->GetFirstCollisionPosition(dist, angle);
Core/Scripts: More fixes in boss Lich King (#20147)
2017-08-17 12:03:56 -03:00
}
Core/Spells: fix charge and chargedest effect through textures
2011-12-10 01:43:04 +01:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetMotionMaster()->MoveCharge(pos.m_positionX, pos.m_positionY, pos.m_positionZ);
*Fix build.
2009-07-01 17:47:31 -05:00
}
Core/Spells: Fixed extra charge effect visuals
2017-03-12 00:40:52 +01:00
else if (effectHandleMode == SPELL_EFFECT_HANDLE_HIT)
{
if (effectInfo->TriggerSpell)
Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes
2021-10-03 14:58:35 +02:00
m_caster->CastSpell(*destTarget, effectInfo->TriggerSpell, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
.SetOriginalCaster(m_originalCasterGUID)
.SetOriginalCastId(m_castId));
Core/Spells: Fixed extra charge effect visuals
2017-03-12 00:40:52 +01:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectKnockBack()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (m_caster->GetAffectingPlayer())
Core/Spells Allow bosses to receive KnockBack under certain conditions (#19312)
2017-06-14 14:16:12 +02:00
if (Creature* creatureTarget = unitTarget->ToCreature())
if (creatureTarget->isWorldBoss() || creatureTarget->IsDungeonBoss())
return;
Core/Spells: Changed boss knockback immunity
2011-05-07 22:16:30 +02:00
Core/Spells: convert some spells to SpellScripts
2013-01-20 04:30:17 +01:00
// Spells with SPELL_EFFECT_KNOCK_BACK (like Thunderstorm) can't knockback target if target has ROOT/STUN
Fix a typo
2012-07-28 23:19:45 +02:00
if (unitTarget->HasUnitState(UNIT_STATE_ROOT | UNIT_STATE_STUNNED))
Core/Spells: Spells with SPELL_EFFECT_KNOCK_BACK(like Thunderstorm) can't knoback target if target has ROOT/STUN
2012-07-28 15:37:24 +02:00
return;
Core/Scripting: Replace casted with cast as casted is not a word.
2013-12-25 14:16:55 -03:30
// Instantly interrupt non melee spells being cast
if (unitTarget->IsNonMeleeSpellCast(true))
Core/Spells: Interruption should be checked after knowing that the knockback effect will happen (in this case, after the glyph checks).
2011-05-05 18:08:01 -03:00
unitTarget->InterruptNonMeleeSpells(true);
Core/Movement: Fixed knockback visibility for other players (no more "teleport") and knockback strength from creature spells (this does not fix knocking creatures back)
2011-09-30 18:24:12 +02:00
float ratio = 0.1f;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
float speedxy = float(effectInfo->MiscValue) * ratio;
*Do not allow to knockback target which is much larger than caster.
2009-08-25 16:34:17 -05:00
float speedz = float(damage) * ratio;
Core/Movement: Corrected all speed checks after 23b6991273bac4ee9d7cf1b4ac3b9a92e0a7300e
2017-02-28 15:18:09 -03:00
if (speedxy < 0.01f && speedz < 0.01f)
*Do not allow to knockback target which is much larger than caster.
2009-08-25 16:34:17 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix knockback effect.
2009-02-06 21:48:47 -06:00
float x, y;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->Effect == SPELL_EFFECT_KNOCK_BACK_DEST)
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
{
if (m_targets.HasDst())
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
destTarget->GetPosition(x, y);
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
else
return;
}
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
else //if (m_spellInfo->Effects[i].Effect == SPELL_EFFECT_KNOCK_BACK)
*More update about positions.
2009-08-29 23:20:16 -05:00
m_caster->GetPosition(x, y);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
unitTarget->KnockbackFrom(x, y, speedxy, speedz);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLeapBack()
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
return;
if (!unitTarget)
return;
Core/Spells: Fix a float division issue in EffectLeapBack
2015-02-15 15:01:36 +00:00
float speedxy = effectInfo->MiscValue / 10.f;
float speedz = damage / 10.f;
Core/DataStores: Updated db2 structures to 7.2.0
2017-04-06 23:39:34 +02:00
// Disengage
unitTarget->JumpTo(speedxy, speedz, m_spellInfo->IconFileDataId != 132572);
Added some missing SetFallInformation calls (#19121)
2017-02-13 21:05:32 +01:00
// changes fall time
if (m_caster->GetTypeId() == TYPEID_PLAYER)
m_caster->ToPlayer()->SetFallInformation(0, m_caster->GetPositionZ());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectQuestClear()
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
return;
REPO: code-style clean-up
2011-10-07 11:08:09 -05:00
Player* player = unitTarget->ToPlayer();
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 quest_id = effectInfo->MiscValue;
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
REPO: Code-style clean-ups
2011-10-07 19:45:43 -05:00
Quest const* quest = sObjectMgr->GetQuestTemplate(quest_id);
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
REPO: Code-style clean-ups
2011-10-07 19:45:43 -05:00
if (!quest)
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
return;
Core/Scripts: Added new QuestScript hooks (#20950)
2017-12-04 17:35:37 +01:00
QuestStatus oldStatus = player->GetQuestStatus(quest_id);
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
// Player has never done this quest
Core/Scripts: Added new QuestScript hooks (#20950)
2017-12-04 17:35:37 +01:00
if (oldStatus == QUEST_STATUS_NONE)
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
return;
// remove all quest entries for 'entry' from quest log
for (uint8 slot = 0; slot < MAX_QUEST_LOG_SIZE; ++slot)
{
Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit
2011-11-23 19:17:33 +01:00
uint32 logQuest = player->GetQuestSlotQuestId(slot);
if (logQuest == quest_id)
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
{
REPO: code-style clean-up
2011-10-07 11:08:09 -05:00
player->SetQuestSlot(slot, 0);
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit
2011-11-23 19:17:33 +01:00
// we ignore unequippable quest items in this case, it's still be equipped
player->TakeQuestSourceItem(logQuest, false);
Core/Quests: Implemented quest flag forcing the player to be flagged for PvP as long as the quest is in his log.
2013-02-26 17:14:13 +01:00
if (quest->HasFlag(QUEST_FLAGS_FLAGS_PVP))
{
player->pvpInfo.IsHostile = player->pvpInfo.IsInHostileArea || player->HasPvPForcingQuest();
player->UpdatePvPState();
}
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
}
}
Core/Entities: allow interaction with gameobject questgivers if player can take or return quests
2014-02-06 21:23:18 +01:00
player->RemoveActiveQuest(quest_id, false);
REPO: code-style clean-up
2011-10-07 11:08:09 -05:00
player->RemoveRewardedQuest(quest_id);
Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865)
2016-09-09 22:11:36 +03:00
sScriptMgr->OnQuestStatusChange(player, quest_id);
Core/Scripts: Added new QuestScript hooks (#20950)
2017-12-04 17:35:37 +01:00
sScriptMgr->OnQuestStatusChange(player, quest, oldStatus, QUEST_STATUS_NONE);
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSendTaxi()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
unitTarget->ToPlayer()->ActivateTaxiPathTo(effectInfo->MiscValue, m_spellInfo->Id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPullTowards()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
Position pos;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->Effect == SPELL_EFFECT_PULL_TOWARDS_DEST)
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
{
if (m_targets.HasDst())
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
pos.Relocate(*destTarget);
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
else
return;
}
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
else //if (m_spellInfo->Effects[i].Effect == SPELL_EFFECT_PULL_TOWARDS)
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
{
pos.Relocate(m_caster);
}
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
float speedXY = float(effectInfo->MiscValue) * 0.1f;
Core/Spells: Fixed movement from SPELL_EFFECT_PULL_TOWARDS_DEST
2013-12-31 13:08:45 +01:00
float speedZ = unitTarget->GetDistance(pos) / speedXY * 0.5f * Movement::gravity;
Merge remote-tracking branch 'Eliminationzx/FixJumpDestOrientation' into 3.3.5 (PR #16450) with some minor CS adjustments
2016-02-10 17:41:19 +01:00
unitTarget->GetMotionMaster()->MoveJump(pos, speedXY, speedZ);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectChangeRaidMarker()
Core/PacketsIO: Implemented or updated most of party related packets.
2015-05-19 02:55:53 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Player* player = m_caster->ToPlayer();
if (!player || !m_targets.HasDst())
return;
Group* group = player->GetGroup();
if (!group || (group->isRaidGroup() && !group->IsLeader(player->GetGUID()) && !group->IsAssistant(player->GetGUID())))
return;
float x, y, z;
destTarget->GetPosition(x, y, z);
group->AddRaidMarker(damage, player->GetMapId(), x, y, z);
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDispelMechanic()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 mechanic = effectInfo->MiscValue;
Core/Entities: Use ObjectGuid class in game project
2014-09-14 16:14:12 +02:00
DispelList dispel_list;
* Make sure that aura is applied on unit before trying to remove it.
2010-01-10 20:09:44 +01:00
Unit::AuraMap const& auras = unitTarget->GetOwnedAuras();
for (Unit::AuraMap::const_iterator itr = auras.begin(); itr != auras.end(); ++itr)
*Fix T.N.T proc chance
2009-04-13 18:56:29 +02:00
{
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
Aura* aura = itr->second;
* Make sure that aura is applied on unit before trying to remove it.
2010-01-10 20:09:44 +01:00
if (!aura->GetApplicationOfTarget(unitTarget->GetGUID()))
continue;
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
if (roll_chance_i(aura->CalcDispelChance(unitTarget, !unitTarget->IsFriendlyTo(m_caster))))
if ((aura->GetSpellInfo()->GetAllEffectsMechanicMask() & (1 << mechanic)))
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
dispel_list.emplace_back(aura->GetId(), aura->GetCasterGUID());
*Fix T.N.T proc chance
2009-04-13 18:56:29 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
for (auto itr = dispel_list.begin(); itr != dispel_list.end(); ++itr)
unitTarget->RemoveAura(itr->first, itr->second, 0, AURA_REMOVE_BY_ENEMY_SPELL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectResurrectPet()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
if (damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Misc: Fixed some duplicate checks for player typeid in Unit::Kill and Spell::EffectSummonDeadPet. Also some random cleanup
2011-12-10 13:48:41 +01:00
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
Player* player = m_caster->ToPlayer();
if (!player)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Misc: Fixed some duplicate checks for player typeid in Unit::Kill and Spell::EffectSummonDeadPet. Also some random cleanup
2011-12-10 13:48:41 +01:00
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
// Maybe player dismissed dead pet or pet despawned?
bool hadPet = true;
Core/Spells: Rename Spell::EffectSummonDeadPet with Spell::EffectResurrectPet and get rid of two TODO's that are already done.
2014-01-17 17:54:52 +01:00
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
if (!player->GetPet())
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
{
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
// Position passed to SummonPet is irrelevant with current implementation,
// pet will be relocated without using these coords in Pet::LoadPetFromDB
player->SummonPet(0, 0.0f, 0.0f, 0.0f, 0.0f, SUMMON_PET, 0);
hadPet = false;
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
}
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
Core/Commands: The .setskill command is now usable even if the player doesn't already have the skill learned.
2014-01-18 01:05:03 +01:00
// TODO: Better to fail Hunter's "Revive Pet" at cast instead of here when casting ends
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
Pet* pet = player->GetPet(); // Attempt to get current pet
Core/Spells: Rename Spell::EffectSummonDeadPet with Spell::EffectResurrectPet and get rid of two TODO's that are already done.
2014-01-17 17:54:52 +01:00
if (!pet || pet->IsAlive())
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
return;
// If player did have a pet before reviving, teleport it
if (hadPet)
{
// Reposition the pet's corpse before reviving so as not to grab aggro
// We can use a different, more accurate version of GetClosePoint() since we have a pet
float x, y, z; // Will be used later to reposition the pet if we have one
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
2017-03-23 00:43:04 +01:00
player->GetClosePoint(x, y, z, pet->GetCombatReach(), PET_FOLLOW_DIST, pet->GetFollowAngle());
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
pet->NearTeleportTo(x, y, z, player->GetOrientation());
pet->Relocate(x, y, z, player->GetOrientation()); // This is needed so SaveStayPosition() will get the proper coords.
}
Fixed some problems with pets, port from tc1, by krz, thx Frankir.
2010-01-16 19:11:32 +03:00
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
pet->SetDynamicFlags(UNIT_DYNFLAG_NONE);
pet->RemoveUnitFlag(UNIT_FLAG_SKINNABLE);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
pet->setDeathState(ALIVE);
Core/Unit: cleanup UnitState enum
2017-03-25 12:16:13 +01:00
pet->ClearUnitState(UNIT_STATE_ALL_ERASABLE);
Core:
2010-08-26 01:20:57 +06:00
pet->SetHealth(pet->CountPctFromMaxHealth(damage));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Revive Pet to revive the pet near the owner
2013-11-11 13:22:41 +01:00
// Reset things for when the AI to takes over
CharmInfo *ci = pet->GetCharmInfo();
if (ci)
{
// In case the pet was at stay, we don't want it running back
ci->SaveStayPosition();
ci->SetIsAtStay(ci->HasCommandState(COMMAND_STAY));
ci->SetIsFollowing(false);
ci->SetIsCommandAttack(false);
ci->SetIsCommandFollow(false);
ci->SetIsReturning(false);
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDestroyAllTotems()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
*Use custom spell intead of hard code for EffectDestroyAllTotems. By Maxxie
2009-05-06 17:00:11 -05:00
int32 mana = 0;
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint8 slot = SUMMON_SLOT_TOTEM; slot < MAX_TOTEM_SLOT; ++slot)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster->m_SummonSlot[slot])
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
continue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Creature* totem = unitCaster->GetMap()->GetCreature(unitCaster->m_SummonSlot[slot]);
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
if (totem && totem->IsTotem())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
uint32 spell_id = totem->m_unitData->CreatedBySpell;
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(spell_id, GetCastDifficulty());
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (spellInfo)
*Fix totemic call mana gain
2009-04-12 01:29:56 +02:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
std::vector<SpellPowerCost> costs = spellInfo->CalcPowerCost(unitCaster, spellInfo->GetSchoolMask());
Core/Game: Include cleanup, part 4 - packets and largest headers (after preprocessing, except player/objectmgr)
2017-05-21 23:18:43 +02:00
auto m = std::find_if(costs.begin(), costs.end(), [](SpellPowerCost const& cost) { return cost.Power == POWER_MANA; });
Core/Spells: Implemented multiple spell power costs
2015-03-08 13:31:57 +01:00
if (m != costs.end())
mana += m->Amount;
*Fix totemic call mana gain
2009-04-12 01:29:56 +02:00
}
Core/Spells: Implemented multiple spell power costs
2015-03-08 13:31:57 +01:00
Totem* casts.
2010-03-10 07:58:11 +01:00
totem->ToTotem()->UnSummon();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
Core/Spells: Implemented multiple spell power costs
2015-03-08 13:31:57 +01:00
Core/Utilities: Use generic templates with AddPct, ApplyPct and CalculatePct
2012-10-02 12:17:42 +02:00
ApplyPct(mana, damage);
Core/Spells: Implemented multiple spell power costs
2015-03-08 13:31:57 +01:00
*Use custom spell intead of hard code for EffectDestroyAllTotems. By Maxxie
2009-05-06 17:00:11 -05:00
if (mana)
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
{
CastSpellExtraArgs args(TRIGGERED_FULL_MASK);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.SetOriginalCastId(m_castId);
Core/Spell: SpellValueOverrides encapsulation
2018-01-13 20:38:32 -03:00
args.AddSpellMod(SPELLVALUE_BASE_POINT0, mana);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->CastSpell(unitCaster, 39104, args);
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDurabilityDamage()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
int32 slot = effectInfo->MiscValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed combat log for spells that affect item durability
2012-11-25 11:13:39 +01:00
// -1 means all player equipped items and -2 all items
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->DurabilityPointsLossAll(damage, (slot < -1));
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectDurabilityDamage(SpellEffectName(effectInfo->Effect), unitTarget, -1, -1);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// invalid slot value
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot >= INVENTORY_SLOT_BAG_END)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Item* item = unitTarget->ToPlayer()->GetItemByPos(INVENTORY_SLOT_BAG_0, slot))
Core/Spells: Fixed visuals of area spells that use a dynamic object
2012-10-20 00:02:32 +02:00
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->DurabilityPointsLoss(item, damage);
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectDurabilityDamage(SpellEffectName(effectInfo->Effect), unitTarget, item->GetEntry(), slot);
Core/Spells: Fixed visuals of area spells that use a dynamic object
2012-10-20 00:02:32 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDurabilityDamagePCT()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
int32 slot = effectInfo->MiscValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// FIXME: some spells effects have value -1/-2
// Possibly its mean -1 all player equipped items and -2 all items
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
unitTarget->ToPlayer()->DurabilityLossAll(float(damage) / 100.0f, (slot < -1));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// invalid slot value
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot >= INVENTORY_SLOT_BAG_END)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage <= 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Item* item = unitTarget->ToPlayer()->GetItemByPos(INVENTORY_SLOT_BAG_0, slot))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
unitTarget->ToPlayer()->DurabilityLoss(item, float(damage) / 100.0f);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectModifyThreatPercent()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitTarget->GetThreatManager().ModifyThreatByPercent(unitCaster, damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTransmitted()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
uint32 name_id = effectInfo->MiscValue;
Unit::AuraEffectList const& overrideSummonedGameObjects = unitCaster->GetAuraEffectsByType(SPELL_AURA_OVERRIDE_SUMMONED_OBJECT);
Core/Spells: Fixed fishing
2017-02-11 13:04:12 +01:00
for (AuraEffect const* aurEff : overrideSummonedGameObjects)
{
if (uint32(aurEff->GetMiscValue()) == name_id)
{
name_id = uint32(aurEff->GetMiscValueB());
break;
}
}
Core/ObjectMgr: Refactor sGOStorage
2011-04-28 22:54:30 +02:00
GameObjectTemplate const* goinfo = sObjectMgr->GetGameObjectTemplate(name_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!goinfo)
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("sql.sql", "Gameobject (Entry: %u) does not exist and is not created by spell (ID: %u) cast.", name_id, m_spellInfo->Id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
float fx, fy, fz;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.HasDst())
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
destTarget->GetPosition(fx, fy, fz);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//FIXME: this can be better check for most objects but still hack
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
else if (effectInfo->HasRadius() && m_spellInfo->Speed == 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
float dis = effectInfo->CalcRadius(unitCaster);
unitCaster->GetClosePoint(fx, fy, fz, DEFAULT_PLAYER_BOUNDING_RADIUS, dis);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
else
{
*Make range check dependent from target.
2009-02-14 15:56:04 +01:00
//GO is always friendly to it's creator, get range for friends
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
float min_dis = m_spellInfo->GetMinRange(true);
float max_dis = m_spellInfo->GetMaxRange(true);
Core/Game: fix all warnings related to converting doubles and floats.
2010-08-22 12:39:39 -07:00
float dis = (float)rand_norm() * (max_dis - min_dis) + min_dis;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetClosePoint(fx, fy, fz, DEFAULT_PLAYER_BOUNDING_RADIUS, dis);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Map* cMap = unitCaster->GetMap();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// if gameobject is summoning object, it should be spawned right on caster's position
Core/Defines: Updated some enums to build 6.0.2.18988
2014-10-06 18:37:38 -04:00
if (goinfo->type == GAMEOBJECT_TYPE_RITUAL)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetPosition(fx, fy, fz);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Position pos = { fx, fy, fz, unitCaster->GetOrientation() };
QuaternionData rot = QuaternionData::fromEulerAnglesZYX(unitCaster->GetOrientation(), 0.f, 0.f);
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
GameObject* go = GameObject::CreateGameObject(name_id, cMap, pos, rot, 255, GO_STATE_READY);
if (!go)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Phasing rewrite
2018-01-28 11:37:20 +01:00
PhasingHandler::InheritPhaseShift(go, m_caster);
Core/Entities: Basic AreaTrigger System (#18035)
2017-01-29 00:00:43 +01:00
int32 duration = m_spellInfo->CalcDuration(m_caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (goinfo->type)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case GAMEOBJECT_TYPE_FISHINGNODE:
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
go->SetFaction(unitCaster->GetFaction());
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
ObjectGuid bobberGuid = go->GetGUID();
Core/Spells: Fixed fishing bobbers not being usable
2017-07-04 20:30:16 +02:00
// client requires fishing bobber guid in channel object slot 0 to be usable
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->SetChannelObject(0, bobberGuid);
unitCaster->AddGameObject(go); // will removed at spell cancel
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// end time of range when possible catch fish (FISHING_BOBBER_READY_TIME..GetDuration(m_spellInfo))
// start time == fish-FISHING_BOBBER_READY_TIME (0..GetDuration(m_spellInfo)-FISHING_BOBBER_READY_TIME)
[7716] Fixed some typos and possible crashes. Author: AlexDereka
2009-04-27 18:42:35 -05:00
int32 lastSec = 0;
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (urand(0, 3))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case 0: lastSec = 3; break;
case 1: lastSec = 7; break;
case 2: lastSec = 13; break;
case 3: lastSec = 17; break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
duration = duration - lastSec*IN_MILLISECONDS + FISHING_BOBBER_READY_TIME*IN_MILLISECONDS;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
Core/Defines: Updated some enums to build 6.0.2.18988
2014-10-06 18:37:38 -04:00
case GAMEOBJECT_TYPE_RITUAL:
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster->GetTypeId() == TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
go->AddUniqueUse(unitCaster->ToPlayer());
unitCaster->AddGameObject(go); // will be removed at spell cancel
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
*Some update of script "death's challenge"
2009-08-13 00:21:10 -05:00
case GAMEOBJECT_TYPE_DUEL_ARBITER: // 52991
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->AddGameObject(go);
*Some update of script "death's challenge"
2009-08-13 00:21:10 -05:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_FISHINGHOLE:
case GAMEOBJECT_TYPE_CHEST:
default:
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
go->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
go->SetOwnerGUID(unitCaster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
//go->SetLevel(unitCaster->getLevel());
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
go->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), go);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "AddObject at SpellEfects.cpp EffectTransmitted");
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
//unitCaster->AddGameObject(go);
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
//m_ObjToDel.push_back(go);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
cMap->AddToMap(go);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
if (GameObject* linkedTrap = go->GetLinkedTrap())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Entities: Phasing rewrite
2018-01-28 11:37:20 +01:00
PhasingHandler::InheritPhaseShift(linkedTrap, m_caster);
Core/Phases: Preliminary work with correctly implementing the phase system in 4.3.4
2014-06-01 22:27:29 -05:00
Core/GameObject: spawn linked traps at gameobject creation instead of using DB spawns. (#18172)
2016-11-01 22:24:03 +01:00
linkedTrap->SetRespawnTime(duration > 0 ? duration / IN_MILLISECONDS : 0);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
//linkedTrap->SetLevel(unitCaster->getLevel());
Core/GameObject: spawn linked traps at gameobject creation instead of using DB spawns. (#18172)
2016-11-01 22:24:03 +01:00
linkedTrap->SetSpellId(m_spellInfo->Id);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
linkedTrap->SetOwnerGUID(unitCaster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), linkedTrap);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectProspecting()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
if (!player)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items: Defined all item flags
2016-09-09 10:22:57 +02:00
if (!itemTarget || !(itemTarget->GetTemplate()->GetFlags() & ITEM_FLAG_IS_PROSPECTABLE))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (itemTarget->GetCount() < 5)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (sWorld->getBoolConfig(CONFIG_SKILL_PROSPECTING))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
uint32 SkillValue = player->GetPureSkillValue(SKILL_JEWELCRAFTING);
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
uint32 reqSkillValue = itemTarget->GetTemplate()->GetRequiredSkillRank();
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
player->UpdateGatherSkill(SKILL_JEWELCRAFTING, SkillValue, reqSkillValue);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
player->SendLoot(itemTarget->GetGUID(), LOOT_PROSPECTING);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectMilling()
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
if (!player)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Items: Defined all item flags
2016-09-09 10:22:57 +02:00
if (!itemTarget || !(itemTarget->GetTemplate()->GetFlags() & ITEM_FLAG_IS_MILLABLE))
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (itemTarget->GetCount() < 5)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (sWorld->getBoolConfig(CONFIG_SKILL_MILLING))
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
uint32 SkillValue = player->GetPureSkillValue(SKILL_INSCRIPTION);
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
uint32 reqSkillValue = itemTarget->GetTemplate()->GetRequiredSkillRank();
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
player->UpdateGatherSkill(SKILL_INSCRIPTION, SkillValue, reqSkillValue);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
player->SendLoot(itemTarget->GetGUID(), LOOT_MILLING);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSkill()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "WORLD: SkillEFFECT");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
/* There is currently no need for this effect. We handle it in Battleground.cpp
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
If we would handle the resurrection here, the spiritguide would instantly disappear as the
player revives, and so we wouldn't see the spirit heal visual effect on the npc.
This is why we use a half sec delay between the visual effect and the resurrection itself */
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSpiritHeal()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
/*
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->IsInWorld())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
//m_spellInfo->Effects[i].BasePoints; == 99 (percent?)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
//unitTarget->ToPlayer()->setResurrect(m_caster->GetGUID(), unitTarget->GetPositionX(), unitTarget->GetPositionY(), unitTarget->GetPositionZ(), unitTarget->GetMaxHealth(), unitTarget->GetMaxPower(POWER_MANA));
unitTarget->ToPlayer()->ResurrectPlayer(1.0f);
unitTarget->ToPlayer()->SpawnCorpseBones();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
*/
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// remove insignia spell effect
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSkinPlayerCorpse()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "Effect: SkinPlayerCorpse");
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
Player* player = m_caster->ToPlayer();
Player* target = unitTarget->ToPlayer();
if (!player || !target || target->IsAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-20 21:52:05 +02:00
target->RemovedInsignia(player);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectStealBeneficialBuff()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
TC_LOG_DEBUG("spells", "Effect: StealBeneficialBuff");
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
if (!unitTarget || unitTarget == m_caster) // can't steal from self
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
DispelChargesList stealList;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Create dispel mask by dispel type
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 dispelMask = SpellInfo::GetDispelMask(DispelType(effectInfo->MiscValue));
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraMap const& auras = unitTarget->GetOwnedAuras();
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (Unit::AuraMap::const_iterator itr = auras.begin(); itr != auras.end(); ++itr)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
Aura* aura = itr->second;
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
AuraApplication const* aurApp = aura->GetApplicationOfTarget(unitTarget->GetGUID());
* Make sure that aura is applied on unit before trying to remove it.
2010-01-10 20:09:44 +01:00
if (!aurApp)
continue;
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
2011-07-26 23:09:28 +02:00
if ((aura->GetSpellInfo()->GetDispelMask()) & dispelMask)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Need check for passive? this
Core/Spells: use spellinfo helper methods
2016-10-01 17:51:05 +02:00
if (!aurApp->IsPositive() || aura->IsPassive() || aura->GetSpellInfo()->HasAttribute(SPELL_ATTR4_NOT_STEALABLE))
* Use pair<uint32, uint64> lists instead of <Aura*> lists in Dispel/SpellSteal effects handlers (prevent reference to aura removed from unit)
2010-01-10 12:08:58 +01:00
continue;
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
// 2.4.3 Patch Notes: "Dispel effects will no longer attempt to remove effects that have 100% dispel resistance."
int32 chance = aura->CalcDispelChance(unitTarget, !unitTarget->IsFriendlyTo(m_caster));
if (!chance)
continue;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
// The charges / stack amounts don't count towards the total number of auras that can be dispelled.
// Ie: A dispel on a target with 5 stacks of Winters Chill and a Polymorph has 1 / (1 + 1) -> 50% chance to dispell
// Polymorph instead of 1 / (5 + 1) -> 16%.
Core/Spells: use spellinfo helper methods
2016-10-01 17:51:05 +02:00
bool dispelCharges = aura->GetSpellInfo()->HasAttribute(SPELL_ATTR7_DISPEL_CHARGES);
uint8 charges = dispelCharges ? aura->GetCharges() : aura->GetStackAmount();
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
if (charges > 0)
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
stealList.emplace_back(aura, chance, charges);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
if (stealList.empty())
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
return;
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
size_t remaining = stealList.size();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Ok if exist some buffs for dispel try dispel it
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
uint32 failCount = 0;
DispelList successList;
successList.reserve(damage);
Core/PacketIO: Updated and enabled SMSG_DISPEL_FAILED
2016-03-18 23:53:29 +01:00
WorldPackets::Spells::DispelFailed dispelFailed;
dispelFailed.CasterGUID = m_caster->GetGUID();
dispelFailed.VictimGUID = unitTarget->GetGUID();
dispelFailed.SpellID = m_spellInfo->Id;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
// dispel N = damage buffs (or while exist buffs for dispel)
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
for (int32 count = 0; count < damage && remaining > 0;)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
// Random select buff for dispel
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
DispelChargesList::iterator itr = stealList.begin();
std::advance(itr, urand(0, remaining - 1));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
if (itr->RollDispel())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
successList.emplace_back(itr->GetAura()->GetId(), itr->GetAura()->GetCasterGUID());
if (!itr->DecrementCharge())
{
--remaining;
std::swap(*itr, stealList[remaining]);
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
else
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
++failCount;
dispelFailed.FailedSpells.push_back(int32(itr->GetAura()->GetId()));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
++count;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
Core/PacketIO: Updated and enabled SMSG_DISPEL_FAILED
2016-03-18 23:53:29 +01:00
if (!dispelFailed.FailedSpells.empty())
m_caster->SendMessageToSet(dispelFailed.Write(), true);
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
if (successList.empty())
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
return;
Core/Packets: Updated and enabled SMSG_SPELL_DISPELL_LOG
2016-02-29 01:54:18 +00:00
WorldPackets::CombatLog::SpellDispellLog spellDispellLog;
spellDispellLog.IsBreak = false; // TODO: use me
spellDispellLog.IsSteal = true;
spellDispellLog.TargetGUID = unitTarget->GetGUID();
spellDispellLog.CasterGUID = m_caster->GetGUID();
spellDispellLog.DispelledBySpellID = m_spellInfo->Id;
Core/Spell: implemented dispel reflection
2016-12-11 15:04:25 -03:00
for (std::pair<uint32, ObjectGuid> const& dispell : successList)
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
{
Core/Packets: Updated and enabled SMSG_SPELL_DISPELL_LOG
2016-02-29 01:54:18 +00:00
WorldPackets::CombatLog::SpellDispellData dispellData;
dispellData.SpellID = dispell.first;
dispellData.Harmful = false; // TODO: use me
dispellData.Rolled = boost::none; // TODO: use me
dispellData.Needed = boost::none; // TODO: use me
unitTarget->RemoveAurasDueToSpellBySteal(dispell.first, dispell.second, m_caster);
spellDispellLog.DispellData.emplace_back(dispellData);
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
}
Core/Packets: Updated and enabled SMSG_SPELL_DISPELL_LOG
2016-02-29 01:54:18 +00:00
m_caster->SendMessageToSet(spellDispellLog.Write(), true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectKillCreditPersonal()
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
unitTarget->ToPlayer()->KilledMonsterCredit(effectInfo->MiscValue);
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectKillCredit()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed obsolete spell fixes
2017-08-27 14:59:18 +02:00
if (int32 creatureEntry = effectInfo->MiscValue)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->RewardPlayerAndGroupAtEvent(creatureEntry, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectQuestFail()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
unitTarget->ToPlayer()->FailQuest(effectInfo->MiscValue);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectQuestStart()
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: corrected implementation of SPELL_EFFECT_QUEST_START
2014-04-21 16:48:05 +02:00
if (!unitTarget)
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
return;
Core: Codestyle cleanup
2011-06-11 22:35:29 +02:00
Player* player = unitTarget->ToPlayer();
Core/Spells: corrected implementation of SPELL_EFFECT_QUEST_START
2014-04-21 16:48:05 +02:00
if (!player)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (Quest const* quest = sObjectMgr->GetQuestTemplate(effectInfo->MiscValue))
Core/Spells: corrected implementation of SPELL_EFFECT_QUEST_START
2014-04-21 16:48:05 +02:00
{
if (!player->CanTakeQuest(quest, false))
return;
if (quest->IsAutoAccept() && player->CanAddQuest(quest, false))
Core/Quests: Implemented quest popups
2017-11-28 00:04:03 +01:00
{
Core/Spells: corrected implementation of SPELL_EFFECT_QUEST_START
2014-04-21 16:48:05 +02:00
player->AddQuestAndCheckCompletion(quest, player);
Core/Quests: Implemented quest popups
2017-11-28 00:04:03 +01:00
player->PlayerTalkClass->SendQuestGiverQuestDetails(quest, player->GetGUID(), true, true);
}
else
player->PlayerTalkClass->SendQuestGiverQuestDetails(quest, player->GetGUID(), true, false);
Core/Spells: corrected implementation of SPELL_EFFECT_QUEST_START
2014-04-21 16:48:05 +02:00
}
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateTamedPet()
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Entities: First batch of removing implicit conversions of ObjectGuid to uint64
2014-10-21 19:23:32 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER || !unitTarget->GetPetGUID().IsEmpty() || unitTarget->getClass() != CLASS_HUNTER)
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 creatureEntry = effectInfo->MiscValue;
Core/Misc: Some random cleanups and code style fixes
2011-06-20 04:04:20 +07:00
Pet* pet = unitTarget->CreateTamedPetFrom(creatureEntry, m_spellInfo->Id);
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
if (!pet)
return;
Core/Players: Cast Summon Pet on first login, relocate created pets
2013-05-10 20:39:15 +02:00
// relocate
float px, py, pz;
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
2017-03-23 00:43:04 +01:00
unitTarget->GetClosePoint(px, py, pz, pet->GetCombatReach(), PET_FOLLOW_DIST, pet->GetFollowAngle());
Core/Players: Cast Summon Pet on first login, relocate created pets
2013-05-10 20:39:15 +02:00
pet->Relocate(px, py, pz, unitTarget->GetOrientation());
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
// add to world
Rename Map::Add to Map::AddToMap, Map::Remove to Map::RemoveFromMap for better management.
2011-10-10 17:39:34 -04:00
pet->GetMap()->AddToMap(pet->ToCreature());
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
// unitTarget has pet now
unitTarget->SetMinion(pet, true);
if (unitTarget->GetTypeId() == TYPEID_PLAYER)
{
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
unitTarget->ToPlayer()->PetSpellInitialize();
}
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDiscoverTaxi()
*Implement SPELL_EFFECT_DISCOVER_TAXI(154).
2010-07-20 18:27:18 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Implement SPELL_EFFECT_DISCOVER_TAXI(154).
2010-07-20 18:27:18 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 nodeid = effectInfo->MiscValue;
*Implement SPELL_EFFECT_DISCOVER_TAXI(154).
2010-07-20 18:27:18 +02:00
if (sTaxiNodesStore.LookupEntry(nodeid))
unitTarget->ToPlayer()->GetSession()->SendDiscoverNewTaxiNode(nodeid);
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTitanGrip()
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (m_caster->GetTypeId() == TYPEID_PLAYER)
Core/Player: Implemented Titan's Grip damage reduction
2016-10-02 07:34:23 +02:00
m_caster->ToPlayer()->SetCanTitanGrip(true, uint32(effectInfo->MiscValue));
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectRedirectThreat()
*Fix misdirection.
2008-12-17 20:07:25 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->GetThreatManager().RegisterRedirectThreat(m_spellInfo->Id, unitTarget->GetGUID(), uint32(damage));
*Update difftime record.
2009-01-06 15:48:42 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectGameObjectDamage()
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/GameObject: Refactored destructible building handling, properly implemented spell effect repair
2011-07-22 21:22:05 +02:00
if (!gameObjTarget)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
FactionTemplateEntry const* casterFaction = m_caster->GetFactionTemplateEntry();
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
FactionTemplateEntry const* targetFaction = sFactionTemplateStore.LookupEntry(gameObjTarget->GetFaction());
Core/GameObject: Refactored destructible building handling, properly implemented spell effect repair
2011-07-22 21:22:05 +02:00
// Do not allow to damage GO's of friendly factions (ie: Wintergrasp Walls/Ulduar Storm Beacons)
Core/Misc: Fix static analysis issues
2017-12-08 17:33:10 +01:00
if (!targetFaction || (casterFaction && !casterFaction->IsFriendlyTo(targetFaction)))
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
gameObjTarget->ModifyHealth(-damage, m_caster, GetSpellInfo()->Id);
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectGameObjectRepair()
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/GameObject: Refactored destructible building handling, properly implemented spell effect repair
2011-07-22 21:22:05 +02:00
if (!gameObjTarget)
return;
gameObjTarget->ModifyHealth(damage, m_caster);
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectGameObjectSetDestructionState()
Core/Spells: Implement SPELL_EFFECT_WMO_CHANGE, patch by Heisenberg
2010-12-01 20:59:05 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!gameObjTarget)
Core/GameObject: Refactored destructible building handling, properly implemented spell effect repair
2011-07-22 21:22:05 +02:00
return;
Core/Spells: Implement SPELL_EFFECT_WMO_CHANGE, patch by Heisenberg
2010-12-01 20:59:05 +02:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
gameObjTarget->SetDestructibleState(GameObjectDestructibleState(effectInfo->MiscValue), m_caster, true);
Core/Spells: Implement SPELL_EFFECT_WMO_CHANGE, patch by Heisenberg
2010-12-01 20:59:05 +02:00
}
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
void Spell::SummonGuardian(SpellEffectInfo const* effect, uint32 entry, SummonPropertiesEntry const* properties, uint32 numGuardians, ObjectGuid privateObjectOwner)
*More work on summon system.
2009-03-20 14:01:46 -06:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (unitCaster->IsTotem())
unitCaster = unitCaster->ToTotem()->GetOwner();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More work on summon system.
2009-03-20 14:01:46 -06:00
// in another case summon new
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
uint8 level = unitCaster->getLevel();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More work on summon system.
2009-03-20 14:01:46 -06:00
// level of pet summoned using engineering item based at engineering skill level
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (m_CastItem && unitCaster->GetTypeId() == TYPEID_PLAYER)
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:08:17 +02:00
if (ItemTemplate const* proto = m_CastItem->GetTemplate())
Core/Items: Refactored ItemTemplate
2014-12-21 13:35:43 +01:00
if (proto->GetRequiredSkill() == SKILL_ENGINEERING)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (uint16 skill202 = unitCaster->ToPlayer()->GetSkillValue(SKILL_ENGINEERING))
Core/Misc: Fix spelling typo
2011-11-02 19:13:51 +07:00
level = skill202 / 5;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More work on summon system.
2009-03-20 14:01:46 -06:00
float radius = 5.0f;
Core/Entities: Basic AreaTrigger System (#18035)
2017-01-29 00:00:43 +01:00
int32 duration = m_spellInfo->CalcDuration(m_originalCaster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Remove LOTS of compile warnings
2010-04-19 09:26:37 +02:00
//TempSummonType summonType = (duration == 0) ? TEMPSUMMON_DEAD_DESPAWN : TEMPSUMMON_TIMED_DESPAWN;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Map* map = unitCaster->GetMap();
Core/Spells: Fix some problems with spells summoning to many objects.
2012-02-09 20:26:30 +01:00
for (uint32 count = 0; count < numGuardians; ++count)
*More work on summon system.
2009-03-20 14:01:46 -06:00
{
*Make position as a class;
2009-08-29 14:58:45 -05:00
Position pos;
Merge git://github.com/TrinityCore/TrinityCore into 4.x
2012-05-30 08:01:02 +02:00
if (count == 0)
pos = *destTarget;
else
// randomize position for multiple summons
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
pos = unitCaster->GetRandomPoint(*destTarget, radius);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
TempSummon* summon = map->SummonCreature(entry, pos, properties, duration, unitCaster, m_spellInfo->Id, 0, privateObjectOwner);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!summon)
*More work on summon system.
2009-03-20 14:01:46 -06:00
return;
Core/Spells: move paladins judgements to spellscripts
2014-01-26 23:56:53 +01:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (summon->HasUnitTypeMask(UNIT_MASK_GUARDIAN))
*More work on summon system.
2009-03-20 14:01:46 -06:00
((Guardian*)summon)->InitStatsForLevel(level);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/DataStores: Fixed db2 structures after 7.3.5
2018-03-12 18:20:26 +01:00
if (properties && properties->Control == SUMMON_CATEGORY_ALLY)
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
summon->SetFaction(unitCaster->GetFaction());
Core/Chat: move chat link validation code into separate classes and improve some validation logic
2011-04-27 16:22:42 +06:00
Fixed broken missile visuals in certain DST and SRC type spells (Void Reaver's Arcane Orb and many others). Achieved by fixing wildly incorrect SMSG_SPELL_GO target mask data handling.
2010-03-19 00:21:57 +01:00
if (summon->HasUnitTypeMask(UNIT_MASK_MINION) && m_targets.HasDst())
Core/Position: Refactor GetAngle -> GetAbsoluteAngle because code clarity is good.
2018-04-01 13:52:36 +02:00
((Minion*)summon)->SetFollowAngle(unitCaster->GetAbsoluteAngle(summon));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
if (summon->GetEntry() == 27893)
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
{
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
UF::VisibleItem const& weapon = m_caster->ToPlayer()->m_playerData->VisibleItems[EQUIPMENT_SLOT_MAINHAND];
if (weapon.ItemID)
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
{
Core/Entities: correct creature damage, offhand damage should work too
2014-01-04 18:22:06 +01:00
summon->SetDisplayId(11686); // modelid2
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
summon->SetVirtualItem(0, weapon.ItemID, weapon.ItemAppearanceModID, weapon.ItemVisual);
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
}
else
Core/Entities: correct creature damage, offhand damage should work too
2014-01-04 18:22:06 +01:00
summon->SetDisplayId(1126); // modelid1
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
}
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
*Move MoveFollow owner from MoveTargetedHome to enterevademode.
2009-05-12 10:11:54 -05:00
summon->AI()->EnterEvadeMode();
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effect->Effect), summon);
*More work on summon system.
2009-03-20 14:01:46 -06:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectRenamePet()
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT ||
Core/Misc: Remove unneeded ToCreature() casts
2015-08-12 12:48:33 +02:00
!unitTarget->IsPet() || ((Pet*)unitTarget)->getPetType() != HUNTER_PET)
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
unitTarget->AddPetFlag(UNIT_PET_FLAG_CAN_BE_RENAMED);
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPlayMusic()
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 soundid = effectInfo->MiscValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/DataStores: Updated dbc/db2 to 7.0.1.20810
2016-01-24 15:56:10 +01:00
if (!sSoundKitStore.LookupEntry(soundid))
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "EffectPlayMusic: Sound (Id: %u) does not exist in spell %u.", soundid, m_spellInfo->Id);
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Game: Include cleanup part 5
2017-06-04 01:00:45 +02:00
unitTarget->ToPlayer()->SendDirectMessage(WorldPackets::Misc::PlayMusic(soundid).Write());
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectActivateSpec()
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed EffectActivateSpec for hunter pets
2017-03-21 17:36:44 +01:00
Player* player = unitTarget->ToPlayer();
uint32 specID = m_misc.SpecializationId;
ChrSpecializationEntry const* spec = sChrSpecializationStore.AssertEntry(specID);
// Safety checks done in Spell::CheckCast
if (!spec->IsPetSpecialization())
player->ActivateTalentGroup(spec);
else
player->GetPet()->SetSpecialization(specID);
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPlaySound()
Update aura system:
2010-01-10 01:23:15 +01:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Chat: cleanup MonsterText methods
2014-09-13 20:41:31 +02:00
if (!unitTarget)
return;
Player* player = unitTarget->ToPlayer();
if (!player)
Update aura system:
2010-01-10 01:23:15 +01:00
return;
Cosmetic: Multiple cosmetic changes
2011-09-29 12:43:05 +02:00
switch (m_spellInfo->Id)
Update aura system:
2010-01-10 01:23:15 +01:00
{
Core/Spells: Update no fly zone for wintergrasp
2013-01-03 17:37:39 +01:00
case 91604: // Restricted Flight Area
Core/Chat: cleanup MonsterText methods
2014-09-13 20:41:31 +02:00
player->GetSession()->SendNotification(LANG_ZONE_NOFLYZONE);
Core/Spells: Update no fly zone for wintergrasp
2013-01-03 17:37:39 +01:00
break;
default:
Update aura system:
2010-01-10 01:23:15 +01:00
break;
}
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
2011-03-07 21:13:18 +01:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 soundId = effectInfo->MiscValue;
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
2011-03-07 21:13:18 +01:00
Core/DataStores: Updated dbc/db2 to 7.0.1.20810
2016-01-24 15:56:10 +01:00
if (!sSoundKitStore.LookupEntry(soundId))
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
2011-03-07 21:13:18 +01:00
{
Merge pull request #16038 from tkrokli/grammar_and_spelling_corrections_335
2016-02-20 13:23:35 +01:00
TC_LOG_ERROR("spells", "EffectPlaySound: Sound (Id: %u) does not exist in spell %u.", soundId, m_spellInfo->Id);
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
2011-03-07 21:13:18 +01:00
return;
}
Core/Chat: cleanup MonsterText methods
2014-09-13 20:41:31 +02:00
player->PlayDirectSound(soundId, player);
Update aura system:
2010-01-10 01:23:15 +01:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectRemoveAura()
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
if (!unitTarget)
return;
// there may be need of specifying casterguid of removed auras
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
unitTarget->RemoveAurasDueToSpell(effectInfo->TriggerSpell);
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDamageFromMaxHealthPCT()
Core/Spells: Implemented effect SPELL_EFFECT_DAMAGE_FROM_MAX_HEALTH_PCT
2012-12-31 02:10:04 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget)
return;
m_damage += unitTarget->CountPctFromMaxHealth(damage);
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectGiveCurrency()
Core/Spells: Implemented SPELL_EFFECT_GIVE_CURRENCY.
2013-01-01 17:48:09 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Core/Spells: Fixed possible crash
2017-02-25 00:05:21 +01:00
if (!sCurrencyTypesStore.LookupEntry(effectInfo->MiscValue))
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
unitTarget->ToPlayer()->ModifyCurrency(effectInfo->MiscValue, damage);
Core/Spells: Implemented SPELL_EFFECT_GIVE_CURRENCY.
2013-01-01 17:48:09 +01:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCastButtons()
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Player* player = m_caster->ToPlayer();
if (!player)
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
return;
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
uint32 button_id = effectInfo->MiscValue + 132;
uint32 n_buttons = effectInfo->MiscValueB;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
Core/Transport: Minor optimization in LoadTransports (And some cosmetic changes here and there in other files)
2011-08-03 08:18:24 +02:00
for (; n_buttons; --n_buttons, ++button_id)
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
{
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
ActionButton const* ab = player->GetActionButton(button_id);
Fix Shaman totem bars and Call of the Elements/Spirits/Ancestors
2010-04-29 11:35:31 +02:00
if (!ab || ab->GetType() != ACTION_BUTTON_SPELL)
continue;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
Core/Achievements: Award normal mode achievements when instance was done on heroic mode
2011-09-05 15:21:37 +02:00
//! Action button data is unverified when it's set so it can be "hacked"
Core/Spells: Fix Shaman totem bar exploit that would allow the player to cast any spell when using Call of the Elements etc.
2011-07-31 14:10:47 +02:00
//! to contain invalid spells, so filter here.
Fix action buttons sent to client when swapping between talent specs. Storage related parts by Hunuza (MaNGOS), big thanks.
2010-04-28 16:08:31 +02:00
uint32 spell_id = ab->GetAction();
if (!spell_id)
continue;
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(spell_id, GetCastDifficulty());
Core/Spells: Fix Shaman totem bar exploit that would allow the player to cast any spell when using Call of the Elements etc.
2011-07-31 14:10:47 +02:00
if (!spellInfo)
Fix action buttons sent to client when swapping between talent specs. Storage related parts by Hunuza (MaNGOS), big thanks.
2010-04-28 16:08:31 +02:00
continue;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!player->HasSpell(spell_id) || player->GetSpellHistory()->HasCooldown(spell_id))
Core/Spells: Fix Shaman totem bar exploit that would allow the player to cast any spell when using Call of the Elements etc.
2011-07-31 14:10:47 +02:00
continue;
Core/Spells: Implement HasAttribute() helper for SpellInfo for easier readability
2015-01-05 23:49:43 +02:00
if (!spellInfo->HasAttribute(SPELL_ATTR9_SUMMON_PLAYER_TOTEM))
Core/Spells: Fix Shaman totem bar exploit that would allow the player to cast any spell when using Call of the Elements etc.
2011-07-31 14:10:47 +02:00
continue;
Core: Code cleanup (here and there)
2011-09-05 14:01:50 +02:00
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
CastSpellExtraArgs args;
args.TriggerFlags = TriggerCastFlags(TRIGGERED_IGNORE_GCD | TRIGGERED_IGNORE_CAST_IN_PROGRESS | TRIGGERED_CAST_DIRECTLY | TRIGGERED_DONT_REPORT_CAST_ERROR);
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
args.OriginalCastId = m_castId;
[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)
2017-12-30 20:28:41 +01:00
args.CastDifficulty = GetCastDifficulty();
m_caster->CastSpell(m_caster, spellInfo->Id, args);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
}
}
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectRechargeItem()
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Spells: Renamed SPELL_EFFECT_CREATE_MANA_GEM to SPELL_EFFECT_RECHARGE_ITEM
2017-07-29 18:01:12 +02:00
if (!unitTarget)
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
return;
Core/Spells: Renamed SPELL_EFFECT_CREATE_MANA_GEM to SPELL_EFFECT_RECHARGE_ITEM
2017-07-29 18:01:12 +02:00
Player* player = unitTarget->ToPlayer();
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
if (!player)
return;
Core/Spells: spell system updates (no-compile-version_2)
2014-11-17 20:38:56 +01:00
Core/Spells: Renamed SPELL_EFFECT_CREATE_MANA_GEM to SPELL_EFFECT_RECHARGE_ITEM
2017-07-29 18:01:12 +02:00
if (Item* item = player->GetItemByEntry(effectInfo->ItemType))
{
Core/Items: Implemented new bonus type (extra ItemEffect)
2020-06-05 00:27:40 +02:00
for (ItemEffectEntry const* itemEffect : item->GetEffects())
if (itemEffect->LegacySlotIndex <= item->m_itemData->SpellCharges.size())
item->SetSpellCharges(itemEffect->LegacySlotIndex, itemEffect->Charges);
Core/Spells: Renamed SPELL_EFFECT_CREATE_MANA_GEM to SPELL_EFFECT_RECHARGE_ITEM
2017-07-29 18:01:12 +02:00
item->SetState(ITEM_CHANGED, player);
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
}
}
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectBind()
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
{
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
2010-12-03 13:54:00 +01:00
Player* player = unitTarget->ToPlayer();
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
Core/Player: correct SetHomebind and cleanup Spell::EffectBind
2012-12-08 23:46:16 +01:00
WorldLocation homeLoc;
uint32 areaId = player->GetAreaId();
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
if (effectInfo->MiscValue)
areaId = effectInfo->MiscValue;
Core/Player: correct SetHomebind and cleanup Spell::EffectBind
2012-12-08 23:46:16 +01:00
if (m_targets.HasDst())
homeLoc.WorldRelocate(*destTarget);
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
else
Core/Misc: Change how Position struct is retrieved
2014-04-25 21:19:30 +02:00
homeLoc = player->GetWorldLocation();
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
Core/Player: correct SetHomebind and cleanup Spell::EffectBind
2012-12-08 23:46:16 +01:00
player->SetHomebind(homeLoc, areaId);
Core/Packets: updated SMSG_BINDPOINTUPDATE, SMSG_INVALIDATE_PLAYER, SMSG_LOGIN_SETTIMESPEED, SMSG_WORLD_SERVER_INFO
2014-11-19 02:12:47 +01:00
player->SendBindPointUpdate();
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
Core/Characters: Made homebind location a WorldLocation (this implicitly adds orientation) (#27055)
2021-10-16 01:17:47 +02:00
TC_LOG_DEBUG("spells", "EffectBind: New homebind X: %f, Y: %f, Z: %f O: %f, MapId: %u, AreaId: %u",
homeLoc.GetPositionX(), homeLoc.GetPositionY(), homeLoc.GetPositionZ(), homeLoc.GetOrientation(), homeLoc.GetMapId(), areaId);
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
// zone update
Core/Player: Added SendPlayerBound method
2021-10-13 18:08:50 +02:00
player->SendPlayerBound(m_caster->GetGUID(), areaId);
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
}
Core/Refer-a-Friend: Finish base work for Refer-a-Friend.
2011-08-03 09:28:12 -07:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectTeleportToReturnPoint()
Core/Spells: Implement SPELL_EFFECT_TELEPORT_TO_RETURN_POINT (#26217)
2021-03-28 02:22:34 +03:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (Player* player = unitTarget->ToPlayer())
if (WorldLocation const* dest = player->GetStoredAuraTeleportLocation(effectInfo->MiscValue))
player->TeleportTo(*dest, unitTarget == m_caster ? TELE_TO_SPELL | TELE_TO_NOT_LEAVE_COMBAT : 0);
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonRaFFriend()
Core/Spells: spell effect handling improvements
2011-09-25 13:29:17 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Core/Refer-a-Friend: Finish base work for Refer-a-Friend.
2011-08-03 09:28:12 -07:00
Core: Cosmetic changes in Threat related code (per request) and remove of extra call to SpellMgr singleton inside that singleton
2011-08-04 13:16:09 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER || !unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
Core/Refer-a-Friend: Finish base work for Refer-a-Friend.
2011-08-03 09:28:12 -07:00
return;
Core/Spells: Send OriginalCastId in SMSG_SPELL_START and SMSG_SPELL_GO for triggered spells in 'game' project
2021-10-03 16:36:39 +02:00
m_caster->CastSpell(unitTarget, effectInfo->TriggerSpell, CastSpellExtraArgs(TRIGGERED_FULL_MASK)
.SetOriginalCastId(m_castId));
Core/Refer-a-Friend: Finish base work for Refer-a-Friend.
2011-08-03 09:28:12 -07:00
}
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUnlockGuildVaultTab()
Core/Guilds: Fixed 7th and 8th guild bault tabs.
2013-07-06 15:03:23 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
// Safety checks done in Spell::CheckCast
Player* caster = m_caster->ToPlayer();
if (Guild* guild = caster->GetGuild())
Core/Spells: Removed useless calls of Spell::GetEffect and SpellInfo::GetEffect
2018-08-11 15:08:57 +02:00
guild->HandleBuyBankTab(caster->GetSession(), damage - 1); // Bank tabs start at zero internally
Core/Guilds: Fixed 7th and 8th guild bault tabs.
2013-07-06 15:03:23 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSummonPersonalGameObject()
Core/Spells: Implemented summoning a personal gameobject effect (#25917)
2021-01-23 17:44:47 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
uint32 goId = effectInfo->MiscValue;
if (!goId)
return;
float x, y, z;
if (m_targets.HasDst())
destTarget->GetPosition(x, y, z);
else
m_caster->GetClosePoint(x, y, z, DEFAULT_PLAYER_BOUNDING_RADIUS);
Map* map = m_caster->GetMap();
Position pos = Position(x, y, z, m_caster->GetOrientation());
QuaternionData rot = QuaternionData::fromEulerAnglesZYX(m_caster->GetOrientation(), 0.f, 0.f);
GameObject* go = GameObject::CreateGameObject(goId, map, pos, rot, 255, GO_STATE_READY);
if (!go)
{
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
TC_LOG_WARN("spells", "SpellEffect Failed to summon personal gameobject. SpellId %u, effect %u", m_spellInfo->Id, effectInfo->EffectIndex);
Core/Spells: Implemented summoning a personal gameobject effect (#25917)
2021-01-23 17:44:47 +02:00
return;
}
PhasingHandler::InheritPhaseShift(go, m_caster);
int32 duration = m_spellInfo->CalcDuration(m_caster);
go->SetRespawnTime(duration > 0 ? duration / IN_MILLISECONDS : 0);
go->SetSpellId(m_spellInfo->Id);
Core/Objects: Move personal summon handling from TemporarySummon/GameObject to WorldObject and check it using dedicated guid field
2021-03-14 21:23:07 +02:00
go->SetPrivateObjectOwner(m_caster->GetGUID());
Core/Spells: Implemented summoning a personal gameobject effect (#25917)
2021-01-23 17:44:47 +02:00
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), go);
Core/Spells: Implemented summoning a personal gameobject effect (#25917)
2021-01-23 17:44:47 +02:00
map->AddToMap(go);
if (GameObject* linkedTrap = go->GetLinkedTrap())
{
PhasingHandler::InheritPhaseShift(linkedTrap, m_caster);
linkedTrap->SetRespawnTime(duration > 0 ? duration / IN_MILLISECONDS : 0);
linkedTrap->SetSpellId(m_spellInfo->Id);
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectSummonObject(SpellEffectName(effectInfo->Effect), linkedTrap);
Core/Spells: Implemented summoning a personal gameobject effect (#25917)
2021-01-23 17:44:47 +02:00
}
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectResurrectWithAura()
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || !unitTarget->IsInWorld())
return;
Player* target = unitTarget->ToPlayer();
if (!target)
return;
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
2013-06-13 19:35:01 +02:00
if (unitTarget->IsAlive())
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
return;
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
2014-05-25 21:52:27 +02:00
if (target->IsResurrectRequested()) // already have one active request
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
return;
uint32 health = target->CountPctFromMaxHealth(damage);
uint32 mana = CalculatePct(target->GetMaxPower(POWER_MANA), damage);
uint32 resurrectAura = 0;
Core/Spells: Implement using different difficulty data from all spell related db2s, not just SpellEffect and SpellPower
2020-06-12 01:29:18 +02:00
if (sSpellMgr->GetSpellInfo(effectInfo->TriggerSpell, DIFFICULTY_NONE))
Core/Spells: Implemented using dbc spellpower/ap coeffiecients for spells
2014-12-19 23:52:29 +01:00
resurrectAura = effectInfo->TriggerSpell;
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
if (resurrectAura && target->HasAura(resurrectAura))
return;
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectResurrect(SpellEffectName(effectInfo->Effect), target);
Core/Spells: Implemented SPELL_EFFECT_RESURRECT_WITH_AURA (effect number 172)
2013-01-01 21:57:31 +01:00
target->SetResurrectRequestData(m_caster, health, mana, resurrectAura);
SendResurrectRequest(target);
}
Core/Spells: Implement SPELL_EFFECT_CREATE_AREATRIGGER (effect #179)
2013-05-26 04:47:10 +03:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateAreaTrigger()
Core/Spells: Implement SPELL_EFFECT_CREATE_AREATRIGGER (effect #179)
2013-05-26 04:47:10 +03:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !m_targets.HasDst())
Core/Entities: Basic AreaTrigger System (#18035)
2017-01-29 00:00:43 +01:00
return;
Core/Spells: Implement SPELL_EFFECT_CREATE_AREATRIGGER (effect #179)
2013-05-26 04:47:10 +03:00
Core/Entities: Basic AreaTrigger System (#18035)
2017-01-29 00:00:43 +01:00
int32 duration = GetSpellInfo()->CalcDuration(GetCaster());
Core/Entities: Created factory methods to create new areatriggers, creatures and gameobjects
2018-01-27 21:47:37 +01:00
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
AreaTrigger::CreateAreaTrigger(effectInfo->MiscValue, unitCaster, nullptr, GetSpellInfo(), destTarget->GetPosition(), duration, m_SpellVisual, m_castId);
Core/Spells: Implement SPELL_EFFECT_CREATE_AREATRIGGER (effect #179)
2013-05-26 04:47:10 +03:00
}
Core/Spells: Reimplemented automatic spell learning
2015-01-30 23:58:16 +01:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectRemoveTalent()
Core/Spells: Reimplemented automatic spell learning
2015-01-30 23:58:16 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
TalentEntry const* talent = sTalentStore.LookupEntry(m_misc.TalentId);
if (!talent)
return;
Player* player = unitTarget ? unitTarget->ToPlayer() : nullptr;
if (!player)
return;
player->RemoveTalent(talent);
player->SendTalentsInfoData();
}
Core/Spells: implemented SPELL_EFFECT_DESTROY_ITEM
2015-04-06 14:01:39 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectDestroyItem()
Core/Spells: implemented SPELL_EFFECT_DESTROY_ITEM
2015-04-06 14:01:39 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Player* player = unitTarget->ToPlayer();
Core/Spells: Removed useless calls of Spell::GetEffect and SpellInfo::GetEffect
2018-08-11 15:08:57 +02:00
if (Item* item = player->GetItemByEntry(effectInfo->ItemType))
Core/Spells: small cleanup in EffectDestroyItem
2015-04-06 19:50:21 +02:00
player->DestroyItem(item->GetBagSlot(), item->GetSlot(), true);
Core/Spells: implemented SPELL_EFFECT_DESTROY_ITEM
2015-04-06 14:01:39 +02:00
}
Core/Garrisons: Basics for garrisons
2015-05-08 00:03:15 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLearnGarrisonBuilding()
Core/Garrisons: Basics for garrisons
2015-05-08 00:03:15 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
if (Garrison* garrison = unitTarget->ToPlayer()->GetGarrison())
Core/Spells: Removed useless calls of Spell::GetEffect and SpellInfo::GetEffect
2018-08-11 15:08:57 +02:00
garrison->LearnBlueprint(effectInfo->MiscValue);
Core/Garrisons: Basics for garrisons
2015-05-08 00:03:15 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateGarrison()
Core/Garrisons: Basics for garrisons
2015-05-08 00:03:15 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Core/Spells: Removed useless calls of Spell::GetEffect and SpellInfo::GetEffect
2018-08-11 15:08:57 +02:00
unitTarget->ToPlayer()->CreateGarrison(effectInfo->MiscValue);
Core/Garrisons: Basics for garrisons
2015-05-08 00:03:15 +02:00
}
Core/Garrisons: Initial work on garrison followers
2015-05-17 18:06:28 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateConversation()
Core/Entities : Basic Conversation Implementation (#18010)
2017-05-14 11:40:55 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !m_targets.HasDst())
Core/Entities : Basic Conversation Implementation (#18010)
2017-05-14 11:40:55 +02:00
return;
Core/Conversations: Replace _participants with generic personal object implementation
2021-10-09 13:30:47 +02:00
Conversation::CreateConversation(effectInfo->MiscValue, unitCaster, destTarget->GetPosition(), ObjectGuid::Empty, GetSpellInfo());
Core/Entities : Basic Conversation Implementation (#18010)
2017-05-14 11:40:55 +02:00
}
Core/Spells: Implemented SPELL_EFFECT_CANCEL_CONVERSATION (#27037)
2021-10-11 14:50:04 +02:00
void Spell::EffectCancelConversation()
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget)
return;
std::vector<WorldObject*> objs;
Trinity::ObjectEntryAndPrivateOwnerIfExistsCheck check(unitTarget->GetGUID(), effectInfo->MiscValue);
Trinity::WorldObjectListSearcher<Trinity::ObjectEntryAndPrivateOwnerIfExistsCheck> checker(unitTarget, objs, check, GRID_MAP_TYPE_MASK_CONVERSATION);
Cell::VisitGridObjects(unitTarget, checker, 100.0f);
for (WorldObject* obj : objs)
{
if (Conversation* convo = obj->ToConversation())
convo->Remove();
}
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectAddGarrisonFollower()
Core/Garrisons: Initial work on garrison followers
2015-05-17 18:06:28 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
if (Garrison* garrison = unitTarget->ToPlayer()->GetGarrison())
Core/Spells: Removed useless calls of Spell::GetEffect and SpellInfo::GetEffect
2018-08-11 15:08:57 +02:00
garrison->AddFollower(effectInfo->MiscValue);
Core/Garrisons: Initial work on garrison followers
2015-05-17 18:06:28 +02:00
}
Core/Garrisons: Implemented activating buildings
2015-06-22 00:02:02 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreateHeirloomItem()
Core/Player: implemented Heirloom Collection
2015-10-16 22:54:46 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Player* player = m_caster->ToPlayer();
if (!player)
return;
CollectionMgr* collectionMgr = player->GetSession()->GetCollectionMgr();
if (!collectionMgr)
return;
std::vector<int32> bonusList;
bonusList.push_back(collectionMgr->GetHeirloomBonus(m_misc.Raw.Data[0]));
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
DoCreateItem(m_misc.Raw.Data[0], ItemContext::NONE, bonusList);
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00
ExecuteLogEffectCreateItem(SpellEffectName(effectInfo->Effect), m_misc.Raw.Data[0]);
Core/Player: implemented Heirloom Collection
2015-10-16 22:54:46 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectActivateGarrisonBuilding()
Core/Garrisons: Implemented activating buildings
2015-06-22 00:02:02 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
if (Garrison* garrison = unitTarget->ToPlayer()->GetGarrison())
Core/Spells: Removed useless calls of Spell::GetEffect and SpellInfo::GetEffect
2018-08-11 15:08:57 +02:00
garrison->ActivateBuilding(effectInfo->MiscValue);
Core/Garrisons: Implemented activating buildings
2015-06-22 00:02:02 +02:00
}
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectHealBattlePetPct()
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
if (BattlePetMgr* battlePetMgr = unitTarget->ToPlayer()->GetSession()->GetBattlePetMgr())
Core/Spells: Removed useless calls of Spell::GetEffect and SpellInfo::GetEffect
2018-08-11 15:08:57 +02:00
battlePetMgr->HealBattlePetsPct(damage);
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectEnableBattlePets()
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Player* plr = unitTarget->ToPlayer();
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
plr->AddPlayerFlag(PLAYER_FLAGS_PET_BATTLES_UNLOCKED);
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
plr->GetSession()->GetBattlePetMgr()->UnlockSlot(0);
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLaunchQuestChoice()
Core/Quests: Implemented player choices
2017-12-17 14:40:04 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || !unitTarget->IsPlayer())
return;
Core/Quests: Implemented player choice rewards
2017-12-31 18:37:09 +01:00
unitTarget->ToPlayer()->SendPlayerChoice(GetCaster()->GetGUID(), effectInfo->MiscValue);
Core/Quests: Implemented player choices
2017-12-17 14:40:04 +01:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUncageBattlePet()
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (!m_CastItem || !m_caster || m_caster->GetTypeId() != TYPEID_PLAYER)
return;
uint32 speciesId = m_CastItem->GetModifier(ITEM_MODIFIER_BATTLE_PET_SPECIES_ID);
uint16 breed = m_CastItem->GetModifier(ITEM_MODIFIER_BATTLE_PET_BREED_DATA) & 0xFFFFFF;
uint8 quality = (m_CastItem->GetModifier(ITEM_MODIFIER_BATTLE_PET_BREED_DATA) >> 24) & 0xFF;
uint16 level = m_CastItem->GetModifier(ITEM_MODIFIER_BATTLE_PET_LEVEL);
Core/BattlePets: Misc fixes (#27057)
2021-10-16 12:15:03 +02:00
uint32 displayId = m_CastItem->GetModifier(ITEM_MODIFIER_BATTLE_PET_DISPLAY_ID);
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
BattlePetSpeciesEntry const* speciesEntry = sBattlePetSpeciesStore.LookupEntry(speciesId);
if (!speciesEntry)
return;
Core/BattlePets: Misc fixes (#27057)
2021-10-16 12:15:03 +02:00
Player* plr = m_caster->ToPlayer();
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
BattlePetMgr* battlePetMgr = plr->GetSession()->GetBattlePetMgr();
if (!battlePetMgr)
return;
Core/BattlePets: Misc fixes
2018-01-02 14:04:09 +01:00
if (battlePetMgr->GetMaxPetLevel() < level)
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
{
Core/BattlePets: Misc fixes (#27057)
2021-10-16 12:15:03 +02:00
battlePetMgr->SendError(BATTLEPETRESULT_TOO_HIGH_LEVEL_TO_UNCAGE, speciesEntry->CreatureID);
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
SendCastResult(SPELL_FAILED_CANT_ADD_BATTLE_PET);
return;
}
Core/BattlePets: Misc fixes (#26964)
2021-09-29 22:26:25 +02:00
if (battlePetMgr->HasMaxPetCount(speciesEntry))
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
{
Core/BattlePets: Misc fixes (#27057)
2021-10-16 12:15:03 +02:00
battlePetMgr->SendError(BATTLEPETRESULT_CANT_HAVE_MORE_PETS_OF_THAT_TYPE, speciesEntry->CreatureID);
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
SendCastResult(SPELL_FAILED_CANT_ADD_BATTLE_PET);
return;
}
Core/BattlePets: Misc fixes (#27057)
2021-10-16 12:15:03 +02:00
battlePetMgr->AddPet(speciesId, displayId, breed, BattlePetBreedQuality(quality), level);
Core/BattlePets: Misc fixes
2018-01-02 14:04:09 +01:00
Core/BattlePets: Fixes when adding pets (#27076)
2021-10-17 00:11:48 +02:00
if (speciesEntry->SummonSpellID)
if (!plr->HasSpell(speciesEntry->SummonSpellID))
plr->LearnSpell(speciesEntry->SummonSpellID, false);
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
Core/BattlePets: Misc fixes (#27057)
2021-10-16 12:15:03 +02:00
plr->SendPlaySpellVisual(plr, SPELL_VISUAL_UNCAGE_PET, 0, 0, 0.f, false);
Core/BattlePets: Basics for Battle Pets
2015-09-09 14:52:32 +02:00
plr->DestroyItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), true);
m_CastItem = nullptr;
}
Core/Player: implemented Heirloom Collection
2015-10-16 22:54:46 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUpgradeHeirloom()
Core/Player: implemented Heirloom Collection
2015-10-16 22:54:46 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (Player* player = m_caster->ToPlayer())
if (CollectionMgr* collectionMgr = player->GetSession()->GetCollectionMgr())
Core/DataStores: Fixed db2 structures after 7.3.5
2018-03-12 18:20:26 +01:00
collectionMgr->UpgradeHeirloom(m_misc.Raw.Data[0], int32(m_castItemEntry));
Core/Player: implemented Heirloom Collection
2015-10-16 22:54:46 +02:00
}
Core/Spells: Implemented spell effect 243 - SPELL_EFFECT_APPLY_ENCHANT_ILLUSION (and fixed enchant visuals, for real this time)
2016-04-07 21:36:36 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectApplyEnchantIllusion()
Core/Spells: Implemented spell effect 243 - SPELL_EFFECT_APPLY_ENCHANT_ILLUSION (and fixed enchant visuals, for real this time)
2016-04-07 21:36:36 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!itemTarget)
return;
Player* player = m_caster->ToPlayer();
if (!player || player->GetGUID() != itemTarget->GetOwnerGUID())
return;
itemTarget->SetState(ITEM_CHANGED, player);
Core/Transmog: Implemented transmog collection and updated transmog handling
2016-07-05 22:07:35 +02:00
itemTarget->SetModifier(ITEM_MODIFIER_ENCHANT_ILLUSION_ALL_SPECS, effectInfo->MiscValue);
Core/Spells: Implemented spell effect 243 - SPELL_EFFECT_APPLY_ENCHANT_ILLUSION (and fixed enchant visuals, for real this time)
2016-04-07 21:36:36 +02:00
if (itemTarget->IsEquipped())
Core/PacketIO: Rewrite updatefield handling
2019-06-03 20:40:34 +02:00
player->SetVisibleItemSlot(itemTarget->GetSlot(), itemTarget);
Core/Spells: Implemented spell effect 243 - SPELL_EFFECT_APPLY_ENCHANT_ILLUSION (and fixed enchant visuals, for real this time)
2016-04-07 21:36:36 +02:00
player->RemoveTradeableItem(itemTarget);
itemTarget->ClearSoulboundTradeable(player);
}
Core/Spells: Implemented spell effects SPELL_EFFECT_UPDATE_PLAYER_PHASE and SPELL_EFFECT_UPDATE_ZONE_AURAS_AND_PHASES (#16957)
2016-04-13 20:24:51 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUpdatePlayerPhase()
Core/Spells: Implemented spell effects SPELL_EFFECT_UPDATE_PLAYER_PHASE and SPELL_EFFECT_UPDATE_ZONE_AURAS_AND_PHASES (#16957)
2016-04-13 20:24:51 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Core/Entities: Phasing rewrite
2018-01-28 11:37:20 +01:00
PhasingHandler::OnConditionChange(unitTarget);
Core/Spells: Implemented spell effects SPELL_EFFECT_UPDATE_PLAYER_PHASE and SPELL_EFFECT_UPDATE_ZONE_AURAS_AND_PHASES (#16957)
2016-04-13 20:24:51 +02:00
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectUpdateZoneAurasAndPhases()
Core/Spells: Implemented spell effects SPELL_EFFECT_UPDATE_PLAYER_PHASE and SPELL_EFFECT_UPDATE_ZONE_AURAS_AND_PHASES (#16957)
2016-04-13 20:24:51 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
unitTarget->ToPlayer()->UpdateAreaDependentAuras(unitTarget->GetAreaId());
}
Core/Items: Implemented artifacts
2016-08-15 00:03:38 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectGiveArtifactPower()
Core/Items: Implemented artifacts
2016-08-15 00:03:38 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
Player* playerCaster = m_caster->ToPlayer();
if (!playerCaster)
Core/Items: Implemented artifacts
2016-08-15 00:03:38 +02:00
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (Aura* artifactAura = playerCaster->GetAura(ARTIFACTS_ALL_WEAPONS_GENERAL_WEAPON_EQUIPPED_PASSIVE))
if (Item* artifact = playerCaster->GetItemByGuid(artifactAura->GetCastItemGUID()))
Core/Items: Implemented artifacts
2016-08-15 00:03:38 +02:00
artifact->GiveArtifactXp(damage, m_CastItem, uint32(effectInfo->MiscValue));
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectGiveArtifactPowerNoBonus()
Core/Items: Implemented artifacts
2016-08-15 00:03:38 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_LAUNCH_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
if (Aura* artifactAura = unitTarget->GetAura(ARTIFACTS_ALL_WEAPONS_GENERAL_WEAPON_EQUIPPED_PASSIVE))
if (Item* artifact = unitTarget->ToPlayer()->GetItemByGuid(artifactAura->GetCastItemGUID()))
artifact->GiveArtifactXp(damage, m_CastItem, 0);
}
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE (#19836)
2017-06-04 15:07:34 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPlaySceneScriptPackage()
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
Core/Scenes: Defined more flags and implemented FadeToBlackscreenOnCancel (#26975)
2021-10-05 22:36:22 +02:00
m_caster->ToPlayer()->GetSceneMgr().PlaySceneByPackageId(effectInfo->MiscValue, SceneFlag::PlayerNonInteractablePhased, destTarget);
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
}
Core/Scenes: Implemented spell created SceneObjects
2021-10-11 12:59:19 +02:00
template<typename TargetInfo>
bool IsUnitTargetSceneObjectAura(Spell const* spell, TargetInfo const& target)
{
if (target.TargetGUID != spell->GetCaster()->GetGUID())
return false;
for (SpellEffectInfo const& spellEffectInfo : spell->GetSpellInfo()->GetEffects())
if (target.EffectMask & (1 << spellEffectInfo.EffectIndex) && spellEffectInfo.IsUnitOwnedAuraEffect())
return true;
return false;
}
void Spell::EffectCreateSceneObject()
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (!unitCaster || !m_targets.HasDst())
return;
if (SceneObject* sceneObject = SceneObject::CreateSceneObject(effectInfo->MiscValue, unitCaster, destTarget->GetPosition(), ObjectGuid::Empty))
{
bool hasAuraTargetingCaster = std::find_if(m_UniqueTargetInfo.begin(), m_UniqueTargetInfo.end(), [this](TargetInfo const& target)
{
return IsUnitTargetSceneObjectAura(this, target);
}) != m_UniqueTargetInfo.end();
if (hasAuraTargetingCaster)
sceneObject->SetCreatedBySpellCast(m_castId);
}
}
void Spell::EffectCreatePrivateSceneObject()
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (!unitCaster || !m_targets.HasDst())
return;
if (SceneObject* sceneObject = SceneObject::CreateSceneObject(effectInfo->MiscValue, unitCaster, destTarget->GetPosition(), unitCaster->GetGUID()))
{
bool hasAuraTargetingCaster = std::find_if(m_UniqueTargetInfo.begin(), m_UniqueTargetInfo.end(), [this](TargetInfo const& target)
{
return IsUnitTargetSceneObjectAura(this, target);
}) != m_UniqueTargetInfo.end();
if (hasAuraTargetingCaster)
sceneObject->SetCreatedBySpellCast(m_castId);
}
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectPlayScene()
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE (#19836)
2017-06-04 15:07:34 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
m_caster->ToPlayer()->GetSceneMgr().PlayScene(effectInfo->MiscValue, destTarget);
}
Core/Players: Implement basics for the honor system
2017-06-04 16:51:47 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectGiveHonor()
Core/Players: Implement basics for the honor system
2017-06-04 16:51:47 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
WorldPackets::Combat::PvPCredit packet;
packet.Honor = damage;
packet.OriginalHonor = damage;
Player* playerTarget = unitTarget->ToPlayer();
playerTarget->AddHonorXP(damage);
playerTarget->SendDirectMessage(packet.Write());
}
Core/Transmog: Implemented transmog sets
2017-08-24 20:39:22 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLearnTransmogSet()
Core/Transmog: Implemented transmog sets
2017-08-24 20:39:22 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
unitTarget->ToPlayer()->GetSession()->GetCollectionMgr()->AddTransmogSet(effectInfo->MiscValue);
}
Core/Items: Implement azerite essences
2019-11-22 11:02:04 +01:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectRespecAzeriteEmpoweredItem()
Core/Items: Implement azerite empowered items
2019-12-05 00:12:35 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
if (!itemTarget || !itemTarget->IsAzeriteEmpoweredItem())
return;
Player* owner = m_caster->ToPlayer();
if (!owner)
return;
AzeriteEmpoweredItem* azeriteEmpoweredItem = itemTarget->ToAzeriteEmpoweredItem();
owner->ModifyMoney(-azeriteEmpoweredItem->GetRespecCost());
// reapply all item mods - item level change affects stats and auras
if (azeriteEmpoweredItem->IsEquipped())
owner->_ApplyItemMods(azeriteEmpoweredItem, azeriteEmpoweredItem->GetSlot(), false);
azeriteEmpoweredItem->ClearSelectedAzeritePowers();
if (azeriteEmpoweredItem->IsEquipped())
owner->_ApplyItemMods(azeriteEmpoweredItem, azeriteEmpoweredItem->GetSlot(), true);
azeriteEmpoweredItem->SetState(ITEM_CHANGED, owner);
owner->SetNumRespecs(owner->GetNumRespecs() + 1);
}
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectLearnAzeriteEssencePower()
Core/Items: Implement azerite essences
2019-11-22 11:02:04 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT_TARGET)
return;
Player* playerTarget = unitTarget ? unitTarget->ToPlayer() : nullptr;
if (!playerTarget)
return;
Core/Items: Calculating item level + organized iterating over items (#26276)
2021-04-21 11:02:42 +03:00
Item* heartOfAzeroth = playerTarget->GetItemByEntry(ITEM_ID_HEART_OF_AZEROTH, ItemSearchLocation::Everywhere);
Core/Items: Implement azerite essences
2019-11-22 11:02:04 +01:00
if (!heartOfAzeroth)
return;
AzeriteItem* azeriteItem = heartOfAzeroth->ToAzeriteItem();
if (!azeriteItem)
return;
// remove old rank and apply new one
if (azeriteItem->IsEquipped())
{
if (UF::SelectedAzeriteEssences const* selectedEssences = azeriteItem->GetSelectedAzeriteEssences())
{
for (int32 slot = 0; slot < MAX_AZERITE_ESSENCE_SLOT; ++slot)
{
if (selectedEssences->AzeriteEssenceID[slot] == uint32(effectInfo->MiscValue))
{
bool major = AzeriteItemMilestoneType(sDB2Manager.GetAzeriteItemMilestonePower(slot)->Type) == AzeriteItemMilestoneType::MajorEssence;
playerTarget->ApplyAzeriteEssence(azeriteItem, effectInfo->MiscValue, MAX_AZERITE_ESSENCE_RANK, major, false);
playerTarget->ApplyAzeriteEssence(azeriteItem, effectInfo->MiscValue, effectInfo->MiscValueB, major, false);
break;
}
}
}
}
azeriteItem->SetEssenceRank(effectInfo->MiscValue, effectInfo->MiscValueB);
azeriteItem->SetState(ITEM_CHANGED, playerTarget);
}
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectCreatePrivateConversation()
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster || !unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
return;
Core/Conversations: Replace _participants with generic personal object implementation
2021-10-09 13:30:47 +02:00
Conversation::CreateConversation(effectInfo->MiscValue, unitCaster, unitTarget->GetPosition(), unitTarget->GetGUID(), GetSpellInfo());
Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION
2021-03-04 20:31:08 +01:00
}
Core/DataStores: 9.1.0 db2 structures
2021-08-07 19:40:34 +02:00
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
void Spell::EffectSendChatMessage()
Core/DataStores: 9.1.0 db2 structures
2021-08-07 19:40:34 +02:00
{
if (effectHandleMode != SPELL_EFFECT_HANDLE_HIT)
return;
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
if (!unitCaster)
return;
Core/DataStores: 9.1.0 db2 structures
2021-08-07 19:40:34 +02:00
uint32 broadcastTextId = effectInfo->MiscValue;
if (!sBroadcastTextStore.LookupEntry(broadcastTextId))
return;
ChatMsg chatType = ChatMsg(effectInfo->MiscValueB);
Core/Spells: rework part 5: GameObject casting
2018-02-10 16:43:01 -03:00
unitCaster->Talk(broadcastTextId, chatType, CreatureTextMgr::GetRangeForChatType(chatType), unitTarget);
Core/DataStores: 9.1.0 db2 structures
2021-08-07 19:40:34 +02:00
}
Reference in New Issue Copy Permalink