josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
fade2383ccebe7a3cce060e00a1a45fa28f1bd3a
TCPlayerbotCore/src/server/game/Spells/SpellEffects.cpp
T

7121 lines
285 KiB
C++
Raw Normal View History

Remove the accidental additions of CRLF-crap from the header updates
2010-10-07 15:35:36 +02:00
/*
Update copyright note for 2011.
2011-01-01 15:01:13 +01:00
* Copyright (C) 2008-2011 TrinityCore <http://www.trinitycore.org/>
Remove the accidental additions of CRLF-crap from the header updates
2010-10-07 15:35:36 +02:00
* Copyright (C) 2005-2009 MaNGOS <http://getmangos.com/>
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
* You should have received a copy of the GNU General Public License along
* with this program. If not, see <http://www.gnu.org/licenses/>.
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
*/
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
#include "Common.h"
* Remove the last of the realative paths from #include statements
2010-06-08 17:01:03 -06:00
#include "DatabaseEnv.h"
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
#include "WorldPacket.h"
#include "Opcodes.h"
#include "Log.h"
#include "UpdateMask.h"
#include "World.h"
#include "ObjectMgr.h"
#include "SpellMgr.h"
#include "Player.h"
#include "SkillExtraItems.h"
#include "Unit.h"
#include "Spell.h"
#include "DynamicObject.h"
#include "SpellAuras.h"
Update aura system:
2010-01-10 01:23:15 +01:00
#include "SpellAuraEffects.h"
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
#include "Group.h"
#include "UpdateData.h"
#include "MapManager.h"
#include "ObjectAccessor.h"
#include "SharedDefines.h"
#include "Pet.h"
#include "GameObject.h"
#include "GossipDef.h"
#include "Creature.h"
#include "Totem.h"
#include "CreatureAI.h"
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
#include "BattlegroundMgr.h"
#include "Battleground.h"
#include "BattlegroundEY.h"
#include "BattlegroundWS.h"
[svn] * Merge Temp dev SVN with Assembla.
2008-10-14 11:57:03 -05:00
#include "OutdoorPvPMgr.h"
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
#include "Language.h"
#include "SocialMgr.h"
#include "Util.h"
HIGHLY EXPERIMENTAL - USE AT YOUR OWN RISK
2010-06-05 00:59:25 +02:00
#include "VMapFactory.h"
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
#include "TemporarySummon.h"
[svn] Added missing includes.
2008-11-15 15:11:31 -06:00
#include "CellImpl.h"
*Let vanish interrupt enemies' casting.
2008-12-21 12:33:03 -06:00
#include "GridNotifiers.h"
#include "GridNotifiersImpl.h"
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
#include "SkillDiscovery.h"
[7435] Fixed Spell::EffectAddHonor to corrcetly add honor based on player's level Author: Triply
2009-03-10 15:28:51 -06:00
#include "Formulas.h"
*Allow spells to summon vehicles.
2009-03-18 21:39:09 -06:00
#include "Vehicle.h"
*Integrate Script system to Core
2010-01-19 11:36:05 +01:00
#include "ScriptMgr.h"
Core/AI: implemented SmartScripts System (still beta) not 100% complete
2010-10-27 21:01:47 +02:00
#include "GameObjectAI.h"
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pEffect SpellEffects[TOTAL_SPELL_EFFECTS]=
{
&Spell::EffectNULL, // 0
&Spell::EffectInstaKill, // 1 SPELL_EFFECT_INSTAKILL
&Spell::EffectSchoolDMG, // 2 SPELL_EFFECT_SCHOOL_DAMAGE
&Spell::EffectDummy, // 3 SPELL_EFFECT_DUMMY
&Spell::EffectUnused, // 4 SPELL_EFFECT_PORTAL_TELEPORT unused
&Spell::EffectTeleportUnits, // 5 SPELL_EFFECT_TELEPORT_UNITS
&Spell::EffectApplyAura, // 6 SPELL_EFFECT_APPLY_AURA
&Spell::EffectEnvirinmentalDMG, // 7 SPELL_EFFECT_ENVIRONMENTAL_DAMAGE
&Spell::EffectPowerDrain, // 8 SPELL_EFFECT_POWER_DRAIN
&Spell::EffectHealthLeech, // 9 SPELL_EFFECT_HEALTH_LEECH
&Spell::EffectHeal, // 10 SPELL_EFFECT_HEAL
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
&Spell::EffectBind, // 11 SPELL_EFFECT_BIND
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectNULL, // 12 SPELL_EFFECT_PORTAL
&Spell::EffectUnused, // 13 SPELL_EFFECT_RITUAL_BASE unused
&Spell::EffectUnused, // 14 SPELL_EFFECT_RITUAL_SPECIALIZE unused
&Spell::EffectUnused, // 15 SPELL_EFFECT_RITUAL_ACTIVATE_PORTAL unused
&Spell::EffectQuestComplete, // 16 SPELL_EFFECT_QUEST_COMPLETE
&Spell::EffectWeaponDmg, // 17 SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL
&Spell::EffectResurrect, // 18 SPELL_EFFECT_RESURRECT
&Spell::EffectAddExtraAttacks, // 19 SPELL_EFFECT_ADD_EXTRA_ATTACKS
&Spell::EffectUnused, // 20 SPELL_EFFECT_DODGE one spell: Dodge
&Spell::EffectUnused, // 21 SPELL_EFFECT_EVADE one spell: Evade (DND)
&Spell::EffectParry, // 22 SPELL_EFFECT_PARRY
&Spell::EffectBlock, // 23 SPELL_EFFECT_BLOCK one spell: Block
&Spell::EffectCreateItem, // 24 SPELL_EFFECT_CREATE_ITEM
&Spell::EffectUnused, // 25 SPELL_EFFECT_WEAPON
&Spell::EffectUnused, // 26 SPELL_EFFECT_DEFENSE one spell: Defense
&Spell::EffectPersistentAA, // 27 SPELL_EFFECT_PERSISTENT_AREA_AURA
&Spell::EffectSummonType, // 28 SPELL_EFFECT_SUMMON
*Move target handling of TARGET_DEST_CASTER_FRONT_LEAP out of SPELL_EFFECT_LEAP handler, this fixes spells with SPELL_EFFECT_LEAP using other target types.
2010-07-21 02:06:51 +02:00
&Spell::EffectLeap, // 29 SPELL_EFFECT_LEAP
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectEnergize, // 30 SPELL_EFFECT_ENERGIZE
&Spell::EffectWeaponDmg, // 31 SPELL_EFFECT_WEAPON_PERCENT_DAMAGE
&Spell::EffectTriggerMissileSpell, // 32 SPELL_EFFECT_TRIGGER_MISSILE
&Spell::EffectOpenLock, // 33 SPELL_EFFECT_OPEN_LOCK
&Spell::EffectSummonChangeItem, // 34 SPELL_EFFECT_SUMMON_CHANGE_ITEM
&Spell::EffectApplyAreaAura, // 35 SPELL_EFFECT_APPLY_AREA_AURA_PARTY
&Spell::EffectLearnSpell, // 36 SPELL_EFFECT_LEARN_SPELL
&Spell::EffectUnused, // 37 SPELL_EFFECT_SPELL_DEFENSE one spell: SPELLDEFENSE (DND)
&Spell::EffectDispel, // 38 SPELL_EFFECT_DISPEL
&Spell::EffectUnused, // 39 SPELL_EFFECT_LANGUAGE
&Spell::EffectDualWield, // 40 SPELL_EFFECT_DUAL_WIELD
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
&Spell::EffectJump, // 41 SPELL_EFFECT_JUMP
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
&Spell::EffectJumpDest, // 42 SPELL_EFFECT_JUMP_DEST
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTeleUnitsFaceCaster, // 43 SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER
&Spell::EffectLearnSkill, // 44 SPELL_EFFECT_SKILL_STEP
&Spell::EffectAddHonor, // 45 SPELL_EFFECT_ADD_HONOR honor/pvp related
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
&Spell::EffectUnused, // 46 SPELL_EFFECT_SPAWN clientside, unit appears as if it was just spawned
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTradeSkill, // 47 SPELL_EFFECT_TRADE_SKILL
&Spell::EffectUnused, // 48 SPELL_EFFECT_STEALTH one spell: Base Stealth
&Spell::EffectUnused, // 49 SPELL_EFFECT_DETECT one spell: Detect
&Spell::EffectTransmitted, // 50 SPELL_EFFECT_TRANS_DOOR
&Spell::EffectUnused, // 51 SPELL_EFFECT_FORCE_CRITICAL_HIT unused
&Spell::EffectUnused, // 52 SPELL_EFFECT_GUARANTEE_HIT one spell: zzOLDCritical Shot
&Spell::EffectEnchantItemPerm, // 53 SPELL_EFFECT_ENCHANT_ITEM
&Spell::EffectEnchantItemTmp, // 54 SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY
&Spell::EffectTameCreature, // 55 SPELL_EFFECT_TAMECREATURE
&Spell::EffectSummonPet, // 56 SPELL_EFFECT_SUMMON_PET
&Spell::EffectLearnPetSpell, // 57 SPELL_EFFECT_LEARN_PET_SPELL
&Spell::EffectWeaponDmg, // 58 SPELL_EFFECT_WEAPON_DAMAGE
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
&Spell::EffectCreateRandomItem, // 59 SPELL_EFFECT_CREATE_RANDOM_ITEM create item base at spell specific loot
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectProficiency, // 60 SPELL_EFFECT_PROFICIENCY
&Spell::EffectSendEvent, // 61 SPELL_EFFECT_SEND_EVENT
&Spell::EffectPowerBurn, // 62 SPELL_EFFECT_POWER_BURN
&Spell::EffectThreat, // 63 SPELL_EFFECT_THREAT
&Spell::EffectTriggerSpell, // 64 SPELL_EFFECT_TRIGGER_SPELL
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
&Spell::EffectApplyAreaAura, // 65 SPELL_EFFECT_APPLY_AREA_AURA_RAID
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
&Spell::EffectRechargeManaGem, // 66 SPELL_EFFECT_CREATE_MANA_GEM (possibly recharge it, misc - is item ID)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectHealMaxHealth, // 67 SPELL_EFFECT_HEAL_MAX_HEALTH
&Spell::EffectInterruptCast, // 68 SPELL_EFFECT_INTERRUPT_CAST
&Spell::EffectDistract, // 69 SPELL_EFFECT_DISTRACT
&Spell::EffectPull, // 70 SPELL_EFFECT_PULL one spell: Distract Move
&Spell::EffectPickPocket, // 71 SPELL_EFFECT_PICKPOCKET
&Spell::EffectAddFarsight, // 72 SPELL_EFFECT_ADD_FARSIGHT
Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
2010-12-22 20:14:30 +02:00
&Spell::EffectUntrainTalents, // 73 SPELL_EFFECT_UNTRAIN_TALENTS
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
&Spell::EffectApplyGlyph, // 74 SPELL_EFFECT_APPLY_GLYPH
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectHealMechanical, // 75 SPELL_EFFECT_HEAL_MECHANICAL one spell: Mechanical Patch Kit
&Spell::EffectSummonObjectWild, // 76 SPELL_EFFECT_SUMMON_OBJECT_WILD
&Spell::EffectScriptEffect, // 77 SPELL_EFFECT_SCRIPT_EFFECT
&Spell::EffectUnused, // 78 SPELL_EFFECT_ATTACK
&Spell::EffectSanctuary, // 79 SPELL_EFFECT_SANCTUARY
&Spell::EffectAddComboPoints, // 80 SPELL_EFFECT_ADD_COMBO_POINTS
&Spell::EffectUnused, // 81 SPELL_EFFECT_CREATE_HOUSE one spell: Create House (TEST)
&Spell::EffectNULL, // 82 SPELL_EFFECT_BIND_SIGHT
&Spell::EffectDuel, // 83 SPELL_EFFECT_DUEL
&Spell::EffectStuck, // 84 SPELL_EFFECT_STUCK
&Spell::EffectSummonPlayer, // 85 SPELL_EFFECT_SUMMON_PLAYER
&Spell::EffectActivateObject, // 86 SPELL_EFFECT_ACTIVATE_OBJECT
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
&Spell::EffectWMODamage, // 87 SPELL_EFFECT_WMO_DAMAGE
&Spell::EffectWMORepair, // 88 SPELL_EFFECT_WMO_REPAIR
Core/Spells: Implement SPELL_EFFECT_WMO_CHANGE, patch by Heisenberg
2010-12-01 20:59:05 +02:00
&Spell::EffectWMOChange, // 89 SPELL_EFFECT_WMO_CHANGE // 0 intact // 1 damaged // 2 destroyed // 3 rebuilding
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
&Spell::EffectKillCreditPersonal, // 90 SPELL_EFFECT_KILL_CREDIT Kill credit but only for single person
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectUnused, // 91 SPELL_EFFECT_THREAT_ALL one spell: zzOLDBrainwash
&Spell::EffectEnchantHeldItem, // 92 SPELL_EFFECT_ENCHANT_HELD_ITEM
Change SPELL_EFFECT_SUMMON_PHANTAS to SPELL_EFFECT_FORCE_DESELECT and allow it to be casted with active pet
2010-01-13 10:27:44 +01:00
&Spell::EffectForceDeselect, // 93 SPELL_EFFECT_FORCE_DESELECT
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectSelfResurrect, // 94 SPELL_EFFECT_SELF_RESURRECT
&Spell::EffectSkinning, // 95 SPELL_EFFECT_SKINNING
*Fix broken charge spells.
2009-05-04 12:11:54 -05:00
&Spell::EffectCharge, // 96 SPELL_EFFECT_CHARGE
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
&Spell::EffectCastButtons, // 97 SPELL_EFFECT_CAST_BUTTON (totem bar since 3.2.2a)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectKnockBack, // 98 SPELL_EFFECT_KNOCK_BACK
&Spell::EffectDisEnchant, // 99 SPELL_EFFECT_DISENCHANT
&Spell::EffectInebriate, //100 SPELL_EFFECT_INEBRIATE
&Spell::EffectFeedPet, //101 SPELL_EFFECT_FEED_PET
&Spell::EffectDismissPet, //102 SPELL_EFFECT_DISMISS_PET
&Spell::EffectReputation, //103 SPELL_EFFECT_REPUTATION
&Spell::EffectSummonObject, //104 SPELL_EFFECT_SUMMON_OBJECT_SLOT1
&Spell::EffectSummonObject, //105 SPELL_EFFECT_SUMMON_OBJECT_SLOT2
&Spell::EffectSummonObject, //106 SPELL_EFFECT_SUMMON_OBJECT_SLOT3
&Spell::EffectSummonObject, //107 SPELL_EFFECT_SUMMON_OBJECT_SLOT4
&Spell::EffectDispelMechanic, //108 SPELL_EFFECT_DISPEL_MECHANIC
&Spell::EffectSummonDeadPet, //109 SPELL_EFFECT_SUMMON_DEAD_PET
&Spell::EffectDestroyAllTotems, //110 SPELL_EFFECT_DESTROY_ALL_TOTEMS
&Spell::EffectDurabilityDamage, //111 SPELL_EFFECT_DURABILITY_DAMAGE
*Mangos [7034] Add support 96 bit spell family mask to triggers. By DiSlord.
2009-01-06 13:45:49 -06:00
&Spell::EffectUnused, //112 SPELL_EFFECT_112
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectResurrectNew, //113 SPELL_EFFECT_RESURRECT_NEW
&Spell::EffectTaunt, //114 SPELL_EFFECT_ATTACK_ME
&Spell::EffectDurabilityDamagePCT, //115 SPELL_EFFECT_DURABILITY_DAMAGE_PCT
&Spell::EffectSkinPlayerCorpse, //116 SPELL_EFFECT_SKIN_PLAYER_CORPSE one spell: Remove Insignia, bg usage, required special corpse flags...
&Spell::EffectSpiritHeal, //117 SPELL_EFFECT_SPIRIT_HEAL one spell: Spirit Heal
&Spell::EffectSkill, //118 SPELL_EFFECT_SKILL professions and more
&Spell::EffectApplyAreaAura, //119 SPELL_EFFECT_APPLY_AREA_AURA_PET
&Spell::EffectUnused, //120 SPELL_EFFECT_TELEPORT_GRAVEYARD one spell: Graveyard Teleport Test
&Spell::EffectWeaponDmg, //121 SPELL_EFFECT_NORMALIZED_WEAPON_DMG
&Spell::EffectUnused, //122 SPELL_EFFECT_122 unused
&Spell::EffectSendTaxi, //123 SPELL_EFFECT_SEND_TAXI taxi/flight related (misc value is taxi path id)
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
&Spell::EffectPullTowards, //124 SPELL_EFFECT_PULL_TOWARDS
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectModifyThreatPercent, //125 SPELL_EFFECT_MODIFY_THREAT_PERCENT
&Spell::EffectStealBeneficialBuff, //126 SPELL_EFFECT_STEAL_BENEFICIAL_BUFF spell steal effect?
&Spell::EffectProspecting, //127 SPELL_EFFECT_PROSPECTING Prospecting spell
&Spell::EffectApplyAreaAura, //128 SPELL_EFFECT_APPLY_AREA_AURA_FRIEND
&Spell::EffectApplyAreaAura, //129 SPELL_EFFECT_APPLY_AREA_AURA_ENEMY
*Fix misdirection.
2008-12-17 20:07:25 -06:00
&Spell::EffectRedirectThreat, //130 SPELL_EFFECT_REDIRECT_THREAT
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
2011-03-07 21:13:18 +01:00
&Spell::EffectPlayerNotification, //131 SPELL_EFFECT_PLAYER_NOTIFICATION sound id in misc value (SoundEntries.dbc)
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
&Spell::EffectPlayMusic, //132 SPELL_EFFECT_PLAY_MUSIC sound id in misc value (SoundEntries.dbc)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectUnlearnSpecialization, //133 SPELL_EFFECT_UNLEARN_SPECIALIZATION unlearn profession specialization
&Spell::EffectKillCredit, //134 SPELL_EFFECT_KILL_CREDIT misc value is creature entry
&Spell::EffectNULL, //135 SPELL_EFFECT_CALL_PET
&Spell::EffectHealPct, //136 SPELL_EFFECT_HEAL_PCT
* Fix bug that potions and other energize effects make client display twice as much of a gain, by nos4r2zod.
2009-06-08 21:19:34 +02:00
&Spell::EffectEnergizePct, //137 SPELL_EFFECT_ENERGIZE_PCT
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
&Spell::EffectLeapBack, //138 SPELL_EFFECT_LEAP_BACK Leap back
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
&Spell::EffectQuestClear, //139 SPELL_EFFECT_CLEAR_QUEST Reset quest status (miscValue - quest ID)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectForceCast, //140 SPELL_EFFECT_FORCE_CAST
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
&Spell::EffectForceCastWithValue, //141 SPELL_EFFECT_FORCE_CAST_WITH_VALUE
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTriggerSpellWithValue, //142 SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE
&Spell::EffectApplyAreaAura, //143 SPELL_EFFECT_APPLY_AREA_AURA_OWNER
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
&Spell::EffectKnockBack, //144 SPELL_EFFECT_KNOCK_BACK_DEST
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
&Spell::EffectPullTowards, //145 SPELL_EFFECT_PULL_TOWARDS_DEST Black Hole Effect
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
&Spell::EffectActivateRune, //146 SPELL_EFFECT_ACTIVATE_RUNE
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectQuestFail, //147 SPELL_EFFECT_QUEST_FAIL quest fail
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
&Spell::EffectUnused, //148 SPELL_EFFECT_148 1 spell - 43509
*Rename SPELL_EFFECT_CHARGE_2 to SPELL_EFFECT_CHARGE_DEST, fix its implementation.
2010-07-19 19:22:05 +02:00
&Spell::EffectChargeDest, //149 SPELL_EFFECT_CHARGE_DEST
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
&Spell::EffectQuestStart, //150 SPELL_EFFECT_QUEST_START
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
&Spell::EffectTriggerRitualOfSummoning, //151 SPELL_EFFECT_TRIGGER_SPELL_2
&Spell::EffectNULL, //152 SPELL_EFFECT_152 summon Refer-a-Friend
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
&Spell::EffectCreateTamedPet, //153 SPELL_EFFECT_CREATE_TAMED_PET misc value is creature entry
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
&Spell::EffectDiscoverTaxi, //154 SPELL_EFFECT_DISCOVER_TAXI
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
&Spell::EffectTitanGrip, //155 SPELL_EFFECT_TITAN_GRIP Allows you to equip two-handed axes, maces and swords in one hand, but you attack $49152s1% slower than normal.
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
&Spell::EffectEnchantItemPrismatic, //156 SPELL_EFFECT_ENCHANT_ITEM_PRISMATIC
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
&Spell::EffectCreateItem2, //157 SPELL_EFFECT_CREATE_ITEM_2 create item or create item template and replace by some randon spell loot item
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
&Spell::EffectMilling, //158 SPELL_EFFECT_MILLING milling
*Switch to support client version 3.1.3
2009-06-11 00:45:59 -05:00
&Spell::EffectRenamePet, //159 SPELL_EFFECT_ALLOW_RENAME_PET allow rename pet once again
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
&Spell::EffectNULL, //160 SPELL_EFFECT_160 1 spell - 45534
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
&Spell::EffectSpecCount, //161 SPELL_EFFECT_TALENT_SPEC_COUNT second talent spec (learn/revert)
&Spell::EffectActivateSpec, //162 SPELL_EFFECT_TALENT_SPEC_SELECT activate primary/secondary spec
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
&Spell::EffectNULL, //163 unused
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
&Spell::EffectRemoveAura, //164 SPELL_EFFECT_REMOVE_AURA
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
};
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectNULL(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "WORLD: Spell Effect DUMMY");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectUnused(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
A great purge of obsolete macros.
2010-02-05 00:31:28 +01:00
// NOT USED BY ANY SPELL OR USELESS OR IMPLEMENTED IN DIFFERENT WAY IN TRINITY
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectResurrectNew(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->IsInWorld())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
Player* pTarget = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (pTarget->isRessurectRequested()) // already have one active request
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 health = damage;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 mana = m_spellInfo->EffectMiscValue[effIndex];
ExecuteLogEffectResurrect(effIndex, pTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pTarget->setResurrectRequestData(m_caster->GetGUID(), m_caster->GetMapId(), m_caster->GetPositionX(), m_caster->GetPositionY(), m_caster->GetPositionZ(), health, mana);
SendResurrectRequest(pTarget);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectInstaKill(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (!unitTarget || !unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Demonic Sacrifice
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
if (m_spellInfo->Id == 18788 && unitTarget->GetTypeId() == TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint32 entry = unitTarget->GetEntry();
uint32 spellID;
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
switch (entry)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 416: spellID = 18789; break; //imp
case 417: spellID = 18792; break; //fellhunter
case 1860: spellID = 18790; break; //void
case 1863: spellID = 18791; break; //succubus
case 17252: spellID = 35701; break; //fellguard
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("EffectInstaKill: Unhandled creature entry (%u) case.", entry);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, spellID, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster == unitTarget) // prevent interrupt message
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
finish();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Send SMSG_SPELLINSTAKILLLOG on SPELL_EFFECT_INSTAKILL(1), thanks to Zor for base packet info.
2010-08-28 00:30:07 +02:00
WorldPacket data(SMSG_SPELLINSTAKILLLOG, 8+8+4);
data << uint64(m_caster->GetGUID());
data << uint64(unitTarget->GetGUID());
data << uint32(m_spellInfo->Id);
m_caster->SendMessageToSet(&data, true);
m_caster->DealDamage(unitTarget, unitTarget->GetHealth(), NULL, NODAMAGE, SPELL_SCHOOL_MASK_NORMAL, NULL, false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectEnvirinmentalDMG(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint32 absorb = 0;
uint32 resist = 0;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Note: this hack with damage replace required until GO casting not implemented
// environment damage spells already have around enemies targeting but this not help in case not existed GO casting support
// currently each enemy selected explicitly and self cast damage, we prevent apply self casted spell bonuses/etc
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
damage = SpellMgr::CalculateSpellEffectAmount(m_spellInfo, effIndex, m_caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CalcAbsorbResist(m_caster, GetSpellSchoolMask(m_spellInfo), SPELL_DIRECT_DAMAGE, damage, &absorb, &resist, m_spellInfo);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->SendSpellNonMeleeDamageLog(m_caster, m_spellInfo->Id, damage, GetSpellSchoolMask(m_spellInfo), absorb, resist, false, 0, false);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->EnvironmentalDamage(DAMAGE_FIRE, damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSchoolDMG(SpellEffIndex /*effIndex*/)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::SpellDamageSchoolDmg(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
bool apply_direct_bonus = true;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (unitTarget && unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
switch (m_spellInfo->SpellFamilyName)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELLFAMILY_GENERIC:
{
[svn] Add SpellExtraInfoMap. Currently support:
2008-10-25 15:46:52 -05:00
// Meteor like spells (divided damage to targets)
Core: Rename spell attributes, use more general names
2010-12-19 05:15:47 +01:00
if (m_customAttr & SPELL_ATTR0_CU_SHARE_DAMAGE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[svn] Add SpellExtraInfoMap. Currently support:
2008-10-25 15:46:52 -05:00
uint32 count = 0;
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (std::list<TargetInfo>::iterator ihit= m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (ihit->effectMask & (1<<effIndex))
[svn] Add SpellExtraInfoMap. Currently support:
2008-10-25 15:46:52 -05:00
++count;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Add SpellExtraInfoMap. Currently support:
2008-10-25 15:46:52 -05:00
damage /= count; // divide to all targets
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Add SpellExtraInfoMap. Currently support:
2008-10-25 15:46:52 -05:00
switch(m_spellInfo->Id) // better way to check unknown
{
*Add some scripted spells for naxx.
2009-05-18 15:04:05 -05:00
// Positive/Negative Charge
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 28062:
case 28085:
case 39090:
case 39093:
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (!m_triggeredByAuraSpell)
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
break;
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (unitTarget == m_caster)
*Add some scripted spells for naxx.
2009-05-18 15:04:05 -05:00
{
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
uint8 count = 0;
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (std::list<TargetInfo>::iterator ihit = m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (ihit->targetGUID != m_caster->GetGUID())
*Thread safe player searcher in scripts.
2010-07-30 15:51:07 +02:00
if (Player *target = ObjectAccessor::GetPlayer(*m_caster, ihit->targetGUID))
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (target->HasAura(m_triggeredByAuraSpell->Id))
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
++count;
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (count)
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
{
Remove LOTS of compile warnings
2010-04-19 09:26:37 +02:00
uint32 spellId = 0;
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
switch (m_spellInfo->Id)
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
{
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 28062: spellId = 29659; break;
case 28085: spellId = 29660; break;
case 39090: spellId = 39089; break;
case 39093: spellId = 39092; break;
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
}
Update aura system:
2010-01-10 01:23:15 +01:00
m_caster->SetAuraStack(spellId, m_caster, count);
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
}
*Add some scripted spells for naxx.
2009-05-18 15:04:05 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (unitTarget->HasAura(m_triggeredByAuraSpell->Id))
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
damage = 0;
break;
// Consumption
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 28865:
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
damage = (((InstanceMap*)m_caster->GetMap())->GetDifficulty() == REGULAR_DIFFICULTY ? 2750 : 4250);
*Add some scripted spells for naxx.
2009-05-18 15:04:05 -05:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// percent from health with min
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 25599: // Thundercrash
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
damage = unitTarget->GetHealth() / 2;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage < 200)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
damage = 200;
break;
}
*Fix arcane charge.
2008-11-24 15:15:09 -06:00
// arcane charge. must only affect demons (also undead?)
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 45072:
[svn] Fix spell 45072: should only affect demons.
2008-10-19 14:47:43 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetCreatureType() != CREATURE_TYPE_DEMON
*Fix arcane charge.
2008-11-24 15:15:09 -06:00
&& unitTarget->GetCreatureType() != CREATURE_TYPE_UNDEAD)
[svn] Fix spell 45072: should only affect demons.
2008-10-19 14:47:43 -05:00
return;
break;
}
Fix spells 50811 & 61547 (Krystallus shatter), by microbius51
2010-06-19 23:51:33 +02:00
case 33671: // gruul's shatter
Minor cleansing
2010-06-20 01:34:11 +02:00
case 50811: // krystallus shatter ( Normal )
case 61547: // krystallus shatter ( Heroic )
*Alterac Valley. By Bogie and Balrok. Note: some core contents are modified. Will fix them later. Some sql are disabled because of possible conflict with offical DB. Use them at your own risk.
2008-11-21 19:45:49 -06:00
{
// don't damage self and only players
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetGUID() == m_caster->GetGUID() || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Alterac Valley. By Bogie and Balrok. Note: some core contents are modified. Will fix them later. Some sql are disabled because of possible conflict with offical DB. Use them at your own risk.
2008-11-21 19:45:49 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make range check dependent from target.
2009-02-14 15:56:04 +01:00
float radius = GetSpellRadiusForHostile(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[0]));
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (!radius) return;
*Alterac Valley. By Bogie and Balrok. Note: some core contents are modified. Will fix them later. Some sql are disabled because of possible conflict with offical DB. Use them at your own risk.
2008-11-21 19:45:49 -06:00
float distance = m_caster->GetDistance2d(unitTarget);
Correct usage of basePoints in various locations
2010-08-25 03:21:22 +03:00
damage = (distance > radius) ? 0 : int32(SpellMgr::CalculateSpellEffectAmount(m_spellInfo, 0) * ((radius - distance)/radius));
[7739] Implement boss spell 38441. Author: NoFantasy
2009-04-30 19:35:37 -05:00
break;
}
*Shadow Mark target requirement - by PrinceCreed
2010-02-24 21:38:51 +01:00
// TODO: add spell specific target requirement hook for spells
// Shadowbolts only affects targets with Shadow Mark (Gothik)
case 27831:
case 55638:
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->HasAura(27825))
*Shadow Mark target requirement - by PrinceCreed
2010-02-24 21:38:51 +01:00
return;
break;
[7739] Implement boss spell 38441. Author: NoFantasy
2009-04-30 19:35:37 -05:00
// Cataclysmic Bolt
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 38441:
*Blackfathom Deeps - Event: Aku'mai, by Tartalo
2009-10-09 20:48:55 -07:00
{
Core:
2010-08-26 01:20:57 +06:00
damage = unitTarget->CountPctFromMaxHealth(50);
[7739] Implement boss spell 38441. Author: NoFantasy
2009-04-30 19:35:37 -05:00
break;
*Blackfathom Deeps - Event: Aku'mai, by Tartalo
2009-10-09 20:48:55 -07:00
}
// Tympanic Tantrum
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 62775:
*Blackfathom Deeps - Event: Aku'mai, by Tartalo
2009-10-09 20:48:55 -07:00
{
Core:
2010-08-26 01:20:57 +06:00
damage = unitTarget->CountPctFromMaxHealth(10);
*Blackfathom Deeps - Event: Aku'mai, by Tartalo
2009-10-09 20:48:55 -07:00
break;
}
* Begin replacing SpellId's with their new variable names.
2009-12-25 13:10:54 -06:00
// Gargoyle Strike
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 51963:
Support for spell 67729.
2009-12-26 14:46:19 -03:00
{
Corrected gargoyle damage calculation
2009-12-17 09:10:04 +01:00
// about +4 base spell dmg per level
damage = (m_caster->getLevel() - 60) * 4 + 60;
break;
}
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
Fix spells 52942 & 58837 (Loken Pulsing Shockwave: dinstance depending damage, by Josh
2010-06-20 01:37:58 +02:00
// Loken Pulsing Shockwave
case 59837:
case 52942:
{
// don't damage self and only players
if(unitTarget->GetGUID() == m_caster->GetGUID() || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
Fix spells 52942 & 58837 (Loken Pulsing Shockwave: dinstance depending damage, by Josh
2010-06-20 01:37:58 +02:00
float radius = GetSpellRadiusForHostile(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[0]));
if (!radius)
return;
float distance = m_caster->GetDistance2d(unitTarget);
Correct usage of basePoints in various locations
2010-08-25 03:21:22 +03:00
damage = (distance > radius) ? 0 : int32(SpellMgr::CalculateSpellEffectAmount(m_spellInfo, 0) * distance);
Fix spells 52942 & 58837 (Loken Pulsing Shockwave: dinstance depending damage, by Josh
2010-06-20 01:37:58 +02:00
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
case SPELLFAMILY_WARRIOR:
{
// Bloodthirst
Fix talent Shockwave and typo in comment.
2010-02-15 19:09:17 +01:00
if (m_spellInfo->SpellFamilyFlags[1] & 0x400)
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
ApplyPctF(damage, m_caster->GetTotalAttackPowerValue(BASE_ATTACK));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Shield Slam
Fix talent Shockwave and typo in comment.
2010-02-15 19:09:17 +01:00
else if (m_spellInfo->SpellFamilyFlags[1] & 0x200 && m_spellInfo->Category == 1209)
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
damage += int32(m_caster->ApplyEffectModifiers(m_spellInfo, effIndex, float(m_caster->GetShieldBlockValue())));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Victory Rush
Fix talent Shockwave and typo in comment.
2010-02-15 19:09:17 +01:00
else if (m_spellInfo->SpellFamilyFlags[1] & 0x100)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
ApplyPctF(damage, m_caster->GetTotalAttackPowerValue(BASE_ATTACK));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->ModifyAuraState(AURA_STATE_WARRIOR_VICTORY_RUSH, false);
}
Fix talent Shockwave and typo in comment.
2010-02-15 19:09:17 +01:00
// Shockwave
else if (m_spellInfo->Id == 46968)
*Move shockwave bonus ap damage to SpellDamageSchoolDmg from dummy effect, because the effect has incorrect target data.
2009-05-06 18:33:19 +02:00
{
Final fix basepoints calculation, thx to Vladimir, Laise.
2010-04-11 11:43:23 +04:00
int32 pct = m_caster->CalculateSpellDamage(unitTarget, m_spellInfo, 2);
*Move shockwave bonus ap damage to SpellDamageSchoolDmg from dummy effect, because the effect has incorrect target data.
2009-05-06 18:33:19 +02:00
if (pct > 0)
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
damage += int32(CalculatePctN(m_caster->GetTotalAttackPowerValue(BASE_ATTACK), pct));
*Move shockwave bonus ap damage to SpellDamageSchoolDmg from dummy effect, because the effect has incorrect target data.
2009-05-06 18:33:19 +02:00
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
case SPELLFAMILY_WARLOCK:
{
// Incinerate Rank 1 & 2
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
if ((m_spellInfo->SpellFamilyFlags[1] & 0x000040) && m_spellInfo->SpellIconID == 2128)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Do not let Incinerate has extra damage for Shadowflame Author: rechapa79
2009-07-24 09:59:33 +08:00
// Incinerate does more dmg (dmg*0.25) if the target have Immolate debuff.
// Check aura state for speed but aura state set not only for Immolate spell
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->HasAuraState(AURA_STATE_CONFLAGRATE))
*Do not let Incinerate has extra damage for Shadowflame Author: rechapa79
2009-07-24 09:59:33 +08:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
if (unitTarget->GetAuraEffect(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_WARLOCK, 0x4, 0, 0))
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
damage += damage/4;
*Do not let Incinerate has extra damage for Shadowflame Author: rechapa79
2009-07-24 09:59:33 +08:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Do not let Incinerate has extra damage for Shadowflame Author: rechapa79
2009-07-24 09:59:33 +08:00
// Conflagrate - consumes Immolate or Shadowflame
else if (m_spellInfo->TargetAuraState == AURA_STATE_CONFLAGRATE)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
AuraEffect const* aura = NULL; // found req. aura for damage calculation
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraEffectList const &mPeriodic = unitTarget->GetAuraEffectsByType(SPELL_AURA_PERIODIC_DAMAGE);
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (Unit::AuraEffectList::const_iterator i = mPeriodic.begin(); i != mPeriodic.end(); ++i)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
// for caster applied auras only
if ((*i)->GetSpellProto()->SpellFamilyName != SPELLFAMILY_WARLOCK ||
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
(*i)->GetCasterGUID() != m_caster->GetGUID())
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
continue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
// Immolate
if ((*i)->GetSpellProto()->SpellFamilyFlags[0] & 0x4)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
aura = *i; // it selected always if exist
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
// Shadowflame
if ((*i)->GetSpellProto()->SpellFamilyFlags[2] & 0x00000002)
aura = *i; // remember but wait possible Immolate as primary priority
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
// found Immolate or Shadowflame
if (aura)
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
uint32 pdamage = uint32(std::max(aura->GetAmount(), 0));
Update aura system:
2010-01-10 01:23:15 +01:00
pdamage = m_caster->SpellDamageBonus(unitTarget, aura->GetSpellProto(), pdamage, DOT, aura->GetBase()->GetStackAmount());
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 pct_dir = m_caster->CalculateSpellDamage(unitTarget, m_spellInfo, (effIndex + 1));
Conflagrate direct & DoT damage shouldn't scale with duration increases of Immolate/Shadowflame, fixes issue 3376.
2010-09-02 06:02:51 +03:00
uint8 baseTotalTicks = uint8(m_caster->CalcSpellDuration(aura->GetSpellProto()) / aura->GetSpellProto()->EffectAmplitude[0]);
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
damage += int32(CalculatePctU(pdamage * baseTotalTicks, pct_dir));
*Fixes conflagrate DOT damage so that warlocks finally can be the pyromaniacs they want to be
2010-04-23 21:24:32 +02:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 pct_dot = m_caster->CalculateSpellDamage(unitTarget, m_spellInfo, (effIndex + 2)) / 3;
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
m_spellValue->EffectBasePoints[1] = SpellMgr::CalculateSpellEffectBaseAmount(int32(CalculatePctU(pdamage * baseTotalTicks, pct_dot)), m_spellInfo, 1);
*Fixes conflagrate DOT damage so that warlocks finally can be the pyromaniacs they want to be
2010-04-23 21:24:32 +02:00
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
apply_direct_bonus = false;
// Glyph of Conflagrate
if (!m_caster->HasAura(56235))
unitTarget->RemoveAurasDueToSpell(aura->GetId(), m_caster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8217] Implement proper priority in effect selection at talent 17962 cast. Author: VladimirMangos
2009-07-24 10:06:11 +08:00
break;
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
}
}
*Fix shadow bite bonus per dot on target.
2009-06-12 13:01:42 +02:00
// Shadow Bite
else if (m_spellInfo->SpellFamilyFlags[1] & 0x400000)
{
Convert some C style casts to new functions
2010-03-11 20:51:31 +01:00
if (m_caster->GetTypeId() == TYPEID_UNIT && m_caster->ToCreature()->isPet())
Core/Spells: Fix Improved Felhunter mana energize part.
2010-12-20 00:35:11 +01:00
{
if (Player* owner = m_caster->GetOwner()->ToPlayer())
{
if (AuraEffect* aurEff = owner->GetAuraEffect(SPELL_AURA_ADD_FLAT_MODIFIER, SPELLFAMILY_WARLOCK, 214, 0))
{
int32 bp0 = aurEff->GetId() == 54037 ? 4 : 8;
m_caster->CastCustomSpell(m_caster, 54425, &bp0, NULL, NULL, true);
}
}
}
*Fix shadow bite bonus per dot on target.
2009-06-12 13:01:42 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
*Update to Mangos 6982.
2008-12-29 17:27:50 -06:00
case SPELLFAMILY_PRIEST:
{
// Shadow Word: Death - deals damage equal to damage done to caster
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if ((m_spellInfo->SpellFamilyFlags[1] & 0x2))
Fix Shadow Word: Death (Backfire Damage). Original Author: Nevan.
2009-10-17 18:16:28 +02:00
{
fix Pain and Suffering (reduces the damage you take from your own Shadow Word: Death)
2010-01-04 15:53:19 +02:00
int32 back_damage = m_caster->SpellDamageBonus(unitTarget, m_spellInfo, (uint32)damage, SPELL_DIRECT_DAMAGE);
// Pain and Suffering reduces damage
Update aura system:
2010-01-10 01:23:15 +01:00
if (AuraEffect * aurEff = m_caster->GetDummyAuraEffect(SPELLFAMILY_PRIEST, 2874, 0))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(back_damage, -aurEff->GetAmount());
fix Pain and Suffering (reduces the damage you take from your own Shadow Word: Death)
2010-01-04 15:53:19 +02:00
Core/Cleanup:
2010-08-26 15:54:56 +06:00
if (back_damage < int32(unitTarget->GetHealth()))
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
m_caster->CastCustomSpell(m_caster, 32409, &back_damage, 0, 0, true);
Fix Shadow Word: Death (Backfire Damage). Original Author: Nevan.
2009-10-17 18:16:28 +02:00
}
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
// Improved Mind Blast (Mind Blast in shadow form bonus)
Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
2010-12-09 17:03:42 +06:00
else if (m_caster->GetShapeshiftForm() == FORM_SHADOW && (m_spellInfo->SpellFamilyFlags[0] & 0x00002000))
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraEffectList const& ImprMindBlast = m_caster->GetAuraEffectsByType(SPELL_AURA_ADD_FLAT_MODIFIER);
Code style (game + scripts only):
2010-04-07 19:12:44 +02:00
for (Unit::AuraEffectList::const_iterator i = ImprMindBlast.begin(); i != ImprMindBlast.end(); ++i)
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
{
if ((*i)->GetSpellProto()->SpellFamilyName == SPELLFAMILY_PRIEST &&
((*i)->GetSpellProto()->SpellIconID == 95))
{
*Add SpellMgr::CalculateSpellEffectAmount function for consistency of effect amount calculations in core
2010-07-14 16:57:13 +02:00
int chance = SpellMgr::CalculateSpellEffectAmount((*i)->GetSpellProto(), 1, m_caster);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
if (roll_chance_i(chance))
// Mind Trauma
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
m_caster->CastSpell(unitTarget, 48301, true, 0);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
break;
}
}
}
*Update to Mangos 6982.
2008-12-29 17:27:50 -06:00
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case SPELLFAMILY_DRUID:
{
// Ferocious Bite
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER && (m_spellInfo->SpellFamilyFlags[0] & 0x000800000) && m_spellInfo->SpellVisual[0] == 6587)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
// converts each extra point of energy into ($f1+$AP/410) additional damage
float ap = m_caster->GetTotalAttackPowerValue(BASE_ATTACK);
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float multiple = ap / 410 + m_spellInfo->EffectDamageMultiplier[effIndex];
*Fix Ferocious Bite energy to dmg conversion
2009-06-24 15:58:44 +02:00
int32 energy = -(m_caster->ModifyPower(POWER_ENERGY, -30));
damage += int32(energy * multiple);
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
damage += int32(CalculatePctN(m_caster->ToPlayer()->GetComboPoints() * ap, 7));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Fix Improved Insect Swarm - original patch by Zor
2009-08-28 14:03:18 +02:00
// Wrath
else if (m_spellInfo->SpellFamilyFlags[0] & 0x00000001)
{
// Improved Insect Swarm
Update aura system:
2010-01-10 01:23:15 +01:00
if (AuraEffect const * aurEff = m_caster->GetDummyAuraEffect(SPELLFAMILY_DRUID, 1771, 0))
if (unitTarget->GetAuraEffect(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_DRUID, 0x00200000, 0, 0))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(damage, aurEff->GetAmount());
*Fix Improved Insect Swarm - original patch by Zor
2009-08-28 14:03:18 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
case SPELLFAMILY_ROGUE:
{
// Envenom
*Cleanup
2009-10-18 18:38:46 -07:00
if (m_caster->GetTypeId() == TYPEID_PLAYER && (m_spellInfo->SpellFamilyFlags[1] & 0x8))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// consume from stack dozes not more that have combo-points
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (uint32 combo = m_caster->ToPlayer()->GetComboPoints())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 7059.
2009-01-09 16:06:17 -06:00
// Lookup for Deadly poison (only attacker applied)
Update aura system:
2010-01-10 01:23:15 +01:00
if (AuraEffect const * aurEff = unitTarget->GetAuraEffect(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_ROGUE, 0x10000, 0, 0, m_caster->GetGUID()))
*Update to Mangos 7059.
2009-01-09 16:06:17 -06:00
{
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
// count consumed deadly poison doses at target
*Implement Master Poisoner - chance to not consume Deadly Poison, thanks Sisif
2009-10-31 17:09:38 -07:00
bool needConsume = true;
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
uint32 spellId = aurEff->GetId();
Update aura system:
2010-01-10 01:23:15 +01:00
uint32 doses = aurEff->GetBase()->GetStackAmount();
*Update to Mangos 7059.
2009-01-09 16:06:17 -06:00
if (doses > combo)
doses = combo;
*Implement Master Poisoner - chance to not consume Deadly Poison, thanks Sisif
2009-10-31 17:09:38 -07:00
// Master Poisoner
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
Unit::AuraEffectList const& auraList = m_caster->ToPlayer()->GetAuraEffectsByType(SPELL_AURA_MOD_AURA_DURATION_BY_DISPEL_NOT_STACK);
*Implement Master Poisoner - chance to not consume Deadly Poison, thanks Sisif
2009-10-31 17:09:38 -07:00
for (Unit::AuraEffectList::const_iterator iter = auraList.begin(); iter != auraList.end(); ++iter)
{
if ((*iter)->GetSpellProto()->SpellFamilyName == SPELLFAMILY_ROGUE && (*iter)->GetSpellProto()->SpellIconID == 1960)
{
*Add SpellMgr::CalculateSpellEffectAmount function for consistency of effect amount calculations in core
2010-07-14 16:57:13 +02:00
uint32 chance = SpellMgr::CalculateSpellEffectAmount((*iter)->GetSpellProto(), 2, m_caster);
*Implement Master Poisoner - chance to not consume Deadly Poison, thanks Sisif
2009-10-31 17:09:38 -07:00
if (chance && roll_chance_i(chance))
needConsume = false;
break;
}
}
if (needConsume)
for (uint32 i = 0; i < doses; ++i)
unitTarget->RemoveAuraFromStack(spellId);
*Update to Mangos 7059.
2009-01-09 16:06:17 -06:00
damage *= doses;
Fix Envenom Damage Formula. Closes #655.
2009-12-19 20:00:01 -06:00
damage += int32(((Player*)m_caster)->GetTotalAttackPowerValue(BASE_ATTACK) * 0.09f * doses);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
// Eviscerate and Envenom Bonus Damage (item set effect)
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
if (m_caster->HasAura(37169))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
damage += ((Player*)m_caster)->GetComboPoints()*40;
}
}
// Eviscerate
*Cleanup
2009-10-18 18:38:46 -07:00
else if ((m_spellInfo->SpellFamilyFlags[0] & 0x00020000) && m_caster->GetTypeId() == TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (uint32 combo = ((Player*)m_caster)->GetComboPoints())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
float ap = m_caster->GetTotalAttackPowerValue(BASE_ATTACK);
damage += irand(int32(ap * combo * 0.03f), int32(ap * combo * 0.07f));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Eviscerate and Envenom Bonus Damage (item set effect)
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
if (m_caster->HasAura(37169))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
damage += combo*40;
}
}
break;
}
case SPELLFAMILY_HUNTER:
{
[8283] Implement 3.x way work for double damage from 35290 and ranks Author: VladimirMangos
2009-08-02 10:10:13 +08:00
//Gore
if (m_spellInfo->SpellIconID == 1578)
{
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
if (m_caster->HasAura(57627)) // Charge 6 sec post-affect
[8283] Implement 3.x way work for double damage from 35290 and ranks Author: VladimirMangos
2009-08-02 10:10:13 +08:00
damage *= 2;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Steady Shot
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
else if (m_spellInfo->SpellFamilyFlags[1] & 0x1)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
bool found = false;
// check dazed affect
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraEffectList const& decSpeedList = unitTarget->GetAuraEffectsByType(SPELL_AURA_MOD_DECREASE_SPEED);
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
for (Unit::AuraEffectList::const_iterator iter = decSpeedList.begin(); iter != decSpeedList.end(); ++iter)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if ((*iter)->GetSpellProto()->SpellIconID == 15 && (*iter)->GetSpellProto()->Dispel == 0)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
found = true;
break;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix the bug that Steady Shot make too much(over million) damage with these items: 42946, 44093.
2009-08-26 17:56:35 +02:00
// TODO: should this be put on taken but not done?
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (found)
Correct usage of basePoints in various locations
2010-08-25 03:21:22 +03:00
damage += SpellMgr::CalculateSpellEffectAmount(m_spellInfo, 1);
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
*Fix crash in mob_anti_airAI. Remove assert and cast no spell instead, if no spell was found in DB template.
2009-08-21 17:15:35 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
{
* Last commit also fixes damage calculation of Steady Shot, based on original patch by thenecromancer.
2009-08-21 17:23:09 +02:00
// Add Ammo and Weapon damage plus RAP * 0.1
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
Item *item = m_caster->ToPlayer()->GetWeaponForAttack(RANGED_ATTACK);
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (item)
*Fix crash in mob_anti_airAI. Remove assert and cast no spell instead, if no spell was found in DB template.
2009-08-21 17:15:35 +02:00
{
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
float dmg_min = item->GetTemplate()->Damage->DamageMin;
float dmg_max = item->GetTemplate()->Damage->DamageMax;
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (dmg_max == 0.0f && dmg_min > dmg_max)
*Correct damage for Steady Shot, thanks lobuz
2009-11-17 16:59:58 -08:00
damage += int32(dmg_min);
*Fix the bug that Steady Shot make too much(over million) damage with these items: 42946, 44093.
2009-08-26 17:56:35 +02:00
else
*Correct damage for Steady Shot, thanks lobuz
2009-11-17 16:59:58 -08:00
damage += irand(int32(dmg_min), int32(dmg_max));
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
damage += int32(m_caster->ToPlayer()->GetAmmoDPS()*item->GetTemplate()->Delay*0.001f);
*Fix crash in mob_anti_airAI. Remove assert and cast no spell instead, if no spell was found in DB template.
2009-08-21 17:15:35 +02:00
}
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
case SPELLFAMILY_PALADIN:
{
[7209] Fix damage for paladin 53595
2009-02-01 16:21:40 -06:00
// Hammer of the Righteous
Fixed some typos
2009-12-25 16:01:19 +01:00
if (m_spellInfo->SpellFamilyFlags[1]&0x00040000)
[7209] Fix damage for paladin 53595
2009-02-01 16:21:40 -06:00
{
// Add main hand dps * effect[2] amount
[7825] Fixed typo in comment and var. name. Author: BombermaG
2009-05-14 15:38:20 -05:00
float average = (m_caster->GetFloatValue(UNIT_FIELD_MINDAMAGE) + m_caster->GetFloatValue(UNIT_FIELD_MAXDAMAGE)) / 2;
Core/Spells: Fix Shield of Righteousness damage
2010-11-09 11:15:00 +01:00
int32 count = m_caster->CalculateSpellDamage(unitTarget, m_spellInfo, EFFECT_2);
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
damage += count * int32(average * IN_MILLISECONDS) / m_caster->GetAttackTime(BASE_ATTACK);
Core/Spells: Fix Shield of Righteousness damage
2010-11-09 11:15:00 +01:00
break;
[7209] Fix damage for paladin 53595
2009-02-01 16:21:40 -06:00
}
[7434] Fix one paladin spell bonus Author: rechapa79
2009-03-09 18:15:27 -06:00
// Shield of Righteousness
Core/Spells: Fix Shield of Righteousness damage
2010-11-09 11:15:00 +01:00
if (m_spellInfo->SpellFamilyFlags[EFFECT_1] & 0x100000)
[7434] Fix one paladin spell bonus Author: rechapa79
2009-03-09 18:15:27 -06:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
damage += CalculatePctN(m_caster->GetShieldBlockValue(), SpellMgr::CalculateSpellEffectAmount(m_spellInfo, EFFECT_1));
Core/Spells: Fix Shield of Righteousness damage
2010-11-09 11:15:00 +01:00
break;
[7434] Fix one paladin spell bonus Author: rechapa79
2009-03-09 18:15:27 -06:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
*Fix Improved Moonkin Form and Blood Boil disease bonus.
2009-07-06 00:51:50 +02:00
case SPELLFAMILY_DEATHKNIGHT:
{
// Blood Boil - bonus for diseased targets
Core/Spells: Fix runic power gain from Blood Boil
2011-05-28 03:12:41 +07:00
if (m_spellInfo->SpellFamilyFlags[0] & 0x00040000)
*Fix Improved Moonkin Form and Blood Boil disease bonus.
2009-07-06 00:51:50 +02:00
{
Core/Spells: Fix runic power gain from Blood Boil
2011-05-28 03:12:41 +07:00
if (unitTarget->GetAuraEffect(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_DEATHKNIGHT, 0, 0, 0x00000002, m_caster->GetGUID()))
{
damage += m_damage / 2;
damage += int32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.035f);
}
*Fix Improved Moonkin Form and Blood Boil disease bonus.
2009-07-06 00:51:50 +02:00
}
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_originalCaster && damage > 0 && apply_direct_bonus)
*Fix the bug that some spells have too high damage.
2009-01-10 09:29:22 -06:00
damage = m_originalCaster->SpellDamageBonus(unitTarget, m_spellInfo, (uint32)damage, SPELL_DIRECT_DAMAGE);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix the bug that some spells have too high damage.
2009-01-10 09:29:22 -06:00
m_damage += damage;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDummy(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (!unitTarget && !gameObjTarget && !itemTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix the bug that charge spells do not apply stun auras.
2009-01-31 11:09:37 -06:00
uint32 spell_id = 0;
int32 bp = 0;
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
bool triggered = true;
SpellCastTargets targets;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// selection by spell family
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
switch (m_spellInfo->SpellFamilyName)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELLFAMILY_GENERIC:
*Update to Mangos 6856. Source: Mangos.
2008-11-28 11:38:28 -06:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
switch (m_spellInfo->Id)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 31225: // Shimmering Vessel (restore creature to life)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
unitTarget->ToCreature()->setDeathState(JUST_ALIVED);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 12162: // Deep wounds
case 12850: // (now good common check for this spells)
case 12868:
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
float damage;
// DW should benefit of attack power, damage percent mods etc.
// TODO: check if using offhand damage is correct and if it should be divided by 2
if (m_caster->haveOffhandWeapon() && m_caster->getAttackTimer(BASE_ATTACK) > m_caster->getAttackTimer(OFF_ATTACK))
damage = (m_caster->GetFloatValue(UNIT_FIELD_MINOFFHANDDAMAGE) + m_caster->GetFloatValue(UNIT_FIELD_MAXOFFHANDDAMAGE))/2;
else
damage = (m_caster->GetFloatValue(UNIT_FIELD_MINDAMAGE) + m_caster->GetFloatValue(UNIT_FIELD_MAXDAMAGE))/2;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
switch (m_spellInfo->Id)
{
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
case 12162: damage *= 0.16f; break; // Rank 1
case 12850: damage *= 0.32f; break; // Rank 2
case 12868: damage *= 0.48f; break; // Rank 3
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("Spell::EffectDummy: Spell %u not handled in DW", m_spellInfo->Id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
};
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8061] Fixed 12834 and ranks stacking behaviour. Author: hunuza
2009-06-23 14:18:20 +02:00
// get remaining damage of old Deep Wound aura
Core/Spells: Fix Deep Wounds when more than one application applied
2011-05-19 00:25:53 +07:00
AuraEffect* deepWound = unitTarget->GetAuraEffect(12721, 0, m_caster->GetGUID());
*Cleanup, fix a lot of potential crashes and typos.
2009-10-15 11:50:11 -07:00
if (deepWound)
[8061] Fixed 12834 and ranks stacking behaviour. Author: hunuza
2009-06-23 14:18:20 +02:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
int32 remainingTicks = deepWound->GetBase()->GetDuration() / deepWound->GetAmplitude();
[8061] Fixed 12834 and ranks stacking behaviour. Author: hunuza
2009-06-23 14:18:20 +02:00
damage += remainingTicks * deepWound->GetAmount();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8061] Fixed 12834 and ranks stacking behaviour. Author: hunuza
2009-06-23 14:18:20 +02:00
// 1 tick/sec * 6 sec = 6 ticks
int32 deepWoundsDotBasePoints0 = int32(damage / 6);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastCustomSpell(unitTarget, 12721, &deepWoundsDotBasePoints0, NULL, NULL, true, NULL);
return;
}
Backed out changeset: bcf447b68a92
2009-12-27 17:49:52 -06:00
case 13567: // Dummy Trigger
{
// can be used for different aura triggering, so select by aura
if (!m_triggeredByAuraSpell || !unitTarget)
return;
switch (m_triggeredByAuraSpell->Id)
{
case 26467: // Persistent Shield
m_caster->CastCustomSpell(unitTarget, 26470, &damage, NULL, NULL, true);
break;
default:
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("EffectDummy: Non-handled case for spell 13567 for triggered aura %u", m_triggeredByAuraSpell->Id);
Backed out changeset: bcf447b68a92
2009-12-27 17:49:52 -06:00
break;
}
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case 17251: // Spirit Healer Res
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || !m_originalCaster)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_originalCaster->GetTypeId() == TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
WorldPacket data(SMSG_SPIRIT_HEALER_CONFIRM, 8);
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
data << uint64(unitTarget->GetGUID());
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
m_originalCaster->ToPlayer()->GetSession()->SendPacket(&data);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
return;
}
case 20577: // Cannibalize
if (unitTarget)
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 20578, false, NULL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
case 23019: // Crystal Prison Dummy DND
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || !unitTarget->isAlive() || unitTarget->GetTypeId() != TYPEID_UNIT || unitTarget->ToCreature()->isPet())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
Creature* creatureTarget = unitTarget->ToCreature();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Game: Fix remaining warnings on windows (and most likely almost all of the ones on *nix)
2010-09-03 21:55:57 -07:00
m_caster->SummonGameObject(179644, creatureTarget->GetPositionX(), creatureTarget->GetPositionY(), creatureTarget->GetPositionZ(), creatureTarget->GetOrientation(), 0, 0, 0, 0, uint32(creatureTarget->GetRespawnTime()-time(NULL)));
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "SummonGameObject at SpellEfects.cpp EffectDummy for Spell 23019");
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon
2011-01-02 21:33:37 +01:00
creatureTarget->DespawnOrUnsummon();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
case 23448: // Transporter Arrival - Ultrasafe Transporter: Gadgetzan - backfires
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
int32 r = irand(0, 119);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (r < 20) // Transporter Malfunction - 1/6 polymorph
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 23444, true);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
else if (r < 100) // Evil Twin - 4/6 evil twin
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 23445, true);
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
else // Transporter Malfunction - 1/6 miss the target
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36902, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
case 23453: // Gnomish Transporter - Ultrasafe Transporter: Gadgetzan
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (roll_chance_i(50)) // Gadgetzan Transporter - success
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 23441, true);
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
else // Gadgetzan Transporter Failure - failure
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 23446, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
case 25860: // Reindeer Transformation
{
if (!m_caster->HasAuraType(SPELL_AURA_MOUNTED))
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 6902. Source: Mangos.
2008-12-12 11:21:28 -06:00
float flyspeed = m_caster->GetSpeedRate(MOVE_FLIGHT);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
float speed = m_caster->GetSpeedRate(MOVE_RUN);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update of aura system.
2009-04-06 13:31:14 +02:00
m_caster->RemoveAurasByType(SPELL_AURA_MOUNTED);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//5 different spells used depending on mounted speed and if mount can fly or not
if (flyspeed >= 4.1f)
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
// Flying Reindeer
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 44827, true); //310% flying Reindeer
else if (flyspeed >= 3.8f)
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
// Flying Reindeer
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 44825, true); //280% flying Reindeer
else if (flyspeed >= 1.6f)
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
// Flying Reindeer
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 44824, true); //60% flying Reindeer
else if (speed >= 2.0f)
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
// Reindeer
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 25859, true); //100% ground Reindeer
else
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
// Reindeer
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 25858, true); //60% ground Reindeer
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
case 26074: // Holiday Cheer
// implemented at client side
return;
*Add some scripted spells for naxx.
2009-05-18 15:04:05 -05:00
// Polarity Shift
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
case 28089:
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
unitTarget->CastSpell(unitTarget, roll_chance_i(50) ? 28059 : 28084, true, NULL, NULL, m_caster->GetGUID());
break;
// Polarity Shift
case 39096:
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
*Update Naxx scripts. Now only Kelthuzad is incompleted
2009-05-20 11:44:38 -05:00
unitTarget->CastSpell(unitTarget, roll_chance_i(50) ? 39088 : 39091, true, NULL, NULL, m_caster->GetGUID());
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case 29200: // Purify Helboar Meat
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
uint32 spell_id = roll_chance_i(50)
? 29277 // Summon Purified Helboar Meat
: 29278; // Summon Toxic Helboar Meat
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->CastSpell(m_caster, spell_id, true, NULL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
case 29858: // Soulshatter
*Do not let soulshatter aggro not-aggroed creatures.
2008-12-02 20:53:06 -06:00
if (unitTarget && unitTarget->CanHaveThreatList()
&& unitTarget->getThreatManager().getThreat(m_caster) > 0.0f)
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->CastSpell(unitTarget, 32835, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
case 30458: // Nigh Invulnerability
if (!m_CastItem) return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (roll_chance_i(86)) // Nigh-Invulnerability - success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 30456, true, m_CastItem);
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
else // Complete Vulnerability - backfire in 14% casts
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 30457, true, m_CastItem);
return;
case 30507: // Poultryizer
if (!m_CastItem) return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (roll_chance_i(80)) // Poultryized! - success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(unitTarget, 30501, true, m_CastItem);
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
else // Poultryized! - backfire 20%
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(unitTarget, 30504, true, m_CastItem);
return;
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
case 35745: // Socrethar's Stone
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint32 spell_id;
switch(m_caster->GetAreaId())
{
[8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. Author: VladimirMangos
2009-07-16 10:54:43 +08:00
case 3900: spell_id = 35743; break; // Socrethar Portal
case 3742: spell_id = 35744; break; // Socrethar Portal
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default: return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, spell_id, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
case 37674: // Chaos Blast
*Update to Mangos 6880. Source: Mangos.
2008-12-06 14:01:44 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
*Update to Mangos 6880. Source: Mangos.
2008-12-06 14:01:44 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 6880. Source: Mangos.
2008-12-06 14:01:44 -06:00
int32 basepoints0 = 100;
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastCustomSpell(unitTarget, 37675, &basepoints0, NULL, NULL, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Update to Mangos 6880. Source: Mangos.
2008-12-06 14:01:44 -06:00
}
*Remove hack for Divine Storm from Unit::DealDamage
2010-07-16 14:42:24 +02:00
// Wrath of the Astromancer
case 42784:
{
uint32 count = 0;
for (std::list<TargetInfo>::iterator ihit= m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (ihit->effectMask & (1<<effIndex))
*Remove hack for Divine Storm from Unit::DealDamage
2010-07-16 14:42:24 +02:00
++count;
damage = 12000; // maybe wrong value
damage /= count;
SpellEntry const *spellInfo = sSpellStore.LookupEntry(42784);
// now deal the damage
for (std::list<TargetInfo>::iterator ihit= m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (ihit->effectMask & (1<<effIndex))
*Remove hack for Divine Storm from Unit::DealDamage
2010-07-16 14:42:24 +02:00
{
if (Unit* casttarget = Unit::GetUnit((*unitTarget), ihit->targetGUID))
m_caster->DealDamage(casttarget, damage, NULL, SPELL_DIRECT_DAMAGE, SPELL_SCHOOL_MASK_ARCANE, spellInfo, false);
}
return;
}
*Update to Mangos 6856. Source: Mangos.
2008-11-28 11:38:28 -06:00
// Demon Broiled Surprise
case 43723:
{
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix for spell used by cooking pot for quest Super Hot Stew(43723) - by simon.
2009-08-17 12:52:11 +02:00
Player *player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix for spell used by cooking pot for quest Super Hot Stew(43723) - by simon.
2009-08-17 12:52:11 +02:00
if (player && player->GetQuestStatus(11379) == QUEST_STATUS_INCOMPLETE)
{
Creature *creature = player->FindNearestCreature(19973, 10, false);
if (!creature)
{
SendCastResult(SPELL_FAILED_NOT_HERE);
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix for spell used by cooking pot for quest Super Hot Stew(43723) - by simon.
2009-08-17 12:52:11 +02:00
player->CastSpell(player, 43753, false);
}
*Update to Mangos 6856. Source: Mangos.
2008-11-28 11:38:28 -06:00
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case 44875: // Complete Raptor Capture
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon
2011-01-02 21:33:37 +01:00
unitTarget->ToCreature()->DespawnOrUnsummon();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//cast spell Raptor Capture Credit
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 42337, true, NULL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
Add support for quest 11626 (The Emissary) - patch by antihrists (thanks)
2010-05-01 08:30:46 +02:00
case 47170: // Impale Leviroth
{
Core:
2010-08-26 01:20:57 +06:00
if (!unitTarget && unitTarget->GetEntry() != 26452 && unitTarget->HealthAbovePct(95))
return;
Add support for quest 11626 (The Emissary) - patch by antihrists (thanks)
2010-05-01 08:30:46 +02:00
*Send SMSG_SPELLINSTAKILLLOG on SPELL_EFFECT_INSTAKILL(1), thanks to Zor for base packet info.
2010-08-28 00:30:07 +02:00
m_caster->DealDamage(unitTarget, unitTarget->CountPctFromMaxHealth(93));
Core:
2010-08-26 01:20:57 +06:00
return;
Add support for quest 11626 (The Emissary) - patch by antihrists (thanks)
2010-05-01 08:30:46 +02:00
}
*Implemented dummy effects for spells 49357, 52845, thanks Sisif
2009-10-31 16:55:12 -07:00
case 49357: // Brewfest Mount Transformation
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
if (!m_caster->HasAuraType(SPELL_AURA_MOUNTED))
return;
m_caster->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Ram for Alliance, Kodo for Horde
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (m_caster->ToPlayer()->GetTeam() == ALLIANCE)
*Implemented dummy effects for spells 49357, 52845, thanks Sisif
2009-10-31 16:55:12 -07:00
{
if (m_caster->GetSpeedRate(MOVE_RUN) >= 2.0f)
// 100% Ram
m_caster->CastSpell(m_caster, 43900, true);
else
// 60% Ram
m_caster->CastSpell(m_caster, 43899, true);
}
else
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (m_caster->ToPlayer()->GetSpeedRate(MOVE_RUN) >= 2.0f)
*Implemented dummy effects for spells 49357, 52845, thanks Sisif
2009-10-31 16:55:12 -07:00
// 100% Kodo
m_caster->CastSpell(m_caster, 49379, true);
else
// 60% Kodo
m_caster->CastSpell(m_caster, 49378, true);
}
return;
case 52845: // Brewfest Mount Transformation (Faction Swap)
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
if (!m_caster->HasAuraType(SPELL_AURA_MOUNTED))
return;
m_caster->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Ram for Horde, Kodo for Alliance
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (m_caster->ToPlayer()->GetTeam() == HORDE)
*Implemented dummy effects for spells 49357, 52845, thanks Sisif
2009-10-31 16:55:12 -07:00
{
if (m_caster->GetSpeedRate(MOVE_RUN) >= 2.0f)
// 100% Ram
m_caster->CastSpell(m_caster, 43900, true);
else
// 60% Ram
m_caster->CastSpell(m_caster, 43899, true);
}
else
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (m_caster->ToPlayer()->GetSpeedRate(MOVE_RUN) >= 2.0f)
*Implemented dummy effects for spells 49357, 52845, thanks Sisif
2009-10-31 16:55:12 -07:00
// 100% Kodo
m_caster->CastSpell(m_caster, 49379, true);
else
// 60% Kodo
m_caster->CastSpell(m_caster, 49378, true);
}
return;
[8221] Removed trailing whitespaces
2009-07-30 10:19:03 +08:00
case 55004: // Nitro Boosts
*Implemented dummy effects for spells 49357, 52845, thanks Sisif
2009-10-31 16:55:12 -07:00
if (!m_CastItem)
return;
if (roll_chance_i(95)) // Nitro Boosts - success
[8221] Removed trailing whitespaces
2009-07-30 10:19:03 +08:00
m_caster->CastSpell(m_caster, 54861, true, m_CastItem);
else // Knocked Up - backfire 5%
m_caster->CastSpell(m_caster, 46014, true, m_CastItem);
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case 50243: // Teach Language
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// spell has a 1/3 chance to trigger one of the below
*Implemented dummy effects for spells 49357, 52845, thanks Sisif
2009-10-31 16:55:12 -07:00
if (roll_chance_i(66))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (m_caster->ToPlayer()->GetTeam() == ALLIANCE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// 1000001 - gnomish binary
m_caster->CastSpell(m_caster, 50242, true);
}
else
{
// 01001000 - goblin binary
m_caster->CastSpell(m_caster, 50246, true);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
case 51582: //Rocket Boots Engaged (Rocket Boots Xtreme and Rocket Boots Xtreme Lite)
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
if (Battleground* bg = m_caster->ToPlayer()->GetBattleground())
Cleanup the mage spell scripts, and move SPELLFAMILY_PRIEST and SPELLFAMILY_ROGUE dummy effect handlers to spell scripts.
2010-07-27 21:12:40 -07:00
bg->EventPlayerDroppedFlag(m_caster->ToPlayer());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->CastSpell(m_caster, 30452, true, NULL);
return;
[7585] Implement quest item 39164 work. Author: KiriX
2009-03-29 17:22:58 -06:00
}
[7876] Implemented dummy effect /*and special target selection*/ for 52759. Author: ApoC
2009-05-22 16:49:37 -05:00
case 52759: // Ancestral Awakening
if (!unitTarget)
return;
m_caster->CastCustomSpell(unitTarget, 52752, &damage, NULL, NULL, true);
return;
*Remove hack for Divine Storm from Unit::DealDamage
2010-07-16 14:42:24 +02:00
case 54171: //Divine Storm
{
m_caster->CastCustomSpell(unitTarget, 54172, &damage, 0, 0, true);
return;
}
[7377] Dummy effects for portal spells used in DK starting area. Author: GriffonHeart
2009-03-03 18:41:44 -06:00
case 58418: // Portal to Orgrimmar
case 58420: // Portal to Stormwind
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
return; // implemented in EffectScript[0]
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
case 62324: // Throw Passenger
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.HasTraj())
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Vehicle *vehicle = m_caster->GetVehicleKit())
if (Unit *passenger = vehicle->GetPassenger(damage - 1))
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
{
std::list<Unit*> unitList;
// use 99 because it is 3d search
SearchAreaTarget(unitList, 99, PUSH_DST_CENTER, SPELL_TARGETS_ENTRY, 33114);
float minDist = 99 * 99;
Core/Vehicles: Make the vehicle system more aura driven. Get rid of redundant checks and update relevant data.
2011-03-04 21:16:27 +01:00
Unit *target = NULL;
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (std::list<Unit*>::iterator itr = unitList.begin(); itr != unitList.end(); ++itr)
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Vehicle *seat = (*itr)->GetVehicleKit())
if (!seat->GetPassenger(0))
if (Unit *device = seat->GetPassenger(2))
if (!device->GetCurrentSpell(CURRENT_CHANNELED_SPELL))
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
{
*More update about positions.
2009-08-29 23:20:16 -05:00
float dist = (*itr)->GetExactDistSq(&m_targets.m_dstPos);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (dist < minDist)
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
{
minDist = dist;
Core/Vehicles: Make the vehicle system more aura driven. Get rid of redundant checks and update relevant data.
2011-03-04 21:16:27 +01:00
target = (*itr);
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
}
}
}
Core/Vehicles: Make the vehicle system more aura driven. Get rid of redundant checks and update relevant data.
2011-03-04 21:16:27 +01:00
if (target && target->IsWithinDist2d(&m_targets.m_dstPos, GetSpellRadius(m_spellInfo, effIndex, false) * 2)) // now we use *2 because the location of the seat is not correct
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
passenger->EnterVehicle(target, 0);
else
{
passenger->ExitVehicle();
*More update about positions.
2009-08-29 23:20:16 -05:00
float x, y, z;
m_targets.m_dstPos.GetPosition(x, y, z);
passenger->GetMotionMaster()->MoveJump(x, y, z, m_targets.GetSpeedXY(), m_targets.GetSpeedZ());
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
}
}
}
return;
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
}
case 64385: // Unusual Compass
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->SetOrientation(float(urand(0, 62832)) / 10000.0f);
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
WorldPacket data;
m_caster->BuildHeartBeatMsg(&data);
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->SendMessageToSet(&data, true);
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
return;
}
Core/Spells: Implemented Pygmy oil use effect
2011-01-06 21:40:32 +01:00
case 53808: // Pygmy Oil
{
Fix build from 06314c9387
2011-01-06 22:45:07 +01:00
Aura *pAura = m_caster->GetAura(53806);
if (pAura)
Core/Spells: Implemented Pygmy oil use effect
2011-01-06 21:40:32 +01:00
pAura->RefreshDuration();
else
{
Fix build from 06314c9387
2011-01-06 22:45:07 +01:00
pAura = m_caster->GetAura(53805);
Core/Spells: Implemented Pygmy oil use effect
2011-01-06 21:40:32 +01:00
if (!pAura || pAura->GetStackAmount() < 5 || !roll_chance_i(50))
m_caster->CastSpell(m_caster, 53805, true);
else
{
pAura->Remove();
m_caster->CastSpell(m_caster, 53806, true);
}
}
return;
}
Core/Spells: Fix Spell 54577 - Support for Quest 12828
2011-01-06 19:33:22 +01:00
case 54577: // U.D.E.D.
{
Core/Spells: Starfall skips targets in stealth, invisibility or not in LoS
2011-01-06 19:57:36 +01:00
if (unitTarget->GetEntry() != 29402)
Core/Spells: Fix Spell 54577 - Support for Quest 12828
2011-01-06 19:33:22 +01:00
return;
m_caster->SummonGameObject(192693, unitTarget->GetPositionX(), unitTarget->GetPositionY(), unitTarget->GetPositionZ(), unitTarget->GetOrientation(), 0, 0, 0, 0, 100);
Core/Spells: Starfall skips targets in stealth, invisibility or not in LoS
2011-01-06 19:57:36 +01:00
for (uint8 i = 0; i < 4; ++i)
Core/Spells: Fix Spell 54577 - Support for Quest 12828
2011-01-06 19:33:22 +01:00
m_caster->SummonGameObject(191567, float(unitTarget->GetPositionX() + irand(-7, 7)), float(unitTarget->GetPositionY() + irand(-7, 7)), unitTarget->GetPositionZ(), unitTarget->GetOrientation(), 0, 0, 0, 0, 100);
unitTarget->Kill(unitTarget);
return;
}
Core/Spells: Dummy for spell 51961; support for Quest 12532 & 12702
2011-01-06 20:22:39 +01:00
case 51961: // Captured Chicken Cover - Quest 12702 & 12532
{
if (m_caster->GetTypeId() != TYPEID_PLAYER
|| !unitTarget->HasAura(51959)
|| !(m_caster->ToPlayer()->GetQuestStatus(12702) == QUEST_STATUS_INCOMPLETE || m_caster->ToPlayer()->GetQuestStatus(12532) == QUEST_STATUS_INCOMPLETE))
return;
m_caster->CastSpell(m_caster, 51037, true);
unitTarget->Kill(unitTarget);
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
*Update to Mangos 6856. Source: Mangos.
2008-11-28 11:38:28 -06:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case SPELLFAMILY_WARRIOR:
// Charge
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_WARRIOR_CHARGE && m_spellInfo->SpellVisual[0] == 867)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
int32 chargeBasePoints0 = damage;
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastCustomSpell(m_caster, 34846, &chargeBasePoints0, NULL, NULL, true);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
//Juggernaut crit bonus
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->HasAura(64976))
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
m_caster->CastSpell(m_caster, 65156, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
* Tabs to spaces -- using: perl -p -i -e "s/\t/ /g" *
2009-04-07 10:51:45 +02:00
//Slam
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_WARRIOR_SLAM && m_spellInfo->SpellIconID == 559)
* Tabs to spaces -- using: perl -p -i -e "s/\t/ /g" *
2009-04-07 10:51:45 +02:00
{
int32 bp0 = damage;
m_caster->CastCustomSpell(unitTarget, 50783, &bp0, NULL, NULL, true, 0);
*Fix starfall.
2009-03-03 20:42:49 +01:00
return;
* Tabs to spaces -- using: perl -p -i -e "s/\t/ /g" *
2009-04-07 10:51:45 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Execute
Core/Spells: Fixed Execute formula, patch by dr.tenma
2010-09-05 14:28:13 +02:00
if (m_spellInfo->SpellFamilyFlags[EFFECT_0] & SPELLFAMILYFLAG_WARRIOR_EXECUTE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix the bug that charge spells do not apply stun auras.
2009-01-31 11:09:37 -06:00
spell_id = 20647;
Execute should only apply damage based on rage up to 30. Thanks 19Maxx83. Fixes issue #953.
2010-03-01 17:57:14 -06:00
Core/Spells: Fixed Execute formula, patch by dr.tenma
2010-09-05 14:28:13 +02:00
int32 rageUsed = std::min<int32>(300 - m_powerCost, m_caster->GetPower(POWER_RAGE));
int32 newRage = std::max<int32>(0, m_caster->GetPower(POWER_RAGE) - rageUsed);
// Sudden Death rage save
if (AuraEffect * aurEff = m_caster->GetAuraEffect(SPELL_AURA_PROC_TRIGGER_SPELL, SPELLFAMILY_GENERIC, 1989, EFFECT_0))
*Fix sudden death proc execute damage.
2009-05-13 18:00:07 +02:00
{
Core/Spells: Fixed Execute formula, patch by dr.tenma
2010-09-05 14:28:13 +02:00
int32 ragesave = SpellMgr::CalculateSpellEffectAmount(aurEff->GetSpellProto(), EFFECT_1) * 10;
newRage = std::max(newRage, ragesave);
*Fix sudden death proc execute damage.
2009-05-13 18:00:07 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Execute formula, patch by dr.tenma
2010-09-05 14:28:13 +02:00
m_caster->SetPower(POWER_RAGE, uint32(newRage));
// Glyph of Execution bonus
if (AuraEffect * aurEff = m_caster->GetAuraEffect(58367, EFFECT_0))
rageUsed += aurEff->GetAmount() * 10;
Execute should only apply damage based on rage up to 30. Thanks 19Maxx83. Fixes issue #953.
2010-03-01 17:57:14 -06:00
Core/Spells: Fixed Execute formula, patch by dr.tenma
2010-09-05 14:28:13 +02:00
bp = damage + int32(rageUsed * m_spellInfo->EffectDamageMultiplier[effIndex] + m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.2f);
*Fix broken execute.
2009-02-02 10:01:56 -06:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
[7704] Implement damage part for spell 12809. Author: Trogvar
2009-04-24 11:15:04 -05:00
// Concussion Blow
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_WARRIOR_CONCUSSION_BLOW)
[7704] Implement damage part for spell 12809. Author: Trogvar
2009-04-24 11:15:04 -05:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
m_damage += CalculatePctF(damage, m_caster->GetTotalAttackPowerValue(BASE_ATTACK));
[7704] Implement damage part for spell 12809. Author: Trogvar
2009-04-24 11:15:04 -05:00
return;
*Do not take ammo for shockwave
2009-05-04 15:48:10 +02:00
}
*Update to Mangos 7093.
2009-01-14 18:42:53 -06:00
switch(m_spellInfo->Id)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 7183.
2009-01-25 16:35:14 -06:00
// Bloodthirst
case 23881:
{
m_caster->CastCustomSpell(unitTarget, 23885, &damage, NULL, NULL, true, NULL);
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
case SPELLFAMILY_WARLOCK:
*Update to Mangos 7006.
2009-01-02 11:03:43 -06:00
// Life Tap
Core/AuraScripts: Fix runtime error messages appearing in aura scripts when one hook is called from inside of another one.
2011-05-26 16:12:33 +02:00
if ((m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_WARLOCK_LIFETAP) && m_caster->ToPlayer())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core:
2010-08-22 23:46:40 +06:00
float spFactor = 0.0f;
Re-re-fix for Life Tap (3.3.3).
2010-05-26 14:54:56 -03:00
switch (m_spellInfo->Id)
{
Core:
2010-08-22 23:46:40 +06:00
case 11689: spFactor = 0.2f; break;
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
case 27222:
Core:
2010-08-22 23:46:40 +06:00
case 57946: spFactor = 0.5f; break;
Re-re-fix for Life Tap (3.3.3).
2010-05-26 14:54:56 -03:00
}
Correct usage of basePoints in various locations
2010-08-25 03:21:22 +03:00
int32 damage = int32(SpellMgr::CalculateSpellEffectAmount(m_spellInfo, 0) + (6.3875 * m_spellInfo->baseLevel));
Core/Game: fix all warnings related to converting doubles and floats.
2010-08-22 12:39:39 -07:00
int32 mana = int32(damage + (m_caster->ToPlayer()->GetUInt32Value(PLAYER_FIELD_MOD_DAMAGE_DONE_POS+SPELL_SCHOOL_SHADOW) * spFactor));
Fix Life Tap Formula (3.3.3)
2010-05-22 04:04:51 -03:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget && (int32(unitTarget->GetHealth()) > damage))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Shouldn't Appear in Combat Log
*Update to Mangos 7006.
2009-01-02 11:03:43 -06:00
unitTarget->ModifyHealth(-damage);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7006.
2009-01-02 11:03:43 -06:00
// Improved Life Tap mod
Update aura system:
2010-01-10 01:23:15 +01:00
if (AuraEffect const * aurEff = m_caster->GetDummyAuraEffect(SPELLFAMILY_WARLOCK, 208, 0))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(mana, aurEff->GetAmount());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7006.
2009-01-02 11:03:43 -06:00
m_caster->CastCustomSpell(unitTarget, 31818, &mana, NULL, NULL, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Mana Feed
*Update to Mangos 7006.
2009-01-02 11:03:43 -06:00
int32 manaFeedVal = 0;
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
if (AuraEffect const * aurEff = m_caster->GetAuraEffect(SPELL_AURA_ADD_FLAT_MODIFIER, SPELLFAMILY_WARLOCK, 1982, 0))
manaFeedVal = aurEff->GetAmount();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (manaFeedVal > 0)
*Update to Mangos 7006.
2009-01-02 11:03:43 -06:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
ApplyPctN(manaFeedVal, mana);
*Update to Mangos 7006.
2009-01-02 11:03:43 -06:00
m_caster->CastCustomSpell(m_caster, 32553, &manaFeedVal, NULL, NULL, true, NULL);
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
else
SendCastResult(SPELL_FAILED_FIZZLE);
return;
}
break;
case SPELLFAMILY_DRUID:
*Fix starfall.
2009-03-03 20:42:49 +01:00
// Starfall
* Begin removing hardcoded SpellFamilyFlags from the core.
2009-12-24 12:37:26 -06:00
if (m_spellInfo->SpellFamilyFlags[2] & SPELLFAMILYFLAG2_DRUID_STARFALL)
*Fix starfall.
2009-03-03 20:42:49 +01:00
{
[7516] Add form/mounting/self control loss limitations to 48505 and ranks. Author: Sarjuuk
2009-03-21 22:48:52 -06:00
//Shapeshifting into an animal form or mounting cancels the effect.
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetCreatureType() == CREATURE_TYPE_BEAST || m_caster->IsMounted())
[7516] Add form/mounting/self control loss limitations to 48505 and ranks. Author: Sarjuuk
2009-03-21 22:48:52 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_triggeredByAuraSpell)
[7516] Add form/mounting/self control loss limitations to 48505 and ranks. Author: Sarjuuk
2009-03-21 22:48:52 -06:00
m_caster->RemoveAurasDueToSpell(m_triggeredByAuraSpell->Id);
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7516] Add form/mounting/self control loss limitations to 48505 and ranks. Author: Sarjuuk
2009-03-21 22:48:52 -06:00
//Any effect which causes you to lose control of your character will supress the starfall effect.
Fixed Starfall: root effect shouldn't supress the starfall effect
2011-04-10 08:46:47 +03:00
if (m_caster->HasUnitState(UNIT_STAT_CONTROLLED))
[7516] Add form/mounting/self control loss limitations to 48505 and ranks. Author: Sarjuuk
2009-03-21 22:48:52 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7516] Add form/mounting/self control loss limitations to 48505 and ranks. Author: Sarjuuk
2009-03-21 22:48:52 -06:00
m_caster->CastSpell(unitTarget, damage, true);
*Fix starfall.
2009-03-03 20:42:49 +01:00
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case SPELLFAMILY_PALADIN:
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
// Divine Storm
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (m_spellInfo->SpellFamilyFlags[1] & SPELLFAMILYFLAG1_PALADIN_DIVINESTORM && effIndex == 1)
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
int32 dmg = CalculatePctN(m_damage, damage);
*Reinit the iterator in each loop as the iter is removed from the list, in AuctionHouseObject::Update, by Trazom
2009-10-31 16:00:47 -07:00
if (!unitTarget)
unitTarget = m_caster;
*Ulduar teleporter, and updates, by BonDit. Thanks AniRB.
2009-10-16 12:44:00 -07:00
m_caster->CastCustomSpell(unitTarget, 54171, &dmg, 0, 0, true);
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
switch(m_spellInfo->Id)
{
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case 31789: // Righteous Defense (step 1)
{
// Clear targets for eff 1
*Reinit the iterator in each loop as the iter is removed from the list, in AuctionHouseObject::Update, by Trazom
2009-10-31 16:00:47 -07:00
for (std::list<TargetInfo>::iterator ihit = m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
ihit->effectMask &= ~(1<<1);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
// not empty (checked), copy
Fixed spell Righteous Defense
2009-12-20 15:11:57 +01:00
Unit::AttackerSet attackers = unitTarget->getAttackers();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
// selected from list 3
Core/Spells: Fixed TARGET_UNIT_DRIVER selection and possible problems with Righteous Defense target count
2011-05-14 14:12:40 +02:00
uint32 maxTargets = std::min<uint32>(3, attackers.size());
for (uint32 i = 0; i < maxTargets; ++i)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
Unit::AttackerSet::iterator aItr = attackers.begin();
Core/Spells: Fixed TARGET_UNIT_DRIVER selection and possible problems with Righteous Defense target count
2011-05-14 14:12:40 +02:00
std::advance(aItr, urand(0, attackers.size() - 1));
AddUnitTarget(*aItr, 1);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
attackers.erase(aItr);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// now let next effect cast spell at each target.
return;
}
}
break;
case SPELLFAMILY_SHAMAN:
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
// Cleansing Totem Pulse
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
if (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_SHAMAN_TOTEM_EFFECTS && m_spellInfo->SpellIconID == 1673)
*Fix Cleansing Totem Author: Astellar
2009-05-22 16:42:29 -05:00
{
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
int32 bp1 = 1;
// Cleansing Totem Effect
*Check for NULL unitTarget's in Cleansing Totem Effect, Healing Stream Totem, Mana Spring Totem, thanks Sisif
2009-10-31 16:45:56 -07:00
if (unitTarget)
m_caster->CastCustomSpell(unitTarget, 52025, NULL, &bp1, NULL, true, NULL, NULL, m_originalCasterGUID);
*Fix Cleansing Totem Author: Astellar
2009-05-22 16:42:29 -05:00
return;
}
*Update to Mangos 7190.
2009-01-26 17:13:27 -06:00
// Healing Stream Totem
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_SHAMAN_HEALING_STREAM)
*Update to Mangos 7190.
2009-01-26 17:13:27 -06:00
{
fix Restorative Totems
2010-01-04 11:05:19 +02:00
if (!unitTarget)
return;
// Restorative Totems
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Unit *owner = m_caster->GetOwner())
fix Restorative Totems
2010-01-04 11:05:19 +02:00
if (AuraEffect *dummy = owner->GetAuraEffect(SPELL_AURA_DUMMY, SPELLFAMILY_SHAMAN, 338, 1))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(damage, dummy->GetAmount());
fix Restorative Totems
2010-01-04 11:05:19 +02:00
*Check for NULL unitTarget's in Cleansing Totem Effect, Healing Stream Totem, Mana Spring Totem, thanks Sisif
2009-10-31 16:45:56 -07:00
m_caster->CastCustomSpell(unitTarget, 52042, &damage, 0, 0, true, 0, 0, m_originalCasterGUID);
*Update to Mangos 7190.
2009-01-26 17:13:27 -06:00
return;
}
// Mana Spring Totem
* Begin removing hardcoded SpellFamilyFlags from the core.
2009-12-24 12:37:26 -06:00
if (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_SHAMAN_MANA_SPRING)
*Update to Mangos 7190.
2009-01-26 17:13:27 -06:00
{
*Check for NULL unitTarget's in Cleansing Totem Effect, Healing Stream Totem, Mana Spring Totem, thanks Sisif
2009-10-31 16:45:56 -07:00
if (!unitTarget || unitTarget->getPowerType() != POWER_MANA)
*Update to Mangos 7190.
2009-01-26 17:13:27 -06:00
return;
m_caster->CastCustomSpell(unitTarget, 52032, &damage, 0, 0, true, 0, 0, m_originalCasterGUID);
return;
}
*Update to Mangos 7076.
2009-01-12 21:58:01 -06:00
// Lava Lash
* Begin removing hardcoded SpellFamilyFlags from the core.
2009-12-24 12:37:26 -06:00
if (m_spellInfo->SpellFamilyFlags[2] & SPELLFAMILYFLAG2_SHAMAN_LAVA_LASH)
*Update to Mangos 7076.
2009-01-12 21:58:01 -06:00
{
*Cleanup
2009-10-18 18:38:46 -07:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7076.
2009-01-12 21:58:01 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if (m_caster->ToPlayer()->GetItemByPos(INVENTORY_SLOT_BAG_0, EQUIPMENT_SLOT_OFFHAND))
*Update to Mangos 7076.
2009-01-12 21:58:01 -06:00
{
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
// Damage is increased by 25% if your off-hand weapon is enchanted with Flametongue.
Update aura system:
2010-01-10 01:23:15 +01:00
if (m_caster->GetAuraEffect(SPELL_AURA_DUMMY, SPELLFAMILY_SHAMAN, 0x200000, 0, 0))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(m_damage, damage);
*Update to Mangos 7076.
2009-01-12 21:58:01 -06:00
}
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
*Fix Death Strike.
2009-03-04 00:19:55 +01:00
case SPELLFAMILY_DEATHKNIGHT:
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
// Death strike
* Begin removing hardcoded SpellFamilyFlags from the core.
2009-12-24 12:37:26 -06:00
if (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_DK_DEATH_STRIKE)
*Fix Death Strike.
2009-03-04 00:19:55 +01:00
{
*Proper Diseases and Death Strike disease count, thanks lobuz
2009-11-17 20:13:41 -08:00
uint32 count = unitTarget->GetDiseasesByCaster(m_caster->GetGUID());
Core/Game: Fix remaining warnings on windows (and most likely almost all of the ones on *nix)
2010-09-03 21:55:57 -07:00
int32 bp = int32(count * m_caster->CountPctFromMaxHealth(int32(m_spellInfo->EffectDamageMultiplier[0])));
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
// Improved Death Strike
if (AuraEffect const * aurEff = m_caster->GetAuraEffect(SPELL_AURA_ADD_PCT_MODIFIER, SPELLFAMILY_DEATHKNIGHT, 2751, 0))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(bp, m_caster->CalculateSpellDamage(m_caster, aurEff->GetSpellProto(), 2));
*Fix healing reduce effects on Death Knights, thanks lobuz
2009-11-17 19:49:24 -08:00
m_caster->CastCustomSpell(m_caster, 45470, &bp, NULL, NULL, false);
*Fix Death Strike.
2009-03-04 00:19:55 +01:00
return;
}
*Fix judgements of the Wise
2009-03-08 03:10:03 +01:00
// Death Coil
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_DK_DEATH_COIL)
*Fix judgements of the Wise
2009-03-08 03:10:03 +01:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->IsFriendlyTo(unitTarget))
*Fix judgements of the Wise
2009-03-08 03:10:03 +01:00
{
Core/Game: fix all warnings related to converting doubles and floats.
2010-08-22 12:39:39 -07:00
int32 bp = int32(damage * 1.5f);
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastCustomSpell(unitTarget, 47633, &bp, NULL, NULL, true);
*Fix judgements of the Wise
2009-03-08 03:10:03 +01:00
}
else
*Update 52375 and ranks code. Author: Charlie2025
2009-03-31 14:25:38 -06:00
{
int32 bp = damage;
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastCustomSpell(unitTarget, 47632, &bp, NULL, NULL, true);
*Update 52375 and ranks code. Author: Charlie2025
2009-03-31 14:25:38 -06:00
}
*Fix judgements of the Wise
2009-03-08 03:10:03 +01:00
return;
}
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
switch (m_spellInfo->Id)
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
{
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
case 49560: // Death Grip
* Fix: Deathknights 'Death Grip'
2010-04-11 15:30:39 +02:00
Position pos;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
GetSummonPosition(effIndex, pos);
*Update vehicle system. Make vehicle a seperate class from creature.
2009-08-23 22:09:43 -05:00
if (Unit *unit = unitTarget->GetVehicleBase()) // what is this for?
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
unit->CastSpell(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ(), damage, true);
Core/Spells: Deterrence should deflect Death Grip.
2010-11-09 23:02:47 -03:00
else if (!unitTarget->HasAuraType(SPELL_AURA_DEFLECT_SPELLS)) // Deterrence
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
unitTarget->CastSpell(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ(), damage, true);
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
return;
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
case 46584: // Raise Dead
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
// Do we have talent Master of Ghouls?
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->HasAura(52143))
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
// summon as pet
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
bp = 52150;
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
else
// or guardian
bp = 46585;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
if (m_targets.HasDst())
*Implement spell casting on transports (no more out of range error, etc)
2010-08-08 20:32:14 +02:00
targets.setDst(m_targets.m_dstPos);
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
else
{
*Implement spell casting on transports (no more out of range error, etc)
2010-08-08 20:32:14 +02:00
targets.setDst(*m_caster);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
// Corpse not found - take reagents (only not triggered cast can take them)
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
triggered = false;
}
// Remove cooldown - summon spellls have category
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
m_caster->ToPlayer()->RemoveSpellCooldown(m_spellInfo->Id, true);
spell_id = 48289;
break;
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
// Raise dead - take reagents and trigger summon spells
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
case 48289:
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
if (m_targets.HasDst())
*Implement spell casting on transports (no more out of range error, etc)
2010-08-08 20:32:14 +02:00
targets.setDst(m_targets.m_dstPos);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Correctly set basepoints of Learn spells - patch by Toni.Shocker.
2010-07-15 23:20:41 +02:00
spell_id = CalculateDamage(0, NULL);
Add more methods to SpellScript.
2010-08-18 00:20:23 +06:00
break;
*Fix Gargoyle feeding behaviour - original patch by thenecromancer.
2009-08-04 19:28:31 +02:00
}
*Fix judgements of the Wise
2009-03-08 03:10:03 +01:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix broken execute.
2009-04-03 16:59:01 -06:00
//spells triggered by dummy effect should not miss
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (spell_id)
*Fix broken execute.
2009-04-03 16:59:01 -06:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(spell_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
*Fix broken execute.
2009-04-03 16:59:01 -06:00
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("EffectDummy of spell %u: triggering unknown spell id %i\n", m_spellInfo->Id, spell_id);
*Fix broken execute.
2009-04-03 16:59:01 -06:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix broken execute.
2009-04-03 16:59:01 -06:00
targets.setUnitTarget(unitTarget);
*Remove some unused containers from Spell class.
2010-08-21 21:00:06 +02:00
Spell* spell = new Spell(m_caster, spellInfo, triggered, m_originalCasterGUID, true);
*Remove m_currentBasePoints from spell class, use m_spellValue instead.
2010-08-27 06:40:23 +02:00
if (bp) spell->SetSpellValue(SPELLVALUE_BASE_POINT0, bp);
*Fix broken execute.
2009-04-03 16:59:01 -06:00
spell->prepare(&targets);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// pet auras
Add spaces after commas
2011-04-29 20:47:02 +02:00
if (PetAura const* petSpell = sSpellMgr->GetPetAura(m_spellInfo->Id, effIndex))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
m_caster->AddPetAura(petSpell);
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Modified spell_scripts table, it is now possible to add different scripts for each spell effect
2010-07-24 21:51:25 +02:00
// normal DB scripted effect
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Spell ScriptStart spellid %u in EffectDummy(%u)", m_spellInfo->Id, effIndex);
DB Scripts: Fix calling of DB scripts from spell_scripts table
2010-08-28 21:01:16 +06:00
m_caster->GetMap()->ScriptsStart(sSpellScripts, uint32(m_spellInfo->Id | (effIndex << 24)), m_caster, unitTarget);
Modified spell_scripts table, it is now possible to add different scripts for each spell effect
2010-07-24 21:51:25 +02:00
[7454] Support scripting for dummy spell effects. Author: Lightguard
2009-03-13 18:34:46 -06:00
// Script based implementation. Must be used only for not good for implementation in core spell effects
// So called only for not proccessed cases
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (gameObjTarget)
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
sScriptMgr->OnDummyEffect(m_caster, m_spellInfo->Id, effIndex, gameObjTarget);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (unitTarget && unitTarget->GetTypeId() == TYPEID_UNIT)
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
sScriptMgr->OnDummyEffect(m_caster, m_spellInfo->Id, effIndex, unitTarget->ToCreature());
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (itemTarget)
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
sScriptMgr->OnDummyEffect(m_caster, m_spellInfo->Id, effIndex, itemTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTriggerSpellWithValue(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 triggered_spell_id = m_spellInfo->EffectTriggerSpell[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal case
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(triggered_spell_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("EffectTriggerSpellWithValue of spell %u: triggering unknown spell id %i", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 bp = damage;
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
Unit * caster = GetTriggeredSpellCaster(spellInfo, m_caster, unitTarget);
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
caster->CastCustomSpell(unitTarget, triggered_spell_id, &bp, &bp, &bp, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTriggerRitualOfSummoning(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 triggered_spell_id = m_spellInfo->EffectTriggerSpell[effIndex];
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(triggered_spell_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("EffectTriggerRitualOfSummoning of spell %u: triggering unknown spell id %i", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
finish();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->CastSpell(unitTarget, spellInfo, false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectForceCast(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 triggered_spell_id = m_spellInfo->EffectTriggerSpell[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal case
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(triggered_spell_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("EffectForceCast of spell %u: triggering unknown spell id %i", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Use basepoints for effect 140 only when non-null.
2009-07-30 00:05:36 +02:00
if (damage)
*better handle effect 140. do not consider bp > 0 as custom damage.
2009-08-15 20:36:21 -05:00
{
Scripts/Icecrown Citadel
2011-01-12 22:50:51 +01:00
switch (m_spellInfo->Id)
*better handle effect 140. do not consider bp > 0 as custom damage.
2009-08-15 20:36:21 -05:00
{
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
case 48598: // Ride Flamebringer Cue
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
unitTarget->RemoveAura(damage);
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
break;
Core/Spells: Fix spell 52588 (Skeletal Gryphon Escape) used in quest 12701 (Massacre At Light's Point).
2011-05-24 05:20:57 +02:00
case 52588: // Skeletal Gryphon Escape
unitTarget->RemoveAura(damage);
unitTarget->CastSpell(unitTarget, spellInfo, true);
return;
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
case 52463: // Hide In Mine Car
case 52349: // Overtake
unitTarget->CastCustomSpell(unitTarget, spellInfo->Id, &damage, NULL, NULL, true, NULL, NULL, m_originalCasterGUID);
return;
Scripts/Icecrown Citadel: Add script for Deathbringer Saurfang (only missing alliance outro due to need of spawning and moving a transport)
2010-08-21 20:50:38 +02:00
case 72378: // Blood Nova
case 73058: // Blood Nova
Scripts/Icecrown Citadel
2011-01-12 22:50:51 +01:00
m_caster->CastSpell(unitTarget, 72380, true); // additional spell cast
Scripts/Icecrown Citadel: Add script for Deathbringer Saurfang (only missing alliance outro due to need of spawning and moving a transport)
2010-08-21 20:50:38 +02:00
break;
*better handle effect 140. do not consider bp > 0 as custom damage.
2009-08-15 20:36:21 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Revert 0a95c34021 (thanks QAston for talking sense into me)
2010-12-27 11:06:53 +01:00
Unit * caster = GetTriggeredSpellCaster(spellInfo, m_caster, unitTarget);
Core: Generic cleanup (tab2spaces/trailing whitespace removal)
2011-01-26 01:03:35 +01:00
Revert 0a95c34021 (thanks QAston for talking sense into me)
2010-12-27 11:06:53 +01:00
caster->CastSpell(unitTarget, spellInfo, true, NULL, NULL, m_originalCasterGUID);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectForceCastWithValue(SpellEffIndex effIndex)
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
{
if (!unitTarget)
return;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 triggered_spell_id = m_spellInfo->EffectTriggerSpell[effIndex];
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
// normal case
SpellEntry const *spellInfo = sSpellStore.LookupEntry(triggered_spell_id);
if (!spellInfo)
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("EffectForceCastWithValue of spell %u: triggering unknown spell id %i", m_spellInfo->Id, triggered_spell_id);
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
return;
}
int32 bp = damage;
Revert 0a95c34021 (thanks QAston for talking sense into me)
2010-12-27 11:06:53 +01:00
Unit * caster = GetTriggeredSpellCaster(spellInfo, m_caster, unitTarget);
caster->CastCustomSpell(unitTarget, spellInfo->Id, &bp, &bp, &bp, true, NULL, NULL, m_originalCasterGUID);
*Implement SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141).
2010-07-19 22:52:21 +02:00
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTriggerSpell(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[8360] Simplify and partly rewrite SPELL_EFFECT_TRIGGER_SPELL work. Author: VladimirMangos
2009-08-12 21:07:03 -05:00
// only unit case known
if (!unitTarget)
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (gameObjTarget || itemTarget)
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("Spell::EffectTriggerSpell (Spell: %u): Unsupported non-unit case!", m_spellInfo->Id);
[8360] Simplify and partly rewrite SPELL_EFFECT_TRIGGER_SPELL work. Author: VladimirMangos
2009-08-12 21:07:03 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8369] Some step back in triggered effect caster selection. Author: VladimirMangos
2009-08-17 15:54:39 -05:00
uint32 triggered_spell_id = m_spellInfo->EffectTriggerSpell[effIndex];
Fix Hunter's spell Snake Trap.
2010-03-16 21:32:01 +01:00
Unit* originalCaster = NULL;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// special cases
switch(triggered_spell_id)
{
*Fix Glyph of Mirror Image
2009-08-07 16:45:56 +02:00
// Mirror Image
case 58832:
{
// Glyph of Mirror Image
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
if (m_caster->HasAura(63093))
*Fix Glyph of Mirror Image
2009-08-07 16:45:56 +02:00
m_caster->CastSpell(m_caster, 65047, true); // Mirror Image
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix Glyph of Mirror Image
2009-08-07 16:45:56 +02:00
break;
}
[8292] Fixed healing part of spell 19505 and ranks (in fact from rank 2) Author: VladimirMangos
2009-08-02 10:19:40 +08:00
// Vanish (not exist)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case 18461:
{
[8360] Simplify and partly rewrite SPELL_EFFECT_TRIGGER_SPELL work. Author: VladimirMangos
2009-08-12 21:07:03 -05:00
unitTarget->RemoveMovementImpairingAuras();
unitTarget->RemoveAurasByType(SPELL_AURA_MOD_STALKED);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Vanish not applying stealth. Closes issue #4699.
2010-11-13 06:43:45 +01:00
// If this spell is given to an NPC, it must handle the rest using its own AI
[8360] Simplify and partly rewrite SPELL_EFFECT_TRIGGER_SPELL work. Author: VladimirMangos
2009-08-12 21:07:03 -05:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Vanish not applying stealth. Closes issue #4699.
2010-11-13 06:43:45 +01:00
// See if we already are stealthed. If so, we're done.
if (unitTarget->HasAura(1784))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Vanish not applying stealth. Closes issue #4699.
2010-11-13 06:43:45 +01:00
// Reset cooldown on stealth if needed
if (unitTarget->ToPlayer()->HasSpellCooldown(1784))
unitTarget->ToPlayer()->RemoveSpellCooldown(1784);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Vanish not applying stealth. Closes issue #4699.
2010-11-13 06:43:45 +01:00
triggered_spell_id = 1784;
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Fix Demonic Empowerment.
2009-05-19 18:33:49 +02:00
// Demonic Empowerment -- succubus
case 54437:
{
unitTarget->RemoveMovementImpairingAuras();
unitTarget->RemoveAurasByType(SPELL_AURA_MOD_STALKED);
unitTarget->RemoveAurasByType(SPELL_AURA_MOD_STUN);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix Demonic Empowerment.
2009-05-19 18:33:49 +02:00
// Cast Lesser Invisibility
triggered_spell_id = 7870;
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// just skip
case 23770: // Sayge's Dark Fortune of *
// not exist, common cooldown can be implemented in scripts if need.
return;
// Brittle Armor - (need add max stack of 24575 Brittle Armor)
case 29284:
{
[8292] Fixed healing part of spell 19505 and ranks (in fact from rank 2) Author: VladimirMangos
2009-08-02 10:19:40 +08:00
// Brittle Armor
SpellEntry const* spell = sSpellStore.LookupEntry(24575);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!spell)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Cleanup:
2010-08-26 15:54:56 +06:00
for (uint32 j = 0; j < spell->StackAmount; ++j)
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
m_caster->CastSpell(unitTarget, spell->Id, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
// Mercurial Shield - (need add max stack of 26464 Mercurial Shield)
case 29286:
{
[8292] Fixed healing part of spell 19505 and ranks (in fact from rank 2) Author: VladimirMangos
2009-08-02 10:19:40 +08:00
// Mercurial Shield
SpellEntry const* spell = sSpellStore.LookupEntry(26464);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!spell)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Cleanup:
2010-08-26 15:54:56 +06:00
for (uint32 j = 0; j < spell->StackAmount; ++j)
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
m_caster->CastSpell(unitTarget, spell->Id, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
// Righteous Defense
case 31980:
{
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
m_caster->CastSpell(unitTarget, 31790, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
// Cloak of Shadows
[8292] Fixed healing part of spell 19505 and ranks (in fact from rank 2) Author: VladimirMangos
2009-08-02 10:19:40 +08:00
case 35729:
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix the bug that devastate requires double rage.
2008-11-27 11:54:27 -06:00
uint32 dispelMask = GetDispellMask(DISPEL_ALL);
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraApplicationMap& Auras = unitTarget->GetAppliedAuras();
for (Unit::AuraApplicationMap::iterator iter = Auras.begin(); iter != Auras.end();)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// remove all harmful spells on you...
Update aura system:
2010-01-10 01:23:15 +01:00
SpellEntry const* spell = iter->second->GetBase()->GetSpellProto();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if ((spell->DmgClass == SPELL_DAMAGE_CLASS_MAGIC // only affect magic spells
*Fix the bug that devastate requires double rage.
2008-11-27 11:54:27 -06:00
|| ((1<<spell->Dispel) & dispelMask))
[svn] Fix cloak of shadow, can remove fairy fire now.
2008-10-23 22:04:14 -05:00
// ignore positive and passive auras
Update aura system:
2010-01-10 01:23:15 +01:00
&& !iter->second->IsPositive() && !iter->second->GetBase()->IsPassive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix a crash with cloak of shadows.
2009-04-08 00:21:11 +02:00
m_caster->RemoveAura(iter);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Fix auras amount after relog
2009-04-08 00:07:32 +02:00
else
Core/Spells: Removed unused variables
2011-05-12 10:41:25 +02:00
++iter;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
return;
}
// Priest Shadowfiend (34433) need apply mana gain trigger aura on pet
case 41967:
{
[8360] Simplify and partly rewrite SPELL_EFFECT_TRIGGER_SPELL work. Author: VladimirMangos
2009-08-12 21:07:03 -05:00
if (Unit *pet = unitTarget->GetGuardianPet())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pet->CastSpell(pet, 28305, true);
return;
}
Fix Empowered Rune Weapon
2010-01-23 16:06:06 +01:00
// Empower Rune Weapon
case 53258:
return; // skip, hack-added in spell effect
Fix Hunter's spell Snake Trap.
2010-03-16 21:32:01 +01:00
// Snake Trap
case 57879:
originalCaster = m_originalCaster;
break;
Scripts: Added script for Lord Marrowgar
2010-08-18 17:19:47 +02:00
// Coldflame
case 33801:
return; // just make the core stfu
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal case
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(triggered_spell_id);
[8360] Simplify and partly rewrite SPELL_EFFECT_TRIGGER_SPELL work. Author: VladimirMangos
2009-08-12 21:07:03 -05:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("EffectTriggerSpell of spell %u: triggering unknown spell id %i", m_spellInfo->Id, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix freezing trap.
2009-06-07 12:49:06 +02:00
// Remove spell cooldown (not category) if spell triggering spell with cooldown and same category
*Allow auras SPELL_AURA_MECHANIC_DURATION_MOD and similar to use effect mechanics to check which spell can be moded.
2009-06-07 13:14:08 +02:00
// Needed by freezing arrow and few other spells
*Fix freezing trap.
2009-06-07 12:49:06 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER && m_spellInfo->CategoryRecoveryTime && spellInfo->CategoryRecoveryTime
&& m_spellInfo->Category == spellInfo->Category)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->RemoveSpellCooldown(spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8369] Some step back in triggered effect caster selection. Author: VladimirMangos
2009-08-17 15:54:39 -05:00
// Note: not exist spells with weapon req. and IsSpellHaveCasterSourceTargets == true
// so this just for speedup places in else
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
Unit * caster = GetTriggeredSpellCaster(spellInfo, m_caster, unitTarget);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
caster->CastSpell(unitTarget, spellInfo, true, 0, 0, (originalCaster ? originalCaster->GetGUID() : 0));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTriggerMissileSpell(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 triggered_spell_id = m_spellInfo->EffectTriggerSpell[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal case
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(triggered_spell_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("EffectTriggerMissileSpell of spell %u (eff: %u): triggering unknown spell id %u",
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_spellInfo->Id, effIndex, triggered_spell_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (m_CastItem)
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outStaticDebug("WORLD: cast Item spellId - %i", spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix freezing trap.
2009-06-07 12:49:06 +02:00
// Remove spell cooldown (not category) if spell triggering spell with cooldown and same category
*Allow auras SPELL_AURA_MECHANIC_DURATION_MOD and similar to use effect mechanics to check which spell can be moded.
2009-06-07 13:14:08 +02:00
// Needed by freezing arrow and few other spells
*Fix freezing trap.
2009-06-07 12:49:06 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER && m_spellInfo->CategoryRecoveryTime && spellInfo->CategoryRecoveryTime
&& m_spellInfo->Category == spellInfo->Category)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->RemoveSpellCooldown(spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More update about positions.
2009-08-29 23:20:16 -05:00
float x, y, z;
m_targets.m_dstPos.GetPosition(x, y, z);
m_caster->CastSpell(x, y, z, spellInfo->Id, true, m_CastItem, 0, m_originalCasterGUID);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectJump(SpellEffIndex effIndex)
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
{
if (m_caster->isInFlight())
return;
Core/Spells: Removed unused variables
2011-05-12 10:41:25 +02:00
float x, y, z;
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
if (m_targets.getUnitTarget())
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_targets.getUnitTarget()->GetContactPoint(m_caster, x, y, z, CONTACT_DISTANCE);
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
else if (m_targets.getGOTarget())
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_targets.getGOTarget()->GetContactPoint(m_caster, x, y, z, CONTACT_DISTANCE);
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
else
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Spell::EffectJump - unsupported target mode for spell ID %u", m_spellInfo->Id);
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
return;
}
float speedXY, speedZ;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
CalculateJumpSpeeds(effIndex, m_caster->GetExactDist2d(x, y), speedXY, speedZ);
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
m_caster->GetMotionMaster()->MoveJump(x, y, z, speedXY, speedZ);
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectJumpDest(SpellEffIndex effIndex)
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->isInFlight())
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
// Init dest coordinates
Core/Spells: Removed unused variables
2011-05-12 10:41:25 +02:00
float x, y, z;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.HasDst())
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
{
*More update about positions.
2009-08-29 23:20:16 -05:00
m_targets.m_dstPos.GetPosition(x, y, z);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (m_spellInfo->EffectImplicitTargetA[effIndex] == TARGET_DEST_TARGET_BACK)
[7450] Fixes and improvements in TARGET_BEHIND_VICTIM, SPELL_EFFECT_JUMP2, SPELL_EFFECT_TELEPORT_UNITS work. Author: VladimirMangos
2009-03-13 18:28:10 -06:00
{
// explicit cast data from client or server-side cast
// some spell at client send caster
Unit* pTarget = NULL;
Code Style (game + scripts only):
2010-04-08 08:20:08 +02:00
if (m_targets.getUnitTarget() && m_targets.getUnitTarget() != m_caster)
[7450] Fixes and improvements in TARGET_BEHIND_VICTIM, SPELL_EFFECT_JUMP2, SPELL_EFFECT_TELEPORT_UNITS work. Author: VladimirMangos
2009-03-13 18:28:10 -06:00
pTarget = m_targets.getUnitTarget();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (m_caster->getVictim())
[7450] Fixes and improvements in TARGET_BEHIND_VICTIM, SPELL_EFFECT_JUMP2, SPELL_EFFECT_TELEPORT_UNITS work. Author: VladimirMangos
2009-03-13 18:28:10 -06:00
pTarget = m_caster->getVictim();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (m_caster->GetTypeId() == TYPEID_PLAYER)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
pTarget = ObjectAccessor::GetUnit(*m_caster, m_caster->ToPlayer()->GetSelection());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7450] Fixes and improvements in TARGET_BEHIND_VICTIM, SPELL_EFFECT_JUMP2, SPELL_EFFECT_TELEPORT_UNITS work. Author: VladimirMangos
2009-03-13 18:28:10 -06:00
}
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
}
else
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Spell::EffectJumpDest - unsupported target mode for spell ID %u", m_spellInfo->Id);
[7450] Fixes and improvements in TARGET_BEHIND_VICTIM, SPELL_EFFECT_JUMP2, SPELL_EFFECT_TELEPORT_UNITS work. Author: VladimirMangos
2009-03-13 18:28:10 -06:00
return;
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
float speedXY, speedZ;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
CalculateJumpSpeeds(effIndex, m_caster->GetExactDist2d(x, y), speedXY, speedZ);
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
m_caster->GetMotionMaster()->MoveJump(x, y, z, speedXY, speedZ);
}
void Spell::CalculateJumpSpeeds(uint8 i, float dist, float & speedXY, float & speedZ)
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->EffectMiscValue[i])
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
speedZ = float(m_spellInfo->EffectMiscValue[i])/10;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (m_spellInfo->EffectMiscValueB[i])
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
speedZ = float(m_spellInfo->EffectMiscValueB[i])/10;
else
speedZ = 10.0f;
*Rename SPELL_EFFECT_JUMP2 to SPELL_EFFECT_JUMP_DEST, split the handler of effect from SPELL_EFFECT_JUMP handler
2010-07-19 21:24:09 +02:00
speedXY = dist * 10.0f / speedZ;
[7445] Implement SPELL_EFFECT_JUMP2 used in some jump to target (unit/go/coordinates) spells. Author: VladimirMangos
2009-03-12 14:50:14 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTeleportUnits(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Add virtual bool IsEscorted() to escort_ai.h
2009-10-30 18:54:38 -07:00
if (!unitTarget || unitTarget->isInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fix spells 48129, 60320 & 60321 (Scrolls of Recall I, II & III)
2010-06-20 04:34:58 +02:00
// Pre effects
uint8 uiMaxSafeLevel = 0;
switch (m_spellInfo->Id)
{
case 48129: // Scroll of Recall
uiMaxSafeLevel = 40;
case 60320: // Scroll of Recall II
if (!uiMaxSafeLevel)
uiMaxSafeLevel = 70;
case 60321: // Scroll of Recal III
if (!uiMaxSafeLevel)
uiMaxSafeLevel = 80;
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
Fix spells 48129, 60320 & 60321 (Scrolls of Recall I, II & III)
2010-06-20 04:34:58 +02:00
if (unitTarget->getLevel() > uiMaxSafeLevel)
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
unitTarget->AddAura(60444, unitTarget); //Apply Lost! Aura
Fix spells 48129, 60320 & 60321 (Scrolls of Recall I, II & III)
2010-06-20 04:34:58 +02:00
return;
}
break;
Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM-
2011-01-09 00:00:08 -03:00
case 66550: // teleports outside (Isle of Conquest)
if (Player* pTarget = unitTarget->ToPlayer())
{
if (pTarget->GetTeamId() == TEAM_ALLIANCE)
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_targets.setDst(442.24f, -835.25f, 44.30f, 0.06f, 628);
Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM-
2011-01-09 00:00:08 -03:00
else
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_targets.setDst(1120.43f, -762.11f, 47.92f, 2.94f, 628);
Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM-
2011-01-09 00:00:08 -03:00
}
break;
case 66551: // teleports inside (Isle of Conquest)
if (Player* pTarget = unitTarget->ToPlayer())
{
if (pTarget->GetTeamId() == TEAM_ALLIANCE)
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_targets.setDst(389.57f, -832.38f, 48.65f, 3.00f, 628);
Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM-
2011-01-09 00:00:08 -03:00
else
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_targets.setDst(1174.85f, -763.24f, 48.72f, 6.26f, 628);
Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM-
2011-01-09 00:00:08 -03:00
}
break;
Fix spells 48129, 60320 & 60321 (Scrolls of Recall I, II & III)
2010-06-20 04:34:58 +02:00
}
[svn] Fix teleport spells.
2008-11-01 15:08:12 -05:00
// If not exist data for dest location - return
*Add virtual bool IsEscorted() to escort_ai.h
2009-10-30 18:54:38 -07:00
if (!m_targets.HasDst())
[svn] Fix teleport spells.
2008-11-01 15:08:12 -05:00
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Spell::EffectTeleportUnits - does not have destination for spell ID %u\n", m_spellInfo->Id);
*Fix build.
2009-03-09 19:17:12 -06:00
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix build.
2009-03-09 19:17:12 -06:00
// Init dest coordinates
*More update about positions.
2009-08-29 23:20:16 -05:00
uint32 mapid = m_targets.m_dstPos.GetMapId();
Set proper orientation after being teleported by spell, by Spp. Closes #100
2009-11-07 18:47:11 +01:00
if (mapid == MAPID_INVALID)
*Add virtual bool IsEscorted() to escort_ai.h
2009-10-30 18:54:38 -07:00
mapid = unitTarget->GetMapId();
Set proper orientation after being teleported by spell, by Spp. Closes #100
2009-11-07 18:47:11 +01:00
float x, y, z, orientation;
m_targets.m_dstPos.GetPosition(x, y, z, orientation);
if (!orientation && m_targets.getUnitTarget())
orientation = m_targets.getUnitTarget()->GetOrientation();
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Spell::EffectTeleportUnits - teleport unit to %u %f %f %f %f\n", mapid, x, y, z, orientation);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Set proper orientation after being teleported by spell, by Spp. Closes #100
2009-11-07 18:47:11 +01:00
if (mapid == unitTarget->GetMapId())
[7450] Fixes and improvements in TARGET_BEHIND_VICTIM, SPELL_EFFECT_JUMP2, SPELL_EFFECT_TELEPORT_UNITS work. Author: VladimirMangos
2009-03-13 18:28:10 -06:00
unitTarget->NearTeleportTo(x, y, z, orientation, unitTarget == m_caster);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (unitTarget->GetTypeId() == TYPEID_PLAYER)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->TeleportTo(mapid, x, y, z, orientation, unitTarget == m_caster ? TELE_TO_SPELL : 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update spell selection.
2009-05-02 11:28:11 -05:00
// post effects for TARGET_DST_DB
*Add virtual bool IsEscorted() to escort_ai.h
2009-10-30 18:54:38 -07:00
switch (m_spellInfo->Id)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Dimensional Ripper - Everlook
case 23442:
{
int32 r = irand(0, 119);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (r >= 70) // 7/12 success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (r < 100) // 4/12 evil twin
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 23445, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else // 1/12 fire
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 23449, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
return;
}
// Ultrasafe Transporter: Toshley's Station
case 36941:
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (roll_chance_i(50)) // 50% success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
int32 rand_eff = urand(1, 7);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
switch (rand_eff)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case 1:
// soul split - evil
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36900, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 2:
// soul split - good
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36901, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 3:
// Increase the size
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36895, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 4:
// Decrease the size
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36893, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 5:
// Transform
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_caster->ToPlayer()->GetTeam() == ALLIANCE)
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36897, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36899, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
case 6:
// chicken
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36940, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 7:
// evil twin
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 23445, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
}
return;
}
// Dimensional Ripper - Area 52
case 36890:
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (roll_chance_i(50)) // 50% success
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
int32 rand_eff = urand(1, 4);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
switch (rand_eff)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case 1:
// soul split - evil
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36900, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 2:
// soul split - good
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36901, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 3:
// Increase the size
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36895, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case 4:
Core/ScriptSystem: Extend SpellScript API by spell focus targets accessors.
2010-10-04 20:32:10 +02:00
// Transform
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_caster->ToPlayer()->GetTeam() == ALLIANCE)
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36897, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->CastSpell(m_caster, 36899, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
}
}
return;
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectApplyAura(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Fix crash in Spell::EffectApplyAura.
2010-02-07 18:16:53 +01:00
if (!m_spellAura || !unitTarget)
Update aura system:
2010-01-10 01:23:15 +01:00
return;
*use ASSERT macro instead of regular assert for better output.
2010-07-30 20:04:28 +02:00
ASSERT(unitTarget == m_spellAura->GetOwner());
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
m_spellAura->_ApplyEffectForTargets(effIndex);
Handle spell effects in order from dbcs
2009-05-02 17:43:41 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectApplyAreaAura(SpellEffIndex effIndex)
Handle spell effects in order from dbcs
2009-05-02 17:43:41 +02:00
{
Fix crash in Spell::EffectApplyAura.
2010-02-07 18:16:53 +01:00
if (!m_spellAura || !unitTarget)
Update aura system:
2010-01-10 01:23:15 +01:00
return;
*use ASSERT macro instead of regular assert for better output.
2010-07-30 20:04:28 +02:00
ASSERT (unitTarget == m_spellAura->GetOwner());
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
m_spellAura->_ApplyEffectForTargets(effIndex);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectUnlearnSpecialization(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player *_player = (Player*)unitTarget;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 spellToUnlearn = m_spellInfo->EffectTriggerSpell[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
_player->removeSpell(spellToUnlearn);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Spell: Player %u has unlearned spell %u from NpcGUID: %u", _player->GetGUIDLow(), spellToUnlearn, m_caster->GetGUIDLow());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectPowerDrain(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if (m_spellInfo->EffectMiscValue[effIndex] < 0 || m_spellInfo->EffectMiscValue[effIndex] >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
Powers powerType = Powers(m_spellInfo->EffectMiscValue[effIndex]);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
if (!unitTarget || !unitTarget->isAlive() || unitTarget->getPowerType() != powerType || damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
// add spell damage bonus
damage = m_caster->SpellDamageBonus(unitTarget, m_spellInfo, uint32(damage), SPELL_DIRECT_DAMAGE);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// resilience reduce mana draining effect at spell crit damage reduction (added in 2.4)
*Fix issues with negative dmg of periodic power burn and periodic power leech effects added recently.
2010-08-27 20:51:29 +02:00
int32 power = damage;
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
if (powerType == POWER_MANA)
Implement player's pet resilience, also fix DoT case. by VladimirMangos and thx tali
2009-12-19 18:46:51 +01:00
power -= unitTarget->GetSpellCritDamageReduction(power);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix issues with negative dmg of periodic power burn and periodic power leech effects added recently.
2010-08-27 20:51:29 +02:00
int32 newDamage = -(unitTarget->ModifyPower(powerType, -int32(power)));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
float gainMultiplier = 0.0f;
*Update to Mangos 7059.
2009-01-09 16:06:17 -06:00
// Don`t restore from self drain
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
if (m_caster != unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
gainMultiplier = SpellMgr::CalculateSpellEffectValueMultiplier(m_spellInfo, effIndex, m_originalCaster, this);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
int32 gain = int32(newDamage * gainMultiplier);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
m_caster->EnergizeBySpell(m_caster, m_spellInfo->Id, gain, powerType);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectTakeTargetPower(effIndex, unitTarget, powerType, newDamage, gainMultiplier);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSendEvent(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[7524] Removed commented code in Spell::EffectSendEvent() Author: Triply
2009-03-24 09:37:45 -06:00
/*
we do not handle a flag dropping or clicking on flag in battleground by sendevent system
*/
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Spell ScriptStart %u for spellid %u in EffectSendEvent ", m_spellInfo->EffectMiscValue[effIndex], m_spellInfo->Id);
Fix EffectSendEvent to work if target is GO or Unit.
2010-01-21 23:57:14 +01:00
Object *pTarget;
if (focusObject)
pTarget = focusObject;
else if (unitTarget)
pTarget = unitTarget;
else if (gameObjTarget)
pTarget = gameObjTarget;
else
pTarget = NULL;
Core/ZoneScript: Implemented ProcessEvent function for units.
2011-01-20 12:27:08 -03:00
if (unitTarget)
{
if (ZoneScript* zoneScript = unitTarget->GetZoneScript())
zoneScript->ProcessEvent(unitTarget, m_spellInfo->EffectMiscValue[effIndex]);
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
m_caster->GetMap()->ScriptsStart(sEventScripts, m_spellInfo->EffectMiscValue[effIndex], m_caster, pTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectPowerBurn(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if (m_spellInfo->EffectMiscValue[effIndex] < 0 || m_spellInfo->EffectMiscValue[effIndex] >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
Powers powerType = Powers(m_spellInfo->EffectMiscValue[effIndex]);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
if (!unitTarget || !unitTarget->isAlive() || unitTarget->getPowerType() != powerType || damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7606] Fix use % power burn in effects Author: Lutik
2009-04-03 16:33:25 -06:00
// burn x% of target's mana, up to maximum of 2x% of caster's mana (Mana Burn)
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->ManaCostPercentage)
[7606] Fix use % power burn in effects Author: Lutik
2009-04-03 16:33:25 -06:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
int32 maxDamage = int32(CalculatePctN(m_caster->GetMaxPower(powerType), damage * 2));
damage = int32(CalculatePctN(unitTarget->GetMaxPower(powerType), damage));
*Fix issues with negative dmg of periodic power burn and periodic power leech effects added recently.
2010-08-27 20:51:29 +02:00
damage = std::min(damage, maxDamage);
[7606] Fix use % power burn in effects Author: Lutik
2009-04-03 16:33:25 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Cleanup:
2010-08-26 15:54:56 +06:00
int32 power = damage;
*Fix mana burn.
2009-03-01 14:38:26 +01:00
// resilience reduce mana draining effect at spell crit damage reduction (added in 2.4)
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
if (powerType == POWER_MANA)
Implement player's pet resilience, also fix DoT case. by VladimirMangos and thx tali
2009-12-19 18:46:51 +01:00
power -= unitTarget->GetSpellCritDamageReduction(power);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix issues with negative dmg of periodic power burn and periodic power leech effects added recently.
2010-08-27 20:51:29 +02:00
int32 newDamage = -(unitTarget->ModifyPower(powerType, -power));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
// NO - Not a typo - EffectPowerBurn uses effect value multiplier - not effect damage multiplier
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float dmgMultiplier = SpellMgr::CalculateSpellEffectValueMultiplier(m_spellInfo, effIndex, m_originalCaster, this);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed power burn effects showing mana restored to caster
2010-09-25 15:03:48 +02:00
// add log data before multiplication (need power amount, not damage)
ExecuteLogEffectTakeTargetPower(effIndex, unitTarget, powerType, newDamage, 0.0f);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed power burn effects showing mana restored to caster
2010-09-25 15:03:48 +02:00
newDamage = int32(newDamage * dmgMultiplier);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
*Allow SPELL_EFFECT_POWER_BURN(64) to proc with damage.
2010-08-29 05:26:32 +02:00
m_damage += newDamage;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectHeal(SpellEffIndex /*effIndex*/)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::SpellDamageHeal(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (unitTarget && unitTarget->isAlive() && damage >= 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Try to get original caster
Unit *caster = m_originalCasterGUID ? m_originalCaster : m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Skip if m_originalCaster not available
if (!caster)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 addhealth = damage;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Vessel of the Naaru (Vial of the Sunwell trinket)
if (m_spellInfo->Id == 45064)
{
// Amount of heal - depends from stacked Holy Energy
int damageAmount = 0;
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
if (AuraEffect const * aurEff = m_caster->GetAuraEffect(45062, 0))
{
damageAmount+= aurEff->GetAmount();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->RemoveAurasDueToSpell(45062);
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
addhealth += damageAmount;
}
// Swiftmend - consumes Regrowth or Rejuvenation
* Apply aura SPELL_AURA_ABILITY_IGNORE_AURASTATE for damage bonuses.
2009-03-18 19:53:36 +01:00
else if (m_spellInfo->TargetAuraState == AURA_STATE_SWIFTMEND && unitTarget->HasAuraState(AURA_STATE_SWIFTMEND, m_spellInfo, m_caster))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraEffectList const& RejorRegr = unitTarget->GetAuraEffectsByType(SPELL_AURA_PERIODIC_HEAL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// find most short by duration
*Update of aura system.
2009-04-06 13:31:14 +02:00
AuraEffect *targetAura = NULL;
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (Unit::AuraEffectList::const_iterator i = RejorRegr.begin(); i != RejorRegr.end(); ++i)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if ((*i)->GetSpellProto()->SpellFamilyName == SPELLFAMILY_DRUID
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
&& (*i)->GetSpellProto()->SpellFamilyFlags[0] & 0x50)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!targetAura || (*i)->GetBase()->GetDuration() < targetAura->GetBase()->GetDuration())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
targetAura = *i;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!targetAura)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Target(GUID:" UI64FMTD ") has aurastate AURA_STATE_SWIFTMEND but no matching aura.", unitTarget->GetGUID());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update of aura system.
2009-04-06 13:31:14 +02:00
int32 tickheal = targetAura->GetAmount();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Unit* auraCaster = targetAura->GetCaster())
*Update to Mangos 7200.
2009-01-29 19:33:39 -06:00
tickheal = auraCaster->SpellHealingBonus(unitTarget, targetAura->GetSpellProto(), tickheal, DOT);
*Fix swiftmend healing bonus. By mobel.
2008-12-13 10:12:22 -06:00
//int32 tickheal = targetAura->GetSpellProto()->EffectBasePoints[idx] + 1;
//It is said that talent bonus should not be included
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Replaced wrong calculation of tickcount in swiftmend with consts - by Anubisss
2009-03-01 21:51:38 +01:00
int32 tickcount = 0;
*Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
2009-08-08 16:18:05 +02:00
// Rejuvenation
if (targetAura->GetSpellProto()->SpellFamilyFlags[0] & 0x10)
tickcount = 4;
// Regrowth
else // if (targetAura->GetSpellProto()->SpellFamilyFlags[0] & 0x40)
tickcount = 6;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
addhealth += tickheal * tickcount;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Add a check for Glyph of Swiftmend in Swiftmend code.
2009-04-06 18:00:16 +02:00
// Glyph of Swiftmend
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!caster->HasAura(54824))
*Add a check for Glyph of Swiftmend in Swiftmend code.
2009-04-06 18:00:16 +02:00
unitTarget->RemoveAura(targetAura->GetId(), targetAura->GetCasterGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix swiftmend healing bonus. By mobel.
2008-12-13 10:12:22 -06:00
//addhealth += tickheal * tickcount;
Add spaces after commas
2011-04-29 20:47:02 +02:00
//addhealth = caster->SpellHealingBonus(m_spellInfo, addhealth, HEAL, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Restore some commits from trinitycore2 3.1.3
2009-12-17 13:07:38 +01:00
// Glyph of Nourish
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_DRUID && m_spellInfo->SpellFamilyFlags[1] & 0x2000000)
{
addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);
if (AuraEffect const* aurEff = m_caster->GetAuraEffect(62971, 0))
{
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraEffectList const& Periodic = unitTarget->GetAuraEffectsByType(SPELL_AURA_PERIODIC_HEAL);
Restore some commits from trinitycore2 3.1.3
2009-12-17 13:07:38 +01:00
for (Unit::AuraEffectList::const_iterator i = Periodic.begin(); i != Periodic.end(); ++i)
{
if (m_caster->GetGUID() == (*i)->GetCasterGUID())
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(addhealth, aurEff->GetAmount());
Restore some commits from trinitycore2 3.1.3
2009-12-17 13:07:38 +01:00
}
}
}
Fixed spellpower coef for Lifebloom final heal
2010-07-28 12:57:00 +02:00
// Lifebloom - final heal coef multiplied by original DoT stack
else if (m_spellInfo->Id == 33778)
addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL, m_spellValue->EffectBasePoints[1]);
*Fix Riptide.
2009-04-10 16:59:34 +02:00
// Riptide - increase healing done by Chain Heal
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_SHAMAN && m_spellInfo->SpellFamilyFlags[0] & 0x100)
*Fix Riptide.
2009-04-10 16:59:34 +02:00
{
Implement attribute flag SPELL_ATTR_EX2_TRIGGERED_CAN_TRIGGER, fix improved fire nova totem.
2009-04-20 12:38:35 +02:00
addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);
Update aura system:
2010-01-10 01:23:15 +01:00
if (AuraEffect * aurEff = unitTarget->GetAuraEffect(SPELL_AURA_PERIODIC_HEAL, SPELLFAMILY_SHAMAN, 0, 0, 0x10, m_originalCasterGUID))
*Fix Riptide.
2009-04-10 16:59:34 +02:00
{
Core/Game: fix all warnings related to converting doubles and floats.
2010-08-22 12:39:39 -07:00
addhealth = int32(addhealth * 1.25f);
*Fix Riptide.
2009-04-10 16:59:34 +02:00
// consume aura
Update aura system:
2010-01-10 01:23:15 +01:00
unitTarget->RemoveAura(aurEff->GetBase());
*Fix Riptide.
2009-04-10 16:59:34 +02:00
}
}
*Fix Death Pact and Corpse Explosion - original patch by Astellar, thanks for help in conversion for Azrael.
2009-06-22 23:30:17 +02:00
// Death Pact - return pct of max health to caster
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_DEATHKNIGHT && m_spellInfo->SpellFamilyFlags[0] & 0x00080000)
Core:
2010-08-26 01:20:57 +06:00
addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, int32(caster->CountPctFromMaxHealth(damage)), HEAL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
*Update to Mangos 7200.
2009-01-29 19:33:39 -06:00
addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fix Grievious bite (48920): now if removed when target is fully healed
2010-06-20 00:37:02 +02:00
// Remove Grievious bite if fully healed
if (unitTarget->HasAura(48920) && (unitTarget->GetHealth() + addhealth >= unitTarget->GetMaxHealth()))
unitTarget->RemoveAura(48920);
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
m_damage -= addhealth;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectHealPct(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
if (!unitTarget || !unitTarget->isAlive() || damage < 0)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
// Skip if m_originalCaster not available
if (!m_originalCaster)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
// Rune Tap - Party
if (m_spellInfo->Id == 59754 && unitTarget == m_caster)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
m_healing += m_originalCaster->SpellHealingBonus(unitTarget, m_spellInfo, unitTarget->CountPctFromMaxHealth(damage), HEAL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectHealMechanical(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
if (!unitTarget || !unitTarget->isAlive() || damage < 0)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
// Skip if m_originalCaster not available
if (!m_originalCaster)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
m_healing += m_originalCaster->SpellHealingBonus(unitTarget, m_spellInfo, uint32(damage), HEAL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectHealthLeech(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix usage of EffectValueMultiplier in spell code.
2010-08-26 19:07:55 +02:00
if (!unitTarget || !unitTarget->isAlive() || damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed damage from warlock's Death Coil
2011-05-10 22:28:28 +07:00
damage = m_caster->SpellDamageBonus(unitTarget, m_spellInfo, uint32(damage), SPELL_DIRECT_DAMAGE);
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "HealthLeech :%i", damage);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float healMultiplier = SpellMgr::CalculateSpellEffectValueMultiplier(m_spellInfo, effIndex, m_originalCaster, this);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed Health Leech effect, should not apply healing multiplier to damage done
2010-09-02 15:34:36 +02:00
m_damage += damage;
// get max possible damage, don't count overkill for heal
uint32 healthGain = uint32(-unitTarget->GetHealthGain(-damage) * healMultiplier);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Fixed Health Leech effect, should not apply healing multiplier to damage done
2010-09-02 15:34:36 +02:00
healthGain = m_caster->SpellHealingBonus(m_caster, m_spellInfo, healthGain, HEAL);
m_caster->HealBySpell(m_caster, m_spellInfo, uint32(healthGain));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Remove LOTS of compile warnings
2010-04-19 09:26:37 +02:00
void Spell::DoCreateItem(uint32 /*i*/, uint32 itemtype)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* player = (Player*)unitTarget;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 newitemid = itemtype;
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
ItemTemplate const *pProto = sObjectMgr->GetItemTemplate(newitemid);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pProto)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
player->SendEquipError(EQUIP_ERR_ITEM_NOT_FOUND, NULL, NULL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8344] In case battleground reward items player must "receive" instead "create" item in message. Author: VladimirMangos
2009-08-12 20:36:55 -05:00
// bg reward have some special in code work
uint32 bgType = 0;
switch(m_spellInfo->Id)
{
case SPELL_AV_MARK_WINNER:
case SPELL_AV_MARK_LOSER:
bgType = BATTLEGROUND_AV;
break;
case SPELL_WS_MARK_WINNER:
case SPELL_WS_MARK_LOSER:
bgType = BATTLEGROUND_WS;
break;
case SPELL_AB_MARK_WINNER:
case SPELL_AB_MARK_LOSER:
bgType = BATTLEGROUND_AB;
break;
default:
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Drop old item amount calculation. by Vladimir
2010-04-14 12:22:35 +04:00
uint32 num_to_add = damage;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (num_to_add < 1)
num_to_add = 1;
[7015] Implement support -1 in item_template.stackable and item_template.maxcount fields. By VladimirMangos.
2009-01-03 11:06:51 -06:00
if (num_to_add > pProto->GetMaxStackSize())
num_to_add = pProto->GetMaxStackSize();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// init items_count to 1, since 1 item will be created regardless of specialization
int items_count=1;
// the chance to create additional items
float additionalCreateChance=0.0f;
// the maximum number of created additional items
uint8 additionalMaxNum=0;
// get the chance and maximum number for creating extra items
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (canCreateExtraItems(player, m_spellInfo->Id, additionalCreateChance, additionalMaxNum))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// roll with this chance till we roll not to create or we create the max num
Code Style (game + scripts only):
2010-04-07 23:56:35 +02:00
while (roll_chance_f(additionalCreateChance) && items_count <= additionalMaxNum)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
++items_count;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// really will be created more items
num_to_add *= items_count;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// can the player store the new item?
ItemPosCountVec dest;
uint32 no_space = 0;
Core: use enum InventoryResult as return type for functions working with player items.
2011-04-29 16:48:15 +06:00
InventoryResult msg = player->CanStoreNewItem(NULL_BAG, NULL_SLOT, dest, newitemid, num_to_add, &no_space);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (msg != EQUIP_ERR_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// convert to possible store amount
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (msg == EQUIP_ERR_INVENTORY_FULL || msg == EQUIP_ERR_CANT_CARRY_MORE_OF_THIS)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
num_to_add -= no_space;
else
{
// if not created by another reason from full inventory or unique items amount limitation
* Implement item limit category (based on changes by VladimirMangos)
2010-08-05 22:08:07 +06:00
player->SendEquipError(msg, NULL, NULL, newitemid);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (num_to_add)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// create the new item and store it
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
Item* pItem = player->StoreNewItem(dest, newitemid, true, Item::GenerateItemRandomPropertyId(newitemid));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// was it successful? return error if not
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
player->SendEquipError(EQUIP_ERR_ITEM_NOT_FOUND, NULL, NULL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// set the "Crafted by ..." property of the item
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
if (pItem->GetTemplate()->Class != ITEM_CLASS_CONSUMABLE && pItem->GetTemplate()->Class != ITEM_CLASS_QUEST && newitemid != 6265 && newitemid != 6948)
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
pItem->SetUInt32Value(ITEM_FIELD_CREATOR, player->GetGUIDLow());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// send info to the client
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (pItem)
[8344] In case battleground reward items player must "receive" instead "create" item in message. Author: VladimirMangos
2009-08-12 20:36:55 -05:00
player->SendNewItem(pItem, num_to_add, true, bgType == 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// we succeeded in creating at least one item, so a levelup is possible
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (bgType == 0)
[8344] In case battleground reward items player must "receive" instead "create" item in message. Author: VladimirMangos
2009-08-12 20:36:55 -05:00
player->UpdateCraftSkill(m_spellInfo->Id);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8344] In case battleground reward items player must "receive" instead "create" item in message. Author: VladimirMangos
2009-08-12 20:36:55 -05:00
/*
// for battleground marks send by mail if not add all expected
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (no_space > 0 && bgType)
[8344] In case battleground reward items player must "receive" instead "create" item in message. Author: VladimirMangos
2009-08-12 20:36:55 -05:00
{
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (Battleground* bg = sBattlegroundMgr->GetBattlegroundTemplate(BattlegroundTypeId(bgType)))
[8344] In case battleground reward items player must "receive" instead "create" item in message. Author: VladimirMangos
2009-08-12 20:36:55 -05:00
bg->SendRewardMarkByMail(player, newitemid, no_space);
* Trailing whitespace removed.
2009-04-06 21:14:51 +02:00
}
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
*/
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectCreateItem(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
DoCreateItem(effIndex, m_spellInfo->EffectItemType[effIndex]);
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectCreateItem(effIndex, m_spellInfo->EffectItemType[effIndex]);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectCreateItem2(SpellEffIndex effIndex)
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[7881] More types with random generated item at recipe casting. Cleanups code. Author: VladimirMangos
2009-05-24 11:17:41 -05:00
return;
Player* player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 item_id = m_spellInfo->EffectItemType[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
if (item_id)
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
DoCreateItem(effIndex, item_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7881] More types with random generated item at recipe casting. Cleanups code. Author: VladimirMangos
2009-05-24 11:17:41 -05:00
// special case: fake item replaced by generate using spell_loot_template
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (IsLootCraftingSpell(m_spellInfo))
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
{
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
if (item_id)
{
if (!player->HasItemCount(item_id, 1))
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
// remove reagent
uint32 count = 1;
player->DestroyItemCount(item_id, count, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code. by Vladimir.
2010-04-11 11:24:05 +04:00
// create some random items
player->AutoStoreLoot(m_spellInfo->Id, LootTemplates_Spell);
Fixed spells with EffectCreateItem2 that do not have EffectItemType set in dbc and should pick it from spell_loot_template table (like 69412 Abyssal Shatter)
2010-06-16 20:10:42 +02:00
}
else
player->AutoStoreLoot(m_spellInfo->Id, LootTemplates_Spell); // create some random items
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
}
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
// TODO: ExecuteLogEffectCreateItem(i, m_spellInfo->EffectItemType[i]);
Use spell_loot_table for item creating in case SPELL_EFFECT_CREATE_ITEM_2 (157) and itemType==0. Author: VladimirMangos
2009-02-05 23:02:07 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectCreateRandomItem(SpellEffIndex /*effIndex*/)
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
return;
Player* player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
// create some random items
player->AutoStoreLoot(m_spellInfo->Id, LootTemplates_Spell);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
// TODO: ExecuteLogEffectCreateItem(i, m_spellInfo->EffectItemType[i]);
[8069] Fixed copy/paste mistake in achievement error output. Author: Saeba
2009-06-23 14:44:16 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectPersistentAA(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
if (!m_spellAura)
*Use one dynobj to handle multiple aura effects.
2009-08-27 16:41:10 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float radius = GetSpellRadiusForFriend(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[effIndex]));
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Player* modOwner = m_originalCaster->GetSpellModOwner())
Update aura system:
2010-01-10 01:23:15 +01:00
modOwner->ApplySpellMod(m_spellInfo->Id, SPELLMOD_RADIUS, radius);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update aura system:
2010-01-10 01:23:15 +01:00
Unit *caster = m_caster->GetEntry() == WORLD_TRIGGER ? m_originalCaster : m_caster;
Do not allow units that are not in world to create dynamic objects from spell effect handlers
2010-01-24 23:47:17 +01:00
// Caster not in world, might be spell triggered from aura removal
if (!caster->IsInWorld())
return;
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
DynamicObject* dynObj = new DynamicObject();
if (!dynObj->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_DYNAMICOBJECT), caster, m_spellInfo->Id, m_targets.m_dstPos, radius, false, DYNAMIC_OBJECT_AREA_SPELL))
Update aura system:
2010-01-10 01:23:15 +01:00
{
delete dynObj;
return;
}
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
Update aura system:
2010-01-10 01:23:15 +01:00
dynObj->GetMap()->Add(dynObj);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
if (Aura* aura = Aura::TryCreate(m_spellInfo, dynObj, caster, &m_spellValue->EffectBasePoints[0]))
Core/DynamicObjects: Change the way how dynamic objects are bound to their owners, fixes some crashes in Aura::GetOwner.
2011-02-04 00:27:43 +01:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
m_spellAura = aura;
Core/DynamicObjects: Change the way how dynamic objects are bound to their owners, fixes some crashes in Aura::GetOwner.
2011-02-04 00:27:43 +01:00
m_spellAura->_RegisterForTargets();
}
Update aura system:
2010-01-10 01:23:15 +01:00
else
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
*use ASSERT macro instead of regular assert for better output.
2010-07-30 20:04:28 +02:00
ASSERT(m_spellAura->GetDynobjOwner());
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
m_spellAura->_ApplyEffectForTargets(effIndex);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectEnergize(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if (m_spellInfo->EffectMiscValue[effIndex] < 0 || m_spellInfo->EffectMiscValue[effIndex] >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
Powers power = Powers(m_spellInfo->EffectMiscValue[effIndex]);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Some level depends spells
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
int level_multiplier = 0;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int level_diff = 0;
switch (m_spellInfo->Id)
{
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
case 9512: // Restore Energy
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
level_diff = m_caster->getLevel() - 40;
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
level_multiplier = 2;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
case 24571: // Blood Fury
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
level_diff = m_caster->getLevel() - 60;
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
level_multiplier = 10;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
case 24532: // Burst of Energy
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
level_diff = m_caster->getLevel() - 60;
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
level_multiplier = 4;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
case 31930: // Judgements of the Wise
case 63375: // Improved Stormstrike
restore work Glyph of Seal of Command
2009-12-18 11:28:12 +02:00
case 68082: // Glyph of Seal of Command
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
damage = int32(CalculatePctN(unitTarget->GetCreateMana(), damage));
*Fix a typo in Spell::EffectEnergize.
2009-08-13 14:36:50 +02:00
break;
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
case 48542: // Revitalize
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
damage = int32(CalculatePctN(unitTarget->GetMaxPower(power), damage));
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
break;
Core/Spells: Fixed Glyph of Shadow Word: Pain
2011-03-07 19:15:00 +01:00
case 71132: // Glyph of Shadow Word: Pain
damage = int32(CalculatePctN(unitTarget->GetCreateMana(), 1)); // set 1 as value, missing in dbc
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (level_diff > 0)
[8266] Move percent spells with flat energize effect spells to effect code. Author: VladimirMangos
2009-07-31 11:16:38 +08:00
damage -= level_multiplier * level_diff;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetMaxPower(power) == 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Add function EnergizeBySpell. Author: nos4r2zod
2009-06-14 10:16:55 -05:00
m_caster->EnergizeBySpell(unitTarget, m_spellInfo->Id, damage, power);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Mad Alchemist's Potion
Removed stupid/not needed file Spellid.h.
2010-02-15 18:23:39 +01:00
if (m_spellInfo->Id == 45051)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// find elixirs on target
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
bool guardianFound = false;
bool battleFound = false;
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraApplicationMap& Auras = unitTarget->GetAppliedAuras();
for (Unit::AuraApplicationMap::iterator itr = Auras.begin(); itr != Auras.end(); ++itr)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
uint32 spell_id = itr->second->GetBase()->GetId();
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
if (!guardianFound)
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (sSpellMgr->IsSpellMemberOfSpellGroup(spell_id, SPELL_GROUP_ELIXIR_GUARDIAN))
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
guardianFound = true;
if (!battleFound)
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (sSpellMgr->IsSpellMemberOfSpellGroup(spell_id, SPELL_GROUP_ELIXIR_BATTLE))
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
battleFound = true;
if (battleFound && guardianFound)
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// get all available elixirs by mask and spell level
*Drop spell_stack_masks table
2010-02-02 22:35:01 +01:00
std::set<uint32> avalibleElixirs;
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
if (!guardianFound)
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
sSpellMgr->GetSetOfSpellsInSpellGroup(SPELL_GROUP_ELIXIR_GUARDIAN, avalibleElixirs);
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
if (!battleFound)
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
sSpellMgr->GetSetOfSpellsInSpellGroup(SPELL_GROUP_ELIXIR_BATTLE, avalibleElixirs);
*Drop spell_stack_masks table
2010-02-02 22:35:01 +01:00
for (std::set<uint32>::iterator itr = avalibleElixirs.begin(); itr != avalibleElixirs.end() ;)
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
{
*Drop spell_stack_masks table
2010-02-02 22:35:01 +01:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(*itr);
if (spellInfo->spellLevel < m_spellInfo->spellLevel || spellInfo->spellLevel > unitTarget->getLevel())
avalibleElixirs.erase(itr++);
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
else if (sSpellMgr->IsSpellMemberOfSpellGroup(*itr, SPELL_GROUP_ELIXIR_SHATTRATH))
*Drop spell_stack_masks table
2010-02-02 22:35:01 +01:00
avalibleElixirs.erase(itr++);
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
else if (sSpellMgr->IsSpellMemberOfSpellGroup(*itr, SPELL_GROUP_ELIXIR_UNSTABLE))
*Drop spell_stack_masks table
2010-02-02 22:35:01 +01:00
avalibleElixirs.erase(itr++);
else
++itr;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
if (!avalibleElixirs.empty())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// cast random elixir on target
Add spaces after commas
2011-04-29 20:47:02 +02:00
uint32 rand_spell = urand(0, avalibleElixirs.size()-1);
*Drop spell_stack_masks table
2010-02-02 22:35:01 +01:00
std::set<uint32>::iterator itr = avalibleElixirs.begin();
*drop spell_elixir table
2010-02-01 19:22:32 +01:00
std::advance(itr, rand_spell);
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->CastSpell(unitTarget, *itr, true, m_CastItem);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectEnergizePct(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if (m_spellInfo->EffectMiscValue[effIndex] < 0 || m_spellInfo->EffectMiscValue[effIndex] >= int8(MAX_POWERS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
Powers power = Powers(m_spellInfo->EffectMiscValue[effIndex]);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 maxPower = unitTarget->GetMaxPower(power);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (maxPower == 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
uint32 gain = CalculatePctN(maxPower, damage);
*Add function EnergizeBySpell. Author: nos4r2zod
2009-06-14 10:16:55 -05:00
m_caster->EnergizeBySpell(unitTarget, m_spellInfo->Id, gain, power);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
void Spell::SendLoot(uint64 guid, LootType loottype)
{
Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
2010-12-26 16:35:29 +01:00
Player* player = m_caster->ToPlayer();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!player)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (gameObjTarget)
{
Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation.
2011-01-18 20:02:28 +01:00
// Players shouldn't be able to loot gameobjects that are currently despawned
Core/Spells: Better solution for exploit check (Thanks to manuel)
2011-01-20 03:06:51 +01:00
if (!gameObjTarget->isSpawned() && !player->isGameMaster())
Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation.
2011-01-18 20:02:28 +01:00
{
sLog->outError("Possible hacking attempt: Player %s [guid: %u] tried to loot a gameobject [entry: %u id: %u] which is on respawn time without being in GM mode!",
player->GetName(), player->GetGUIDLow(), gameObjTarget->GetEntry(), gameObjTarget->GetGUIDLow());
return;
}
Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
2010-12-26 16:35:29 +01:00
// special case, already has GossipHello inside so return and avoid calling twice
if (gameObjTarget->GetGoType() == GAMEOBJECT_TYPE_GOOBER)
{
gameObjTarget->Use(m_caster);
return;
}
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (sScriptMgr->OnGossipHello(player, gameObjTarget))
*Update to Mangos 6880. Source: Mangos.
2008-12-06 14:01:44 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/AI: implemented SmartScripts System (still beta) not 100% complete
2010-10-27 21:01:47 +02:00
gameObjTarget->AI()->GossipHello(player);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
switch (gameObjTarget->GetGoType())
{
case GAMEOBJECT_TYPE_DOOR:
case GAMEOBJECT_TYPE_BUTTON:
gameObjTarget->UseDoorOrButton();
[8252] Move DB scripting code from global World to Map. Author: Ambal
2009-07-31 10:48:34 +08:00
player->GetMap()->ScriptsStart(sGameObjectScripts, gameObjTarget->GetDBTableGUIDLow(), player, gameObjTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_QUESTGIVER:
// start or end quest
player->PrepareQuestMenu(guid);
player->SendPreparedQuest(guid);
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_SPELL_FOCUS:
// triggering linked GO
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint32 trapEntry = gameObjTarget->GetGOInfo()->spellFocus.linkedTrapId)
Add spaces after commas
2011-04-29 20:47:02 +02:00
gameObjTarget->TriggeringLinkedGameObject(trapEntry, m_caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_CHEST:
// TODO: possible must be moved to loot release (in different from linked triggering)
if (gameObjTarget->GetGOInfo()->chest.eventId)
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Chest ScriptStart id %u for GO %u", gameObjTarget->GetGOInfo()->chest.eventId, gameObjTarget->GetDBTableGUIDLow());
[8252] Move DB scripting code from global World to Map. Author: Ambal
2009-07-31 10:48:34 +08:00
player->GetMap()->ScriptsStart(sEventScripts, gameObjTarget->GetGOInfo()->chest.eventId, player, gameObjTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// triggering linked GO
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint32 trapEntry = gameObjTarget->GetGOInfo()->chest.linkedTrapId)
Add spaces after commas
2011-04-29 20:47:02 +02:00
gameObjTarget->TriggeringLinkedGameObject(trapEntry, m_caster);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Don't return, let loots been taken
[7745] Fixed gcc warnings. Author: AlexDereka
2009-05-03 22:21:46 -05:00
default:
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Send loot
player->SendLoot(guid, loottype);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectOpenLock(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Small cleanup in SpellEffects, spells always have caster
2010-12-22 20:18:34 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "WORLD: Open Lock - No Player Caster!");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 lockId = 0;
uint64 guid = 0;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Get lockId
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (gameObjTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/ObjectMgr: Refactor sGOStorage
2011-04-28 22:54:30 +02:00
GameObjectTemplate const* goInfo = gameObjTarget->GetGOInfo();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Arathi Basin banner opening !
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if ((goInfo->type == GAMEOBJECT_TYPE_BUTTON && goInfo->button.noDamageImmune) ||
(goInfo->type == GAMEOBJECT_TYPE_GOOBER && goInfo->goober.losOK))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
//CanUseBattlegroundObject() already called in CheckCast()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// in battleground check
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
if (Battleground *bg = player->GetBattleground())
*(awe)some changes to triggering spell/aura effects:
2010-02-20 23:57:54 +01:00
{
bg->EventPlayerClickedOnFlag(player, gameObjTarget);
return;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
else if (goInfo->type == GAMEOBJECT_TYPE_FLAGSTAND)
{
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
//CanUseBattlegroundObject() already called in CheckCast()
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// in battleground check
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
if (Battleground *bg = player->GetBattleground())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add support for random battlegrounds - port by n0n4me, original code by Vladimir and Griffonheart (Big thanks to all of you!)
2010-05-26 11:34:37 +02:00
if (bg->GetTypeID(true) == BATTLEGROUND_EY)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
bg->EventPlayerClickedOnFlag(player, gameObjTarget);
return;
}
Fixed checks for Disarm Trap, thanks to Spp.
2010-05-23 22:17:01 -03:00
}else if (m_spellInfo->Id == 1842 && gameObjTarget->GetGOInfo()->type == GAMEOBJECT_TYPE_TRAP && gameObjTarget->GetOwner())
Support for spell Disarm Trap.
2010-03-26 22:04:38 -03:00
{
Removed tabs
2010-05-23 18:20:10 -03:00
gameObjTarget->SetLootState(GO_JUST_DEACTIVATED);
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Cleanup, proper indentation, and remove some wrong/irrelevant comments copied from custom patches..
2009-12-18 13:41:30 -08:00
// TODO: Add script for spell 41920 - Filling, becouse server it freze when use this spell
[svn] * Merge Temp dev SVN with Assembla.
2008-10-14 11:57:03 -05:00
// handle outdoor pvp object opening, return true if go was registered for handling
// these objects must have been spawned by outdoorpvp!
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
else if (gameObjTarget->GetGOInfo()->type == GAMEOBJECT_TYPE_GOOBER && sOutdoorPvPMgr->HandleOpenGo(player, gameObjTarget->GetGUID()))
[svn] * Merge Temp dev SVN with Assembla.
2008-10-14 11:57:03 -05:00
return;
[8183] Some gameobject despanw related fixes Author: VladimirMangos
2009-07-16 12:06:07 +08:00
lockId = goInfo->GetLockId();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
guid = gameObjTarget->GetGUID();
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (itemTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
lockId = itemTarget->GetTemplate()->LockID;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
guid = itemTarget->GetGUID();
}
else
{
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "WORLD: Open Lock - No GameObject/Item Target!");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
SkillType skillId = SKILL_NONE;
int32 reqSkillValue = 0;
int32 skillValue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
SpellCastResult res = CanOpenLock(effIndex, lockId, skillId, reqSkillValue, skillValue);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (res != SPELL_CAST_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
SendCastResult(res);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Cleaned up item flags: separated item proto flags and item field flags
2010-08-04 10:34:30 +02:00
if (gameObjTarget)
SendLoot(guid, LOOT_SKINNING);
else
itemTarget->SetFlag(ITEM_FIELD_FLAGS, ITEM_FLAG_UNLOCKED);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Use SpellCastResult and finaly fix SPELL_CAST_OK value (255 custom value now). By VladimirMangos.
2009-03-16 12:00:14 -06:00
// not allow use skill grow at item base open
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_CastItem && skillId != SKILL_NONE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
// update skill if really known
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint32 pureSkillValue = player->GetPureSkillValue(skillId))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (gameObjTarget)
Replace hack code in Spell::EffectOpenLock by generic way for check lock key items/skills
2009-03-15 17:18:59 -06:00
{
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
// Allow one skill-up until respawned
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!gameObjTarget->IsInSkillupList(player->GetGUIDLow()) &&
player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue))
gameObjTarget->AddToSkillupList(player->GetGUIDLow());
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (itemTarget)
[7464] Move check of spell using for lock open to single function. Remove more hacks. Author: VladimirMangos
2009-03-15 17:54:24 -06:00
{
// Do one skill-up
player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue);
Replace hack code in Spell::EffectOpenLock by generic way for check lock key items/skills
2009-03-15 17:18:59 -06:00
}
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
ExecuteLogEffectOpenLock(effIndex, gameObjTarget ? (Object*)gameObjTarget : (Object*)itemTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSummonChangeItem(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player *player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// applied only to using item
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (!m_CastItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// ... only to item in own inventory/bank/equip_slot
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_CastItem->GetOwnerGUID() != player->GetGUID())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 newitemid = m_spellInfo->EffectItemType[effIndex];
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (!newitemid)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint16 pos = m_CastItem->GetPos();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
Item *pNewItem = Item::CreateItem(newitemid, 1, player);
if (!pNewItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
for (uint8 j = PERM_ENCHANTMENT_SLOT; j <= TEMP_ENCHANTMENT_SLOT; ++j)
if (m_CastItem->GetEnchantmentId(EnchantmentSlot(j)))
[7716] Fixed some typos and possible crashes. Author: AlexDereka
2009-04-27 18:42:35 -05:00
pNewItem->SetEnchantment(EnchantmentSlot(j), m_CastItem->GetEnchantmentId(EnchantmentSlot(j)), m_CastItem->GetEnchantmentDuration(EnchantmentSlot(j)), m_CastItem->GetEnchantmentCharges(EnchantmentSlot(j)));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_CastItem->GetUInt32Value(ITEM_FIELD_DURABILITY) < m_CastItem->GetUInt32Value(ITEM_FIELD_MAXDURABILITY))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Misc: Some engrish fixes, thanks to ZxBiohazardZx, closes issue 4740
2010-11-14 23:46:34 +02:00
double lossPercent = 1 - m_CastItem->GetUInt32Value(ITEM_FIELD_DURABILITY) / double(m_CastItem->GetUInt32Value(ITEM_FIELD_MAXDURABILITY));
player->DurabilityLoss(pNewItem, lossPercent);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (player->IsInventoryPos(pos))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
ItemPosCountVec dest;
Core: use enum InventoryResult as return type for functions working with player items.
2011-04-29 16:48:15 +06:00
InventoryResult msg = player->CanStoreItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), dest, pNewItem, true);
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (msg == EQUIP_ERR_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
player->DestroyItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent crash at access and unexpected charges counting with item update queue corrupt
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_CastItem == m_targets.getItemTarget())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_targets.setItemTarget(NULL);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_CastItem = NULL;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->StoreItem(dest, pNewItem, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
else if (player->IsBankPos(pos))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
ItemPosCountVec dest;
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
uint8 msg = player->CanBankItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), dest, pNewItem, true);
if (msg == EQUIP_ERR_OK)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
player->DestroyItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent crash at access and unexpected charges counting with item update queue corrupt
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_CastItem == m_targets.getItemTarget())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_targets.setItemTarget(NULL);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_CastItem = NULL;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->BankItem(dest, pNewItem, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
else if (player->IsEquipmentPos(pos))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint16 dest;
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->DestroyItem(m_CastItem->GetBagSlot(), m_CastItem->GetSlot(), true);
uint8 msg = player->CanEquipItem(m_CastItem->GetSlot(), dest, pNewItem, true);
if (msg == EQUIP_ERR_OK || msg == EQUIP_ERR_CANT_DO_RIGHT_NOW)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (msg == EQUIP_ERR_CANT_DO_RIGHT_NOW) dest = EQUIPMENT_SLOT_MAINHAND;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent crash at access and unexpected charges counting with item update queue corrupt
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
if (m_CastItem == m_targets.getItemTarget())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_targets.setItemTarget(NULL);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_CastItem = NULL;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
player->EquipItem(dest, pNewItem, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
player->AutoUnequipOffhandIfNeed();
return;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// fail
delete pNewItem;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectProficiency(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Player *p_target = (Player*)unitTarget;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 subClassMask = m_spellInfo->EquippedItemSubClassMask;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->EquippedItemClass == ITEM_CLASS_WEAPON && !(p_target->GetWeaponProficiency() & subClassMask))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
p_target->AddWeaponProficiency(subClassMask);
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
p_target->SendProficiency(ITEM_CLASS_WEAPON, p_target->GetWeaponProficiency());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->EquippedItemClass == ITEM_CLASS_ARMOR && !(p_target->GetArmorProficiency() & subClassMask))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
p_target->AddArmorProficiency(subClassMask);
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
p_target->SendProficiency(ITEM_CLASS_ARMOR, p_target->GetArmorProficiency());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSummonType(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 entry = m_spellInfo->EffectMiscValue[effIndex];
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!entry)
*More work on summon system.
2009-03-20 14:01:46 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
SummonPropertiesEntry const *properties = sSummonPropertiesStore.LookupEntry(m_spellInfo->EffectMiscValueB[effIndex]);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!properties)
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("EffectSummonType: Unhandled summon type %u", m_spellInfo->EffectMiscValueB[effIndex]);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!m_originalCaster)
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
int32 duration = GetSpellDuration(m_spellInfo);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (Player* modOwner = m_originalCaster->GetSpellModOwner())
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
modOwner->ApplySpellMod(m_spellInfo->Id, SPELLMOD_DURATION, duration);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make position as a class;
2009-08-29 14:58:45 -05:00
Position pos;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
GetSummonPosition(effIndex, pos);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
TempSummon *summon = NULL;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
switch (properties->Category)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
case SUMMON_CATEGORY_WILD:
case SUMMON_CATEGORY_ALLY:
Core/Spells: Cast proper vehicle spells on vehicle summon
2011-04-24 10:22:58 +02:00
case SUMMON_CATEGORY_UNK:
*Implement Aura Type 247 (SPELL_AURA_CLONE_CASTER) and 279 (SPELL_AURA_INITIALIZE_IMAGES)
2009-07-22 17:10:30 +02:00
if (properties->Flags & 512)
*Fix a typo breaking some summon types.
2009-07-22 20:22:36 +02:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
SummonGuardian(effIndex, entry, properties);
*Implement Aura Type 247 (SPELL_AURA_CLONE_CASTER) and 279 (SPELL_AURA_INITIALIZE_IMAGES)
2009-07-22 17:10:30 +02:00
break;
*Fix a typo breaking some summon types.
2009-07-22 20:22:36 +02:00
}
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
switch (properties->Type)
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
{
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
case SUMMON_TYPE_PET:
case SUMMON_TYPE_GUARDIAN:
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
case SUMMON_TYPE_GUARDIAN2:
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
case SUMMON_TYPE_MINION:
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
SummonGuardian(effIndex, entry, properties);
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
break;
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
// Summons a vehicle, but doesn't force anyone to enter it (see SUMMON_CATEGORY_VEHICLE)
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
case SUMMON_TYPE_VEHICLE:
*Fix some bugs about vehicle.
2009-04-22 17:50:26 -05:00
case SUMMON_TYPE_VEHICLE2:
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
summon = m_caster->GetMap()->SummonCreature(entry, pos, properties, duration, m_originalCaster, m_spellInfo->Id);
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
break;
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
case SUMMON_TYPE_TOTEM:
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
summon = m_caster->GetMap()->SummonCreature(entry, pos, properties, duration, m_originalCaster, m_spellInfo->Id);
if (!summon || !summon->isTotem())
return;
Core/Spells: Fix health for Mana Tide Totem
2011-05-19 01:24:53 +07:00
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
// Mana Tide Totem
if (m_spellInfo->Id == 16190)
damage = m_caster->CountPctFromMaxHealth(10);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
if (damage) // if not spell info, DB values used
{
summon->SetMaxHealth(damage);
summon->SetHealth(damage);
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
case SUMMON_TYPE_MINIPET:
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
summon = m_caster->GetMap()->SummonCreature(entry, pos, properties, duration, m_originalCaster, m_spellInfo->Id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!summon || !summon->HasUnitTypeMask(UNIT_MASK_MINION))
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
//summon->InitPetCreateSpells(); // e.g. disgusting oozeling has a create spell as summon...
[7750] Get level/health critters data from Db instead hardcoded values. Author: daveh
2009-05-03 22:26:53 -05:00
summon->SelectLevel(summon->GetCreatureInfo()); // some summoned creaters have different from 1 DB data for level/hp
[7754] Set NPC flags from DB for mini-pets (summoned critters). Author: daveh
2009-05-04 17:25:13 -05:00
summon->SetUInt32Value(UNIT_NPC_FLAGS, summon->GetCreatureInfo()->npcflag);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
summon->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Move MoveFollow owner from MoveTargetedHome to enterevademode.
2009-05-12 10:11:54 -05:00
summon->AI()->EnterEvadeMode();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
std::string name = m_originalCaster->GetName();
name.append(petTypeSuffix[3]);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
summon->SetName(name);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
default:
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float radius = GetSpellRadiusForHostile(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[effIndex]));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Cleanup:
2010-08-26 15:54:56 +06:00
uint32 amount = damage > 0 ? damage : 1;
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
if (m_spellInfo->Id == 18662 || // Curse of Doom
properties->Id == 2081) // Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling TODO: Research on meaning of basepoints
*Fix dead loop in proc system.
2009-06-15 17:15:19 +02:00
amount = 1;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
TempSummonType summonType = (duration == 0) ? TEMPSUMMON_DEAD_DESPAWN : TEMPSUMMON_TIMED_DESPAWN;
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint32 count = 0; count < amount; ++count)
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
GetSummonPosition(effIndex, pos, radius, count);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fix SPELL_AURA_CLONE_CASTER on summoned creatures, it will now properly clone the appearance of the caster.
2010-06-07 01:59:04 +02:00
summon = m_originalCaster->SummonCreature(entry, pos, summonType, duration);
*Fix Piercing Shots - by freeganja.
2009-07-22 22:52:05 +02:00
if (!summon)
continue;
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
*Fix snake trap.
2009-07-09 17:02:29 +02:00
if (properties->Category == SUMMON_CATEGORY_ALLY)
*Fix the bug that summoner cannot attack summoned creatures. This bug was introduced in 4481. Note the difference between "summoner" and "owner".
2009-08-14 22:25:12 -05:00
{
summon->SetUInt64Value(UNIT_FIELD_SUMMONEDBY, m_originalCaster->GetGUID());
*Fix Desecration.
2009-07-11 13:03:06 +02:00
summon->setFaction(m_originalCaster->getFaction());
*Some clean up and add debug info to find the reason of crash.
2009-08-26 19:28:21 -05:00
summon->SetUInt32Value(UNIT_CREATED_BY_SPELL, m_spellInfo->Id);
*Fix the bug that summoner cannot attack summoned creatures. This bug was introduced in 4481. Note the difference between "summoner" and "owner".
2009-08-14 22:25:12 -05:00
}
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectSummonObject(effIndex, summon);
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
return;
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
}//switch
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
case SUMMON_CATEGORY_PET:
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
SummonGuardian(effIndex, entry, properties);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
case SUMMON_CATEGORY_PUPPET:
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
summon = m_caster->GetMap()->SummonCreature(entry, pos, properties, duration, m_originalCaster, m_spellInfo->Id);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
Core/Spells: Cast proper vehicle spells on vehicle summon
2011-04-24 10:22:58 +02:00
case SUMMON_CATEGORY_VEHICLE:
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
// Summoning spells (usually triggered by npc_spellclick) that spawn a vehicle and that cause the clicker
// to cast a ride vehicle spell on the summoned unit.
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
float x, y, z;
m_caster->GetClosePoint(x, y, z, DEFAULT_WORLD_OBJECT_SIZE);
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
summon = m_originalCaster->GetMap()->SummonCreature(entry, pos, properties, duration, m_caster, m_spellInfo->Id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!summon || !summon->IsVehicle())
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
// The spell that this effect will trigger. It has SPELL_AURA_CONTROL_VEHICLE
Core/Spells: Corrected logic checking vehicle summon spells, thx codels
2011-04-25 14:39:37 +02:00
uint32 spell = VEHICLE_SPELL_RIDE_HARDCODED;
if (SpellEntry const* spellProto = sSpellStore.LookupEntry(SpellMgr::CalculateSpellEffectAmount(m_spellInfo, effIndex)))
spell = spellProto->Id;
Fixed spell casting upon vehicle summoning.
2010-05-13 17:57:59 +02:00
Core/Vehicles: Correct usage of npc_spellclick_spells instead of blatant hacks for vehicle entry.
2011-02-26 23:00:09 +01:00
// Hard coded enter vehicle spell
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
2011-04-22 12:05:15 +02:00
m_originalCaster->CastSpell(summon, spell, true);
Core/Vehicles: Correct usage of npc_spellclick_spells instead of blatant hacks for vehicle entry.
2011-02-26 23:00:09 +01:00
uint32 faction = properties->Faction;
if (!faction)
faction = m_originalCaster->getFaction();
summon->setFaction(faction);
*Summon all creatures by summon properties.
2009-03-25 16:20:30 -06:00
break;
*Some update of summon effect code.
2009-04-27 18:12:45 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (summon)
Fix SPELL_AURA_CLONE_CASTER on summoned creatures, it will now properly clone the appearance of the caster.
2010-06-07 01:59:04 +02:00
{
summon->SetCreatorGUID(m_originalCaster->GetGUID());
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectSummonObject(effIndex, summon);
Fix SPELL_AURA_CLONE_CASTER on summoned creatures, it will now properly clone the appearance of the caster.
2010-06-07 01:59:04 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectLearnSpell(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
EffectLearnPetSpell(effIndex);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player *player = (Player*)unitTarget;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 spellToLearn = (m_spellInfo->Id == 483 || m_spellInfo->Id == 55884) ? damage : m_spellInfo->EffectTriggerSpell[effIndex];
Fix mail, professions, group loot, console spam, and some fixes. Big thx to TOM_RUS.
2010-04-11 11:16:42 +04:00
player->learnSpell(spellToLearn, false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Spell: Player %u has learned spell %u from NpcGUID=%u", player->GetGUIDLow(), spellToLearn, m_caster->GetGUIDLow());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Use pair<uint32, uint64> lists instead of <Aura*> lists in Dispel/SpellSteal effects handlers (prevent reference to aura removed from unit)
2010-01-10 12:08:58 +01:00
typedef std::list< std::pair<uint32, uint64> > DispelList;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
typedef std::list< std::pair<Aura *, uint8> > DispelChargesList;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDispel(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
DispelChargesList dispel_list;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Create dispel mask by dispel type
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 dispel_type = m_spellInfo->EffectMiscValue[effIndex];
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
uint32 dispelMask = GetDispellMask(DispelType(dispel_type));
Unholy Blight should prevent the dispelling of diseases.
2010-08-06 21:32:42 -07:00
// we should not be able to dispel diseases if the target is affected by unholy blight
if (dispelMask & (1 << DISPEL_DISEASE) && unitTarget->HasAura(50536))
dispelMask &= ~(1 << DISPEL_DISEASE);
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraMap const& auras = unitTarget->GetOwnedAuras();
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (Unit::AuraMap::const_iterator itr = auras.begin(); itr != auras.end(); ++itr)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
Aura * aura = itr->second;
* Make sure that aura is applied on unit before trying to remove it.
2010-01-10 20:09:44 +01:00
AuraApplication * aurApp = aura->GetApplicationOfTarget(unitTarget->GetGUID());
if (!aurApp)
continue;
Add one more check to EffectDispel.
2011-01-02 22:43:36 +01:00
// don't try to remove passive auras
if (aura->IsPassive())
continue;
Update aura system:
2010-01-10 01:23:15 +01:00
if ((1<<aura->GetSpellProto()->Dispel) & dispelMask)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (aura->GetSpellProto()->Dispel == DISPEL_MAGIC)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core: Rename spell attributes, use more general names
2010-12-19 05:15:47 +01:00
bool positive = aurApp->IsPositive() ? (!(aura->GetSpellProto()->AttributesEx & SPELL_ATTR1_NEGATIVE)) : false;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// do not remove positive auras if friendly target
// negative auras if non-friendly target
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (positive == unitTarget->IsFriendlyTo(m_caster))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
continue;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
// The charges / stack amounts don't count towards the total number of auras that can be dispelled.
// Ie: A dispel on a target with 5 stacks of Winters Chill and a Polymorph has 1 / (1 + 1) -> 50% chance to dispell
// Polymorph instead of 1 / (5 + 1) -> 16%.
Core: Rename spell attributes, use more general names
2010-12-19 05:15:47 +01:00
bool dispel_charges = aura->GetSpellProto()->AttributesEx7 & SPELL_ATTR7_DISPEL_CHARGES;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
uint8 charges = dispel_charges ? aura->GetCharges() : aura->GetStackAmount();
if (charges > 0)
dispel_list.push_back(std::make_pair(aura, charges));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
if (dispel_list.empty())
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Ok if exist some buffs for dispel try dispel it
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
uint32 failCount = 0;
Core/Spells: Lifebloom final bloom.
2011-05-05 19:06:11 -03:00
DispelChargesList success_list;
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
WorldPacket dataFail(SMSG_DISPEL_FAILED, 8+8+4+4+damage*4);
// dispel N = damage buffs (or while exist buffs for dispel)
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
for (int32 count = 0; count < damage && !dispel_list.empty();)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
// Random select buff for dispel
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
DispelChargesList::iterator itr = dispel_list.begin();
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
std::advance(itr, urand(0, dispel_list.size() - 1));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
bool success = false;
// 2.4.3 Patch Notes: "Dispel effects will no longer attempt to remove effects that have 100% dispel resistance."
Dispell code cleanup - GetDispelChance now really returns dispel chance and not resist chance.
2010-06-27 04:03:30 +02:00
if (!GetDispelChance(itr->first->GetCaster(), unitTarget, itr->first->GetId(), !unitTarget->IsFriendlyTo(m_caster), &success))
*Update of aura system.
2009-04-06 13:31:14 +02:00
{
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
dispel_list.erase(itr);
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
continue;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
else
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
if (success)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Lifebloom final bloom.
2011-05-05 19:06:11 -03:00
bool alreadyListed = false;
for (DispelChargesList::iterator successItr = success_list.begin(); successItr != success_list.end(); ++successItr)
{
if (successItr->first->GetId() == itr->first->GetId())
{
++successItr->second;
alreadyListed = true;
}
}
if (!alreadyListed)
success_list.push_back(std::make_pair(itr->first, 1));
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
--itr->second;
if (itr->second <= 0)
dispel_list.erase(itr);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
else
{
if (!failCount)
{
// Failed to dispell
dataFail << uint64(m_caster->GetGUID()); // Caster GUID
dataFail << uint64(unitTarget->GetGUID()); // Victim GUID
dataFail << uint32(m_spellInfo->Id); // dispel spell id
}
++failCount;
dataFail << uint32(itr->first->GetId()); // Spell Id
}
++count;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
if (failCount)
m_caster->SendMessageToSet(&dataFail, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
if (success_list.empty())
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Lifebloom final bloom.
2011-05-05 19:06:11 -03:00
WorldPacket dataSuccess(SMSG_SPELLDISPELLOG, 8+8+4+1+4+success_list.size()*5);
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
// Send packet header
dataSuccess.append(unitTarget->GetPackGUID()); // Victim GUID
dataSuccess.append(m_caster->GetPackGUID()); // Caster GUID
dataSuccess << uint32(m_spellInfo->Id); // dispel spell id
dataSuccess << uint8(0); // not used
dataSuccess << uint32(success_list.size()); // count
Core/Spells: Lifebloom final bloom.
2011-05-05 19:06:11 -03:00
for (DispelChargesList::iterator itr = success_list.begin(); itr != success_list.end(); ++itr)
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
{
// Send dispelled spell info
Core/Spells: Lifebloom final bloom.
2011-05-05 19:06:11 -03:00
dataSuccess << uint32(itr->first->GetId()); // Spell Id
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
dataSuccess << uint8(0); // 0 - dispelled !=0 cleansed
Core/Spells: Lifebloom final bloom.
2011-05-05 19:06:11 -03:00
unitTarget->RemoveAurasDueToSpellByDispel(itr->first->GetId(), itr->first->GetCasterGUID(), m_caster, itr->second);
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
}
m_caster->SendMessageToSet(&dataSuccess, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
// On success dispel
// Devour Magic
if (m_spellInfo->SpellFamilyName == SPELLFAMILY_WARLOCK && m_spellInfo->Category == SPELLCATEGORY_DEVOUR_MAGIC)
{
*Add SpellMgr::CalculateSpellEffectAmount function for consistency of effect amount calculations in core
2010-07-14 16:57:13 +02:00
int32 heal_amount = SpellMgr::CalculateSpellEffectAmount(m_spellInfo, 1);
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
m_caster->CastCustomSpell(m_caster, 19658, &heal_amount, NULL, NULL, true);
Core/Spells: Fix Glyph of Felhunter
2010-12-23 19:03:28 +01:00
// Glyph of Felhunter
if (Unit * pOwner = m_caster->GetOwner())
if (pOwner->GetAura(56249))
pOwner->CastCustomSpell(pOwner, 19658, &heal_amount, NULL, NULL, true);
*Fix a crash caused by dispel effect. Thanks to nanouniko
2009-09-04 10:01:52 -05:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDualWield(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[svn] Provide creature dual wield support.
2008-10-29 20:00:21 -05:00
unitTarget->SetCanDualWield(true);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() == TYPEID_UNIT)
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
unitTarget->ToCreature()->UpdateDamagePhysical(OFF_ATTACK);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Make some cleanup.
2010-12-16 18:08:23 +01:00
void Spell::EffectPull(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// TODO: create a proper pull towards distract spell center for distract
Make some cleanup.
2010-12-16 18:08:23 +01:00
EffectNULL(effIndex);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDistract(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Check for possible target
if (!unitTarget || unitTarget->isInCombat())
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// target must be OK to do this
Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
2010-12-17 13:43:24 +01:00
if (unitTarget->HasUnitState(UNIT_STAT_CONFUSED | UNIT_STAT_STUNNED | UNIT_STAT_FLEEING))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More update about positions.
2009-08-29 23:20:16 -05:00
float angle = unitTarget->GetAngle(&m_targets.m_dstPos);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() == TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// For players just turn them
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->SetPosition(unitTarget->GetPositionX(), unitTarget->GetPositionY(), unitTarget->GetPositionZ(), angle, false);
Added (blizzlike) packet broadcast to near teleport. Thanks to Zor and nalimleinad (AKA anonymous colleague #1) for research.
2010-03-18 17:58:27 +01:00
unitTarget->ToPlayer()->SendTeleportAckPacket();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
else
{
// Set creature Distracted, Stop it, And turn it
unitTarget->SetOrientation(angle);
unitTarget->StopMoving();
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
unitTarget->GetMotionMaster()->MoveDistract(damage * IN_MILLISECONDS);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectPickPocket(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// victim must be creature and attackable
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT || m_caster->IsFriendlyTo(unitTarget))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// victim have to be alive and humanoid or undead
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->isAlive() && (unitTarget->GetCreatureTypeMask() &CREATURE_TYPEMASK_HUMANOID_OR_UNDEAD) != 0)
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->ToPlayer()->SendLoot(unitTarget->GetGUID(), LOOT_PICKPOCKETING);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectAddFarsight(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[svn] * Reimplemented packet/update forwarding in more generic way
2008-11-14 20:40:35 -06:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float radius = GetSpellRadiusForFriend(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[effIndex]));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 duration = GetSpellDuration(m_spellInfo);
Do not allow units that are not in world to create dynamic objects from spell effect handlers
2010-01-24 23:47:17 +01:00
// Caster not in world, might be spell triggered from aura removal
if (!m_caster->IsInWorld())
return;
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
DynamicObject* dynObj = new DynamicObject();
if (!dynObj->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_DYNAMICOBJECT), m_caster, m_spellInfo->Id, m_targets.m_dstPos, radius, true, DYNAMIC_OBJECT_FARSIGHT_FOCUS))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
delete dynObj;
return;
}
Core/DynamicObject: Research dynamicobject types, added DynamicObjectType enum
2011-04-19 15:14:50 +02:00
Update aura system:
2010-01-10 01:23:15 +01:00
dynObj->SetDuration(duration);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update active object code.
2009-02-26 16:29:55 -06:00
dynObj->setActive(true); //must before add to map to be put in world container
dynObj->GetMap()->Add(dynObj); //grid will also be loaded
Core/DynamicObjects: Change the way how dynamic objects are bound to their owners, fixes some crashes in Aura::GetOwner.
2011-02-04 00:27:43 +01:00
dynObj->SetCasterViewpoint();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Fix a few warnings here and there.
2010-12-25 06:28:38 +01:00
void Spell::EffectUntrainTalents(SpellEffIndex /*effIndex*/)
Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
2010-12-22 20:14:30 +02:00
{
if (!unitTarget || m_caster->GetTypeId() == TYPEID_PLAYER)
return;
if (uint64 guid = m_caster->GetGUID()) // the trainer is the caster
unitTarget->ToPlayer()->SendTalentWipeConfirm(guid);
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTeleUnitsFaceCaster(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->isInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float dis = (float)m_caster->GetSpellRadiusForTarget(unitTarget, sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[effIndex]));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
float fx, fy, fz;
m_caster->GetClosePoint(fx, fy, fz, unitTarget->GetObjectSize(), dis);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
unitTarget->NearTeleportTo(fx, fy, fz, -m_caster->GetOrientation(), unitTarget == m_caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectLearnSkill(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 skillid = m_spellInfo->EffectMiscValue[effIndex];
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
uint16 skillval = unitTarget->ToPlayer()->GetPureSkillValue(skillid);
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
unitTarget->ToPlayer()->SetSkill(skillid, SpellMgr::CalculateSpellEffectAmount(m_spellInfo, effIndex), skillval?skillval:1, damage*75);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectAddHonor(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7461] Give proper honor amount at item based AddHonor spells cast. Author: VladimirMangos
2009-03-15 17:20:15 -06:00
// not scale value for item based reward (/10 value expected)
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_CastItem)
[7461] Give proper honor amount at item based AddHonor spells cast. Author: VladimirMangos
2009-03-15 17:20:15 -06:00
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->RewardHonor(NULL, 1, damage/10);
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "SpellEffect::AddHonor (spell_id %u) rewards %d honor points (item %u) for player: %u", m_spellInfo->Id, damage/10, m_CastItem->GetEntry(), unitTarget->ToPlayer()->GetGUIDLow());
[7461] Give proper honor amount at item based AddHonor spells cast. Author: VladimirMangos
2009-03-15 17:20:15 -06:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7435] Fixed Spell::EffectAddHonor to corrcetly add honor based on player's level Author: Triply
2009-03-10 15:28:51 -06:00
// do not allow to add too many honor for player (50 * 21) = 1040 at level 70, or (50 * 31) = 1550 at level 80
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (damage <= 50)
[7461] Give proper honor amount at item based AddHonor spells cast. Author: VladimirMangos
2009-03-15 17:20:15 -06:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
uint32 honor_reward = Trinity::Honor::hk_honor_at_level(unitTarget->getLevel(), float(damage));
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->RewardHonor(NULL, 1, honor_reward);
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "SpellEffect::AddHonor (spell_id %u) rewards %u honor points (scale) to player: %u", m_spellInfo->Id, honor_reward, unitTarget->ToPlayer()->GetGUIDLow());
[7461] Give proper honor amount at item based AddHonor spells cast. Author: VladimirMangos
2009-03-15 17:20:15 -06:00
}
[7435] Fixed Spell::EffectAddHonor to corrcetly add honor based on player's level Author: Triply
2009-03-10 15:28:51 -06:00
else
{
//maybe we have correct honor_gain in damage already
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->RewardHonor(NULL, 1, damage);
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "SpellEffect::AddHonor (spell_id %u) rewards %u honor points (non scale) for player: %u", m_spellInfo->Id, damage, unitTarget->ToPlayer()->GetGUIDLow());
[7435] Fixed Spell::EffectAddHonor to corrcetly add honor based on player's level Author: Triply
2009-03-10 15:28:51 -06:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTradeSkill(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
// uint32 skillid = m_spellInfo->EffectMiscValue[i];
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
// uint16 skillmax = unitTarget->ToPlayer()->(skillid);
Add spaces after commas
2011-04-29 20:47:02 +02:00
// unitTarget->ToPlayer()->SetSkill(skillid, skillval?skillval:1, skillmax+75);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectEnchantItemPerm(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
if (!itemTarget)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* p_caster = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// Handle vellums
if (itemTarget->IsWeaponVellum() || itemTarget->IsArmorVellum())
{
// destroy one vellum from stack
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
uint32 count = 1;
Add spaces after commas
2011-04-29 20:47:02 +02:00
p_caster->DestroyItemCount(itemTarget, count, true);
*Do not apply auras with 4th diminishing level
2009-05-01 17:21:16 +02:00
unitTarget=p_caster;
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// and add a scroll
Add spaces after commas
2011-04-29 20:47:02 +02:00
DoCreateItem(effIndex, m_spellInfo->EffectItemType[effIndex]);
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
itemTarget=NULL;
m_targets.setItemTarget(NULL);
}
else
{
*Do not apply auras with 4th diminishing level
2009-05-01 17:21:16 +02:00
// do not increase skill if vellum used
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
if (!(m_CastItem && m_CastItem->GetTemplate()->Flags & ITEM_PROTO_FLAG_TRIGGERED_CAST))
*Do not apply auras with 4th diminishing level
2009-05-01 17:21:16 +02:00
p_caster->UpdateCraftSkill(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 enchant_id = m_spellInfo->EffectMiscValue[effIndex];
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
if (!enchant_id)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
SpellItemEnchantmentEntry const *pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pEnchant)
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
return;
Copyright header updates - part 3... (and some whitespace cleanups)
2010-10-07 14:00:52 +02:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// item can be in trade slot and have owner diff. from caster
Player* item_owner = itemTarget->GetOwner();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!item_owner)
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (item_owner != p_caster && p_caster->GetSession()->GetSecurity() > SEC_PLAYER && sWorld->getBoolConfig(CONFIG_GM_LOG_TRADE))
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outCommand(p_caster->GetSession()->GetAccountId(), "GM %s (Account: %u) enchanting(perm): %s (Entry: %d) for player: %s (Account: %u)",
p_caster->GetName(), p_caster->GetSession()->GetAccountId(),
More cleanup after last commit spree
2011-04-29 19:59:40 +02:00
itemTarget->GetTemplate()->Name1.c_str(), itemTarget->GetEntry(),
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->GetName(), item_owner->GetSession()->GetAccountId());
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// remove old enchanting before applying new if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PERM_ENCHANTMENT_SLOT, false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
itemTarget->SetEnchantment(PERM_ENCHANTMENT_SLOT, enchant_id, 0, 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
// add new enchanting if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PERM_ENCHANTMENT_SLOT, true);
Core/Items: Implemented trading soulbound loot items
2010-09-21 21:55:16 +02:00
itemTarget->SetSoulboundTradeable(NULL, item_owner, false);
*Implement enchanting vellums.
2009-05-01 15:40:49 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectEnchantItemPrismatic(SpellEffIndex effIndex)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
if (!itemTarget)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
Player* p_caster = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 enchant_id = m_spellInfo->EffectMiscValue[effIndex];
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
if (!enchant_id)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
SpellItemEnchantmentEntry const *pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pEnchant)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// support only enchantings with add socket in this slot
{
bool add_socket = false;
Magic numbers cleanup:
2010-09-28 08:21:51 +03:00
for (uint8 i = 0; i < MAX_ITEM_ENCHANTMENT_EFFECTS; ++i)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
if (pEnchant->type[i] == ITEM_ENCHANTMENT_TYPE_PRISMATIC_SOCKET)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
add_socket = true;
break;
}
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!add_socket)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Spell::EffectEnchantItemPrismatic: attempt apply enchant spell %u with SPELL_EFFECT_ENCHANT_ITEM_PRISMATIC (%u) but without ITEM_ENCHANTMENT_TYPE_PRISMATIC_SOCKET (%u), not suppoted yet.",
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_spellInfo->Id, SPELL_EFFECT_ENCHANT_ITEM_PRISMATIC, ITEM_ENCHANTMENT_TYPE_PRISMATIC_SOCKET);
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// item can be in trade slot and have owner diff. from caster
Player* item_owner = itemTarget->GetOwner();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!item_owner)
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (item_owner != p_caster && p_caster->GetSession()->GetSecurity() > SEC_PLAYER && sWorld->getBoolConfig(CONFIG_GM_LOG_TRADE))
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outCommand(p_caster->GetSession()->GetAccountId(), "GM %s (Account: %u) enchanting(perm): %s (Entry: %d) for player: %s (Account: %u)",
p_caster->GetName(), p_caster->GetSession()->GetAccountId(),
More cleanup after last commit spree
2011-04-29 19:59:40 +02:00
itemTarget->GetTemplate()->Name1.c_str(), itemTarget->GetEntry(),
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->GetName(), item_owner->GetSession()->GetAccountId());
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// remove old enchanting before applying new if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PRISMATIC_ENCHANTMENT_SLOT, false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
itemTarget->SetEnchantment(PRISMATIC_ENCHANTMENT_SLOT, enchant_id, 0, 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
// add new enchanting if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, PRISMATIC_ENCHANTMENT_SLOT, true);
Core/Items: Implemented trading soulbound loot items
2010-09-21 21:55:16 +02:00
itemTarget->SetSoulboundTradeable(NULL, item_owner, false);
[7227] Implement prismatic sockets. Related code cleanups.
2009-02-03 19:12:17 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectEnchantItemTmp(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* p_caster = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
// Rockbiter Weapon apply to both weapon
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!itemTarget)
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
return;
if (m_spellInfo->SpellFamilyName == SPELLFAMILY_SHAMAN && m_spellInfo->SpellFamilyFlags[0] & 0x400000)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
uint32 spell_id = 0;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
// enchanting spell selected by calculated damage-per-sec stored in Effect[1] base value
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Note: damage calculated (correctly) with rounding int32(float(v)) but
// RW enchantments applied damage int32(float(v)+0.5), this create 0..1 difference sometime
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
switch(damage)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Rank 1
Code Style (game + scripts only):
2010-04-07 23:56:35 +02:00
case 2: spell_id = 36744; break; // 0% [ 7% == 2, 14% == 2, 20% == 2]
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Rank 2
Code Style (game + scripts only):
2010-04-07 23:56:35 +02:00
case 4: spell_id = 36753; break; // 0% [ 7% == 4, 14% == 4]
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
case 5: spell_id = 36751; break; // 20%
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Rank 3
Code Style (game + scripts only):
2010-04-07 23:56:35 +02:00
case 6: spell_id = 36754; break; // 0% [ 7% == 6, 14% == 6]
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
case 7: spell_id = 36755; break; // 20%
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Rank 4
Code Style (game + scripts only):
2010-04-07 23:56:35 +02:00
case 9: spell_id = 36761; break; // 0% [ 7% == 6]
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
case 10: spell_id = 36758; break; // 14%
case 11: spell_id = 36760; break; // 20%
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("Spell::EffectEnchantItemTmp: Damage %u not handled in S'RW", damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(spell_id);
if (!spellInfo)
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Spell::EffectEnchantItemTmp: unknown spell id %i", spell_id);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
return;
Update aura system:
2010-01-10 01:23:15 +01:00
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
}
Code style (game + scripts only):
2010-04-07 19:12:44 +02:00
for (int j = BASE_ATTACK; j <= OFF_ATTACK; ++j)
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
{
if (Item* item = p_caster->GetWeaponForAttack(WeaponAttackType(j)))
{
if (item->IsFitToSpellRequirements(m_spellInfo))
{
Spell *spell = new Spell(m_caster, spellInfo, true);
SpellCastTargets targets;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
targets.setItemTarget(item);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
spell->prepare(&targets);
}
}
}
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
if (!itemTarget)
return;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 enchant_id = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!enchant_id)
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("Spell %u Effect %u (SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY) have 0 as enchanting id", m_spellInfo->Id, effIndex);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
SpellItemEnchantmentEntry const *pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pEnchant)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("Spell %u Effect %u (SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY) have not existed enchanting id %u ", m_spellInfo->Id, effIndex, enchant_id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// select enchantment duration
uint32 duration;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// rogue family enchantments exception by duration
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_spellInfo->Id == 38615)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 1800; // 30 mins
// other rogue family enchantments always 1 hour (some have spell damage=0, but some have wrong data in EffBasePoints)
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_ROGUE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 3600; // 1 hour
// shaman family enchantments
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->SpellFamilyName == SPELLFAMILY_SHAMAN)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 1800; // 30 mins
// other cases with this SpellVisual already selected
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->SpellVisual[0] == 215)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 1800; // 30 mins
Fixed duration on Glow Worm
2010-05-24 13:56:21 +02:00
// some fishing pole bonuses except Glow Worm which lasts full hour
else if (m_spellInfo->SpellVisual[0] == 563 && m_spellInfo->Id != 64401)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 600; // 10 mins
// shaman rockbiter enchantments
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->SpellVisual[0] == 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 1800; // 30 mins
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->Id == 29702)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 300; // 5 mins
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->Id == 37360)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 300; // 5 mins
// default case
else
duration = 3600; // 1 hour
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// item can be in trade slot and have owner diff. from caster
Player* item_owner = itemTarget->GetOwner();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!item_owner)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (item_owner != p_caster && p_caster->GetSession()->GetSecurity() > SEC_PLAYER && sWorld->getBoolConfig(CONFIG_GM_LOG_TRADE))
*Update to Mangos 6848. Source: Mangos.
2008-11-25 16:36:50 -06:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outCommand(p_caster->GetSession()->GetAccountId(), "GM %s (Account: %u) enchanting(temp): %s (Entry: %d) for player: %s (Account: %u)",
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
p_caster->GetName(), p_caster->GetSession()->GetAccountId(),
More cleanup after last commit spree
2011-04-29 19:59:40 +02:00
itemTarget->GetTemplate()->Name1.c_str(), itemTarget->GetEntry(),
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
item_owner->GetName(), item_owner->GetSession()->GetAccountId());
*Update to Mangos 6848. Source: Mangos.
2008-11-25 16:36:50 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// remove old enchanting before applying new if equipped
Add spaces after commas
2011-04-29 20:47:02 +02:00
item_owner->ApplyEnchantment(itemTarget, TEMP_ENCHANTMENT_SLOT, false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
itemTarget->SetEnchantment(TEMP_ENCHANTMENT_SLOT, enchant_id, duration * 1000, 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// add new enchanting if equipped
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
item_owner->ApplyEnchantment(itemTarget, TEMP_ENCHANTMENT_SLOT, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTameCreature(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetPetGUID())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->GetTypeId() != TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
Creature* creatureTarget = unitTarget->ToCreature();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (creatureTarget->isPet())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->getClass() != CLASS_HUNTER)
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// cast finish successfully
//SendChannelUpdate(0);
finish();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
Pet* pet = m_caster->CreateTamedPetFrom(creatureTarget, m_spellInfo->Id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pet) // in very specific state like near world end/etc.
[7937] Check OpenSSL lib at server start up. Author: AlexDereka
2009-06-02 17:40:22 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8040] Implement Creature::ForcedDespawn and ACTION_T_FORCE_DESPAWN for EventAI. Author: NoFantasy
2009-06-18 17:05:01 -05:00
// "kill" original creature
Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon
2011-01-02 21:33:37 +01:00
creatureTarget->DespawnOrUnsummon();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
uint8 level = (creatureTarget->getLevel() < (m_caster->getLevel() - 5)) ? (m_caster->getLevel() - 5) : creatureTarget->getLevel();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// prepare visual effect for levelup
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
pet->SetUInt32Value(UNIT_FIELD_LEVEL, level - 1);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// add to world
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
pet->GetMap()->Add(pet->ToCreature());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// visual effect for levelup
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
pet->SetUInt32Value(UNIT_FIELD_LEVEL, level);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
// caster have pet now
*Update summon system.
2009-05-02 19:24:22 -05:00
m_caster->SetMinion(pet, true);
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
* Fix visual bug that makes client believe that his recently tamed pet has no talent points.
2009-08-17 04:45:34 +02:00
pet->InitTalentForLevel();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
[svn] Fix 146_world.sql. Do not use default for text. (Ignore this if you have successfully applied 146_world.sql)
2008-11-04 09:23:06 -06:00
{
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->PetSpellInitialize();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSummonPet(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
Player *owner = NULL;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_originalCaster)
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_originalCaster->GetTypeId() == TYPEID_PLAYER)
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
owner = (Player*)m_originalCaster;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
else if (m_originalCaster->ToCreature()->isTotem())
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
owner = m_originalCaster->GetCharmerOrOwnerPlayerOrPlayerItself();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 petentry = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!owner)
*Fix the bug that summoned guardians cause crash (do not use the previous one).
2008-12-30 22:01:45 -06:00
{
*Fix a bug that npc's pet has too high level.
2009-04-15 20:19:47 -05:00
SummonPropertiesEntry const *properties = sSummonPropertiesStore.LookupEntry(67);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (properties)
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
SummonGuardian(effIndex, petentry, properties);
*Fix the bug that summoned guardians cause crash (do not use the previous one).
2008-12-30 22:01:45 -06:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
Pet *OldSummon = owner->GetPet();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// if pet requested type already exist
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (OldSummon)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (petentry == 0 || OldSummon->GetEntry() == petentry)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// pet in corpse state can't be summoned
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (OldSummon->isDead())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*use ASSERT macro instead of regular assert for better output.
2010-07-30 20:04:28 +02:00
ASSERT(OldSummon->GetMap() == owner->GetMap());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
//OldSummon->GetMap()->Remove(OldSummon->ToCreature(), false);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
float px, py, pz;
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
owner->GetClosePoint(px, py, pz, OldSummon->GetObjectSize());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix a crash caused by recall pet. Thanks to nanouniko
2009-08-26 21:17:47 -05:00
OldSummon->NearTeleportTo(px, py, pz, OldSummon->GetOrientation());
//OldSummon->Relocate(px, py, pz, OldSummon->GetOrientation());
//OldSummon->SetMap(owner->GetMap());
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
//owner->GetMap()->Add(OldSummon->ToCreature());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (owner->GetTypeId() == TYPEID_PLAYER && OldSummon->isControlled())
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
owner->ToPlayer()->PetSpellInitialize();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (owner->GetTypeId() == TYPEID_PLAYER)
Add spaces after commas
2011-04-29 20:47:02 +02:00
owner->ToPlayer()->RemovePet(OldSummon, (OldSummon->getPetType() == HUNTER_PET ? PET_SAVE_AS_DELETED : PET_SAVE_NOT_IN_SLOT), false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
float x, y, z;
owner->GetClosePoint(x, y, z, owner->GetObjectSize());
Pet* pet = owner->SummonPet(petentry, x, y, z, owner->GetOrientation(), SUMMON_PET, 0);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pet)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() == TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
if (m_caster->ToCreature()->isTotem())
*Disable charmed/possessed creature AI.
2009-03-05 18:48:56 -06:00
pet->SetReactState(REACT_AGGRESSIVE);
*Merge from Mangos. Add MapReference. Author: hunuza.
2008-11-18 19:40:06 -06:00
else
*Disable charmed/possessed creature AI.
2009-03-05 18:48:56 -06:00
pet->SetReactState(REACT_DEFENSIVE);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
pet->SetUInt32Value(UNIT_CREATED_BY_SPELL, m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
// generate new name for summon pet
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
std::string new_name=sObjectMgr->GeneratePetName(petentry);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!new_name.empty())
*Clean up of summoning pet spells.
2009-02-24 20:52:55 -06:00
pet->SetName(new_name);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectSummonObject(effIndex, pet);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectLearnPetSpell(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player *_player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Pet *pet = _player->GetPet();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pet)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!pet->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
SpellEntry const *learn_spellproto = sSpellStore.LookupEntry(m_spellInfo->EffectTriggerSpell[effIndex]);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!learn_spellproto)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pet->learnSpell(learn_spellproto->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
_player->PetSpellInitialize();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTaunt(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[7716] Fixed some typos and possible crashes. Author: AlexDereka
2009-04-27 18:42:35 -05:00
if (!unitTarget)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// this effect use before aura Taunt apply for prevent taunt already attacking target
// for spell as marked "non effective at already attacking target"
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || !unitTarget->CanHaveThreatList()
*Fix incorrect threat calculation of taunt spells.
2009-04-17 18:08:52 -05:00
|| unitTarget->getVictim() == m_caster)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix incorrect threat calculation of taunt spells.
2009-04-17 18:08:52 -05:00
SendCastResult(SPELL_FAILED_DONT_REPORT);
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
if (m_spellInfo->Id == 62124)
Core/Spells: Fix damage and combat log for spell Hand of Reckoning
2011-05-10 20:27:08 +07:00
m_caster->CastSpell(unitTarget, 67485, true);
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Also use this effect to set the taunter's threat to the taunted creature's highest value
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->getThreatManager().getCurrentVictim())
*Fix incorrect threat calculation of taunt spells.
2009-04-17 18:08:52 -05:00
{
float myThreat = unitTarget->getThreatManager().getThreat(m_caster);
float itsThreat = unitTarget->getThreatManager().getCurrentVictim()->getThreat();
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (itsThreat > myThreat)
*Fix incorrect threat calculation of taunt spells.
2009-04-17 18:08:52 -05:00
unitTarget->getThreatManager().addThreat(m_caster, itsThreat - myThreat);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Correct target assignement of taunt spells - patch by Alyen
2009-06-17 00:44:35 +02:00
//Set aggro victim to caster
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget->getThreatManager().getOnlineContainer().empty())
Rename 'Hostil' to 'Hostile'
2010-03-09 11:11:10 +01:00
if (HostileReference* forcedVictim = unitTarget->getThreatManager().getOnlineContainer().getReferenceByTarget(m_caster))
* Correct target assignement of taunt spells - patch by Alyen
2009-06-17 00:44:35 +02:00
unitTarget->getThreatManager().setCurrentVictim(forcedVictim);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
if (unitTarget->ToCreature()->IsAIEnabled && !unitTarget->ToCreature()->HasReactState(REACT_PASSIVE))
unitTarget->ToCreature()->AI()->AttackStart(m_caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectWeaponDmg(SpellEffIndex /*effIndex*/)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
{
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::SpellDamageWeaponDmg(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// multiple weapon dmg effect workaround
// execute only the last weapon damage
// and handle all effects at once
Magic numbers cleanup:
2010-09-28 08:21:51 +03:00
for (uint32 j = effIndex + 1; j < MAX_SPELL_EFFECTS; ++j)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
switch (m_spellInfo->Effect[j])
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELL_EFFECT_WEAPON_DAMAGE:
case SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL:
case SPELL_EFFECT_NORMALIZED_WEAPON_DMG:
case SPELL_EFFECT_WEAPON_PERCENT_DAMAGE:
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
return; // we must calculate only at last weapon effect
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// some spell specific modifiers
float totalDamagePercentMod = 1.0f; // applied to final bonus+weapon damage
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
int32 fixed_bonus = 0;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 spell_bonus = 0; // bonus specific for spell
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
switch (m_spellInfo->SpellFamilyName)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Scripts: Added script for Lord Marrowgar
2010-08-18 17:19:47 +02:00
case SPELLFAMILY_GENERIC:
{
switch (m_spellInfo->Id)
{
case 69055: // Saber Lash
case 70814: // Saber Lash
{
uint32 count = 0;
for (std::list<TargetInfo>::iterator ihit = m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (ihit->effectMask & (1 << effIndex))
Scripts: Added script for Lord Marrowgar
2010-08-18 17:19:47 +02:00
++count;
totalDamagePercentMod /= count;
break;
}
}
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case SPELLFAMILY_WARRIOR:
{
Cleanups for Devastate and Glyph of Devastate.
2010-01-05 14:36:06 +03:00
// Devastate (player ones)
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_spellInfo->SpellFamilyFlags[1] & 0x40)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Cleanups for Devastate and Glyph of Devastate.
2010-01-05 14:36:06 +03:00
// Player can apply only 58567 Sunder Armor effect.
bool needCast = !unitTarget->HasAura(58567, m_caster->GetGUID());
if (needCast)
m_caster->CastSpell(unitTarget, 58567, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Update aura system:
2010-01-10 01:23:15 +01:00
if (Aura * aur = unitTarget->GetAura(58567, m_caster->GetGUID()))
*Update weapon damage spell calculations.
2008-11-25 19:14:55 -06:00
{
Cleanups for Devastate and Glyph of Devastate.
2010-01-05 14:36:06 +03:00
// 58388 - Glyph of Devastate dummy aura.
if (int32 num = (needCast ? 0 : 1) + (m_caster->HasAura(58388) ? 1 : 0))
Update aura system:
2010-01-10 01:23:15 +01:00
aur->ModStackAmount(num);
Cleanups for Devastate and Glyph of Devastate.
2010-01-05 14:36:06 +03:00
fixed_bonus += (aur->GetStackAmount() - 1) * CalculateDamage(2, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
break;
}
case SPELLFAMILY_ROGUE:
{
Weapon dependant damage for some rogue talents
2010-04-21 18:52:30 +02:00
// Fan of Knives, Hemorrhage, Ghostly Strike
Warning Fixes
2010-04-29 23:12:16 +02:00
if ((m_spellInfo->SpellFamilyFlags[1] & 0x40000)
Weapon dependant damage for some rogue talents
2010-04-21 18:52:30 +02:00
|| (m_spellInfo->SpellFamilyFlags[0] & 0x6000000))
*Fix Fan of Knives.
2009-04-14 20:21:16 +02:00
{
Weapon dependant damage for some rogue talents
2010-04-21 18:52:30 +02:00
// Hemorrhage
if (m_spellInfo->SpellFamilyFlags[0] & 0x2000000)
{
if (m_caster->GetTypeId() == TYPEID_PLAYER)
m_caster->ToPlayer()->AddComboPoints(unitTarget, 1, this);
}
*Fix Fan of Knives.
2009-04-14 20:21:16 +02:00
// 50% more damage with daggers
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (Item* item = m_caster->ToPlayer()->GetWeaponForAttack(m_attackType, true))
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
if (item->GetTemplate()->SubClass == ITEM_SUBCLASS_WEAPON_DAGGER)
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
totalDamagePercentMod *= 1.5f;
*Fix Fan of Knives.
2009-04-14 20:21:16 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Mutilate (for each hand)
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
else if (m_spellInfo->SpellFamilyFlags[1] & 0x6)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
bool found = false;
// fast check
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (unitTarget->HasAuraState(AURA_STATE_DEADLY_POISON, m_spellInfo, m_caster))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
found = true;
// full aura scan
else
{
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraApplicationMap const& auras = unitTarget->GetAppliedAuras();
Code Style (game + scripts only):
2010-04-08 08:20:08 +02:00
for (Unit::AuraApplicationMap::const_iterator itr = auras.begin(); itr != auras.end(); ++itr)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
if (itr->second->GetBase()->GetSpellProto()->Dispel == DISPEL_POISON)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
found = true;
break;
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (found)
[7318] Fixed damage bonus for spell 1329 and ranks when target is poisoned. Author: Tequila
2009-02-21 17:07:48 -06:00
totalDamagePercentMod *= 1.2f; // 120% if poisoned
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
case SPELLFAMILY_PALADIN:
{
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
// Seal of Command Unleashed
Core/Spells: Drop obsolete code
2011-05-12 04:25:55 +07:00
if (m_spellInfo->Id == 20467)
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
spell_bonus += int32(0.08f * m_caster->GetTotalAttackPowerValue(BASE_ATTACK));
spell_bonus += int32(0.13f * m_caster->SpellBaseDamageBonus(GetSpellSchoolMask(m_spellInfo)));
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
case SPELLFAMILY_SHAMAN:
{
// Skyshatter Harness item set bonus
// Stormstrike
*Make charge-like spells with talented warbringer correctly remove movement impairing auras.
2009-07-13 21:27:05 +02:00
if (AuraEffect * aurEff = m_caster->IsScriptOverriden(m_spellInfo, 5634))
m_caster->CastSpell(m_caster, 38430, true, NULL, aurEff);
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
break;
}
case SPELLFAMILY_DRUID:
{
// Mangle (Cat): CP
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyFlags[1] & 0x400)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
m_caster->ToPlayer()->AddComboPoints(unitTarget, 1, this);
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
}
*Fix rend and tear talent.
2009-06-28 19:39:15 +02:00
// Shred, Maul - Rend and Tear
* Core switch to client 3.3.2 (11403)
2010-02-14 19:13:14 -07:00
else if (m_spellInfo->SpellFamilyFlags[0] & 0x00008800 && unitTarget->HasAuraState(AURA_STATE_BLEEDING))
*Fix rend and tear talent.
2009-06-28 19:39:15 +02:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
if (AuraEffect const* rendAndTear = m_caster->GetDummyAuraEffect(SPELLFAMILY_DRUID, 2859, 0))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(totalDamagePercentMod, rendAndTear->GetAmount());
*Fix rend and tear talent.
2009-06-28 19:39:15 +02:00
}
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Fix Kill Shot. Patch partially by bodompelle. Closes #357.
2009-12-20 17:25:10 -06:00
case SPELLFAMILY_HUNTER:
{
Fix Kill Shot damage (increase damage by attack power, not weapon damage ( that is already included in effects))
2010-01-13 09:54:03 +01:00
// Kill Shot - bonus damage from Ranged Attack Power
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyFlags[1] & 0x800000)
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
spell_bonus += int32(0.4f * m_caster->GetTotalAttackPowerValue(RANGED_ATTACK));
Fix Kill Shot. Patch partially by bodompelle. Closes #357.
2009-12-20 17:25:10 -06:00
break;
}
*Fix Obliterate disease bonus.
2009-06-13 17:28:38 +02:00
case SPELLFAMILY_DEATHKNIGHT:
{
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
// Plague Strike
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (m_spellInfo->SpellFamilyFlags[EFFECT_0] & 0x1)
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
{
// Glyph of Plague Strike
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (AuraEffect const * aurEff = m_caster->GetAuraEffect(58657, EFFECT_0))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(totalDamagePercentMod, aurEff->GetAmount());
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
break;
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
}
// Blood Strike
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (m_spellInfo->SpellFamilyFlags[EFFECT_0] & 0x400000)
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctF(totalDamagePercentMod, SpellMgr::CalculateSpellEffectAmount(m_spellInfo, EFFECT_2) * unitTarget->GetDiseasesByCaster(m_caster->GetGUID()) / 2.0f);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
// Glyph of Blood Strike
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (m_caster->GetAuraEffect(59332, EFFECT_0))
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->HasAuraType(SPELL_AURA_MOD_DECREASE_SPEED))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(totalDamagePercentMod, 20);
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
break;
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
}
// Death Strike
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (m_spellInfo->SpellFamilyFlags[EFFECT_0] & 0x10)
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
{
// Glyph of Death Strike
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (AuraEffect const * aurEff = m_caster->GetAuraEffect(59336, EFFECT_0))
if (uint32 runic = std::min<uint32>(m_caster->GetPower(POWER_RUNIC_POWER), SpellMgr::CalculateSpellEffectAmount(aurEff->GetSpellProto(), EFFECT_1)))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(totalDamagePercentMod, runic);
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
break;
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
}
*Fix Obliterate disease bonus.
2009-06-13 17:28:38 +02:00
// Obliterate (12.5% more damage per disease)
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (m_spellInfo->SpellFamilyFlags[EFFECT_1] & 0x20000)
*Fix Blood-Caked blade
2009-06-14 20:07:12 +02:00
{
bool consumeDiseases = true;
// Annihilation
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (AuraEffect const * aurEff = m_caster->GetDummyAuraEffect(SPELLFAMILY_DEATHKNIGHT, 2710, EFFECT_0))
*Fix Blood-Caked blade
2009-06-14 20:07:12 +02:00
// Do not consume diseases if roll sucesses
if (roll_chance_i(aurEff->GetAmount()))
consumeDiseases = false;
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctF(totalDamagePercentMod, SpellMgr::CalculateSpellEffectAmount(m_spellInfo, EFFECT_2) * unitTarget->GetDiseasesByCaster(m_caster->GetGUID(), consumeDiseases) / 2.0f);
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
break;
*Fix Blood-Caked blade
2009-06-14 20:07:12 +02:00
}
*Fix Glyph of Blood Strike
2009-08-08 21:51:00 +02:00
// Blood-Caked Strike - Blood-Caked Blade
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
if (m_spellInfo->SpellIconID == 1736)
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctF(totalDamagePercentMod, unitTarget->GetDiseasesByCaster(m_caster->GetGUID()) * 12.5f);
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
break;
}
// Heart Strike
if (m_spellInfo->SpellFamilyFlags[EFFECT_0] & 0x1000000)
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
AddPctN(totalDamagePercentMod, SpellMgr::CalculateSpellEffectAmount(m_spellInfo, EFFECT_2) * unitTarget->GetDiseasesByCaster(m_caster->GetGUID()));
Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
2010-12-04 10:31:14 +01:00
break;
}
*Fix Obliterate disease bonus.
2009-06-13 17:28:38 +02:00
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
bool normalized = false;
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
float weaponDamagePercentMod = 1.0f;
Magic numbers cleanup:
2010-09-28 08:21:51 +03:00
for (int j = 0; j < MAX_SPELL_EFFECTS; ++j)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
switch (m_spellInfo->Effect[j])
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELL_EFFECT_WEAPON_DAMAGE:
case SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL:
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
fixed_bonus += CalculateDamage(j, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
case SPELL_EFFECT_NORMALIZED_WEAPON_DMG:
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
fixed_bonus += CalculateDamage(j, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
normalized = true;
break;
case SPELL_EFFECT_WEAPON_PERCENT_DAMAGE:
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
ApplyPctN(weaponDamagePercentMod, CalculateDamage(j, unitTarget));
[7562] Drop code for now not existed spell support. (Touch of Weakness triggered spell) Author: cccyril
2009-03-28 16:34:34 -06:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
break; // not weapon damage effect, just skip
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// apply to non-weapon bonus weapon total pct effect, weapon total flat effect included in weapon damage
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (fixed_bonus || spell_bonus)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
UnitMods unitMod;
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
switch (m_attackType)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
default:
case BASE_ATTACK: unitMod = UNIT_MOD_DAMAGE_MAINHAND; break;
case OFF_ATTACK: unitMod = UNIT_MOD_DAMAGE_OFFHAND; break;
case RANGED_ATTACK: unitMod = UNIT_MOD_DAMAGE_RANGED; break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Do not make nonphysical damage spells that use EffectWeaponDmg (like Seal of Command) receive total damage mod % auras twice - based on nos4r2zod's patch for MaNGOS
2009-10-07 19:34:20 +02:00
float weapon_total_pct = 1.0f;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_spellInfo->SchoolMask & SPELL_SCHOOL_MASK_NORMAL)
* Do not make nonphysical damage spells that use EffectWeaponDmg (like Seal of Command) receive total damage mod % auras twice - based on nos4r2zod's patch for MaNGOS
2009-10-07 19:34:20 +02:00
weapon_total_pct = m_caster->GetModifierValue(unitMod, TOTAL_PCT);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (fixed_bonus)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
fixed_bonus = int32(fixed_bonus * weapon_total_pct);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (spell_bonus)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
spell_bonus = int32(spell_bonus * weapon_total_pct);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Do not make nonphysical damage spells that use EffectWeaponDmg (like Seal of Command) receive total damage mod % auras twice - based on nos4r2zod's patch for MaNGOS
2009-10-07 19:34:20 +02:00
int32 weaponDamage = m_caster->CalculateDamage(m_attackType, normalized, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
// Sequence is important
Magic numbers cleanup:
2010-09-28 08:21:51 +03:00
for (int j = 0; j < MAX_SPELL_EFFECTS; ++j)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
{
// We assume that a spell have at most one fixed_bonus
// and at most one weaponDamagePercentMod
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
switch(m_spellInfo->Effect[j])
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
{
case SPELL_EFFECT_WEAPON_DAMAGE:
case SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL:
case SPELL_EFFECT_NORMALIZED_WEAPON_DMG:
weaponDamage += fixed_bonus;
break;
case SPELL_EFFECT_WEAPON_PERCENT_DAMAGE:
weaponDamage = int32(weaponDamage * weaponDamagePercentMod);
default:
break; // not weapon damage effect, just skip
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (spell_bonus)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
weaponDamage += spell_bonus;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (totalDamagePercentMod != 1.0f)
*Fix melee spell damage calculation.
2008-12-17 23:27:01 -06:00
weaponDamage = int32(weaponDamage * totalDamagePercentMod);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// prevent negative damage
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
uint32 eff_damage(std::max(weaponDamage, 0));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Procflag patch by DiSlord.
2008-11-26 15:14:03 -06:00
// Add melee damage bonuses (also check for negative)
m_caster->MeleeDamageBonus(unitTarget, &eff_damage, m_attackType, m_spellInfo);
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
m_damage += eff_damage;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectThreat(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || !unitTarget->isAlive() || !m_caster->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->CanHaveThreatList())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
unitTarget->AddThreat(m_caster, float(damage));
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectHealMaxHealth(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
if (!unitTarget || !unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Lay on hands should have heal amount = caster's max health.
2009-05-31 20:45:34 -05:00
int32 addhealth;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->SpellFamilyName == SPELLFAMILY_PALADIN) // Lay on Hands
* Core switch to client 3.3.2 (11403)
2010-02-14 19:13:14 -07:00
{
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
if (m_caster->GetGUID() == unitTarget->GetGUID())
Fixed Forbearance. Also self-cast LoH will now correctly prevent Avenging Wrath for 30 s. Closes issue #1270. Thanks to _manuel_ for research.
2010-03-25 17:09:05 +01:00
{
m_caster->CastSpell(m_caster, 25771, true); // Forbearance
m_caster->CastSpell(m_caster, 61988, true); // Immune shield marker (serverside)
m_caster->CastSpell(m_caster, 61987, true); // Avenging Wrath marker
}
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
}
* Core switch to client 3.3.2 (11403)
2010-02-14 19:13:14 -07:00
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
// damage == 0 - heal for caster max health
if (damage == 0)
*Lay on hands should have heal amount = caster's max health.
2009-05-31 20:45:34 -05:00
addhealth = m_caster->GetMaxHealth();
else
addhealth = unitTarget->GetMaxHealth() - unitTarget->GetHealth();
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_originalCaster)
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
m_healing += m_originalCaster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectInterruptCast(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
2010-08-28 23:01:04 +02:00
if (!unitTarget || !unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// TODO: not all spells that used this effect apply cooldown at school spells
// also exist case: apply cooldown to interrupted cast only and to all spells
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
for (uint32 i = CURRENT_FIRST_NON_MELEE_SPELL; i < CURRENT_MAX_SPELL; ++i)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
if (Spell* spell = unitTarget->GetCurrentSpell(CurrentSpellTypes(i)))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
SpellEntry const* curSpellInfo = spell->m_spellInfo;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// check if we can interrupt spell
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
if ((spell->getState() == SPELL_STATE_CASTING
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
|| (spell->getState() == SPELL_STATE_PREPARING && spell->GetCastTime() > 0.0f))
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
&& curSpellInfo->InterruptFlags & SPELL_INTERRUPT_FLAG_INTERRUPT && curSpellInfo->PreventionType == SPELL_PREVENTION_TYPE_SILENCE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_originalCaster)
*Let talents such as focused mind have effect on counterspell effects.
2008-12-15 09:55:57 -06:00
{
*Update of aura system.
2009-04-06 13:31:14 +02:00
int32 duration = m_originalCaster->ModSpellDuration(m_spellInfo, unitTarget, m_originalCaster->CalcSpellDuration(m_spellInfo), false);
Core/Misc: Some random cleanups
2011-05-25 19:54:17 +07:00
unitTarget->ProhibitSpellSchool(GetSpellSchoolMask(curSpellInfo), duration/*GetSpellDuration(m_spellInfo)*/);
*Let talents such as focused mind have effect on counterspell effects.
2008-12-15 09:55:57 -06:00
}
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
ExecuteLogEffectInterruptCast(effIndex, unitTarget, curSpellInfo->Id);
[8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
2009-08-19 16:52:51 -05:00
unitTarget->InterruptSpell(CurrentSpellTypes(i), false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSummonObjectWild(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 gameobject_id = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
GameObject* pGameObj = new GameObject;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
WorldObject* target = focusObject;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!target)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
target = m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
float x, y, z;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.HasDst())
*More update about positions.
2009-08-29 23:20:16 -05:00
m_targets.m_dstPos.GetPosition(x, y, z);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
else
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->GetClosePoint(x, y, z, DEFAULT_WORLD_OBJECT_SIZE);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Map *map = target->GetMap();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (!pGameObj->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_GAMEOBJECT), gameobject_id, map,
[7715] Provided way for scripts set alternative gameobject state for client show. Author: VladimirMangos
2009-04-27 18:36:10 -05:00
m_caster->GetPhaseMask(), x, y, z, target->GetOrientation(), 0.0f, 0.0f, 0.0f, 0.0f, 100, GO_STATE_READY))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
delete pGameObj;
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 duration = GetSpellDuration(m_spellInfo);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
pGameObj->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pGameObj->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectSummonObject(effIndex, pGameObj);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
// Wild object not have owner and check clickable by players
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
map->Add(pGameObj);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (pGameObj->GetGoType() == GAMEOBJECT_TYPE_FLAGDROP && m_caster->GetTypeId() == TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Convert some C style casts to new functions
2010-03-11 20:51:31 +01:00
Player *pl = m_caster->ToPlayer();
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
Battleground* bg = pl->GetBattleground();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
switch(pGameObj->GetMapId())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
case 489: //WS
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add support for random battlegrounds - port by n0n4me, original code by Vladimir and Griffonheart (Big thanks to all of you!)
2010-05-26 11:34:37 +02:00
if (bg && bg->GetTypeID(true) == BATTLEGROUND_WS && bg->GetStatus() == STATUS_IN_PROGRESS)
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
{
uint32 team = ALLIANCE;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (pl->GetTeam() == team)
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
team = HORDE;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
((BattlegroundWS*)bg)->SetDroppedFlagGUID(pGameObj->GetGUID(), team);
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
}
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
case 566: //EY
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Add support for random battlegrounds - port by n0n4me, original code by Vladimir and Griffonheart (Big thanks to all of you!)
2010-05-26 11:34:37 +02:00
if (bg && bg->GetTypeID(true) == BATTLEGROUND_EY && bg->GetStatus() == STATUS_IN_PROGRESS)
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
{
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
((BattlegroundEY*)bg)->SetDroppedFlagGUID(pGameObj->GetGUID());
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
}
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint32 linkedEntry = pGameObj->GetGOInfo()->GetLinkedGameObjectEntry())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
GameObject* linkedGO = new GameObject;
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (linkedGO->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_GAMEOBJECT), linkedEntry, map,
[7715] Provided way for scripts set alternative gameobject state for client show. Author: VladimirMangos
2009-04-27 18:36:10 -05:00
m_caster->GetPhaseMask(), x, y, z, target->GetOrientation(), 0.0f, 0.0f, 0.0f, 0.0f, 100, GO_STATE_READY))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
linkedGO->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
linkedGO->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectSummonObject(effIndex, linkedGO);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
[8320] Imporovements in wild summoned gameobjects work. Author: VladimirMangos
2009-08-08 12:25:20 -05:00
// Wild object not have owner and check clickable by players
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
map->Add(linkedGO);
}
else
{
delete linkedGO;
linkedGO = NULL;
return;
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectScriptEffect(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// TODO: we must implement hunter pet summon at login there (spell 6962)
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
switch(m_spellInfo->SpellFamilyName)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case SPELLFAMILY_GENERIC:
*Update to Mangos 6880. Source: Mangos.
2008-12-06 14:01:44 -06:00
{
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
switch(m_spellInfo->Id)
{
*Fix Glyph of Starfire
2009-08-23 17:59:32 +02:00
// Glyph of Backstab
case 63975:
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
if (AuraEffect const * aurEff = unitTarget->GetAuraEffect(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_ROGUE, 0x00100000, 0, 0, m_caster->GetGUID()))
*Fix Glyph of Starfire
2009-08-23 17:59:32 +02:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
uint32 countMin = aurEff->GetBase()->GetMaxDuration();
*Fix Glyph of Starfire
2009-08-23 17:59:32 +02:00
uint32 countMax = 12000;
countMax += m_caster->HasAura(56801) ? 4000 : 0;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix Glyph of Starfire
2009-08-23 17:59:32 +02:00
if (countMin < countMax)
{
Update aura system:
2010-01-10 01:23:15 +01:00
aurEff->GetBase()->SetDuration(uint32(aurEff->GetBase()->GetDuration()+3000));
aurEff->GetBase()->SetMaxDuration(countMin+2000);
*Fix Glyph of Starfire
2009-08-23 17:59:32 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix Glyph of Starfire
2009-08-23 17:59:32 +02:00
}
return;
}
*Implement Aura Type 247 (SPELL_AURA_CLONE_CASTER) and 279 (SPELL_AURA_INITIALIZE_IMAGES)
2009-07-22 17:10:30 +02:00
case 45204: // Clone Me!
Core/Spells: Fix cloning spells
2011-04-08 23:16:57 +03:00
m_caster->CastSpell(unitTarget, damage, true);
break;
[8351] Implement spell 55693. Author: VladimirMangos
2009-08-12 20:47:54 -05:00
case 55693: // Remove Collapsing Cave Aura
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[8351] Implement spell 55693. Author: VladimirMangos
2009-08-12 20:47:54 -05:00
return;
*Add SpellMgr::CalculateSpellEffectAmount function for consistency of effect amount calculations in core
2010-07-14 16:57:13 +02:00
unitTarget->RemoveAurasDueToSpell(SpellMgr::CalculateSpellEffectAmount(m_spellInfo, effIndex));
[8351] Implement spell 55693. Author: VladimirMangos
2009-08-12 20:47:54 -05:00
break;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// PX-238 Winter Wondervolt TRAP
case 26275:
{
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
uint32 spells[4] = { 26272, 26157, 26273, 26274 };
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
// check presence
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint8 j = 0; j < 4; ++j)
Add spaces after commas
2011-04-29 20:47:02 +02:00
if (unitTarget->HasAuraEffect(spells[j], 0))
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
// select spell
Add spaces after commas
2011-04-29 20:47:02 +02:00
uint32 iTmpSpellId = spells[urand(0, 3)];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
// cast
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
unitTarget->CastSpell(unitTarget, iTmpSpellId, true);
return;
}
// Bending Shinbone
case 8856:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!itemTarget && m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
uint32 spell_id = 0;
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
switch(urand(1, 5))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
case 1: spell_id = 8854; break;
default: spell_id = 8855; break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->CastSpell(m_caster, spell_id, true, NULL);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
}
// Brittle Armor - need remove one 24575 Brittle Armor aura
case 24590:
*Update of aura system.
2009-04-06 13:31:14 +02:00
unitTarget->RemoveAuraFromStack(24575);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
// Mercurial Shield - need remove one 26464 Mercurial Shield aura
case 26465:
*Update of aura system.
2009-04-06 13:31:14 +02:00
unitTarget->RemoveAuraFromStack(26464);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
// Shadow Flame (All script effects, not just end ones to prevent player from dodging the last triggered spell)
case 22539:
case 22972:
case 22975:
case 22976:
case 22977:
case 22978:
case 22979:
case 22980:
case 22981:
case 22982:
case 22983:
case 22984:
case 22985:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || !unitTarget->isAlive())
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Onyxia Scale Cloak
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->HasAura(22683))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Shadow Flame
m_caster->CastSpell(unitTarget, 22682, true);
return;
}
// Piccolo of the Flaming Fire
case 17512:
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
unitTarget->HandleEmoteCommand(EMOTE_STATE_DANCE);
[7431] Fix the gnome racial spell Author: Lightguard
2009-03-09 18:09:00 -06:00
return;
}
// Escape artist
case 20589:
Core/Spell: Fixed Escape artist, patch by Heisenberg
2010-09-05 13:59:49 +02:00
m_caster->RemoveMovementImpairingAuras();
*Update of aura system.
2009-04-06 13:31:14 +02:00
return;
*Update naxx script.
2009-05-16 14:49:58 -05:00
// Decimate
case 28374:
case 54426:
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
*Update naxx script.
2009-05-16 14:49:58 -05:00
{
Core:
2010-08-26 01:20:57 +06:00
int32 damage = int32(unitTarget->GetHealth()) - int32(unitTarget->CountPctFromMaxHealth(5));
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage > 0)
*Update naxx script.
2009-05-16 14:49:58 -05:00
m_caster->CastCustomSpell(28375, SPELLVALUE_BASE_POINT0, damage, unitTarget);
}
return;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Mirren's Drinking Hat
case 29830:
{
uint32 item = 0;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
switch (urand(1, 6))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
case 1:
case 2:
case 3:
item = 23584; break; // Loch Modan Lager
case 4:
case 5:
item = 23585; break; // Stouthammer Lite
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case 6:
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
item = 23586; break; // Aerie Peak Pale Ale
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
if (item)
Add spaces after commas
2011-04-29 20:47:02 +02:00
DoCreateItem(effIndex, item);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
}
// Improved Sprint
case 30918:
{
// Removes snares and roots.
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
unitTarget->RemoveMovementImpairingAuras();
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
}
Fixed spell Spirit Walk. by Ouden
2009-12-24 13:01:39 +01:00
// Spirit Walk
case 58876:
{
// Removes snares and roots.
unitTarget->RemoveMovementImpairingAuras();
break;
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
// Plant Warmaul Ogre Banner
case 32307:
{
Player *p_caster = dynamic_cast<Player*>(m_caster);
if (!p_caster)
break;
p_caster->RewardPlayerAndGroupAtEvent(18388, unitTarget);
Creature *cTarget = dynamic_cast<Creature*>(unitTarget);
if (!cTarget)
break;
cTarget->setDeathState(CORPSE);
cTarget->RemoveCorpse();
break;
}
*Merge.
2009-02-12 17:21:33 -06:00
case 48025: // Headless Horseman's Mount
{
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Merge.
2009-02-12 17:21:33 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
// Prevent stacking of mounts and client crashes upon dismounting
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Triggered spell id dependent on riding skill and zone
bool canFly = true;
uint32 v_map = GetVirtualMapForMapAndZone(unitTarget->GetMapId(), unitTarget->GetZoneId());
if (v_map != 530 && v_map != 571)
canFly = false;
if (canFly && v_map == 571 && !unitTarget->ToPlayer()->HasSpell(54197))
canFly = false;
float x, y, z;
unitTarget->GetPosition(x, y, z);
uint32 areaFlag = unitTarget->GetBaseMap()->GetAreaFlag(x, y, z);
AreaTableEntry const *pArea = sAreaStore.LookupEntry(areaFlag);
Core: Fix warnings
2010-11-16 14:08:12 +01:00
if (!pArea || (canFly && (pArea->flags & AREA_FLAG_NO_FLY_ZONE)))
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
canFly = false;
switch(unitTarget->ToPlayer()->GetBaseSkillValue(SKILL_RIDING))
*Merge.
2009-02-12 17:21:33 -06:00
{
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
case 75: unitTarget->CastSpell(unitTarget, 51621, true); break;
case 150: unitTarget->CastSpell(unitTarget, 48024, true); break;
case 225:
{
if (canFly)
*Cleanup, proper indentation, and remove some wrong/irrelevant comments copied from custom patches..
2009-12-18 13:41:30 -08:00
unitTarget->CastSpell(unitTarget, 51617, true);
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
else
unitTarget->CastSpell(unitTarget, 48024, true);
}break;
case 300:
{
if (canFly)
*Cleanup, proper indentation, and remove some wrong/irrelevant comments copied from custom patches..
2009-12-18 13:41:30 -08:00
unitTarget->CastSpell(unitTarget, 48023, true);
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
else
unitTarget->CastSpell(unitTarget, 48024, true);
}break;
*Merge.
2009-02-12 17:21:33 -06:00
}
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
return;
*Merge.
2009-02-12 17:21:33 -06:00
}
*Merge.
2009-02-15 11:57:00 -06:00
case 47977: // Magic Broom
{
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Merge.
2009-02-15 11:57:00 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
// Prevent stacking of mounts and client crashes upon dismounting
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Triggered spell id dependent on riding skill and zone
bool canFly = true;
uint32 v_map = GetVirtualMapForMapAndZone(unitTarget->GetMapId(), unitTarget->GetZoneId());
if (v_map != 530 && v_map != 571)
canFly = false;
if (canFly && v_map == 571 && !unitTarget->ToPlayer()->HasSpell(54197))
canFly = false;
float x, y, z;
unitTarget->GetPosition(x, y, z);
uint32 areaFlag = unitTarget->GetBaseMap()->GetAreaFlag(x, y, z);
AreaTableEntry const *pArea = sAreaStore.LookupEntry(areaFlag);
Core: Fix warnings
2010-11-16 14:08:12 +01:00
if (!pArea || (canFly && (pArea->flags & AREA_FLAG_NO_FLY_ZONE)))
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
canFly = false;
switch(unitTarget->ToPlayer()->GetBaseSkillValue(SKILL_RIDING))
*Merge.
2009-02-15 11:57:00 -06:00
{
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
case 75: unitTarget->CastSpell(unitTarget, 42680, true); break;
case 150: unitTarget->CastSpell(unitTarget, 42683, true); break;
case 225:
*Merge.
2009-02-15 11:57:00 -06:00
{
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
if (canFly)
unitTarget->CastSpell(unitTarget, 42667, true);
else
unitTarget->CastSpell(unitTarget, 42683, true);
}break;
case 300:
{
if (canFly)
unitTarget->CastSpell(unitTarget, 42668, true);
else
unitTarget->CastSpell(unitTarget, 42683, true);
}break;
*Merge.
2009-02-15 11:57:00 -06:00
}
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
return;
*Merge.
2009-02-15 11:57:00 -06:00
}
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
// Mug Transformation
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case 41931:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
uint8 bag = 19;
uint8 slot = 0;
Item *item = NULL;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
while (bag) // 256 = 0 due to var type
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
item = m_caster->ToPlayer()->GetItemByPos(bag, slot);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
if (item && item->GetEntry() == 38587) break;
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
++slot;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
if (slot == 39)
{
slot = 0;
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
++bag;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
}
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
if (bag)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
if (m_caster->ToPlayer()->GetItemByPos(bag, slot)->GetCount() == 1) m_caster->ToPlayer()->RemoveItem(bag, slot, true);
else m_caster->ToPlayer()->GetItemByPos(bag, slot)->SetCount(m_caster->ToPlayer()->GetItemByPos(bag, slot)->GetCount()-1);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Spell 42518 (Braufest - Gratisprobe des Braufest herstellen)
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
m_caster->CastSpell(m_caster, 42518, true);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
}
break;
}
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
// Brutallus - Burn
case 45141:
case 45151:
{
//Workaround for Range ... should be global for every ScriptEffect
*Prevent MoveFollow and MoveChase while UNIT_FLAG_DISABLE_MOVE is present, by Liberate. Closes #168.
2009-11-19 20:03:35 -08:00
float radius = GetSpellRadiusForHostile(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[effIndex]));
*Merge TC1 r1737 and r1754 by BroodWyrn, fixes spells 45151, 45141, 46394 (Brutallus Burn), closes #179
2009-11-19 19:55:24 -08:00
if (unitTarget && unitTarget->GetTypeId() == TYPEID_PLAYER && unitTarget->GetDistance(m_caster) >= radius && !unitTarget->HasAura(46394) && unitTarget != m_caster)
unitTarget->CastSpell(unitTarget, 46394, true);
break;
}
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Goblin Weather Machine
case 46203:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7716] Fixed some typos and possible crashes. Author: AlexDereka
2009-04-27 18:42:35 -05:00
uint32 spellId = 0;
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
switch(rand() % 4)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
case 0: spellId = 46740; break;
case 1: spellId = 46739; break;
case 2: spellId = 46738; break;
case 3: spellId = 46736; break;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
unitTarget->CastSpell(unitTarget, spellId, true);
break;
}
Add spaces after commas
2011-04-29 20:47:02 +02:00
// 5, 000 Gold
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case 46642:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->ModifyMoney(5000 * GOLD);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
// Roll Dice - Decahedral Dwarven Dice
case 47770:
{
char buf[128];
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
const char *gender = "his";
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->getGender() > 0)
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
gender = "her";
Add spaces after commas
2011-04-29 20:47:02 +02:00
sprintf(buf, "%s rubs %s [Decahedral Dwarven Dice] between %s hands and rolls. One %u and one %u.", m_caster->GetName(), gender, gender, urand(1, 10), urand(1, 10));
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
m_caster->MonsterTextEmote(buf, 0);
break;
}
// Roll 'dem Bones - Worn Troll Dice
case 47776:
{
char buf[128];
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
const char *gender = "his";
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->getGender() > 0)
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
gender = "her";
Add spaces after commas
2011-04-29 20:47:02 +02:00
sprintf(buf, "%s causually tosses %s [Worn Troll Dice]. One %u and one %u.", m_caster->GetName(), gender, urand(1, 6), urand(1, 6));
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
m_caster->MonsterTextEmote(buf, 0);
break;
}
*Fix reckonging
2009-05-21 20:02:22 +02:00
// Vigilance
case 50725:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Fix reckonging
2009-05-21 20:02:22 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix reckonging
2009-05-21 20:02:22 +02:00
// Remove Taunt cooldown
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->RemoveSpellCooldown(355, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix reckonging
2009-05-21 20:02:22 +02:00
return;
}
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
// Death Knight Initiate Visual
case 51519:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT)
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
uint32 iTmpSpellId = 0;
switch (unitTarget->GetDisplayId())
{
case 25369: iTmpSpellId = 51552; break; // bloodelf female
case 25373: iTmpSpellId = 51551; break; // bloodelf male
case 25363: iTmpSpellId = 51542; break; // draenei female
case 25357: iTmpSpellId = 51541; break; // draenei male
case 25361: iTmpSpellId = 51537; break; // dwarf female
case 25356: iTmpSpellId = 51538; break; // dwarf male
case 25372: iTmpSpellId = 51550; break; // forsaken female
case 25367: iTmpSpellId = 51549; break; // forsaken male
case 25362: iTmpSpellId = 51540; break; // gnome female
case 25359: iTmpSpellId = 51539; break; // gnome male
case 25355: iTmpSpellId = 51534; break; // human female
case 25354: iTmpSpellId = 51520; break; // human male
case 25360: iTmpSpellId = 51536; break; // nightelf female
case 25358: iTmpSpellId = 51535; break; // nightelf male
case 25368: iTmpSpellId = 51544; break; // orc female
case 25364: iTmpSpellId = 51543; break; // orc male
case 25371: iTmpSpellId = 51548; break; // tauren female
case 25366: iTmpSpellId = 51547; break; // tauren male
case 25370: iTmpSpellId = 51545; break; // troll female
case 25365: iTmpSpellId = 51546; break; // troll male
default: return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
unitTarget->CastSpell(unitTarget, iTmpSpellId, true);
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
Creature* npc = unitTarget->ToCreature();
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
npc->LoadEquipment(npc->GetEquipmentId());
return;
}
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Emblazon Runeblade
case 51770:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_originalCaster)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix runeblade forge. Set triggered = false to take reagent. But there is interrupted message. Need fix.
2009-03-15 00:48:35 -06:00
m_originalCaster->CastSpell(m_originalCaster, damage, false);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
}
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
// Deathbolt from Thalgran Blightbringer
// reflected by Freya's Ward
// Retribution by Sevenfold Retribution
case 51854:
{
Core/Spells: Small cleanup in SpellEffects, spells always have caster
2010-12-22 20:18:34 +02:00
if (!unitTarget)
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
return;
if (unitTarget->HasAura(51845))
unitTarget->CastSpell(m_caster, 51856, true);
else
m_caster->CastSpell(unitTarget, 51855, true);
break;
}
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
// Summon Ghouls On Scarlet Crusade
case 51904:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_targets.HasDst())
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
float x, y, z;
float radius = GetSpellRadius(m_spellInfo, effIndex, true);
*Implement spells: 781, 13280, 32307, 40109, 47770, 47776, 49625, 49634, 51854, 64385, by Warhead
2009-10-31 04:28:02 -07:00
for (uint8 i = 0; i < 15; ++i)
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
{
*More update about positions.
2009-08-29 23:20:16 -05:00
m_caster->GetRandomPoint(m_targets.m_dstPos, radius, x, y, z);
*Do not consider possessed creatures as pet. Also fix the bug that possessed creature does not display spells.
2009-05-25 22:52:08 -05:00
m_caster->CastSpell(x, y, z, 54522, true);
}
break;
*Some improvement of DK start zone quests (no new quest fixed)
2009-05-27 23:33:21 -05:00
}
*Fix Coyote Spirit Despawn Aura (52172) and Blood Parrot Despawn Aura (60244) - inspired by Disassembler's patch.
2009-08-05 17:00:01 +02:00
case 52173: // Coyote Spirit Despawn
case 60243: // Blood Parrot Despawn
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
if (unitTarget->GetTypeId() == TYPEID_UNIT && unitTarget->ToCreature()->isSummon())
Make a function(ToTempSummon()) which can convert Creature to TempSummon with a C++ cast(reinterpret_cast) and with a type check(isSummon()).
2010-03-27 16:08:14 +01:00
unitTarget->ToTempSummon()->UnSummon();
*Fix Coyote Spirit Despawn Aura (52172) and Blood Parrot Despawn Aura (60244) - inspired by Disassembler's patch.
2009-08-05 17:00:01 +02:00
return;
*Fix the bug that some traps without charges and spell radius cannot be triggered.
2009-06-03 23:24:57 -05:00
case 52479: // Gift of the Harvester
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget && m_originalCaster)
*Fix the bug that some traps without charges and spell radius cannot be triggered.
2009-06-03 23:24:57 -05:00
m_originalCaster->CastSpell(unitTarget, urand(0, 1) ? damage : 52505, true);
return;
*Fix spell 53110.
2009-06-14 21:05:37 -05:00
case 53110: // Devour Humanoid
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
*Fix spell 53110.
2009-06-14 21:05:37 -05:00
unitTarget->CastSpell(m_caster, damage, true);
return;
[7729] Implement skill level dependent speed bonus for mount (item 40775). Author: Lightguard
2009-04-29 00:17:33 -05:00
// Winged Steed of the Ebon Blade
case 54729:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[7729] Implement skill level dependent speed bonus for mount (item 40775). Author: Lightguard
2009-04-29 00:17:33 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
// Prevent stacking of mounts and client crashes upon dismounting
*Fix build.
2009-04-29 01:00:15 -05:00
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
// Triggered spell id dependent on riding skill
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint16 skillval = unitTarget->ToPlayer()->GetSkillValue(SKILL_RIDING))
[7729] Implement skill level dependent speed bonus for mount (item 40775). Author: Lightguard
2009-04-29 00:17:33 -05:00
{
if (skillval >= 300)
unitTarget->CastSpell(unitTarget, 54727, true);
else
unitTarget->CastSpell(unitTarget, 54726, true);
}
return;
}
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
case 58418: // Portal to Orgrimmar
case 58420: // Portal to Stormwind
{
Code Style (game + scripts only):
2010-04-08 08:20:08 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER || effIndex != 0)
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Add SpellMgr::CalculateSpellEffectAmount function for consistency of effect amount calculations in core
2010-07-14 16:57:13 +02:00
uint32 spellID = SpellMgr::CalculateSpellEffectAmount(m_spellInfo, 0);
uint32 questID = SpellMgr::CalculateSpellEffectAmount(m_spellInfo, 1);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Quests: Resolve ambiguity between QUEST_STATUS_COMPLETED and rewarded state by implementing QUEST_STATUS_REWARDED. The latter is not used in the database explicitly, only in the core. This is to prevent overhead by iterating over the rewarded quests storage multiple times.
2011-01-13 23:06:59 +01:00
if (unitTarget->ToPlayer()->GetQuestStatus(questID) == QUEST_STATUS_COMPLETE)
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
unitTarget->CastSpell(unitTarget, spellID, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7581] Move spell 58418, 58420 to script effect (first) from dummy (second). Author: VladimirMangos
2009-03-29 17:18:51 -06:00
return;
}
*Fix rock shards spell for archavon script.
2009-05-23 01:43:46 -05:00
case 58941: // Rock Shards
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget && m_originalCaster)
*Fix rock shards spell for archavon script.
2009-05-23 01:43:46 -05:00
{
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint32 i = 0; i < 3; ++i)
*Fix rock shards spell for archavon script.
2009-05-23 01:43:46 -05:00
{
m_originalCaster->CastSpell(unitTarget, 58689, true);
m_originalCaster->CastSpell(unitTarget, 58692, true);
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (((InstanceMap*)m_originalCaster->GetMap())->GetDifficulty() == REGULAR_DIFFICULTY)
*Fix rock shards spell for archavon script.
2009-05-23 01:43:46 -05:00
{
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
m_originalCaster->CastSpell(unitTarget, 58695, true);
m_originalCaster->CastSpell(unitTarget, 58696, true);
*Fix rock shards spell for archavon script.
2009-05-23 01:43:46 -05:00
}
else
{
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
m_originalCaster->CastSpell(unitTarget, 60883, true);
m_originalCaster->CastSpell(unitTarget, 60884, true);
*Fix rock shards spell for archavon script.
2009-05-23 01:43:46 -05:00
}
}
return;
*Fix Coyote Spirit Despawn Aura (52172) and Blood Parrot Despawn Aura (60244) - inspired by Disassembler's patch.
2009-08-05 17:00:01 +02:00
case 58983: // Big Blizzard Bear
*Script effect for Big Blizzard Bear - by simon.
2009-08-05 16:00:36 +02:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Script effect for Big Blizzard Bear - by simon.
2009-08-05 16:00:36 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
// Prevent stacking of mounts and client crashes upon dismounting
*Script effect for Big Blizzard Bear - by simon.
2009-08-05 16:00:36 +02:00
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
// Triggered spell id dependent on riding skill
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint16 skillval = unitTarget->ToPlayer()->GetSkillValue(SKILL_RIDING))
*Script effect for Big Blizzard Bear - by simon.
2009-08-05 16:00:36 +02:00
{
if (skillval >= 150)
unitTarget->CastSpell(unitTarget, 58999, true);
else
unitTarget->CastSpell(unitTarget, 58997, true);
}
return;
}
Core/Spells: Implemented handler for spell Create Lance, patch by 0xFuture
2010-09-06 12:22:19 +02:00
case 63845: // Create Lance
{
if (m_caster->GetTypeId() != TYPEID_PLAYER)
return;
if (m_caster->ToPlayer()->GetTeam() == ALLIANCE)
m_caster->CastSpell(m_caster, 63914, true);
else
m_caster->CastSpell(m_caster, 63919, true);
return;
}
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
case 71342: // Big Love Rocket
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
// Prevent stacking of mounts and client crashes upon dismounting
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Triggered spell id dependent on riding skill and zone
bool canFly = true;
uint32 v_map = GetVirtualMapForMapAndZone(unitTarget->GetMapId(), unitTarget->GetZoneId());
if (v_map != 530 && v_map != 571)
canFly = false;
if (canFly && v_map == 571 && !unitTarget->ToPlayer()->HasSpell(54197))
canFly = false;
float x, y, z;
unitTarget->GetPosition(x, y, z);
uint32 areaFlag = unitTarget->GetBaseMap()->GetAreaFlag(x, y, z);
AreaTableEntry const *pArea = sAreaStore.LookupEntry(areaFlag);
Core: Fix warnings
2010-11-16 14:08:12 +01:00
if (!pArea || (canFly && (pArea->flags & AREA_FLAG_NO_FLY_ZONE)))
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
canFly = false;
switch(unitTarget->ToPlayer()->GetBaseSkillValue(SKILL_RIDING))
{
case 0: unitTarget->CastSpell(unitTarget, 71343, true); break;
case 75: unitTarget->CastSpell(unitTarget, 71344, true); break;
case 150: unitTarget->CastSpell(unitTarget, 71345, true); break;
case 225:
{
if (canFly)
unitTarget->CastSpell(unitTarget, 71346, true);
else
unitTarget->CastSpell(unitTarget, 71345, true);
}break;
case 300:
{
if (canFly)
unitTarget->CastSpell(unitTarget, 71347, true);
else
unitTarget->CastSpell(unitTarget, 71345, true);
}break;
}
return;
}
case 72286: // Invincible
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
// Prevent stacking of mounts and client crashes upon dismounting
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Triggered spell id dependent on riding skill and zone
bool canFly = true;
uint32 v_map = GetVirtualMapForMapAndZone(unitTarget->GetMapId(), unitTarget->GetZoneId());
if (v_map != 530 && v_map != 571)
canFly = false;
if (canFly && v_map == 571 && !unitTarget->ToPlayer()->HasSpell(54197))
canFly = false;
float x, y, z;
unitTarget->GetPosition(x, y, z);
uint32 areaFlag = unitTarget->GetBaseMap()->GetAreaFlag(x, y, z);
AreaTableEntry const *pArea = sAreaStore.LookupEntry(areaFlag);
Core: Fix warnings
2010-11-16 14:08:12 +01:00
if (!pArea || (canFly && (pArea->flags & AREA_FLAG_NO_FLY_ZONE)))
Added new area flag to enum which marks areas you cannot fly in
2010-05-22 22:57:16 +02:00
canFly = false;
switch(unitTarget->ToPlayer()->GetBaseSkillValue(SKILL_RIDING))
{
case 75: unitTarget->CastSpell(unitTarget, 72281, true); break;
case 150: unitTarget->CastSpell(unitTarget, 72282, true); break;
case 225:
{
if (canFly)
unitTarget->CastSpell(unitTarget, 72283, true);
else
unitTarget->CastSpell(unitTarget, 72282, true);
}break;
case 300:
{
if (canFly)
unitTarget->CastSpell(unitTarget, 72284, true);
else
unitTarget->CastSpell(unitTarget, 72282, true);
}break;
}
return;
}
case 74856: // Blazing Hippogryph
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
// Prevent stacking of mounts and client crashes upon dismounting
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Triggered spell id dependent on riding skill
if (uint16 skillval = unitTarget->ToPlayer()->GetSkillValue(SKILL_RIDING))
{
if (skillval >= 300)
unitTarget->CastSpell(unitTarget, 74855, true);
else
unitTarget->CastSpell(unitTarget, 74854, true);
}
return;
}
Fixed remaining scaling mounts that have 310% speed when you have other 310% mount: Celestial Steed and X-53 Touring Rocket
2010-05-24 16:11:35 +02:00
case 75614: // Celestial Steed
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
// Prevent stacking of mounts and client crashes upon dismounting
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Triggered spell id dependent on riding skill and zone
bool canFly = true;
uint32 v_map = GetVirtualMapForMapAndZone(unitTarget->GetMapId(), unitTarget->GetZoneId());
if (v_map != 530 && v_map != 571)
canFly = false;
if (canFly && v_map == 571 && !unitTarget->ToPlayer()->HasSpell(54197))
canFly = false;
float x, y, z;
unitTarget->GetPosition(x, y, z);
uint32 areaFlag = unitTarget->GetBaseMap()->GetAreaFlag(x, y, z);
AreaTableEntry const *pArea = sAreaStore.LookupEntry(areaFlag);
Core: Fix warnings
2010-11-16 14:08:12 +01:00
if (!pArea || (canFly && (pArea->flags & AREA_FLAG_NO_FLY_ZONE)))
Fixed remaining scaling mounts that have 310% speed when you have other 310% mount: Celestial Steed and X-53 Touring Rocket
2010-05-24 16:11:35 +02:00
canFly = false;
switch(unitTarget->ToPlayer()->GetBaseSkillValue(SKILL_RIDING))
{
case 75: unitTarget->CastSpell(unitTarget, 75619, true); break;
case 150: unitTarget->CastSpell(unitTarget, 75620, true); break;
case 225:
{
if (canFly)
unitTarget->CastSpell(unitTarget, 75617, true);
else
unitTarget->CastSpell(unitTarget, 75620, true);
}break;
case 300:
{
if (canFly)
{
if (unitTarget->ToPlayer()->Has310Flyer(false))
unitTarget->CastSpell(unitTarget, 76153, true);
else
unitTarget->CastSpell(unitTarget, 75618, true);
}
else
unitTarget->CastSpell(unitTarget, 75620, true);
}break;
}
return;
}
case 75973: // X-53 Touring Rocket
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
// Prevent stacking of mounts
unitTarget->RemoveAurasByType(SPELL_AURA_MOUNTED);
// Triggered spell id dependent on riding skill
if (uint16 skillval = unitTarget->ToPlayer()->GetSkillValue(SKILL_RIDING))
{
if (skillval >= 300)
{
if (unitTarget->ToPlayer()->Has310Flyer(false))
unitTarget->CastSpell(unitTarget, 76154, true);
else
unitTarget->CastSpell(unitTarget, 75972, true);
}
else
unitTarget->CastSpell(unitTarget, 75957, true);
}
return;
}
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
case 59317: // Teleporting
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
// return from top
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (unitTarget->ToPlayer()->GetAreaId() == 4637)
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
unitTarget->CastSpell(unitTarget, 59316, true);
// teleport atop
else
unitTarget->CastSpell(unitTarget, 59314, true);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7767] Implement item 43824 work. Author: evilstar
2009-05-05 14:46:32 -05:00
return;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// random spell learn instead placeholder
case 60893: // Northrend Alchemy Research
case 61177: // Northrend Inscription Research
case 61288: // Minor Inscription Research
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
case 61756: // Northrend Inscription Research (FAST QA VERSION)
[8234] Implement support for explcit discovery spell 64323. Also better checks at loading. Author: VladimirMangos
2009-07-30 10:55:13 +08:00
case 64323: // Book of Glyph Mastery
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7136.
2009-01-21 16:18:57 -06:00
// learn random explicit discovery recipe (if any)
Core/Spells:
2011-03-04 21:18:38 +01:00
if (uint32 discoveredSpell = GetExplicitDiscoverySpell(m_spellInfo->Id, m_caster->ToPlayer()))
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->learnSpell(discoveredSpell, false);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
}
*Some work on vehicle.
2009-06-14 09:57:57 -05:00
case 62428: // Load into Catapult
Restore some commits from trinitycore2 3.1.3
2009-12-17 13:07:38 +01:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Vehicle *seat = m_caster->GetVehicleKit())
if (Unit *passenger = seat->GetPassenger(0))
if (Unit *demolisher = m_caster->GetVehicleBase())
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
passenger->CastSpell(demolisher, damage, true);
*Some work on vehicle.
2009-06-14 09:57:57 -05:00
return;
Restore some commits from trinitycore2 3.1.3
2009-12-17 13:07:38 +01:00
}
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
case 62482: // Grab Crate
Restore some commits from trinitycore2 3.1.3
2009-12-17 13:07:38 +01:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Vehicle *seat = m_caster->GetVehicleKit())
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Creature *oldContainer = dynamic_cast<Creature*>(seat->GetPassenger(1)))
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
oldContainer->DisappearAndDie();
*More update about positions.
2009-08-29 23:20:16 -05:00
// TODO: a hack, range = 11, should after some time cast, otherwise too far
Core/Spells: Use a workaround for Grab Crate, cast triggered spell with original caster as caster instead of target. Previous approach was prone to out of range errors.
2010-12-25 03:18:21 +01:00
m_caster->CastSpell(seat->GetBase(), 62496, true);
Core/Vehicles: Make the vehicle system more aura driven. Get rid of redundant checks and update relevant data.
2011-03-04 21:16:27 +01:00
unitTarget->EnterVehicle(m_caster, 1);
*Update flame levi script. Allow player to shoot down pyrite container and refill the demolishers.
2009-08-28 11:26:20 -05:00
}
}
return;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
}
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
case 60123: // Lightwell
*Fix Lightwell. By Elron
2009-08-10 15:52:11 -05:00
{
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
if (m_caster->GetTypeId() != TYPEID_UNIT || !m_caster->ToCreature()->isSummon())
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
uint32 spell_heal;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
switch(m_caster->GetEntry())
{
case 31897: spell_heal = 7001; break;
case 31896: spell_heal = 27873; break;
case 31895: spell_heal = 27874; break;
case 31894: spell_heal = 28276; break;
case 31893: spell_heal = 48084; break;
case 31883: spell_heal = 48085; break;
default:
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Unknown Lightwell spell caster %u", m_caster->GetEntry());
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
return;
*Fix Lightwell. By Elron
2009-08-10 15:52:11 -05:00
}
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
Aura * chargesaura = m_caster->GetAura(59907);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (chargesaura && chargesaura->GetCharges() > 1)
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
chargesaura->SetCharges(chargesaura->GetCharges() - 1);
Make a function(ToTempSummon()) which can convert Creature to TempSummon with a C++ cast(reinterpret_cast) and with a type check(isSummon()).
2010-03-27 16:08:14 +01:00
m_caster->CastSpell(unitTarget, spell_heal, true, NULL, NULL, m_caster->ToTempSummon()->GetSummonerGUID());
*Add spell_bonus_data for lightwell - by Elron
2009-08-17 02:53:39 +02:00
}
else
Make a function(ToTempSummon()) which can convert Creature to TempSummon with a C++ cast(reinterpret_cast) and with a type check(isSummon()).
2010-03-27 16:08:14 +01:00
m_caster->ToTempSummon()->UnSummon();
*Update flame leviathan script.
2009-08-23 01:08:09 -05:00
return;
*Fix Lightwell. By Elron
2009-08-10 15:52:11 -05:00
}
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
// Stoneclaw Totem
case 55328: // Rank 1
case 55329: // Rank 2
case 55330: // Rank 3
case 55332: // Rank 4
case 55333: // Rank 5
case 55335: // Rank 6
case 55278: // Rank 7
case 58589: // Rank 8
case 58590: // Rank 9
case 58591: // Rank 10
{
int32 basepoints0 = damage;
// Cast Absorb on totems
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint8 slot = SUMMON_SLOT_TOTEM; slot < MAX_TOTEM_SLOT; ++slot)
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->m_SummonSlot[slot])
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
continue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
Creature* totem = unitTarget->GetMap()->GetCreature(unitTarget->m_SummonSlot[slot]);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (totem && totem->isTotem())
*[8480] Provided real-time update for guidl ranks rights.
2009-09-14 13:34:23 -07:00
{
m_caster->CastCustomSpell(totem, 55277, &basepoints0, NULL, NULL, true);
}
}
// Glyph of Stoneclaw Totem
if (AuraEffect *aur=unitTarget->GetAuraEffect(63298, 0))
{
basepoints0 *= aur->GetAmount();
m_caster->CastCustomSpell(unitTarget, 55277, &basepoints0, NULL, NULL, true);
}
break;
}
Support for spell 67751 used by Argent Confessor Paletress. Thanks to QAston and Gyullo.
2009-12-27 18:01:34 -03:00
case 66545: //Summon Memory
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
uint8 uiRandom = urand(0, 25);
uint32 uiSpells[26] = {66704, 66705, 66706, 66707, 66709, 66710, 66711, 66712, 66713, 66714, 66715, 66708, 66708, 66691, 66692, 66694, 66695, 66696, 66697, 66698, 66699, 66700, 66701, 66702, 66703, 66543};
Support for spell 67751 used by Argent Confessor Paletress. Thanks to QAston and Gyullo.
2009-12-27 18:01:34 -03:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->CastSpell(m_caster, uiSpells[uiRandom], true);
Support for spell 67751 used by Argent Confessor Paletress. Thanks to QAston and Gyullo.
2009-12-27 18:01:34 -03:00
break;
}
Fix spell 45668
2010-02-23 23:48:07 +01:00
case 45668: // Ultra-Advanced Proto-Typical Shortening Blaster
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT)
return;
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Fix spell 45668
2010-02-23 23:48:07 +01:00
if (roll_chance_i(50)) // chance unknown, using 50
return;
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Fix spell 45668
2010-02-23 23:48:07 +01:00
static uint32 const spellPlayer[5] =
{
45674, // Bigger!
45675, // Shrunk
45678, // Yellow
45682, // Ghost
45684 // Polymorph
};
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Fix spell 45668
2010-02-23 23:48:07 +01:00
static uint32 const spellTarget[5] = {
45673, // Bigger!
45672, // Shrunk
45677, // Yellow
45681, // Ghost
45683 // Polymorph
};
Code Style: Remove trailing spaces
2010-04-07 18:09:10 +02:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->CastSpell(m_caster, spellPlayer[urand(0, 4)], true);
unitTarget->CastSpell(unitTarget, spellTarget[urand(0, 4)], true);
Fix spell 45668
2010-02-23 23:48:07 +01:00
break;
}
Fixed spell 64142 (Upper Deck - Create Foam Sword)
2010-06-16 20:59:15 +02:00
case 64142: // Upper Deck - Create Foam Sword
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Player *plr = unitTarget->ToPlayer();
static uint32 const itemId[] = {45061, 45176, 45177, 45178, 45179, 0};
// player can only have one of these items
Fixed compile
2010-06-16 21:32:34 +02:00
for (uint32 const *itr = &itemId[0]; *itr; ++itr)
Fixed spell 64142 (Upper Deck - Create Foam Sword)
2010-06-16 20:59:15 +02:00
if (plr->HasItemCount(*itr, 1, true))
return;
Add spaces after commas
2011-04-29 20:47:02 +02:00
DoCreateItem(effIndex, itemId[urand(0, 4)]);
Fixed spell 64142 (Upper Deck - Create Foam Sword)
2010-06-16 20:59:15 +02:00
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case SPELLFAMILY_PALADIN:
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
[8309] Fixed paladin judgement selection code in some places. Author: KAPATEJIb
2009-08-05 16:39:09 -05:00
// Judgement (seal trigger)
if (m_spellInfo->Category == SPELLCATEGORY_JUDGEMENT)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || !unitTarget->isAlive())
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
uint32 spellId1 = 0;
uint32 spellId2 = 0;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Judgement self add switch
switch (m_spellInfo->Id)
{
case 53407: spellId1 = 20184; break; // Judgement of Justice
case 20271: // Judgement of Light
case 57774: spellId1 = 20185; break; // Judgement of Light
case 53408: spellId1 = 20186; break; // Judgement of Wisdom
default:
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("Unsupported Judgement (seal trigger) spell (Id: %u) in Spell::EffectScriptEffect", m_spellInfo->Id);
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
}
// all seals have aura dummy in 2 effect
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraApplicationMap & sealAuras = m_caster->GetAppliedAuras();
for (Unit::AuraApplicationMap::iterator iter = sealAuras.begin(); iter != sealAuras.end();)
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
Aura * aura = iter->second->GetBase();
if (IsSealSpell(aura->GetSpellProto()))
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
if (AuraEffect * aureff = aura->GetEffect(2))
if (aureff->GetAuraType() == SPELL_AURA_DUMMY)
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
{
if (sSpellStore.LookupEntry(aureff->GetAmount()))
spellId2 = aureff->GetAmount();
break;
}
if (!spellId2)
{
switch (iter->first)
{
*Heart of the Crusader now works, thanks lobuz
2009-11-17 19:24:31 -08:00
// Seal of light, Seal of wisdom, Seal of justice
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
case 20165:
case 20166:
case 20164:
*Heart of the Crusader now works, thanks lobuz
2009-11-17 19:24:31 -08:00
spellId2 = 54158;
*Fix seals: command, justice, wisdom, light unleashing damage.
2009-04-09 14:58:25 +02:00
}
}
break;
}
else
++iter;
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
if (spellId1)
m_caster->CastSpell(unitTarget, spellId1, true);
if (spellId2)
m_caster->CastSpell(unitTarget, spellId2, true);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
}
}
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
case SPELLFAMILY_POTION:
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
switch(m_spellInfo->Id)
*Update to Mangos 7083.
2009-01-14 00:35:13 -06:00
{
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Netherbloom
case 28702:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
// 25% chance of casting a random buff
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (roll_chance_i(75))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// triggered spells are 28703 to 28707
// Note: some sources say, that there was the possibility of
// receiving a debuff. However, this seems to be removed by a patch.
const uint32 spellid = 28703;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// don't overwrite an existing aura
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint8 i = 0; i < 5; ++i)
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->HasAura(spellid + i))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
unitTarget->CastSpell(unitTarget, spellid+urand(0, 4), true);
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
// Nightmare Vine
case 28720:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
// 25% chance of casting Nightmare Pollen
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (roll_chance_i(75))
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
return;
unitTarget->CastSpell(unitTarget, 28721, true);
break;
}
*Update to Mangos 7083.
2009-01-14 00:35:13 -06:00
}
*Update to Mangos 7125.
2009-01-20 19:59:43 -06:00
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Fix Pestilence and Glyph of Diseases.
2009-06-14 21:04:44 +02:00
case SPELLFAMILY_DEATHKNIGHT:
{
// Pestilence
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_spellInfo->SpellFamilyFlags[1]&0x10000)
*Fix Pestilence and Glyph of Diseases.
2009-06-14 21:04:44 +02:00
{
// Get diseases on target of spell
if (m_targets.getUnitTarget() && // Glyph of Disease - cast on unit target too to refresh aura
(m_targets.getUnitTarget() != unitTarget || m_caster->GetAura(63334)))
{
// And spread them on target
// Blood Plague
if (m_targets.getUnitTarget()->GetAura(55078))
m_caster->CastSpell(unitTarget, 55078, true);
// Frost Fever
if (m_targets.getUnitTarget()->GetAura(55095))
m_caster->CastSpell(unitTarget, 55095, true);
}
}
*Fix raise dead spell - original patch by Astellar, thanks for some help in conversion for Azrael
2009-06-18 14:17:11 +02:00
break;
*Fix Pestilence and Glyph of Diseases.
2009-06-14 21:04:44 +02:00
}
*Implement immunity removal part for Shattering Throw ability - by thenecromancer.
2009-07-27 17:32:56 +02:00
case SPELLFAMILY_WARRIOR:
{
// Shattering Throw
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
if (m_spellInfo->SpellFamilyFlags[1] & 0x00400000)
*Implement immunity removal part for Shattering Throw ability - by thenecromancer.
2009-07-27 17:32:56 +02:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
*Implement immunity removal part for Shattering Throw ability - by thenecromancer.
2009-07-27 17:32:56 +02:00
return;
// remove shields, will still display immune to damage part
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
unitTarget->RemoveAurasWithMechanic(1<<MECHANIC_IMMUNE_SHIELD, AURA_REMOVE_BY_ENEMY_SPELL);
*Implement immunity removal part for Shattering Throw ability - by thenecromancer.
2009-07-27 17:32:56 +02:00
return;
}
break;
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// normal DB scripted effect
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Spell ScriptStart spellid %u in EffectScriptEffect(%u)", m_spellInfo->Id, effIndex);
DB Scripts: Fix calling of DB scripts from spell_scripts table
2010-08-28 21:01:16 +06:00
m_caster->GetMap()->ScriptsStart(sSpellScripts, uint32(m_spellInfo->Id | (effIndex << 24)), m_caster, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSanctuary(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fix spelleffect sanctuary
2010-11-13 18:04:56 +01:00
unitTarget->getHostileRefManager().UpdateVisibility();
Core/Spells: Effect sanctuary should stop attackers without threatlist too
2010-11-13 20:23:05 +01:00
Unit::AttackerSet const& attackers = unitTarget->getAttackers();
for (Unit::AttackerSet::const_iterator itr = attackers.begin(); itr != attackers.end();)
{
if (!(*itr)->canSeeOrDetect(unitTarget))
(*(itr++))->AttackStop();
else
++itr;
}
Core/Spells: Fix spelleffect sanctuary
2010-11-13 18:04:56 +01:00
unitTarget->m_lastSanctuaryTime = getMSTime();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Vanish allows to remove all threat and cast regular stealth so other spells can be used
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER
Fix crash in AuraEffect::HandleShapeshiftBoosts
2010-03-08 17:20:25 +01:00
&& m_spellInfo->SpellFamilyName == SPELLFAMILY_ROGUE
&& (m_spellInfo->SpellFamilyFlags[0] & SPELLFAMILYFLAG_ROGUE_VANISH))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Convert some C style casts to new functions
2010-03-11 20:51:31 +01:00
m_caster->ToPlayer()->RemoveAurasByType(SPELL_AURA_MOD_ROOT);
Support for spell 67729.
2009-12-26 14:46:19 -03:00
// Overkill
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->ToPlayer()->HasSpell(58426))
Fixed overkill proc after vanish. by bodompelle
2009-12-24 12:55:29 +01:00
m_caster->CastSpell(m_caster, 58427, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectAddComboPoints(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_caster->m_movedPlayer)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage <= 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Allow pet to have combo points.
2009-09-01 00:17:39 -05:00
m_caster->m_movedPlayer->AddComboPoints(unitTarget, damage, this);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDuel(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Spells: Small cleanup in SpellEffects, spells always have caster
2010-12-22 20:18:34 +02:00
if (!unitTarget || m_caster->GetTypeId() != TYPEID_PLAYER || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player *caster = (Player*)m_caster;
Player *target = (Player*)unitTarget;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// caster or target already have requested duel
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (caster->duel || target->duel || !target->GetSocial() || target->GetSocial()->HasIgnore(caster->GetGUIDLow()))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Players can only fight a duel with each other outside (=not inside dungeons and not in capital cities)
// Don't have to check the target's map since you cannot challenge someone across maps
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (caster->GetMap()->Instanceable())
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
//if (mapid != 0 && mapid != 1 && mapid != 530 && mapid != 571 && mapid != 609)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
SendCastResult(SPELL_FAILED_NO_DUELING); // Dueling isn't allowed here
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
AreaTableEntry const* casterAreaEntry = GetAreaEntryByAreaID(caster->GetZoneId());
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (casterAreaEntry && (casterAreaEntry->flags & AREA_FLAG_CAPITAL))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
SendCastResult(SPELL_FAILED_NO_DUELING); // Dueling isn't allowed here
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
AreaTableEntry const* targetAreaEntry = GetAreaEntryByAreaID(target->GetZoneId());
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (targetAreaEntry && (targetAreaEntry->flags & AREA_FLAG_CAPITAL))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
SendCastResult(SPELL_FAILED_NO_DUELING); // Dueling isn't allowed here
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//CREATE DUEL FLAG OBJECT
GameObject* pGameObj = new GameObject;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 gameobject_id = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Map *map = m_caster->GetMap();
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (!pGameObj->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_GAMEOBJECT), gameobject_id,
*Update to Mangos 7208. Implement phase system.
2009-01-31 16:38:50 -06:00
map, m_caster->GetPhaseMask(),
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->GetPositionX()+(unitTarget->GetPositionX()-m_caster->GetPositionX())/2 ,
m_caster->GetPositionY()+(unitTarget->GetPositionY()-m_caster->GetPositionY())/2 ,
m_caster->GetPositionZ(),
[7715] Provided way for scripts set alternative gameobject state for client show. Author: VladimirMangos
2009-04-27 18:36:10 -05:00
m_caster->GetOrientation(), 0.0f, 0.0f, 0.0f, 0.0f, 0, GO_STATE_READY))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
delete pGameObj;
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
pGameObj->SetUInt32Value(GAMEOBJECT_FACTION, m_caster->getFaction());
pGameObj->SetUInt32Value(GAMEOBJECT_LEVEL, m_caster->getLevel()+1);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 duration = GetSpellDuration(m_spellInfo);
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
pGameObj->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pGameObj->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectSummonObject(effIndex, pGameObj);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->AddGameObject(pGameObj);
map->Add(pGameObj);
//END
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Send request
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
WorldPacket data(SMSG_DUEL_REQUESTED, 8 + 8);
data << uint64(pGameObj->GetGUID());
data << uint64(caster->GetGUID());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
caster->GetSession()->SendPacket(&data);
target->GetSession()->SendPacket(&data);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// create duel-info
DuelInfo *duel = new DuelInfo;
duel->initiator = caster;
duel->opponent = target;
duel->startTime = 0;
duel->startTimer = 0;
caster->duel = duel;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
DuelInfo *duel2 = new DuelInfo;
duel2->initiator = caster;
duel2->opponent = caster;
duel2->startTime = 0;
duel2->startTimer = 0;
target->duel = duel2;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
caster->SetUInt64Value(PLAYER_DUEL_ARBITER, pGameObj->GetGUID());
target->SetUInt64Value(PLAYER_DUEL_ARBITER, pGameObj->GetGUID());
Core/ScriptMgr: Add hooks for duel phases: OnDuelRequest, OnDuelStart, OnDuelEnd
2010-09-13 01:42:14 +03:00
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
sScriptMgr->OnPlayerDuelRequest(target, caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectStuck(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (!sWorld->getBoolConfig(CONFIG_CAST_UNSTUCK))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* pTarget = (Player*)unitTarget;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Spell Effect: Stuck");
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outDetail("Player %s (guid %u) used auto-unstuck future at map %u (%f, %f, %f)", pTarget->GetName(), pTarget->GetGUIDLow(), m_caster->GetMapId(), m_caster->GetPositionX(), pTarget->GetPositionY(), pTarget->GetPositionZ());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (pTarget->isInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix the bug that .start always send dk back to start zone.
2009-08-17 23:51:08 -05:00
pTarget->TeleportTo(pTarget->GetStartPosition(), unitTarget == m_caster ? TELE_TO_SPELL : 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// homebind location is loaded always
Add spaces after commas
2011-04-29 20:47:02 +02:00
// pTarget->TeleportTo(pTarget->m_homebindMapId, pTarget->m_homebindX, pTarget->m_homebindY, pTarget->m_homebindZ, pTarget->GetOrientation(), (unitTarget == m_caster ? TELE_TO_SPELL : 0));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Stuck spell trigger Hearthstone cooldown
SpellEntry const *spellInfo = sSpellStore.LookupEntry(8690);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!spellInfo)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
Spell spell(pTarget, spellInfo, true, 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
spell.SendSpellCooldown();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSummonPlayer(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Evil Twin (ignore player summon, but hide this for summoner)
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->HasAura(23445))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
float x, y, z;
m_caster->GetClosePoint(x, y, z, unitTarget->GetObjectSize());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
unitTarget->ToPlayer()->SetSummonPoint(m_caster->GetMapId(), x, y, z);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
WorldPacket data(SMSG_SUMMON_REQUEST, 8+4+4);
data << uint64(m_caster->GetGUID()); // summoner guid
data << uint32(m_caster->GetZoneId()); // summoner zone
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
data << uint32(MAX_PLAYER_SUMMON_DELAY*IN_MILLISECONDS); // auto decline after msecs
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->GetSession()->SendPacket(&data);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
static ScriptInfo generateActivateCommand()
{
ScriptInfo si;
si.command = SCRIPT_COMMAND_ACTIVATE_OBJECT;
return si;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectActivateObject(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!gameObjTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
static ScriptInfo activateCommand = generateActivateCommand();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
int32 delay_secs = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8252] Move DB scripting code from global World to Map. Author: Ambal
2009-07-31 10:48:34 +08:00
gameObjTarget->GetMap()->ScriptCommandStart(activateCommand, delay_secs, m_caster, gameObjTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectApplyGlyph(SpellEffIndex effIndex)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Fix one WPE exploit.
2010-03-23 14:38:31 -05:00
if (m_caster->GetTypeId() != TYPEID_PLAYER || m_glyphIndex >= MAX_GLYPH_SLOT_INDEX)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
Player *player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Add level requirement check for glyph sockets
2010-09-08 06:11:32 +03:00
// glyph sockets level requirement
uint8 minLevel = 0;
switch (m_glyphIndex)
{
case 0:
case 1: minLevel = 15; break;
case 2: minLevel = 50; break;
case 3: minLevel = 30; break;
case 4: minLevel = 70; break;
case 5: minLevel = 80; break;
}
if (minLevel && m_caster->getLevel() < minLevel)
{
SendCastResult(SPELL_FAILED_GLYPH_SOCKET_LOCKED);
return;
}
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
// apply new one
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (uint32 glyph = m_spellInfo->EffectMiscValue[effIndex])
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Fix one WPE exploit.
2010-03-23 14:38:31 -05:00
if (GlyphPropertiesEntry const *gp = sGlyphPropertiesStore.LookupEntry(glyph))
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Fix one WPE exploit.
2010-03-23 14:38:31 -05:00
if (GlyphSlotEntry const *gs = sGlyphSlotStore.LookupEntry(player->GetGlyphSlot(m_glyphIndex)))
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Fix one WPE exploit.
2010-03-23 14:38:31 -05:00
if (gp->TypeFlags != gs->TypeFlags)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
SendCastResult(SPELL_FAILED_INVALID_GLYPH);
Small code cleanup and partial merge with dev branch Author: tomrus88
2009-03-21 14:53:38 -06:00
return; // glyph slot mismatch
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Small code cleanup and partial merge with dev branch Author: tomrus88
2009-03-21 14:53:38 -06:00
// remove old glyph
Fix one WPE exploit.
2010-03-23 14:38:31 -05:00
if (uint32 oldglyph = player->GetGlyph(m_glyphIndex))
Small code cleanup and partial merge with dev branch Author: tomrus88
2009-03-21 14:53:38 -06:00
{
Fix one WPE exploit.
2010-03-23 14:38:31 -05:00
if (GlyphPropertiesEntry const *old_gp = sGlyphPropertiesStore.LookupEntry(oldglyph))
Small code cleanup and partial merge with dev branch Author: tomrus88
2009-03-21 14:53:38 -06:00
{
player->RemoveAurasDueToSpell(old_gp->SpellId);
player->SetGlyph(m_glyphIndex, 0);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
player->CastSpell(m_caster, gp->SpellId, true);
player->SetGlyph(m_glyphIndex, glyph);
*Switch to support client version 3.1.3
2009-06-11 00:45:59 -05:00
player->SendTalentsInfoData(false);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectEnchantHeldItem(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// this is only item spell effect applied to main-hand weapon of target player (players in area)
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* item_owner = (Player*)unitTarget;
Item* item = item_owner->GetItemByPos(INVENTORY_SLOT_BAG_0, EQUIPMENT_SLOT_MAINHAND);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!item)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// must be equipped
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!item ->IsEquipped())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (m_spellInfo->EffectMiscValue[effIndex])
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 enchant_id = m_spellInfo->EffectMiscValue[effIndex];
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 duration = GetSpellDuration(m_spellInfo); //Try duration index first ..
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!duration)
*Calculate base spell damage/healing when casting but not hitting.
2008-12-25 17:39:46 -06:00
duration = damage;//+1; //Base points after ..
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!duration)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
duration = 10; //10 seconds for enchants which don't have listed duration
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
SpellItemEnchantmentEntry const *pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pEnchant)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Always go to temp enchantment slot
EnchantmentSlot slot = TEMP_ENCHANTMENT_SLOT;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Enchantment will not be applied if a different one already exists
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (item->GetEnchantmentId(slot) && item->GetEnchantmentId(slot) != enchant_id)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Apply the temporary enchantment
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
item->SetEnchantment(slot, enchant_id, duration*IN_MILLISECONDS, 0);
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
item_owner->ApplyEnchantment(item, slot, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDisEnchant(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* p_caster = (Player*)m_caster;
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
if (!itemTarget || !itemTarget->GetTemplate()->DisenchantID)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
p_caster->UpdateCraftSkill(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->ToPlayer()->SendLoot(itemTarget->GetGUID(), LOOT_DISENCHANTING);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// item will be removed at disenchanting end
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectInebriate(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player *player = (Player*)unitTarget;
uint16 currentDrunk = player->GetDrunkValue();
uint16 drunkMod = damage * 256;
if (currentDrunk + drunkMod > 0xFFFF)
currentDrunk = 0xFFFF;
else
currentDrunk += drunkMod;
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
player->SetDrunkValue(currentDrunk, m_CastItem ? m_CastItem->GetEntry() : 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectFeedPet(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player *_player = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Mangos [7009] Fixed spell 6991 work.
2009-01-02 15:49:28 -06:00
Item* foodItem = m_targets.getItemTarget();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!foodItem)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Pet *pet = _player->GetPet();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pet)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pet->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
int32 benefit = pet->GetCurrentFoodBenefitLevel(foodItem->GetTemplate()->ItemLevel);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (benefit <= 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fixed crash in EffectFeedPet
2010-09-02 22:04:08 +02:00
ExecuteLogEffectDestroyItem(effIndex, foodItem->GetEntry());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 count = 1;
Core/Spells: Fixed crash in EffectFeedPet
2010-09-02 22:04:08 +02:00
_player->DestroyItemCount(foodItem, count, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// TODO: fix crash when a spell has two effects, both pointed at the same item target
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
m_caster->CastCustomSpell(pet, m_spellInfo->EffectTriggerSpell[effIndex], &benefit, NULL, NULL, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDismissPet(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
Pet* pet = m_caster->ToPlayer()->GetPet();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// not let dismiss dead pet
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pet||!pet->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectUnsummonObject(effIndex, pet);
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->RemovePet(pet, PET_SAVE_NOT_IN_SLOT);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSummonObject(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 go_id = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint8 slot = 0;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
switch(m_spellInfo->Effect[effIndex])
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
case SPELL_EFFECT_SUMMON_OBJECT_SLOT1: slot = 0; break;
case SPELL_EFFECT_SUMMON_OBJECT_SLOT2: slot = 1; break;
case SPELL_EFFECT_SUMMON_OBJECT_SLOT3: slot = 2; break;
case SPELL_EFFECT_SUMMON_OBJECT_SLOT4: slot = 3; break;
default: return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Backed out changeset 9b89f42ffbd8 - mangos [8219]
2009-07-30 11:45:51 +02:00
uint64 guid = m_caster->m_ObjectSlot[slot];
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (guid != 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Backed out changeset 9b89f42ffbd8 - mangos [8219]
2009-07-30 11:45:51 +02:00
GameObject* obj = NULL;
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (m_caster)
Backed out changeset 9b89f42ffbd8 - mangos [8219]
2009-07-30 11:45:51 +02:00
obj = m_caster->GetMap()->GetGameObject(guid);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (obj)
Backed out changeset 9b89f42ffbd8 - mangos [8219]
2009-07-30 11:45:51 +02:00
{
// Recast case - null spell id to make auras not be removed on object remove from world
if (m_spellInfo->Id == obj->GetSpellId())
obj->SetSpellId(0);
m_caster->RemoveGameObject(obj, true);
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->m_ObjectSlot[slot] = 0;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
GameObject* pGameObj = new GameObject;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
float x, y, z;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// If dest location if present
*More update about positions.
2009-08-29 23:20:16 -05:00
if (m_targets.HasDst())
m_targets.m_dstPos.GetPosition(x, y, z);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Summon in random point all other units if location present
else
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->GetClosePoint(x, y, z, DEFAULT_WORLD_OBJECT_SIZE);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Map *map = m_caster->GetMap();
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (!pGameObj->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_GAMEOBJECT), go_id, map,
[7715] Provided way for scripts set alternative gameobject state for client show. Author: VladimirMangos
2009-04-27 18:36:10 -05:00
m_caster->GetPhaseMask(), x, y, z, m_caster->GetOrientation(), 0.0f, 0.0f, 0.0f, 0.0f, 0, GO_STATE_READY))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
delete pGameObj;
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
//pGameObj->SetUInt32Value(GAMEOBJECT_LEVEL, m_caster->getLevel());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 duration = GetSpellDuration(m_spellInfo);
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
pGameObj->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pGameObj->SetSpellId(m_spellInfo->Id);
m_caster->AddGameObject(pGameObj);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectSummonObject(effIndex, pGameObj);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
map->Add(pGameObj);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->m_ObjectSlot[slot] = pGameObj->GetGUID();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectResurrect(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->IsInWorld())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
switch (m_spellInfo->Id)
{
// Defibrillate (Goblin Jumper Cables) have 33% chance on success
case 8342:
if (roll_chance_i(67))
{
m_caster->CastSpell(m_caster, 8338, true, m_CastItem);
return;
}
break;
// Defibrillate (Goblin Jumper Cables XL) have 50% chance on success
case 22999:
if (roll_chance_i(50))
{
m_caster->CastSpell(m_caster, 23055, true, m_CastItem);
return;
}
break;
Fix Spell 54732, Defibrillate from Gnomish Army Knife (now has success chance roll)
2010-06-20 00:55:54 +02:00
// Defibrillate ( Gnomish Army Knife) have 67% chance on success_list
case 54732:
if (roll_chance_i(33))
{
return;
}
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
default:
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
Player* pTarget = unitTarget->ToPlayer();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (pTarget->isRessurectRequested()) // already have one active request
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core:
2010-08-26 01:20:57 +06:00
uint32 health = pTarget->CountPctFromMaxHealth(damage);
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
uint32 mana = CalculatePctN(pTarget->GetMaxPower(POWER_MANA), damage);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
ExecuteLogEffectResurrect(effIndex, pTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pTarget->setResurrectRequestData(m_caster->GetGUID(), m_caster->GetMapId(), m_caster->GetPositionX(), m_caster->GetPositionY(), m_caster->GetPositionZ(), health, mana);
SendResurrectRequest(pTarget);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectAddExtraAttacks(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
if (!unitTarget || !unitTarget->isAlive() || !unitTarget->getVictim())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (unitTarget->m_extraAttacks)
*Merge.
2009-06-27 16:37:29 +02:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
unitTarget->m_extraAttacks = damage;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectExtraAttacks(effIndex, unitTarget->getVictim(), damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectParry(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
if (unitTarget && unitTarget->GetTypeId() == TYPEID_PLAYER)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->SetCanParry(true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectBlock(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
if (unitTarget && unitTarget->GetTypeId() == TYPEID_PLAYER)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->SetCanBlock(true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectLeap(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->isInFlight())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_targets.HasDst())
[svn] Disable combat_reach spams.
2008-11-01 18:52:59 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Move target handling of TARGET_DEST_CASTER_FRONT_LEAP out of SPELL_EFFECT_LEAP handler, this fixes spells with SPELL_EFFECT_LEAP using other target types.
2010-07-21 02:06:51 +02:00
unitTarget->NearTeleportTo(m_targets.m_dstPos.GetPositionX(), m_targets.m_dstPos.GetPositionY(), m_targets.m_dstPos.GetPositionZ(), m_targets.m_dstPos.GetOrientation(), unitTarget == m_caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectReputation(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
Player *_player = (Player*)unitTarget;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
int32 rep_change = damage;//+1; // field store reputation change -1
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 faction_id = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
FactionEntry const* factionEntry = sFactionStore.LookupEntry(faction_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
if (!factionEntry)
return;
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (RepRewardRate const * repData = sObjectMgr->GetRepRewardRate(faction_id))
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
{
Core/Game: fix all warnings related to converting doubles and floats.
2010-08-22 12:39:39 -07:00
rep_change = int32((float)rep_change * repData->spell_rate);
*Implement RepRewardRate for spells.
2010-07-27 02:25:22 +02:00
}
Backed out changeset f751065ec933
2010-08-09 11:33:31 -06:00
_player->GetReputationMgr().ModifyReputation(factionEntry, rep_change);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectQuestComplete(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Fix SpellEffect Quest Complete: shall work if player is the unitTarget
2010-01-25 20:45:02 +01:00
Player *pPlayer;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fix SpellEffect Quest Complete: shall work if player is the unitTarget
2010-01-25 20:45:02 +01:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
pPlayer = (Player*)m_caster;
Re-add event support for type 10 (goober) GOs. By Biglad
2010-01-27 14:50:42 -03:00
else if (unitTarget && unitTarget->GetTypeId() == TYPEID_PLAYER)
Fix SpellEffect Quest Complete: shall work if player is the unitTarget
2010-01-25 20:45:02 +01:00
pPlayer = (Player*)unitTarget;
else
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 quest_id = m_spellInfo->EffectMiscValue[effIndex];
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
if (quest_id)
{
uint16 log_slot = pPlayer->FindQuestSlot(quest_id);
if (log_slot < MAX_QUEST_LOG_SIZE)
pPlayer->AreaExploredOrEventHappens(quest_id);
sigh, i did the same compile error mistake
2010-07-22 13:02:47 +02:00
else if (!pPlayer->GetQuestRewardStatus(quest_id)) // never rewarded before
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
pPlayer->CompleteQuest(quest_id); // quest not in log - for internal use
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectForceDeselect(SpellEffIndex /*effIndex*/)
Change SPELL_EFFECT_SUMMON_PHANTAS to SPELL_EFFECT_FORCE_DESELECT and allow it to be casted with active pet
2010-01-13 10:27:44 +01:00
{
* Fix CRLF.
2010-01-13 18:22:31 +01:00
WorldPacket data(SMSG_CLEAR_TARGET, 8);
data << uint64(m_caster->GetGUID());
Change SPELL_EFFECT_SUMMON_PHANTAS to SPELL_EFFECT_FORCE_DESELECT and allow it to be casted with active pet
2010-01-13 10:27:44 +01:00
m_caster->SendMessageToSet(&data, true);
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSelfResurrect(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->IsInWorld())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
uint32 health = 0;
uint32 mana = 0;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// flat case
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
health = uint32(-damage);
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
mana = m_spellInfo->EffectMiscValue[effIndex];
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
// percent case
else
{
Core:
2010-08-26 01:20:57 +06:00
health = unitTarget->CountPctFromMaxHealth(damage);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetMaxPower(POWER_MANA) > 0)
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
mana = CalculatePctN(unitTarget->GetMaxPower(POWER_MANA), damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
Player *plr = unitTarget->ToPlayer();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
plr->ResurrectPlayer(0.0f);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
plr->SetHealth(health);
plr->SetPower(POWER_MANA, mana);
plr->SetPower(POWER_RAGE, 0);
plr->SetPower(POWER_ENERGY, plr->GetMaxPower(POWER_ENERGY));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
plr->SpawnCorpseBones();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSkinning(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (unitTarget->GetTypeId() != TYPEID_UNIT)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Core/Spells: Small cleanup in SpellEffects, spells always have caster
2010-12-22 20:18:34 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
Creature* creature = unitTarget->ToCreature();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 targetLevel = creature->getLevel();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Merge from Mangos. Add MapReference. Author: hunuza.
2008-11-18 19:40:06 -06:00
uint32 skill = creature->GetCreatureInfo()->GetRequiredLootSkill();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->ToPlayer()->SendLoot(creature->GetGUID(), LOOT_SKINNING);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
creature->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_SKINNABLE);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 reqValue = targetLevel < 10 ? 0 : targetLevel < 20 ? (targetLevel-10)*10 : targetLevel*5;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
int32 skillValue = m_caster->ToPlayer()->GetPureSkillValue(skill);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Double chances for elites
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
m_caster->ToPlayer()->UpdateGatherSkill(skill, skillValue, reqValue, creature->isElite() ? 2 : 1);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectCharge(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Fix build.
2009-07-01 17:47:31 -05:00
Unit *target = m_targets.getUnitTarget();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!target)
*Fix build.
2009-07-01 17:47:31 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix build.
2009-07-01 17:47:31 -05:00
float x, y, z;
target->GetContactPoint(m_caster, x, y, z);
m_caster->GetMotionMaster()->MoveCharge(x, y, z);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8089] Implement SPELL_EFFECT_CHARGE2(149), more correct monster flags use in charge effects. Author: VladimirMangos
2009-07-01 17:36:34 -05:00
// not all charge effects used in negative spells
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if (!IsPositiveSpell(m_spellInfo->Id) && m_caster->GetTypeId() == TYPEID_PLAYER)
*Fix build.
2009-07-01 17:47:31 -05:00
m_caster->Attack(target, true);
[8089] Implement SPELL_EFFECT_CHARGE2(149), more correct monster flags use in charge effects. Author: VladimirMangos
2009-07-01 17:36:34 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectChargeDest(SpellEffIndex /*effIndex*/)
[8089] Implement SPELL_EFFECT_CHARGE2(149), more correct monster flags use in charge effects. Author: VladimirMangos
2009-07-01 17:36:34 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.HasDst())
*Fix build.
2009-07-01 17:47:31 -05:00
{
*Correct typo in CastSpeedSlow spellgroup - by tassader1000, thanks azazel_kon for sql
2010-07-19 19:28:54 +02:00
float x, y, z;
*Rename SPELL_EFFECT_CHARGE_2 to SPELL_EFFECT_CHARGE_DEST, fix its implementation.
2010-07-19 19:22:05 +02:00
m_targets.m_dstPos.GetPosition(x, y, z);
m_caster->GetMotionMaster()->MoveCharge(x, y, z);
*Fix build.
2009-07-01 17:47:31 -05:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectKnockBack(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Changed boss knockback immunity
2011-05-07 22:16:30 +02:00
if (Creature* creatureTarget = unitTarget->ToCreature())
if (creatureTarget->isWorldBoss() || creatureTarget->IsDungeonBoss())
return;
*Fix Glyph of Typhoon
2009-08-18 00:35:32 +02:00
// Typhoon
if (m_spellInfo->SpellFamilyName == SPELLFAMILY_DRUID && m_spellInfo->SpellFamilyFlags[1] & 0x01000000)
{
// Glyph of Typhoon
if (m_caster->HasAura(62135))
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix Glyph of Typhoon
2009-08-18 00:35:32 +02:00
// Thunderstorm
if (m_spellInfo->SpellFamilyName == SPELLFAMILY_SHAMAN && m_spellInfo->SpellFamilyFlags[1] & 0x00002000)
{
// Glyph of Thunderstorm
if (m_caster->HasAura(62132))
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Interruption should be checked after knowing that the knockback effect will happen (in this case, after the glyph checks).
2011-05-05 18:08:01 -03:00
// Instantly interrupt non melee spells being casted
if (unitTarget->IsNonMeleeSpellCasted(true))
unitTarget->InterruptNonMeleeSpells(true);
*Fix the calculation of knockback.
2009-08-25 23:50:58 -05:00
float ratio = m_caster->GetCombatReach() / std::max(unitTarget->GetCombatReach(), 1.0f);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (ratio < 1.0f)
*Fix the calculation of knockback.
2009-08-25 23:50:58 -05:00
ratio = ratio * ratio * ratio * 0.1f; // volume = length^3
else
ratio = 0.1f; // dbc value ratio
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float speedxy = float(m_spellInfo->EffectMiscValue[effIndex]) * ratio;
*Do not allow to knockback target which is much larger than caster.
2009-08-25 16:34:17 -05:00
float speedz = float(damage) * ratio;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (speedxy < 0.1f && speedz < 0.1f)
*Do not allow to knockback target which is much larger than caster.
2009-08-25 16:34:17 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix knockback effect.
2009-02-06 21:48:47 -06:00
float x, y;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (m_spellInfo->Effect[effIndex] == SPELL_EFFECT_KNOCK_BACK_DEST)
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
{
if (m_targets.HasDst())
m_targets.m_dstPos.GetPosition(x, y);
else
return;
}
else //if (m_spellInfo->Effect[i] == SPELL_EFFECT_KNOCK_BACK)
{
*More update about positions.
2009-08-29 23:20:16 -05:00
m_caster->GetPosition(x, y);
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
unitTarget->KnockbackFrom(x, y, speedxy, speedz);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectLeapBack(SpellEffIndex effIndex)
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float speedxy = float(m_spellInfo->EffectMiscValue[effIndex])/10;
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
float speedz = float(damage/10);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!speedxy)
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.getUnitTarget())
*Fix a crash caused by feedpet.
2009-05-03 16:29:33 -05:00
m_caster->JumpTo(m_targets.getUnitTarget(), speedz);
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
}
else
{
//1891: Disengage
*Cleanups and obsolete spell handlers remove.
2009-08-11 19:57:27 +02:00
m_caster->JumpTo(speedxy, speedz, m_spellInfo->SpellIconID != 1891);
*Implement spell Disengage and Death Grip.
2009-04-11 22:41:15 -05:00
}
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectQuestClear(SpellEffIndex effIndex)
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
{
Player *pPlayer = NULL;
if (m_caster->GetTypeId() == TYPEID_PLAYER)
pPlayer = m_caster->ToPlayer();
else if (unitTarget && unitTarget->GetTypeId() == TYPEID_PLAYER)
pPlayer = unitTarget->ToPlayer();
Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
2010-08-08 19:45:53 +02:00
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
if (!pPlayer)
return;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 quest_id = m_spellInfo->EffectMiscValue[effIndex];
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
Quest const* pQuest = sObjectMgr->GetQuestTemplate(quest_id);
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
if (!pQuest)
return;
// Player has never done this quest
Core/QuestStatus: Fix EffectQuestClear, also clear rewarded quests again
2010-12-26 21:18:22 +01:00
if (pPlayer->GetQuestStatus(quest_id) == QUEST_STATUS_NONE)
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
return;
// remove all quest entries for 'entry' from quest log
for (uint8 slot = 0; slot < MAX_QUEST_LOG_SIZE; ++slot)
{
uint32 quest = pPlayer->GetQuestSlotQuestId(slot);
if (quest == quest_id)
{
pPlayer->SetQuestSlot(slot, 0);
// we ignore unequippable quest items in this case, its' still be equipped
pPlayer->TakeQuestSourceItem(quest, false);
}
}
Core/Player: Split RemoveQuest into 2 separate functions
2010-12-26 21:34:08 +01:00
pPlayer->RemoveActiveQuest(quest_id);
pPlayer->RemoveRewardedQuest(quest_id);
Implemented SPELL_EFFECT_CLEAR_QUEST (139), patch by Socolin
2010-07-04 19:16:40 +02:00
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSendTaxi(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
unitTarget->ToPlayer()->ActivateTaxiPathTo(m_spellInfo->EffectMiscValue[effIndex], m_spellInfo->Id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectPullTowards(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
float speedZ = (float)(SpellMgr::CalculateSpellEffectAmount(m_spellInfo, effIndex) / 10);
float speedXY = (float)(m_spellInfo->EffectMiscValue[effIndex]/10);
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
Position pos;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (m_spellInfo->Effect[effIndex] == SPELL_EFFECT_PULL_TOWARDS_DEST)
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
2010-08-09 02:31:42 +02:00
{
if (m_targets.HasDst())
pos.Relocate(m_targets.m_dstPos);
else
return;
}
else //if (m_spellInfo->Effect[i] == SPELL_EFFECT_PULL_TOWARDS)
{
pos.Relocate(m_caster);
}
unitTarget->GetMotionMaster()->MoveJump(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ(), speedXY, speedZ);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDispelMechanic(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 mechanic = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Prevent crash in EffectDispelMechanic.
2009-04-19 22:21:40 +02:00
std::queue < std::pair < uint32, uint64 > > dispel_list;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Make sure that aura is applied on unit before trying to remove it.
2010-01-10 20:09:44 +01:00
Unit::AuraMap const& auras = unitTarget->GetOwnedAuras();
for (Unit::AuraMap::const_iterator itr = auras.begin(); itr != auras.end(); ++itr)
*Fix T.N.T proc chance
2009-04-13 18:56:29 +02:00
{
* Make sure that aura is applied on unit before trying to remove it.
2010-01-10 20:09:44 +01:00
Aura * aura = itr->second;
if (!aura->GetApplicationOfTarget(unitTarget->GetGUID()))
continue;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
bool success = false;
GetDispelChance(aura->GetCaster(), unitTarget, aura->GetId(), !unitTarget->IsFriendlyTo(m_caster), &success);
Dispell code cleanup - GetDispelChance now really returns dispel chance and not resist chance.
2010-06-27 04:03:30 +02:00
if ((GetAllSpellMechanicMask(aura->GetSpellProto()) & (1 << mechanic)) && success)
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
dispel_list.push(std::make_pair(aura->GetId(), aura->GetCasterGUID()));
*Fix T.N.T proc chance
2009-04-13 18:56:29 +02:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (; dispel_list.size(); dispel_list.pop())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
unitTarget->RemoveAura(dispel_list.front().first, dispel_list.front().second, 0, AURA_REMOVE_BY_ENEMY_SPELL);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSummonDeadPet(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Player *_player = (Player*)m_caster;
Pet *pet = _player->GetPet();
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pet)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (pet->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Add spaces after commas
2011-04-29 20:47:02 +02:00
float x, y, z;
Fixed some problems with pets, port from tc1, by krz, thx Frankir.
2010-01-16 19:11:32 +03:00
_player->GetPosition(x, y, z);
_player->GetMap()->CreatureRelocation(pet, x, y, z, _player->GetOrientation());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pet->SetUInt32Value(UNIT_DYNAMIC_FLAGS, 0);
pet->RemoveFlag (UNIT_FIELD_FLAGS, UNIT_FLAG_SKINNABLE);
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
pet->setDeathState(ALIVE);
Core: Fixed warnings:
2011-03-08 16:42:00 +01:00
pet->ClearUnitState(uint32(UNIT_STAT_ALL_STATE));
Core:
2010-08-26 01:20:57 +06:00
pet->SetHealth(pet->CountPctFromMaxHealth(damage));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix the bug that revive pet make pet action bar disappear.
2009-04-06 22:08:12 -05:00
//pet->AIM_Initialize();
//_player->PetSpellInitialize();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDestroyAllTotems(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Use custom spell intead of hard code for EffectDestroyAllTotems. By Maxxie
2009-05-06 17:00:11 -05:00
int32 mana = 0;
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint8 slot = SUMMON_SLOT_TOTEM; slot < MAX_TOTEM_SLOT; ++slot)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!m_caster->m_SummonSlot[slot])
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
continue;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[7690] Move GetCreature/GetGameobject to class Map. Author: VladimirMangos
2009-04-20 20:28:19 -05:00
Creature* totem = m_caster->GetMap()->GetCreature(m_caster->m_SummonSlot[slot]);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (totem && totem->isTotem())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint32 spell_id = totem->GetUInt32Value(UNIT_CREATED_BY_SPELL);
SpellEntry const* spellInfo = sSpellStore.LookupEntry(spell_id);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (spellInfo)
*Fix totemic call mana gain
2009-04-12 01:29:56 +02:00
{
mana += spellInfo->manaCost;
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
mana += int32(CalculatePctU(m_caster->GetCreateMana(), spellInfo->ManaCostPercentage));
*Fix totemic call mana gain
2009-04-12 01:29:56 +02:00
}
Totem* casts.
2010-03-10 07:58:11 +01:00
totem->ToTotem()->UnSummon();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
ApplyPctN(mana, damage);
*Use custom spell intead of hard code for EffectDestroyAllTotems. By Maxxie
2009-05-06 17:00:11 -05:00
if (mana)
m_caster->CastCustomSpell(m_caster, 39104, &mana, NULL, NULL, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDurabilityDamage(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
int32 slot = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// FIXME: some spells effects have value -1/-2
// Possibly its mean -1 all player equipped items and -2 all items
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->DurabilityPointsLossAll(damage, (slot < -1));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// invalid slot value
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot >= INVENTORY_SLOT_BAG_END)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Item* item = unitTarget->ToPlayer()->GetItemByPos(INVENTORY_SLOT_BAG_0, slot))
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->DurabilityPointsLoss(item, damage);
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
ExecuteLogEffectDurabilityDamage(effIndex, unitTarget, slot, damage);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDurabilityDamagePCT(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
int32 slot = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// FIXME: some spells effects have value -1/-2
// Possibly its mean -1 all player equipped items and -2 all items
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot < 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
unitTarget->ToPlayer()->DurabilityLossAll(float(damage) / 100.0f, (slot < -1));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// invalid slot value
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (slot >= INVENTORY_SLOT_BAG_END)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (damage <= 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Item* item = unitTarget->ToPlayer()->GetItemByPos(INVENTORY_SLOT_BAG_0, slot))
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
2010-12-11 20:37:38 +06:00
unitTarget->ToPlayer()->DurabilityLoss(item, float(damage) / 100.0f);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectModifyThreatPercent(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
unitTarget->getThreatManager().modifyThreatPercent(m_caster, damage);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTransmitted(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint32 name_id = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/ObjectMgr: Refactor sGOStorage
2011-04-28 22:54:30 +02:00
GameObjectTemplate const* goinfo = sObjectMgr->GetGameObjectTemplate(name_id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
if (!goinfo)
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outErrorDb("Gameobject (Entry: %u) not exist and not created at spell (ID: %u) cast", name_id, m_spellInfo->Id);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
float fx, fy, fz;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_targets.HasDst())
*More update about positions.
2009-08-29 23:20:16 -05:00
m_targets.m_dstPos.GetPosition(fx, fy, fz);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//FIXME: this can be better check for most objects but still hack
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
else if (m_spellInfo->EffectRadiusIndex[effIndex] && m_spellInfo->speed == 0)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Make range check dependent from target.
2009-02-14 15:56:04 +01:00
float dis = GetSpellRadiusForFriend(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[effIndex]));
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->GetClosePoint(fx, fy, fz, DEFAULT_WORLD_OBJECT_SIZE, dis);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
else
{
*Make range check dependent from target.
2009-02-14 15:56:04 +01:00
//GO is always friendly to it's creator, get range for friends
float min_dis = GetSpellMinRangeForFriend(sSpellRangeStore.LookupEntry(m_spellInfo->rangeIndex));
float max_dis = GetSpellMaxRangeForFriend(sSpellRangeStore.LookupEntry(m_spellInfo->rangeIndex));
Core/Game: fix all warnings related to converting doubles and floats.
2010-08-22 12:39:39 -07:00
float dis = (float)rand_norm() * (max_dis - min_dis) + min_dis;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->GetClosePoint(fx, fy, fz, DEFAULT_WORLD_OBJECT_SIZE, dis);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Map *cMap = m_caster->GetMap();
Scripts/Spells: Added script for Animal Blood pool spawning (fixes fishing daily quest "Blood is Thicker")
2010-11-10 11:37:41 +01:00
if (goinfo->type == GAMEOBJECT_TYPE_FISHINGNODE || goinfo->type == GAMEOBJECT_TYPE_FISHINGHOLE)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
HIGHLY EXPERIMENTAL - USE AT YOUR OWN RISK
2010-06-05 00:59:25 +02:00
LiquidData liqData;
if ( !cMap->IsInWater(fx, fy, fz + 1.f/* -0.5f */, &liqData)) // Hack to prevent fishing bobber from failing to land on fishing hole
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{ // but this is not proper, we really need to ignore not materialized objects
SendCastResult(SPELL_FAILED_NOT_HERE);
SendChannelUpdate(0);
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// replace by water level in this case
HIGHLY EXPERIMENTAL - USE AT YOUR OWN RISK
2010-06-05 00:59:25 +02:00
//fz = cMap->GetWaterLevel(fx, fy);
fz = liqData.level;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
// if gameobject is summoning object, it should be spawned right on caster's position
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
else if (goinfo->type == GAMEOBJECT_TYPE_SUMMONING_RITUAL)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Mangos [7911]. Author: tomrus88
2009-05-31 15:56:51 -05:00
m_caster->GetPosition(fx, fy, fz);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
GameObject* pGameObj = new GameObject;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (!pGameObj->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_GAMEOBJECT), name_id, cMap,
[7715] Provided way for scripts set alternative gameobject state for client show. Author: VladimirMangos
2009-04-27 18:36:10 -05:00
m_caster->GetPhaseMask(), fx, fy, fz, m_caster->GetOrientation(), 0.0f, 0.0f, 0.0f, 0.0f, 100, GO_STATE_READY))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
delete pGameObj;
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
int32 duration = GetSpellDuration(m_spellInfo);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
switch(goinfo->type)
{
case GAMEOBJECT_TYPE_FISHINGNODE:
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->SetUInt64Value(UNIT_FIELD_CHANNEL_OBJECT, pGameObj->GetGUID());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
m_caster->AddGameObject(pGameObj); // will removed at spell cancel
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// end time of range when possible catch fish (FISHING_BOBBER_READY_TIME..GetDuration(m_spellInfo))
// start time == fish-FISHING_BOBBER_READY_TIME (0..GetDuration(m_spellInfo)-FISHING_BOBBER_READY_TIME)
[7716] Fixed some typos and possible crashes. Author: AlexDereka
2009-04-27 18:42:35 -05:00
int32 lastSec = 0;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
switch(urand(0, 3))
{
case 0: lastSec = 3; break;
case 1: lastSec = 7; break;
case 2: lastSec = 13; break;
case 3: lastSec = 17; break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
duration = duration - lastSec*IN_MILLISECONDS + FISHING_BOBBER_READY_TIME*IN_MILLISECONDS;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
break;
}
case GAMEOBJECT_TYPE_SUMMONING_RITUAL:
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() == TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Scripts/Spells: Added script for Animal Blood pool spawning (fixes fishing daily quest "Blood is Thicker")
2010-11-10 11:37:41 +01:00
pGameObj->AddUniqueUse(m_caster->ToPlayer());
m_caster->AddGameObject(pGameObj); // will removed at spell cancel
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
break;
}
*Some update of script "death's challenge"
2009-08-13 00:21:10 -05:00
case GAMEOBJECT_TYPE_DUEL_ARBITER: // 52991
m_caster->AddGameObject(pGameObj);
break;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
case GAMEOBJECT_TYPE_FISHINGHOLE:
case GAMEOBJECT_TYPE_CHEST:
default:
break;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
pGameObj->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8225] Some fixes from 320 branch. Author: tomrus88
2009-07-30 10:26:15 +08:00
pGameObj->SetOwnerGUID(m_caster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8225] Some fixes from 320 branch. Author: tomrus88
2009-07-30 10:26:15 +08:00
//pGameObj->SetUInt32Value(GAMEOBJECT_LEVEL, m_caster->getLevel());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
pGameObj->SetSpellId(m_spellInfo->Id);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
ExecuteLogEffectSummonObject(effIndex, pGameObj);
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outStaticDebug("AddObject at SpellEfects.cpp EffectTransmitted");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//m_caster->AddGameObject(pGameObj);
//m_ObjToDel.push_back(pGameObj);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
cMap->Add(pGameObj);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (uint32 linkedEntry = pGameObj->GetGOInfo()->GetLinkedGameObjectEntry())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
GameObject* linkedGO = new GameObject;
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (linkedGO->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_GAMEOBJECT), linkedEntry, cMap,
[7715] Provided way for scripts set alternative gameobject state for client show. Author: VladimirMangos
2009-04-27 18:36:10 -05:00
m_caster->GetPhaseMask(), fx, fy, fz, m_caster->GetOrientation(), 0.0f, 0.0f, 0.0f, 0.0f, 100, GO_STATE_READY))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
2010-07-12 00:30:17 +02:00
linkedGO->SetRespawnTime(duration > 0 ? duration/IN_MILLISECONDS : 0);
[8225] Some fixes from 320 branch. Author: tomrus88
2009-07-30 10:26:15 +08:00
//linkedGO->SetUInt32Value(GAMEOBJECT_LEVEL, m_caster->getLevel());
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
linkedGO->SetSpellId(m_spellInfo->Id);
[8225] Some fixes from 320 branch. Author: tomrus88
2009-07-30 10:26:15 +08:00
linkedGO->SetOwnerGUID(m_caster->GetGUID());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
ExecuteLogEffectSummonObject(effIndex, linkedGO);
*Merge from Mangos. Add MapReference. Author: hunuza.
2008-11-18 19:40:06 -06:00
linkedGO->GetMap()->Add(linkedGO);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
else
{
delete linkedGO;
linkedGO = NULL;
return;
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectProspecting(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
Player* p_caster = (Player*)m_caster;
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
if (!itemTarget || !(itemTarget->GetTemplate()->Flags & ITEM_PROTO_FLAG_PROSPECTABLE))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (itemTarget->GetCount() < 5)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (sWorld->getBoolConfig(CONFIG_SKILL_PROSPECTING))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
uint32 SkillValue = p_caster->GetPureSkillValue(SKILL_JEWELCRAFTING);
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
uint32 reqSkillValue = itemTarget->GetTemplate()->RequiredSkillRank;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
p_caster->UpdateGatherSkill(SKILL_JEWELCRAFTING, SkillValue, reqSkillValue);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->SendLoot(itemTarget->GetGUID(), LOOT_PROSPECTING);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectMilling(SpellEffIndex /*effIndex*/)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
Player* p_caster = (Player*)m_caster;
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
if (!itemTarget || !(itemTarget->GetTemplate()->Flags & ITEM_PROTO_FLAG_MILLABLE))
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (itemTarget->GetCount() < 5)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
if (sWorld->getBoolConfig(CONFIG_SKILL_MILLING))
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
uint32 SkillValue = p_caster->GetPureSkillValue(SKILL_INSCRIPTION);
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
uint32 reqSkillValue = itemTarget->GetTemplate()->RequiredSkillRank;
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
p_caster->UpdateGatherSkill(SKILL_INSCRIPTION, SkillValue, reqSkillValue);
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_caster->ToPlayer()->SendLoot(itemTarget->GetGUID(), LOOT_MILLING);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSkill(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "WORLD: SkillEFFECT");
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
* Rename: BattleGround -> Battleground.
2010-08-08 04:37:24 +02:00
/* There is currently no need for this effect. We handle it in Battleground.cpp
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
If we would handle the resurrection here, the spiritguide would instantly disappear as the
player revives, and so we wouldn't see the spirit heal visual effect on the npc.
This is why we use a half sec delay between the visual effect and the resurrection itself */
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSpiritHeal(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
/*
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->isAlive())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget->IsInWorld())
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
//m_spellInfo->EffectBasePoints[i]; == 99 (percent?)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
//unitTarget->ToPlayer()->setResurrect(m_caster->GetGUID(), unitTarget->GetPositionX(), unitTarget->GetPositionY(), unitTarget->GetPositionZ(), unitTarget->GetMaxHealth(), unitTarget->GetMaxPower(POWER_MANA));
unitTarget->ToPlayer()->ResurrectPlayer(1.0f);
unitTarget->ToPlayer()->SpawnCorpseBones();
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
*/
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// remove insignia spell effect
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSkinPlayerCorpse(SpellEffIndex /*effIndex*/)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Effect: SkinPlayerCorpse");
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
if ((m_caster->GetTypeId() != TYPEID_PLAYER) || (unitTarget->GetTypeId() != TYPEID_PLAYER) || (unitTarget->isAlive()))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
unitTarget->ToPlayer()->RemovedInsignia((Player*)m_caster);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectStealBeneficialBuff(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf.
2011-02-20 20:16:34 +01:00
sLog->outDebug(LOG_FILTER_SPELLS_AURAS, "Effect: StealBeneficialBuff");
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code Style (game + scripts only):
2010-04-07 23:25:02 +02:00
if (!unitTarget || unitTarget == m_caster) // can't steal from self
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
DispelChargesList steal_list;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Create dispel mask by dispel type
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 dispelMask = GetDispellMask(DispelType(m_spellInfo->EffectMiscValue[effIndex]));
Update aura system:
2010-01-10 01:23:15 +01:00
Unit::AuraMap const& auras = unitTarget->GetOwnedAuras();
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (Unit::AuraMap::const_iterator itr = auras.begin(); itr != auras.end(); ++itr)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Update aura system:
2010-01-10 01:23:15 +01:00
Aura * aura = itr->second;
* Make sure that aura is applied on unit before trying to remove it.
2010-01-10 20:09:44 +01:00
AuraApplication * aurApp = aura->GetApplicationOfTarget(unitTarget->GetGUID());
if (!aurApp)
continue;
Update aura system:
2010-01-10 01:23:15 +01:00
if ((1<<aura->GetSpellProto()->Dispel) & dispelMask)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
// Need check for passive? this
Core: Rename spell attributes, use more general names
2010-12-19 05:15:47 +01:00
if (!aurApp->IsPositive() || aura->IsPassive() || aura->GetSpellProto()->AttributesEx4 & SPELL_ATTR4_NOT_STEALABLE)
* Use pair<uint32, uint64> lists instead of <Aura*> lists in Dispel/SpellSteal effects handlers (prevent reference to aura removed from unit)
2010-01-10 12:08:58 +01:00
continue;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
// The charges / stack amounts don't count towards the total number of auras that can be dispelled.
// Ie: A dispel on a target with 5 stacks of Winters Chill and a Polymorph has 1 / (1 + 1) -> 50% chance to dispell
// Polymorph instead of 1 / (5 + 1) -> 16%.
Core: Rename spell attributes, use more general names
2010-12-19 05:15:47 +01:00
bool dispel_charges = aura->GetSpellProto()->AttributesEx7 & SPELL_ATTR7_DISPEL_CHARGES;
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
uint8 charges = dispel_charges ? aura->GetCharges() : aura->GetStackAmount();
if (charges > 0)
steal_list.push_back(std::make_pair(aura, charges));
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
if (steal_list.empty())
return;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
// Ok if exist some buffs for dispel try dispel it
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
uint32 failCount = 0;
DispelList success_list;
WorldPacket dataFail(SMSG_DISPEL_FAILED, 8+8+4+4+damage*4);
// dispel N = damage buffs (or while exist buffs for dispel)
for (int32 count = 0; count < damage && !steal_list.empty();)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
// Random select buff for dispel
DispelChargesList::iterator itr = steal_list.begin();
std::advance(itr, urand(0, steal_list.size() - 1));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
bool success = false;
// 2.4.3 Patch Notes: "Dispel effects will no longer attempt to remove effects that have 100% dispel resistance."
Dispell code cleanup - GetDispelChance now really returns dispel chance and not resist chance.
2010-06-27 04:03:30 +02:00
if (!GetDispelChance(itr->first->GetCaster(), unitTarget, itr->first->GetId(), !unitTarget->IsFriendlyTo(m_caster), &success))
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
*Update of aura system.
2009-04-06 13:31:14 +02:00
steal_list.erase(itr);
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
continue;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
else
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
if (success)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
success_list.push_back(std::make_pair(itr->first->GetId(), itr->first->GetCasterGUID()));
--itr->second;
if (itr->second <= 0)
steal_list.erase(itr);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
else
{
if (!failCount)
{
// Failed to dispell
dataFail << uint64(m_caster->GetGUID()); // Caster GUID
dataFail << uint64(unitTarget->GetGUID()); // Victim GUID
dataFail << uint32(m_spellInfo->Id); // dispel spell id
}
++failCount;
dataFail << uint32(itr->first->GetId()); // Spell Id
}
++count;
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
}
Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
2010-05-25 10:36:33 +02:00
if (failCount)
m_caster->SendMessageToSet(&dataFail, true);
if (success_list.empty())
return;
WorldPacket dataSuccess(SMSG_SPELLSTEALLOG, 8+8+4+1+4+damage*5);
dataSuccess.append(unitTarget->GetPackGUID()); // Victim GUID
dataSuccess.append(m_caster->GetPackGUID()); // Caster GUID
dataSuccess << uint32(m_spellInfo->Id); // dispel spell id
dataSuccess << uint8(0); // not used
dataSuccess << uint32(success_list.size()); // count
for (DispelList::iterator itr = success_list.begin(); itr!=success_list.end(); ++itr)
{
dataSuccess << uint32(itr->first); // Spell Id
dataSuccess << uint8(0); // 0 - steals !=0 transfers
unitTarget->RemoveAurasDueToSpellBySteal(itr->first, itr->second, m_caster);
}
m_caster->SendMessageToSet(&dataSuccess, true);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectKillCreditPersonal(SpellEffIndex effIndex)
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
unitTarget->ToPlayer()->KilledMonsterCredit(m_spellInfo->EffectMiscValue[effIndex], 0);
*[8471] Little correction to prev. commit. Spell effect 90 seems to be kill credit but only for single person. Author: ApoC
2009-09-11 15:38:31 -07:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectKillCredit(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
int32 creatureEntry = m_spellInfo->EffectMiscValue[effIndex];
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!creatureEntry)
*Fix quest War is Hell.
2009-05-05 12:27:11 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_spellInfo->Id == 42793) // Burn Body
*Fix quest War is Hell.
2009-05-05 12:27:11 -05:00
creatureEntry = 24008; // Fallen Combatant
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (creatureEntry)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->RewardPlayerAndGroupAtEvent(creatureEntry, unitTarget);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectQuestFail(SpellEffIndex effIndex)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
unitTarget->ToPlayer()->FailQuest(m_spellInfo->EffectMiscValue[effIndex]);
[svn] * svn:eol-style native set on all files that need it
2008-10-11 14:16:25 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectQuestStart(SpellEffIndex effIndex)
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Player * player = unitTarget->ToPlayer();
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
if (Quest const* qInfo = sObjectMgr->GetQuestTemplate(m_spellInfo->EffectMiscValue[effIndex]))
*Implement SPELL_EFFECT_QUEST_START (150).
2010-07-20 16:11:49 +02:00
{
if (player->CanTakeQuest(qInfo, false) && player->CanAddQuest(qInfo, false))
{
player->AddQuest(qInfo, NULL);
}
}
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectActivateRune(SpellEffIndex effIndex)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (m_caster->GetTypeId() != TYPEID_PLAYER)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
Player *plr = (Player*)m_caster;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (plr->getClass() != CLASS_DEATH_KNIGHT)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fix Empowered Rune Weapon
2010-01-23 16:06:06 +01:00
// needed later
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
m_runesState = m_caster->ToPlayer()->GetRunesState();
Fix Empowered Rune Weapon
2010-01-23 16:06:06 +01:00
uint32 count = damage;
if (count == 0) count = 1;
Code style (game + scripts only):
2010-04-07 19:12:44 +02:00
for (uint32 j = 0; j < MAX_RUNES && count > 0; ++j)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (plr->GetRuneCooldown(j) && plr->GetCurrentRune(j) == RuneType(m_spellInfo->EffectMiscValue[effIndex]))
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
plr->SetRuneCooldown(j, 0);
Fix Empowered Rune Weapon
2010-01-23 16:06:06 +01:00
--count;
}
}
// Empower rune weapon
if (m_spellInfo->Id == 47568)
{
// Need to do this just once
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (effIndex != 0)
Fix Empowered Rune Weapon
2010-01-23 16:06:06 +01:00
return;
Code style (game + scripts only):
2010-04-07 19:12:44 +02:00
for (uint32 i = 0; i < MAX_RUNES; ++i)
Fix Empowered Rune Weapon
2010-01-23 16:06:06 +01:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (plr->GetRuneCooldown(i) && (plr->GetCurrentRune(i) == RUNE_FROST || plr->GetCurrentRune(i) == RUNE_DEATH))
Fix Empowered Rune Weapon
2010-01-23 16:06:06 +01:00
plr->SetRuneCooldown(i, 0);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectCreateTamedPet(SpellEffIndex effIndex)
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER || unitTarget->GetPetGUID() || unitTarget->getClass() != CLASS_HUNTER)
return;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 creatureEntry = m_spellInfo->EffectMiscValue[effIndex];
*Implement SPELL_EFFECT_CREATE_TAMED_PET(153).
2010-07-20 22:55:28 +02:00
Pet * pet = unitTarget->CreateTamedPetFrom(creatureEntry, m_spellInfo->Id);
if (!pet)
return;
// add to world
pet->GetMap()->Add(pet->ToCreature());
// unitTarget has pet now
unitTarget->SetMinion(pet, true);
pet->InitTalentForLevel();
if (unitTarget->GetTypeId() == TYPEID_PLAYER)
{
pet->SavePetToDB(PET_SAVE_AS_CURRENT);
unitTarget->ToPlayer()->PetSpellInitialize();
}
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectDiscoverTaxi(SpellEffIndex effIndex)
*Implement SPELL_EFFECT_DISCOVER_TAXI(154).
2010-07-20 18:27:18 +02:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 nodeid = m_spellInfo->EffectMiscValue[effIndex];
*Implement SPELL_EFFECT_DISCOVER_TAXI(154).
2010-07-20 18:27:18 +02:00
if (sTaxiNodesStore.LookupEntry(nodeid))
unitTarget->ToPlayer()->GetSession()->SendDiscoverNewTaxiNode(nodeid);
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectTitanGrip(SpellEffIndex /*effIndex*/)
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
{
if (unitTarget && unitTarget->GetTypeId() == TYPEID_PLAYER)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->SetCanTitanGrip(true);
*Update to Mangos 6938. (Only build for VC9)
2008-12-24 09:58:26 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectRedirectThreat(SpellEffIndex /*effIndex*/)
*Fix misdirection.
2008-12-17 20:07:25 -06:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (unitTarget)
*Fix misdirection.
2008-12-17 20:07:25 -06:00
m_caster->SetReducedThreatPercent((uint32)damage, unitTarget->GetGUID());
*Update difftime record.
2009-01-06 15:48:42 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectWMODamage(SpellEffIndex /*effIndex*/)
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (gameObjTarget && gameObjTarget->GetGoType() == GAMEOBJECT_TYPE_DESTRUCTIBLE_BUILDING)
*Wintersgrasp - prevents team from using vehicles to damage their own buildings, by Spp
2009-10-13 16:16:45 -07:00
{
Unit *caster = m_originalCaster;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!caster)
*Wintersgrasp - prevents team from using vehicles to damage their own buildings, by Spp
2009-10-13 16:16:45 -07:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Destructable Buildings
2010-10-19 13:15:47 +02:00
// Do not allow damage if hp is 0
if (gameObjTarget->GetGOValue()->building.health == 0)
return;
*Wintersgrasp - prevents team from using vehicles to damage their own buildings, by Spp
2009-10-13 16:16:45 -07:00
FactionTemplateEntry const *casterft, *goft;
casterft = caster->getFactionTemplateEntry();
*Wintergrasp: Set Faction on workshop capture + GO check faction fix, by Spp
2009-10-13 23:04:11 -07:00
goft = sFactionTemplateStore.LookupEntry(gameObjTarget->GetUInt32Value(GAMEOBJECT_FACTION));
Core/Spells: Destructable Buildings
2010-10-19 13:15:47 +02:00
// Do not allow to damage GO's of friendly factions (ie: Wintergrasp Walls/Ulduar Storm Beacons)
if ((casterft && goft && !casterft->IsFriendlyTo(*goft)) || !goft)
Send SMSG_DESTRUCTIBLE_BUILDING_DAMAGE when a destructible building takes damage
2010-03-14 21:10:21 +01:00
{
gameObjTarget->TakenDamage(uint32(damage), caster);
WorldPacket data(SMSG_DESTRUCTIBLE_BUILDING_DAMAGE, 8+8+8+4+4);
data.append(gameObjTarget->GetPackGUID());
data.append(caster->GetPackGUID());
if (Unit *who = caster->GetCharmerOrOwner())
data.append(who->GetPackGUID());
else
data << uint8(0);
data << uint32(damage);
data << uint32(m_spellInfo->Id);
gameObjTarget->SendMessageToSet(&data, false);
}
*Wintersgrasp - prevents team from using vehicles to damage their own buildings, by Spp
2009-10-13 16:16:45 -07:00
}
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectWMORepair(SpellEffIndex /*effIndex*/)
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (gameObjTarget && gameObjTarget->GetGoType() == GAMEOBJECT_TYPE_DESTRUCTIBLE_BUILDING)
*Implement spell effect wmo damage.
2009-05-21 10:01:03 -05:00
gameObjTarget->Rebuild();
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Implement SPELL_EFFECT_WMO_CHANGE, patch by Heisenberg
2010-12-01 20:59:05 +02:00
void Spell::EffectWMOChange(SpellEffIndex effIndex)
{
if (gameObjTarget && gameObjTarget->GetGoType() == GAMEOBJECT_TYPE_DESTRUCTIBLE_BUILDING)
{
Unit* caster = m_originalCaster;
if (!caster)
return;
int ChangeType = m_spellInfo->EffectMiscValue[effIndex];
switch (ChangeType)
{
case 0: // intact
if (gameObjTarget->HasFlag(GAMEOBJECT_FLAGS, GO_FLAG_DAMAGED))
gameObjTarget->RemoveFlag(GAMEOBJECT_FLAGS, GO_FLAG_DAMAGED);
if (gameObjTarget->HasFlag(GAMEOBJECT_FLAGS, GO_FLAG_DESTROYED))
gameObjTarget->RemoveFlag(GAMEOBJECT_FLAGS, GO_FLAG_DESTROYED);
break;
case 1: // damaged
gameObjTarget->SetFlag(GAMEOBJECT_FLAGS, GO_FLAG_DAMAGED);
break;
case 2: // destroyed
gameObjTarget->SetFlag(GAMEOBJECT_FLAGS, GO_FLAG_DESTROYED);
break;
case 3: // rebuild
gameObjTarget->Rebuild();
break;
}
}
}
*Make position as a class;
2009-08-29 14:58:45 -05:00
void Spell::SummonGuardian(uint32 i, uint32 entry, SummonPropertiesEntry const *properties)
*More work on summon system.
2009-03-20 14:01:46 -06:00
{
Unit *caster = m_originalCaster;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!caster)
*Summon creatures based on general summon types.
2009-03-18 21:16:24 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (caster->isTotem())
Totem* casts.
2010-03-10 07:58:11 +01:00
caster = caster->ToTotem()->GetOwner();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More work on summon system.
2009-03-20 14:01:46 -06:00
// in another case summon new
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
uint8 level = caster->getLevel();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More work on summon system.
2009-03-20 14:01:46 -06:00
// level of pet summoned using engineering item based at engineering skill level
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (m_CastItem && caster->GetTypeId() == TYPEID_PLAYER)
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
if (ItemTemplate const *proto = m_CastItem->GetTemplate())
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (proto->RequiredSkill == SKILL_ENGINERING)
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
if (uint16 skill202 = caster->ToPlayer()->GetSkillValue(SKILL_ENGINERING))
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
level = skill202/5;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*More work on summon system.
2009-03-20 14:01:46 -06:00
//float radius = GetSpellRadiusForFriend(sSpellRadiusStore.LookupEntry(m_spellInfo->EffectRadiusIndex[i]));
float radius = 5.0f;
Core/Cleanup:
2010-08-26 15:54:56 +06:00
uint32 amount = damage > 0 ? damage : 1;
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
int32 duration = GetSpellDuration(m_spellInfo);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
switch (m_spellInfo->Id)
*Fix the bug that inferno and curse of doom summons too many minions.
2009-05-17 17:33:39 -05:00
{
case 1122: // Inferno
*Make spell 1122 summon only one infernal.
2009-06-30 15:55:02 +02:00
amount = 1;
*Fix the bug that inferno and curse of doom summons too many minions.
2009-05-17 17:33:39 -05:00
break;
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
case 49028: // Dancing Rune Weapon
Implementation of Glyph of Dancing Rune Weapon. Related #365
2009-12-14 02:01:22 +01:00
if (AuraEffect *aurEff = m_originalCaster->GetAuraEffect(63330, 0)) // glyph of Dancing Rune Weapon
duration += aurEff->GetAmount();
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
break;
*Fix the bug that inferno and curse of doom summons too many minions.
2009-05-17 17:33:39 -05:00
}
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (Player* modOwner = m_originalCaster->GetSpellModOwner())
*Fix some typos in trinitycore.conf.dist
2009-10-15 08:34:19 -07:00
modOwner->ApplySpellMod(m_spellInfo->Id, SPELLMOD_DURATION, duration);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Remove LOTS of compile warnings
2010-04-19 09:26:37 +02:00
//TempSummonType summonType = (duration == 0) ? TEMPSUMMON_DEAD_DESPAWN : TEMPSUMMON_TIMED_DESPAWN;
*More work on summon system.
2009-03-20 14:01:46 -06:00
Map *map = caster->GetMap();
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Massive cleanup redux.
2009-10-17 16:20:24 -07:00
for (uint32 count = 0; count < amount; ++count)
*More work on summon system.
2009-03-20 14:01:46 -06:00
{
*Make position as a class;
2009-08-29 14:58:45 -05:00
Position pos;
GetSummonPosition(i, pos, radius, count);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Moved setting UNIT_CREATED_BY_SPELL out of spell effect handlers and sending SMSG_TOTEM_CREATED into Totem class
2011-05-19 22:27:18 +02:00
TempSummon *summon = map->SummonCreature(entry, pos, properties, duration, caster, m_spellInfo->Id);
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!summon)
*More work on summon system.
2009-03-20 14:01:46 -06:00
return;
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (summon->HasUnitTypeMask(UNIT_MASK_GUARDIAN))
*More work on summon system.
2009-03-20 14:01:46 -06:00
((Guardian*)summon)->InitStatsForLevel(level);
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Chat: move chat link validation code into separate classes and improve some validation logic
2011-04-27 16:22:42 +06:00
if (properties && properties->Category == SUMMON_CATEGORY_ALLY)
summon->setFaction(caster->getFaction());
Fixed broken missile visuals in certain DST and SRC type spells (Void Reaver's Arcane Orb and many others). Achieved by fixing wildly incorrect SMSG_SPELL_GO target mask data handling.
2010-03-19 00:21:57 +01:00
if (summon->HasUnitTypeMask(UNIT_MASK_MINION) && m_targets.HasDst())
*Implement Aura Type 247 (SPELL_AURA_CLONE_CASTER) and 279 (SPELL_AURA_INITIALIZE_IMAGES)
2009-07-22 17:10:30 +02:00
((Minion*)summon)->SetFollowAngle(m_caster->GetAngle(summon));
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
if (summon->GetEntry() == 27893)
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
{
Fix Dancing Rune Weapon. By liberate, closes #365
2009-12-14 01:51:12 +01:00
if (uint32 weapon = m_caster->GetUInt32Value(PLAYER_VISIBLE_ITEM_16_ENTRYID))
{
summon->SetDisplayId(11686);
summon->SetUInt32Value(UNIT_VIRTUAL_ITEM_SLOT_ID, weapon);
}
else
summon->SetDisplayId(1126);
Core: Fix more warnings
2010-08-30 15:25:15 +02:00
}
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
*Move MoveFollow owner from MoveTargetedHome to enterevademode.
2009-05-12 10:11:54 -05:00
summon->AI()->EnterEvadeMode();
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
2010-08-27 17:49:32 +02:00
ExecuteLogEffectSummonObject(i, summon);
*More work on summon system.
2009-03-20 14:01:46 -06:00
}
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Make position as a class;
2009-08-29 14:58:45 -05:00
void Spell::GetSummonPosition(uint32 i, Position &pos, float radius, uint32 count)
*Set totem slot to 4 but total summon slot to 6.
2009-03-19 15:45:22 -06:00
{
*More update about positions.
2009-08-29 23:20:16 -05:00
pos.SetOrientation(m_caster->GetOrientation());
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Fixed broken missile visuals in certain DST and SRC type spells (Void Reaver's Arcane Orb and many others). Achieved by fixing wildly incorrect SMSG_SPELL_GO target mask data handling.
2010-03-19 00:21:57 +01:00
if (m_targets.HasDst())
*Set totem slot to 4 but total summon slot to 6.
2009-03-19 15:45:22 -06:00
{
// Summon 1 unit in dest location
if (count == 0)
*More update about positions.
2009-08-29 23:20:16 -05:00
pos.Relocate(m_targets.m_dstPos);
*Set totem slot to 4 but total summon slot to 6.
2009-03-19 15:45:22 -06:00
// Summon in random point all other units if location present
else
*Use better summon positions for summon spells with more than one summons. (Still a temp fix)
2009-05-10 22:47:03 -05:00
{
//This is a workaround. Do not have time to write much about it
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
switch (m_spellInfo->EffectImplicitTargetA[i])
*Use better summon positions for summon spells with more than one summons. (Still a temp fix)
2009-05-10 22:47:03 -05:00
{
case TARGET_MINION:
case TARGET_DEST_CASTER_RANDOM:
Core/Game: fix all warnings related to converting doubles and floats.
2010-08-22 12:39:39 -07:00
m_caster->GetNearPosition(pos, radius * (float)rand_norm(), (float)rand_norm()*static_cast<float>(2*M_PI));
*Use better summon positions for summon spells with more than one summons. (Still a temp fix)
2009-05-10 22:47:03 -05:00
break;
case TARGET_DEST_DEST_RANDOM:
case TARGET_DEST_TARGET_RANDOM:
*More update about positions.
2009-08-29 23:20:16 -05:00
m_caster->GetRandomPoint(m_targets.m_dstPos, radius, pos);
*Use better summon positions for summon spells with more than one summons. (Still a temp fix)
2009-05-10 22:47:03 -05:00
break;
default:
*More update about positions.
2009-08-29 23:20:16 -05:00
pos.Relocate(m_targets.m_dstPos);
*Use better summon positions for summon spells with more than one summons. (Still a temp fix)
2009-05-10 22:47:03 -05:00
break;
}
}
*Set totem slot to 4 but total summon slot to 6.
2009-03-19 15:45:22 -06:00
}
// Summon if dest location not present near caster
else
*Make position as a class;
2009-08-29 14:58:45 -05:00
{
float x, y, z;
Add spaces after commas
2011-04-29 20:47:02 +02:00
m_caster->GetClosePoint(x, y, z, 3.0f);
*More update about positions.
2009-08-29 23:20:16 -05:00
pos.Relocate(x, y, z);
*Make position as a class;
2009-08-29 14:58:45 -05:00
}
*Set totem slot to 4 but total summon slot to 6.
2009-03-19 15:45:22 -06:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectRenamePet(SpellEffIndex /*effIndex*/)
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT ||
Some Creature* casts moved to new ToCreature.
2010-03-07 18:30:53 +01:00
!unitTarget->ToCreature()->isPet() || ((Pet*)unitTarget)->getPetType() != HUNTER_PET)
*Update to Mangos 7151.
2009-01-22 22:44:27 -06:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Core/Spells: Fix hunter pet namechanging when using Certificate of Ownership (spellID 53987, used by itemID 43850)
2010-11-07 22:23:12 +01:00
unitTarget->SetByteFlag(UNIT_FIELD_BYTES_2, 2, UNIT_CAN_BE_RENAMED);
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectPlayMusic(SpellEffIndex effIndex)
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 soundid = m_spellInfo->EffectMiscValue[effIndex];
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
if (!sSoundEntriesStore.LookupEntry(soundid))
{
Add spaces after commas
2011-04-29 20:47:02 +02:00
sLog->outError("EffectPlayMusic: Sound (Id: %u) not exist in spell %u.", soundid, m_spellInfo->Id);
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
return;
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
WorldPacket data(SMSG_PLAY_MUSIC, 4);
data << uint32(soundid);
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->GetSession()->SendPacket(&data);
[8220] Implement SPELL_EFFECT_PLAY_MUSIC(132) Author: evilstar
2009-07-30 10:18:05 +08:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectSpecCount(SpellEffIndex /*effIndex*/)
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->UpdateSpecCount(damage);
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
}
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectActivateSpec(SpellEffIndex /*effIndex*/)
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
{
*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
2009-11-01 17:53:07 -08:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
return;
*Backed out changeset 3be01fb200a5
2009-10-17 15:51:44 -07:00
Added new type-safe cast functions.
2010-03-07 15:20:19 +01:00
unitTarget->ToPlayer()->ActivateSpec(damage-1); // damage is 1 or 2, spec is 0 or 1
*Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
2009-08-14 17:24:52 -07:00
}
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
2011-03-07 21:13:18 +01:00
void Spell::EffectPlayerNotification(SpellEffIndex effIndex)
Update aura system:
2010-01-10 01:23:15 +01:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
switch(m_spellInfo->Id)
{
case 58730: // Restricted Flight Area
case 58600: // Restricted Flight Area
Convert some C style casts to new functions
2010-03-11 20:51:31 +01:00
unitTarget->ToPlayer()->GetSession()->SendNotification(LANG_ZONE_NOFLYZONE);
Update aura system:
2010-01-10 01:23:15 +01:00
break;
}
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
2011-03-07 21:13:18 +01:00
uint32 soundid = m_spellInfo->EffectMiscValue[effIndex];
if (!sSoundEntriesStore.LookupEntry(soundid))
{
sLog->outError("EffectPlayerNotification: Sound (Id: %u) not exist in spell %u.", soundid, m_spellInfo->Id);
return;
}
WorldPacket data(SMSG_PLAY_SOUND, 4);
data << uint32(soundid);
unitTarget->ToPlayer()->GetSession()->SendPacket(&data);
Update aura system:
2010-01-10 01:23:15 +01:00
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectRemoveAura(SpellEffIndex effIndex)
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
{
if (!unitTarget)
return;
// there may be need of specifying casterguid of removed auras
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
unitTarget->RemoveAurasDueToSpell(m_spellInfo->EffectTriggerSpell[effIndex]);
*Implement SPELL_EFFECT_REMOVE_AURA(164)
2010-07-20 04:29:17 +02:00
}
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectCastButtons(SpellEffIndex effIndex)
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
{
if (!unitTarget || m_caster->GetTypeId() != TYPEID_PLAYER)
return;
Player *p_caster = (Player*)m_caster;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
uint32 button_id = m_spellInfo->EffectMiscValue[effIndex] + 132;
uint32 n_buttons = m_spellInfo->EffectMiscValueB[effIndex];
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
for (; n_buttons; n_buttons--, button_id++)
{
Fix action buttons sent to client when swapping between talent specs. Storage related parts by Hunuza (MaNGOS), big thanks.
2010-04-28 16:08:31 +02:00
ActionButton const* ab = p_caster->GetActionButton(button_id);
Fix Shaman totem bars and Call of the Elements/Spirits/Ancestors
2010-04-29 11:35:31 +02:00
if (!ab || ab->GetType() != ACTION_BUTTON_SPELL)
continue;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
Fix action buttons sent to client when swapping between talent specs. Storage related parts by Hunuza (MaNGOS), big thanks.
2010-04-28 16:08:31 +02:00
uint32 spell_id = ab->GetAction();
if (!spell_id)
continue;
if (p_caster->HasSpellCooldown(spell_id))
continue;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
Fix action buttons sent to client when swapping between talent specs. Storage related parts by Hunuza (MaNGOS), big thanks.
2010-04-28 16:08:31 +02:00
SpellEntry const *spellInfo = sSpellStore.LookupEntry(spell_id);
uint32 cost = CalculatePowerCost(spellInfo, m_caster, GetSpellSchoolMask(spellInfo));
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
Fix action buttons sent to client when swapping between talent specs. Storage related parts by Hunuza (MaNGOS), big thanks.
2010-04-28 16:08:31 +02:00
if (m_caster->GetPower(POWER_MANA) < cost)
break;
Update Spell code for 322a. Part 2
2009-12-17 12:23:01 +01:00
m_caster->CastSpell(unitTarget, spell_id, true);
m_caster->ModifyPower(POWER_MANA, -(int32)cost);
p_caster->AddSpellAndCategoryCooldowns(spellInfo, 0);
}
}
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectRechargeManaGem(SpellEffIndex /*effIndex*/)
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
{
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
return;
Core/Spells: Implement TARGET_DEST_CHANNEL_CASTER(106) and TARGET_GAMEOBJECT_AREA_PATH(108). Rename TARGET_UNIT_CHANNEL to TARGET_UNIT_CHANNEL_TARGET, TARGET_DEST_CHANNEL to TARGET_DEST_CHANNEL_TARGET
2010-08-18 15:04:00 +02:00
Player *player = m_caster->ToPlayer();
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
if (!player)
return;
uint32 item_id = m_spellInfo->EffectItemType[0];
Core/ObjectMgr: Refactor sItemStorage
2011-04-28 22:42:33 +02:00
ItemTemplate const *pProto = sObjectMgr->GetItemTemplate(item_id);
Code style (game + scripts only):
2010-04-07 19:14:10 +02:00
if (!pProto)
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
{
Code style (game + scripts only):
2010-04-07 22:59:46 +02:00
player->SendEquipError(EQUIP_ERR_ITEM_NOT_FOUND, NULL, NULL);
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
return;
}
if (Item* pItem = player->GetItemByEntry(item_id))
{
Code style (game + scripts only):
2010-04-07 19:12:44 +02:00
for (int x = 0; x < MAX_ITEM_PROTO_SPELLS; ++x)
Add spaces after commas
2011-04-29 20:47:02 +02:00
pItem->SetSpellCharges(x, pProto->Spells[x].SpellCharges);
pItem->SetState(ITEM_CHANGED, player);
Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
2009-12-26 18:25:49 +01:00
}
}
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
void Spell::EffectBind(SpellEffIndex effIndex)
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
{
if (!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER)
return;
Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
2010-12-03 13:54:00 +01:00
Player* player = unitTarget->ToPlayer();
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
uint32 area_id;
WorldLocation loc;
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
2010-08-27 19:36:27 +02:00
if (m_spellInfo->EffectImplicitTargetA[effIndex] == TARGET_DST_DB || m_spellInfo->EffectImplicitTargetB[effIndex] == TARGET_DST_DB)
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
{
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
2010-12-22 21:25:23 +01:00
SpellTargetPosition const* st = sSpellMgr->GetSpellTargetPosition(m_spellInfo->Id);
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
if (!st)
{
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outError("Spell::EffectBind - unknown teleport coordinates for spell ID %u", m_spellInfo->Id);
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
return;
}
Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
2010-12-03 13:54:00 +01:00
loc.m_mapId = st->target_mapId;
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
loc.m_positionX = st->target_X;
loc.m_positionY = st->target_Y;
Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
2010-12-03 13:54:00 +01:00
loc.m_positionZ = st->target_Z;
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
loc.m_orientation = st->target_Orientation;
area_id = player->GetAreaId();
}
else
{
player->GetPosition(&loc);
area_id = player->GetAreaId();
}
player->SetHomebind(loc, area_id);
// binding
Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
2010-12-03 13:54:00 +01:00
WorldPacket data(SMSG_BINDPOINTUPDATE, (4+4+4+4+4));
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
data << float(loc.m_positionX);
data << float(loc.m_positionY);
data << float(loc.m_positionZ);
data << uint32(loc.m_mapId);
data << uint32(area_id);
Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
2010-12-03 13:54:00 +01:00
player->SendDirectMessage(&data);
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
2010-12-23 23:25:44 +01:00
sLog->outStaticDebug("New homebind X : %f", loc.m_positionX);
sLog->outStaticDebug("New homebind Y : %f", loc.m_positionY);
sLog->outStaticDebug("New homebind Z : %f", loc.m_positionZ);
sLog->outStaticDebug("New homebind MapId : %u", loc.m_mapId);
sLog->outStaticDebug("New homebind AreaId : %u", area_id);
Move around and do some changes to homebinding, thanks to Vladimir
2010-04-18 23:20:07 +02:00
// zone update
data.Initialize(SMSG_PLAYERBOUND, 8+4);
data << uint64(player->GetGUID());
data << uint32(area_id);
player->SendDirectMessage( &data );
}
Reference in New Issue Copy Permalink