Commit Graph
660 Commits
Author SHA1 Message Date
QAston c8adcc95f9 Core/Unit: Move spell specific code from Unit::CalcAbsorbResist to AuraScripts. 2010-12-30 02:03:46 +01:00
leak 1c244cced5 Core/Entities: Fixed disarming and related exploits
- Disarm shouldn't deduct stats other than weapon damage
- Ferals shouldn't be affected by disarm
- Fixed meta gem stacking exploit
2010-12-29 17:18:29 +01:00
Machiavelli 1f7e888465 Core/Units: Units shouldn't be able to dodge while casting 2010-12-29 14:37:55 +01:00
Shauren 82f471cc13 Core/Quests: Fixed repeatable quest still showing as completable after completion
Signed-off-by: Machiavelli <[email protected]>
2010-12-29 13:14:51 +01:00
Machiavelli 6b12ec1f3e Fix build from 68c6189201 2010-12-29 12:09:57 +01:00
Machiavelli 68c6189201 Core/Vehicles:
- Set MovementFlagsExtra (2) correctly depending on vehicle 'template' flags. This makes certain vehicles such as demolishers unable to jump/strafe (as intended)
- Fix SMSG_MONSTER_MOVE_TRANSPORT stucture, prevents a client crash when entering certain vehicles, as well as *properly* broadcast position relative to the vehicle.
- Send SMSG_BREAK_TARGET to player when entering vehicle.
- Set MOVEMENTFLAG_ROOT on passenger when entering vehicle
- Cleanup in affected code
2010-12-29 05:45:38 +01:00
Machiavelli f0db5396f4 Core/Vehicles: Chart some unknown VehicleFlags
Author: zergtm

--HG--
branch : trunk
2010-12-28 16:28:17 +01:00
Shauren 9ac813e147 Core/Player: Fixed weapon swap macro while in combat
Closes issue #4954.

--HG--
branch : trunk
2010-12-28 13:07:54 +01:00
linencloth e739d26eac Core/Player: Keep and store abandoned quests in the DB if CLEANING_FLAG_QUESTSTATUS is not set
Core/QuestStatus: Prevent inactive quest from being added into the questlog

--HG--
branch : trunk
2010-12-28 05:08:57 +01:00
click 464f1a9f8f Core: Kill off some warnings
--HG--
branch : trunk
2010-12-27 22:58:22 +01:00
Shauren 52620db629 Core/Auras: Fixed enchant proc stack rules
Closes issue #5222.

--HG--
branch : trunk
2010-12-27 22:27:11 +01:00
QAston ef968f4b15 Core/Unit: Big cleanup in Unit::CalcAbsorbResist
Core/AuraScript:
	Fix compile time check for AuraScript functions
	Remove AuraApplication from hook functions parameter list, use GetTarget() and GetTargetApplication() instead
	Add OnEffectAbsorb hook
Scripts: move handlers of Spell Deflection, Savage Defense, Primal Tenacity, Nerves of Steel, Astral shift from core to scripts.

--HG--
branch : trunk
2010-12-27 20:14:54 +01:00
Machiavelli dd745ef326 Core/Vehicles: Some research on VehicleSeatFlagsB.
It is assumed that VehicleSeatFlagsB & 322 means the seat can be used indirectly (ie. by aura 236 (SPELL_AURA_CONTROL_VEHICLE)) even though !(VehicleSeatFlags & VEHICLE_SEAT_FLAG_USABLE).
More research to be done Soon (tm).

--HG--
branch : trunk
2010-12-27 16:55:17 +01:00
linencloth efbc73d025 Core/Player: Split RemoveQuest into 2 separate functions
--HG--
branch : trunk
2010-12-26 21:34:08 +01:00
linencloth dfbd344aae Core/QuestStatus: Fix typo
Closes issue 5279

--HG--
branch : trunk
2010-12-26 18:20:58 +01:00
Shauren 79070ca820 Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
--HG--
branch : trunk
2010-12-26 16:35:29 +01:00
linencloth b150172521 Core/QuestStatus:
- Separate rewarded quests from active quests, and store them in a new table to reduce database size
- Drop the no longer needed `rewarded` column from character_queststatus for smaller table size
- Prevent filling the database with dropped quests
  - Delete useless records
- Implement queststatus save "queues" instead of states
- Minor optimizations

WARNING: Backup your database!

--HG--
branch : trunk
2010-12-26 04:16:18 +01:00
click 29d5e4e4d5 Core: Remove a useless log-error in Unit::BuildMovementPacket()
--HG--
branch : trunk
2010-12-26 00:38:01 +01:00
QAston f4e46db38a Core/Auras: Add some asserions to hunt down reason of a crash in Aura::UpdateTargetMap. Thanks to Shauren for inspiration.
--HG--
branch : trunk
2010-12-26 00:14:13 +01:00
Machiavelli 70ec4a8f9b Fix build
--HG--
branch : trunk
2010-12-25 20:12:31 +01:00
Machiavelli 06d014f04d Core/Spells: Remove double initialization of ¨GetAuraEffectsByType(SPELL_AURA_MOD_DAMAGE_PERCENT_DONE)¨ in Unit::MeleeDamageBonus
Patch by [email protected]
Fixes issue #5269

--HG--
branch : trunk
2010-12-25 20:04:12 +01:00
QAston bce9b081ec Core/Unit: Fix crashes in Unit::CalcAbsorbResist and Unit::DealDamage caused by unsafe iteration over Unit::AuraEffectList - copy the list instead of using oryginal one.
--HG--
branch : trunk
2010-12-25 16:12:31 +01:00
click b181ba21d9 Core: Fix a few warnings here and there.
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00
click 088ed9404b Core/Entities: Fix a minor disrepancy in the handling of weapon specializations introduced in revision a83f26ef71 - patch by Dr.Tenma
Fixes issue 5059.
Fixes issue 5265.

--HG--
branch : trunk
2010-12-25 04:03:04 +01:00
Machiavelli 06955a1113 Core/Entities: Fix guid lookup for linked respawn system
--HG--
branch : trunk
2010-12-25 02:22:35 +01:00
Machiavelli c05ed659cb Core/Entities:
- Rename creature_linked_respawn to linked_respawn
- Update functionality: add field ´linkType´.
** 0 = creature respawn dependant on creature (default)
** 1 = creature respawn dependant on gameobject
** 2 = gameobject respawn dependant on gameobject
** 3 = gameobject respawn dependant on creature

--HG--
branch : trunk
2010-12-24 18:55:50 +01:00
Machiavelli f690338de1 Core/CreatureAI: Add virtual bool CanRespawn().
This method will be checked on Creature::Update with deathstate ¨DEAD¨, and allows inherited scripts to manipulate respawn behaviour based on scripted events.

--HG--
branch : trunk
2010-12-24 16:18:23 +01:00
Shauren 928443d899 Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
click ca78881c63 Core/Spells: Fix a warning in SPELL_AURA_MOD_DAMAGE_PERCENT_DONE (explicitly define which parts to check for)
--HG--
branch : trunk
2010-12-23 18:35:43 +01:00
Machiavelli 0cdc4153d8 Core/Spells: Fix Glyph of Death Grip
Fixes issue #4608

--HG--
branch : trunk
2010-12-23 17:38:31 +01:00
Machiavelli 392a312c6b Core/Spells: Fix SPELL_AURA_MOD_DAMAGE_PERCENT_DONE(79) to affect proper spellschools based on EffectMiscValue.
Author: Dr.Tenma
Fixes issue #4019
Fixes issue #5059

--HG--
branch : trunk
2010-12-23 16:22:30 +01:00
Spp 0c8b07d3e5 Core/ScriptMgr: Add OnBindToInstance Player hook
--HG--
branch : trunk
2010-12-23 06:06:21 +01:00
Xanadu cfa26522ad Core: Fixed occasional wrong order of async operations at respawn time saving. Closes issue #5239.
DB schema: Sorted out a discrepancy in respawn time column format.

--HG--
branch : trunk
2010-12-23 05:49:23 +01:00
click b1ded4bd98 Core/Unit: Check if NPC is on a transport before sending StopMoving() -packet (normally shipped when trying to speak to moving NPCs) - fixes creatures falling off boats etc.
Thanks to Socolin for hunting down and patching this annoying bug.

--HG--
branch : trunk
2010-12-22 21:31:52 +01:00
Shauren 0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren 7b4e1c6387 Core/ObjectMgr: Static members are no longer accessed through singleton
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
Shocker 42304c0b25 Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
--HG--
branch : trunk
2010-12-22 20:14:30 +02:00
leak 6115b0bd5f Removing ProgressBars as they are performing badly on startup.
[**************************************************] 100%
R.I.P

--HG--
branch : trunk
2010-12-22 00:12:03 +01:00
leak 68ed96989a Core/Entities: Include prismatic sockets in gem equipment limitation checking. (Stops equipping more than 3 JC gems)
--HG--
branch : trunk
2010-12-21 23:14:38 +01:00
leak 739a3b9165 Core/ObjectMgr: Simplify trainer spell loading. Should decrease loading time on decently sized machines
--HG--
branch : trunk
2010-12-21 20:26:59 +01:00
Shauren 5809c1fa3b Core/Auras: Fixed auras incorrectly stacking with different item casters introduced in r19f21916a940
Closes issue #5218.

--HG--
branch : trunk
2010-12-21 11:40:20 +01:00
click a22818ae09 Core: Some more updates on the gossipicons from previous commit
--HG--
branch : trunk
2010-12-21 05:26:48 +01:00
click 6c5a50f24d Core: Add support for 20 different chaticons in gossip (mostly copies of GOSSIP_ICON_CHAT)
--HG--
branch : trunk
2010-12-21 03:52:40 +01:00
Shauren 89f2870b97 Core/Auras: Save cast item guids for auras to db
--HG--
branch : trunk
2010-12-20 14:55:36 +01:00
Shauren e3e77aceab Scripts/Temple of Anh'Qiraj: Fixed possible crash in mob_anubisath_sentinel
--HG--
branch : trunk
2010-12-20 11:39:12 +01:00
Shauren 756ee5832b Core/Auras: Allow stacking of auras proced from different items
Closes issue #2296.

--HG--
branch : trunk
2010-12-20 11:04:48 +01:00
Machiavelli 33808ab567 Core/Spells: Fix Improved Spirit Tap proc from Mind Flay crits.
Author: Dr.Tenma
Fixes issue #2786

--HG--
branch : trunk
2010-12-20 01:58:15 +01:00
Machiavelli f71c97f6c5 Core/Items: Fix ITEM_SPELLTRIGGER_ON_NO_DELAY_USE (5). This trigger should (only) trigger the respective spell when the item is added to the inventory. Aura´s created by this spell will be properly removed when the item is destroyed as well.
--HG--
branch : trunk
2010-12-20 00:46:00 +01:00
leak fd694cd232 Streamlining loading functions for server startup
- Added a couple of timer outputs
- Improved code consistency between loading functions
- Progess bars should look and behave similar on all OS now (sLog.outString() is not needed anymore to replace the progress bar in log files)

--HG--
branch : trunk
2010-12-19 17:06:33 +01:00
Shauren 14a480cb13 Core/Players: Fixed recently introduced crashes in Player::ApplyEnchantment
Closes issue #5193.

--HG--
branch : trunk
2010-12-19 15:22:19 +01:00