Machiavelli
8b83ae0c05
Scripts/Storm Peaks: Typo in 0cb688, thanks to simlt
2011-08-14 11:07:00 +02:00
Machiavelli
0cb68815ec
Scripts/Storm Peaks: Make Hyldsmeet Drakerider properly respawn.
2011-08-13 22:04:05 +02:00
Machiavelli
30a54e43ca
DB/FULL: Remove redundant full content files for world database from the repo. They serve no particular purpose to the project other than consume precious time of the developers having to maintain it. If you're using TDB, this shouldn't affect you in any way since the full world database is periodically dumped and uploaded.
2011-08-13 21:56:50 +02:00
Machiavelli
65a29d1315
Scripts/Spells: Fix a typo in spell_hun_masters_call
2011-08-13 21:46:25 +02:00
Machiavelli
4a3a259e2a
Core/SOAP: Remove redundant thread pool of a hard coded 5 amount of threads that would just linger. Not really smart design to have a single SOAP thread -> SOAP thread pool -> single world thread handling CLI commands.
...
Thanks to leak for spotting the leak.
2011-08-08 17:48:01 +02:00
Machiavelli
beaca1bd34
Fix build
2011-08-07 21:58:35 +02:00
Machiavelli
2d3f51e6e5
Core/Spells: Fix Shaman talent Nature's Guardian and rewrite fix for fc52f08. Fixes some spells not triggering.
2011-08-07 21:19:27 +02:00
Machiavelli
3109d9c0ae
Core/Spells: Spells that can be spellstolen that have a permanent duration should respect the 2 minute spellsteal buff duration limit.
2011-08-07 17:49:02 +02:00
Machiavelli
77c0ca3112
Core/Spells: Hunter ability Master's Call should not process effects when pet is dead.
2011-08-07 16:12:19 +02:00
Machiavelli
04c2f2929e
Core/Player: Fix item refund exploit
2011-08-07 15:57:26 +02:00
Machiavelli
156d491c27
Core/Spells: Add GetTriggeringSpell() method to SpellScript and use it to properly filter server side spell 18350's script.
2011-08-06 19:40:50 +02:00
Machiavelli
98bdbdd76f
Fix build on gcc 4.6 :/
...
Closes #2479
2011-08-03 12:50:15 +02:00
Machiavelli
cb5ba6b3c9
Core/RA: Fix RA subnegotiation for clients that don't send any subnegotiation data (like telnet) by setting a 1 second time window in which the client can send their packet before the RASocket will begin actual authentication.
...
Closes #2471
2011-08-02 01:55:18 +02:00
Machiavelli
fc52f0846e
Core/Spells: Fix Soul Preserver trinket
2011-08-01 23:57:16 +02:00
Machiavelli
ff3c988ee7
Core/Entities: Allow Shaman totems to crit with spells, and add a temp workaround to make Fire Elemental Totem spawn crit with spells also.
...
Closes #252
Closes #1846
2011-08-01 18:30:00 +02:00
Machiavelli
acc2e88c31
Core/RA: Fix RA usage, properly filter out RFC 854 / 855 subnegotiate data
2011-08-01 04:02:08 +02:00
Machiavelli
9efcf82db2
Core/Spells: Update comment
2011-08-01 00:48:11 +02:00
Machiavelli
6732cbbde5
Core/Spells: Fix Shaman Wind Shear (Threat reduction part)
...
Closes #860
2011-07-31 23:49:29 +02:00
Machiavelli
c074be2944
Core/Spells: Small update to TriggeredFlags and fix Glyph of Totem of Wrath with it.
...
Closes #2458
2011-07-31 23:47:11 +02:00
Machiavelli
f26edf09d3
Fix gcc build and remove redundant check from 0afc3c
2011-07-31 22:27:57 +02:00
Machiavelli
0711746b57
Core/Visibility: Send object destroy packets to dead players. Fixes persistent visuals of no longer existing entities while dead.
...
Closes #2458
2011-07-31 21:58:28 +02:00
Machiavelli
d4a68025c7
Core/Spells: Fix Shaman talent Storm, Earth, Fire (Earthgrab part) in case of using Earthbind totem trough Call of the Elements etc.
2011-07-31 21:58:27 +02:00
Machiavelli
58f10c74f7
Core/Spells: Change low level bool triggered with bitmask TriggerCastFlags to better manipulate the behaviour of certain triggered spells.
2011-07-31 21:58:25 +02:00
Machiavelli
0afc3cf110
Core/ChatLog: Properly filter out addon messages in whisper, party, raid and battleground.
...
Original patch by tassader1000
2011-07-31 14:40:15 +02:00
Machiavelli
8ceb780213
Core/Spells: Fix Shaman totem bar exploit that would allow the player to cast any spell when using Call of the Elements etc.
...
Original patch by 3kids
Closes #2356
2011-07-31 14:12:53 +02:00
Machiavelli
b2d37062a0
Core/Vehicles: Allow damaging NPC passengers.
...
+ Forgotten change from 2effb7
2011-07-30 21:55:06 +02:00
Machiavelli
0ecb47bc8a
Core/Spells & Vehicles: Define and implement SPELL_ATTR6_CASTABLE_WHILE_ON_VEHICLE and VEHICLE_SEAT_FLAG_CAN_CAST_MOUNT_SPELL.
...
Research done by QAston
2011-07-30 20:36:19 +02:00
Machiavelli
2effb7acdc
Core/Spells: Fix client crash on ESC when channeling certain spells (e.g. Eye of Acherus, Death Knight Understudy)
...
Fixes #1131
2011-07-30 19:16:54 +02:00
Machiavelli
3d56bd5eb8
Core/CLI: Fix a possible crash in utf8print on linux. (Remove parsing non-existent va_args)
2011-07-29 15:02:22 +02:00
Machiavelli
981e3540c8
Core/Chat: Fix a crash in .lookup spell command
2011-07-29 15:02:20 +02:00
Machiavelli
0c6079790b
Core/Misc: Make 64-bit abs function 'portable'. Should fix build on MSVC versions =< 9
2011-07-29 00:59:30 +02:00
Machiavelli
e291464e06
Fix a warning
2011-07-27 21:27:43 +02:00
Machiavelli
0dcc229071
Core/Commands: Allow muting offline players - the mute will become effective on next player login.
2011-07-27 17:51:57 +02:00
Machiavelli
2eb69330b4
Core/DBLayer: Fix Field::GetInt64 parsing for non-prepared statements
2011-07-27 17:45:49 +02:00
Machiavelli
dae2a088fd
Core/Entities: After some research redefine MOVEMENTFLAG_MASK_MOVING and make it entirely mutually exclusive with MOVEMENTFLAG_ROOT - fixes the last of the related client freezes.
2011-07-19 20:37:17 +02:00
Machiavelli
85caf3a2c1
Core/Instances: Fix dungeon and raid difficulty setting for characters under level 70. Prevents entering heroic modes of instances when access criteria are not met.
2011-07-19 20:35:05 +02:00
Machiavelli
bcdbc9517e
Scripts/Naxxramas: Remove improper unit flags from Gothik the Harvester and properly make him ignore damage taken in phase 1.
2011-07-19 20:32:31 +02:00
Machiavelli
e9e50c4937
Core/Players: Fix corpse remove visual for clients
2011-07-13 14:40:46 +02:00
Machiavelli
145ff66382
Core/Entities: MOVEMENTFLAG_ROOT in conjunction with MOVEMENTFLAG_FALLING will cause client freezes, so make them mutually exclusive.
2011-07-12 00:22:38 +02:00
Machiavelli
609efde598
Core/Corpses: Fix a crash in ConvertCorpseForPlayer
2011-06-29 16:08:23 +02:00
Machiavelli
299dd39d1f
Scripts/Naxxramas: Achievement The Safetey Dance (Heigan the Unclean) shouldn't be marked as failed if non players die due to erruptions. Also tiny cleanup in affected file.
2011-06-29 05:03:47 +02:00
Machiavelli
cbdb8d9cdc
Core/Players: restore fuNcti0N4lity of player bones, that was reMov3d for no apparant reaSon and Underlined with the Comment "// we don't want bones to save some cpu.. :)". this fixes insignia looting after honorable KillS. also fixes a crash with the previous code.
2011-06-29 04:54:10 +02:00
Machiavelli
e5d253170e
Core/Entities: Fix looting gold from vehicles.
2011-06-28 23:11:15 +02:00
Machiavelli
6a59d7ddc1
Core/Entities: Vehicles should be able to be the source of map scripts
2011-06-28 21:43:06 +02:00
Machiavelli
f19f0a19f2
Core/Players: Fix possible (exploitable) data desynchronisation that would lead to repeating the same quest while already having received the rewards.
2011-06-28 21:36:21 +02:00
Machiavelli
86a48c1b63
Core/Vehicles: Fix CMSGS_CHANGE_SEATS_ON_CONTROLLED_VEHICLE after recent aura system changes. With thanks to QAston.
2011-06-28 16:48:57 +02:00
Machiavelli
e2f49f63bc
Core/Entities: Instead of clearing all unit movementflags on SetRoot and SetStunned, only remove ones that are confirmed to be conflicting with MOVEMENTFLAG_ROOT. Fixes vehicle passenger visuals.
...
Closes #2141
2011-06-27 21:25:00 +02:00
Machiavelli
23b9a31229
Core/Vehicles: Final stage of vehicle stat scaling table removal
2011-06-27 15:20:26 +02:00
Machiavelli
ad1777229f
Core/Vehicles: More codestyle. (missed changes)
2011-06-27 14:42:28 +02:00
Machiavelli
8a7957a759
Core/Vehicles: Remove now unused variables and apply codestyle in Vehicle class
2011-06-27 14:36:00 +02:00
Machiavelli
921b39fb2d
Core/Units: Extend change from 6ce529 to Unit::SetRooted as well (was overlooked)
2011-06-27 13:33:56 +02:00
Machiavelli
e8b4d1fab7
Core/Spells: Fix side effects from 33f3397 (issues related to Mangle for druids not being re-learned on talent switch). Original fix done alternatively.
2011-06-27 02:01:20 +02:00
Machiavelli
5864a2e151
Core/Packets: Add some additional movementflag filtering to eliminate some packet spoof attempts.
2011-06-27 00:10:53 +02:00
Machiavelli
6ce529aff3
Core/Entities: Add MOVEMENTFLAG_ROOT to unit on Unit::SetStunned, and remove any other conflicting movement flags that might freeze clients.
...
This *properly* fixes the ancient root freeze issue that surfaced during the early stages of 3.x
2011-06-26 21:36:20 +02:00
Machiavelli
ad81d4132c
Core/Packets: Remove MOVEMENTFLAG_ROOT flag from movementinfo that is sent from client to server. This flag is not valid in this case and is a packet spoofing attempt. When used in conjunction with any of the moving movement flags such as MOVEMENTFLAG_FORWARD this will freeze surrounding clients that receive the cheater's movementinfo.
...
Thanks to Dvlpr for help with research.
2011-06-26 21:27:10 +02:00
Machiavelli
33f3397976
Core/Spells: Completely remove spells which were taught by SPELL_EFFECT_LEARN_SPELL on talent reset or talent spec switch - instead of keeping them stored as disabled. Reason for this is that if the primary spell with effect SPELL_EFFECT_LEARN_SPELL is learnt again, a 'new' secondary spell will be taught while the old one was still around. The latter was the reason for primary key violations in character_spell that led to transaction failures and thus character rollbacks.
...
Closes #1231
Closes #480
2011-06-23 02:39:36 +02:00
Machiavelli
719a079464
Core/WorldSession: Store correct packet in CharacterCreateInfo
2011-06-22 23:30:30 +02:00
Machiavelli
78a90e7bad
Core/Worldsession: Fix death knight character creation logic after recent commits
2011-06-22 23:03:53 +02:00
Machiavelli
2b3ee302f7
Missing line from 9b17b9.
2011-06-22 20:55:32 +02:00
Machiavelli
9b17b9c3ba
Core/DBLayer: Fix possible crashes from fe8cb7
2011-06-22 18:04:12 +02:00
Machiavelli
0df059d5a2
Core/DBLayer: Don't lock a connection when doing mysql_real_escape_string as it doesn't need to interact with the server.
2011-06-22 15:04:13 +02:00
Machiavelli
fe8cb75bf1
Core/DBLayer: Make database interaction after create character packet completely asynchronous. This is more performant and fixes a DoS loophole and possible data desynchronisation caused by spamming this packet.
...
Closes #584
Closes #2089
2011-06-22 14:22:08 +02:00
Machiavelli
8bf53f4a6b
Fix copypasta mistake from acb47d, thanks to Lopin for pointing out.
2011-06-21 13:05:08 +02:00
Machiavelli
aa55e2a417
Scripts/Ulduar/Flame Leviathan: Make Pool of Tar actually apply harmful auras without resetting instantly.
...
Closes #1798
2011-06-21 02:07:06 +02:00
Machiavelli
3f5453c657
Scripts/Ulduar/Kologarn: Fix Stone Shout target selection
2011-06-21 01:52:01 +02:00
Machiavelli
acb47d719c
Scripts/Ulduar/XT002:
...
- Fix heart phase triggering if boss recovered health from scrapbots previously
- Fix scrapbot enter vehicle visual
- Allover cleanup and codestyle appliance
2011-06-21 01:15:43 +02:00
Machiavelli
e1f7f9e5b1
Core/Players: Fix average item level calculation: omit shirt shot, not chest armor slot. Thanks to AreYouSiries for pointing out.
...
See issue #894
2011-06-12 03:06:33 +02:00
Machiavelli
c19dd5b8f9
Scripts/Ulduar/Kologarn: Only set arms in combat with zone if encounter is actually in progress. Thanks to Josh for pointing out.
2011-06-10 19:48:45 +02:00
Machiavelli
d0f1dd552a
Minor cosmetic fix for SQL from previous commit.
2011-06-10 18:30:23 +02:00
Machiavelli
680798a11d
Scripts/Ulduar/XT-002:
...
- Implement achievement Nerf Engineering
- Implement achievement Nerf Gravity Bombs
- Implement achievement Heartbreaker
- Boombot's shouldn't melee
- Call BossAI::Reset in XT002::Reset, fixes some timer issues
2011-06-10 18:24:16 +02:00
Machiavelli
3a5e3e71a4
DB/Entities/Ulduar: Update templates and addon data for adds during XT-002 encounter
2011-06-10 03:27:19 +02:00
Machiavelli
036fc88c1a
Scripts/Ulduar/XT-002: Update TODO comments to reflect todays changes.
2011-06-10 03:25:41 +02:00
Machiavelli
84b27f7194
Scripts/Ulduar/XT-002:
...
- Fix Boombot's explosion visual and damage (workarounds are torroughly explained in code)
- Proper scrapbot vehicle enter handling. (Missing data on how much HP they should restore on the boss, however)
2011-06-10 03:24:32 +02:00
Machiavelli
c0bc829376
Scripts/Ulduar/XT-002:
...
- Fix phase transition submerge/stand visuals
- Further cleanup and minor fixing
2011-06-09 17:52:34 +02:00
Machiavelli
b42239b237
Scripts/Ulduar/XT-002:
...
- Implement "Nerf Scrapbots" achievement
- Proper target conditions for Boombot Boom
- Pummeler add should walk towards raid on spawn
2011-06-09 04:43:57 +02:00
Machiavelli
9505607d95
Scripts/Spells: Proper target selection for 62775 - with thanks to Kaelima
2011-06-08 20:06:41 +02:00
Machiavelli
f4229e52f2
Core/Spells: Fix radius for spell 62775 (Ulduar/XT-002 encounter)
2011-06-08 16:52:02 +02:00
Machiavelli
109a861407
Fix non-PCH build
2011-06-07 16:56:32 +02:00
Machiavelli
730043c58f
Fix non-PCH build
2011-06-07 16:48:00 +02:00
Machiavelli
16ceb5a39e
Core/Spells: Change a log message to debug level and make it more descriptive.
2011-06-07 16:23:20 +02:00
Machiavelli
e8bc02f3bd
Scripts/Ulduar: Remove dirty spell and summon hacks from XT-002 script and rewrite with EventMap.
...
Script is still WIP.
2011-06-07 16:13:14 +02:00
Machiavelli
05cc29b54a
DB/Schema: Add index to characters.character_pet.slot. Prevents deadlocks when operating on this table.
2011-05-29 18:28:54 +02:00
Machiavelli
f8bd56e219
DB/Schema: Correct use of indexes on mail_items table. Prevents deadlocks in operations on this table.
2011-05-29 00:32:18 +02:00
Machiavelli
48b0570f53
Core/Vehicles:
...
- Temporarily unsummon pets when entering vehicle and resummon them when exiting. Also fixes missing pet cast bars on exit.
- Correct SMSG_PET_SPELLS packet for vehicle spell initialize
2011-05-27 17:31:31 +02:00
Machiavelli
08ecee3b13
Core/DBLayer: Fix transaction crash.
2011-05-24 18:27:27 +02:00
Machiavelli
7f96d4b01f
Fix crash added in 402198
2011-05-23 19:14:39 +02:00
Machiavelli
402198c5ff
Core/DBLayer: Proper core-side handling of MySQL errno 1213 to prevent a snowballeffect (until innodb_lock_wait_timeout)
2011-05-23 16:33:33 +02:00
Machiavelli
48838cca27
Fix build on Linux
2011-05-22 13:49:39 +02:00
Machiavelli
29e61ad0ea
Core/DBLayer: Remove a problematic and unneeded transaction in _LoadMails
2011-05-22 13:43:57 +02:00
Machiavelli
d454ee2a74
Core/DBLayer: Apparantly the possible deadlock was present in Player::DeleteFromDB as well.
...
Thanks to Aokromes for pointing out
2011-05-21 14:50:28 +02:00
Machiavelli
59c0670f44
Core/DBLayer: Fix possible transaction deadlock in HandleMailReturnToSender opcode
2011-05-21 14:24:46 +02:00
Machiavelli
374eba2f5d
Scripts/Shadowmoon Valley: Fix kill credit for Enraged Spirits
2011-04-26 23:30:13 +02:00
Machiavelli
6d0c97b06b
Core/SAI: Fix a possible crash in SMART_ACTION_SET_ORIENTATION with SMART_TARGET_SELF for TempSummons
2011-04-22 12:19:34 +02:00
Machiavelli
c9a917ad79
Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value
...
Small cleanup in affected function.
2011-04-22 12:05:15 +02:00
Machiavelli
d42ab6c8bd
Core/ScriptedAI: Reset VehicleKit in BossAI::_Reset()
...
Core/Vehicles: Minor log fix and comment a redundant assertion
2011-04-22 11:07:58 +02:00
Machiavelli
1c3082446e
Core/Gameobject: Respect cooldown for trap and goober gameobjects.
...
Original patch by VladimirMangos
2011-03-14 23:16:34 +01:00
Machiavelli
31a2c9b82b
Core: Fix crash in ~ScriptMgr
...
Fixes : #854
Fixes : #918
Fixes : #917
2011-03-14 09:44:02 +01:00
Machiavelli
7b62bfc1c5
Core/ScriptedAI: Add ResetLootMode() to BossAI::_Reset() and remove some redundant calls in General Vezax script
2011-03-13 22:28:37 +01:00
Machiavelli
e1ac75afe2
Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
...
Research by Kaelima
2011-03-07 21:13:18 +01:00
Machiavelli
28b14f36c8
Core/Vehicle: Use db table GuidLow instead of normal GuidLow (which may differ per instance) for vehicle_accessory definitions.
2011-03-07 20:48:53 +01:00