Commit Graph
100 Commits
Author SHA1 Message Date
Shauren 5282dcbc5a Core/PacketIO: Use default compiler generated copy and move operations in WorldPacket
(cherry picked from commit b758b56be4088a80fcb2094885267af9333d28e5)
Signed-off-by: luis <[email protected]>
2026-05-13 21:44:11 -03:00
Shauren 05a2b81e74 Core/CrashHandler: Fix formatting single char variables
Signed-off-by: luis <[email protected]>
2026-05-12 08:29:13 -03:00
Shauren 88f0137b4c Core/CrashHandler: Update enums from DIA SDK
Signed-off-by: luis <[email protected]>
2026-05-12 08:28:30 -03:00
Shauren dd497fdcc3 Core/CrashHandler: Replace unsafe pointer dereferences wrapped in __try/__except with ReadProcessMemory
Signed-off-by: luis <[email protected]>
2026-05-12 08:26:28 -03:00
Shauren f57149a160 Core/Misc: Reorder function definitions in MiscPackets.cpp to match declaration order in header
Signed-off-by: luis <[email protected]>
2026-05-12 08:25:44 -03:00
Shauren f3b4b9b73f Core/Misc: Fix linker errors with clang-cl
Signed-off-by: luis <[email protected]>
2026-05-12 08:25:03 -03:00
Shauren 7d2879e0c8 Core/Misc: Nopch build fix for msvc
Signed-off-by: luis <[email protected]>
2026-05-12 08:23:56 -03:00
Shauren 4b32cef125 Core/Misc: Remove old msvc warning suppression workarounds for do {} while (0) constructs used in assert and logging macros
Signed-off-by: luis <[email protected]>
2026-05-12 08:21:37 -03:00
Shauren d1b5e93168 Core/Misc: Changed compiler detection to better support compilers that pretend to be something else, such as clang-cl is both msvc and clang at the same time
Signed-off-by: luis <[email protected]>
2026-05-12 08:15:13 -03:00
Shauren 42ecab9e7f Core/Position: Add StringFormat support for Position and WorldLocation
Signed-off-by: luis <[email protected]>
2026-05-11 19:59:20 -03:00
Shauren e78f5dce1f Core/Movement: Move ValidateMovementInfo back to WorldSession class to reduce differences between branches
Signed-off-by: luis <[email protected]>
2026-05-08 21:57:08 -03:00
Shauren f0806d0492 Dep/g3d: Fix warnings with gcc 16
Signed-off-by: luis <[email protected]>
2026-05-08 21:44:55 -03:00
Shauren 26e5bc3232 Dep/g3d: Build fix for gcc on windows
Signed-off-by: luis <[email protected]>
2026-05-08 21:42:37 -03:00
Shauren a4afe6dbd9 Core/Spells: Removed incorrect generated proc data for different difficulties for spells that already have rows in spell_proc table
Signed-off-by: luis <[email protected]>
2026-05-08 21:41:58 -03:00
Shauren 7c17f70151 Core/Movement: Implement FadeObject spline flag for playing smooth despawn animations
Signed-off-by: luis <[email protected]>
2026-05-07 00:50:18 -03:00
Shauren 36e76eb5c7 Core/Commands: FIx .character deleted commands outputting full guid strings instead of just counters (full guids cannot be used as input for other .character deleted commands)
Signed-off-by: luis <[email protected]>
2026-05-06 13:28:00 -03:00
Shauren ff18a1c501 Core/Objects: Private objects are no longer able to see non-private objects other than their owner
Signed-off-by: luis <[email protected]>
2026-05-05 08:36:56 -03:00
Shauren 1215c7aad0 Core/Vehicles: Remove incorrect passenger->vehicle threat redirection
Closes #31832

Signed-off-by: luis <[email protected]>
2026-05-05 08:36:10 -03:00
Shauren 8fb211a1e0 Core/DataStores: Skip MapDifficulty rows that don't point to a valid map id and remove asserts on Difficulty.db2 checks (0 is a valid difficulty for a map and it doesn't have data in that file)
Signed-off-by: luis <[email protected]>
2026-05-04 20:58:51 -03:00
Shauren 8ccf4e4629 Core/DataStores: Add id to assertion message in DB2Storage::AssertEntry
Signed-off-by: luis <[email protected]>
2026-05-03 03:10:12 -03:00
Shauren f49020bf5b DB/Creatures: Add vendor data for 12.0.5 void assault npcs
Maren Silverwing <Quartermaster>
Triam Dawnsetter <Cosmetic Equipment Salvager>
Rae'ana <Historian and Research Supplier>
Sergeant Vornin <Animal Handler>

Signed-off-by: luis <[email protected]>
2026-05-02 13:42:31 -03:00
Shauren d0023aec46 Dep/jemalloc: Update to 5.3.1
Signed-off-by: luis <[email protected]>
2026-05-02 13:42:31 -03:00
Shauren 9c70cdfe16 Core/Players: Correct new trait condition check
Signed-off-by: luis <[email protected]>
2026-04-28 21:20:30 -03:00
Shauren 79b34b102d Core/Players:: Improve trait config validation and implement new condition type used for apex talents
Signed-off-by: luis <[email protected]>
2026-04-28 21:17:19 -03:00
Shauren a9c86ce643 Core/Players: Fixed crash happening on character creation when StartPlayerLevel is set to a value greater than 10
Signed-off-by: luis <[email protected]>
2026-04-28 20:17:14 -03:00
Shauren db8ec66be9 Core/Spells: Add SpellRange structure to replace std::pair<float, float> in spell range checks
Signed-off-by: luis <[email protected]>
2026-04-26 17:02:48 -03:00
Shauren d5227dada5 Scripts/Azjol-Nerub: Fixed Anub'ar Assassin jump pos selection after 5423f36b4d7d0a9830be91c310a19329f57a1cce
Signed-off-by: luis <[email protected]>
2026-04-26 17:02:14 -03:00
Shauren 1d89900c29 Core/Players: Move loading transmog outfits before loading items and rewarded quests
Closes #31816

Signed-off-by: luis <[email protected]>
2026-04-26 17:01:33 -03:00
Shauren 51a67b17c9 Core/Quests: Fix adding and removing quests
Closes #31812

Signed-off-by: luis <[email protected]>
2026-04-25 08:04:27 -03:00
Shauren d3446aed99 Core/Misc: Apply random position selection improvements from ed2a08dc707808caaf5f4b876620dcb510706f96 to WorldObject::GetRandomPoint and WorldObject::GetRandomNearPosition
Signed-off-by: luis <[email protected]>
2026-04-25 08:03:47 -03:00
Shauren 7fecc13c8d Core/Network: Build fix for boost 1.91
Signed-off-by: luis <[email protected]>
2026-04-25 08:02:22 -03:00
Shauren 58bb016e34 Core/Players: Fixed use after free in loading transmog outfit slots
Signed-off-by: luis <[email protected]>
2026-04-25 08:01:35 -03:00
Shauren 33d641a88c Core/Misc: Support arrays in RaceMask util
Signed-off-by: luis <[email protected]>
2026-04-21 20:42:04 -03:00
Shauren 87d77abcb2 Core/Bnet: Fixed bnetserver getting stuck on shutdown when running as windows service
Signed-off-by: luis <[email protected]>
2026-04-18 22:40:28 -03:00
Shauren c4e487b936 Core/Crypto: Support OpenSSL 4.0
Signed-off-by: luis <[email protected]>
2026-04-17 08:37:35 -03:00
Shauren e972774513 Dep/gSOAP: Disable unused openssl integration
Signed-off-by: luis <[email protected]>
2026-04-17 08:36:50 -03:00
Shauren 1fe5f4ed85 Dep/gSOAP: Upgrade to 2.8.141
Signed-off-by: luis <[email protected]>
2026-04-17 08:36:06 -03:00
Shauren 3dbf70aa9f Core/Misc: Change Float*chrono* typedefs to double to match return type of chrono_literals
Signed-off-by: luis <[email protected]>
2026-04-16 19:41:23 -03:00
Shauren a811e40393 Core/Auras: Update absorb aura priority ordering
Signed-off-by: luis <[email protected]>
2026-04-15 19:39:37 -03:00
Shauren 8e192028ed Core/Network: Fix build with msvc versions < 19.43 (vs 2022 17.13)
Signed-off-by: luis <[email protected]>
2026-04-06 19:22:05 -03:00
Shauren d2fa0ab30c Dep/jemalloc: Fix build on arm64
Closes #31776

Signed-off-by: luis <[email protected]>
2026-04-05 12:29:16 -03:00
Shauren bed2dde183 Core/Auras: Define new aura type
Signed-off-by: luis <[email protected]>
2026-04-05 12:27:51 -03:00
Shauren 3fb57b3400 Core/Players: Define new CharacterFlags4
Signed-off-by: luis <[email protected]>
2026-04-02 21:17:53 -03:00
Shauren ec7d87555f Core/Spells: Changed SpellEffectInfo::CalcBaseValue return type to double
Signed-off-by: luis <[email protected]>
2026-03-30 15:30:54 -03:00
Shauren 292d597c8b Core/Commands: Fix copypaste
Signed-off-by: luis <[email protected]>
2026-03-30 15:29:23 -03:00
Shauren 0e060a2f4f Core/Utils: Fixed Trinity::GetTypeName return value when given std::type_info args directly
Signed-off-by: luis <[email protected]>
2026-03-28 08:51:31 -03:00
Shauren 7274ff07fb Core/Misc: Reduce memory usage when data query cache is disabled in config
Signed-off-by: luis <[email protected]>
2026-03-13 19:34:15 -03:00
Shauren 291526eebb Core/Misc: Add missing includes and remove unneccessary Bag::GetDebugInfo override
Signed-off-by: luis <[email protected]>
2026-03-13 19:33:06 -03:00
Shauren 5badcaaf3c Core/Spells: Fixed spell visual selection
Signed-off-by: luis <[email protected]>
2026-03-12 19:49:00 -03:00
Shauren 9e0d2040f2 Core/Misc: Remove outdated TODO comment
Signed-off-by: luis <[email protected]>
2026-03-12 19:44:25 -03:00
Shauren 786dee89e2 Scripts/Spells: Handle haranir Shadowy Apparitions spell visual
Signed-off-by: luis <[email protected]>
2026-03-12 19:43:26 -03:00
Shauren 154d79123c Core/AuctionHouse: Replace IteratorPair with std::span
Signed-off-by: luis <[email protected]>
2026-03-11 14:01:19 -03:00
Shauren cb995fb8e9 Core/Conditions: Replace Condition::ToString with fmt::formatter
Signed-off-by: luis <[email protected]>
2026-03-11 08:46:54 -03:00
Shauren 9ee3a615f7 Core/Spells: Fixed spells with SPELL_ATTR6_DO_NOT_CHAIN_TO_CROWD_CONTROLLED_TARGETS ignoring permanently rooted creatures (with static flags)
Signed-off-by: luis <[email protected]>
2026-03-07 00:11:08 -03:00
Shauren 21f43c007f Core/Utils: Modernize Types and Tuples utils - use constexpr variables instead of structs
* Also remove unneccessary tuple type list wrapping in packet utilities

Signed-off-by: luis <[email protected]>
2026-03-06 23:35:38 -03:00
Shauren fa3a97199f Core/Players: Fixed crashes happening when player is teleported again while still being teleported to a different map
Signed-off-by: luis <[email protected]>
2026-03-05 19:46:28 -03:00
Shauren 92e3a347f1 Scripts/Exile's Reach: Remove unreachable code that appears to be the result of incorrect merge conflict resolution
Signed-off-by: luis <[email protected]>
2026-03-04 20:29:19 -03:00
Shauren df7dd23efe Core/Misc: Remove unneccessary semicolons
Signed-off-by: luis <[email protected]>
2026-03-04 20:28:34 -03:00
Shauren d67801df7f Core/Spells: Fixed autoattack timer being reset by almost every spell cast
Signed-off-by: luis <[email protected]>
2026-03-03 19:37:55 -03:00
Shauren 5cf43f4d72 Core/Achievements: Reduce differences between branches
Signed-off-by: luis <[email protected]>
2026-03-02 20:40:24 -03:00
Shauren e406aae2cf Scripts/Spells: Fix wrong hook being used for Evangelism script
Closes #31699

Signed-off-by: luis <[email protected]>
2026-03-02 20:37:30 -03:00
Shauren f941c2a241 Core/Items: Move selling items to separate function
Signed-off-by: luis <[email protected]>
2026-03-02 20:36:52 -03:00
Shauren 8df84a64c0 Core/Spells: Fixed proc phase order for spells with no travel time (CAST now happens before FINISH as intended)
Signed-off-by: luis <[email protected]>
2026-02-28 18:55:43 -03:00
Shauren 0dd1579a55 Core/Spells: Move duplicated code for proc flag selection to separate function
Signed-off-by: luis <[email protected]>
2026-02-28 18:54:53 -03:00
Shauren 92b018f2ad Dep/jemalloc: Update to 5.3.0
Closes #31684

Signed-off-by: luis <[email protected]>
2026-02-27 00:31:56 -03:00
Shauren 4fb3b19844 Core/AreaTriggers: Fixed crashes caused by areatrigger OnUnitEnter/OnUnitExit scripts teleporting players to other maps
Signed-off-by: luis <[email protected]>
2026-02-25 21:29:31 -03:00
Shauren b561055a1a Core/Spells: Update CAST_FLAG_NO_GCD flag implementation
Signed-off-by: luis <[email protected]>
2026-02-25 21:28:51 -03:00
Shauren 1729893051 Core/MMaps: Fix possible access of freed memory in DynamicTileBuilder
Signed-off-by: luis <[email protected]>
2026-02-22 18:33:46 -03:00
Shauren dec0ec0c6e Core/Players: Fixed storing items in bank bags slots 67-74
Signed-off-by: luis <[email protected]>
2026-02-22 18:33:02 -03:00
Shauren 6b58f36323 Build: Remove scripts include directories from worldserver compilation command line, allowing compilation to happen in directories with longer path before encountering msbuild error MSB6002: The command-line for the “RC” task is too long
Signed-off-by: luis <[email protected]>
2026-02-22 18:31:29 -03:00
Shauren a13be38357 Core/Graveyards: Fixed subzone graveyard selection
Signed-off-by: luis <[email protected]>
2026-02-20 22:33:20 -03:00
Shauren 265b3dbeaf Core/Scripts: Expose Spell::GetUnitTargetIndexForEffect in scripts
Signed-off-by: luis <[email protected]>
2026-02-20 08:19:16 -03:00
Shauren 678a0af72d Core/Transports: Fixed transport path length calculation for transports that teleport on the same map or havev Delay on their first waypoint
Signed-off-by: luis <[email protected]>
2026-02-19 22:04:25 -03:00
Shauren ada7ff67a4 Core/Players: Minor skill loading improvements
* Fix initializing skill slots after they were increased from 256 to 300
* Improve skill step detection during loading from db
* Add safeguard for invalid data saved in character_skill (value = 0)

Signed-off-by: luis <[email protected]>
2026-02-16 20:53:52 -03:00
Shauren 3d551cea9b Core/Scripts: Modernize InstanceScript::Load*Some*Data arrays to use std::span instead of requiring a dummy end markers inside the arrays
Signed-off-by: luis <[email protected]>
2026-02-15 17:42:14 -03:00
Shauren aa1722626e Scripts/WanderingIsle: Fix wrong function being used in bec04e62d892b5908382275a1b90442d2e3f6134
Signed-off-by: luis <[email protected]>
2026-02-15 17:41:30 -03:00
Shauren 5e826f3fd1 Core/Spells: Prevent attacking friendly targets by SPELL_ATTR7_ATTACK_ON_CHARGE_TO_UNIT
Signed-off-by: luis <[email protected]>
2026-02-15 17:39:49 -03:00
Shauren c4d0b7e41f Core/Misc: Update GameError enum for 12.0.1
Signed-off-by: luis <[email protected]>
2026-02-15 17:22:46 -03:00
Shauren 4940084c35 Core/Spells: Update targets caps for 12.0.1
Signed-off-by: luis <[email protected]>
2026-02-15 17:12:10 -03:00
Shauren 54c0cebeee Core: Updated to 12.0.1
Signed-off-by: luis <[email protected]>
2026-02-12 20:22:00 -03:00
Shauren f1d6cdf3d9 Core/Units: Fix crashes caused by spirit being brought back into existence in 12.0.0
Signed-off-by: luis <[email protected]>
2026-02-11 20:19:44 -03:00
Shauren 2e8a8df234 Core/Movement: Improve Turning spline handling
Signed-off-by: luis <[email protected]>
2026-02-11 20:19:09 -03:00
Shauren 12484c7f5d Core/Misc: Fix build with gcc 12
Signed-off-by: luis <[email protected]>
2026-02-11 20:18:08 -03:00
Shauren a1f8425939 Core/Misc: Fix MovementFlags3 log in MovementInfo::OutDebug
Signed-off-by: luis <[email protected]>
2026-02-11 20:17:43 -03:00
Shauren de506923d0 Core/Transports: Fix transport model rotation
Signed-off-by: luis <[email protected]>
2026-02-11 20:14:07 -03:00
Shauren 7290703c86 Core/Vmaps: Fix mismatched new and delete operators in BIH::build
Signed-off-by: luis <[email protected]>
2026-02-11 20:11:52 -03:00
Shauren 3a2719552f Core/GameObjects: Fix anim kits
Signed-off-by: luis <[email protected]>
2026-02-10 21:47:47 -03:00
Shauren 1f87241f1a Core/Objects: Refactor entity fragment functions to separate global array and move ClearChangesMask there
* Additionally unify argument order for UF::Structure::WriteSomething and Object::BuildValuesSomething

Signed-off-by: luis <[email protected]>
2026-02-07 13:14:33 -03:00
Shauren 0f32a1d35d Core/Players: Fixed spellpower for devourer demon hunters (currently the only intellect based spec without mana)
Signed-off-by: luis <[email protected]>
2026-02-06 14:45:55 -03:00
Shauren 8496186319 Core/Misc: Add devourer demon hunter spec to enum
Signed-off-by: luis <[email protected]>
2026-02-06 14:42:15 -03:00
Shauren f4065e2724 Core/PacketIO: Fix some DifficultyID types in packets
Signed-off-by: luis <[email protected]>
2026-02-06 14:08:04 -03:00
Shauren f5da2170d9 Core/Auras: Corrected aura types and attributes used for absorb value calculation
Signed-off-by: luis <[email protected]>
2026-02-04 21:26:36 -03:00
Shauren b4544efc7d Core/Players: Improve trait config validation
Signed-off-by: luis <[email protected]>
2026-02-04 21:16:43 -03:00
Shauren bcf0f246bd Core/SAI: Remove unused field
Signed-off-by: luis <[email protected]>
2026-02-01 20:47:51 -03:00
Shauren 6c06fb77f4 Core/VMaps: Fixed loading vmap tiles that have destructible buildings on them
Closes #31649

Signed-off-by: luis <[email protected]>
2026-02-01 17:44:22 -03:00
Shauren 3636899681 Core/VMaps: Optimize vmap tile unload
Signed-off-by: luis <[email protected]>
2026-02-01 17:43:45 -03:00
Shauren 441a9ff35f Core/Misc: Update expansions enum
Signed-off-by: luis <[email protected]>
2026-01-31 18:16:49 -03:00
Shauren 1a836a6b8f Remove duplicate include
Signed-off-by: luis <[email protected]>
2026-01-29 17:28:10 -03:00
Shauren d71835475e Core: Updated to 12.0.0
Signed-off-by: luis <[email protected]>
2026-01-29 08:40:48 -03:00
Shauren 0db9ca151c Core/Objects: Implement SetUpdateField
Signed-off-by: luis <[email protected]>
2026-01-25 20:59:13 -03:00