Commit Graph
715 Commits
Author SHA1 Message Date
Kandera cd06bb9377 Core/Spells: fix possible crash from not having any effect and trying to check if immune. fixes non effect spell mechanic checking for spells with both spell mechanics and effect mechanics 2012-05-14 15:24:48 -04:00
Kandera 06e019b722 Core/Entities: move spellproto check to the outside of the forloop to not has crashes 2012-05-14 14:23:21 -04:00
Kandera 548ac10879 Core/Entities: fix calculations for damage taken/done with negative values (should go into effect) and correctly implement SPELL_ATTR6_NO_DONE_PCT_DAMAGE_MODS. small cleanup 2012-05-14 14:11:02 -04:00
Vincent-Michael ede623b473 Core/Spell:
* Fix SPELL_DAMAGE_CLASS_NONE calculation for SpellHealingBonusTaken
* Fix some codestyles
2012-05-13 21:07:59 +02:00
Vincent-Michael e122f9fd30 Core/Spell:
* Fix Nourish heal calculation
* Fix some codestyle
2012-05-13 18:08:57 +02:00
kaelima a1ff27a1c6 Core/Threat: Some corrections to 5709929d2b
Fixes HandleChannelDeathItem (spells such as Drain Soul), which got broken by moving m_deathState = s, thanks Shauren
2012-05-13 17:47:27 +02:00
QAston e5268ba0b5 Merge pull request #6502 from Vincent-Michael/SPELL_DAMAGE_CLASS_NONE
Core/Spell: Fix some problems with spells calculation
2012-05-13 07:52:14 -07:00
Vincent-Michael 79a735fb01 Core/Spell:
* Fix Spells with DmgClass SPELL_DAMAGE_CLASS_NONE
* Fix SPELL_AURA_PERIODIC_HEAL calculation
* Fix Swiftmend heal calculation
* Fix some codestyle
2012-05-13 16:29:01 +02:00
Malcrom 5709929d2b Core/Threat: Fix by faq.
Turning gm on, now drops threat.
Dead mobs no longer holds threat on player.
Also fixed some Engrish.
2012-05-13 11:33:42 -02:30
joschiwald 4e354d6ca9 Core/Spells: fix damage mods from caster on target 2012-05-11 22:43:06 +02:00
Chaplain 469ba0b0e7 Clean up for 58f63509cd
*restore const methods in spellauraeffects
*fix typo in Unit::CalculateMeleeDamage thx bytewarrior
*minor speed up in SpellInfo::GetMaxTicks() thx Warpten
*deleted duble ';;' thx bytewarrior
*speed up in SpellInfo::GetMaxTicks() thx goes to Vincent-Michael
2012-05-10 20:42:07 +03:00
Chaplain 879070bc80 Core/Spells: Separation caster/target part damage/heal bonus calculations.
*Implement HoT/DoT save caster side bonuses and apply target mods on each tick
2012-04-28 23:32:25 +03:00
Shauren 4818c70dcb Core/Spells: Removed unneeded phase check from spell casts, its already done in canSeeOrDetect for spells that need it. Probably more phase checks are not needed either 2012-04-18 22:27:40 +02:00
kaelima 3189b57bf5 Core/Unit: Always initialize a pointer before using it.
(less segfaults, more fun)
2012-04-17 02:14:41 +02:00
Kandera bb97ff7601 Attempt on converting updatewaterstate for use with units (pets and vehicles) 2012-04-16 12:27:06 -04:00
Subv 3d8aaabaf3 Core/Spells: Do not proc spells with PROC_FLAG_DONE_SPELL_MAGIC_DMG_CLASS_(NEG|POS) if there is no target, reimplemented Storm, Earth and Fire talent in another way
Closes #3367
Closes #2424

If you find more spells that are broken because of this, please notify us
Signed-off-by: Subv <[email protected]>
2012-04-14 20:08:16 -05:00
Subv 0d90f7c257 Fixed build from my previous commit 2012-04-14 08:47:44 -05:00
Subv 0ec7016cca Core/Spells: Corrected logic check for SPELL_ATTR4_IGNORE_RESISTANCES
Signed-off-by: Subv <[email protected]>
2012-04-14 08:23:23 -05:00
Subv b9c50a8b6e Core/Spells: Prevent Siphon Life from proccing on Corruption apply.
Closes #6150

Signed-off-by: Subv <[email protected]>
2012-04-13 13:37:32 -05:00
Shauren c055a8617d Scripts/Icecrown Citadel
* Fixed Professor Putricide Tear Gas stunning himself
* Fixed visual of Unstable Experiment
* Fixed oozes not picking new targets after hitting old
* Fixed Gas Cloud not using melee attack
* Removed ooze summon position hack

Closes #4301
Closes #2726
Closes #5119
Closes #4464
Closes #2874
Closes #4407
Closes #2421
Closes #4899
2012-04-13 19:56:00 +02:00
Subv 5466092d23 Core/Spells: Fixed Recklessness charges being dropped twice.
Closes #932
2012-04-13 11:54:36 -05:00
Subv 20a09c5857 Core/Spells: Fixed Lifebloom's final bloom benefit from Empowered Rejuvenation
closes #244
Signed-off-by: Subv <[email protected]>
2012-04-12 05:54:33 -05:00
Shauren da8c7d2344 Core: Fixed warning C4263: 'bool Creature::SetDisableGravity(bool,bool)' : member function does not override any base class virtual member function 2012-04-11 21:30:56 +02:00
Kandera 7cc2c6109a Core/Spells: Fix vigilance taunt cooldown spell targeting. cleanup some whitespace 2012-04-11 10:24:51 -04:00
kaelima 5f52cb0d8c Core/Spell: fix crash from 268401029e 2012-04-09 13:39:52 +02:00
kaelima 49e24e2dfb Core/Cleanup:
Mostly if(.. -> if (.. and for(.. -> for (..
but also some miscellaneous cleanup
2012-04-08 23:59:52 +02:00
Subv 268401029e Core/Spells: Implemented SPELL_ATTR4_IGNORE_RESISTANCES.
Closes #919

Signed-off-by: Subv <[email protected]>
2012-04-08 15:15:06 -05:00
Machiavelli bc96df1aae Core/Shared: Move container functions to shared project under Trinity::Container namespace. Also implement RandomResizeList which takes a predicate function as parameter.
Core/ScriptedAI: Extend SummonList::DoAction to take a predicate function as parameter and allow specifying a maximum number of units to be selected.
2012-04-08 17:40:05 +02:00
Machiavelli e636531da3 Core/Movement: Fix pushback issues and client freeze. 2012-04-08 17:03:44 +02:00
Subv f17b990f68 Core/Spells: Fixed rogue T10 2P and 4P bonuses
Closes #422

Signed-off-by: Subv <[email protected]>
2012-04-07 16:58:56 -05:00
Subv e94a5dd16f Core/Visibility: Pets should be always visible for group mates.
Patch by zarocks
Closes #55
2012-04-07 13:31:53 -05:00
MrSmite b843688fa8 PeAI update
* Better handle target selection for defensive pets. Adds triggers for when owner is damaged or begins attacking something.

* Defensive pets no longer run off as soon as a mob aggros the owner but rather at first damage to owner or owner first attack

* Pets on stay will continue to attack unless target unreachable
2012-04-06 12:26:45 -04:00
Subv 3d6da262dc Core/Spells: Blade Barrier should not proc from autoattacks
Closes #6028

Signed-off-by: Subv <[email protected]>
2012-04-04 20:51:49 -05:00
click ad569ce649 Core: Only clear motionmaster flags if the respective entity exists in world.
Original patch by kewarr and Mrsmite, additional commenting by Machiavelli removing the pet-specific checks applied.
Fixes #5400.
2012-04-01 19:54:33 +02:00
Subv 8bd228179d Core/Spells: Fixed SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT on several types of spell effects
closes #5961
Signed-off-by: Subv <[email protected]>
2012-04-01 11:02:44 -05:00
Gyx 5b7493fc66 Core/Misc: Code style and remove unused define.
Signed-off-by: Gyx <[email protected]>
2012-03-29 14:43:34 +08:00
Gyx 360014856d Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-29 13:42:04 +08:00
Gyx 1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <[email protected]>
2012-03-28 20:00:29 +08:00
Gyx 72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-28 19:11:50 +08:00
kaelima 820f45c424 Core/Protocol:
- Correct and rename response message from creating/updating a ticket
- Prevent some trailing data in CMSG_GMTICKET_CREATE and add comment on stuff missing from its structure.
- Random cleanup
2012-03-28 03:59:03 +02:00
click 13757731b7 Merge pull request #5811 from Elron103/pull-requests3
Core/Units: Fix issues with threat management on phase changes
This is the cleaner version of the two suggested on pull-requests, and handles the threatlist correctly as well.
2012-03-27 07:08:03 -07:00
Kandera da540d5584 Core/Spells: Fix Necrotic Touch proc closes #538 2012-03-26 12:05:27 -04:00
Kandera 7b357a5028 Core/Spells: Fix Misdirection (thx to elron) closes #5869, #4343 2012-03-26 11:37:03 -04:00
kaelima 786c226b74 Core/CombatLog:
- Send more proper hitinfo values in SMSG_ATTACKERSTATEUPDATE (still lot of research todo)
- Some renaming and commenting

- Minor cleanup in Player::UpdateZone
2012-03-26 02:16:19 +02:00
Shocker 48dc9313b9 Core/Misc: Fix logic for owner check in Unit::RemoveGameObject 2012-03-26 02:50:08 +03:00
Elron103 6d9dbefe94 Core/Units: Fix issues with threat management on phase changes 2012-03-20 22:15:11 +01:00
Shauren 568e524c45 Core/Spells: Implemented CREATURE_TYPEFLAGS_PARTY_MEMBER, creature with this type_flag set can be targeted by spells that require target to be in caster's party/raid 2012-03-19 20:44:30 +01:00
Kaelima eff48a42d1 Core/Spell: Fix crash for Glyph of Divinity 2012-03-18 19:57:03 +01:00
Machiavelli 41cc704bf8 Core/Movement:
- Don't abort relocation if movementflag restrictions were violated. There might be lag between client and server and even different parts of the core that made this approach improper.
- MOVEMENTFLAG_ROOT cannot be used in conjunction with MOVEMENTFLAG_MASK_MOVING, but it's a valid flag to receive from client.
- Fix falling to ground when unapplying fly/waterwalk aura. NOTE: This is a client-side initiated fall, in the future this should be initiated and updated by the server. (Working on it)
- Rename MOVEMENTFLAG_FALLING to MOVEMENTFLAG_FALLING_FAR
- Rename MOVEMENTFLAG_JUMPING to MOVEMENTFLAG_FALLING

Closes #5751
2012-03-17 20:36:12 +01:00
w1sht0l1v3 b76c2c144d Core/Unit: Fix respawning after ForceDespawn is called. 2012-03-17 18:26:22 +02:00