Commit Graph
850 Commits
Author SHA1 Message Date
Azazel 6ad4044f05 Core/Mechanics: refactor XP (and in fact, honor/reputation/kill credit) rewarding routine and get rid of copy/pasted code. 2011-03-13 15:28:45 +06:00
Azazel 7200363835 Core/Loading: refactor inventory loading routine and add more informational error logging to it. 2011-03-12 00:54:37 +06:00
Shauren 0aa015d897 Core/Items: Don't allow equipping polearms/staves while offhand is not empty (Titan's Grip) 2011-03-10 23:52:13 +01:00
Shauren 9710c41a40 More warning fixes 2011-03-08 19:11:02 +01:00
Shauren e5347a3bda Core: Fixed warnings:
C4100: 'variable' : unreferenced formal parameter
C4701: potentially uninitialized local variable
C4389: '!=' : signed/unsigned mismatch
C4245: 'argument' : conversion from 'X' to 'Y', signed/unsigned mismatch
2011-03-08 16:42:00 +01:00
Shauren 4bed6b7831 Core/Creatures: Make use of delay parameter for TempSummon case in Creature::DespawnOrUnsummon 2011-03-07 21:25:34 +01:00
Machiavelli 27680e420f Core/Vehicles:
- Remove some wrong checks in vehicle_accessory loading.
- Remove Reset() call from Vehicle::Install() - reset is already called by AI functions
2011-03-07 20:25:55 +01:00
Machiavelli d6ddc6410c Core/Vehicles: Rename vehicle_accessory to vehicle_template_accessory, and implement a new table named vehicle_accessory to allow accessory definitions based on GUID that will overwrite defeinitions based on entry.
Fixes #Nay
2011-03-06 23:45:22 +01:00
Machiavelli 10c02690b6 Core/Units: Re-remove MOVEMENTFLAG_ROOT applying on Unit::SetRooted to fix a clientside freeze issue (our visibility system is co-reponsible). It's still an ugly hack and should be fixed properly asap.
Closes #879
2011-03-06 16:07:01 +01:00
Machiavelli d5be3353f3 Core/TempSummon: Implement ForcedUnsummonDelayEvent. Similar to ForcedDespawnEvent for Creatures, this will unsummon TempSummon objects with specified delay.
Core/Vehicles: Implement ForcedUnsummonDelayEvent for creatures exiting vehicles. Fixes visual bug that showed creatures mounted on vehicle after being ejected.
2011-03-06 15:12:34 +01:00
Shauren 4b4d3e7450 Core/Creatures: Implemented UNIT_FLAG_PASSIVE 2011-03-06 12:22:04 +01:00
Havenard 222df58340 [Core/PacketIO] Fix issues with Mind Control that was allowing a player to keep interfering other players' movements using Mind Vision 2011-03-06 11:23:34 +01:00
Machiavelli 6c4a0354a2 Core/ObjectMgr: Move some npc_spellclick_spells and vehicle_accessory related errors to startup instead of post-startup runtime 2011-03-06 11:12:19 +01:00
Machiavelli df97ce7625 Core/Vehicles: Remove redundant Vehicle::Die. All vehicle auras are already removed on Unit::RemoveAllAurasOnDeath.
Addresses ticket:869 - please reconfirm
2011-03-06 10:31:25 +01:00
Shauren 79e660975e Core/Spells: Fixed Heartpierce proc 2011-03-05 18:48:41 +01:00
Machiavelli a9582964d3 Core/Vehicles: Make the vehicle system more aura driven. Get rid of redundant checks and update relevant data.
Closes #805
2011-03-04 21:17:06 +01:00
Shauren 6c020c72cc Core/SAI: Implemented Gameobject action allowing to send SMSG_GAMEOBJECT_CUSTOM_ANIM with parameter set in param1 2011-03-02 16:50:09 +01:00
leak 709c395421 Core/Groups: Forgotten changes from group id recycling reimplementation, also cleanup queries should be sync (and due to their one time execution have no need to be prepared statements) 2011-03-01 01:42:18 +01:00
click d92fb9ad65 Core: Clean up some rogue whitespace and tabs 2011-02-27 18:34:24 +01:00
Machiavelli da773981f8 Core/Vehicles: Respect seatId in vehicle_accessory 2011-02-27 17:38:20 +01:00
Machiavelli 3c36ff92dc Core/Vehicles: Fix an error log message (missing change from 683cea9e83) 2011-02-27 15:45:28 +01:00
Machiavelli b161b0859b Core/Vehicles: Fix a possible crash in InstallAccessory
Closes ticket #769
2011-02-27 04:05:21 +01:00
Machiavelli 683cea9e83 Core/Vehicles:
- Grab correct npc entry from npc_spellclick_spells in case of player vehicle. Fixes DB errors added in my previous changeset
- Allow aura's with SPELL_AURA_CONTROL_VEHICLE to stack if there are enough free seats, even if spellIds are identical.
- Fix a possible infinite loop. Thanks to manuel for spotting
2011-02-27 03:58:41 +01:00
Machiavelli 3ac80ee3a4 Core/Vehicles: Correct usage of npc_spellclick_spells instead of blatant hacks for vehicle entry.
Note: This may break a few vehicles, but only due to the absence of proper, non-hackish data.
2011-02-26 23:00:09 +01:00
Machiavelli 30738e645f Core/Vehicles&Movement:
- Send correct SMSG_MONSTER_MOVE with newly discovered SPLINEFLAG_EXIT_VEHICLE on vehicle exit. Fixes the "stuck on exit" bug as a result of removing the previous hack in 04b656a44f.
- Use SMSG_SPLINE_MOVE_ROOT and SMSG_SPLINE_MOVE_UNROOT as root packets for creatures.
- Reimplement toggling of MOVEMENTFLAG_ROOT on root event (including enter vehicle)
- Speedup in fetching movementflags for vehicles depending on vehicleflags on object updates.
- Code cleanup and refactoring
2011-02-26 03:47:23 +01:00
Shauren bc94dcfbe4 Core/Spells: Fixed random huge DoT damage ticks
Closes #726
2011-02-25 17:11:02 +01:00
Machiavelli 04b656a44f Core/Vehicles:
- Allow specifying of exit position for Unit::ExitVehicle
- On Vehicle::InstallAccessory, despawn any accessory in the current seat with the same entry with TEMPSUMMON_MANUAL_DESPAWN type
- Remove hacky TELEPORT_ACK packet on vehicle exit
- Remove some redundant packet send operations that were already handled elsewhere
2011-02-25 01:38:21 +01:00
Azazel 20ab3e4bda CharDB Schema/Cleanup: cleanup account_data and character_account_data tables:
* rename column account to accountId;
* introduce prepared statements for both tables.
2011-02-25 00:44:33 +06:00
Machiavelli 2c7ca195d1 Core/Vehicles: Remove a visibility hack on Vehicle::AddPassenger. May fix client crash/freeze issues. 2011-02-23 20:43:12 +01:00
Machiavelli 550f59e05f Core/Vehicles: Do not allow Unit A to enter vehicle of unit B, when unit B is already on vehicle of unit A.
Fixes a core deadlock and stack overflow as well as client crash in the event of improper scripts.
2011-02-23 17:41:33 +01:00
Machiavelli a6da435b84 Core/Vehicles: Also remove MOVEMENTFLAG_ROOT on ExitVehicle (thanks to Anubisss), and slight refactoring of code. 2011-02-23 04:08:11 +01:00
Machiavelli 867f6d3513 Core/Vehicles: Don't add MOVEMENTFLAG_ROOT to movementflags on vehicle enter. 2011-02-23 02:21:08 +01:00
Machiavelli 0a2fc16908 Core/Vehicles: Send SMSG_FORCE_MOVE_UNROOT to client when exiting vehicle with UNIT_FLAG_DISABLE_MOVE 2011-02-23 02:15:48 +01:00
Machiavelli 44fc35bb07 Traditional post-commit buildfix 2011-02-22 23:49:08 +01:00
Machiavelli 918f1ce8ec Core/Vehicles:
- Allow configurable TempSummonType and timer for vehicle_accessory table instead of hard coded values
- Reimplement some earlier charted VehicleSeatFlagsB, that were temporarily removed because of VEHICLE_SEAT_FLAG_UNCONTROLLED (they now work in conjunction with eachother)
2011-02-22 23:47:28 +01:00
leak 09bac61e42 Core/Groups: Move scattered group object deletion to Disband() 2011-02-22 16:52:38 +01:00
darkstalker 1646f9d91c Core/Spell Mechanics: introduce global cooldown manager for server-side checks for GCD (ported from mangos) 2011-02-22 17:02:47 +06:00
Machiavelli 8b738d537c Core/Units: Remove hack that caused units with UNIT_STAT_ON_VEHICLE to absorb any incoming damage. 2011-02-22 01:04:56 +01:00
Azazel 4c8130235e Core/Logs: improve one more debug log entry (for Aokromes) 2011-02-22 01:46:19 +06:00
Machiavelli e07e20ffca Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf. 2011-02-20 20:16:34 +01:00
Shauren 7ac891717c Core/Vehicles: Send proper GUID in SMSG_BREAK_TARGET packet when an unit enters vehicle 2011-02-19 22:50:09 +01:00
Machiavelli c0b29fd0ad Core/Vehicles: Chart VEHICLE_SEAT_FLAG_UNCONTROLLED and implement usage. Concerns vehicleseat enter/exit capabilities. Fixes vehicles related to Malygos encounter.
Original research by rsa, thanks to Manuel for pointing out.
2011-02-19 21:58:50 +01:00
Shauren 0f34df6e1a Scripts/Icecrown Citadel: Added support for weekly quest "Deprogramming" 2011-02-18 19:48:47 +01:00
leak 6a64c79d2a Core/Groups: Group system cleaning sweep. 2011-02-18 18:35:52 +01:00
seirge 8003f75781 Core/Players: Don't remove GCD from category if the respective spell doesn't have GCD-time. Fixes certain exploits related to macro's and wands.
Fixes #10
Fixes #220

Any further issues of the same nature should be reported in different tickets.

Signed-off-by: Machiavelli <[email protected]>
2011-02-17 21:55:15 +01:00
Machiavelli 6618655d04 Core/Vehicles: Let's use proper fractions/percentages 2011-02-17 21:41:09 +01:00
Machiavelli 6ebf672557 Core/Vehicles: Take in account current health percentage of vehichle when recalculating new HP based on vehicle gear scaling. Fixes an exploit that would allow vehicles to reset their HP in a jiffy.
Closes ticket #317
2011-02-17 21:32:38 +01:00
Feanordev 253891bf9f Core/Vehicles: Make vehicles with UNIT_FLAG_DISABLE_MOVE unable to move client side by sending SMSG_FORCE_MOVE_ROOT to area.
Signed-off-by: Machiavelli <[email protected]>
2011-02-17 21:06:38 +01:00
Azazel 4dc1eaa47c Core/Misc: improve error log messages by adding more info. Specially for Aokromes. 2011-02-17 19:47:08 +06:00
leak aaa9b069d9 Core/Entities: Prevent accessing uninitialized memory 2011-02-17 02:04:47 +01:00