Commit Graph
38331 Commits
Author SHA1 Message Date
Giacomo Pozzoni 99ee958e0a Core/Misc: Fix issues reported by static analysis (#25351)
* Core/Misc: Fix issues reported by static analysis

* Core/Vmaps: Code cleanup after e777161888

(cherry picked from commit cfc8f7b442a9dba07b198fcebe2c02ab89cf0a8b)
2022-02-04 12:18:15 +01:00
Shauren fc49ba2f85 Build/Tests: Set all our compile flags on tests
Closes #25349

(cherry picked from commit f8a5783327f5ef5606453bcb9c906ba1297538ff)
2022-02-04 12:08:48 +01:00
offl 6db5ef04c5 DB/Quest: Add correct PrevQuestID & NextQuestID to Dungeon Set 2 quests
Closes #25210

(cherry picked from commit 84bcf4db17ec6f1fab99faca0bde8579d92dc4c8)
2022-02-04 12:08:34 +01:00
Treeston 1303ca0e7e Common/Utilities: Make StringTo<bool>'s signature match that of the other integral types, making for easier templating. Default behavior unchanged.
(cherry picked from commit f54cec4db7c67b623383c140159e1171876ace89)
2022-02-04 12:06:26 +01:00
Maks Szokalski 663ec92794 Scripts: Minor loop refactors (#25325)
(cherry picked from commit dc9e0c1e86efbabb52085b3977ec1258f4fbb986)
2022-02-04 12:06:01 +01:00
kvipka 5a20f14a99 Scripts/InstanceScript: Fix an issue where LoadAllGrids would load creatures before TeamInInstance was properly set (PR #25340)
(cherry picked from commit 5d2780c43c36b0ae1cc4ac2694bf6ec464d079c7)
2022-02-04 12:05:36 +01:00
Shauren 94668343c6 Build: Prevent Catch from messing with user cmake preferences
Closes #25348

(cherry picked from commit 822a1a86d1b504b54a8623b6899b3c23e9486a39)
2022-02-04 11:01:08 +01:00
Shauren bb185a78fb Build: Put tests-extractor_common under correct folder when WITH_SOURCE_TREE is set to hierarchical-folders 2022-02-04 11:01:02 +01:00
Shauren 8484376338 Build: Put tests-common and sfmt under correct folders when WITH_SOURCE_TREE is set to hierarchical-folders
(cherry picked from commit 19f69fcf060c4abba0cd3102529a4203eecac394)
2022-02-04 10:59:00 +01:00
Aokromes af7c211230 Script/Azuremyst_isle: Remove useless log
(cherry picked from commit bf8b34946db51e27a25947316e2d4bb7a58a0e75)
2022-02-04 10:58:44 +01:00
offl 007531407d DB/Misc: Add missing comments to creature_summon_groups
(cherry picked from commit dd3a18ba69bc76d47da0dbbc1c3b33bdd6d9dd6e)
2022-02-04 10:56:43 +01:00
offl 4695910085 DB/Creature: Add CREATURE_FLAG_EXTRA_NO_COMBAT to Flame Breath Trigger (Skadi)
(cherry picked from commit 9d6b5386d6342e4203b9dff38afad43a9b343e26)
2022-02-04 10:56:14 +01:00
Shauren 53563c24c3 Warning fix 2022-02-04 10:04:38 +01:00
Treeston 9f97fdd31a Core/Common: Tokenizer -> Trinity::Tokenize (PR: #25327)
(cherry picked from commit 534a2388b7c662c8796aabb1ec8cb424879799b6)
2022-02-04 00:27:14 +01:00
Treeston 6e45c371c4 Common/Utilities: Properly read std::from_chars documentation and check for out_of_range errors.
(cherry picked from commit 7478c2c65aea853a2086c9c7ecc56c14ad6ee338)
2022-02-04 00:27:14 +01:00
offl 2154251ac7 DB/Creature: Fix reference with Frostweave Cloth for Faceless Lurker
(cherry picked from commit fb227be9eb53581863a45002a3878566b3c1e22c)
2022-02-04 00:27:13 +01:00
Cerveciento bfb8bb4e0b DB/Locale/esES+esMX Texts missing in quests (Part 26)
Closes #25337

(cherry picked from commit 28f3924906dbcb892535d86a3435d059276c470f)
2022-02-04 00:27:13 +01:00
offl 44d6aeba63 DB/Creature: Add gold and mechanic immunities to Converted Hero
(cherry picked from commit 4f4b1aac35883706751836098a902982f09bbfad)
2022-02-04 00:27:13 +01:00
offl 64518d94bf DB/Creature: Impove script of Faceless Lurker and add gold
(cherry picked from commit e8b6fe27f7dd571d7e3cebb6a832be84d8c4f47b)
2022-02-04 00:27:13 +01:00
Treeston be9dadc189 Common/Utilities: Centralize string -> T conversion in StringConvert.h (PR #25335)
(cherry picked from commit cd30e0b86ce6ee88386a91cebdf353fc55805c57)
2022-02-04 00:27:13 +01:00
Treeston 7b88fd607e Core/Warden: Ensure Warden packets do not exceed 512 bytes. This should rectify random Warden timeouts.
(cherry picked from commit 7cc027401e4a2837872db54c835a4ed1a98e4a03)
2022-02-04 00:27:13 +01:00
offl e419d7536a DB/SAI: Add SMART_TARGET_ACTION_INVOKER to SMART_EVENT_FRIENDLY_HEALTH_PCT
Ref cbed1039c47f0e3487cea555bb8552a4e6445f5a

(cherry picked from commit f59d6c1306c2a2e3548ca5a9b48cb60996fab581)
2022-02-04 00:27:13 +01:00
Cerveciento 80cf999f84 DB/Locale/esES+esMX Texts missing in quests (Part 25)
Closes #25333

(cherry picked from commit 9c6cd777b96b84ea6c9fec094f3a326714d1939d)
2022-02-04 00:27:13 +01:00
Cerveciento bcc539421a DB/Locale/esES+esMX Texts missing in quests (Part 24)
Closes #25330

(cherry picked from commit f3f68be662e88e5c5b6f7263da2c770298fb319e)
2022-02-04 00:27:13 +01:00
Giacomo Pozzoni 902ed74c2a Core/SAI: Implement SMART_TARGET_ACTION_INVOKER in SMART_EVENT_FRIENDLY_HEALTH_PCT (#25318)
* Core/SAI: Implement SMART_TARGET_ACTION_INVOKER in SMART_EVENT_FRIENDLY_HEALTH_PCT

* Require radius (5th parameter) to be set

(cherry picked from commit cbed1039c47f0e3487cea555bb8552a4e6445f5a)
2022-02-04 00:27:13 +01:00
offl 71cbe9f318 DB/Quest: Update outro event of quest 'Plagued Lands'
Updates #25313

(cherry picked from commit 3f4bcfbbe1ee919d9de85825c9b7fb4a4944ace9)
2022-02-04 00:27:13 +01:00
Cerveciento ecb5cd5dae DB/Locale/esES+esMX Texts missing in quests (Part 23)
Closes #25319

(cherry picked from commit 1bf8b9452aa4c5bc97af6282cf68a009dac230ab)
2022-02-04 00:27:13 +01:00
Cerveciento 1cc161ec8e DB/Locale/esES+esMX Texts missing in quests (Part 22)
Closes #25306

(cherry picked from commit 8325dfa7d438ebfe6bea7f7bf965f547e7ac9d75)
2022-02-04 00:27:13 +01:00
offl 392f0e9f73 DB/Quest: Fix typo in RewardText of quest 'The Remains of Trey Lightforge'
Closes #25322

(cherry picked from commit 64c1e956a4037af4c11041a7720f753546000387)
2022-02-04 00:27:13 +01:00
Treeston cfcfe71097 Build: Add Clang version guard to CMake (PR #25324)
(cherry picked from commit 27b1930d97d541c241655d8b820cbaebe6eec44e)
2022-02-04 00:27:13 +01:00
Shauren f7ed56f232 Core/Warden: Fix warden timeout ticking twice as fast as it should
(cherry picked from commit ec783fcbb59fcd6e657bc1a39c2b073fd7506ed4)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt 0257cdc8ca Core/ChatCommands: Do not try to consume integral types if the token is empty (PR #25320)
(cherry picked from commit 6079bc7f34250e65efa3dcbe5471382b217ebf24)
2022-02-04 00:27:12 +01:00
jackpoz 1f34964df4 Core/Movement: Fix RandomMovementGenerator for swimming creatures
Fix RandomMovementGenerator for swimming creatures not moving at all due to PATHFIND_FARFROMPOLY being handled as wrong path.
Fixes #25236

(cherry picked from commit 1aceb413495c18e5840112d6ada0c4c71cc03c7b)
2022-02-04 00:27:12 +01:00
jackpoz 0150828841 DB/Misc: Add new view vw_conditions_with_labels that shows labels instead of numbers from conditions table
(cherry picked from commit 7cdc4b46bb6ce63ae3830fb1f8e0464093e1a015)
2022-02-04 00:27:12 +01:00
Treeston 03b5c17863 Common/Utilities: Move EnumUtils' implementation struct from Trinity::Impl to Trinity::Impl::EnumUtilsImpl. This avoids confusing name clashes for other implementations in sub-namespaces of Trinity::Impl.
(cherry picked from commit 91744de3162bab23d7c5a0dd65fc8b4249eb803a)
2022-02-04 00:27:12 +01:00
jackpoz 27405870e0 DB/Misc: Add new view vw_disables_with_labels that shows labels instead of numbers from disables table
(cherry picked from commit 6d295629cf01cc23e9c6c521c767a4fa6fd0eb41)
2022-02-04 00:27:12 +01:00
Treeston 0473beff2b Core/Misc: std::string -> std::string_view in a bunch of places, notably chat commands and Util.h
(cherry picked from commit a41bbd9ad9adedb15c7133bdef1575a6ec0eb1ab)
2022-02-04 00:27:12 +01:00
robinsch 5ba95cb42f Core/Unit: Fixed race condition when loot recipient is in different map (#25312)
(cherry picked from commit aaa089ab7f634b50acfabb5ad312edd5ee82d2e2)
2022-02-04 00:27:12 +01:00
jackpoz 1f2c48f8bb Core/SAI: Remove completed timed action lists even while evading
Fixes #25294

(cherry picked from commit 03eb0886a8b0e192d3c299d72ef223d30495c534)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt 1a6564f42f Scripts/Commands: Convert argument parsing of some misc commands to new system (#25308)
* Core/Shared: Make WeatherType smart

* Scripts/Commands: Convert argument parsing of some misc commands to new system

(cherry picked from commit 5bab0e43c627c949bb5fb1d7fd014855c6c02b8e)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt 53b28572bf Scripts/Commands: Convert argument parsing of cast commands to new system (#25309)
(cherry picked from commit cefac75a7d17ea3263f24b6e0fb63c11f92a04ac)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt 582b8458ea Scripts/Commands: Fix two unreachable code issues found by PVS-studio (#25311)
(cherry picked from commit 3262ef447a9c41bef9a9a3d11f5a89a63137c4df)
2022-02-04 00:27:12 +01:00
offl fc2f582d4f DB/Quest: Convert & update support for 'Ebon Blade Prisoners' to SAI
Closes #24672

(cherry picked from commit 6611b7145746d5bc18541f7f3a4b641739877740)
2022-02-04 00:27:12 +01:00
offl 192b98e544 DB/Quest: Convert & update support for Borean Tundra escort quests to SAI
Closes #25001

(cherry picked from commit 040fda87ef0a7a2c7a61dc2fdc3c478c5adf3dd6)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt 5675d62159 Scripts/Commands: Convert argument parsing of message commands to new system (#25305)
(cherry picked from commit f17b9b20f10ed8e14cdddef395ff467053068d35)
2022-02-04 00:27:11 +01:00
Peter Keresztes Schmidt b527a031b9 Core/ChatCommands: Add std::wstring argument type (#25302)
(cherry picked from commit 617a769d6f8dc51d049296fbccca724713916ed4)
2022-02-04 00:27:11 +01:00
Peter Keresztes Schmidt e9209c3131 Scripts/Commands: Convert argument parsing of most list commands to new system (#25303)
(cherry picked from commit 522a4cb1a66539a656c44342d7652c3065a90588)
2022-02-04 00:27:11 +01:00
offl a915b42f89 DB/SAI: Update some scripts using CMC cast flag
(cherry picked from commit d714adbc4fbfdc2825d12105419cf52943fe1042)
2022-02-04 00:27:11 +01:00
offl 1f1583142e DB/SAI: Remove SMARTCAST_INTERRUPT_PREVIOUS from Invoker Cast, Cross Cast and Self Cast actions
Ref aae38bec116d5fb60d1f5900867cfe33388ed0bb

Not needed at all for these action types, you can't interrupt player's spells by this event flag and there's no reason to interrupt creature's spells

(cherry picked from commit e931bc11c25ce26074896115d45ee7f4d77e5071)
2022-02-04 00:27:11 +01:00
offl 0715168bce DB/SAI: Make Bonestripper Buzzard & Vulture move to invoker rather than random creature
Ref #20821

(cherry picked from commit 07acb1d4397f5f1ebd3c9b62e420b3955e73fbe8)
2022-02-04 00:27:11 +01:00