Commit Graph
100 Commits
Author SHA1 Message Date
jackpoz 91153e8b64 CI/CircleCI: Try to avoid timeout when checking sql updates 2021-07-04 11:48:23 +02:00
jackpoz 0f26daafbf GitHub: Update link to create new issues 2021-07-04 11:43:02 +02:00
jackpoz ed43294e2d GitHub: Restore old issue template as backup/fallback 2021-07-04 11:40:35 +02:00
Giacomo Pozzoni 142306e883 CI/GitHub: Add issue form for SQL fixes (#26651) 2021-07-03 22:13:14 +02:00
Giacomo Pozzoni 24636e5627 CI/GitHub: Use issue form and add contact links (#26639) 2021-06-30 18:58:57 +02:00
jackpoz cb0672081e Core/Player: Add some asserts
Assert PlayerInfo for race/class pair in a few Player functions

(cherry picked from commit 3576a38f6c107d6b17795d84fcb4f87809917299)
2021-06-19 23:33:38 +02:00
jackpoz e63c5f7b0c Scripting/Obsidian Sanctum: Fix crash
Fix crash caused by calling Reset() in constructor (which is not allowed)

(cherry picked from commit 5aba5c7afff4289b6b90311f66e6939791b89ee4)
2021-06-19 23:33:38 +02:00
jackpoz 66f7e57990 Shared/Database: Improve dead-lock error handling
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times

(cherry picked from commit 54b0b8f5ead41f936b12e97d1b4fbacd9b89ab53)
2021-06-19 23:33:38 +02:00
jackpoz b9159407e0 Core/AI: Fix assertion triggered with PetAI derived scripts (#21254)
* Core/AI: Fix assertion triggered with PetAI derived scripts

Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.

(cherry picked from commit 95a76a83fcbad0e52c6013697544e3c5691e7e24)
2021-06-19 23:33:21 +02:00
jackpoz 5b4f61d915 Core/Crash reporting: Add support to char* arrays
Add support to char* array showing the string value instead of the pointer address

(cherry picked from commit 4c0c4ab271ddc2d200cd9ccda98e16553dcaf391)
2021-04-16 21:03:23 +02:00
jackpoz 4f643e3f32 Core/Misc: Removed unneeded checks
(cherry picked from commit 513e153a135ab51941fafe452aaa4e91faa285a0)
2021-04-16 20:53:41 +02:00
jackpoz 8244d60859 Core/Misc: Fix static analysis issues
(cherry picked from commit ad56299846a92c2cda84ebcc2d37d9aa6e3e8024)
2021-04-15 05:53:27 +02:00
jackpoz 0a528a525b Scripts/Trial of Crusader: Fix static analysis issues
(cherry picked from commit cbc7642edd4a45068636adb98d74332837ab4c71)
2021-04-15 05:53:27 +02:00
jackpoz 6a1f39863f Core/CreatureAI: Disable PetAI from database
(cherry picked from commit 2c7e921cdc14527bd99d6976793e69999f262f9d)
2021-04-15 05:53:27 +02:00
jackpoz e17e4e6f07 Core/Misc: Replace time(NULL) with GameTime::GetGameTime()
(cherry picked from commit 12701cb0c6c45eb105ad449eb9a56e76d84d691e)

 Conflicts:
	src/server/game/Achievements/AchievementMgr.cpp
	src/server/game/AuctionHouse/AuctionHouseMgr.cpp
	src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
	src/server/game/AuctionHouseBot/AuctionHouseBotSeller.cpp
	src/server/game/Battlefield/Battlefield.cpp
	src/server/game/Battlefield/Zones/BattlefieldWG.cpp
	src/server/game/Battlegrounds/BattlegroundMgr.cpp
	src/server/game/Calendar/CalendarMgr.h
	src/server/game/DungeonFinding/LFGQueue.cpp
	src/server/game/Entities/Corpse/Corpse.cpp
	src/server/game/Entities/Creature/Creature.cpp
	src/server/game/Entities/Item/Item.cpp
	src/server/game/Entities/Pet/Pet.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Unit/Unit.cpp
	src/server/game/Globals/ObjectMgr.cpp
	src/server/game/Grids/ObjectGridLoader.cpp
	src/server/game/Guilds/Guild.cpp
	src/server/game/Handlers/AuctionHouseHandler.cpp
	src/server/game/Handlers/BattlefieldHandler.cpp
	src/server/game/Handlers/CalendarHandler.cpp
	src/server/game/Handlers/CharacterHandler.cpp
	src/server/game/Handlers/ChatHandler.cpp
	src/server/game/Handlers/LFGHandler.cpp
	src/server/game/Handlers/MailHandler.cpp
	src/server/game/Handlers/MiscHandler.cpp
	src/server/game/Handlers/MovementHandler.cpp
	src/server/game/Handlers/PetHandler.cpp
	src/server/game/Handlers/QueryHandler.cpp
	src/server/game/Handlers/TicketHandler.cpp
	src/server/game/Instances/InstanceSaveMgr.cpp
	src/server/game/Server/WorldSession.cpp
	src/server/game/Server/WorldSocket.cpp
	src/server/game/Spells/Auras/SpellAuras.cpp
	src/server/game/Tickets/TicketMgr.cpp
	src/server/game/Tickets/TicketMgr.h
	src/server/game/World/World.cpp
	src/server/scripts/Commands/cs_gobject.cpp
	src/server/scripts/Commands/cs_instance.cpp
	src/server/scripts/Commands/cs_list.cpp
	src/server/scripts/Northrend/zone_wintergrasp.cpp
	src/server/scripts/Spells/spell_item.cpp
2021-04-15 05:53:27 +02:00
jackpoz bddd58d469 Scripts/Stratholme: Add missing header for no-pch build
(cherry picked from commit 9a515c29bab2dadec011f40e4f824bd9409528d4)
2021-04-15 05:53:27 +02:00
jackpoz cf04609c9a Scripts/Stratholme: Fix build
(cherry picked from commit 828c5d08e758385519955201b909a0d9a578715d)
2021-04-15 05:53:27 +02:00
jackpoz b99654924c Scripts/Stratholme: Fix build
(cherry picked from commit a98b2aa8c8cfe9e06cf00b7d37abf06f06aee67b)
2021-04-15 05:53:27 +02:00
jackpoz 8313053a3b Shared/Metric: Fix crash on shutdown
Fix crash on shutdown with metrics enabled but InfluxDB stopping before worldserver

(cherry picked from commit 45b2bcfaf266cac74806ed71f32b8dc02cd2321e)
2021-03-15 20:17:31 +01:00
jackpoz 2364aa59d8 Core/Spells: Fixed Naxx Anub Scarab Summoning Spell
Reduce spell radius of 28864 and 29105 from 100 yards to 10 yards to spawn scarabs closer

(cherry picked from commit 72e97d330bd4d696255eee7046a27a9f8b3d6ae1)
2021-03-15 20:17:31 +01:00
jackpoz 55931b0d92 Core/SmartScripts: Code cleanup
(cherry picked from commit f555a67bf850e1a9659c89551d7bb69cc812f161)
2021-03-04 18:17:08 +01:00
jackpoz a01d397c3d Core/Misc: Fix static analysis issues
Fix static analysis issues reported by 3rd party tools

(cherry picked from commit 24e82fe83d384e3a4cf17719e728760053516607)
2021-02-25 18:50:55 +01:00
jackpoz 668a3ad643 Core/Misc: Fix static analysis issues
Fix coverity id 1382860

(cherry picked from commit 19e99478a70515660615fa8c9d27c7b9581d3098)
2021-02-25 18:50:55 +01:00
jackpoz 246871e3d5 Shared/Metric: Stop metrics on shutdown
Properly stop metric information gathering and sending on shutdown.
Issue reported by AddressSanitizer.

(cherry picked from commit e9c475d45f7fbe78d68e8d0cafe66b829acb6ce6)
2021-02-25 18:50:55 +01:00
jackpoz 96406e3408 Core/Crash reporting: Fix buffer overflow
(cherry picked from commit c7043b25f659eddd75fecd916235e524223c7f05)
2021-02-25 18:50:55 +01:00
jackpoz 7cb6c17df4 Core/CreatureAI: Disable TotemAI from database
Disable TotemAI set in creature_template, triggering an assert when spawning the creature

(cherry picked from commit 072c884ed86a9bf895cd5f53b0f6480ae14c3059)
2021-02-25 18:50:55 +01:00
jackpoz f1388f37b6 Core/WorldSession: Fix idle WorldSessions getting kicked twice as fast as supposed
Fix SocketTimeOutTime and SocketTimeOutTimeActive settings being effectively halved by reducing the timeout time twice every update instead of just once, causing much faster kicks (i.e. after 30 seconds with 60 seconds set in the configs).

(cherry picked from commit 032194099e84bf0d47b121d82170c39fe73e0c87)
2021-02-25 18:50:55 +01:00
jackpoz e9e59e0861 Dep/Jemalloc: Enable MADV_FREE if available
(cherry picked from commit 10ad43916fb67eaf59c5a676c83b36ec8506beec)
2021-02-25 18:50:55 +01:00
jackpoz ba953eb6ac Dep/Jemalloc: Temporarily disable MADV_FREE
Temporarily disable MADV_FREE until CMake file is modified to check if MADV_FREE is available on the current system.
This fixes the build on older systems.

(cherry picked from commit 0f6feb828baf17522a001eddb51495f5ad397444)
2021-02-25 18:50:55 +01:00
jackpoz 08ac99744b Core/Maps: Fix memory leak in BoundaryUnionBoundary
Add missing destructor in BoundaryUnionBoundary to avoid reporting a memory leak (even if it's used only in a global variable)

(cherry picked from commit 724499cf9c6b2027d130d6a8a505413c7da6cb3e)
2021-02-15 19:13:25 +01:00
jackpoz 65f4666063 Dep/Jemalloc: Update to Jemalloc 5.0.1
(cherry picked from commit 92cd9bd70db460fdce4af0596cf9d8ee3c3abad5)
2021-02-15 19:13:25 +01:00
jackpoz 367e9f210e Dep/Jemalloc: Update to Jemalloc 4.0.4
(cherry picked from commit cc6dec72863a771da0c0f3ab3d32f75d7ce863bd)
2021-02-15 19:13:25 +01:00
jackpoz 875c5bcade Tools/MMaps: Improve MMaps quality
Lower Detail Sample Distance and Detail Sample Max Error to get more accurate MMap data, in particular mmap height.
More info about Detail Mesh at http://digestingduck.blogspot.it/2009_07_01_archive.html and http://digestingduck.blogspot.it/2009_08_01_archive.html

(cherry picked from commit f8fd0b7a2c0a9acd084f011c614d529e49397479)
2021-02-15 19:13:25 +01:00
jackpoz 159aa97d72 Dep/Recast: Update recastnavigation to https://github.com/recastnavigation/recastnavigation/commit/2c85309280dbc9c82029e7ab16dfb01b9235c74e
(cherry picked from commit 7ef22e43057080926685eb45f0fce3f2f3d58c61)
2021-02-15 19:13:25 +01:00
jackpoz 94a8be619e Tools/VMaps: Fix build issue on VS2017
(cherry picked from commit 64ca4717349fe3e418f1abe377f81be77818977c)
2021-02-15 19:13:25 +01:00
jackpoz f5dcff32cb Core/Misc: Fix static analysis issues
(cherry picked from commit 06ea65b0e651be2b389800b5acf9a5e8b86d7444)
2021-02-06 21:41:51 +01:00
jackpoz 852c9e9108 Core/Misc: Fix static analysis issues
(cherry picked from commit a80c95a1c788932696fb43e69b9012a751431bac)
2021-02-06 21:41:51 +01:00
jackpoz 388034498f Core/Misc: Fix static analysis issues
(cherry picked from commit 9b7c73a19df66849ec829fc5a94875aa9593934d)
2021-02-06 21:41:51 +01:00
jackpoz 1c24819741 Core/Misc: Fix static analysis issues
(cherry picked from commit 97f33dc77945d8f284d14e0eaa994ae1405a3f20)
2021-02-06 21:41:51 +01:00
jackpoz a68ab3241a Core/Misc: Fix static analysis issues
(cherry picked from commit 7e73f5f1edd8c99c3639e2a342cf044f6192fb6a)
2021-02-06 21:41:51 +01:00
jackpoz c44478664a Dep/G3D: Add static assert checks for Array functions being used with non-POD types
(cherry picked from commit f017b1d470aec0ca4918e059343d57de99fb2254)
2021-02-06 21:41:51 +01:00
jackpoz d8804418ce Core/SAI: Fix static analysis issue
Initialize uninitialized value, move class field from public to private.

(cherry picked from commit 7dc97c035350f9505a9fba0b8ec2d2037044e586)
2021-01-13 22:04:52 +01:00
jackpoz 89cfced1b5 CI/GitHub: Apply branch label to PRs when they are opened
Apply branch label to PRs when they are opened instead of having a cron job that runs every 5 minutes. This uses the "new" github action type "pull_request_target"
2020-12-26 14:02:14 +01:00
jackpoz bf5be28396 Core/Misc: Fix static analysis issues
Fix various coverity reported issues

(cherry picked from commit 925557d1c097cd45311b38dc3a9c715579456980)
2020-08-21 23:13:13 +02:00
jackpoz 32832fa9cb Core/Misc: Fix static analysis issues
(cherry picked from commit 832a114196c7e9405d0569eac1d44de6c7dd83dc)
2020-08-19 00:21:48 +02:00
jackpoz 77e6355fba Core/Misc: Fix static analysis issues
(cherry picked from commit 9cf4dd7345b7f05db834fd48a9f0a135f1884d70)
2020-08-19 00:14:06 +02:00
jackpoz 76bd0adaa4 Core/Misc: Fix static analysis issues
(cherry picked from commit 41f4a80f3097b41d19592bcbe99b9a8444eacb19)
2020-08-18 19:46:12 +02:00
jackpoz 31654a2295 Core/Misc: Fix static analysis issues
(cherry picked from commit b2a341df6efc099c35b436e1ec8eedd1632433d7)
2020-08-18 19:42:54 +02:00
jackpoz a3dbf4b088 Core/Scripts: Simplify code
Partially revert 753e7074d84b5a2e8d3c3e92d25c54bb25ba477e and 12c680f9b1f1068099c3b19443d93d456690ac56 to simplify the code and to only remove GMs from the target list.

(cherry picked from commit f9cfc202e90ded24fe0dcf5d06035d2aab2cf6af)
2020-07-16 22:00:28 +02:00
jackpoz eccc015ce7 CI/GitHub: Execute issue-labeler.yml action only on TC repo 2020-06-26 22:56:10 +02:00
jackpoz c3a7a604f4 Build/CMake: Increase minimum version to 3.8
(cherry picked from commit 965ac6fb08623b13c2486f9d09967dd00f3d396f)
2020-06-16 09:29:31 +02:00
Giacomo Pozzoni 0f390606a1 Build/CMake: Set some policies to NEW (#23779)
* Build/CMake: Set CMP0005 to NEW

See https://cmake.org/cmake/help/v3.2/policy/CMP0005.html

* Build/CMake: Set CMP0043 to NEW

See https://cmake.org/cmake/help/v3.2/policy/CMP0043.html

* Build/CMake: Set CMP0074 to NEW

See https://cmake.org/cmake/help/v3.12/policy/CMP0074.html

(cherry picked from commit 18cc36bc67023dc9ca58e77733c2b8c74655cf86)
2020-06-16 09:29:31 +02:00
jackpoz ebb6f12db8 CI/GitHub: Add another Pull Request labeler as cron job 2020-05-23 23:22:54 +02:00
jackpoz 59e8b98bef CI/GitHub: Remove PR GitHub Action because of current limitations
GitHub Actions triggered when creating a Pull Request receive a read-only token that makes them useless when trying to do anything on GitHub.
Useful links:
- https://github.com/actions/first-interaction/issues/10
- https://github.com/actions/labeler/issues/12
- https://github.com/actions/labeler#pull-request-labeler
2020-05-23 18:43:28 +02:00
jackpoz 58013167de CI/GitHub: Rename jobs 2020-05-23 17:56:59 +02:00
jackpoz 0435ecc8f5 CI/GitHub: Fix github actions syntax 2020-05-22 13:28:57 +02:00
Giacomo Pozzoni 7c68eb0e70 CI/GitHub: Fix github actions syntax 2020-05-22 13:26:46 +02:00
jackpoz 92a289e455 CI/GitHub: Add action to label pull requests 2020-05-21 16:43:42 +02:00
jackpoz ce10a9482a CI/GitHub: Add action to label issues 2020-05-17 18:57:51 +02:00
jackpoz d3782c2d09 Core/Misc: Add console option to update databases only
Add "--update-databases-only" console argument to stop worldserver execution after having updated all databases (if specified in config file)

(cherry picked from commit 92bf5b1ba795303808c5f1b3bf82dd0204133ed8)
2020-05-13 21:06:33 +02:00
jackpoz 49f25f6e33 Core/Misc: Fix static analysis issues
(cherry picked from commit 486b03234304526d8f7d66ff0d99ea3de975745e)
2020-04-28 13:47:58 +02:00
jackpoz 6611211d31 Core/Misc: Fix static analysis issues
(cherry picked from commit 65aeeafad385cca7d836272c37ee6f4d180d2842)
2020-04-28 13:43:40 +02:00
jackpoz c31f875cc8 Core/Misc: Fix static analysis issues
(cherry picked from commit 3c4c67160afbe15cc48e5390201157c416cb9a09)
2020-04-27 12:25:52 +02:00
jackpoz 70c2b4e5ba Scripts/GruulsLair: Fix indentation
(cherry picked from commit 9d77b2be3b72810db1f12b6fde5e39583d521bc9)
2020-04-26 00:51:55 +02:00
Giacomo Pozzoni 60b338881d Core/Grid: Code cleanup
Remove unused method that should not be used anyway
2020-04-24 19:40:26 +02:00
jackpoz bfcb276781 Core/Crash: Refactor and fixes
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.

(cherry picked from commit 9226e212053ef8ec10eeb9509f2ce6ec002d8e3b)
2020-04-24 17:18:48 +02:00
Giacomo Pozzoni 77154e0c03 Require Visual Studio 2019 16.4 or greater (#24214)
* CI/AppVeyor: Add appveyor.yml file

* Build: Require Visual Studio 2019 16.4 or greater

* CI/AppVeyor: Upgrade to VS2019 image

* Update cmake error message

* CI/AppVeyor: Fix appveyor VS 2019 configuration

(cherry picked from commit 1df52da0b052654a9b42339fdd22028bfdbf9fc0)
2020-04-04 18:35:58 +02:00
Giacomo Pozzoni 642dd62cc7 Core/Misc: Fix build warning
(cherry picked from commit 2803269e8cbc8dcb462425db109b67facdf71715)
2020-03-30 17:04:27 +02:00
jackpoz 6f1b13e5c4 Core/Misc: Fix static analysis issues
(cherrypicked from 8f2bcd79da39ef9448938842de32b6f8572facdf)
2019-08-17 20:04:14 +02:00
jackpoz 154f9a03e7 Core/Misc: Fix static analysis issues
(cherrypicked from 69400719948fc32b3802a0ff6834b6261e4a0754)
2019-08-17 20:04:14 +02:00
jackpoz 9780d23f47 Core/Misc: Fix static analysis issues
(cherrypicked from b375bab22592daaaa1fc387c4f6a1fb9564cbcc6)
2019-08-17 20:04:14 +02:00
jackpoz 5b78f19879 Core/Misc: Fix static analysis issues
(cherrypicked from 865a3a47eaa518cb9c7827e863d679697e38b03e)
2019-07-21 21:06:54 +02:00
Giacomo Pozzoni 2f140693e8 Shared/Misc: Use C99 conformant snprintf and vsnprintf in Visual Studio (#22876)
(cherry picked from commit 166bb311635bd68da09960987177972608b84396)
2018-12-31 14:27:05 +01:00
jackpoz 8488150dee Core/DBUpdater: Code cleanup 2018-12-30 18:10:11 +01:00
jackpoz d2b77ca075 Core/DBUpdater: Fix error message
Fix error message when trying to populate the database showing free'd memory data instead of the sql file name
2018-12-30 18:10:06 +01:00
jackpoz 1fed5d571a Scripts/Azjol-Nerub: fix static analysis issues
(cherry picked from commit 2edfedc2b60367a888e8819d91474261e66e989d)
2017-09-05 11:21:19 +02:00
jackpoz fc6b488620 Core/Misc: Fix static analysis issues
# Conflicts:
#	src/server/game/Battlegrounds/Zones/BattlegroundEY.cpp
#	src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/scripts/Commands/cs_ban.cpp
#	src/server/scripts/Commands/cs_disable.cpp
2017-07-16 21:14:22 +02:00
jackpoz 74e4f73fcb Core/Misc: Fix static analysis issues
(cherry picked from commit 7d3291e8044841b085ca5b0987bdf25269881863)

# Conflicts:
#	src/server/scripts/Outland/TempestKeep/Eye/boss_kaelthas.cpp
2017-07-16 20:50:43 +02:00
jackpoz 9d09307e34 Scripts/ICC: Fix chest loot exploit
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.

(cherry picked from commit c4865fe63ee4bb9d401d09cb9543acaf9c853b56)

# Conflicts:
#	src/server/game/Entities/GameObject/GameObject.cpp
2017-03-03 22:31:28 +01:00
jackpoz 3cd6e1dd82 Core/Loot: Fix group loot if player loot recipient disconnects
Fixes #13300

(cherry picked from commit 38f8a03781d98388408f7d4d9f906c311d21bdcc)
2017-02-18 17:21:00 +01:00
jackpoz 143f0c0e4d Core/Misc: Fix static analysis issues
(cherry picked from commit b7306f06f56ea3d7ee1803d7421dcf850878ac80)

# Conflicts:
#	src/server/game/Entities/Unit/StatSystem.cpp
2017-02-18 14:30:23 +01:00
jackpoz 7616f22bfb Core/Commands: Code cleanup
Remove commented out code

(cherry picked from commit eb9bf314c45a236f71a05814b2ef825c326eab83)
2017-02-12 16:27:58 +01:00
jackpoz 238072e67a Core/Battleground: Fix crash happening when reporting afk a nonexistent player
(cherry picked from commit f67d1158d108b82e0b399c8acac3f4dd06f24d67)
2017-02-12 16:27:01 +01:00
jackpoz e5ba8f1e4d Core/MMAPs: Update recast
Update recast to https://github.com/recastnavigation/recastnavigation/commit/64385e9ed0822427bca5814d03a3f4c4d7a6db9f

(cherry picked from commit 1d7013e0e2758b1468a488dd17e3f5c5ce5f265d)

# Conflicts:
#	dep/PackageList.txt
2017-02-12 15:41:19 +01:00
jackpoz f98e3b0ee5 Tools/MMapGenerator: Avoid saving uninitialized padding bytes to disk
Initialize padding bytes in MmapTileHeader struct to avoid saving uninitialized data to disk, causing issues when binary-comparing *.mmtile files.

(cherry picked from commit 2585c62e6fc8925bb74160fb9b24fb1d361a8b2c)
2017-02-12 15:39:38 +01:00
jackpoz a3384bdc70 Scripts/Commands: Change "server shutdown" behavior
Change "server shutdown 0" behavior to delay the shutdown by the force threshold specified in configs if there are still players connected, set to 30 by default

(cherry picked from commit b37c7101de272d1b3d599f26d6b5077cfacfb121)
2017-02-11 22:02:08 +01:00
jackpoz 6367be09fa Scripts/Commands: Change "server shutdown" behavior
Change "server shutdown" behavior to always include [force] optional parameter when issued from local or remote console.

(cherry picked from commit 884736b3b279737c44b0954ca3fe0f193085fbb3)
2017-02-11 21:43:03 +01:00
jackpoz af11f48356 Core/Group: Do not allow a player to invite himself
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix #17664

(cherry picked from commit bcfa47c0514b51690a5dd222b3b1ac5f20379232)
2017-02-11 21:37:40 +01:00
jackpoz 2355facafe Core/Creature: Fix assertion triggered
Fix assertion triggered when a Creature was summoned at an invalid position with Auras loaded as Creature addons.
Fix #17415

(cherry picked from commit 75319e4a6887f23562ac141e4494427793962b00)
2017-02-01 22:53:21 +01:00
jackpoz 98d16d82be Core/Player: Fix duel edge case crash
Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.

(cherry picked from commit 7ff0f3c65fd0c068560351eac92e96a8527c96a7)
2017-01-12 03:13:55 +01:00
jackpoz 954b3c9617 Core/VMaps: Fix some vmap height edge cases
Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.

(cherry picked from commit 1347d7cf7a8656f3db9d8b2f6e6d955e1fa8c129)
2017-01-12 00:13:55 +01:00
jackpoz f23c6c4d7e Shared/Metric: Initial support for tag value escaping
Fix #18175

(cherry picked from commit 189edc0f23a2935747eb5eb3555607f4edc15480)
2016-11-14 20:33:03 +01:00
jackpoz a59fef4bff Dep/G3D: Backport warning fix from G3D10
(cherry picked from commit bf5c37a5d056485fc256aa7f128f81eeb125a992)
2016-10-11 14:16:30 +02:00
jackpoz 40b67bb7ce Core/Packets: Remove empty file 2016-08-12 18:17:01 +02:00
jackpoz fe03c9a45e Core/Accounts: Reduce differences between 3.3.5 and 6.x branches
Add code missing from d8234bed42
2016-08-10 18:40:37 +02:00
jackpoz 555ac389e2 Server/Database: Reduce differences between 3.3.5 and 6.x branches
Code functionality shouldn't have been modified.
2016-08-10 17:06:16 +02:00
jackpoz d44c605f6d Server/Database: Reduce differences between 3.3.5 and 6.x branches
Code functionality shouldn't have been modified.
2016-08-08 18:46:38 +02:00
jackpoz 6d866102de Common/Utilities: Reduce differences between 3.3.5 and 6.x branches
Code functionality shouldn't have been modified.
2016-08-06 16:27:10 +02:00
jackpoz fe6d8016af Common/Logging: Reduce differences between 3.3.5 and 6.x branches
Code functionality shouldn't have been modified.
2016-08-04 21:54:02 +02:00
jackpoz bceb385773 Core/Crash reporting: Better handle max nesting level setting
Fix wheaty exception report counting reference symbols as 2 nesting levels, not logging child objects in some cases, i.e. spell id in SpellEvent crash.

(cherry picked from commit 284dd6b80d79f5691c82eda848c7474c5b87cfd9)
2016-08-04 17:05:24 +02:00