Change an assert to a NULL check on Flame Leviathan vehicle kit, it can be NULL on map unload.
Close#16662
(cherry picked from commit 31cd082833926539c56569ff6faabc139f5f3223)
Core/GameObjects: Fixed an issue where traps were not redirected to Grounding Totem
(cherry picked from commit 2a50ea5cf14e16ee0dda09f3c9090d5541b39b2d)
Core/Player: Fix profession specialization being re-learnt on login after unlearning it
(cherry picked from commit 1c89b4dcdfa0e25aee28245513b1cf464e3d9e7b)
Conflicts:
src/server/game/Entities/Player/Player.cpp
Fix assertion triggered when entering a vehicle while channelling a shared vision spell.
Fix#15953
(cherry picked from commit 2cb54d5606109305194ed3cdb1b56ca62317b891)
# Conflicts:
# src/server/game/Entities/Player/Player.cpp
Add Unit::KillSelf() function as overload of Unit::Kill(this) . Use KillSelf() whenever the killer and the victim are the same to clearly state the Unit is going to kill itself.
(cherry picked from commit 3267c90102068ed88c0bd7146ae747fe8ba44771)
# Conflicts:
# src/server/game/AI/SmartScripts/SmartScript.cpp
Core/Scripts: Remove deprecated script npc_anchorite_truuen
Remove deprecated script npc_anchorite_truuen replaced by SAI in 2cecc7b1f7b846d24f25e0f5acb957c4c4b4484d
(cherry picked from commit 9020790db22d96dca05e8f6581c9cf80727f14b4)
Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.
(cherry picked from commit 5f917e2286809d7aafa8871be38042ae7966c26b)
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close#15900
(cherry picked from commit 6e296ddaa20a51327f7666f6ddaac60e4216ee23)
Adjust more packet throttling values by increasing some limits, this might fix some random kicks.
Close#14659
(cherry picked from commit 5bd7c295c0b0f2cb78345ed02dd37531a67348f5)
Fix a crash happening when using items casting spells like Item ID 37198
Fix#14900
(cherry picked from commit 166e66cc06d418b94e14abb30dea6a76ba9edce2)
Fix queuing in LFG with 5-men groups leaving the party in queue forever, caused by group GUID being added to list of party members.
(cherry picked from commit 42a71133fa32a1414dc52241c99430178b24422e)
Conflicts:
src/server/game/DungeonFinding/LFGQueue.cpp
Add an optional parameter "escapeCharacters" to ChatHandler::SendSysMessage() to properly escape | character, otherwise it might freeze the client.
(cherry picked from commit 7c91984a64c2f78ad17153018a42926dfcf0ae59)
Fix LFG queue issues by removing disconnected players from LFG queue and their party with them.
(cherry picked from commit b7f9836d223925802115f45ad2c2c7eeb9bb00a4)
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.
(cherry picked from commit 2f92a2f58e171bbfa6dc06d3b2663cbf384a7d38)
Conflicts:
src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet(), IsTotem(), IsSummon(), IsGuardian(), IsHunterPet() and IsVehicle() from Creature to Unit
(cherry picked from commit ea4d9c0d9e3339c96b94f13bbbfc1318bb6b03f9)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Unit/Unit.cpp
src/server/scripts/Spells/spell_pet.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet() from Creature to Unit
(cherry picked from commit d243630acff017f5e50bf0c833a0bbac35ba6c5a)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Spells/Spell.cpp
src/server/game/Spells/SpellEffects.cpp
Fix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj
(cherry picked from commit 5f0f152345ec7e9cc6195ba8f59f316a1cad90f7)
The log is triggered when a mage creates a portal to another map, uses it and then the portal despawns.
(cherry picked from commit a8ceb18cdfe850fbb84ddd3d917565f2a100ebb7)
Conflicts:
src/server/game/Entities/GameObject/GameObject.cpp
The "error" is a false positive happening every time a player in a Battleground logs out because WorldSession::LogoutPlayer() notifies the bg twice
(cherry picked from commit ca5a2785f760a90ceb0c3d321da208ee07552f87)
Fix a rare case that would cause SPELL_EFFECT_NORMALIZED_WEAPON_DMG to do 4 billions damage or to trigger an assertion in Unit::CalculateDamage() depending by Unit base damage.
To reproduce the issue cast spell 25816 on a level 1-14 warrior, then make the warrior cast spell 694 on a Creature.
(cherry picked from commit 143026ed19455f5a908ef508d1bf5ce43c092a21)
Apply an exponential formula to define the chance to bid/buyout an auction depending on auction price and item price ratio. The formula can be adjusted changing the new AuctionHouseBot.Buyer.ChanceFactor config parameter
Chance = 100 ^ (1 + (1 - (auction_price / item_price) / k)
k is the config parameter AuctionHouseBot.Buyer.ChanceFactor, the higher the number the higher chance to buy overpriced auctions.
(cherry picked from commit 177b6319d1ad49a38fbd06f37671da1e3d1ae4e6)
Conflicts:
src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
Addition to a328a119784252c6d514436f4ceffa693ac65453 , clamp object size to [0,4] in case of very huge Creatures like Lord Marrowgar entry 36612
(cherry picked from commit 0a94382637ba9212a23e224b4ac2df114acb4ca7)
Core/Build: Renamed Revision.h to GitRevision.h to avoid compile failure when old revision.h file is present
(cherry picked from commit 360cc93357d1b51258986e547ac29dddac20159c)
Conflicts:
src/server/authserver/Main.cpp
src/server/database/Updater/DBUpdater.cpp
src/server/game/Entities/Player/Player.cpp
src/server/game/World/World.cpp
src/server/shared/PrecompiledHeaders/sharedPCH.h
src/server/worldserver/Main.cpp
Fix Boost libraries not being found by CMake when targeting Visual Studio 2015 with Boost installed using the binaries.
Fixes#15277
(cherry picked from commit ca940548bfbeff585983aa537da036f75d3f0f7b)
Fix a race condition in MMapManager happening whenever a map was unloaded. GridUnload enabled was required to trigger the race condition.
(cherry picked from commit aa042e94c2f76e5735a8f745c3fcb7dd54cf6c0b)
Conflicts:
src/server/collision/Management/MMapManager.cpp
src/server/collision/Management/MMapManager.h
Fix a race condition in VMapManager2 happening whenever a map was unloaded. GridUnload enabled was required to trigger the race condition.
(cherry picked from commit ca7f31c6cdceb7e2921d5d83e1ae22ccb247988d)
Always send a Welcome type Instance Lock chat message when entering an instance instead of changing type based on remaining time.
Fix scheduled warning message to always send "Your instance lock for ... will expire in 0 minutes." even if there are hours left, issue added in 4193806dba , closes#11519 .
Update warning messages based on remaining time so that the most meaning is always used (6 hours left, 59 minutes left, etc).
(cherry picked from commit fae826958915673338868d0b3b273860630638fb)
Conflicts:
src/server/game/Handlers/MovementHandler.cpp
src/server/game/Maps/Map.cpp
Fix Flame Leviathan instance lock not being granted to players because they were ejected from the vehicles as soon as boss died.
Players are now ejected some seconds later.
Close https://github.com/TrinityCore/TrinityCore/issues/15005
(cherry picked from commit b574c99549bb8cf1d95bd4bc0c319548a678799a)
Add "line" optional parameter to ".mmap path" command to use raycast implementation of recast, useful to simulate charge paths.
(cherry picked from commit 37b157746e075294fd14abef5cc8e611b7bf2c76)
Fix Charge returning "no path found" error when targeting targets with Object Size of 8 like Festergut by changing how the target Z coordinate is set, using only half object size.
It is unclear why the CalculatePath() call in Charge handler is using target object size, maybe for corner cases where the target is slightly below the ground.
(cherry picked from commit a328a119784252c6d514436f4ceffa693ac65453)
Disable -Wunused-parameter warnings in gsoap library to have a 0-warning build till the library gets updated
(cherry picked from commit 77f7f562683753a15bd2d3f80e65385f88383566)
Suppress -Wmismatched-tags warnings on clang to avoid false positive warnings reported using gcc 4.8
(cherry picked from commit 879af88d2180ca0655fda87072308f6eb76e70ca)
Fix race conditions in CreatureTextMgr repeat group happening with MapThreads > 1 reported by helgrind by moving Creature-GUID-base data from CreatureTextMgr to Creature.
Issues added in bbf86641a1
(cherry picked from commit d123c811623fcedcf125f56101b6aea773f460e0)
Conflicts:
src/server/game/Texts/CreatureTextMgr.cpp
Make achievements, loot rolls, master loot at money loot instance-wide, removing the previous limit for 74.f yards
(cherry picked from commit cb4d1574e05b0d50368da03c42edeac46590d14f)
Set CMake option VALGRIND to add valgrind support to jemalloc. Set CMake parameter VALGRIND_INCLUDE_DIR to the valgrind include directory.
(cherry picked from commit 60a29f761467c0ac76129f2f761ca0de9e7d237d)
Fix quests not being converted on faction change due to table world.player_factionchange_quests not loaded on startup
(cherry picked from commit c544e88437106fb79dba14bbf8469deadb679e8a)
Allow GameMasters with ".gm on" tag to use ".tele" command inside of a battleground to tele around.
(cherry picked from commit 0b9cd22a6b5a0cca6e3c07dd5ae077ddbdfc3992)
Core/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED
Fix SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED modifying speeds of bosses that are immune to changes of speeds.
(cherry picked from commit 81cec13a586c1d7e84d0936b4a385934f5f91ef1)
Fix an exploit that allowed to resurrect even if corpse was not in range (teleport hack was required too)
(cherry picked from commit 83cf1e6aec0594f7d92bdebf52239867c3fd3abc)
Conflicts:
src/server/game/Entities/Player/Player.h
Handle only 1 exception in the whole process lifetime and create only 1 crash report.
(cherry picked from commit 1a5051a9c3b8246e92543962c04c3883c4d03f5f)
Fix doors opening/closing during Dreadscale fight by sending a CloseDoor command instead of toggling the door state when Dreadscale resets its movement.
Note that bounding the door state to boss movement makes poor sense and should be changed. Other bosses in ToC have this logic and should be updated if they show the same bug.
(cherry picked from commit b5cc8c5b17c96f281728ee08576acfff507d8039)
Core/Spells: Fix being able to cast while feared and rooted at same time
Disallow to cast if feared and rooted at same time
(cherry picked from commit 1161295f4f933661ea9738e0c57049a1e38ec8f2)
Conflicts:
src/server/game/Entities/Unit/Unit.cpp
Fix crash in Violet Hold happening when crystals were activated without killing trash mobs.
Crash added in cba6515acb and f4531c5a58 .
Closes#14629
(cherry picked from commit 09aed2565966c96d403afe44a0cce423c59cb4ec)
Try to log STACK_OVERFLOW crashes by allocating log buffer on the heap which should still be in a valid state with a stack overflow exception.
This will probably still not produce a complete crash report with details about all stackframes.
(cherry picked from commit ec4b08e3cf79cfb5fe99a542bd53bac9560e0d92)
Log the current LfgState of the target player when sending SMSG_LFG_QUEUE_STATUS packet.
(cherry picked from commit c38d4f57b318573f4ccd4404c733d658298c3f0b)
Restore ".lfg queue" behavior to print additional debug informations when an additional argument is passed (any character/word will work).
(cherry picked from commit be9294dc098029c62003d3e19e0c2a29a7c738f7)
Fix some Flame Leviathan issues:
- Fix boss evading all the time due to bad Doors check
- Opened "Lightning Door" to other bosses only after boss dies
- Eject players from the vehicles when boss dies, make them untargetable and despawn them after 5 minutes (adjust the time to the blizzlike time of choice)
(cherry picked from commit d888e4c7ad5ce48eb1f550b3e142dad16c026d0c)
jackpoz