megamage
e6a3dc679f
Fix a crash caused by 0ac431f52d. Close #4418 .
2011-12-23 11:09:09 -05:00
megamage
ce0dfa88a6
Revert "Temp fix for *nix build."
...
It builds in *nix without this patch.
This reverts commit e84fffe588 .
2011-12-22 10:15:17 -05:00
megamage
e84fffe588
Temp fix for *nix build.
2011-12-22 08:57:16 -05:00
megamage
36bfce08b4
Try to fix build in Linux.
2011-12-21 08:55:54 -05:00
megamage
8cf2062c1f
Update grid system. Try to fix some crashes and transport passengers (now they are despawned after a while).
2011-12-20 17:07:09 -05:00
megamage
6a4d68b8c2
Fix a crash caused by m_itemSoulboundTradeable. Fix #4266 .
2011-12-15 10:52:09 -05:00
Vinolentus
599a24df24
Core/ObjectMgr: Fix possible SQL injection for game_tele
2011-12-13 13:58:49 +01:00
Vinolentus
f8cb2f528b
Core/ObjectMgr: Fix possible SQL injection for game_tele
2011-12-12 20:36:46 +01:00
megamage
6a648c01a4
Some clean up of grid system.
2011-12-07 13:02:44 -05:00
megamage
5b034ee631
Revert 81fea2d7b5.
2011-11-28 14:34:30 -05:00
megamage
1f70fd2851
Delete DynamicObject if AddToMap fails.
2011-11-28 14:19:29 -05:00
megamage
81fea2d7b5
Fix some memory leak from CreateTamedPetFrom.
2011-11-28 14:10:56 -05:00
megamage
529af3cd09
Delete obj if it is not successfully added to grid. More to fix.
2011-11-28 14:05:25 -05:00
megamage
cde7ea260e
Make AddToMap return bool.
2011-11-28 13:23:20 -05:00
megamage
49b2407077
Add an ASSERT to find out the reasons of some crashes.
2011-11-28 11:32:52 -05:00
megamage
f116960b2a
Remove a check which always returns true. Correct me if I am wrong.
2011-11-23 13:21:10 -05:00
megamage
f091360940
Do not allow base map be accessed from outside if map is instanceable.
2011-11-23 13:14:59 -05:00
megamage
0eb193f2b4
Revert 2f83db28f2. Note that here we only want to check baseMap->canEnter, but not instanceMap->canEnter.
...
Thanks to SignFinder.
2011-11-23 12:55:00 -05:00
megamage
5a0ffefecc
Remove unnecessary const_cast<Map*>.
2011-11-23 12:51:20 -05:00
megamage
98be413ce0
Clean up very some confusing MapManager functions (create/find map/base map).
2011-11-23 12:45:59 -05:00
megamage
b3fef1e280
Fix build.
2011-11-23 12:42:11 -05:00
megamage
298c162c86
Do not allow an instance map to be created twice if it already exists. Fix #4018 .
2011-11-23 09:34:08 -05:00
megamage
23186b24e2
Merge pull request #3421 from Chipsi/master
...
Core/Items: Added case for Darkmoon Card: Madness trinket
2011-11-21 14:12:46 -08:00
megamage
811d1f85a5
Merge pull request #3990 from kandera/lfgfix
...
Core/LFG: Fix being unable to enter an instance to retrieve body when yo...
2011-11-21 13:58:23 -08:00
megamage
0992f27cad
Fix the correct exit from the dungeon finder queue.
...
By Giuseppe Montesanto
Conflicts:
src/server/game/DungeonFinding/LFGScripts.cpp
2011-11-21 16:56:39 -05:00
megamage
10b89d976f
A temp fix for crash caused by remove corpse.
2011-11-14 21:01:53 -05:00
megamage
0bb964285f
Fix a crash caused by removecorpse
2011-11-12 23:04:51 -05:00
megamage
d9e4d991c9
Fix a crash when player is logged out when not in map.
2011-11-12 08:16:52 -05:00
megamage
077a2194ba
Fix another place where corpse is added twice to a grid.
2011-11-11 18:57:50 -05:00
megamage
07cf71fdd4
Some cleanup of add/remove to/from map.
2011-11-11 17:50:26 -05:00
megamage
f47c0e661c
Add some comments for the previous crash fix. Thanks to Amit86.
2011-11-11 14:20:49 -05:00
megamage
9e3b4fe409
Cleanup before deleting objects when unloading grid. Fix #3922 .
2011-11-11 14:11:58 -05:00
megamage
360c9dd635
Add detailed crash info when aura owner is not in the same map as target in Aura::UpdateTargetMap.
2011-11-11 11:29:59 -05:00
megamage
583f6575e1
Do not add a corpse to grid twice. Should fix #3918 .
2011-11-11 08:50:16 -05:00
megamage
847fc35e6d
Fix compile in linux.
2011-11-10 18:14:07 -05:00
megamage
31a88d4fe5
Fix the crash when removing object from an unloaded grid. Object should always be unlinked from grid no matter if the grid is loaded.
2011-11-10 17:31:45 -05:00
megamage
23b3f16f3a
Add some ASSERT in add/remove obj to/from grid.
2011-11-10 10:18:32 -05:00
megamage
462a2b9876
Change more ace_guard to trinity_guard
2011-11-08 10:48:49 -05:00
megamage
495ef10b0d
Change ObjectAccessor to an ACE_Null_Mutex singleton, since its members have been protected by individual locks.
...
Also make some of its member functions static.
2011-11-07 09:44:09 -05:00
megamage
809694408a
Change ObjectAccessor::i_corpseLock to ACE_RW_Thread_Mutex.
...
Remove unecessary guard in ObjectAccessor::Update.
2011-11-02 09:39:37 -04:00
megamage
e3fa04823d
Use TRINITY_GUARD to replace ACE_GUARD. ASSERT(false) if failed to acquire the lock.
2011-10-31 17:25:12 -04:00
megamage
1b8d9ec7b4
Clean up summon/remove gameobject code.
2011-10-31 10:46:39 -04:00
megamage
dfeb4a746b
Fix a crash caused by spell with CAST_FLAG_RUNE_LIST casted by a creature mover. Thanks to Vasago.
2011-10-31 09:56:04 -04:00
megamage
0ac431f52d
Fix a crash caused by spell 49065. Close #3646 .
2011-10-24 16:54:52 -04:00
megamage
91f56c181c
More cleanup of grid system.
2011-10-22 10:01:29 -04:00
megamage
80a18b9e56
Some cleanup of grid system.
2011-10-22 09:36:05 -04:00
megamage
c9c5c2a355
Use read/write thread mx guard instead of general guard for HashMapHolder.
2011-10-21 17:29:09 -04:00
megamage
7231ab959f
Clean up grid system. Get rid of GridLoader. This patch should not change any logic, except the incorrect calculation of the number of loaded corpse (which only affects log).
2011-10-18 14:31:34 -04:00
megamage
ffdfd9252b
More clean up of grid system.
2011-10-18 11:51:30 -04:00
megamage
e27ef59548
Clean up grid system: allow directly creating Cell from x, y.
2011-10-18 11:18:49 -04:00
megamage
e0d933fed8
Use method IsCoordValid() to replace explicit checks.
2011-10-18 11:05:32 -04:00
megamage
c29ff41001
Rename some classes in grid system.
...
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
megamage
a56f89ab1b
Fix a crashed caused by mob_mistress_of_pain. Fix #3527 .
2011-10-16 16:52:06 -04:00
megamage
71407fde1a
Make npc on transport world object. Try to fix the bug that npc are unloaded with grid and disappear.
2011-10-14 18:09:21 -04:00
megamage
c8251bc619
Remove some "_" from private methods as required by TC standards. Thanks to Shauren for pointing out.
2011-10-13 17:01:55 -04:00
megamage
0e65e94f40
Merge pull request #3467 from Studioworks/master
...
Core: Style cleanup in boss_illidan.cpp
2011-10-13 13:53:00 -07:00
megamage
bcc55489f8
More cleanup of CanSeeOrDetect
2011-10-13 14:02:07 -04:00
megamage
5912e2444d
Some cleanup of CanSeeOrDetect code.
2011-10-13 13:26:27 -04:00
megamage
dc2bdb8e13
Merge pull request #3445 from Bootz/master
...
Scriptwork/Clean-up (Av,Brd,Brs)
2011-10-12 12:01:05 -07:00
megamage
fd9bab9d89
Add a missing break in AuraEffect::CalculateSpellMod. Thanks to vlad852 for pointing out.
2011-10-12 14:48:22 -04:00
megamage
481d16af13
Merge pull request #3430 from Havenard/fix0007
...
Scripts/ICC: Fix Shadow Prison
2011-10-12 08:45:14 -07:00
megamage
0184720df6
Merge pull request #3444 from Havenard/fix0008
...
Fix Elemental Oath
2011-10-12 08:44:47 -07:00
megamage
d2e8237d23
Merge pull request #3469 from Chaplain/cleanup3
...
Core/Spells: SPELL_AURA_MOD_INCREASE_ENERGY_PERCENT improvement
2011-10-12 08:39:45 -07:00
megamage
69414ed065
Add MX lock to InstanceSave::Add/RemovePlayer. Because BindToInstance can be called within Player::Update.
...
Try to fix crashes #2514 and #2177 . May also fix #3466 , #2862 and #2239 .
2011-10-12 11:36:03 -04:00
megamage
44c55f78e0
Fix crash caused by FlameLeviathanPursuedTargetSelector
2011-10-11 17:19:57 -04:00
megamage
11bb9bfdb3
Fix compile error in gcc.
2011-10-11 08:56:44 -04:00
megamage
edc46d5606
Fix a crash caused by my previous commit.
2011-10-11 08:47:36 -04:00
megamage
8ce5177f74
Pass low guid instead of guid to DeleteCharaceterNameData.
...
Thanks to Studioworks for pointing out.
2011-10-10 18:03:19 -04:00
megamage
3569121d80
Remove/Add creature from/to map when it changes map.
...
Note: creatures was never supposed to change map, but now the core allows them to move with transports...
2011-10-10 17:59:52 -04:00
megamage
3ba22d0d06
Rename Map::Add to Map::AddToMap, Map::Remove to Map::RemoveFromMap for better management.
2011-10-10 17:39:34 -04:00
megamage
d156e066cf
Rename "SetPosition" to "UpdatePosition".
...
Replace CreatureRelocation in scripts with new Creature::SetPosition.
2011-10-10 17:08:01 -04:00
megamage
76c9c30c2b
Merge pull request #3399 from megamage/master
...
Fix the relocation of creatures across cells. Try to fix #3054 .
2011-10-10 13:12:15 -07:00
megamage
00f5366029
Fix the bug that CC AOE spells do not remove stealth aura if the target is behind the caster.
2011-10-10 12:56:14 -04:00
megamage
765a6f2e19
Remove duplicated code for SendNameQueryOpcode
2011-10-10 12:47:33 -04:00
megamage
f9fc12650b
Merge pull request #3259 from Souler/pull
...
Traps and Basic Campfire ignoring unattackable flags.
2011-10-08 13:36:05 -07:00
megamage
45de1f01e0
Update char name data when create/delete char.
2011-10-08 16:24:07 -04:00
megamage
0bb86a3e97
Update code related to character name data.
...
Note: need to add/delete data when character is created/deleted.
2011-10-08 16:09:12 -04:00
megamage
679802ecf4
Merge pull request #3400 from Bootz/master
...
REPO: Code-Style fixes... (Part duece)
2011-10-07 17:56:47 -07:00
megamage
1e44044a8f
Merge pull request #3281 from n4ndo/master
...
Fix Crash in ProcessQueryCallbacks
2011-10-07 15:19:21 -07:00
megamage
341d22ff91
Fix incorrect logic in Unit::IsNonMeleeSpellCasted
...
Author: kerhong
2011-10-07 18:16:32 -04:00
megamage
24b5ec1e39
Fix the broken logic in NearestHostileUnitInAttackDistanceCheck
2011-10-07 18:11:24 -04:00
megamage
8c9bd67fe9
Fix crash #3274 in Unit::HandleDummyAuraProc
2011-10-07 18:06:33 -04:00
megamage
47994f82d7
Fix crash #3306 in Unit::HandleDummyAuraProc
2011-10-07 18:01:41 -04:00
megamage
ba8cade780
Fix crash #3297 in Unit::HandleDummyAuraProc
2011-10-07 17:58:23 -04:00
megamage
eb8cbae0d5
Fix the relocation of creatures across cells. Try to fix #3054 .
2011-10-07 17:36:23 -04:00
megamage
a85b1decb0
Merge pull request #3395 from megamage/master
...
Fix a crash caused by SetupBattleground when m_Map is not created.
2011-10-07 14:27:52 -07:00
megamage
381cf2f9d3
Fix a crash caused by SetupBattleground when m_Map is not created.
2011-10-07 13:21:01 -04:00
megamage
42d1562183
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore.git
...
Conflicts:
src/server/game/Entities/Player/Player.cpp
2011-10-07 12:48:20 -04:00
megamage
7f4be7e93a
Fix a crash caused by items with 0 price.
2011-10-03 08:43:21 -04:00
megamage
2730d51266
Fix possible total price overflow when buying items. Fix #3137 .
...
Thanks to BroodWyrm for finding out the problem.
2011-09-28 16:03:46 -04:00
megamage
eb946691c7
Unlink Battleground and BattlegroundMap when one of them is deleted. Fix crash #3239 .
2011-09-27 17:26:13 -04:00
megamage
780747f5d3
Missing part of the previous commit.
2011-09-26 09:14:12 -04:00
megamage
a35deba186
Fix some crashes caused by spell scripts without checking unit type. Fix #3216 and #3217 .
2011-09-26 09:03:33 -04:00
megamage
738f94eed3
Fix incorrect logic in PetAI. Solve #3155 .
2011-09-21 12:53:29 -04:00
megamage
4ccb22e1a6
Fix the incorrect logic of threat online status check. Also add targets in other map or phase to offline container.
2011-09-20 10:26:34 -04:00
megamage
8aead2a1ee
Do not add spell-caused threat to creatures in other map or phase. Fix crashes #2396 and #2992 .
...
Note: Threat system is still thread-unsafe. This patch only reduces the chance of crash.
2011-09-20 10:24:44 -04:00
megamage
e81b3c6fde
Move thread-unsafe events from Player to BattlegroundQueue. Fix crash #2960 .
2011-09-19 17:22:27 -04:00
megamage
c9a4efdf8f
Fix crash caused by invalid talker in SmartScript. Solve #3082 .
2011-09-19 09:24:59 -04:00
megamage
bd4cf4b78b
Store pendingInstanceId instead of pointer of instance save, because pointer may become invalid. Fix #2987 .
2011-09-15 22:04:51 +02:00
megamage
76488854d8
A more conservative way to fix crash #2892 .
2011-09-13 11:54:55 -04:00