Initialize padding bytes in MmapTileHeader struct to avoid saving uninitialized data to disk, causing issues when binary-comparing *.mmtile files.
(cherry picked from commit 2585c62e6fc8925bb74160fb9b24fb1d361a8b2c)
Change "server shutdown 0" behavior to delay the shutdown by the force threshold specified in configs if there are still players connected, set to 30 by default
(cherry picked from commit b37c7101de272d1b3d599f26d6b5077cfacfb121)
Change "server shutdown" behavior to always include [force] optional parameter when issued from local or remote console.
(cherry picked from commit 884736b3b279737c44b0954ca3fe0f193085fbb3)
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix#17664
(cherry picked from commit bcfa47c0514b51690a5dd222b3b1ac5f20379232)
Fix assertion triggered when a Creature was summoned at an invalid position with Auras loaded as Creature addons.
Fix#17415
(cherry picked from commit 75319e4a6887f23562ac141e4494427793962b00)
Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.
(cherry picked from commit 7ff0f3c65fd0c068560351eac92e96a8527c96a7)
Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.
(cherry picked from commit 1347d7cf7a8656f3db9d8b2f6e6d955e1fa8c129)
Fix wheaty exception report counting reference symbols as 2 nesting levels, not logging child objects in some cases, i.e. spell id in SpellEvent crash.
(cherry picked from commit 284dd6b80d79f5691c82eda848c7474c5b87cfd9)
Fix dead flying creatures ignoring being spawned below the floor in instances on server restart because of not taking into account vmap height.
Fix#16777
(cherry picked from commit 912514c198bd0f59bd22c4a189692aff5244f697)
Change an assert to a NULL check on Flame Leviathan vehicle kit, it can be NULL on map unload.
Close#16662
(cherry picked from commit 31cd082833926539c56569ff6faabc139f5f3223)
Core/GameObjects: Fixed an issue where traps were not redirected to Grounding Totem
(cherry picked from commit 2a50ea5cf14e16ee0dda09f3c9090d5541b39b2d)
Core/Player: Fix profession specialization being re-learnt on login after unlearning it
(cherry picked from commit 1c89b4dcdfa0e25aee28245513b1cf464e3d9e7b)
Conflicts:
src/server/game/Entities/Player/Player.cpp
Fix assertion triggered when entering a vehicle while channelling a shared vision spell.
Fix#15953
(cherry picked from commit 2cb54d5606109305194ed3cdb1b56ca62317b891)
# Conflicts:
# src/server/game/Entities/Player/Player.cpp
Add Unit::KillSelf() function as overload of Unit::Kill(this) . Use KillSelf() whenever the killer and the victim are the same to clearly state the Unit is going to kill itself.
(cherry picked from commit 3267c90102068ed88c0bd7146ae747fe8ba44771)
# Conflicts:
# src/server/game/AI/SmartScripts/SmartScript.cpp
Core/Scripts: Remove deprecated script npc_anchorite_truuen
Remove deprecated script npc_anchorite_truuen replaced by SAI in 2cecc7b1f7b846d24f25e0f5acb957c4c4b4484d
(cherry picked from commit 9020790db22d96dca05e8f6581c9cf80727f14b4)
Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.
(cherry picked from commit 5f917e2286809d7aafa8871be38042ae7966c26b)
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close#15900
(cherry picked from commit 6e296ddaa20a51327f7666f6ddaac60e4216ee23)
Adjust more packet throttling values by increasing some limits, this might fix some random kicks.
Close#14659
(cherry picked from commit 5bd7c295c0b0f2cb78345ed02dd37531a67348f5)
Fix a crash happening when using items casting spells like Item ID 37198
Fix#14900
(cherry picked from commit 166e66cc06d418b94e14abb30dea6a76ba9edce2)
Fix queuing in LFG with 5-men groups leaving the party in queue forever, caused by group GUID being added to list of party members.
(cherry picked from commit 42a71133fa32a1414dc52241c99430178b24422e)
Conflicts:
src/server/game/DungeonFinding/LFGQueue.cpp
Add an optional parameter "escapeCharacters" to ChatHandler::SendSysMessage() to properly escape | character, otherwise it might freeze the client.
(cherry picked from commit 7c91984a64c2f78ad17153018a42926dfcf0ae59)
Fix LFG queue issues by removing disconnected players from LFG queue and their party with them.
(cherry picked from commit b7f9836d223925802115f45ad2c2c7eeb9bb00a4)
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.
(cherry picked from commit 2f92a2f58e171bbfa6dc06d3b2663cbf384a7d38)
Conflicts:
src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet(), IsTotem(), IsSummon(), IsGuardian(), IsHunterPet() and IsVehicle() from Creature to Unit
(cherry picked from commit ea4d9c0d9e3339c96b94f13bbbfc1318bb6b03f9)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Unit/Unit.cpp
src/server/scripts/Spells/spell_pet.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet() from Creature to Unit
(cherry picked from commit d243630acff017f5e50bf0c833a0bbac35ba6c5a)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Spells/Spell.cpp
src/server/game/Spells/SpellEffects.cpp
Fix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj
(cherry picked from commit 5f0f152345ec7e9cc6195ba8f59f316a1cad90f7)
The log is triggered when a mage creates a portal to another map, uses it and then the portal despawns.
(cherry picked from commit a8ceb18cdfe850fbb84ddd3d917565f2a100ebb7)
Conflicts:
src/server/game/Entities/GameObject/GameObject.cpp
The "error" is a false positive happening every time a player in a Battleground logs out because WorldSession::LogoutPlayer() notifies the bg twice
(cherry picked from commit ca5a2785f760a90ceb0c3d321da208ee07552f87)
Fix a rare case that would cause SPELL_EFFECT_NORMALIZED_WEAPON_DMG to do 4 billions damage or to trigger an assertion in Unit::CalculateDamage() depending by Unit base damage.
To reproduce the issue cast spell 25816 on a level 1-14 warrior, then make the warrior cast spell 694 on a Creature.
(cherry picked from commit 143026ed19455f5a908ef508d1bf5ce43c092a21)
Apply an exponential formula to define the chance to bid/buyout an auction depending on auction price and item price ratio. The formula can be adjusted changing the new AuctionHouseBot.Buyer.ChanceFactor config parameter
Chance = 100 ^ (1 + (1 - (auction_price / item_price) / k)
k is the config parameter AuctionHouseBot.Buyer.ChanceFactor, the higher the number the higher chance to buy overpriced auctions.
(cherry picked from commit 177b6319d1ad49a38fbd06f37671da1e3d1ae4e6)
Conflicts:
src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
Addition to a328a119784252c6d514436f4ceffa693ac65453 , clamp object size to [0,4] in case of very huge Creatures like Lord Marrowgar entry 36612
(cherry picked from commit 0a94382637ba9212a23e224b4ac2df114acb4ca7)
Core/Build: Renamed Revision.h to GitRevision.h to avoid compile failure when old revision.h file is present
(cherry picked from commit 360cc93357d1b51258986e547ac29dddac20159c)
Conflicts:
src/server/authserver/Main.cpp
src/server/database/Updater/DBUpdater.cpp
src/server/game/Entities/Player/Player.cpp
src/server/game/World/World.cpp
src/server/shared/PrecompiledHeaders/sharedPCH.h
src/server/worldserver/Main.cpp
Fix Boost libraries not being found by CMake when targeting Visual Studio 2015 with Boost installed using the binaries.
Fixes#15277
(cherry picked from commit ca940548bfbeff585983aa537da036f75d3f0f7b)
Fix a race condition in MMapManager happening whenever a map was unloaded. GridUnload enabled was required to trigger the race condition.
(cherry picked from commit aa042e94c2f76e5735a8f745c3fcb7dd54cf6c0b)
Conflicts:
src/server/collision/Management/MMapManager.cpp
src/server/collision/Management/MMapManager.h
Fix a race condition in VMapManager2 happening whenever a map was unloaded. GridUnload enabled was required to trigger the race condition.
(cherry picked from commit ca7f31c6cdceb7e2921d5d83e1ae22ccb247988d)
Always send a Welcome type Instance Lock chat message when entering an instance instead of changing type based on remaining time.
Fix scheduled warning message to always send "Your instance lock for ... will expire in 0 minutes." even if there are hours left, issue added in 4193806dba , closes#11519 .
Update warning messages based on remaining time so that the most meaning is always used (6 hours left, 59 minutes left, etc).
(cherry picked from commit fae826958915673338868d0b3b273860630638fb)
Conflicts:
src/server/game/Handlers/MovementHandler.cpp
src/server/game/Maps/Map.cpp
Fix Flame Leviathan instance lock not being granted to players because they were ejected from the vehicles as soon as boss died.
Players are now ejected some seconds later.
Close https://github.com/TrinityCore/TrinityCore/issues/15005
(cherry picked from commit b574c99549bb8cf1d95bd4bc0c319548a678799a)
Add "line" optional parameter to ".mmap path" command to use raycast implementation of recast, useful to simulate charge paths.
(cherry picked from commit 37b157746e075294fd14abef5cc8e611b7bf2c76)
Fix Charge returning "no path found" error when targeting targets with Object Size of 8 like Festergut by changing how the target Z coordinate is set, using only half object size.
It is unclear why the CalculatePath() call in Charge handler is using target object size, maybe for corner cases where the target is slightly below the ground.
(cherry picked from commit a328a119784252c6d514436f4ceffa693ac65453)
Disable -Wunused-parameter warnings in gsoap library to have a 0-warning build till the library gets updated
(cherry picked from commit 77f7f562683753a15bd2d3f80e65385f88383566)
Suppress -Wmismatched-tags warnings on clang to avoid false positive warnings reported using gcc 4.8
(cherry picked from commit 879af88d2180ca0655fda87072308f6eb76e70ca)
Fix race conditions in CreatureTextMgr repeat group happening with MapThreads > 1 reported by helgrind by moving Creature-GUID-base data from CreatureTextMgr to Creature.
Issues added in bbf86641a1
(cherry picked from commit d123c811623fcedcf125f56101b6aea773f460e0)
Conflicts:
src/server/game/Texts/CreatureTextMgr.cpp
jackpoz