Nawuko
6d21d33aac
Core: user defined literals need a space in front
2013-12-30 20:35:37 +01:00
Malcrom
fe95371d9a
Core/Scripting: Replace casted with cast as casted is not a word.
2013-12-25 14:16:55 -03:30
jackpoz
b3c810a0fb
Core/Misc: Fix warning
...
Partially revert f0a742a8c4 to fix a warning about unhandled switch case (the same case that Coverity reported as dead code) .
2013-12-16 19:52:50 +01:00
Malcrom
a2e7191b26
Core/Unit: prevent COMMAND_ATTACK being added for Trained Rock Falcon.
...
Also added spells for Trained Rock Falcon to db.
2013-12-15 13:43:18 -03:30
jackpoz
f0a742a8c4
Core/Misc: Remove unused code
...
Remove unused debugging code added in MaNGOS r5067.
Remove dead code from a switch found by Coverity.
2013-12-15 13:37:49 +01:00
w1sht0l1v3
89ee8cbac1
Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries.
2013-12-15 14:09:49 +02:00
jackpoz
1c0903e286
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed, while some of them are real issues spotted by valgrind too.
2013-12-14 18:41:26 +01:00
Shauren
54fd53f7e3
Core/Movement: Fixed possible invalid memory access
2013-12-12 09:50:52 +01:00
trickerer
91ebea4a77
Don't allow units to enter combat upon death
2013-12-11 09:38:24 +07:00
jackpoz
f418f4cf94
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about uninitialized values in scripts.
Add spell id validation in Unit::SpellNonMeleeDamageLog() .
2013-12-08 22:04:30 +01:00
Malcrom
5c15e88da9
Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries.
2013-12-08 11:55:28 -03:30
joschiwald
9a0bb93b33
Scripts: fix warning and cleanup npc_apprentice_mirveda
2013-11-24 21:49:51 +01:00
Shauren
1966a78b9f
Core/Movement: Backported spline stop fix from 4.3.4 branch - use Stop spline type for stopping movement instead of starting movement that ends in creature's current position
2013-11-10 18:52:20 +01:00
Spp
94e2b9332a
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
leguybrush
0a308144a8
Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }.
2013-10-28 14:36:07 -04:00
Shauren
b81bf7d025
Core/Spells: Implemented additional conditions for spells that start cooldown after an event instead of after cast
2013-10-26 14:39:00 +02:00
Shauren
06f5011071
Core/Auras: Added serverside checking for UNIT_FLAG_PACIFIED when attempting to start melee attack
...
Closes #8623
2013-10-22 17:09:41 +02:00
Discover-
1a6157985c
Core/Misc: Get rid of some useless code
2013-10-21 09:15:17 +02:00
Shauren
b6db622b52
Core/Transports: Fixed crashes happening when passenger is removed from transport during teleport
...
Closes #11067
2013-10-20 14:27:17 +02:00
Shauren
ce55647c41
Core/Transports
...
* Rewritten path generation, now uses splines - timers are a lot more accurate now
* Implemented stopping transports
* Implemented spawning transports in instances
* Implemented spawning gameobjects as transport passengers
* Transport passengers are now stored in creature/gameobject table using gameobject_template.data6 from transport's template as map id
2013-10-16 18:37:29 +02:00
Discover-
82eda3244a
Core/Misc: Ugh.. Fix recent commit that broke the OnHeal hook 😥
2013-10-14 16:56:09 +02:00
Discover-
db848f2045
Core/Misc: Fix build after 731b3670fe (again..)
2013-10-12 13:41:00 +02:00
Shauren
1d3e3fac89
Build fix
2013-10-06 12:09:05 +02:00
Shauren
9d19e4d0ac
Core/Commands: Restored old functionality of getSelectedPlayer in chat commands
...
Also fixed build
2013-10-06 11:28:25 +02:00
Shauren
21a64d8fb4
Merge pull request #10976 from avengerweb/master
...
Core/Spells: Spells with SPELL_ATTR3_IGNORE_HIT_RESULT can never miss!
2013-10-06 02:19:19 -07:00
Discover-
36e6407e24
Merge pull request #10981 from Lillecarl/hookz
...
Implement OnDamage and OnHeal hooks
2013-10-04 02:55:23 -07:00
Shauren
a368fae588
Core/Players: Fixed issues with incorrect targets being selected for spells
2013-10-03 17:07:25 +02:00
Shauren
993513ce8d
Core/Vehicles: Fixed a crash happening when a minion vehicle despawns with passenger on it
...
Ref #9738
2013-10-02 00:13:00 +02:00
Shauren
770f69d4e6
Core/Vehicles: Fixed calling Vehicle::Uninstall on freed memory
...
Valgrind log:
==7723== Invalid read of size 8
==7723== at 0x10753CE: Vehicle::GetBase() const (Vehicle.h:51)
==7723== by 0x1072449: Vehicle::Uninstall() (Vehicle.cpp:159)
==7723== by 0x10B1E3C: Unit::RemoveVehicleKit() (Unit.cpp:15946)
==7723== by 0x10A8F32: Unit::RemoveFromWorld() (Unit.cpp:13441)
==7723== by 0x11A4703: Creature::RemoveFromWorld() (Creature.cpp:203)
==7723== by 0x11B9AB7: TempSummon::RemoveFromWorld() (TemporarySummon.cpp:279)
==7723== by 0x11B9C6C: Minion::RemoveFromWorld() (TemporarySummon.cpp:308)
==7723== by 0x10A917C: Unit::CleanupBeforeRemoveFromMap(bool) (Unit.cpp:13482)
==7723== by 0x10A926C: Unit::CleanupsBeforeDelete(bool) (Unit.cpp:13504)
==7723== by 0x12DBB89: Map::AddObjectToRemoveList(WorldObject*) (Map.cpp:2108)
==7723== by 0x10F4556: WorldObject::AddObjectToRemoveList() (Object.cpp:2140)
==7723== by 0x11B99C5: TempSummon::UnSummon(unsigned int) (TemporarySummon.cpp:256)
==7723== Address 0x3bd20530 is 64 bytes inside a block of size 168 free'd
==7723== at 0x4C2B59C: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7723== by 0x1071FD3: Vehicle::~Vehicle() (Vehicle.cpp:66)
==7723== by 0x10B1E71: Unit::RemoveVehicleKit() (Unit.cpp:15947)
==7723== by 0x10A8F32: Unit::RemoveFromWorld() (Unit.cpp:13441)
==7723== by 0x11A4703: Creature::RemoveFromWorld() (Creature.cpp:203)
==7723== by 0x11B9AB7: TempSummon::RemoveFromWorld() (TemporarySummon.cpp:279)
==7723== by 0x11B9C6C: Minion::RemoveFromWorld() (TemporarySummon.cpp:308)
==7723== by 0x10A917C: Unit::CleanupBeforeRemoveFromMap(bool) (Unit.cpp:13482)
==7723== by 0x10A926C: Unit::CleanupsBeforeDelete(bool) (Unit.cpp:13504)
==7723== by 0x12DBB89: Map::AddObjectToRemoveList(WorldObject*) (Map.cpp:2108)
==7723== by 0x10F4556: WorldObject::AddObjectToRemoveList() (Object.cpp:2140)
==7723== by 0x11B99C5: TempSummon::UnSummon(unsigned int) (TemporarySummon.cpp:256)
2013-10-01 22:06:39 +02:00
Carl Hjerpe
8737984b71
Implement script hooks: OnDamge, OnHeal
2013-10-01 18:35:09 +02:00
Ellie
1fae858645
Whitespace between string literals and user-defined literals is now mandatory for concatenation in C++11
2013-10-01 01:13:13 -07:00
Vadim
2320f6d28f
Core/Spells: Spells with SPELL_ATTR3_IGNORE_HIT_RESULT can`t never miss!
2013-09-30 13:43:02 +04:00
Nay
78786c7b54
Core&Scripts: Fix clang compiler warnings
2013-08-27 23:47:03 +01:00
Nay
cc14e18664
Core/Misc: Fix compiler warnings
2013-08-27 16:06:18 +01:00
Nay
8eaf763235
Core&Tools: Fix multiple issues found by a static code coverage tool
2013-08-26 02:00:18 +01:00
Shauren
75cc4e7b25
Core/Auras
...
* Fixed unsafe removal of charm auras, it is now safe to remove them inside AI hooks
* Fixes crash in SmartAI::EnterEvadeMode
Closes #8679
2013-08-20 00:43:03 +02:00
joschiwald
2b19ba1879
Misc: replace Unit::GetPlayer with ObjectAccessor::GetPlayer and some cosmetic changes
2013-08-18 01:41:10 +02:00
joschiwald
c45e665c86
Core/Spells: move spell resistance calculation into separate function (and some cosmetic changes)
...
Ref #7254
2013-08-17 00:47:44 +02:00
betagan
c81c198d4c
Core/Spells: Fix deathknight gladiator glove bonus
...
Closes #512
2013-08-16 02:50:47 +02:00
Shauren
d1bb6da668
Core/Spells: Fixed cast time mods using two charges on every cast
2013-08-15 16:34:57 +02:00
Shauren
2ac6380202
Core/Auras: Allow preventing whole aura proc default handler from script hooks, just how it is possible for separate effects
2013-08-15 16:32:22 +02:00
joschiwald
e87402dd05
Core/Spells:
...
- corrected structure of SMSG_PET_CAST_FAILED (fixes highlighted action buttons)
- simplified spell focus check
2013-08-14 15:45:36 +02:00
Vincent-Michael
147c7d5243
Core/Spells: Fix Rogue T10 4P bonus
...
Closes #4153
2013-08-12 13:04:52 +02:00
Vincent-Michael
4c64e407b7
Core/Spells: Convert hunter "Improved Mend Pet" in spell script
...
Closes #5597
Closes #9006
Closes #10346
2013-08-11 19:23:21 +02:00
Nay
d0bde02b21
Core/CreatureAI: Do not remove clone_caster auras on evade (in addition to control_vehicle auras)
2013-08-11 15:52:23 +01:00
Shauren
20a61b6400
Core/Creatures: DoTs and self damage will no longer reset time since last damage taken for stopping creature from evading
2013-08-02 19:56:48 +02:00
joschiwald
a522be8108
Merge pull request #10336 from joschiwald/spellscripts5
...
Scripts/Spells: backport some SpellScripts from 4.3.4 branch
2013-07-23 17:21:17 -07:00
joschiwald
99c67c103d
Scripts/Spells: backport some SpellScripts from 4.3.4 branch
...
- Fix Earth Shield
- Fix Necrotic Touch
- Fix Reflective Shield
Closes #9145 , #9163 , #9665
2013-07-24 02:13:49 +02:00
joschiwald
380cf5d241
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-21 01:38:21 +02:00
Shauren
13208ff257
Core/Vehicles: Implemented vehicle seat flag that makes passengers unselectable and dropped redundant UNIT_STATE_ONVEHICLE (it is only checked in the same places as unselectable unit flag)
2013-06-29 15:20:15 +02:00