* This also fixes proc cooldows unneccessarily being sent to client
* Also removes the need for cooldown hacks when the proc trigger is selected randomly like for Deathbringer's Will
(cherry picked from commit 1e1fcd6847619629f4b6642faaccb81c4cf3755e)
* This issue was caused by PvP-flagging being done calculated after the target's flag was turned off by becoming a pet.
(cherry picked from commit e7a12edb833ffe26f27d6e392e97a560ffb0c827)
(cherry picked from commit 4d4d2f56651b9d9a3966ec2d39f8af182660b369)
Seriously, who doesn't support std::string instead of char* in 2016?
(cherry picked from commit a012b37d66cdfcd3a8f6485c8563740f6f174823)
(I have no idea why I never bothered to do this before, really. It had crossed my mind a few times.)
(cherry picked from commit ab0abdbde5fb70a88aba4ec05291ec717444abe8)
This discussion is more effort than it takes to change it.
(cherry picked from commit b52a6b857097ff0e540fa0b560df2cc61546603d)
- Default range for DoZoneInCombat: 50.0f -> 250.0f.
- Add optional second arg to SummonList::DoZoneInCombat to specify range.
- Also a bunch of random NULL -> nullptr cleanup.
(cherry picked from commit b7f2c87d37ad20e9fd39c6f0523f6b5edb9d4a66)
Too many damn stars in that damn argument list.
(cherry picked from commit afbda0476700f272c734ecb5b31474dbf66477f7)
(cherry picked from commit 6002acf376556eb413a6b514f14b8a07f8de5099)
Another sql fix
(cherry picked from commit 204acbb5b72d9706cdcf26aede62c2eeec11c6a2)
by @gerripeach
(cherry picked from commit c1ed002b4b0d30432b76f9c5df9095ade4b0b171)
SQL file name fix
(cherry picked from commit 74f3a84a019e3d6b71d02c9616238dc1e7b14784)
* Corrections to vehicle id and spells (Soo-holu previously had vehicleid 134 in sniff both are 257)
* Move spell focus for summoning Soo-holu with http://www.wowhead.com/item=39266/tainted-crystal to correct place
* On summon texts for when summoned
* Add some broadcasttext ids I forgot to add in my last commit.
(cherry picked from commit c42f0bd83049385b20d2b53524f7459103ec57df)
- When a creature cannot find a path to its victim, it begins evading all attacks and regenerating health.
- If this persists for 5 seconds, it evades back to spawn position with new EvadeReason value EVADE_REASON_NO_PATH.
- Also some SmartAI cleanup (why oh why does it have so much duplicated code) and getting rid of #defines in favor of type-checked compile-time constants.
(cherry picked from commit 7b1560fccba77ecbdfecd7b33af740aea41b7087)
Add missing reward mail when either version of Return to the Orphanage in Shattrath is returned
Horde (185) - Subject: Thank you! Body: Dear, $n,$B$BThank you for taking me out during Children's Week. Lady Liadrin, the leader of the Blood Knights, has asked that I be released to her custody for training in Silvermoon City!$B$BI just wanted to thank you for taking me to see my friend, Hch'uu, as well as the Dark Portal, the Throne of the Elements, and the Caverns of Time. I like my toy dragon very much!$B$BI'm sure that you're taking good care of my pet. Please tell him that I miss him!$B$BSincerely,$B$BSalandria
Alliance (184) - Subject: Thank you! Body: $n,$B$BThank you for the time that we spent together during Children's Week. Did you know that Farseer Nobundo has asked the orphan matron to allow me to study with him at the Exodar?$B$BThank you for taking me to all of those neat places, and to visit my brother, Jheel. I miss him almost as much as I miss you. And, the Ring of Observance, the Dark Portal and the Caverns of Time were neato!$B$BI'm sure that you're taking good care of my pet. Tell him that I miss him, too!$B$BLove,$B$BDornaa
(cherry picked from commit e4a22f94e79a538b3adef64f619964b384b4b843)
Actually add the sql to last commit
(cherry picked from commit 9566b94688a17f7480e89d6627ca6d43f93125c7)
When you accept quest where you receive item to summon Goregek, Dajik, Zepik, Lafoo, Jaloot or Moodle the guardian for which player just received item is also summoned automatically.
(cherry picked from commit 4a85b652f2ebb601dae8fd7be2857daff9b1d8c1)
Waypoints again since have more experience and had a lot more wp than needed previously
A couple of cosmetic fixes for this quest
(cherry picked from commit 732ec94d9b38eee0acaed6b514292eb65f68b243)
Kittnz