Commit Graph
17731 Commits
Author SHA1 Message Date
ccrs 426f9f2f92 Core/Movement: MotionMaster reimplementation (#21888)
Internal structure and handling changes, nothing behavioural (or thats the intention at least).

(cherry picked from commit 982643cd96790ffc54e7a3e507469649f3b074d2)
2021-09-28 00:15:13 +02:00
Maxwelllmj bd91674e66 Scripts/Karazhan: make Barnes properly start the Opera Event (#21970)
Close: #21881
(cherry picked from commit 4fe5a167d298ad6fcb9a5f130035abcb98fa5eae)
2021-09-26 23:23:26 +02:00
Keader b91398fd28 Scripts/Magtheridon Lair: Fixed a case when channelers get hit kill and not start fight
It's needed for cataclysm+

(cherry picked from commit 65bad41144846ae97fc3bcb21c34cd2d5d1405e1)
2021-09-26 23:04:18 +02:00
Gooyeth 2757235956 Core/Battleground: Fixed a problem that did not let Arenas queue if it was in queue of Random Battleground (#21963)
(cherry picked from commit 5871c3675069b85d83ff8ee4b63e1be6fc9d9aea)
2021-09-26 21:36:48 +02:00
Treeston 5f0f530c08 re-enable CreatureAI::MovementInform for Chase/FollowMovementGenerator - didn't realize any AI used this
(cherry picked from commit 56a056a8a5f5aa61c68a2b827d8d64ff2fc9abdd)
2021-09-26 21:17:40 +02:00
jackpoz 289be4d97c Core/Misc: Fix FreezeDetector triggered on startup
Fix FreezeDetector triggering the assert on startup if scripts took more than a few seconds to initialize.

(cherry picked from commit 7b7dc1b50844027853023491c1f69dc40292eec3)
2021-09-26 20:51:09 +02:00
jackpoz 376defd085 Scripts/Icecrown Citadel: Fix "intended" crash
Change an assert (that can happen easily using ".npc add") to a sanity check

(cherry picked from commit 953640d56369abd979d194b83df90b20f50b2720)
2021-09-26 16:21:33 +02:00
jackpoz 330881518a Core/Quest: Fix crash caused by disabled quests
Fix crash happening when a disabled quest was added and rewarded (through a GM command). Disabled quests are not validated on startup and they can reference invalid spells.

(cherry picked from commit 5f6af8c6cbe7c5a622dd51a77e0d27db33c99118)
2021-09-26 16:21:11 +02:00
ccrs ab740026b3 Core/Movement: crashfix workaround
untested
ref #18471

(cherry picked from commit 76667e45a902f86bd341d40efa28037137e5e541)
2021-09-26 16:16:16 +02:00
jackpoz 3f659ce5ff Core/Thread: Fix crash added in fd33b1cd02a1c69fc78f47f079eadc43c331d054
Fix crash caused by dereferencing uninitialized field.

(cherry picked from commit 623bc6483a067accf816a65c693b0c0df6a999c3)
2021-09-26 16:15:52 +02:00
Treeston 9f06cb63d2 Core/Threat: My dictionary informs me that "fixtate" is not, in fact, a word. Corrected to "fixate".
fd33b1c follow-up

(cherry picked from commit 1d27f83bda1053578911f53b6231bcb96c9b7b1e)
2021-09-26 16:13:15 +02:00
Shauren 58043c8d90 Core/Movement: Removed unneccessary z position adjustment
Closes #21872

(cherry picked from commit d9a2177e9cc1115b0d830bd0a76ac0eec9878e05)
2021-09-26 16:12:52 +02:00
Treeston 16eb5032ad Core/Threat: Re-add fixtate system. I am being told Netherspite needs it.
(cherry picked from commit fd33b1cd02a1c69fc78f47f079eadc43c331d054)
2021-09-26 16:12:33 +02:00
Treeston c926e2fc94 1b7ec4b follow-up
(cherry picked from commit 7fe59c95d857708181991bf8478712b56e5076ac)
2021-09-26 16:11:59 +02:00
Treeston 4634cfaa9f Core/Threat: Fix taunt behavior in some edge cases
(cherry picked from commit 1b7ec4bc841cd51e17bb21a3d4b774102f195c46)
2021-09-26 16:07:40 +02:00
Treeston f1ac141f25 Core/Unit: UNIT_FLAG renames
[UNIT_FLAG_PLAYER_CONTROLLED -> UNIT_FLAG_POSSESSED]
[UNIT_FLAG_PVP_ATTACKABLE -> UNIT_FLAG_PLAYER_CONTROLLED]
Signed off by: Shauren, Warlockbugs.

(cherry picked from commit 081eab3cf5a5ec42917b2a7eaebf816fb36da423)
2021-09-26 16:07:09 +02:00
Jorge Turrado Ferrero a9b97939a8 Scripts/Ulduar: Fixed Vehicles when flame leviathan die(#21897)
(cherry picked from commit f13de8083469742d62c2d74a49a76e35469d8fb0)
2021-09-26 15:49:18 +02:00
Keader 962833d86f Core/Handlers: Fixed Equipament Manager (for real this time)
(cherry picked from commit 26a444719b6bdc06a00f7737a70a6fb4bd6443db)
2021-09-26 15:47:34 +02:00
Gooyeth 80d4bde77a Core/Player: Skip the cinematic of the first login if the character is teleported before. (#21776)
(cherry picked from commit 8cec3ffe43fe3dc144e1475f7bb360ac142c7e5f)
2021-09-26 15:45:44 +02:00
Keader d8e57b1ddc Core/Handlers: Fixed a Equipament Manager typo
(cherry picked from commit 5a22467912ef038c4a8df20547cab4b1b747ad09)
2021-09-26 15:43:00 +02:00
Keader 1fcabb4092 Core/Handlers: Fixed equipament manager with empty slots. Yes kids, dont use drugs !
Followup: 42be04898c6fd001160ee4fdf00fc2ba5c5c1ee3
(cherry picked from commit dec75903cf2ac3bf62d83300a7526cb44ae5b128)
2021-09-26 15:42:24 +02:00
Shauren 9709643f50 Core/Misc: Fix copyright headers 2021-09-26 14:22:52 +02:00
ccrs 0b6049fe0b Core/Movement: use helpers for validation
(cherry picked from commit 71188062314ee94402d9d3e228fd5b46e8865b18)
2021-09-26 14:21:14 +02:00
ccrs d59a6af9c6 Core/Movement: move MoveSplineInit (#21857)
The number of edge cases in which weirdness is seen on "effect movements" will be kinda reduced, plus consistency, plus movementInform on custom movement spline initalizations.

(cherry picked from commit 2a45418032233bc8779cdb44f9be6057c4b417c5)
2021-09-26 14:19:36 +02:00
Shauren 334b02e1da Core/SAI: Fixed crashes when SAI targets pets that use sai if not tamed
Closes #21870

(cherry picked from commit beb333738db0d493bf95994eb5557e174e5dd3a6)
2021-09-26 12:43:18 +02:00
ccrs d376058dcc Core/Movement: crashfix
New movement -> Mutate -> Finish current for that slot that happens to be the same type, Follow -> Finish method on the removed movement -> UpdateSpeed call -> search for top -> crash

Closes #21861

(cherry picked from commit bcab5bc4e7ac3866e86a54a1aa17e1174672ce75)
2021-09-26 01:43:24 +02:00
Shauren 068b340b69 Core/Transports: Force transport passengers into legacy spawn group
Ref #21641

(cherry picked from commit a5df77a9d6f3e48f2c4e8a61d60e3b5f2f0c326e)
2021-09-26 01:42:54 +02:00
Shauren 5274f7af17 Core/PacketIO: Added missing move assignment operator to ByteBuffer
(cherry picked from commit fcb1e3e6424ef86934132e1111052a6798d78bc9)
2021-09-26 01:27:59 +02:00
ccrs 4793b073ee Core/Misc: movement header cleanup
(cherry picked from commit f9914caefc59f36ab7583432442a26b29124b7f1)
2021-09-26 01:22:17 +02:00
Nitair 4f0aa11c6e Scripts/Stratholme: Baroness Anastari rework (PR #21687)
(cherry picked from commit dc2888915127ae31fae641ba8e53d10a7aed6446)
2021-09-25 22:45:56 +02:00
Gooyeth a9e7464e0d Core/Battleground: allow Random battleground and arena queues same time. (#21730)
- It also restricts queuing to arenas if it is in queue of dungeon finder

(cherry picked from commit 8aad6f828e7ade2232da3d4697c41b12f3acc727)
2021-09-25 21:36:11 +02:00
Shauren e598cfe28d Core/SAI: Fixed silence logic in 1e8227eda7f9c6a989fe6c928c857d76491e008c
(cherry picked from commit 668df7fd01a2b3bdac1ea4600ed17df03e51bd60)
2021-09-25 20:46:13 +02:00
Killyana c0cb8fc1fe Core/SAI: Allow movements for creature using castflag 64 when silenced
Closes #20222

(cherry picked from commit 1e8227eda7f9c6a989fe6c928c857d76491e008c)
2021-09-25 20:45:27 +02:00
Killyana e7f93ca96d Core/SmartAI: Remove PauseMovement on AttackStart
Closes #21144

(cherry picked from commit e27a745c582f1c45a5d8a1b72c1d61fe3cecf2f1)
2021-09-25 20:43:39 +02:00
Shauren 52de393f10 Core/Players: Greatly simplifiy fdb2b90685ebc3852740c424170101a196c29ebb
(cherry picked from commit 9617778336556cd9b19c77e037fb64344021d9cc)
2021-09-25 15:36:50 +02:00
Shauren 47630708f0 Core/Players: Prevent creating characters with duplicate name by reserving name early in the process
Closes #21656
Closes #21809

(cherry picked from commit fdb2b90685ebc3852740c424170101a196c29ebb)
2021-09-25 15:34:20 +02:00
Shauren 453b59de57 Core/Maps: Adjusted logic in GetFullTerrainStatusForPosition to closer match what the client does regarding being inside WMOs
Closes #21625
Closes #21624
Closes #21516

(cherry picked from commit b9c6bbb51df0ed10f74617482740fedb91ff5366)
2021-09-25 01:04:21 +02:00
Treeston 3d9d6fbcb8 Core/Movement: Fix a potential crash on newly created pets. Closes #21791.
(cherry picked from commit 74defba5a7e3e0619ca05808936ebd74741e1472)
2021-09-24 23:43:30 +02:00
Shauren d76db70cbf Core/Chat: Fixed chat link exploit
Closes #21790

(cherry picked from commit 454bae42c6412161a69dc9de2ee4e5edcbd7ee8c)
2021-09-24 23:38:11 +02:00
Treeston 1493920495 Core/Movement: Replace old TargetedMovementGenerator into ChaseMovementGenerator and FollowMovementGenerator, full rewrite for both.
- Chase to angle is now functional. Pets use this to chase behind the target. Closes #19925.
- Chase to arbitrary range interval works. Not used anywhere, but you can technically make hunter-like mobs.
- Pets now follow the hunter cleanly and without stutter stepping. Also fix some other things. Closes #8924.

(cherry picked from commit 2a84562dc85516f432bb1e5de9add23c28b26ce4)
2021-09-24 23:37:43 +02:00
ariel- 3d1da4957c Core/Player: partial revert of m_items handling as it's cause of a exploit
Closes #21760

(cherry picked from commit a413e7dee95e39d77b433b6726988d9f049377ad)
2021-09-23 23:53:04 +02:00
Keader 69663cc94f Core/Spells: Fix UNIT_CREATED_BY_SPELL in SPELL_EFFECT_SUMMON (#21756)
(cherry picked from commit 309738dc3e08f572fad661e96f149a017011758c)
2021-09-23 23:50:13 +02:00
ariel- 3ea88f814a Core/Spells: all bleed effects should ignore armor
Closes #21759

(cherry picked from commit 5dec0e491ba56c940833791d2cb4a2607c2b003f)
2021-09-23 23:37:11 +02:00
Gooyeth 2bea816bbe Core/Auras: Don't save liquid auras
(cherry picked from commit 8001c5ead1aa27671aea20336c7eb2194b89d8ac)
2021-09-23 23:23:06 +02:00
ariel- 765987a9f5 Core/Misc: whitespace/tab cleanup
(cherry picked from commit bcc7427fbc5f170656714468dc6f66efe2d78704)
2021-09-23 22:50:09 +02:00
Treeston a5ae9522f3 travis fix, ebc96af follow-up
(cherry picked from commit e350cfc4374f7f2a1170b2c287a24d0461207dbd)
2021-09-23 22:40:42 +02:00
Treeston fc05aba0d4 crash fix follow-up
(cherry picked from commit 6939f4eb7b023a6b2f8940ab12484523e1904860)
2021-09-23 22:28:48 +02:00
Treeston f69d12504c Core/Object: Bump hover delta handling on nearpoints downstack into GetNearPoint2D (from movement generators); functionality should be unchanged
(cherry picked from commit ebc96af6bb784819ba8824ac390864ae9ba12351)
2021-09-23 22:28:06 +02:00
Treeston b0e064ff89 you saw nothing, and have no evidence against me
(cherry picked from commit 69143b949e89612bbdd3abbc5308175a19ff76f9)
2021-09-23 22:24:08 +02:00
Treeston 572c16b017 fb39980 follow-up
(cherry picked from commit 44502bbfff45b01132b9ca4101b26b8a98e56005)
2021-09-23 22:21:55 +02:00