Commit Graph
180 Commits
Author SHA1 Message Date
Shauren 358b33239a Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit 2011-11-23 19:17:33 +01:00
megamage f091360940 Do not allow base map be accessed from outside if map is instanceable. 2011-11-23 13:14:59 -05:00
megamage 98be413ce0 Clean up very some confusing MapManager functions (create/find map/base map). 2011-11-23 12:45:59 -05:00
megamage 298c162c86 Do not allow an instance map to be created twice if it already exists. Fix #4018. 2011-11-23 09:34:08 -05:00
Kandera 04183cb8de Core/LFG: Fix being unable to enter an instance to retrieve body when you have 5 or more instances in the database. 2011-11-18 16:47:06 -05:00
megamage d9e4d991c9 Fix a crash when player is logged out when not in map. 2011-11-12 08:16:52 -05:00
megamage 07cf71fdd4 Some cleanup of add/remove to/from map. 2011-11-11 17:50:26 -05:00
megamage 31a88d4fe5 Fix the crash when removing object from an unloaded grid. Object should always be unlinked from grid no matter if the grid is loaded. 2011-11-10 17:31:45 -05:00
megamage 23b3f16f3a Add some ASSERT in add/remove obj to/from grid. 2011-11-10 10:18:32 -05:00
Shocker c2a2a4f713 Merge pull request #3872 from Bootz/master
Codestyle clean-up
2011-11-09 02:31:18 -08:00
megamage 462a2b9876 Change more ace_guard to trinity_guard 2011-11-08 10:48:49 -05:00
Bootz d1334624da Core: Codestyle clean-up
"pl"->"player"

 Note: codestyle methods needs maintained, Player* player.
still to do properly clean-up chat.cpp.
2011-11-07 11:18:00 -06:00
Bootz f75ec5ba2b Core: Codestyle clean-up
"plr"->player

Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
megamage 495ef10b0d Change ObjectAccessor to an ACE_Null_Mutex singleton, since its members have been protected by individual locks.
Also make some of its member functions static.
2011-11-07 09:44:09 -05:00
megamage 91f56c181c More cleanup of grid system. 2011-10-22 10:01:29 -04:00
megamage 80a18b9e56 Some cleanup of grid system. 2011-10-22 09:36:05 -04:00
kaelima be0b2fcf97 Core/Grid:
- Simplified CellArea calculation (Original author: SilverIce)

- Removed unused code in Cell class (Original author: SilverIce)

- Improve some Visit functions.
2011-10-19 17:40:44 +01:00
Liberate fd45c111b0 Core/Grid: Fix a typo in e0d933fed8. Grids should work correctly again. Thanks Kaelima. 2011-10-18 23:16:33 +02:00
megamage 7231ab959f Clean up grid system. Get rid of GridLoader. This patch should not change any logic, except the incorrect calculation of the number of loaded corpse (which only affects log). 2011-10-18 14:31:34 -04:00
megamage ffdfd9252b More clean up of grid system. 2011-10-18 11:51:30 -04:00
megamage e27ef59548 Clean up grid system: allow directly creating Cell from x, y. 2011-10-18 11:18:49 -04:00
megamage e0d933fed8 Use method IsCoordValid() to replace explicit checks. 2011-10-18 11:05:32 -04:00
megamage c29ff41001 Rename some classes in grid system.
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
Spp bc023c6dfb Core: Fix some warnings 2011-10-18 12:39:01 +02:00
Spp 805e14a463 Core/Grid: Replaced ambiguous operator overloads with functions (Makes it clear to read) 2011-10-18 11:42:40 +02:00
megamage 3ba22d0d06 Rename Map::Add to Map::AddToMap, Map::Remove to Map::RemoveFromMap for better management. 2011-10-10 17:39:34 -04:00
megamage 76c9c30c2b Merge pull request #3399 from megamage/master
Fix the relocation of creatures across cells. Try to fix #3054.
2011-10-10 13:12:15 -07:00
Machiavelli 82dbe7bc17 Core: Fix some build errors after code style cleanup 2011-10-08 13:20:04 +02:00
Bootz 5b4c7783c2 REPO: Code-style clean-ups
* Fixed pMap->map
* Fixed pInstance->instance
* Fixed pInsta->instance
* Fixed pQuest->quest
* Fixed pWho->who
* Fixed pTarget->target
* Fixed pGo->go

~DEVNOTES: Handlers/QuestHandler.cpp still needs to be cleaned...
2011-10-07 19:45:43 -05:00
megamage eb8cbae0d5 Fix the relocation of creatures across cells. Try to fix #3054. 2011-10-07 17:36:23 -04:00
Bootz 96d7a1e970 REPO: code-style clean-up
* Fixed pGuild->guild
* Fixed pGroup->group
* Fixed pOwner->owner
2011-10-07 10:54:53 -05:00
Spp b16d2245bb Cosmetic: Multiple cosmetic changes
- Added missing space to 'if', 'for', 'while' and 'switch' when it's followed by '('
- Added missing space after a comma and remove space before comma (with some exceptions)
- Remove trailing spaces
- Convert tab to spaces

Note: Only affects files with extension "cpp" and "h" under /src/server
2011-09-29 12:43:05 +02:00
Spp 9e517c963b Cosmetic: Replace "* )" with "*)" and "* /*" with "* /*" 2011-09-29 09:32:55 +02:00
megamage eb946691c7 Unlink Battleground and BattlegroundMap when one of them is deleted. Fix crash #3239. 2011-09-27 17:26:13 -04:00
Spp bf38cd8f3e Tab2spaces previous commit :S 2011-09-16 21:56:29 +02:00
Spp d0f9406a10 Core/Instances: Resurrect a dead player (with corpse) before enter to instance. Original patch by Den 2011-09-16 21:54:45 +02:00
megamage bd4cf4b78b Store pendingInstanceId instead of pointer of instance save, because pointer may become invalid. Fix #2987. 2011-09-15 22:04:51 +02:00
Spp af05915b9e [Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions) 2011-09-15 14:12:57 +02:00
megamage 76488854d8 A more conservative way to fix crash #2892. 2011-09-13 11:54:55 -04:00
megamage 2dbf64827a Do not call AddObjectToRemoveList(Pet*) in Map::MoveAllCreaturesInMoveList(). Fix #2892. 2011-09-12 11:44:32 -04:00
Shauren f13f32c972 Core/Achievements: Award normal mode achievements when instance was done on heroic mode 2011-09-05 15:21:37 +02:00
QAston e2d8faea09 Core/Spells: move Cannibalize and Carrion Feeder cast checks to SpellScripts. 2011-08-20 00:30:38 +02:00
Lopin dad2fc78e2 Core/Logs: Added Difficulty output to InstanceMap::SetResetSchedule error message. Requested by Aokromes 2011-08-19 10:47:56 +02:00
Lopin 8ae5750c15 Core/Maps: Changed InstanceSave error message to show also Name & GUID of player and Entry & Name & InstanceId of instance map 2011-08-16 15:42:32 +02:00
Shauren 8e2a32906d Core/Gridmonster: Increased upper value for search radius to size of grid 2011-08-08 13:16:03 +02:00
Spp 4ecda557e4 Core/Battleground: Some (minor) code optimizations
- All access to Battleground vars are done using funtions (Remove friendship from Battleground and BattlegroundMgr)
- Move specific 47 mins arena check to battleground code as its generic to all arenas
- Create PreUpdateImpl and PostUpdateImpl functions. Specific battlegrounds will implement those if needed (No more need of call Battleground::Update inside specific BGs)
- Modify Create function to use only one parameter
- Remove EventPlayerCapturedFlag from Battleground class, only one BG implements it and it's not used outside that BG.
2011-08-05 11:57:09 +02:00
LihO 3fbb657e3b Core/Maps : Crash fix
Closes #1489
2011-08-04 19:41:11 +02:00
Spp- acd0fc79f6 Core: Pass by const reference for simple objects replaced with pass by value 2011-08-01 14:23:27 +02:00
Spp- fa50c0a464 Fix some warnings here and there 2011-07-27 11:00:39 +02:00
tobmaps 55b0e550b9 Core/Spells: Properly fix Ignite 2011-07-24 19:37:57 +07:00