josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,810 Commits 1 Branch 0 Tags
17c3ac6b0732665e8b5144ebf3be5245e9fea9b4
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Machiavelli dae2a088fd Core/Entities: After some research redefine MOVEMENTFLAG_MASK_MOVING and make it entirely mutually exclusive with MOVEMENTFLAG_ROOT - fixes the last of the related client freezes. 2011-07-19 20:37:17 +02:00
Machiavelli 85caf3a2c1 Core/Instances: Fix dungeon and raid difficulty setting for characters under level 70. Prevents entering heroic modes of instances when access criteria are not met. 2011-07-19 20:35:05 +02:00
Machiavelli bcdbc9517e Scripts/Naxxramas: Remove improper unit flags from Gothik the Harvester and properly make him ignore damage taken in phase 1. 2011-07-19 20:32:31 +02:00
Machiavelli e9e50c4937 Core/Players: Fix corpse remove visual for clients 2011-07-13 14:40:46 +02:00
Machiavelli 145ff66382 Core/Entities: MOVEMENTFLAG_ROOT in conjunction with MOVEMENTFLAG_FALLING will cause client freezes, so make them mutually exclusive. 2011-07-12 00:22:38 +02:00
Machiavelli 609efde598 Core/Corpses: Fix a crash in ConvertCorpseForPlayer 2011-06-29 16:08:23 +02:00
Machiavelli 299dd39d1f Scripts/Naxxramas: Achievement The Safetey Dance (Heigan the Unclean) shouldn't be marked as failed if non players die due to erruptions. Also tiny cleanup in affected file. 2011-06-29 05:03:47 +02:00
Machiavelli cbdb8d9cdc Core/Players: restore fuNcti0N4lity of player bones, that was reMov3d for no apparant reaSon and Underlined with the Comment "// we don't want bones to save some cpu.. :)". this fixes insignia looting after honorable KillS. also fixes a crash with the previous code. 2011-06-29 04:54:10 +02:00
Machiavelli e5d253170e Core/Entities: Fix looting gold from vehicles. 2011-06-28 23:11:15 +02:00
Machiavelli 6a59d7ddc1 Core/Entities: Vehicles should be able to be the source of map scripts 2011-06-28 21:43:06 +02:00
Machiavelli f19f0a19f2 Core/Players: Fix possible (exploitable) data desynchronisation that would lead to repeating the same quest while already having received the rewards. 2011-06-28 21:36:21 +02:00
Machiavelli 86a48c1b63 Core/Vehicles: Fix CMSGS_CHANGE_SEATS_ON_CONTROLLED_VEHICLE after recent aura system changes. With thanks to QAston. 2011-06-28 16:48:57 +02:00
Machiavelli e2f49f63bc Core/Entities: Instead of clearing all unit movementflags on SetRoot and SetStunned, only remove ones that are confirmed to be conflicting with MOVEMENTFLAG_ROOT. Fixes vehicle passenger visuals. 
Closes #2141
 2011-06-27 21:25:00 +02:00
Machiavelli 23b9a31229 Core/Vehicles: Final stage of vehicle stat scaling table removal 2011-06-27 15:20:26 +02:00
Machiavelli ad1777229f Core/Vehicles: More codestyle. (missed changes) 2011-06-27 14:42:28 +02:00
Machiavelli 8a7957a759 Core/Vehicles: Remove now unused variables and apply codestyle in Vehicle class 2011-06-27 14:36:00 +02:00
Machiavelli 921b39fb2d Core/Units: Extend change from 6ce529 to Unit::SetRooted as well (was overlooked) 2011-06-27 13:33:56 +02:00
Machiavelli e8b4d1fab7 Core/Spells: Fix side effects from 33f3397 (issues related to Mangle for druids not being re-learned on talent switch). Original fix done alternatively. 2011-06-27 02:01:20 +02:00
Machiavelli 5864a2e151 Core/Packets: Add some additional movementflag filtering to eliminate some packet spoof attempts. 2011-06-27 00:10:53 +02:00
Machiavelli 6ce529aff3 Core/Entities: Add MOVEMENTFLAG_ROOT to unit on Unit::SetStunned, and remove any other conflicting movement flags that might freeze clients. 
This *properly* fixes the ancient root freeze issue that surfaced during the early stages of 3.x
 2011-06-26 21:36:20 +02:00
Machiavelli ad81d4132c Core/Packets: Remove MOVEMENTFLAG_ROOT flag from movementinfo that is sent from client to server. This flag is not valid in this case and is a packet spoofing attempt. When used in conjunction with any of the moving movement flags such as MOVEMENTFLAG_FORWARD this will freeze surrounding clients that receive the cheater's movementinfo. 
Thanks to Dvlpr for help with research.
 2011-06-26 21:27:10 +02:00
Machiavelli 33f3397976 Core/Spells: Completely remove spells which were taught by SPELL_EFFECT_LEARN_SPELL on talent reset or talent spec switch - instead of keeping them stored as disabled. Reason for this is that if the primary spell with effect SPELL_EFFECT_LEARN_SPELL is learnt again, a 'new' secondary spell will be taught while the old one was still around. The latter was the reason for primary key violations in character_spell that led to transaction failures and thus character rollbacks. 
Closes #1231
Closes #480
 2011-06-23 02:39:36 +02:00
Machiavelli 719a079464 Core/WorldSession: Store correct packet in CharacterCreateInfo 2011-06-22 23:30:30 +02:00
Machiavelli 78a90e7bad Core/Worldsession: Fix death knight character creation logic after recent commits 2011-06-22 23:03:53 +02:00
Machiavelli 2b3ee302f7 Missing line from 9b17b9. 2011-06-22 20:55:32 +02:00
Machiavelli 9b17b9c3ba Core/DBLayer: Fix possible crashes from fe8cb7 2011-06-22 18:04:12 +02:00
Machiavelli 0df059d5a2 Core/DBLayer: Don't lock a connection when doing mysql_real_escape_string as it doesn't need to interact with the server. 2011-06-22 15:04:13 +02:00
Machiavelli fe8cb75bf1 Core/DBLayer: Make database interaction after create character packet completely asynchronous. This is more performant and fixes a DoS loophole and possible data desynchronisation caused by spamming this packet. 
Closes #584
Closes #2089
 2011-06-22 14:22:08 +02:00
Machiavelli 8bf53f4a6b Fix copypasta mistake from acb47d, thanks to Lopin for pointing out. 2011-06-21 13:05:08 +02:00
Machiavelli aa55e2a417 Scripts/Ulduar/Flame Leviathan: Make Pool of Tar actually apply harmful auras without resetting instantly. 
Closes #1798
 2011-06-21 02:07:06 +02:00
Machiavelli 3f5453c657 Scripts/Ulduar/Kologarn: Fix Stone Shout target selection 2011-06-21 01:52:01 +02:00
Machiavelli acb47d719c Scripts/Ulduar/XT002: 
- Fix heart phase triggering if boss recovered health from scrapbots previously
- Fix scrapbot enter vehicle visual
- Allover cleanup and codestyle appliance
 2011-06-21 01:15:43 +02:00
Machiavelli e1f7f9e5b1 Core/Players: Fix average item level calculation: omit shirt shot, not chest armor slot. Thanks to AreYouSiries for pointing out. 
See issue #894
 2011-06-12 03:06:33 +02:00
Machiavelli c19dd5b8f9 Scripts/Ulduar/Kologarn: Only set arms in combat with zone if encounter is actually in progress. Thanks to Josh for pointing out. 2011-06-10 19:48:45 +02:00
Machiavelli d0f1dd552a Minor cosmetic fix for SQL from previous commit. 2011-06-10 18:30:23 +02:00
Machiavelli 680798a11d Scripts/Ulduar/XT-002: 
- Implement achievement Nerf Engineering
- Implement achievement Nerf Gravity Bombs
- Implement achievement Heartbreaker
- Boombot's shouldn't melee
- Call BossAI::Reset in XT002::Reset, fixes some timer issues
 2011-06-10 18:24:16 +02:00
Machiavelli 3a5e3e71a4 DB/Entities/Ulduar: Update templates and addon data for adds during XT-002 encounter 2011-06-10 03:27:19 +02:00
Machiavelli 036fc88c1a Scripts/Ulduar/XT-002: Update TODO comments to reflect todays changes. 2011-06-10 03:25:41 +02:00
Machiavelli 84b27f7194 Scripts/Ulduar/XT-002: 
- Fix Boombot's explosion visual and damage (workarounds are torroughly explained in code)
- Proper scrapbot vehicle enter handling. (Missing data on how much HP they should restore on the boss, however)
 2011-06-10 03:24:32 +02:00
Machiavelli c0bc829376 Scripts/Ulduar/XT-002: 
- Fix phase transition submerge/stand visuals
- Further cleanup and minor fixing
 2011-06-09 17:52:34 +02:00
Machiavelli b42239b237 Scripts/Ulduar/XT-002: 
- Implement "Nerf Scrapbots" achievement
- Proper target conditions for Boombot Boom
- Pummeler add should walk towards raid on spawn
 2011-06-09 04:43:57 +02:00
Machiavelli 9505607d95 Scripts/Spells: Proper target selection for 62775 - with thanks to Kaelima 2011-06-08 20:06:41 +02:00
Machiavelli f4229e52f2 Core/Spells: Fix radius for spell 62775 (Ulduar/XT-002 encounter) 2011-06-08 16:52:02 +02:00
Machiavelli 109a861407 Fix non-PCH build 2011-06-07 16:56:32 +02:00
Machiavelli 730043c58f Fix non-PCH build 2011-06-07 16:48:00 +02:00
Machiavelli 16ceb5a39e Core/Spells: Change a log message to debug level and make it more descriptive. 2011-06-07 16:23:20 +02:00
Machiavelli e8bc02f3bd Scripts/Ulduar: Remove dirty spell and summon hacks from XT-002 script and rewrite with EventMap. 
Script is still WIP.
 2011-06-07 16:13:14 +02:00
Machiavelli 05cc29b54a DB/Schema: Add index to characters.character_pet.slot. Prevents deadlocks when operating on this table. 2011-05-29 18:28:54 +02:00
Machiavelli f8bd56e219 DB/Schema: Correct use of indexes on mail_items table. Prevents deadlocks in operations on this table. 2011-05-29 00:32:18 +02:00
Machiavelli 48b0570f53 Core/Vehicles: 
- Temporarily unsummon pets when entering vehicle and resummon them when exiting. Also fixes missing pet cast bars on exit.
- Correct SMSG_PET_SPELLS packet for vehicle spell initialize
 2011-05-27 17:31:31 +02:00
Machiavelli 08ecee3b13 Core/DBLayer: Fix transaction crash. 2011-05-24 18:27:27 +02:00
Machiavelli 7f96d4b01f Fix crash added in 402198 2011-05-23 19:14:39 +02:00
Machiavelli 402198c5ff Core/DBLayer: Proper core-side handling of MySQL errno 1213 to prevent a snowballeffect (until innodb_lock_wait_timeout) 2011-05-23 16:33:33 +02:00
Machiavelli 48838cca27 Fix build on Linux 2011-05-22 13:49:39 +02:00
Machiavelli 29e61ad0ea Core/DBLayer: Remove a problematic and unneeded transaction in _LoadMails 2011-05-22 13:43:57 +02:00
Machiavelli d454ee2a74 Core/DBLayer: Apparantly the possible deadlock was present in Player::DeleteFromDB as well. 
Thanks to Aokromes for pointing out
 2011-05-21 14:50:28 +02:00
Machiavelli 59c0670f44 Core/DBLayer: Fix possible transaction deadlock in HandleMailReturnToSender opcode 2011-05-21 14:24:46 +02:00
Machiavelli 374eba2f5d Scripts/Shadowmoon Valley: Fix kill credit for Enraged Spirits 2011-04-26 23:30:13 +02:00
Machiavelli 6d0c97b06b Core/SAI: Fix a possible crash in SMART_ACTION_SET_ORIENTATION with SMART_TARGET_SELF for TempSummons 2011-04-22 12:19:34 +02:00
Machiavelli c9a917ad79 Core/Spells: Add a 'as-generic-as-possible' temporary fix for SummonProperties 2081 (Mechanical Dragonling, Arcanite Dragonling, Mithril Dragonling). For them, basepoints != amount of entities to spawn. Needs more research for the proper value 
Small cleanup in affected function.
 2011-04-22 12:05:15 +02:00
Machiavelli d42ab6c8bd Core/ScriptedAI: Reset VehicleKit in BossAI::_Reset() 
Core/Vehicles: Minor log fix and comment a redundant assertion
 2011-04-22 11:07:58 +02:00
Machiavelli 1c3082446e Core/Gameobject: Respect cooldown for trap and goober gameobjects. 
Original patch by VladimirMangos
 2011-03-14 23:16:34 +01:00
Machiavelli 31a2c9b82b Core: Fix crash in ~ScriptMgr 
Fixes: #854
Fixes: #918
Fixes: #917
 2011-03-14 09:44:02 +01:00
Machiavelli 7b62bfc1c5 Core/ScriptedAI: Add ResetLootMode() to BossAI::_Reset() and remove some redundant calls in General Vezax script 2011-03-13 22:28:37 +01:00
Machiavelli e1ac75afe2 Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId. 
Research by Kaelima
 2011-03-07 21:13:18 +01:00
Machiavelli 28b14f36c8 Core/Vehicle: Use db table GuidLow instead of normal GuidLow (which may differ per instance) for vehicle_accessory definitions. 2011-03-07 20:48:53 +01:00
Machiavelli ebca4c0326 Scripts/ToTC: Reset vehiclekit on generic_vehicleAI_toc5::Reset() 
Fixes accessory installation
 2011-03-07 20:25:57 +01:00
Machiavelli 311d0cf989 Core/Commands: Make vehicle_accessory and vehicle_template_accessory reloadable with commands 2011-03-07 20:25:56 +01:00
Machiavelli 27680e420f Core/Vehicles: 
- Remove some wrong checks in vehicle_accessory loading.
- Remove Reset() call from Vehicle::Install() - reset is already called by AI functions
 2011-03-07 20:25:55 +01:00
Machiavelli d6ddc6410c Core/Vehicles: Rename vehicle_accessory to vehicle_template_accessory, and implement a new table named vehicle_accessory to allow accessory definitions based on GUID that will overwrite defeinitions based on entry. 
Fixes #Nay
 2011-03-06 23:45:22 +01:00
Machiavelli 0f91728fdd Core/ObjectMgr: Load npc spellclick data after quests. 2011-03-06 16:28:31 +01:00
Machiavelli 10c02690b6 Core/Units: Re-remove MOVEMENTFLAG_ROOT applying on Unit::SetRooted to fix a clientside freeze issue (our visibility system is co-reponsible). It's still an ugly hack and should be fixed properly asap. 
Closes #879
 2011-03-06 16:07:01 +01:00
Machiavelli d5be3353f3 Core/TempSummon: Implement ForcedUnsummonDelayEvent. Similar to ForcedDespawnEvent for Creatures, this will unsummon TempSummon objects with specified delay. 
Core/Vehicles: Implement ForcedUnsummonDelayEvent for creatures exiting vehicles. Fixes visual bug that showed creatures mounted on vehicle after being ejected.
 2011-03-06 15:12:34 +01:00
Machiavelli 6c4a0354a2 Core/ObjectMgr: Move some npc_spellclick_spells and vehicle_accessory related errors to startup instead of post-startup runtime 2011-03-06 11:12:19 +01:00
Machiavelli df97ce7625 Core/Vehicles: Remove redundant Vehicle::Die. All vehicle auras are already removed on Unit::RemoveAllAurasOnDeath. 
Addresses ticket:869 - please reconfirm
 2011-03-06 10:31:25 +01:00
Machiavelli a9582964d3 Core/Vehicles: Make the vehicle system more aura driven. Get rid of redundant checks and update relevant data. 
Closes #805
 2011-03-04 21:17:06 +01:00
Machiavelli e31d08e9e1 Core/SQL: Remove duplicate entry from my previous commit 2011-02-27 18:44:52 +01:00
Machiavelli da773981f8 Core/Vehicles: Respect seatId in vehicle_accessory 2011-02-27 17:38:20 +01:00
Machiavelli 76f393717d DB/World: npc_spellclick_spells updates for Strand of the Ancients and Wintergrasp vehicles. 2011-02-27 16:15:47 +01:00
Machiavelli 3c36ff92dc Core/Vehicles: Fix an error log message (missing change from 683cea9e83) 2011-02-27 15:45:28 +01:00
Machiavelli b161b0859b Core/Vehicles: Fix a possible crash in InstallAccessory 
Closes ticket #769
 2011-02-27 04:05:21 +01:00
Machiavelli 683cea9e83 Core/Vehicles: 
- Grab correct npc entry from npc_spellclick_spells in case of player vehicle. Fixes DB errors added in my previous changeset
- Allow aura's with SPELL_AURA_CONTROL_VEHICLE to stack if there are enough free seats, even if spellIds are identical.
- Fix a possible infinite loop. Thanks to manuel for spotting
 2011-02-27 03:58:41 +01:00
Machiavelli 3ac80ee3a4 Core/Vehicles: Correct usage of npc_spellclick_spells instead of blatant hacks for vehicle entry. 
Note: This may break a few vehicles, but only due to the absence of proper, non-hackish data.
 2011-02-26 23:00:09 +01:00
Machiavelli 7e4456f79d Merge branch 'master' of github.com:TrinityCore/TrinityCore 2011-02-26 03:47:57 +01:00
Machiavelli 30738e645f Core/Vehicles&Movement: 
- Send correct SMSG_MONSTER_MOVE with newly discovered SPLINEFLAG_EXIT_VEHICLE on vehicle exit. Fixes the "stuck on exit" bug as a result of removing the previous hack in 04b656a44f.
- Use SMSG_SPLINE_MOVE_ROOT and SMSG_SPLINE_MOVE_UNROOT as root packets for creatures.
- Reimplement toggling of MOVEMENTFLAG_ROOT on root event (including enter vehicle)
- Speedup in fetching movementflags for vehicles depending on vehicleflags on object updates.
- Code cleanup and refactoring
 2011-02-26 03:47:23 +01:00
Machiavelli 02d8d7c2a6 Scripts/Ulduar: Kologarn (90% complete) 
- Kologarn is unable to parry (correct spellID used)
- Fix Arm respawning
- Correct Arm despawn animation
- Only cast Arm Sweep if left arm is alive
- Remove minimum required range for Focused Eyebeams
- Fix possible crash in Rubble despawn
- Correct gameobject handling
- Fix bridge visual
- Correct instance load operations for this encounter
 2011-02-25 15:17:15 +01:00
Machiavelli 04b656a44f Core/Vehicles: 
- Allow specifying of exit position for Unit::ExitVehicle
- On Vehicle::InstallAccessory, despawn any accessory in the current seat with the same entry with TEMPSUMMON_MANUAL_DESPAWN type
- Remove hacky TELEPORT_ACK packet on vehicle exit
- Remove some redundant packet send operations that were already handled elsewhere
 2011-02-25 01:38:21 +01:00
Machiavelli a6e30e0509 Really fix the crash caused by wrong prepared statement types 2011-02-25 00:00:11 +01:00
Machiavelli 51d00e1b17 Core: Fix crash on login added in 20ab3e4bda 2011-02-24 23:44:08 +01:00
Machiavelli 2c7ca195d1 Core/Vehicles: Remove a visibility hack on Vehicle::AddPassenger. May fix client crash/freeze issues. 2011-02-23 20:43:12 +01:00
Machiavelli 102c089ab8 Scripts/Kologarn: 
- Correct target limitation for Focused Eyebeam
- Correct target selection and limitation for Stone Grip
** Fixes random teleports to the "safe spot" caused by aura unapply when that player wasn't intended as target.
** Stone Grip will only target the main tank if there's no one else in range.
- Despawn Rubbles on encounter reset/complete
- Use elegant MotionMaster::MoveJump instead of NearTeleportTo when releasing Stone Grip target

DB/NPC Templates:
- Add civilian flag for Armsweep Stalker and Rubble Stalker

Other:
- Fix 2011_02_23_2_world_conditions.sql to comply to standards
- Cleanup affected code
 2011-02-23 18:17:20 +01:00
Machiavelli 550f59e05f Core/Vehicles: Do not allow Unit A to enter vehicle of unit B, when unit B is already on vehicle of unit A. 
Fixes a core deadlock and stack overflow as well as client crash in the event of improper scripts.
 2011-02-23 17:41:33 +01:00
Machiavelli 4e9cd1e490 Core/UnitAI: Add template<class PREDICATE> void SelectTargetList, to select target list based on unary predicate function, with parameters maxTargets and targetType. 2011-02-23 13:35:15 +01:00
Machiavelli a6da435b84 Core/Vehicles: Also remove MOVEMENTFLAG_ROOT on ExitVehicle (thanks to Anubisss), and slight refactoring of code. 2011-02-23 04:08:11 +01:00
Machiavelli 867f6d3513 Core/Vehicles: Don't add MOVEMENTFLAG_ROOT to movementflags on vehicle enter. 2011-02-23 02:21:08 +01:00
Machiavelli 0a2fc16908 Core/Vehicles: Send SMSG_FORCE_MOVE_UNROOT to client when exiting vehicle with UNIT_FLAG_DISABLE_MOVE 2011-02-23 02:15:48 +01:00
Machiavelli c42939b99c Merge branch 'master' of github.com:TrinityCore/TrinityCore 2011-02-23 01:46:38 +01:00
Machiavelli 0ec88a642c Scripts/Ulduar: 
- Fix Focused Eyebeams
- Fix Arm Sweep
- Fix respawning and re-entering of arms

DB/Templates:
- Fix speed, modelId and trigger state of Focused Eyebeams
- Set NullAI to semi-triggers; Rubble Stalker, Kologarn Pit Kill Bunny
 2011-02-23 01:45:22 +01:00
Machiavelli 44fc35bb07 Traditional post-commit buildfix 2011-02-22 23:49:08 +01:00
Machiavelli 918f1ce8ec Core/Vehicles: 
- Allow configurable TempSummonType and timer for vehicle_accessory table instead of hard coded values
- Reimplement some earlier charted VehicleSeatFlagsB, that were temporarily removed because of VEHICLE_SEAT_FLAG_UNCONTROLLED (they now work in conjunction with eachother)
 2011-02-22 23:47:28 +01:00