Commit Graph
1202 Commits
Author SHA1 Message Date
Kandera 1037f96e4f Core/Spells: Damage should be dealt AFTER m_damage has been set. possibly fixes scourge strike damage calculations. 2012-05-18 12:31:13 -04:00
Kandera e897bb59f7 Core/SpellEffects: successful dispel effects on hostile targets should put you in combat. Closes #656 Closes #678 2012-05-18 12:25:13 -04:00
Kandera 01b2bf8057 Core/Spells, DB/Conditions: convert checkcast cpp to conditions for spell 52264 (deliver stolen horse) 2012-05-18 12:09:35 -04:00
Kandera edf1de6d93 Core/Spells: move rocket boots spell cast check to spell script. add event for checkcast for deathcoil (dk) heh i forgot it >.< 2012-05-18 11:56:23 -04:00
Kandera 7688c7609f Core/Spells: remove holy shock and death coil (dk) from checkcast and add them to the checkcast of the spell script. also check if unit is in front for damage spell of death coil (dk) Closes #6027 2012-05-18 11:44:38 -04:00
Subv e74135946d Merge branch 'master' of https://github.com/TrinityCore/TrinityCore 2012-05-13 19:40:05 -05:00
Subv 1a06e197fd Core/Spells: Proc the spells that have DEST target when there is no other target info
Closes #6443
Closes #6277
Closes #6331

Signed-off-by: Subv <[email protected]>
2012-05-13 19:39:06 -05:00
Vincent-Michael e122f9fd30 Core/Spell:
* Fix Nourish heal calculation
* Fix some codestyle
2012-05-13 18:08:57 +02:00
kaelima a1ff27a1c6 Core/Threat: Some corrections to 5709929d2b
Fixes HandleChannelDeathItem (spells such as Drain Soul), which got broken by moving m_deathState = s, thanks Shauren
2012-05-13 17:47:27 +02:00
Vincent-Michael 79a735fb01 Core/Spell:
* Fix Spells with DmgClass SPELL_DAMAGE_CLASS_NONE
* Fix SPELL_AURA_PERIODIC_HEAL calculation
* Fix Swiftmend heal calculation
* Fix some codestyle
2012-05-13 16:29:01 +02:00
joschiwald 4e354d6ca9 Core/Spells: fix damage mods from caster on target 2012-05-11 22:43:06 +02:00
Chaplain 469ba0b0e7 Clean up for 58f63509cd
*restore const methods in spellauraeffects
*fix typo in Unit::CalculateMeleeDamage thx bytewarrior
*minor speed up in SpellInfo::GetMaxTicks() thx Warpten
*deleted duble ';;' thx bytewarrior
*speed up in SpellInfo::GetMaxTicks() thx goes to Vincent-Michael
2012-05-10 20:42:07 +03:00
QAston 58f63509cd Merge pull request #6314 from Chaplain/spells
Core/Spells: Separation of caster/target part damage/heal bonus calculation.
2012-05-09 15:10:33 -07:00
Chaplain d94a89c465 Clean misused m_canBeRecalculated.
*When we solve problem with m_amount we could make right solution for caster/victim damage calculation.
2012-05-04 18:35:11 +03:00
Amit a12faa5e9d Fix log typo with spell_group at SpellMgr.cpp 2012-04-30 13:53:25 +03:00
Chaplain 879070bc80 Core/Spells: Separation caster/target part damage/heal bonus calculations.
*Implement HoT/DoT save caster side bonuses and apply target mods on each tick
2012-04-28 23:32:25 +03:00
QAston b53485e053 Fix build and correct minor codestyle issue. 2012-04-28 15:10:52 +02:00
QAston b899f5fc94 Core/SpellScripts: rename GetTarget*() functions to GetExplTarget*(), so the names reflect better what those functions do. Also update some comments. 2012-04-28 14:55:14 +02:00
Vincent-Michael e8bfcb686f Core/Spell: Fix not using Disengage while rooted 2012-04-28 02:56:29 +02:00
Shauren 51656d7e60 Scripts/Icecrown Citadel: Fixed Scent of Blood on heroic mode of Deathbringer Saurfang encounter 2012-04-27 15:38:09 +02:00
Kandera e6a6f6539d Core/Spells: Correct tick damage for health funnel. (thx alp22) Closes #3465 2012-04-24 13:39:37 -04:00
Nay c06012d054 Merge pull request #6272 from MrSmite/PetAI_attackFix
Core/Pets: Fix pets attacking on non-harmful spells (Hunter Mark and others)
2012-04-21 09:19:23 -07:00
Vincent-Core 408c78dcd7 Core/Spells
* Converted percent based damage dealing spell effects to scripts
 * Fix Leviroth Self-Impale damage

Closes #6085

Signed-off-by: Shauren <[email protected]>
2012-04-21 12:17:45 +02:00
kaelima 9559a48877 Core/Spell: Attempt to fix some rare steady shot crashes
ref issue #5689
2012-04-21 02:42:59 +02:00
MrSmite e9fd6d1979 Fix pets attacking on non-harmful spells 2012-04-20 20:22:40 -04:00
Shauren 3c2dd7c5ed Scripts/Ulduar: Algalon the Observer 2012-04-19 23:19:27 +02:00
Subv 3d8aaabaf3 Core/Spells: Do not proc spells with PROC_FLAG_DONE_SPELL_MAGIC_DMG_CLASS_(NEG|POS) if there is no target, reimplemented Storm, Earth and Fire talent in another way
Closes #3367
Closes #2424

If you find more spells that are broken because of this, please notify us
Signed-off-by: Subv <[email protected]>
2012-04-14 20:08:16 -05:00
Subv 8c3d0e2368 Core/Spells: Dont remove auras on stance change if the stance you are moving to is also allowed by the spell.
Closes #2758

Signed-off-by: Subv <[email protected]>
2012-04-14 14:51:59 -05:00
Subv ba957e6a0e Core/Spells: Reapply glyph bonuses that depend on stance when you shapeshift into that instance
Closes #1076 and possibly others

Signed-off-by: Subv <[email protected]>
2012-04-13 18:32:56 -05:00
Shauren c055a8617d Scripts/Icecrown Citadel
* Fixed Professor Putricide Tear Gas stunning himself
* Fixed visual of Unstable Experiment
* Fixed oozes not picking new targets after hitting old
* Fixed Gas Cloud not using melee attack
* Removed ooze summon position hack

Closes #4301
Closes #2726
Closes #5119
Closes #4464
Closes #2874
Closes #4407
Closes #2421
Closes #4899
2012-04-13 19:56:00 +02:00
Subv c04e92564b Core/Spells: Apply Lifebloom's final bloom bonus from Empowered Rejuvenation also on expire. thanks @3kids for noticing 2012-04-12 18:39:40 -05:00
Kandera dda7fab230 Core/SpellScripts: Fix crash caused by 6cb8d607ce 2012-04-12 09:15:36 -04:00
Subv 20a09c5857 Core/Spells: Fixed Lifebloom's final bloom benefit from Empowered Rejuvenation
closes #244
Signed-off-by: Subv <[email protected]>
2012-04-12 05:54:33 -05:00
Subv 6cb8d607ce Spells/Scripts: Allow OnEffectAbsorb to call PreventDefaultAction in AuraScripts
closes #6172

Signed-off-by: Subv <[email protected]>
2012-04-12 05:52:20 -05:00
Subv 2e5962725d Core/Spells: Corrected Rupture critical hits, it wont make other dots (incorrectly) crit any longer
Signed-off-by: Subv <[email protected]>
2012-04-11 18:53:24 -05:00
Subv 397ee8ceb5 Core/Spells: Execute spell procs after the healing effects of a spell
Closes #216

Signed-off-by: Subv <[email protected]>
2012-04-11 17:41:36 -05:00
Kandera 6407582667 Core/Attributes: change some attribute names to better describe what they are 2012-04-11 11:56:35 -04:00
Subv e309c4fe1b Core/Spells: Fixed Riptide bonus on Chain Heal
closes #1152

Signed-off-by: Subv <[email protected]>
2012-04-08 19:09:30 -05:00
Subv 38d5fbac0e Core/Spells: You should be able to revive pets from anywhere without summoning them first
Closes #1090
Signed-off-by: Subv <[email protected]>
2012-04-08 16:22:19 -05:00
Machiavelli 9d6c8add0e Fix non-PCH build and GitExtensions screwup from last changeset 2012-04-08 18:58:42 +02:00
Machiavelli bc96df1aae Core/Shared: Move container functions to shared project under Trinity::Container namespace. Also implement RandomResizeList which takes a predicate function as parameter.
Core/ScriptedAI: Extend SummonList::DoAction to take a predicate function as parameter and allow specifying a maximum number of units to be selected.
2012-04-08 17:40:05 +02:00
Machiavelli e636531da3 Core/Movement: Fix pushback issues and client freeze. 2012-04-08 17:03:44 +02:00
Subv f8e9dedbe5 Scripts/Spells: Removed redundant code for spell 54798.
Closes #519

Signed-off-by: Subv <[email protected]>
2012-04-07 21:09:04 -05:00
Subv fd9c4d9c43 Core/Spells: Health leech spells should still do damage even if the caster is dead (Devouring Plague)
Closes #470

Signed-off-by: Subv <[email protected]>
2012-04-07 20:34:21 -05:00
Subv 7ce33ca0a6 Core/Spells: Fixes the rune cooldown when a hit mises the target
Closes #412

Signed-off-by: Subv <[email protected]>
2012-04-07 16:36:43 -05:00
Shocker 1fccaae4b0 Merge pull request #6070 from MrSmite/PetAI_3.1
Core/Pets: Improve PetAI

Closes #6048
Closes #6070
2012-04-06 18:42:37 -07:00
Shauren 33d5e7c753 Scripts/Icecrown Citadel: Fixed Ice Bomb visual synchronization
Closes #5179
2012-04-07 01:06:56 +02:00
Nay 2560642f07 Merge pull request #6072 from Vincent-Michael/elixir
Core/Spell: Fix Elixir of Minor Fortitude
Closes #1135
2012-04-06 11:53:38 -07:00
Nay a074497880 Core&DB/Spells: Fix Warr T8 4p bonus
- Added missing spell to DB
- Corrected DBC data that is, very likely, wrong
Closes #2386
2012-04-06 19:33:32 +01:00
Vincent-Core d1f8dff47a Core/Spell: Fix Elixir of Minor Fortitude 2012-04-06 20:25:36 +02:00