josh/ThordekkCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,102 Commits 4 Branches 0 Tags
b71779ecb54c99bff4acab22182cffa47dd989a8
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Shauren b71779ecb5 Scripts/The Escape From Durnholde: Fixed Thrall not resetting state after combat 
Closes #28797
Closes #30739

(cherry picked from commit 5c5a047342b417a8363765a7b174fdf1c9f8bd5a)
Signed-off-by: luis <[email protected]>
 2026-06-24 17:55:53 -03:00
Shauren 6878e514f8 Core/Players: Fix Titan's Grip weapon type restrictions 
Closes #20972
Closes #30747

(cherry picked from commit b610048f892e36aadabe2c75c13b2e84f4796f64)
Signed-off-by: luis <[email protected]>
 2026-06-24 17:54:35 -03:00
Shauren 4f316364a0 Core/Async: Add another boost asio forward declaration hack for io_context executor 
Signed-off-by: luis <[email protected]>
 2026-06-22 18:59:24 -03:00
Shauren a05ecc8dae Core/Objects: Minor ObjectGuid packet reading and writing optimization 
Signed-off-by: luis <[email protected]>
 2026-06-21 16:13:00 -03:00
Shauren 85b36029d3 Core/Proto: Updated protobuf messages and services 
Signed-off-by: luis <[email protected]>
 2026-06-18 18:11:23 -03:00
Shauren 98439c8891 Core/Misc: Remove non-array version of RaceMask util 
Signed-off-by: luis <[email protected]>
 2026-06-18 17:56:14 -03:00
Shauren 6a494675db Core/Reputation: Removed duplicate function to get base reputation with a faction 
Signed-off-by: luis <[email protected]>
 2026-06-16 17:41:47 -03:00
Shauren 9a38a472a1 Core/Reputation: Removed unneccessary condition when determining data index for reputation, fixes Shadowmoon Exiles not being a hidden faction 
Signed-off-by: luis <[email protected]>
 2026-06-16 17:40:59 -03:00
Shauren 029a36654a Core/PacketIO: Add packet reading functions returning raw packet bytes without copying 
Signed-off-by: luis <[email protected]>
 2026-06-16 17:37:38 -03:00
Shauren c84a36aff3 Core/Utils: Fix HashFnv1a compile error when hashing uint64 values with 32 bit variant at compile time 
Signed-off-by: luis <[email protected]>
 2026-06-16 17:35:41 -03:00
Shauren 5362437b45 Core/Bnet: Move all protobuf related code to proto service classes 
Signed-off-by: luis <[email protected]>
 2026-06-16 17:34:09 -03:00
Shauren 6404b9c589 Core/Bnet: Fixed handling 0 sized client packets 
Signed-off-by: luis <[email protected]>
 2026-06-16 17:30:20 -03:00
Shauren a55941f834 Core/JSON: Allow deserializing from string_view 
Signed-off-by: luis <[email protected]>
 2026-06-16 17:29:34 -03:00
Shauren cf9cd9b627 Core/Scripts: Replace std::invoke in spell script internals to slightly reduce compile time 
Signed-off-by: luis <[email protected]>
 2026-06-12 18:46:55 -03:00
Shauren 044b35d43e Core/Misc: Build fix for gcc on windows 
Signed-off-by: luis <[email protected]>
 2026-06-12 18:46:17 -03:00
Shauren b097121c92 Core/Quests: Fail quests with QUEST_FLAGS_COMPLETION_NO_DEATH when releasing spirit instead of immediately on death 
Signed-off-by: luis <[email protected]>
 2026-06-09 17:25:03 -03:00
Shauren 12683b7b41 Core/Battlegrounds: Fix possible shutdown crash 
Closes #30725

(cherry picked from commit b8582e71caf2154ac9232d337973dfc285f80981)
Signed-off-by: luis <[email protected]>
 2026-06-09 17:23:38 -03:00
Shauren c1dd093e74 Core/Spells: Fixed range checks for ON_NEXT_SWING spells broken in f02ac750073fd07c14bf86f7ddc3e72a7b83d59b 
Signed-off-by: luis <[email protected]>
 2026-06-05 19:43:17 -03:00
Shauren 7b66db3363 Core/GroupHander: Simplify 5e95f4db66aad68b67db351605cddf37cc5cdcb9 
(cherry picked from commit f57647287af1f47a1c4a503cde654d6ff8f4261c)
Signed-off-by: luis <[email protected]>
 2026-06-01 19:58:16 -03:00
Shauren e39e72b74f Core/Spells: Implement sending FailedBy in spell failure packets 
Signed-off-by: luis <[email protected]>
 2026-06-01 19:53:52 -03:00
Shauren e351e5d68b Core/Players: Add location restrictions for race and faction changes 
Signed-off-by: luis <[email protected]>
 2026-06-01 19:52:46 -03:00
Shauren c702a00b44 Core/Spells: Corrected SpellCastResult values sent on spell interrupts 
(cherry picked from commit b1c15cbfe61884664ed7615a34ca77ad0db3d95c)
Signed-off-by: luis <[email protected]>
 2026-06-01 19:35:51 -03:00
Shauren 201d227143 Core/Spells: Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed in 63bc405faeb7afcf99de6f7531e4ea59065165f4 
(cherry picked from commit 844efbfca84580f7b2bd700f40209515f2aaa959)
Signed-off-by: luis <[email protected]>
 2026-06-01 19:35:17 -03:00
Shauren d9964d9144 Core/Spells: Don't send SMSG_CAST_FAILED for interrupted spells after they were launched or channelling was started (this clears cooldown on client) 
Closes #26077

(cherry picked from commit 63bc405faeb7afcf99de6f7531e4ea59065165f4)
Signed-off-by: luis <[email protected]>
 2026-06-01 19:25:47 -03:00
Shauren 064223c23a Core/Spells: Removed early access_requirement checks for summon spells to prevent cross map inventory access (it is checked later by TeleportTo) 
Closes #26877
Closes #29906

(cherry picked from commit 4a30ca00c7d9adc3ec46267ca267d36c46a3c88e)
Signed-off-by: luis <[email protected]>
 2026-06-01 19:22:34 -03:00
Shauren 3153ca6c36 Core/Spells: Fixed TargetB selectoin after d6ccdbea10a29091afc20471331f50260f65ac46 
(cherry picked from commit eba78de1eeb824fec5fcdc50fc08196419605b7c)
Signed-off-by: luis <[email protected]>
 2026-06-01 19:12:55 -03:00
Shauren edaa325644 Core/Spells: SPELL_ATTR1_REQUIRE_ALL_TARGETS should require that each unique (targetA, targetB) pair has at least one target, not that each effect has a target 
* Fixed Mind Flay on creatures immune to slow

(cherry picked from commit d6ccdbea10a29091afc20471331f50260f65ac46)
Signed-off-by: luis <[email protected]>
 2026-06-01 19:12:05 -03:00
Shauren 482c683df6 Misc/Extractor: Update extractor.bat - vmaps are not optional anymore 
Signed-off-by: luis <[email protected]>
 2026-06-01 19:11:21 -03:00
Shauren 8c0755d7b8 Core/Auras: Implement aura SPELL_AURA_DETECT_VISIBLE_WHILE_INVISIBLE 
Signed-off-by: luis <[email protected]>
 2026-05-31 20:49:20 -03:00
Shauren 93747de9c0 Revert "Spells/Mage: Mages should be able to see everything while on Invisibility" 
This reverts commit 456d9a6cea801c013df0c784256a3ada9a813aed.

Signed-off-by: luis <[email protected]>
 2026-05-31 20:48:50 -03:00
Shauren 970f62a37b Core/Spells: Improved spell explicit target fallback selection for unit targets when spell target comes from client 
Client only looks at target type of first spell effect to determine what additional target info to send in packet outside of Spell.dbc Targets column

Closes #11566
Closes #29809

(cherry picked from commit 5d7ae76d6f2a0f6f6416ff754d2243f3aafcc7d5)
Signed-off-by: luis <[email protected]>
 2026-05-31 20:42:56 -03:00
Shauren 4ab3fb1c3a Core/Auras: Fixed SPELL_AURA_PREVENT_REGENERATE_POWER for power types other than mana 
Signed-off-by: luis <[email protected]>
 2026-05-31 13:51:09 -03:00
Shauren 89fd1ee360 Core/Chat: Control CHAT_MSG_PARTY_LEADER serverside 
Closes #14868
Closes #29689

(cherry picked from commit e835ab5014345962d84590cdd2ce71cc27608c80)
Signed-off-by: luis <[email protected]>
 2026-05-29 18:02:02 -03:00
Shauren 741150bd79 Core/PacketIO: Removed wrong error packet used when trying to leave party in battleground 
Closes #29726

(cherry picked from commit 39fd26ef41b802f937695a57ae10dbfc476d51c0)
Signed-off-by: luis <[email protected]>
 2026-05-29 17:57:13 -03:00
Shauren 4c98df22d6 Core/PacketIO: Implemented SMSG_REAL_GROUP_UPDATE, used to access information about original group data while being in a lfg/bg group at the same time 
Fixes GetRealNumPartyMembers, GetRealNumRaidMembers and IsRealPartyLeader lua functions

(cherry picked from commit c5d63ee1fc24a01710f069b8dc6442c3c5983311)
Signed-off-by: luis <[email protected]>
 2026-05-29 17:57:13 -03:00
Shauren edc7fde5e2 Core/Cells: Improve cell copy constructor and argument passing codegen (now fully done through a single register) 
(cherry picked from commit 8a619460e21a9603a45894db88e344a0499c2d0f)
Signed-off-by: luis <[email protected]>
 2026-05-26 21:17:23 -03:00
Shauren d27c679492 Core/Battlefield: Fixed using invalidated iterator when a player queued for wintergrasp is inside a battleground 
Closes #29405

(cherry picked from commit 63cbef9e893d19318e97aab67dff7bc7e82e6544)
Signed-off-by: luis <[email protected]>
 2026-05-26 21:15:12 -03:00
Shauren 26f437d2d7 Core/Battlefields: Added missing virtual destructor (and delete copy and move operations) 
(cherry picked from commit 343d09bc95ade0cc34f953b56cbe666baca387fc)
Signed-off-by: luis <[email protected]>
 2026-05-26 21:09:56 -03:00
Shauren c557c7211a Scripts: Fix EventMap event id overflow 
Signed-off-by: luis <[email protected]>
 2026-05-26 21:09:12 -03:00
Shauren 89869a46df Core/Spells: Corrected client control checks in spell packets 
Closes #26510
Closes #27863

(cherry picked from commit 0a34290484f3e90a2a642986de682a8b0c7e3815)
Signed-off-by: luis <[email protected]>
 2026-05-26 21:04:56 -03:00
Shauren 6778591b37 Core/Instances: Fixed crash in loading scenario state 
Signed-off-by: luis <[email protected]>
 2026-05-26 08:20:07 -03:00
Shauren 5b0f26d059 Core/Loot: Fixed loot roll exploit 
Closes #29042

(cherry picked from commit fb699dc641342c1e1a094ec5bff7b5e581dd0d01)
Signed-off-by: luis <[email protected]>
 2026-05-26 08:19:27 -03:00
Shauren d3bb3c8f09 Core/Units: Corrected AURA_INTERRUPT_FLAG_NOT_SEATED implementation to only interrupt when actually standing (flag not renamed but its correct name is SpellAuraInterruptFlags::Standing) 
(cherry picked from commit 47b1de526e9f380c96307edc5fb618ad18f04206)
Signed-off-by: luis <[email protected]>
 2026-05-26 08:17:00 -03:00
Shauren 54e9dc2321 Core/Auras: Don't force sitting state from non-standing state when applying auras with SpellAuraInterruptFlags::Standing 
Closes #28973

(cherry picked from commit dd10ac27fee1fa91661422458d22bb1d2dbab6de)
Signed-off-by: luis <[email protected]>
 2026-05-26 08:16:28 -03:00
Shauren ccd6568a73 Core/Units: Don't make force stand state on periodic damage taken 
Closes #28950

(cherry picked from commit 2f4c412f4c13c7ae02d3d3ae715c3099395bcf70)
Signed-off-by: luis <[email protected]>
 2026-05-26 08:15:52 -03:00
Shauren bf970624ee Core/Misc: Port some 3.3.5 cherry-pick refactors 
Signed-off-by: luis <[email protected]>
 2026-05-25 22:28:21 -03:00
Shauren ffa2a47aba Core/Misc: Port some 3.3.5 cherry-pick refactors 
Signed-off-by: luis <[email protected]>
 2026-05-19 14:20:41 -03:00
Shauren e6413a357c Core/Misc: Port some 3.3.5 cherry-pick refactors 
Signed-off-by: luis <[email protected]>
 2026-05-16 03:11:44 -03:00
Shauren 5282dcbc5a Core/PacketIO: Use default compiler generated copy and move operations in WorldPacket 
(cherry picked from commit b758b56be4088a80fcb2094885267af9333d28e5)
Signed-off-by: luis <[email protected]>
 2026-05-13 21:44:11 -03:00
Shauren 05a2b81e74 Core/CrashHandler: Fix formatting single char variables 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:29:13 -03:00
Shauren 88f0137b4c Core/CrashHandler: Update enums from DIA SDK 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:28:30 -03:00
Shauren dd497fdcc3 Core/CrashHandler: Replace unsafe pointer dereferences wrapped in __try/__except with ReadProcessMemory 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:26:28 -03:00
Shauren f57149a160 Core/Misc: Reorder function definitions in MiscPackets.cpp to match declaration order in header 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:25:44 -03:00
Shauren f3b4b9b73f Core/Misc: Fix linker errors with clang-cl 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:25:03 -03:00
Shauren 7d2879e0c8 Core/Misc: Nopch build fix for msvc 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:23:56 -03:00
Shauren 4b32cef125 Core/Misc: Remove old msvc warning suppression workarounds for do {} while (0) constructs used in assert and logging macros 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:21:37 -03:00
Shauren d1b5e93168 Core/Misc: Changed compiler detection to better support compilers that pretend to be something else, such as clang-cl is both msvc and clang at the same time 
Signed-off-by: luis <[email protected]>
 2026-05-12 08:15:13 -03:00
Shauren 42ecab9e7f Core/Position: Add StringFormat support for Position and WorldLocation 
Signed-off-by: luis <[email protected]>
 2026-05-11 19:59:20 -03:00
Shauren e78f5dce1f Core/Movement: Move ValidateMovementInfo back to WorldSession class to reduce differences between branches 
Signed-off-by: luis <[email protected]>
 2026-05-08 21:57:08 -03:00
Shauren f0806d0492 Dep/g3d: Fix warnings with gcc 16 
Signed-off-by: luis <[email protected]>
 2026-05-08 21:44:55 -03:00
Shauren 26e5bc3232 Dep/g3d: Build fix for gcc on windows 
Signed-off-by: luis <[email protected]>
 2026-05-08 21:42:37 -03:00
Shauren a4afe6dbd9 Core/Spells: Removed incorrect generated proc data for different difficulties for spells that already have rows in spell_proc table 
Signed-off-by: luis <[email protected]>
 2026-05-08 21:41:58 -03:00
Shauren 7c17f70151 Core/Movement: Implement FadeObject spline flag for playing smooth despawn animations 
Signed-off-by: luis <[email protected]>
 2026-05-07 00:50:18 -03:00
Shauren 36e76eb5c7 Core/Commands: FIx .character deleted commands outputting full guid strings instead of just counters (full guids cannot be used as input for other .character deleted commands) 
Signed-off-by: luis <[email protected]>
 2026-05-06 13:28:00 -03:00
Shauren ff18a1c501 Core/Objects: Private objects are no longer able to see non-private objects other than their owner 
Signed-off-by: luis <[email protected]>
 2026-05-05 08:36:56 -03:00
Shauren 1215c7aad0 Core/Vehicles: Remove incorrect passenger->vehicle threat redirection 
Closes #31832

Signed-off-by: luis <[email protected]>
 2026-05-05 08:36:10 -03:00
Shauren 8fb211a1e0 Core/DataStores: Skip MapDifficulty rows that don't point to a valid map id and remove asserts on Difficulty.db2 checks (0 is a valid difficulty for a map and it doesn't have data in that file) 
Signed-off-by: luis <[email protected]>
 2026-05-04 20:58:51 -03:00
Shauren 8ccf4e4629 Core/DataStores: Add id to assertion message in DB2Storage::AssertEntry 
Signed-off-by: luis <[email protected]>
 2026-05-03 03:10:12 -03:00
Shauren f49020bf5b DB/Creatures: Add vendor data for 12.0.5 void assault npcs 
Maren Silverwing <Quartermaster>
Triam Dawnsetter <Cosmetic Equipment Salvager>
Rae'ana <Historian and Research Supplier>
Sergeant Vornin <Animal Handler>

Signed-off-by: luis <[email protected]>
 2026-05-02 13:42:31 -03:00
Shauren d0023aec46 Dep/jemalloc: Update to 5.3.1 
Signed-off-by: luis <[email protected]>
 2026-05-02 13:42:31 -03:00
Shauren 9c70cdfe16 Core/Players: Correct new trait condition check 
Signed-off-by: luis <[email protected]>
 2026-04-28 21:20:30 -03:00
Shauren 79b34b102d Core/Players:: Improve trait config validation and implement new condition type used for apex talents 
Signed-off-by: luis <[email protected]>
 2026-04-28 21:17:19 -03:00
Shauren a9c86ce643 Core/Players: Fixed crash happening on character creation when StartPlayerLevel is set to a value greater than 10 
Signed-off-by: luis <[email protected]>
 2026-04-28 20:17:14 -03:00
Shauren db8ec66be9 Core/Spells: Add SpellRange structure to replace std::pair<float, float> in spell range checks 
Signed-off-by: luis <[email protected]>
 2026-04-26 17:02:48 -03:00
Shauren d5227dada5 Scripts/Azjol-Nerub: Fixed Anub'ar Assassin jump pos selection after 5423f36b4d7d0a9830be91c310a19329f57a1cce 
Signed-off-by: luis <[email protected]>
 2026-04-26 17:02:14 -03:00
Shauren 1d89900c29 Core/Players: Move loading transmog outfits before loading items and rewarded quests 
Closes #31816

Signed-off-by: luis <[email protected]>
 2026-04-26 17:01:33 -03:00
Shauren 51a67b17c9 Core/Quests: Fix adding and removing quests 
Closes #31812

Signed-off-by: luis <[email protected]>
 2026-04-25 08:04:27 -03:00
Shauren d3446aed99 Core/Misc: Apply random position selection improvements from ed2a08dc707808caaf5f4b876620dcb510706f96 to WorldObject::GetRandomPoint and WorldObject::GetRandomNearPosition 
Signed-off-by: luis <[email protected]>
 2026-04-25 08:03:47 -03:00
Shauren 7fecc13c8d Core/Network: Build fix for boost 1.91 
Signed-off-by: luis <[email protected]>
 2026-04-25 08:02:22 -03:00
Shauren 58bb016e34 Core/Players: Fixed use after free in loading transmog outfit slots 
Signed-off-by: luis <[email protected]>
 2026-04-25 08:01:35 -03:00
Shauren 33d641a88c Core/Misc: Support arrays in RaceMask util 
Signed-off-by: luis <[email protected]>
 2026-04-21 20:42:04 -03:00
Shauren 87d77abcb2 Core/Bnet: Fixed bnetserver getting stuck on shutdown when running as windows service 
Signed-off-by: luis <[email protected]>
 2026-04-18 22:40:28 -03:00
Shauren c4e487b936 Core/Crypto: Support OpenSSL 4.0 
Signed-off-by: luis <[email protected]>
 2026-04-17 08:37:35 -03:00
Shauren e972774513 Dep/gSOAP: Disable unused openssl integration 
Signed-off-by: luis <[email protected]>
 2026-04-17 08:36:50 -03:00
Shauren 1fe5f4ed85 Dep/gSOAP: Upgrade to 2.8.141 
Signed-off-by: luis <[email protected]>
 2026-04-17 08:36:06 -03:00
Shauren 3dbf70aa9f Core/Misc: Change Float*chrono* typedefs to double to match return type of chrono_literals 
Signed-off-by: luis <[email protected]>
 2026-04-16 19:41:23 -03:00
Shauren a811e40393 Core/Auras: Update absorb aura priority ordering 
Signed-off-by: luis <[email protected]>
 2026-04-15 19:39:37 -03:00
Shauren 8e192028ed Core/Network: Fix build with msvc versions < 19.43 (vs 2022 17.13) 
Signed-off-by: luis <[email protected]>
 2026-04-06 19:22:05 -03:00
Shauren d2fa0ab30c Dep/jemalloc: Fix build on arm64 
Closes #31776

Signed-off-by: luis <[email protected]>
 2026-04-05 12:29:16 -03:00
Shauren bed2dde183 Core/Auras: Define new aura type 
Signed-off-by: luis <[email protected]>
 2026-04-05 12:27:51 -03:00
Shauren 3fb57b3400 Core/Players: Define new CharacterFlags4 
Signed-off-by: luis <[email protected]>
 2026-04-02 21:17:53 -03:00
Shauren ec7d87555f Core/Spells: Changed SpellEffectInfo::CalcBaseValue return type to double 
Signed-off-by: luis <[email protected]>
 2026-03-30 15:30:54 -03:00
Shauren 292d597c8b Core/Commands: Fix copypaste 
Signed-off-by: luis <[email protected]>
 2026-03-30 15:29:23 -03:00
Shauren 0e060a2f4f Core/Utils: Fixed Trinity::GetTypeName return value when given std::type_info args directly 
Signed-off-by: luis <[email protected]>
 2026-03-28 08:51:31 -03:00
Shauren 7274ff07fb Core/Misc: Reduce memory usage when data query cache is disabled in config 
Signed-off-by: luis <[email protected]>
 2026-03-13 19:34:15 -03:00
Shauren 291526eebb Core/Misc: Add missing includes and remove unneccessary Bag::GetDebugInfo override 
Signed-off-by: luis <[email protected]>
 2026-03-13 19:33:06 -03:00
Shauren 5badcaaf3c Core/Spells: Fixed spell visual selection 
Signed-off-by: luis <[email protected]>
 2026-03-12 19:49:00 -03:00
Shauren 9e0d2040f2 Core/Misc: Remove outdated TODO comment 
Signed-off-by: luis <[email protected]>
 2026-03-12 19:44:25 -03:00
Shauren 786dee89e2 Scripts/Spells: Handle haranir Shadowy Apparitions spell visual 
Signed-off-by: luis <[email protected]>
 2026-03-12 19:43:26 -03:00
Shauren 154d79123c Core/AuctionHouse: Replace IteratorPair with std::span 
Signed-off-by: luis <[email protected]>
 2026-03-11 14:01:19 -03:00