Commit Graph
1197 Commits
Author SHA1 Message Date
Subv 24b699d904 Core/Spells: Fixed Dancing Rune Weapon double-applying the duration bonus of the glyph
Closes #6032

Signed-off-by: Subv <[email protected]>
2012-04-05 08:32:58 -05:00
Subv 5468e8eeb5 Core/Spells: The first target of a chained spell should be explicit.
Closes #5643
2012-04-04 17:06:50 -05:00
Gyx 360014856d Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-29 13:42:04 +08:00
Gyx 1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <[email protected]>
2012-03-28 20:00:29 +08:00
Gyx 72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-28 19:11:50 +08:00
kaelima 820f45c424 Core/Protocol:
- Correct and rename response message from creating/updating a ticket
- Prevent some trailing data in CMSG_GMTICKET_CREATE and add comment on stuff missing from its structure.
- Random cleanup
2012-03-28 03:59:03 +02:00
Shocker b4f9cb6aa8 Core/Spells: Correct diminishing returns for Horror category 2012-03-28 01:30:12 +03:00
Nay 729f419af1 Core/DBLayer: Correct few more wrong read types (No. 4)
DB/World: Some consistency in the ints "length" field (not really a length)

All world dbs checked
2012-03-27 21:36:16 +01:00
kandera def4643896 Core/Spells: correctly fix the issue with dispel over time auras. thx shauren 2012-03-27 14:46:19 -03:00
Kandera 0550f1dc05 Core/Spells: fix the issue with dispel auras. (thx warpten) closes #5902 2012-03-27 08:42:54 -04:00
Nay 8f365de4b2 Core/DBLayer: Fix creature and spell_rank loading 2012-03-26 21:06:50 +01:00
Kandera 7b357a5028 Core/Spells: Fix Misdirection (thx to elron) closes #5869, #4343 2012-03-26 11:37:03 -04:00
kaelima c38bf4498a Fix compile and fix a possible crash for mob_kiljaeden_controller 2012-03-26 03:12:56 +02:00
Shocker fab1944ae4 Core/Spells: Don't remove summoned gameobjects for non-channeled spells when spell cast was canceled
Fixes issues like Demonic Circle: Summon removing the last summoned circle when the new cast was canceled
2012-03-26 03:03:32 +03:00
Shocker 4c16421cde Core/Spells: Fix periodic aura log for SPELL_AURA_PERIODIC_HEAL and SPELL_AURA_OBS_MOD_HEALTH when there is heal absorption 2012-03-24 20:21:17 +02:00
Shauren 25c13de8b3 Core/Auras: Corrected check relying on a not yet initialized variable 2012-03-24 13:43:28 +01:00
Shauren 568e524c45 Core/Spells: Implemented CREATURE_TYPEFLAGS_PARTY_MEMBER, creature with this type_flag set can be targeted by spells that require target to be in caster's party/raid 2012-03-19 20:44:30 +01:00
Machiavelli 41cc704bf8 Core/Movement:
- Don't abort relocation if movementflag restrictions were violated. There might be lag between client and server and even different parts of the core that made this approach improper.
- MOVEMENTFLAG_ROOT cannot be used in conjunction with MOVEMENTFLAG_MASK_MOVING, but it's a valid flag to receive from client.
- Fix falling to ground when unapplying fly/waterwalk aura. NOTE: This is a client-side initiated fall, in the future this should be initiated and updated by the server. (Working on it)
- Rename MOVEMENTFLAG_FALLING to MOVEMENTFLAG_FALLING_FAR
- Rename MOVEMENTFLAG_JUMPING to MOVEMENTFLAG_FALLING

Closes #5751
2012-03-17 20:36:12 +01:00
Shauren 01f3620d45 Core/Movement: Corrected movement info structure written in WriteMovementInfo 2012-03-17 18:01:56 +01:00
Gyx 1e94ab8d51 Core/Game: Code style and remove unused core.
Signed-off-by: Gyx <[email protected]>
2012-03-17 20:13:37 +08:00
Machiavelli cf5ed0a7b6 Core/Movement: Remove MOVEMENTFLAG_FLYING on fly aura unapply as well as _CAN_FLY 2012-03-16 23:41:43 +01:00
Kandera aad4e41ca5 Core/Spells: finish fixing dispel functionality. closes #5745 2012-03-16 17:59:10 -04:00
Machiavelli f8c04b1bc5 Core/Movement: Fix players still able to fly on SPELL_AURA_FLY and SPELL_AURA_MOD_INCREASE_MOUNTED_FLIGHT_SPEED unapply.
Closes #5731
2012-03-16 17:10:01 +01:00
Kandera bea8fcfbfa Core/Spells: fix shield slam giving nothing to dispel error. 2012-03-16 09:08:46 -04:00
kaelima ef53bde176 Core/Spell: Add some missing cast results which require additional data when sent. And rename two researched castflags (thanks TOMRUS) 2012-03-16 08:59:18 +01:00
Kandera b23ff228a4 Core/Spells: Used correct implementation for checking if a spell effect targets an area. 2012-03-15 14:14:42 -04:00
Kandera 5406a0fd93 Core/Spells: Fix bugged mass dispel after previous commits 2012-03-15 14:12:40 -04:00
Kandera fe46cf9796 Core/Spells: Fix being unable to use spells due hasDispellableAura being false if no spell effects were SPELL_EFFECT_DISPEL 2012-03-15 12:41:16 -04:00
Kandera 5e25791bff whitespace cleanup 2012-03-15 11:08:45 -04:00
Kandera 01bc6c483b Core/Spells: add correct checking for dispeling errors. Fixes spammable cleanse. 2012-03-15 10:56:56 -04:00
Shauren 84891377b5 Core/Spells: Fixed copy paste mistake that caused all area spells to search targets starting from caster's coordinates instead of targeted destination 2012-03-15 13:15:25 +01:00
Machiavelli afaed98b7a Core/Movement: Send correct packet to client when unapplying hover, feather fall and water walking auras.
Closes #5704
2012-03-15 10:03:25 +01:00
leak 2a5caef4a6 Revert "Core: more more cleanup" - Build test anyone?
This reverts commit 20cd4c71ee.
2012-03-14 18:51:51 +01:00
thomas33 20cd4c71ee Core: more more cleanup 2012-03-14 17:51:11 +01:00
Machiavelli 03a24a84e4 Core/Units:
- Implement UNIT_FIELD_HOVERHEIGHT (requires DB data). This field, sent in update object packet, will determine the height at which a creature hovers if it has movementflag_hover applied. Note that hovering will now update the server-sided z-coordinate by the value of this field, and that all subsequent positional updates to the client will need to send z coordinate MINUS the hover height offset, or the hoverheight will be visually doubled client side.
- Correct our usage of movementflag_flying, movementflag_can_fly, movementflag_hover and movementflag_disable_gravity (previously levitate), and how they relate to InhabitType in the database. This fixes "flying creatures on steroids" bug (wings flapping too fast), and potentially a lot of visual issues in AI scripts. Note that a lot of scripts still set wrong movementflags, these need to be fixed on a case by case basis.
- Send correct packets for SPELL_AURA_FEATHER_FALL, SPELL_AURA_WATER_WALK and SPELL_AURA_HOVER apply/unapply.
- Send correct packet contents for movement update in Unit::SetSpeed.
- Misc. cleanup in affected scripts.
2012-03-12 00:53:45 +01:00
Machiavelli b1a8570a30 Core/Spells: Fix item target selection in Spell:SelectImplicitTargetObjectTargets. Typo spotted by zwerg 2012-03-11 14:52:11 +01:00
Subv 7c42cd76e4 Core/Conditions: Prevent crash at Spell::CheckCast if Condition::Meets returned prematurely 2012-03-09 17:15:22 -05:00
click a153e0ca06 Core: Remove some whitespace and tabs 2012-03-07 00:05:34 +01:00
QAston a08fe16d69 Core/Spells: Allow spell effects to have multiple destinations. Spells like: 49814, 10869 and similar are now properly selecting destination targets. 2012-03-03 00:19:48 +01:00
QAston e1b544d129 Core/Spells: Remove some obsolete code 2012-03-02 17:57:26 +01:00
Kandera 92af6ec647 Core/Auras: fix stacking for auras that change phase. (thx to manuel) 2012-03-01 13:39:53 -05:00
QAston 8653016bdd Merge pull request #5445 from Souler/fix_demonic_circle
Move Demonic Circle related code to spell_warlock.cpp
2012-02-27 07:15:39 -08:00
Spp d38bc3a178 Core: Rename GetCreatureInfo to GetCreatureTemplate and minor cleanup here and there 2012-02-27 14:58:47 +01:00
Souler 05097c7fc5 Scripts/Spells: Move Demonic Circle mechanics to spell_warlock.cpp 2012-02-26 17:22:27 +01:00
QAston a0de042efe Core/Spells: Remove SpellSelectTargetTypes enum - it's not needed anymore. 2012-02-25 14:07:07 +01:00
QAston b7b37dca29 Core/Spells: send spell error messages on spell cast condition checks. 2012-02-25 11:54:12 +01:00
Shauren dc28b92415 Core: Random cleanup + compile fix 2012-02-23 13:01:16 +01:00
QAston fb5d05c198 Core/Spells: Prevent assertion failure in Spell::SelectImplicitDestDestTargets by setting dest to caster if no dest provided. 2012-02-22 21:06:29 +01:00
Machiavelli fa546d1428 Core/Spells: Change logic in assertion in Spell::SelectImplicitTargetObjectTargets.
Not sure if this a step in the right direction for the intended design, but following the logic of the function there should be OR unit target OR gameobject target OR item target pointers available. If Item target doesn't belong there then the already present AddItemTarget call should be removed.
2012-02-22 19:16:47 +01:00
QAston 7a261ff9b8 Core/Spells: Use right function for obtaining spell target type. Fixes assertion failures. 2012-02-22 10:34:08 +01:00