Commit Graph
33385 Commits
Author SHA1 Message Date
ZenoX92 ddf45f44d3 DB/Creature: Tosamina
Closes #20176

(cherry picked from commit 6621d8fd7bb24b2842fa665e1aef4bff428b3b70)
2020-08-23 16:00:51 +02:00
ccrs 9a5e2b80b3 Core/Creature: regenerate health
There are three possible scenarios regarding regenerating health
- db lock and curhealth set to > 0
- db lock and curhealth set to 0
- dynamic lock (set in scripts and such) overriding db lock

(cherry picked from commit 91c0d49c188977c3d797f5749b1204612ce50195)
2020-08-23 15:56:21 +02:00
ZenoX92 04c974dbc3 DB/Creature: Lil Timmy
Closes #20175

(cherry picked from commit 5f8ee9a01eee5f80d1186b3ff932fe30505eea49)
2020-08-23 15:28:07 +02:00
ZenoX92 dea04f8649 DB/Creature: Zem Leeward
Closes #20174

(cherry picked from commit d3ba34fdeb63a62534b40e9ccbf4a9f8d44dacb8)
2020-08-23 15:02:22 +02:00
Treeston 22b754c9e2 Core/Creature: temporary summons are now dynamic flagged (oversight in dynspawn). This fixes issues with vehicle kit resets breaking AI.
Closes #20137 #20138 #20153.

(cherry picked from commit 92e9376e5eecdc3412104a0ee304d389d4ce0188)
2020-08-23 14:52:51 +02:00
Treeston 2924ae0803 Scripts/Commands: .npc delete and .gobj delete now work while the specified guid is despawned. Fixes #20145.
(cherry picked from commit cac99beffd66218c6cbdd873d4a90461d04b25c4)
2020-08-23 14:47:48 +02:00
Treeston 88a61fa9d6 Scripts/Auchindoun: Fix a super edge case crash bug with GM far teleports during Blackheart's charm phase. Follow-up to d80d7c6.
(cherry picked from commit 165bc028893a1971d4c75b146e3cd3ce92f13982)
2020-08-23 14:47:29 +02:00
Keader 43f76c8cdd Core/Scripts: Updated Razorscale to new registers model
* More codestyle fixes
* Ty sirikfoll :)

(cherry picked from commit 76fc9ed6356ca34a603d4c716d2850b5b15a4164)
2020-08-23 14:44:29 +02:00
Keader 3df7e8b9fb Core/Razorscale: Codestyle Updates
* Removing spelldifficulty_dbc to make portable to master
* Updated to new Spell/Aurascript model

(cherry picked from commit 203c5f705806f6f39a8392c3164ff04fc5415d58)
2020-08-23 14:39:20 +02:00
Foereaper 07e903a23d Scripts/Naxxramas: Fix Heigan the Unclean eruption event (#20129)
By scheduling the eruption event without cancelling the previously registered eruption events, Heigan's eruption (or dance) would overlap and cause a runaway scenario, where eruptions would not follow a proper timer.

By using Reschedule and not locking the Eruption event to the fighting phase, the dance now works as intended.

(cherry picked from commit 6f4492bc61f0883df7dac81ef6235a1cb7299bc7)
2020-08-23 14:35:07 +02:00
Killyana 3fcb592568 DB: Add missing spawns in Wintergarde Mausoleum
(cherry picked from commit c702a1e2505f7f021bb6a6b3e8c0f2bee52e0e33)
2020-08-23 14:21:30 +02:00
Gustavo e5963fda0e Core/Scripts: More fixes in boss Lich King (#20147)
* Core/Scripts: More fixes in boss Lich King

Fix Valkyr charge spell, they will no longer ignore Z position and become unreachable.
Correct height of Spirit Bomb and added the 3 seconds delay on his explosion.
Set the Trigger inside frostmourne room as active, to avoid problems with reseting the room, e.g: Spirit Bombs not despawning and Wicked Spirits stuck in evade.
Use correct InhabitType for Wicked and Vile Spirits, this avoid a situation where they could spawn falling.

(cherry picked from commit 22a7956069c293a3f8eab8adcd84a9f4703f364a)
2020-08-23 01:20:27 +02:00
Demonid fa762826e9 Scripts/Icecrown Citadel: Fixed Lord Marrowgar - Coldflame to not ignore resistances (#20146)
Closes #13240

(cherry picked from commit 7b747848ede0bdb7e12374d3560059ec708e177a)
2020-08-23 01:16:17 +02:00
ccrs 5e39572c06 Core/Movement: 7fff83d6752 followup
since MOTION_SLOT_IDLE cannot be expired, signal path done and behave like IdleMotionGenerator

(cherry picked from commit eb2769996f01bfd7d7118503a44705711eb309a3)
2020-08-23 00:52:05 +02:00
ccrs 138edeb34e Core/AI: add missing checks on AssistPlayerInCombatAgainst
(cherry picked from commit ee5cbf28bc003ecc52347fdd612e27432bd87c24)
2020-08-23 00:49:53 +02:00
ccrs e10018029d Core/SmatAI: correct MoveInLineOfSight
mistake introduced in 15f2706acaa that was masqueraded by other checks in combat start, till recent related commits

(cherry picked from commit d117a0e4d4aa29960c04d09ba90d2d0798a5c1b6)
2020-08-23 00:49:36 +02:00
ccrs 0a133e77d6 Core/Movement: 7fff83d6752 followup
remove home position set from creature PauseMovement, and use it when necessary
change log level on DelayedDelete

(cherry picked from commit cd4775420a4894012616d54467eb3827430245b5)
2020-08-23 00:48:46 +02:00
sirikfoll 7586daad62 Core/Misc: Remove Whitespaces
(cherry picked from commit e2565c2597a72ea7868eef3156014dc3a83c058f)
2020-08-23 00:48:19 +02:00
ccrs 97585597f0 Core/Movement: waypoint movement (#20121)
Following the work done in #19361 this is the cleanup and improvement of the related logic of waypoint management.

Ref 28050f3 #18020
(taking the good parts and ignoring the incomplete work)

(cherry picked from commit 7fff83d67526efff63867d41b9e036a19a9287b3)
2020-08-23 00:45:46 +02:00
tkrokli a86870622d DB/Creature: creature_addon guid without corresponding creature guid
Updates #18542 (TDB 335.63 DBerrors)

(cherry picked from commit 00329fe9a505c437af0b7591d8321bf3b77ad7fb)
2020-08-22 21:27:27 +02:00
Gustavo 6135ee20a9 Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau) (#19897)
* Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau)

Scripted all spells
Corrected behavior of Spectral Blast and Curse of Boundless Agony
Removed wrong wipe behavior
Fix problem where bosses would be stuck with banish
Added Boundaries
Corrected texts
Removed old hacks
Other minor fixes

(cherry picked from commit e9cd7af2dfcb7948f27e83e73398da0086190aab)
2020-08-22 21:13:01 +02:00
Treeston b538cdc129 Core/Creature: Fix a crash in .npc delete (closes #20124). Also fix an issue breaking vehicles in certain edge case situations.
(cherry picked from commit 4cf49614e6e3e4a2da09c0f00404f323ae948590)
2020-08-22 20:52:13 +02:00
ccrs 6209ceddb9 Core/Movement: ee2d7c1d53 followup
(cherry picked from commit 4f43f4d72f10cf1f4e522979f1050e5141c226c2)
2020-08-22 20:50:56 +02:00
ccrs b521bf1d3a Core/Movement: PropagateSpeedChange should only be called on the top (current active) movement generator
(cherry picked from commit 40903dcd65ef2b15efed6a32669c6b659685e7bd)
2020-08-22 20:50:24 +02:00
ccrs 4cf5cb9031 Core/Movement: add new helper that cleans the referenced MovementSlot
(cherry picked from commit ee2d7c1d53986d32779379caf0591d6cde530ead)
2020-08-22 20:49:13 +02:00
Demonid 6130a775fe Scripts/ICC: Minor Fixes for Lich King (#20120)
- Fixed Shadow Trap and Defile Targets
- Fixed Shadow Trap Summon Delay and Duration
- Fixed Berserk Timer (15 Minutes)
- Fixed Shadow Trap Despawn when Snowstorm starts

(cherry picked from commit 9fa68855d7d0d5f37112ce21c919a16ed8724ac2)
2020-08-22 20:48:06 +02:00
Keader a1342bc9fc Core/Scripts: Razorscale Rewrite (#19828)
(cherry picked from commit d825a068300224498a3613299d15a70323af9b73)
2020-08-22 20:46:26 +02:00
tkrokli 99b8221456 DB/Quest: You, Robot (10248): missing progress text + partial RewardText
http://www.wowhead.com/quest=10248/you-robot

- Progress text (quest_request_items) was missing completely (request item: Scrap Reaver X6000 Controller)
- Reward Text (quest_offer_reward.RewardText) had lost '-52 Nether-Rocket from certain doom!' from the end.

(cherry picked from commit f9f5a701f48bbb703658a99d689270d6bd7469c6)
2020-08-22 20:12:23 +02:00
Treeston 129dd7c909 Core/Scripts: dynamic_spawning follow-up, I had forgotten JustRespawned existed.
- Rename JustRespawned to JustAppeared, which better matches its behavior anyway.
- Properly invoke JustAppeared for new (re-)spawns - fixes #20111.
- Fix Thaddius script to work with dynamic_spawning (mostly unrelated to the above) - Feugen/Stalagg should really be a summon group, but I don't have time to fix that right now.
- Fix default value for DynamicEscortNPC to match worldserver.conf.dist.

(cherry picked from commit 184c45cfe0fbe4f3e4fb701f0f99994df98bdc8a)
2020-08-22 20:10:42 +02:00
tkrokli 521a950f9c DB/Quest: A Boaring Time for Grulloc (10721): wrong RewardText content
http://www.wowhead.com/quest=10721/a-boaring-time-for-grulloc
https://wow.gamepedia.com/Quest:A_Boaring_Time_for_Grulloc

- Quest 10721 showed up in-game with the same Reward Text as Quest Description
- quest_template.QuestDescription was inserted as quest_offer_reward.RewardText
- issue also found in https://github.com/dalaranwow/dalaran-wow/issues/1926
- Correct RewardText is based on content from the 3 linked pages above.

(cherry picked from commit dbda060ae7a31135044495470e46276dad0bcc0e)
2020-08-22 20:07:07 +02:00
tkrokli 65567046df DB/Quest: Surveying the Ruins (10335): add missing RewardText, end half
http://www.wowhead.com/quest=10335/surveying-the-ruins

- Another quest_offer_reward.RewardText cut short, missing half of its content.
- Previous: 114 characters. Added: 115 characters. Full text: 229 characters.

(cherry picked from commit 8de9f1c3592e1c988842cedf8f9c6dd32f75ad33)
2020-08-22 20:05:46 +02:00
tkrokli 575e3c87b1 DB/Quest: Invaluable Asset Zapping (10203): add missing RewardText end
http://www.wowhead.com/quest=10203/invaluable-asset-zapping

- Another quest_offer_reward.RewardText cut short, missing ≈33% of its content.
- Previous: 290 characters. Added: 143 characters. Full text: 433 characters.

(cherry picked from commit 61fdbe57f206c42633b94b664b7ca67376cc28a3)
2020-08-22 20:04:44 +02:00
Necropola 5e3170d58e Core/Pet: Fix an issue that was causing lower ranks of pet spells to remain in DB (#20112)
(cherry picked from commit ecf59786085cb8750bf48bbfa4f4f3d49b924dbd)
2020-08-22 20:02:34 +02:00
Aokromes ed4788190d Revert permision change
(cherry picked from commit 92359de5ef1aea170f7f7ead0da092a8cb1b1fbc)
2020-08-22 13:59:28 +02:00
tkrokli c053cc1b04 DB/Quests: Terokkar Forest quest text typos
Fixed the following typos:
- 'Clues in the Thicket' (9971) RewardText typo (Is it was/Is it what)
- `An Unseen Hand` (10013) RewardText typo (duplicated words "it to me")
- 'Evil Draws Near' (10923) Progress typo (ben/been)

(cherry picked from commit 446ea121271c77407429368e5491a84eef7fc19b)
2020-08-22 13:59:09 +02:00
Necropola 885e172f4d [3.3.5] Core/Pet: Make pet action bar autocast persist properly (#20110)
Partial revert of of 6c21ddd9b98d372cb802c9abf034e2aa3ecc70b9.
Closes #16211.

(cherry picked from commit 906498e9f4d80ff10094cd3f365b310d9dec4521)
2020-08-22 13:55:11 +02:00
Treeston d5a9461e26 DB/InstanceSpawn: More low-hanging fruit - Ruby and Obsidian Sanctum.
(cherry picked from commit 70a48ff182aa3c01152dad6302aa043b5555558a)
2020-08-22 13:54:38 +02:00
Treeston a7baefeadb DB/InstanceSpawn: The easy ones. Gruul's Lair, Magtheridon's Lair, Onyxia's Lair, Eye of Eternity.
(cherry picked from commit fd9a93b45e9839e8f22b3572c16b16c32fcd771e)
2020-08-22 13:52:45 +02:00
Treeston 608c9aaabf Scripts/InstanceScript: Implement database framework for managing spawn groups based on boss state. (#20103)
(cherry picked from commit 84590be26d6b3c56b95a804cbe889826186dd8a2)
2020-08-22 13:48:44 +02:00
Treeston acb4934f76 Core/Unit: Don't apply liquid effects to game masters.
(cherry picked from commit 2644fa703a6b20b6f1d62360fb47bc719cf43933)
2020-08-22 13:35:46 +02:00
Shauren 50a64ccd1e Core/Misc: Revert back to using boost::regex, std::wregex doesn't work for name validation
Closes #20094

(cherry picked from commit 6691e41873f255c0f303229b0bd2e5db77a3c879)
2020-08-22 13:21:55 +02:00
Treeston f15b4f5043 Scripts/Commands: Fix some quirkiness and potential crashes with live DB modification commands (npc move and npc delete), which are horrible and should be deleted anyway.
Fixes #20104.

(cherry picked from commit 759357049cdbe9a2f97bbab6e61299cd65ba1bec)
2020-08-22 13:16:34 +02:00
Treeston 703910d71b Scripts/Commands: New utility command: .list spawnpoints.
(I just needed it for dynspawn follow-up work, really.)

(cherry picked from commit fcd6fe0aac0b906e2cf8e2379d94a7d73384c160)
2020-08-22 13:11:34 +02:00
r00ty-tc 03b125e6d1 Dynamic Creature/Go spawning:
- True blizzlike creature spawn/respawn behavior - new creature = new object
 - Toggleable spawn groups (with C++/SAI/command options to use them)
 - Custom feature: dynamic spawn rate scaling. Accelerates respawn rate based on players in the zone.
 - Backward compatibility mode (set via group and for summons)
   to support creatures/gos that currently don't work well with this
   (this should be removed once the exceptions are fixed)

Fixes and closes #2858
Tags #8661 as fixable.
Fixes and closes #13787
Fixes #15222.

(cherry picked from commit 59db2eeea0a35028779fd76372ae06cc98c8086f)
2020-08-22 12:59:57 +02:00
jackpoz bf5be28396 Core/Misc: Fix static analysis issues
Fix various coverity reported issues

(cherry picked from commit 925557d1c097cd45311b38dc3a9c715579456980)
2020-08-21 23:13:13 +02:00
Treeston 42c65c3bc2 Core/Chat: Provide a fully-formed protocol for addons to interact with GM commands (#20074)
Send success/fail state, allow interleaving, and indicate end of output. Add framework for supporting non-human-readable output in commands.

(cherry picked from commit 508c9d2fc1b20dc2cb40df533e823e1dfe2becc3)
2020-08-20 00:49:52 +02:00
Treeston e69b5d8fcc Scripts/IcecrownCitadel: Prevent players from becoming inaccessible when killed by Lord Marrowgar's Impale spell (the initial damage, not the DoT). Also fix the underlying bug in vehicle logic.
(cherry picked from commit 7cbb6c101e975a046b95aeb5dd68d75d016f67a5)
2020-08-20 00:21:37 +02:00
ccrs 9757a2992a Core/AI: correct Permit level for trigger flagged creatures
This broke several mechanics such as LK hc Frostmourne Room or Rotface's slime, how come no one noticed it? Like really, no one?
ref ce3787f190d28c1e981598eef2cd24c622a2cbae

(cherry picked from commit 1de89579c75f7b5d5028b162334fa496832a093c)
2020-08-20 00:20:03 +02:00
Treeston e5836dcc1a Core/Unit: No code change, just updating a comment with insights gleaned from sniffs.
(cherry picked from commit f2f45765e408cbba49e15ea642a1ed052c751bcf)
2020-08-20 00:19:23 +02:00
Treeston e6be53d141 Core/WorldObject: Properly initialize position data for all types when initially creating them. Fixes some issues with PvP objectives not having the correct area ID set on initialization. Closes #20028.
(cherry picked from commit 28b3469e89f89a8c87fad06bad27800939abf0f5)
2020-08-20 00:18:48 +02:00