Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.
(cherry picked from commit 2f92a2f58e171bbfa6dc06d3b2663cbf384a7d38)
Conflicts:
src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet(), IsTotem(), IsSummon(), IsGuardian(), IsHunterPet() and IsVehicle() from Creature to Unit
(cherry picked from commit ea4d9c0d9e3339c96b94f13bbbfc1318bb6b03f9)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Unit/Unit.cpp
src/server/scripts/Spells/spell_pet.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet() from Creature to Unit
(cherry picked from commit d243630acff017f5e50bf0c833a0bbac35ba6c5a)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Spells/Spell.cpp
src/server/game/Spells/SpellEffects.cpp
Fix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj
(cherry picked from commit 5f0f152345ec7e9cc6195ba8f59f316a1cad90f7)
The log is triggered when a mage creates a portal to another map, uses it and then the portal despawns.
(cherry picked from commit a8ceb18cdfe850fbb84ddd3d917565f2a100ebb7)
Conflicts:
src/server/game/Entities/GameObject/GameObject.cpp
The "error" is a false positive happening every time a player in a Battleground logs out because WorldSession::LogoutPlayer() notifies the bg twice
(cherry picked from commit ca5a2785f760a90ceb0c3d321da208ee07552f87)
Fix a rare case that would cause SPELL_EFFECT_NORMALIZED_WEAPON_DMG to do 4 billions damage or to trigger an assertion in Unit::CalculateDamage() depending by Unit base damage.
To reproduce the issue cast spell 25816 on a level 1-14 warrior, then make the warrior cast spell 694 on a Creature.
(cherry picked from commit 143026ed19455f5a908ef508d1bf5ce43c092a21)
Apply an exponential formula to define the chance to bid/buyout an auction depending on auction price and item price ratio. The formula can be adjusted changing the new AuctionHouseBot.Buyer.ChanceFactor config parameter
Chance = 100 ^ (1 + (1 - (auction_price / item_price) / k)
k is the config parameter AuctionHouseBot.Buyer.ChanceFactor, the higher the number the higher chance to buy overpriced auctions.
(cherry picked from commit 177b6319d1ad49a38fbd06f37671da1e3d1ae4e6)
Conflicts:
src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
Addition to a328a119784252c6d514436f4ceffa693ac65453 , clamp object size to [0,4] in case of very huge Creatures like Lord Marrowgar entry 36612
(cherry picked from commit 0a94382637ba9212a23e224b4ac2df114acb4ca7)
* Updated segment distance calculations - now selected path fully matches clientside preview
* Fixed building sOldContinentsNodesMask to also include any new taxi node added in future
* Implemented filtering possible hops when searching for shortest path by faction (and in future PlayerCondition)
* Changed ObjectMgr::GetNearestTaxiNode to filter faction nodes by flags instead of mount display
* Use dijkstra algorithm instead of astar to match client behavior
* Properly exclude special taxi nodes from the graph
* Corrected initial death knight nodes to only include destinations for their faction
jackpoz