Gyx
1e94ab8d51
Core/Game: Code style and remove unused core.
...
Signed-off-by: Gyx <[email protected] >
2012-03-17 20:13:37 +08:00
Machiavelli
cf5ed0a7b6
Core/Movement: Remove MOVEMENTFLAG_FLYING on fly aura unapply as well as _CAN_FLY
2012-03-16 23:41:43 +01:00
Kandera
aad4e41ca5
Core/Spells: finish fixing dispel functionality. closes #5745
2012-03-16 17:59:10 -04:00
Machiavelli
f8c04b1bc5
Core/Movement: Fix players still able to fly on SPELL_AURA_FLY and SPELL_AURA_MOD_INCREASE_MOUNTED_FLIGHT_SPEED unapply.
...
Closes #5731
2012-03-16 17:10:01 +01:00
Kandera
bea8fcfbfa
Core/Spells: fix shield slam giving nothing to dispel error.
2012-03-16 09:08:46 -04:00
kaelima
ef53bde176
Core/Spell: Add some missing cast results which require additional data when sent. And rename two researched castflags (thanks TOMRUS)
2012-03-16 08:59:18 +01:00
Kandera
b23ff228a4
Core/Spells: Used correct implementation for checking if a spell effect targets an area.
2012-03-15 14:14:42 -04:00
Kandera
5406a0fd93
Core/Spells: Fix bugged mass dispel after previous commits
2012-03-15 14:12:40 -04:00
Kandera
fe46cf9796
Core/Spells: Fix being unable to use spells due hasDispellableAura being false if no spell effects were SPELL_EFFECT_DISPEL
2012-03-15 12:41:16 -04:00
Kandera
5e25791bff
whitespace cleanup
2012-03-15 11:08:45 -04:00
Kandera
01bc6c483b
Core/Spells: add correct checking for dispeling errors. Fixes spammable cleanse.
2012-03-15 10:56:56 -04:00
Shauren
84891377b5
Core/Spells: Fixed copy paste mistake that caused all area spells to search targets starting from caster's coordinates instead of targeted destination
2012-03-15 13:15:25 +01:00
Machiavelli
afaed98b7a
Core/Movement: Send correct packet to client when unapplying hover, feather fall and water walking auras.
...
Closes #5704
2012-03-15 10:03:25 +01:00
leak
2a5caef4a6
Revert "Core: more more cleanup" - Build test anyone?
...
This reverts commit 20cd4c71ee .
2012-03-14 18:51:51 +01:00
thomas33
20cd4c71ee
Core: more more cleanup
2012-03-14 17:51:11 +01:00
Machiavelli
03a24a84e4
Core/Units:
...
- Implement UNIT_FIELD_HOVERHEIGHT (requires DB data). This field, sent in update object packet, will determine the height at which a creature hovers if it has movementflag_hover applied. Note that hovering will now update the server-sided z-coordinate by the value of this field, and that all subsequent positional updates to the client will need to send z coordinate MINUS the hover height offset, or the hoverheight will be visually doubled client side.
- Correct our usage of movementflag_flying, movementflag_can_fly, movementflag_hover and movementflag_disable_gravity (previously levitate), and how they relate to InhabitType in the database. This fixes "flying creatures on steroids" bug (wings flapping too fast), and potentially a lot of visual issues in AI scripts. Note that a lot of scripts still set wrong movementflags, these need to be fixed on a case by case basis.
- Send correct packets for SPELL_AURA_FEATHER_FALL, SPELL_AURA_WATER_WALK and SPELL_AURA_HOVER apply/unapply.
- Send correct packet contents for movement update in Unit::SetSpeed.
- Misc. cleanup in affected scripts.
2012-03-12 00:53:45 +01:00
Machiavelli
b1a8570a30
Core/Spells: Fix item target selection in Spell:SelectImplicitTargetObjectTargets. Typo spotted by zwerg
2012-03-11 14:52:11 +01:00
Subv
7c42cd76e4
Core/Conditions: Prevent crash at Spell::CheckCast if Condition::Meets returned prematurely
2012-03-09 17:15:22 -05:00
click
a153e0ca06
Core: Remove some whitespace and tabs
2012-03-07 00:05:34 +01:00
QAston
a08fe16d69
Core/Spells: Allow spell effects to have multiple destinations. Spells like: 49814, 10869 and similar are now properly selecting destination targets.
2012-03-03 00:19:48 +01:00
QAston
e1b544d129
Core/Spells: Remove some obsolete code
2012-03-02 17:57:26 +01:00
Kandera
92af6ec647
Core/Auras: fix stacking for auras that change phase. (thx to manuel)
2012-03-01 13:39:53 -05:00
QAston
8653016bdd
Merge pull request #5445 from Souler/fix_demonic_circle
...
Move Demonic Circle related code to spell_warlock.cpp
2012-02-27 07:15:39 -08:00
Spp
d38bc3a178
Core: Rename GetCreatureInfo to GetCreatureTemplate and minor cleanup here and there
2012-02-27 14:58:47 +01:00
Souler
05097c7fc5
Scripts/Spells: Move Demonic Circle mechanics to spell_warlock.cpp
2012-02-26 17:22:27 +01:00
QAston
a0de042efe
Core/Spells: Remove SpellSelectTargetTypes enum - it's not needed anymore.
2012-02-25 14:07:07 +01:00
QAston
b7b37dca29
Core/Spells: send spell error messages on spell cast condition checks.
2012-02-25 11:54:12 +01:00
Shauren
dc28b92415
Core: Random cleanup + compile fix
2012-02-23 13:01:16 +01:00
QAston
fb5d05c198
Core/Spells: Prevent assertion failure in Spell::SelectImplicitDestDestTargets by setting dest to caster if no dest provided.
2012-02-22 21:06:29 +01:00
Machiavelli
fa546d1428
Core/Spells: Change logic in assertion in Spell::SelectImplicitTargetObjectTargets.
...
Not sure if this a step in the right direction for the intended design, but following the logic of the function there should be OR unit target OR gameobject target OR item target pointers available. If Item target doesn't belong there then the already present AddItemTarget call should be removed.
2012-02-22 19:16:47 +01:00
QAston
7a261ff9b8
Core/Spells: Use right function for obtaining spell target type. Fixes assertion failures.
2012-02-22 10:34:08 +01:00
QAston
2a1ffc1cd9
Core/Spells: Fix a typo in f09b5a6bea - call right function for target dest case.
...
Closes #5357
2012-02-22 10:21:02 +01:00
Spp
1e246cb66c
Fix build (gcc) and fix warnings
2012-02-22 09:15:57 +01:00
QAston
f09b5a6bea
Core/Db/Conditions:
...
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required
Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
click
dce3bc01ac
Core: Fix non-PCH building
2012-02-19 16:57:07 +01:00
QAston
9abc47736f
Core/Spells: Changes in code related to spell explicit target redirection (cleanups, added target validation, prevent unexpected behaviour in some cases)
2012-02-19 00:40:55 +01:00
click
5411e1ce52
Core: Clean up whitespace and tabs in the base sourcetree
2012-02-18 16:52:08 +01:00
Kandera
c517806a23
Scripts/Spells: Convert code from Spell::EffectDummy to spell scripts.
2012-02-18 12:12:49 +01:00
Subv
b3f729274a
Core/Spells: Fixed an error in the logic of the AuraEffect constructor, thanks @A-Metaphysical-Drama for noticing
2012-02-17 17:19:23 -05:00
QAston
cd3ed111c9
Core/Spells: Fix recently broken feral spirit and force of nature. Closes #5278 .
2012-02-17 11:45:21 +01:00
kaelima
7ce7853606
Core/Spells: Revert part of 65d269f6de. Solves some recent instant spell casting issues.
2012-02-16 20:38:48 +01:00
QAston
0d5ae5784c
Core/Spells: Make channeled auras stackable by default with other auras.
2012-02-16 17:14:32 +01:00
Spp
03c34ee507
Fix a lot of warnings
2012-02-16 13:56:28 +01:00
leak
1b506c18ee
Core/Spells: Remove pointless check
2012-02-15 17:06:31 +01:00
Shauren
65d269f6de
Core/Spells: Allow dead players as valid objects for RaiseDeadObjectCheck (enables Raise Dead on players that have not yet released spirit)
...
TODO: Allow all corpses
2012-02-15 00:46:08 +01:00
Subv
7d30b061f0
More compiler error fixes
2012-02-14 14:06:31 -05:00
Subv
d55126aacb
Core/Spells: Revert erroneous interruption added in 5ea49613d2 - more research required
2012-02-14 13:14:51 -05:00
Subv
8a72aede16
Codestyle: Renamed some variables to fit codestyle, corrected order in structure/class fields to match alignment (they use slightly less memory now)
...
Signed-off-by: Subv <[email protected] >
2012-02-14 12:46:26 -05:00
Subv
5ea49613d2
Core/Spells: Spell casts should be interrupted if the target goes out of LoS.
...
Signed-off-by: Subv <[email protected] >
2012-02-12 15:30:16 -05:00
Subv
ff9830c18d
Core/Spells: Blink wont be able to trespass solid objects anymore (walls/doors)
...
Refactored some code
Signed-off-by: Subv <[email protected] >
2012-02-11 19:23:18 -05:00