QAston
94126e0369
Core/Spells: Fix some talents with incorrect target entries in dbcs. This is an alternative fix for #2848 . Closes #2846 Closes #2848 .
2011-09-06 11:21:40 +02:00
QAston
fab78d5e02
Scripts/Vault of Archavon: Earth, Wind & Fire achievement - by idostyle@zoit, with some spell attribute correction to the patch by me.
2011-09-03 21:16:12 +02:00
QAston
81a841ed20
Database/Spells: Add AttributesEx6 and AttributesEx7 columns to spell_dbc table.
2011-09-03 21:05:26 +02:00
QAston
ddacd0de94
Core/Spells: Fix pick lock - thanks to cyberbrest for pointing the reason of this issue.
2011-09-03 20:16:15 +02:00
QAston
f31e676199
Fix build after recent pull merges.
2011-09-03 18:07:27 +02:00
QAston
df19a0c31f
Correct sql file naming for b40bf69319.
2011-09-03 17:49:53 +02:00
QAston
dc01541111
Merge pull request #2852 from Chaplain/cleanup2
...
Core/Misc: Cleanup - remove unused variables, add some const modifiers to functions, fix process of args in vmap3_extractor
2011-09-03 08:34:02 -07:00
QAston
82e7b11df1
Merge pull request #2778 from KoffeinKaio/master
...
Fixed spellid's from Zul'Gurub encounters High Priest Thekal and Bloodlord Mandokir (&adds).
2011-09-03 08:27:37 -07:00
QAston
d23b03271d
Merge pull request #2777 from KoffeinKaio/fishing
...
Core/Spells: Fixed fishing bobber landing angle.
2011-09-03 07:52:47 -07:00
QAston
7871ead798
Merge pull request 'Fix quest New Recruit(13143) & Fix quest King of the Mountain(13280&13283)' from Kiperr/TrinityCore
2011-09-03 16:44:05 +02:00
QAston
414f048bd5
Merge pull request #2735 from hacknowledge/fix_2734
...
Core/Spells: Fixes ammo consumption for Hunter's Volley
2011-09-03 07:29:31 -07:00
QAston
0ba79e0078
Merge pull request: The Val'kyr Twins Clean up and Implements from 'Drethek/master'
2011-09-03 16:26:49 +02:00
QAston
68037cdc3c
Scripts/Commands: Allow c++ style comments in opcode.txt file for .debug send opcode command.
2011-09-01 10:46:15 +02:00
QAston
71b9e0d8de
Core/Spells: Make mind sear aoe no longet target unit at which caster is channeling the spell.
2011-09-01 09:07:14 +02:00
QAston
f16520fa25
Merge pull request #2838 from wonopon/patch-7
...
Rotface should only cast Mutated Infection on one player.
2011-08-31 14:34:38 -07:00
QAston
534ca8e23f
Merge pull request #2821 from Chaplain/cleanup2
...
Core/Misc: Cleanup
2011-08-31 11:33:26 -07:00
QAston
048ae9cfab
Merge pull request #2792 from wonopon/patch-6
...
Scripts/Taldaram: Make the boss cast Bloodthirst on self instead of on victim.
2011-08-31 11:31:11 -07:00
QAston
ac9701afa7
Merge pull request #2762 from Kapoeira/master
...
Core/Spells: Prevent deterrance from parrying spells that require the attacker to be behind the hunter, like Shred or Ambush.
2011-08-31 11:24:45 -07:00
QAston
d863562507
Core/Spells: Make core be a little less strict about some spell attributes SPELL_ATTR0_CASTABLE_WHILE_DEAD and SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS checks.
2011-08-30 00:13:53 +02:00
QAston
2f79241237
Core/Spells: check unattackable flag only for negative spells.
2011-08-29 23:26:47 +02:00
QAston
8754166071
Core/Spells: Send expected type of spell implicit target to client.
2011-08-27 12:59:57 +02:00
QAston
751cbaf307
Core/Spells: Fix a typo (!GetDst() instead of !HasDst()) which prevented from automatical lconverion of spell unit target to destination target (this is only used in script casts). Closes #2761 .
2011-08-26 16:30:56 +02:00
QAston
79427354aa
Fix build. Damn.
2011-08-26 15:40:11 +02:00
QAston
265c909666
Core/Spells: small correction to e2d592f380, don't interrupt passive auras.
2011-08-26 14:43:19 +02:00
QAston
e2d592f380
Core/Spells: Interrupt periodic trigger auras when triggered spells fails to cast. Closes #2598
2011-08-26 14:23:23 +02:00
QAston
2ee88d76da
Core/Spells: remove one obsolete spell proc target check.
2011-08-26 12:48:12 +02:00
QAston
8e392440cf
Core/Spells: Fix a regression of 7f30ac5a95 - spells with TARGET_SELECT_CATEGORY_CHANNEL target type (like mind sear) should be triggered by triggering spell caster
2011-08-26 12:39:50 +02:00
QAston
5c48d9ec8a
Core/Spells: Store explicit unit, corpse and GO targets in one variable, because both client and server can't handle more than one explicit object target; Add spell explicit target validation.
2011-08-26 12:06:13 +02:00
QAston
dfa179b427
Scripts/Achievement: fix a typo.
2011-08-25 13:16:09 +02:00
QAston
5ebb4ba4c1
Core/Packets: Update opcodes enum - research by TOM_RUS, also remove some useless/obsolete comments from opcodes.h
2011-08-25 12:48:51 +02:00
QAston
c0f3122b9c
Fix build after revert.
2011-08-25 08:01:56 +02:00
QAston
188fdb3e4c
Core/Spells: Allow spells with TARGET_FLAG_CORPSE to target players which didn't hit release button yet.
2011-08-25 06:51:57 +02:00
QAston
62d913bb35
Revert "Core/Spells: Also Death Runes itself should be able to turn into a Death Rune. They should not turn back into their original rune when using a spell that turns the used runes into Death Runes." - it is causing crashes.
...
This reverts commit 17b89ea8ab .
2011-08-25 06:40:56 +02:00
QAston
fd500ba257
Fix build after last pull request merge.
2011-08-24 19:36:20 +02:00
QAston
7ae8f15985
Merge pull request #2582 from hacknowledge/fix_2531
...
Core/Spells Disables environmental damage to players which are not attackable by AOE damage
2011-08-24 10:03:10 -07:00
QAston
b69330676d
Merge pull request #2588 from hacknowledge/fix_2488
...
Crashfix. Added missing check for NULL of victim parameter
2011-08-24 10:02:26 -07:00
QAston
7a3b1f1ed5
Core/Spells: Make GMs and vehicle riders not attackable by AOE again.
2011-08-24 18:22:33 +02:00
QAston
5cd4f9e513
Core/Spells: fix TARGET_DEST_TARGET_* targets after 7f30ac5a95
2011-08-24 10:35:41 +02:00
QAston
1178cee836
Core/Spells: Small correction to: 7f30ac5a95 - TARGET_DEST_TRAJ targets should require both src and dst target provided.
2011-08-24 08:53:26 +02:00
QAston
7f30ac5a95
Core/Spells: Add a generic way of selecting spell explicit targets. Make explicit targets independant of calling convention in core - this makes targets sent to client to be much more blizzlike than before (for example CastSpell(Unit*) won't set TARGET_FLAG_UNIT for spells which are not using explicit unit target) for SMSG_SPELL_START packets. Also remove hacks, which became obsolete with this commit.
2011-08-24 08:08:33 +02:00
QAston
9f7a557c05
Merge pull request #2721 from Chaplain/cleanup
...
Core: Clean up here and there.
2011-08-23 21:01:54 -07:00
QAston
5819cb084f
Merge pull request #2715 from elecyb/diminish
...
Core/Spells: Fix duration of some spells in PvP
2011-08-23 21:01:35 -07:00
QAston
5ef9f7dd1c
Merge pull request #2728 from Kapoeira/master
...
Core/Spells: Fixed Survival of the Fittest armor increase bonus while in Dire Bear or Bear form.
2011-08-23 21:00:34 -07:00
QAston
0365feb069
Core/Entities: Make dead units not targetable for attack again (after fc5e924138).
2011-08-23 14:47:26 +02:00
QAston
e7468b2e2c
Core/Spells: Do not apply spellmods to spells with SPELL_ATTR3_NO_DONE_BONUS attribute.
2011-08-23 14:30:26 +02:00
QAston
738214f8e5
Core/Spells: add some const modifiers to functions, fixes build.
2011-08-21 13:57:15 +02:00
QAston
c453d78b07
Core/Spells: Fix mind controll after recent target requirement changes.
2011-08-21 13:01:37 +02:00
QAston
0a7c622305
Db: remove command no longer present in scripts - thanks Whiroph.
2011-08-21 13:01:36 +02:00
QAston
3476767eb0
Fix warnings from merged pull requests.
2011-08-21 11:59:06 +02:00
QAston
0946843875
Merge pull request #2682 from Fredi/clean
...
Core/AI: Cleaning up hungarian notation
2011-08-21 01:04:08 -07:00
QAston
396a2e588b
Merge pull request #2678 from Kapoeira/master
...
Core/Spells: Fixed Heart of the Wild stamina and attack power bonus part.
2011-08-21 01:00:00 -07:00
QAston
8e8fa083b2
Merge pull request #2636 from LihO/master
...
Core/Auras: Check amount of total ticks to avoid division by zero (and crash) in Unit::GetRemainingPeriodicAmount.
2011-08-21 00:58:55 -07:00
QAston
a10eb53598
Merge pull request #2672 from Chaplain/master
...
Core/Spell: case TOTAL_PCT\BASE_PCT should be processed by multiplicative function not additive.
2011-08-21 00:54:14 -07:00
QAston
edb1f1d436
Core/Spells: Don't check triggered flags for SPELL_ATTR0_CASTABLE_WHILE_DEAD attribute check - triggered spells have this flag set correctly - fixes problems with auras triggering spells for dead casters while they shouldn't.
2011-08-21 09:39:53 +02:00
QAston
a76f023002
Core/Spells: remove one now obsolete check which prevents spells with SPELL_ATTR6_CAST_BY_CHARMER from being cast.
2011-08-20 13:14:47 +02:00
QAston
b838aad7d0
Core/Spells: check UNIT_FLAG_OOC_NOT_ATTACKABLE only for AOE spells targeting enemies, fixes some interactions with npcs.
2011-08-20 12:08:37 +02:00
QAston
919a8ecf0e
Core/Spells: Allow to explicitly target crowd controlled targets for spells with SPELL_ATTR6_CANT_TARGET_CROWD_CONTROLLED (Shield of Righteousness for example).
2011-08-20 11:45:23 +02:00
QAston
511db66297
Core/Spells: Remove some duplicate checks from Spell::CheckPetCast
2011-08-20 10:23:28 +02:00
QAston
b0602b3153
Core/Spells: Use spell target flags to determine if spell can target dead targets - fixes skinning. Also, fix build once again
2011-08-20 10:01:57 +02:00
QAston
580a68573f
Core/Spells: fix a crash.
2011-08-20 09:49:18 +02:00
QAston
cf4e19cf4b
Fix GCC build.
2011-08-20 09:32:19 +02:00
QAston
03f3a2a636
Core/SpellScripts: Add possibility to access real damage/healing done by SpellScript from AfterHit hooks.
2011-08-20 00:45:34 +02:00
QAston
e2d8faea09
Core/Spells: move Cannibalize and Carrion Feeder cast checks to SpellScripts.
2011-08-20 00:30:38 +02:00
QAston
e8240fbc02
Fix a typo in last commit.
2011-08-19 16:34:26 +02:00
QAston
393b436a0c
Fix a typo in last commit.
2011-08-19 16:34:00 +02:00
QAston
fc5e924138
Core/Spells: Implement recently discovered target check attributes and move most of target checks to SpellInfo::CheckTarget function.
2011-08-19 14:54:15 +02:00
QAston
dc3a3772ba
Merge pull request #2617 from Chaplain/master
...
Core/Spells: Fixed exploit found in 9936921206 .
2011-08-18 03:03:00 -07:00
QAston
1de095f7cf
Core/Spells: Add required and implicit target object type data for spell effects - will be used in future patches.
2011-08-18 11:50:31 +02:00
QAston
ec95ead0ac
Fix build.
2011-08-17 12:00:20 +02:00
QAston
a44e1c505e
Core/Spells: Add new spell implicit target categories data - will be used in future patches.
2011-08-17 11:30:47 +02:00
QAston
a3fc4e897c
Core: Add missing forward declarations in SpellInfo.h
2011-08-16 20:08:13 +02:00
QAston
a077a26aa5
Core/Spells: update the core to the changes from 1fb1988d46 . To make your custom code work with those changes simply lookup the value of Targets enum value from prev rev, and update the name in your code.
2011-08-16 19:44:18 +02:00
QAston
1fb1988d46
Core/Spells: change Targets enum to use consistent naming schema. This is not a functional change, but it's needed for upcoming changes, also this makes target type research and use easier.
2011-08-16 19:42:36 +02:00
QAston
d4b90d1f86
Core/Spells: Remove OriginalVictim parameter from Unit::CastSpell(x,y,z) - setting unit target was enough for all spells which used it, there's never a need to cast with both unit and dest target on retail (in such cases unit target + DEST_TARGET target types are used).
2011-08-16 16:53:29 +02:00
QAston
73bbc3aca8
Core/Spells: Update some targeting related attribute definitions to make them more clear and consistent.
2011-08-16 16:06:21 +02:00
QAston
e0d43388af
Core/Spells: define SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS and SPELL_ATTR6_CAN_TARGET_INVISIBLE (big thanks to joschiwald for the second one)
2011-08-16 15:11:07 +02:00
QAston
961b2629c5
Merge pull request #2593 from fredi/clean
...
Core/Account: Code style and cleanups in AccountMgr
2011-08-16 04:47:31 -07:00
QAston
9936921206
Merge pull request #2580 from hacknowledge/damagemodfix
...
Core/Spells: Fixed weapon dependent damage mods for players as well as au
2011-08-16 03:41:23 -07:00
QAston
b81fb4d423
Core/Spells: Rename SPELL_ATTR2_ALWAYS_APPLY_MODIFIERS to SPELL_ATTR2_DISPLAY_IN_STANCE_BAR, and make auras to be recalculated when permament instead of using that wrongly defined flag.
2011-08-11 23:11:10 +02:00
QAston
0d1a5314dc
Core/Spells: Define some new attributes: SPELL_ATTR6_ONLY_CAST_WHILE_POSSESSED, SPELL_ATTR6_DONT_DISPLAY_COOLDOWN, SPELL_ATTR5_ALLOW_TARGET_OF_TARGET_AS_TARGET, SPELL_ATTR4_AREA_TARGET_CHAIN, SPELL_ATTR3_DONT_DISPLAY_RANGE
2011-08-11 23:03:43 +02:00
QAston
df87f00e73
Core/Commands: Add .cast dest #spellid #x #y #z which orders selected unit to cast a spell at selected destination.
2011-08-06 22:50:46 +02:00
QAston
db28ae55c9
Core/Spells: Add missing braces to possession spell check - fixes problems with being unable to cast target's spells while possesing.
2011-07-31 11:13:41 +02:00
QAston
1df57ae522
Core/Spells: Don't allow passive area auras to stack.
2011-07-30 02:02:35 +02:00
QAston
c9291243c1
Core/Spells: Remove some obsolete code (stealth is no longer a ranked spell).
2011-07-29 18:01:33 +02:00
QAston
41593a79e3
Core/Spells: Check if spell has range entry before trying to access property (some spell do not) - fixes a crash.
2011-07-29 00:01:08 +02:00
QAston
fe913bf66c
Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura) - this time without additional changes (argh!)
2011-07-28 23:45:57 +02:00
QAston
495ead5f7f
Revert "Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura)"
...
This reverts commit 07badd7385 .
2011-07-28 23:44:39 +02:00
QAston
07badd7385
Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura)
2011-07-28 23:41:29 +02:00
QAston
045dec19fa
CoreSpells: Typofixes: fix area auras autocast and usage of items in combat.
2011-07-28 13:21:31 +02:00
QAston
f33a0c23ca
Core/Spells: Fix passive auras stacking logic after recent changes.
...
Closes #2417
2011-07-28 03:08:42 +02:00
QAston
7094f57841
Core/Spells: Don't unload sSpellStore on startup, to allow access to dbc strings.
2011-07-28 02:03:47 +02:00
QAston
4c8c0ce193
Core/Spells: Use correct spell target in Spell::EffectEnvirinmentalDMG - fixes area damage of spells using this.
2011-07-27 21:23:15 +02:00
QAston
46851c3fda
Core/Spells: Drop obsolete code for Demonic Sacrifice.
2011-07-27 20:37:28 +02:00
QAston
b0fe236265
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
...
*SpellEntry is now SpellInfo
*GetSpellProto is now GetSpellInfo
*SpellEntry::Effect*[effIndex] is now avalible under SpellInfo.Effects[effIndex].*
*sSpellStore.LookupEntry is no longer valid, use sSpellMgr->GetSpellInfo()
*SpellFunctions from SpellMgr.h like DoSpellStuff(spellId) are now: spellInfo->DoStuff()
*SpellMgr::CalculateEffectValue and similar functions are now avalible in SpellEffectInfo class.
*GET_SPELL macro is removed, code which used it is moved to SpellMgr::LoadDbcDataCorrections
*code which affected dbc data in SpellMgr::LoadSpellCustomAttr is now moved to LoadDbcDataCorrections
2011-07-26 23:09:28 +02:00
QAston
29c228a801
Core/Spells: Add SpellInfo class to store static data and methods for spells. This class is going to replace SpellEntry use in core. SpellInfo class includes all spell-related functions which resided in SpellMgr, and makes them much easier to access, reuse or add new stuff. Another advantage is that you no longer have to lookup db/dbc data by entry or index, because such data can now be included in the new class. Thanks to that, TC will have no problems on drastic spell dbc format change in 4.x.
2011-07-26 23:00:23 +02:00
QAston
f35d8c9bc4
Core/Spells: Temporary workaround for Summon Eye of Acherus (this time working)
2011-07-16 08:03:36 +02:00
QAston
5f565709cf
Core/Auras: Correct display stackable aura amount in client when aura has 1 stack.
2011-07-13 20:57:11 +02:00
QAston
f70875510a
Core/Spells: Drop unrelated manaCostPct check from Spell::EffectPowerBurn and use explicit check instead, fixes some power burn spells.
2011-07-13 20:39:17 +02:00
QAston
b9413f08b3
Core/Spells: Define and implement attributes SPELL_ATTR1_CANT_BE_REDIRECTED and SPELL_ATTR1_CANT_BE_REFLECTED, fixes some problems with Grounding Totem and Spell Reflection.
2011-07-13 20:14:55 +02:00
QAston
7b2cf3d1f2
Core/Spells: Fix a typo (thanks to tobmaps for catching)
2011-07-13 17:31:09 +02:00