Commit Graph
1220 Commits
Author SHA1 Message Date
QAston 8e392440cf Core/Spells: Fix a regression of 7f30ac5a95 - spells with TARGET_SELECT_CATEGORY_CHANNEL target type (like mind sear) should be triggered by triggering spell caster 2011-08-26 12:39:50 +02:00
QAston 5c48d9ec8a Core/Spells: Store explicit unit, corpse and GO targets in one variable, because both client and server can't handle more than one explicit object target; Add spell explicit target validation. 2011-08-26 12:06:13 +02:00
Spp- 85164d2876 Core: Some cosmetic changes and minor optimizations 2011-08-26 09:41:33 +02:00
Lopin cc8609950a Core/Misc, Killed some engrish 2011-08-25 10:24:44 +02:00
Lopin 8ce77c7d83 Core/Logs: Fixed a crash 2011-08-25 10:12:32 +02:00
QAston c0f3122b9c Fix build after revert. 2011-08-25 08:01:56 +02:00
QAston 62d913bb35 Revert "Core/Spells: Also Death Runes itself should be able to turn into a Death Rune. They should not turn back into their original rune when using a spell that turns the used runes into Death Runes." - it is causing crashes.
This reverts commit 17b89ea8ab.
2011-08-25 06:40:56 +02:00
QAston fd500ba257 Fix build after last pull request merge. 2011-08-24 19:36:20 +02:00
QAston 7ae8f15985 Merge pull request #2582 from hacknowledge/fix_2531
Core/Spells Disables environmental damage to players which are not attackable by AOE damage
2011-08-24 10:03:10 -07:00
QAston b69330676d Merge pull request #2588 from hacknowledge/fix_2488
Crashfix. Added missing check for NULL of victim parameter
2011-08-24 10:02:26 -07:00
Lopin 87d3cb6a10 Core/Logs: Fixed a typo in one log. Thanks RA3OR for notice 2011-08-24 17:01:50 +02:00
Lopin 0c410bda43 Core/Logs: Added some more log informations to certain logs 2011-08-24 13:37:05 +02:00
QAston 0365feb069 Core/Entities: Make dead units not targetable for attack again (after fc5e924138). 2011-08-23 14:47:26 +02:00
Shauren 5f6c6d3925 Core/Auras: Implemented SPELL_AURA_PREVENT_RESSURECTION 2011-08-21 12:42:22 +02:00
QAston 3476767eb0 Fix warnings from merged pull requests. 2011-08-21 11:59:06 +02:00
QAston 8e8fa083b2 Merge pull request #2636 from LihO/master
Core/Auras: Check amount of total ticks to avoid division by zero (and crash) in Unit::GetRemainingPeriodicAmount.
2011-08-21 00:58:55 -07:00
QAston a10eb53598 Merge pull request #2672 from Chaplain/master
Core/Spell: case TOTAL_PCT\BASE_PCT should be processed by multiplicative function not additive.
2011-08-21 00:54:14 -07:00
Chaplain 4b56226619 Core/Spell: case TOTAL_PCT\BASE_PCT should be processed by multiplicative function not additive.
Also get ride of hack in Player::HandleBaseModValue now it's unnecessary.
Fixes: #855, multiplicative % count for normal school for aura 79 and may be others.
2011-08-20 13:38:20 +03:00
QAston b838aad7d0 Core/Spells: check UNIT_FLAG_OOC_NOT_ATTACKABLE only for AOE spells targeting enemies, fixes some interactions with npcs. 2011-08-20 12:08:37 +02:00
QAston e2d8faea09 Core/Spells: move Cannibalize and Carrion Feeder cast checks to SpellScripts. 2011-08-20 00:30:38 +02:00
tobmaps cd03dadb7f Core/Misc: Minor code cleanup and code style fix 2011-08-20 04:43:01 +07:00
tobmaps e1e91bacbe Core/Spells: Prevent apply spell power coefficients at bonus given by some "taken" damage mods
Closes #1991
2011-08-20 03:06:15 +07:00
Lopin f94bd733e3 Core/GameObject: Fixed build on Linux 2011-08-19 21:09:12 +02:00
Lopin 8166e338ad Core/Logs: Added some useful informations to certain logs, part #1. Requested by Aokromes 2011-08-19 19:17:39 +02:00
QAston fc5e924138 Core/Spells: Implement recently discovered target check attributes and move most of target checks to SpellInfo::CheckTarget function. 2011-08-19 14:54:15 +02:00
LihO 171049bf4a Core/Auras: Crash fix.
Check amount of total ticks to avoid division by zero.
2011-08-18 18:18:44 +02:00
QAston dc3a3772ba Merge pull request #2617 from Chaplain/master
Core/Spells: Fixed exploit found in 9936921206.
2011-08-18 03:03:00 -07:00
Ramus cfef963092 Fix Item - Shaman T10 Restoration 4P Bonus 2011-08-18 13:27:22 +07:00
Lopin 9e9a84cf0e Core/Events: Fixed items removing from World Events. The items will be removed on first player's login after the end of the event. Also prevents using those items between the end and login of the player 2011-08-17 18:47:34 +02:00
Chaplain 2233018f52 Core/Spells: Fixed exploit found in 9936921206.
When we count twice multipliar for spells with SPELL_SCHOOL_MASK_NORMAL.
Also now it will show correct data in character info like damage reduction % from defence stance in warrior case.
Also fixed some minor logic issues.
2011-08-17 16:11:38 +03:00
QAston d4b90d1f86 Core/Spells: Remove OriginalVictim parameter from Unit::CastSpell(x,y,z) - setting unit target was enough for all spells which used it, there's never a need to cast with both unit and dest target on retail (in such cases unit target + DEST_TARGET target types are used). 2011-08-16 16:53:29 +02:00
QAston 73bbc3aca8 Core/Spells: Update some targeting related attribute definitions to make them more clear and consistent. 2011-08-16 16:06:21 +02:00
QAston 9936921206 Merge pull request #2580 from hacknowledge/damagemodfix
Core/Spells: Fixed weapon dependent damage mods for players as well as au
2011-08-16 03:41:23 -07:00
Machiavelli 826ec0582a Core/GameObject: Fix GameObject::Use log error message 2011-08-15 15:41:06 +02:00
Machiavelli b560090692 Core/GameObject: Fix interaction distance with GameObjects in all corner cases by overriding Object:_IsWithinDist. Distance calculation to GO's need to take in account GameObjectDisplayInfoDBC entries, otherwise distance would not be calculated from the edges properly and ie. quest interaction with large gameobjects would fail. 2011-08-15 14:09:20 +02:00
hacknowledge c0326e3170 Crashfix. Added missing check for NULL of victim parameter 2011-08-14 21:51:52 +02:00
hacknowledge 1aa4e7bd57 converted tab to spaces 2011-08-14 00:00:19 +02:00
hacknowledge 78ca3ad5d2 Core/Spells Disables environmental damage to spirit of redemption form of priest
Core: Added check for AOE attackability to environmental damage
Fixes #2531
Reduced check for environmental damage to whether unit is attackable by AOE. check for GM and death state is included in this check

Fixes #2531
2011-08-13 23:58:33 +02:00
hacknowledge 0c500486f3 Core/Spells: Fixed weapon dependent damage mods for players as well as autohit damage mods for NPCs and pets. This fixes also meta sockel effects. Also fixed displaying the correct values in the char info. I also took care of applying and unapplying the weapon based damage mods when the player is being disarmed and equips/unequips his weapon.
Fixes #178, #418, #1276, #259 and possible a few other issues.
2011-08-13 23:26:16 +02:00
tobmaps 54cf7f28d2 Core/Misc: Fix some typos in af040fc18d 2011-08-13 20:53:24 +07:00
leak af040fc18d Core/Players: Allow players to answer gamemaster whispers even if whispers are disabled. Whitelist can be reset by .whispers off 2011-08-13 15:10:45 +02:00
Shauren f03ef48b3e Core/Object: Removed incorrect code (never affected anything) 2011-08-13 11:44:51 +02:00
idostyle@zoit 93238fe6c3 Core/Players: Corrected faction id check for RepObjectiveFaction2 2011-08-13 11:40:45 +02:00
idostyle@zoit 8c411ffa42 Spell: Mark of the Fallen Champion
Forcing gcc to use the right overloaded function here.
2011-08-12 05:01:31 +02:00
Fest c1f0833672 Core/ReferAFriend : fix strange grantableLevels value in DB 2011-08-11 17:42:02 +02:00
tobmaps 4ce345a9f9 DB/Loot: Fix max count of items from Titanium Ore prospecting loot 2011-08-09 06:14:07 +07:00
Machiavelli beaca1bd34 Fix build 2011-08-07 21:58:35 +02:00
Machiavelli 2d3f51e6e5 Core/Spells: Fix Shaman talent Nature's Guardian and rewrite fix for fc52f08. Fixes some spells not triggering. 2011-08-07 21:19:27 +02:00
Machiavelli 3109d9c0ae Core/Spells: Spells that can be spellstolen that have a permanent duration should respect the 2 minute spellsteal buff duration limit. 2011-08-07 17:49:02 +02:00
Machiavelli 04c2f2929e Core/Player: Fix item refund exploit 2011-08-07 15:57:26 +02:00