Commit Graph
100 Commits
Author SHA1 Message Date
click 61d6397559 Core/Buildsystem: Adjust the variable so it works on MSVC9 again (danged MS and renaming variables)
--HG--
branch : trunk
2010-12-20 02:54:04 +01:00
leak 4c9cfa6739 Core/Buildsystem: Resolved quoting problem that caused gcc to spam warnings. Patch by click.
--HG--
branch : trunk
2010-12-20 02:23:55 +01:00
Machiavelli 33808ab567 Core/Spells: Fix Improved Spirit Tap proc from Mind Flay crits.
Author: Dr.Tenma
Fixes issue #2786

--HG--
branch : trunk
2010-12-20 01:58:15 +01:00
Machiavelli f71c97f6c5 Core/Items: Fix ITEM_SPELLTRIGGER_ON_NO_DELAY_USE (5). This trigger should (only) trigger the respective spell when the item is added to the inventory. Aura´s created by this spell will be properly removed when the item is destroyed as well.
--HG--
branch : trunk
2010-12-20 00:46:00 +01:00
Machiavelli baff745be1 Core/Spells: Fix Improved Felhunter mana energize part.
Based on code by Karolis.Rudzevicius
Fixes issue #2125
Fixes issue #2109

--HG--
branch : trunk
2010-12-20 00:35:11 +01:00
Shauren 85d69dc73d Scripts/Spells: Explicitly remove all other auras with the same id when applying Animal Blood (46221)
--HG--
branch : trunk
2010-12-19 20:03:56 +01:00
QAston 251f7f2121 Core/Auras: Add some assertions to make sure that AuraEffects are not added twice to UnitAuraEffect containers.
--HG--
branch : trunk
2010-12-19 19:43:53 +01:00
Machiavelli 60ce3fdbd2 Core/DBLayer: Add MySQL errno´s 1058 and 1062 (related to query-correctness) to handled errno´s (=doesn´t require further actions from the core)
--HG--
branch : trunk
2010-12-19 18:01:06 +01:00
Machiavelli 5e826806ba Core/Aura´s: Remove a redundant NULL check, because QAston saideth so.
--HG--
branch : trunk
2010-12-19 17:50:50 +01:00
Machiavelli cbbcfa03f3 Core/DBLayer: Minor padding/alignment optimization in struct Field::data (16b->10b)
--HG--
branch : trunk
2010-12-19 17:48:47 +01:00
leak ff3dc410ed Typo in recent commit
--HG--
branch : trunk
2010-12-19 17:14:54 +01:00
leak fd694cd232 Streamlining loading functions for server startup
- Added a couple of timer outputs
- Improved code consistency between loading functions
- Progess bars should look and behave similar on all OS now (sLog.outString() is not needed anymore to replace the progress bar in log files)

--HG--
branch : trunk
2010-12-19 17:06:33 +01:00
click 9c35e10444 Core:DBLayer: Fix warning on GCC
--HG--
branch : trunk
2010-12-19 16:29:51 +01:00
Machiavelli dfd82c2fad Core/DBLayer: Use mysql_set_character_set in MySQLConnection::Open instead of explicit string queries
Also possibly fix an absolutely useless warning on GCC

--HG--
branch : trunk
2010-12-19 16:13:45 +01:00
Machiavelli e2a8dfffbe Core/DBLayer:
- Add generic HandleMySQLErrno() method.
- Add the ability to re-execute a certain statement if errorhandler resolved the situation succesfuly.
- Add support for MySQL errno´s 2006, 2013, 2048, 2055 - fixes automatic reconnection behaviour.
- Cleanup in affected code

NOTE: You should still be smart enough to configure your worldserver and authserver´s MaxPingTime to be lower than your MySQL´s wait_time.

--HG--
branch : trunk
2010-12-19 15:48:55 +01:00
Shauren 14a480cb13 Core/Players: Fixed recently introduced crashes in Player::ApplyEnchantment
Closes issue #5193.

--HG--
branch : trunk
2010-12-19 15:22:19 +01:00
Shauren c35947816c Scripts/Trial of the Crusader: Fixed possible crashes in announcer gossip
Closes issue #3850.

--HG--
branch : trunk
2010-12-19 14:46:13 +01:00
Shauren a4f437a523 Core/GameObject: Dismount the player when using spellcaster gameobject
Closes issue #2539.

--HG--
branch : trunk
2010-12-19 11:56:37 +01:00
linencloth 59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
linencloth 22928e23bd Core: Replace spell attribute defines with enums
--HG--
branch : trunk
2010-12-19 04:11:44 +01:00
linencloth 2fbbcc477c Core/InstanceSaveMgr: Cleanup for better readability
--HG--
branch : trunk
2010-12-19 01:23:36 +01:00
linencloth 4193806dba Core/InstanceSaveMgr: Prevent timer underflow by passing resetTime instead of timeLeft
--HG--
branch : trunk
2010-12-19 00:59:04 +01:00
Machiavelli 837e50ea23 Core/Spells: Allow aura´s with SPELL_AURA_MOD_THREAT (10) to properly reduce threat modifiers on death.
Inspired by effort of james.gml
Fixes issue #3444

--HG--
branch : trunk
2010-12-19 00:38:35 +01:00
Shauren 8d76329eff Scripts/Temple of Ahn'Qiraj: Its generally not a good idea to delete stuff before using it; fixed crash
Closes issue #4357.

--HG--
branch : trunk
extra : rebase_source : b829284f60e2b55f8e79db72751252cc6619e59a
2010-12-19 00:27:38 +01:00
linencloth 12e046e45e Core/InstanceSaveMgr: Replace some queries with executes as the result isn't needed
(thanks to Machiavelli for the idea and for spotting these forgotten lines)

--HG--
branch : trunk
2010-12-19 00:04:27 +01:00
Shauren 43377b4daf Core/Players: Remove player from transport before teleporting to graveyard, will fix infinite recursion when trying to access unavailable map
Core/Auras: Removed unneeded typecasting

Closes issue #4862.

--HG--
branch : trunk
2010-12-19 00:01:22 +01:00
linencloth a8214a682a Core/InstanceSaveMgr: Optimize instance packing and cleaning up
--HG--
branch : trunk
2010-12-18 23:43:44 +01:00
linencloth 454444a1af Core/MovementGenerators: Remove evade state when HomeMovementGenerator gets destroyed without finishing the movement
--HG--
branch : trunk
2010-12-18 23:01:42 +01:00
Machiavelli a093408360 Core/Player: Convert _SaveAuras to prepared statement format
--HG--
branch : trunk
2010-12-18 23:25:03 +01:00
Shauren 7196b880d6 Core/Spells: Fixed possible crashes in Shadow's Fate proc (71169) introduced in r91073dc6ace3
Core/AuctionHouse: Removed "using namespace std" and fixed crash in AuctionHouseMgr destructor

Closes issue #5132.
Closes issue #5134.

--HG--
branch : trunk
2010-12-18 23:16:55 +01:00
Shauren 3ad400ad1a Scripts/Obsidian Sanctum: Removed unneeded code causing crashes
Closes issue #5191.

--HG--
branch : trunk
2010-12-18 22:22:25 +01:00
silinoron f339ced1bf merge
--HG--
branch : trunk
2010-12-18 13:07:15 -08:00
silinoron 41a9d3216c Core/Auras: Fix Cold Blood handling on misses and parries.
Patch by dr.tenma.
Fixes issue #2291

--HG--
branch : trunk
2010-12-18 13:06:38 -08:00
Shauren 24193966dd Core/Auras: Fixed crash in AuraEffect::TriggerSpell (dummy effect) and removed some useless code
Scripts/AI: Changed sOnDummyEffect to return bool value

Closes issue #5190.

--HG--
branch : trunk
2010-12-18 22:04:19 +01:00
Supabad 8ce0abbbc8 Scripts/Obsidian Sanctum Add support for when encounter is in progress. thnx to kiper
--HG--
branch : trunk
2010-12-18 18:07:24 +01:00
click e75d16b813 Core/Dependencies: Adjust jemalloc library caching methods - this will fix the startup-crash on linux-based systems.
Note: This is a temporary measure untill we've figured out why this occurs, further testing will be done.

--HG--
branch : trunk
2010-12-18 16:14:08 +01:00
Machiavelli 535d81db4b Core/Social: Really show correct count (matches + displayed) in SMSG_WHO now (switch position of 2 numbers).
--HG--
branch : trunk
2010-12-18 16:09:50 +01:00
leak 525a1e0ff0 Core/Entities: Remove gem bonuses if requirements of prismatic sockets are not met
Closes issue 4949.

--HG--
branch : trunk
2010-12-18 15:56:55 +01:00
leak 04e4561134 Prevent completing quests by packet manipulation
--HG--
branch : trunk
2010-12-18 15:29:11 +01:00
Machiavelli 57132e35b8 Core/Spells: Fix spells 59915 and 59906 / Discerning Eye of the Beast and Swift Hand of Justice (Heirloom trinkets)
Fixes issue #2435
Fixes issue #2529

--HG--
branch : trunk
2010-12-18 12:27:40 +01:00
click 785d5a94a6 Core/Dependencies: Update jemalloc library from v1.0.0 to v2.1.0 (latest stable)
--HG--
branch : trunk
2010-12-18 02:31:10 +01:00
click 0054bd83d8 Buildsystem/Linux: Fix linking of a long lost little child : jemalloc (yes, it has returned, and is now actively linked again)
--HG--
branch : trunk
2010-12-18 01:36:00 +01:00
Shauren 4a067d5095 Fixed build i broke
--HG--
branch : trunk
2010-12-17 20:48:55 +01:00
Shauren ecd2fbb2b1 Scripts/Vault of Archavon: Cleaned and simplified scripts, fixed Toravon's Frozen Orb summon count
Closes issue #2857.

--HG--
branch : trunk
2010-12-17 20:37:20 +01:00
Machiavelli 32d94ed52a Core/Units: Aura´s of type SPELL_AURA_MOD_RESISTANCE_EXCLUSIVE (143) should stack with eachother in the way that only the strongest aura of each magical school applies.
Author: Iskander
Fixes issue #3897

--HG--
branch : trunk
2010-12-17 20:31:46 +01:00
click 97f912fe93 Core/Pets: Use the safer pet level check-method in SynchronizeLevelWithOwner() too (forgotten in previous commit)
--HG--
branch : trunk
2010-12-17 20:27:36 +01:00
click 0785ad465b Core/Pets: Clean up logic/codedesign slightly for XP/levelup-handling, and also fix a possible overflow in the pet level-tests
(Thanks to Vladimir for the discussion regarding the possible overflow!)

--HG--
branch : trunk
2010-12-17 20:08:27 +01:00
Machiavelli e867481ccb Fix a typo in 52d8bc05c3
--HG--
branch : trunk
2010-12-17 19:27:09 +01:00
Shauren 3df2310417 Core/Auras: Fixed Festive Holiday Mount transformation (3.0.8 update)
--HG--
branch : trunk
2010-12-17 19:03:12 +01:00
Shauren 21f6248726 Core/Spells: Fixed diminishing returns for positive/event spells, patch by DrTenma
--HG--
branch : trunk
2010-12-17 18:21:37 +01:00
Shauren b11e5bbf81 Core/Achievements: Prevent ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL updates at login
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL_AT_AREA
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_TEAM_RATING
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_REACH_TEAM_RATING
Core/Achievements: Implemented map id requirement for achievement criterias

Closes issue #4479.
Closes issue #4478.
Closes issue #4473.
Closes issue #4472.
Closes issue #4471.
Closes issue #4480.
Closes issue #2284.
Closes issue #4481.

--HG--
branch : trunk
2010-12-17 18:12:46 +01:00
Machiavelli 1cdeb4d057 Core/Player: Change equipmentset saving to use prepared statements.
Update issue #4550
Please try to re-reproduce

--HG--
branch : trunk
2010-12-17 17:29:16 +01:00
Machiavelli d38b171391 Core/DBLayer: CharacterDB query CHAR_LOAD_PLAYER_ACTIONS_SPEC should be synchronous. Fixes a crash introduced in bd30ad7bd3
--HG--
branch : trunk
2010-12-17 16:54:38 +01:00
Machiavelli 0a8c99e02c Core/Social: Fix SMSG_WHO. Packet should contain number of players matching given criteria + number of players displayed, instead of total number of players online + number of players displayed.
Fixes issue #4886

--HG--
branch : trunk
2010-12-17 16:36:01 +01:00
Machiavelli 8a196ba4b0 DB/Commands: Add some missing entries to commands table.;
Author: svetilo12
Closes issue #5015

--HG--
branch : trunk
2010-12-17 16:06:47 +01:00
Machiavelli 04e5be6276 Core/DBLayer: Add some garbage collection on DatabaseWorkerPool shutdown (deleting SQLOperation objects)
--HG--
branch : trunk
2010-12-17 16:02:09 +01:00
Machiavelli cb08ec0d74 Core/DBLayer: Don´t prepare asynchronous statements on synchronous connections and vice versa. Prevents allocating RAM that will never be used.
--HG--
branch : trunk
2010-12-17 15:55:16 +01:00
Machiavelli 57d72fa708 Core/Scripts: Prevent double call to mob_acolyte_of_shadronAI::Reset() which applies encounter-related aura´s to certain creatures. Reset() was called from AIM_Initialize and prior to that the AI factory selector
Update issue #5152
Please try to re-reproduce

--HG--
branch : trunk
2010-12-17 14:58:23 +01:00
Spp fa6f2ee9d9 Core/Dungeon Finder: Fix typo, debug msg was supposed to be logged to debug (not error)
--HG--
branch : trunk
2010-12-17 13:45:41 +01:00
Shauren 82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
Spp ee3fd3ebeb Core/Vehicles: Fix facing adjustment. Patch by beberlescaraber
closes issue #1810
updates issue #4714

--HG--
branch : trunk
2010-12-17 13:22:17 +01:00
Spp a47150abb3 Core: Fix non-PCH build
--HG--
branch : trunk
2010-12-17 08:54:15 +01:00
click 0c6750dd52 Core: Fix a memoryleak in LoadCreatureFormations() - thanks to ge0rg (again)
--HG--
branch : trunk
2010-12-17 05:05:17 +01:00
click a7f3548259 Core: Prevent using uninitialized memory in Lazy Peon script - patch by ge0rg
--HG--
branch : trunk
2010-12-17 05:03:25 +01:00
click a6df53bbe2 Core/Spells: Fix erraneous behaviour on hunter spell Lock and Load (disable charge-drop) - thanks to Dr. Tenma
Closes issue 3307

--HG--
branch : trunk
2010-12-17 04:52:17 +01:00
click a3de6e7c6f Core/Dependency: Update gSoap to v2.8.0 - this should also fix some issues when connecting with Axis framework (needs to be tested)
+ Update packagelist to include correct versions of what we have in repository

--HG--
branch : trunk
2010-12-17 01:04:12 +01:00
Machiavelli 5d887159c6 Core/Spells: Fix Power Word: Shield absorb amount after r5badab6d42.
(casting TotalAuraMultiplier to int32 effectively meant setting amount to 0)

--HG--
branch : trunk
2010-12-16 23:16:14 +01:00
Anubisss 942dadc6a9 Correctly fix my change (r10666 / 672c38da05).
Kudos go to QAston.

--HG--
branch : trunk
2010-12-16 19:23:58 +01:00
Anubisss b702bd8987 This not needed too, correctly checked with UpdateVictim().
--HG--
branch : trunk
2010-12-16 18:13:03 +01:00
Anubisss 6d9029c12e Make some cleanup.
My thank goes to Az@zel for the code analysis.

--HG--
branch : trunk
2010-12-16 18:08:23 +01:00
Machiavelli bb7bd9ef45 Core/Spells: Fix a possible crash in spell_hun_readiness_SpellScript
--HG--
branch : trunk
2010-12-16 16:00:56 +01:00
Spp 4671500172 Core/Dungeon Finder: Move all LFG data from Player and Group classes to internal LFG data classes.
--HG--
branch : trunk
2010-12-16 10:53:21 +01:00
Spp 451a6f40d4 Core/Dungeon Finder: Use full guid of players instead of lowguid
Note: This change is done in preparation of other changes that will come later.

--HG--
branch : trunk
2010-12-16 04:20:22 +01:00
Shauren 1bc9b905f6 Scripts/Icecrown Citadel: Removed WIP leftovers
--HG--
branch : trunk
2010-12-15 16:39:23 +01:00
Shauren 2db0c7c017 Scripts/Icecrown Citadel: Festergut's Gas Spore and Vile Gas should not happen at the same time
--HG--
branch : trunk
extra : rebase_source : dbb903afbfbfdee5c2c3ae0be7181508e0eca1b2
2010-12-15 16:36:59 +01:00
Machiavelli ad13cd89b5 Core/Items: Fix item duration saving (and loading at a later stage).
--HG--
branch : trunk
2010-12-15 15:00:52 +01:00
Spp 382fef1958 Core: Some warning fixes
--HG--
branch : trunk
2010-12-15 10:44:06 +01:00
azazel ddf06c086e Core/Social: properly remove deleted character from social list of online players (by Emtec)
--HG--
branch : trunk
2010-12-15 14:44:41 +06:00
azazel 0fdea34a8a Core/Items: fix error in saving item's enchantments introduced in rev 022f3858fc (thanks Shauren for spotting the problem)
--HG--
branch : trunk
2010-12-15 14:44:02 +06:00
azazel 23e3909221 Core/Arena: avoid arena match loss when leaving queue before actual invitation to match (by VladimirMangos)
--HG--
branch : trunk
2010-12-15 14:25:10 +06:00
azazel b39b8fdd0d DB Schema/Characters: removed columns auctionhouse.item_template, character_inventory.item_template, guild_bank_item.item_entry and mail_items.item_template and created item_instance.itemEntry column instead of them.
As a side effect moved related queries to prepared statements.
As one more side effect fixed not shown and lost mail items in returned expired mail (patch by Quriq14).

--HG--
branch : trunk
2010-12-15 14:08:12 +06:00
Shauren 58a9b15443 Core: Fixes some warnings
Core/SmartAI: Fixed DamageTaken and DamageDealt hooks

--HG--
branch : trunk
extra : rebase_source : 062f1c68cd1d318d192b294a493db17a1943bee2
2010-12-14 22:45:23 +01:00
Machiavelli 80494d8f64 Core/DBLayer: Fix a possible crash in ProcessQueryCallback functions.
Closes issue #5095

--HG--
branch : trunk
2010-12-14 20:16:09 +01:00
click 300e37fef7 Docs: Add a small info about how to report compilation errors, AND inform how to properly "hunt" for the error.
--HG--
branch : trunk
2010-12-14 19:34:19 +01:00
Machiavelli 3b0297f912 Core/CharacterHandler: Fix ¨[ERROR] GetUInt32() on non-numeric field¨ on a certain query.
Author: toshik.777
Closes issue #5068

--HG--
branch : trunk
2010-12-14 19:14:54 +01:00
Shauren 9a806e63c1 Fixed compile
--HG--
branch : trunk
2010-12-14 16:31:01 +01:00
Shauren 314376e32c Scripts: Fixed uninitialized variables, unreferenced parameters and virtual overrides
--HG--
branch : trunk
2010-12-14 16:24:59 +01:00
Shauren f4581f67b8 Core: Fixed uninitialized variable warnings
--HG--
branch : trunk
2010-12-14 15:58:45 +01:00
Shauren 0c04b178db Scripts/Icecrown Citadel: Minor adjustments and compile warning fixes
--HG--
branch : trunk
2010-12-14 15:46:54 +01:00
Liberate 6be8446053 Core/Gameobjects: Fix fishing and looting specific chests which were bugged because of revision 044e466d75.
Fixes issue #5116.

--HG--
branch : trunk
2010-12-14 15:02:42 +01:00
click 48b234022f Core: Change HandleEjectPasenger to HandleEjectPassenger (English thank you)
--HG--
branch : trunk
2010-12-14 14:09:14 +01:00
Liberate 09f4eb9e1c Core/Gameobjects: Make a chest not lootable when it still has a respawn time, to avoid cheating using third-party software.
--HG--
branch : trunk
2010-12-14 03:58:59 +01:00
click 2d8e73fab5 Core: Fix up opcode-mess from previous commit, and move CMSG_DECLINE_CHANNEL_INVITE handling to its correct opcode (0x0410)
(Please report back any findings of erranous behaviour to the tracker, or into this commit)

--HG--
branch : trunk
2010-12-14 02:23:28 +01:00
click 2642894342 Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.

--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
Spp 89a33bbf61 Core/Dungeon Finder: Fix a crash in Join when there are no dungeons available for that group (And probably other random crashes that appear when having DF enabled)
Core/Dungeon Finder: Tab2spaces + remove trailing spaces in LFG* files.

Notes to self:
- assign NULL to a pointer parameter will not change the pointer value outside the scope of the function
- deleting a const_iterator can lead to mem corruption

--HG--
branch : trunk
2010-12-13 21:31:55 +01:00
Spp 865f35a637 Core/Dungeon Finder: Minor optimization in handler code
Note: LfgDungeonSet and LfgLockStatusMap were being used without using the existing typedef (to avoid including LFGMgr.h).
Now those functions use a struct as param that is forward declared so still LFGMgr.h is not needed and redefinition of LfgDungeonSet/LfgLockStatusMap is removed.

--HG--
branch : trunk
2010-12-13 21:28:36 +01:00
Spp 9815847511 Core/Dungeon Finder: Return a copy of cached dungeons set (to avoid being cleared later in code)
--HG--
branch : trunk
2010-12-13 21:28:33 +01:00
click 620cde80cd Core: Fix non-PCH build
--HG--
branch : trunk
2010-12-13 17:44:20 +01:00
Machiavelli d5f5fa59ab Add missing declarations as of recent merge
--HG--
branch : trunk
2010-12-13 17:34:27 +01:00
Machiavelli 451159cac4 Fix possible compile error under linux
--HG--
branch : trunk
2010-12-13 17:21:06 +01:00