josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
13,472 Commits 1 Branch 0 Tags
60efe048a51e01eac87bafca05068567b25e85f3
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
QAston 8dd88fa43c Core/Spells: fix a typo which caused to display unneeded error message (invalid target) during cast of some spells (like warrior charge). 2011-09-28 18:59:55 +02:00
QAston 5f043e6291 Core/Spells: Bring back workaround removed in cd7060c65a - it's needed for compatibility with some scripts. 2011-09-27 22:04:26 +02:00
QAston 7fa2a64290 Merge branch 'master' of https://github.com/Chaplain/TrinityCore 2011-09-27 19:19:25 +02:00
QAston ee2af420e7 Merge pull request #3235 from Chaplain/cleanup 
Core/Spell: Hymn of Hope fix.
 2011-09-27 10:11:35 -07:00
QAston 23ba776767 Core/Entities: use Unit::GetReactionTo in Unit::IsFriendlyTo and Unit::IsHostileTo 2011-09-27 01:29:20 +02:00
QAston 75aeb15e90 Core/Spells: Allow AOE spells to hit stealthed targets. 2011-09-27 01:13:32 +02:00
QAston a409cc226c Core/Spells: Fix Vanish's stealth trigger and Demonic Empowerment's invisibility trigger 
Those spells were failing to pass default effect trigger spell due to their custom implementation (changing triggered_spell_id instead of adding serverside spells with proper targeting).
 2011-09-27 00:36:23 +02:00
QAston a2633bf7fc Scripts: fix spell_generic_quest_update_entry script after e949ad3adb. 2011-09-27 00:12:45 +02:00
QAston 210a770958 Core/Spells: Fix totem passive area auras stacking bug. 2011-09-25 19:00:37 +03:00
QAston e949ad3adb Core/Spells: spell effect handling improvements 
* Call spell effect handlers in 4 modes:
   - SPELL_EFFECT_HANDLE_LAUNCH - called when spell is launched (cast just finished)
   - SPELL_EFFECT_HANDLE_LAUNCH_TARGET - called when spell is launched for each target in spell target map
   - SPELL_EFFECT_HANDLE_HIT - called when spell hits its destination
   - SPELL_EFFECT_HANDLE_HIT_TARGET - called when spell hits it's target from spell target map
*Correctly implement SPELL_EFFECT_TRIGGER_SPELL, SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL
*Remove spell system hacks which became obsolete with this commit
Core/SpellScripts:
add OnEffectLaunch, OnEffectLaunchTarget, OnEffectHit, OnEffectHitTarget hooks for new effect handle modes and remove OnEffect hook.
A generic rule of thumb how to update your scripts (will work for nearly all cases) for spell system noobs:
if your spell script used GetHitXXXX function, you need to use OnEffectHitTarget, otherwise use
OnEffectHit
 2011-09-25 13:29:50 +02:00
QAston cd7060c65a Core/Spells: Add more generic overload for Unit::CastSpell function and make all cast functions use it as a base. 2011-09-24 16:41:50 +02:00
QAston d01a761f53 Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead. 2011-09-24 02:02:39 +02:00
QAston 71bbbaa21b Merge pull request #3146 from Havenard/fix0001 
Reimplement WorldObject::IsInBetween() to work as intented.
 2011-09-23 06:04:17 -07:00
QAston 413b542cd9 Add a tempfix for trigger missile spell effects after rev 13a1d90130. 2011-09-23 13:09:31 +02:00
QAston 13a1d90130 Core/Spells: Improvements in selecting default targets based on effect type. 2011-09-23 11:58:40 +02:00
QAston 29fef71137 Merge pull request #2915 from idostyle/armorPen 
Core/Mechanics: Cap armorPen to maxArmorPen - prevents having armor penetration rating greater than 100%.
 2011-09-22 02:03:14 -07:00
QAston a0030ef334 Really fix build (sorry for that:() 2011-09-21 11:06:31 +02:00
QAston 87d9a1d384 Scripts/TwinValkyr: Fix build. 2011-09-21 10:40:11 +02:00
QAston 1881765540 Correct names of todays update SQLs. 2011-09-21 10:37:49 +02:00
QAston e2e784e7ea Merge pull request #3086 from LihO/master 
Core/Groups: Refactored sending of update packets.
Closes #1042.
 2011-09-21 01:05:53 -07:00
QAston d628145d95 Merge pull request #3143 from megamage/master 
Threat manager. Fix crashes #2396 and #2992.
 2011-09-21 01:03:53 -07:00
QAston 82bc917265 Merge pull request #2908 from Drethek/TwinsValk 
Scripts:
Twins Valk - Cleanup / Remove Hardcoded Bullet Spawn (Need DB Support - Stalkers Spawns)
Acidmaw - Use Correct Submerge Spell
Trial Of Crusader - Correct Coordinate Spawn
Trial Of Crusader - Correct Open/Close Main Door Timer
Trial Of Crusader - Open/Close On Boss EnterEvadeMode
 2011-09-21 00:27:20 -07:00
QAston 8c2e58d036 Core/Entities: Allow 2 side parties to work. 2011-09-17 13:45:07 +02:00
QAston a2d9aabbb3 Core/Entities: Allow creatures to attack players while in sanctuary. 2011-09-17 01:50:53 +02:00
QAston fe25ce4fa3 Core/AI: Replace many Unit::IsHostileTo with Unit::IsValidAttackTarget or Creature::canCreatureAttack. 2011-09-17 00:56:59 +02:00
QAston 580264b5a5 Core/Entities: Remove obsolete function Unit::canAttack. 2011-09-16 23:51:01 +02:00
QAston c0b1823524 Core/Entities: Replace Unit::canAttack usage with more accurate Unit::IsValidAttackTarget 2011-09-16 23:49:31 +02:00
QAston 3a3f2d927f Core/Misc: Whitespace and a minor typo fix (thanks Kapoeira) 2011-09-16 22:37:49 +02:00
QAston 9bbb4ef583 Core/Spells: Use Unit::IsValidAttack/AssistTarget functions to validate spell explicit targets. 2011-09-16 22:17:49 +02:00
QAston 31e755c291 Core/Entities: Add Unit::IsValidAssistTarget and Unit::IsValidAttackTarget functions for proper serverside checks of related entity flags. 2011-09-16 22:17:48 +02:00
QAston e07535c3e3 Core/Entities: Add new functions: Unit::GetReactionTo and Unit::GetFactionReactionTo for more direct reaction checks than Unit::IsFriendly/HostileTo (those functions have many duplicated code and have many checks unrelated to unit reaction). 2011-09-15 17:44:03 +02:00
QAston decb20f079 Merge pull request #2991 from megamage/master 
Core/Entities: Do not call AddObjectToRemoveList(Pet*) in Map::MoveAllCreaturesInMoveList() - Closes #2892.
Scripts: Fix a crash in npc_brunnhildar_prisoner script. Closes #2825.
 2011-09-14 14:27:21 -07:00
QAston ec7da6f911 Core/ScriptedAI: remove ScriptedAI::CanCast function which is not functioning properly (compare that func with Spell::CheckCast to see how it should work) and is unused. Closes #2275. 2011-09-12 00:20:37 +02:00
QAston 1d38ccaca6 Core/Spells: Remove redundant explicit target checks from Spell::cast 2011-09-11 22:42:29 +02:00
QAston 606fd07cb1 Merge pull request #2966 from Chaplain/cleanup 
Core/Auras: Improvements in SPELL_AURA_MOD_DAMAGE_PERCENT_DONE handling:
 2011-09-11 13:29:50 -07:00
QAston 7c85617847 Core/Spells: Don't check cast requirements twice for instant cast spells. 2011-09-11 22:27:21 +02:00
QAston 06b9ae6e11 Core/Unit: Define UNIT_FLAG_UNK_0 as UNIT_FLAG_SERVER_CONTROLLED and remove related redundant creature_template data. 2011-09-11 11:41:55 +02:00
QAston 1fef67187b Core/Protocol: Define more opcode names - thanks to TOM_RUS. 2011-09-11 11:41:55 +02:00
QAston dad9d07045 Merge pull request #2920 from Chaplain/cleanup 
Core/Auras: Improvements in SPELL_AURA_MOD_DAMAGE_PERCENT_DONE handling: 
* Weapon specific case for MOD_DAMAGE_DONE_PCT shouldn't change PLAYER_FIELD_MOD_DAMAGE_DONE_PCT, because PLAYER_FIELD_MOD_DAMAGE_DONE_PCT applyed for _all_ damage that deal target.
* Fixed applying SPELL_AURA_MOD_DAMAGE_PERCENT_DONE for SpellDamageBonus.
 2011-09-06 02:37:21 -07:00
QAston 94126e0369 Core/Spells: Fix some talents with incorrect target entries in dbcs. This is an alternative fix for #2848. Closes #2846 Closes #2848. 2011-09-06 11:21:40 +02:00
QAston fab78d5e02 Scripts/Vault of Archavon: Earth, Wind & Fire achievement - by idostyle@zoit, with some spell attribute correction to the patch by me. 2011-09-03 21:16:12 +02:00
QAston 81a841ed20 Database/Spells: Add AttributesEx6 and AttributesEx7 columns to spell_dbc table. 2011-09-03 21:05:26 +02:00
QAston ddacd0de94 Core/Spells: Fix pick lock - thanks to cyberbrest for pointing the reason of this issue. 2011-09-03 20:16:15 +02:00
QAston f31e676199 Fix build after recent pull merges. 2011-09-03 18:07:27 +02:00
QAston df19a0c31f Correct sql file naming for b40bf69319. 2011-09-03 17:49:53 +02:00
QAston dc01541111 Merge pull request #2852 from Chaplain/cleanup2 
Core/Misc: Cleanup - remove unused variables, add some const modifiers to functions, fix process of args in vmap3_extractor
 2011-09-03 08:34:02 -07:00
QAston 82e7b11df1 Merge pull request #2778 from KoffeinKaio/master 
Fixed spellid's from Zul'Gurub encounters High Priest Thekal and Bloodlord Mandokir (&adds).
 2011-09-03 08:27:37 -07:00
QAston d23b03271d Merge pull request #2777 from KoffeinKaio/fishing 
Core/Spells: Fixed fishing bobber landing angle.
 2011-09-03 07:52:47 -07:00
QAston 7871ead798 Merge pull request 'Fix quest New Recruit(13143) & Fix quest King of the Mountain(13280&13283)' from Kiperr/TrinityCore 2011-09-03 16:44:05 +02:00
QAston 414f048bd5 Merge pull request #2735 from hacknowledge/fix_2734 
Core/Spells: Fixes ammo consumption for Hunter's Volley
 2011-09-03 07:29:31 -07:00
QAston 0ba79e0078 Merge pull request: The Val'kyr Twins Clean up and Implements from 'Drethek/master' 2011-09-03 16:26:49 +02:00
QAston 68037cdc3c Scripts/Commands: Allow c++ style comments in opcode.txt file for .debug send opcode command. 2011-09-01 10:46:15 +02:00
QAston 71b9e0d8de Core/Spells: Make mind sear aoe no longet target unit at which caster is channeling the spell. 2011-09-01 09:07:14 +02:00
QAston f16520fa25 Merge pull request #2838 from wonopon/patch-7 
Rotface should only cast Mutated Infection on one player.
 2011-08-31 14:34:38 -07:00
QAston 534ca8e23f Merge pull request #2821 from Chaplain/cleanup2 
Core/Misc: Cleanup
 2011-08-31 11:33:26 -07:00
QAston 048ae9cfab Merge pull request #2792 from wonopon/patch-6 
Scripts/Taldaram: Make the boss cast Bloodthirst on self instead of on victim.
 2011-08-31 11:31:11 -07:00
QAston ac9701afa7 Merge pull request #2762 from Kapoeira/master 
Core/Spells: Prevent deterrance from parrying spells that require the attacker to be behind the hunter, like Shred or Ambush.
 2011-08-31 11:24:45 -07:00
QAston d863562507 Core/Spells: Make core be a little less strict about some spell attributes SPELL_ATTR0_CASTABLE_WHILE_DEAD and SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS checks. 2011-08-30 00:13:53 +02:00
QAston 2f79241237 Core/Spells: check unattackable flag only for negative spells. 2011-08-29 23:26:47 +02:00
QAston 8754166071 Core/Spells: Send expected type of spell implicit target to client. 2011-08-27 12:59:57 +02:00
QAston 751cbaf307 Core/Spells: Fix a typo (!GetDst() instead of !HasDst()) which prevented from automatical lconverion of spell unit target to destination target (this is only used in script casts). Closes #2761. 2011-08-26 16:30:56 +02:00
QAston 79427354aa Fix build. Damn. 2011-08-26 15:40:11 +02:00
QAston 265c909666 Core/Spells: small correction to e2d592f380, don't interrupt passive auras. 2011-08-26 14:43:19 +02:00
QAston e2d592f380 Core/Spells: Interrupt periodic trigger auras when triggered spells fails to cast. Closes #2598 2011-08-26 14:23:23 +02:00
QAston 2ee88d76da Core/Spells: remove one obsolete spell proc target check. 2011-08-26 12:48:12 +02:00
QAston 8e392440cf Core/Spells: Fix a regression of 7f30ac5a95 - spells with TARGET_SELECT_CATEGORY_CHANNEL target type (like mind sear) should be triggered by triggering spell caster 2011-08-26 12:39:50 +02:00
QAston 5c48d9ec8a Core/Spells: Store explicit unit, corpse and GO targets in one variable, because both client and server can't handle more than one explicit object target; Add spell explicit target validation. 2011-08-26 12:06:13 +02:00
QAston dfa179b427 Scripts/Achievement: fix a typo. 2011-08-25 13:16:09 +02:00
QAston 5ebb4ba4c1 Core/Packets: Update opcodes enum - research by TOM_RUS, also remove some useless/obsolete comments from opcodes.h 2011-08-25 12:48:51 +02:00
QAston c0f3122b9c Fix build after revert. 2011-08-25 08:01:56 +02:00
QAston 188fdb3e4c Core/Spells: Allow spells with TARGET_FLAG_CORPSE to target players which didn't hit release button yet. 2011-08-25 06:51:57 +02:00
QAston 62d913bb35 Revert "Core/Spells: Also Death Runes itself should be able to turn into a Death Rune. They should not turn back into their original rune when using a spell that turns the used runes into Death Runes." - it is causing crashes. 
This reverts commit 17b89ea8ab.
 2011-08-25 06:40:56 +02:00
QAston fd500ba257 Fix build after last pull request merge. 2011-08-24 19:36:20 +02:00
QAston 7ae8f15985 Merge pull request #2582 from hacknowledge/fix_2531 
Core/Spells Disables environmental damage to players which are not attackable by AOE damage
 2011-08-24 10:03:10 -07:00
QAston b69330676d Merge pull request #2588 from hacknowledge/fix_2488 
Crashfix. Added missing check for NULL of victim parameter
 2011-08-24 10:02:26 -07:00
QAston 7a3b1f1ed5 Core/Spells: Make GMs and vehicle riders not attackable by AOE again. 2011-08-24 18:22:33 +02:00
QAston 5cd4f9e513 Core/Spells: fix TARGET_DEST_TARGET_* targets after 7f30ac5a95 2011-08-24 10:35:41 +02:00
QAston 1178cee836 Core/Spells: Small correction to: 7f30ac5a95 - TARGET_DEST_TRAJ targets should require both src and dst target provided. 2011-08-24 08:53:26 +02:00
QAston 7f30ac5a95 Core/Spells: Add a generic way of selecting spell explicit targets. Make explicit targets independant of calling convention in core - this makes targets sent to client to be much more blizzlike than before (for example CastSpell(Unit*) won't set TARGET_FLAG_UNIT for spells which are not using explicit unit target) for SMSG_SPELL_START packets. Also remove hacks, which became obsolete with this commit. 2011-08-24 08:08:33 +02:00
QAston 9f7a557c05 Merge pull request #2721 from Chaplain/cleanup 
Core: Clean up here and there.
 2011-08-23 21:01:54 -07:00
QAston 5819cb084f Merge pull request #2715 from elecyb/diminish 
Core/Spells: Fix duration of some spells in PvP
 2011-08-23 21:01:35 -07:00
QAston 5ef9f7dd1c Merge pull request #2728 from Kapoeira/master 
Core/Spells: Fixed Survival of the Fittest armor increase bonus while in Dire Bear or Bear form.
 2011-08-23 21:00:34 -07:00
QAston 0365feb069 Core/Entities: Make dead units not targetable for attack again (after fc5e924138). 2011-08-23 14:47:26 +02:00
QAston e7468b2e2c Core/Spells: Do not apply spellmods to spells with SPELL_ATTR3_NO_DONE_BONUS attribute. 2011-08-23 14:30:26 +02:00
QAston 738214f8e5 Core/Spells: add some const modifiers to functions, fixes build. 2011-08-21 13:57:15 +02:00
QAston c453d78b07 Core/Spells: Fix mind controll after recent target requirement changes. 2011-08-21 13:01:37 +02:00
QAston 0a7c622305 Db: remove command no longer present in scripts - thanks Whiroph. 2011-08-21 13:01:36 +02:00
QAston 3476767eb0 Fix warnings from merged pull requests. 2011-08-21 11:59:06 +02:00
QAston 0946843875 Merge pull request #2682 from Fredi/clean 
Core/AI: Cleaning up hungarian notation
 2011-08-21 01:04:08 -07:00
QAston 396a2e588b Merge pull request #2678 from Kapoeira/master 
Core/Spells: Fixed Heart of the Wild stamina and attack power bonus part.
 2011-08-21 01:00:00 -07:00
QAston 8e8fa083b2 Merge pull request #2636 from LihO/master 
Core/Auras: Check amount of total ticks to avoid division by zero (and crash) in Unit::GetRemainingPeriodicAmount.
 2011-08-21 00:58:55 -07:00
QAston a10eb53598 Merge pull request #2672 from Chaplain/master 
Core/Spell: case TOTAL_PCT\BASE_PCT should be processed by multiplicative function not additive.
 2011-08-21 00:54:14 -07:00
QAston edb1f1d436 Core/Spells: Don't check triggered flags for SPELL_ATTR0_CASTABLE_WHILE_DEAD attribute check - triggered spells have this flag set correctly - fixes problems with auras triggering spells for dead casters while they shouldn't. 2011-08-21 09:39:53 +02:00
QAston a76f023002 Core/Spells: remove one now obsolete check which prevents spells with SPELL_ATTR6_CAST_BY_CHARMER from being cast. 2011-08-20 13:14:47 +02:00
QAston b838aad7d0 Core/Spells: check UNIT_FLAG_OOC_NOT_ATTACKABLE only for AOE spells targeting enemies, fixes some interactions with npcs. 2011-08-20 12:08:37 +02:00
QAston 919a8ecf0e Core/Spells: Allow to explicitly target crowd controlled targets for spells with SPELL_ATTR6_CANT_TARGET_CROWD_CONTROLLED (Shield of Righteousness for example). 2011-08-20 11:45:23 +02:00
QAston 511db66297 Core/Spells: Remove some duplicate checks from Spell::CheckPetCast 2011-08-20 10:23:28 +02:00
QAston b0602b3153 Core/Spells: Use spell target flags to determine if spell can target dead targets - fixes skinning. Also, fix build once again 2011-08-20 10:01:57 +02:00
QAston 580a68573f Core/Spells: fix a crash. 2011-08-20 09:49:18 +02:00
QAston cf4e19cf4b Fix GCC build. 2011-08-20 09:32:19 +02:00