Commit Graph
2802 Commits
Author SHA1 Message Date
Machiavelli 71e959837b Core/Vehicles: - Prevent client ejecting passengers from non-ejectable seats.
- Chart some more VehicleSeatFlags and VehicleSeatFlagsB. Research by linencloth
2010-12-30 17:59:55 +01:00
Machiavelli 8c8f4a828b Core/Vehicles: - Prevent client ejecting passengers from non-ejectable seats.
- Chart some more VehicleSeatFlags and VehicleSeatFlagsB. Research by linencloth
2010-12-30 17:33:51 +01:00
silinoron e522fbe7ce Core/WorldSession: Cleanup. 2010-12-29 20:20:09 -08:00
QAston c8adcc95f9 Core/Unit: Move spell specific code from Unit::CalcAbsorbResist to AuraScripts. 2010-12-30 02:03:46 +01:00
Shocker 5f41699312 Core/Groups: Raid leader can't be kicked from group by raid assistants 2010-12-29 22:08:33 +02:00
leak 1c244cced5 Core/Entities: Fixed disarming and related exploits
- Disarm shouldn't deduct stats other than weapon damage
- Ferals shouldn't be affected by disarm
- Fixed meta gem stacking exploit
2010-12-29 17:18:29 +01:00
Machiavelli 1f7e888465 Core/Units: Units shouldn't be able to dodge while casting 2010-12-29 14:37:55 +01:00
Shauren 82f471cc13 Core/Quests: Fixed repeatable quest still showing as completable after completion
Signed-off-by: Machiavelli <[email protected]>
2010-12-29 13:14:51 +01:00
Machiavelli 6b12ec1f3e Fix build from 68c6189201 2010-12-29 12:09:57 +01:00
Machiavelli 68c6189201 Core/Vehicles:
- Set MovementFlagsExtra (2) correctly depending on vehicle 'template' flags. This makes certain vehicles such as demolishers unable to jump/strafe (as intended)
- Fix SMSG_MONSTER_MOVE_TRANSPORT stucture, prevents a client crash when entering certain vehicles, as well as *properly* broadcast position relative to the vehicle.
- Send SMSG_BREAK_TARGET to player when entering vehicle.
- Set MOVEMENTFLAG_ROOT on passenger when entering vehicle
- Cleanup in affected code
2010-12-29 05:45:38 +01:00
Machiavelli f0db5396f4 Core/Vehicles: Chart some unknown VehicleFlags
Author: zergtm

--HG--
branch : trunk
2010-12-28 16:28:17 +01:00
Shauren 9ac813e147 Core/Player: Fixed weapon swap macro while in combat
Closes issue #4954.

--HG--
branch : trunk
2010-12-28 13:07:54 +01:00
click c3abba71d3 Core/Handlers: Raise an errorlog into debug for CMSG_DISMISS_CRITTER - this may occur if the player is lagged out.
--HG--
branch : trunk
2010-12-28 10:14:05 +01:00
Machiavelli 46328318d2 Core/DB:
- Only use configured PersistentFlags for character database cleaner to determine data saving behaviour during runtime, instead of all original flags set in worldstates.
- Remove the forced deletion of abandoned quest entries in 10828_characters_character_queststatus.sql for those who do not want to lose that data. If you want to purge that data then run the core with CleanupFlags & 0x10. If you want to both purge the data now and prevent it from being saved in the future, run the core with CleanupFlags & 0x10 AND PersistentCleanupFlags & 0x10

--HG--
branch : trunk
2010-12-28 09:49:07 +01:00
linencloth e739d26eac Core/Player: Keep and store abandoned quests in the DB if CLEANING_FLAG_QUESTSTATUS is not set
Core/QuestStatus: Prevent inactive quest from being added into the questlog

--HG--
branch : trunk
2010-12-28 05:08:57 +01:00
linencloth 14b3a0b5c3 Core/CharacterDatabaseCleaner: Store character cleaning flags in World for runtime usage
--HG--
branch : trunk
2010-12-28 05:04:18 +01:00
linencloth bff48d88ad Core/CharacterDatabaseCleaner: Implement PersistentCharacterCleanFlags config value which can prevent specific cleaning flags from being disabled after a cleanup
--HG--
branch : trunk
2010-12-28 05:01:31 +01:00
linencloth 2ecb9eec8b Core/CharacterDatabaseCleaner: Implement CLEANING_FLAG_QUESTSTATUS flag for queststatus cleaning (most of the deleted rows are abandoned quests)
--HG--
branch : trunk
2010-12-28 04:26:25 +01:00
linencloth 1d9a75c338 Core/CharacterDatabaseCleaner: Cleanup
--HG--
branch : trunk
2010-12-28 04:19:37 +01:00
Spp 9b73cb1694 Core/Dungeon Finder: Fix crash in Update after DF system gone inconsistent
Note: Reason that makes DF go inconsistent not fixed, as it's not identified

Closes issue 5293

Thanks to cyberbrest for open my eyes and make me spot the problem

--HG--
branch : trunk
2010-12-28 01:21:05 +01:00
Machiavelli 88fe1da9eb Core/Spells: Fix caster selection in aura´s of type 284 (SPELL_LINKED_AURA).
Huge thanks to QAston for the brainstorming session.

--HG--
branch : trunk
2010-12-27 23:56:41 +01:00
click 464f1a9f8f Core: Kill off some warnings
--HG--
branch : trunk
2010-12-27 22:58:22 +01:00
Shauren 52620db629 Core/Auras: Fixed enchant proc stack rules
Closes issue #5222.

--HG--
branch : trunk
2010-12-27 22:27:11 +01:00
QAston ef968f4b15 Core/Unit: Big cleanup in Unit::CalcAbsorbResist
Core/AuraScript:
	Fix compile time check for AuraScript functions
	Remove AuraApplication from hook functions parameter list, use GetTarget() and GetTargetApplication() instead
	Add OnEffectAbsorb hook
Scripts: move handlers of Spell Deflection, Savage Defense, Primal Tenacity, Nerves of Steel, Astral shift from core to scripts.

--HG--
branch : trunk
2010-12-27 20:14:54 +01:00
Machiavelli dd745ef326 Core/Vehicles: Some research on VehicleSeatFlagsB.
It is assumed that VehicleSeatFlagsB & 322 means the seat can be used indirectly (ie. by aura 236 (SPELL_AURA_CONTROL_VEHICLE)) even though !(VehicleSeatFlags & VEHICLE_SEAT_FLAG_USABLE).
More research to be done Soon (tm).

--HG--
branch : trunk
2010-12-27 16:55:17 +01:00
Machiavelli bdc47053cc Core/Spells: Partial fix spells 62056, 63985 (Stone Grip Force Cast - Part of Kologarn encounter), underlying AuraEffect::HandleAuraControlVehicle will no longer prematurely return.
--HG--
branch : trunk
2010-12-27 14:53:47 +01:00
Machiavelli d951407822 Revert 0a95c34021 (thanks QAston for talking sense into me)
--HG--
branch : trunk
2010-12-27 11:06:53 +01:00
Machiavelli 299118cd3a Remove missing lines from previous commit, thanks click for pointing out.
(WTB Coffee)

--HG--
branch : trunk
2010-12-27 09:49:38 +01:00
Machiavelli d69a1c3629 Core/Spells: Fix SPELL_EFFECT_FORCE_CAST(140), SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141). These should force the target to cast a certain spell, not serve as a proxy for the original caster to cast another spell.
--HG--
branch : trunk
2010-12-27 09:21:08 +01:00
Machiavelli 4a169412b7 Core/Spells: Implement 65594 (Cancel Stone Grip - Used in Kologarn encounter) spell
--HG--
branch : trunk
2010-12-27 09:19:06 +01:00
Machiavelli f0d884ee20 Scripts/Ulduar: Implement script for General Vezax encounter.
Based on original patch by Lopin -- thank you!

--HG--
branch : trunk
2010-12-26 23:35:12 +01:00
linencloth efbc73d025 Core/Player: Split RemoveQuest into 2 separate functions
--HG--
branch : trunk
2010-12-26 21:34:08 +01:00
linencloth 07498c048c Core/QuestStatus: Log abandoned quests (requested, can be used in statistics)
--HG--
branch : trunk
2010-12-26 21:23:05 +01:00
linencloth 6b58081e63 Core/QuestStatus: Fix EffectQuestClear, also clear rewarded quests again
--HG--
branch : trunk
2010-12-26 21:18:22 +01:00
linencloth dfbd344aae Core/QuestStatus: Fix typo
Closes issue 5279

--HG--
branch : trunk
2010-12-26 18:20:58 +01:00
Shauren 2c1be8e182 Core/Auras: Prevent model changing when shapeshifted and restore transforms when changing out of shapeshift
Closes issue #4754.

--HG--
branch : trunk
2010-12-26 17:58:41 +01:00
Shauren f00a589b2a Scripts/Icecrown Citadel: Mutated Abomination should not damage its owner
Closes issue #5252.

--HG--
branch : trunk
2010-12-26 17:15:41 +01:00
Shauren 79070ca820 Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
--HG--
branch : trunk
2010-12-26 16:35:29 +01:00
Machiavelli 821c0f6c42 Core/Spells: Add dummy effect for Saronite Vapors (63322) (Used in General Vezax encounter)
Based on original code by Lopin

--HG--
branch : trunk
2010-12-26 16:25:40 +01:00
linencloth b150172521 Core/QuestStatus:
- Separate rewarded quests from active quests, and store them in a new table to reduce database size
- Drop the no longer needed `rewarded` column from character_queststatus for smaller table size
- Prevent filling the database with dropped quests
  - Delete useless records
- Implement queststatus save "queues" instead of states
- Minor optimizations

WARNING: Backup your database!

--HG--
branch : trunk
2010-12-26 04:16:18 +01:00
click 8fdbe7c4e6 Core/Spells: Update auraeffects for shapeshift forms with a few missing ones (kills off some more logspam as well)
--HG--
branch : trunk
2010-12-26 01:55:48 +01:00
click b5c1d554b2 Core/Handlers: Change/add some extra output in error-logs for PetHandler and SpellHandler
--HG--
branch : trunk
2010-12-26 01:24:29 +01:00
click 29d5e4e4d5 Core: Remove a useless log-error in Unit::BuildMovementPacket()
--HG--
branch : trunk
2010-12-26 00:38:01 +01:00
QAston f4e46db38a Core/Auras: Add some asserions to hunt down reason of a crash in Aura::UpdateTargetMap. Thanks to Shauren for inspiration.
--HG--
branch : trunk
2010-12-26 00:14:13 +01:00
click f5492f82b5 Core: Include the name and ID of the affected BG in Battleground::GetBGCreature() error-reporting
--HG--
branch : trunk
2010-12-26 00:06:03 +01:00
Machiavelli 70ec4a8f9b Fix build
--HG--
branch : trunk
2010-12-25 20:12:31 +01:00
Machiavelli 06d014f04d Core/Spells: Remove double initialization of ¨GetAuraEffectsByType(SPELL_AURA_MOD_DAMAGE_PERCENT_DONE)¨ in Unit::MeleeDamageBonus
Patch by [email protected]
Fixes issue #5269

--HG--
branch : trunk
2010-12-25 20:04:12 +01:00
click 07bebf0f35 Core/Handlers: Add some extra output in WorldSession::HandleDismissCritter (give more of which user attempts to dismiss it)
--HG--
branch : trunk
2010-12-25 17:53:50 +01:00
QAston bce9b081ec Core/Unit: Fix crashes in Unit::CalcAbsorbResist and Unit::DealDamage caused by unsafe iteration over Unit::AuraEffectList - copy the list instead of using oryginal one.
--HG--
branch : trunk
2010-12-25 16:12:31 +01:00
click b181ba21d9 Core: Fix a few warnings here and there.
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00