Allow to enable/disable Address Sanitizer in Clang and GCC from CMake flag "ASAN" of type Boolean. It can be enabled passing -DASAN=TRUE to CMake.
(cherry picked from commit 580f40769c6c446284dd1f5738f67fb3ee802956)
Fix battleground flags not displaying the typical burning animation when they "despawn" (they don't actually despawn, they just change state)
(cherry picked from commit 90bb10aa3a490fc701e6f98b32310687af80dea5)
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.
(cherry picked from commit fed030da190c9c53ad013d3e460ba1afbe1f02a2)
* Core/Achievements: fixed bug with counting honorless units for achievement type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL
* Remove codestyle changes
* Remove codestyle changes
(cherry picked from commit f4be5446293e9896fe8e1cd9db8dc739af848cae)
* Core/Taxis: teleport players to the destination taxi node location instead of straight to their current ground position
* fixed a typo
(cherry picked from commit 7fcb77ecd12c42b8a468e8f932948c99c249a458)
Fix an issue that wouldn't allow to re-queue after joining a dungeon, having 1 member leave/get kicked, queue, leave, queue.
In this case a message "One or more dungeons was not valid" would be displayed because LFG would try to queue the group as "continue dungeon" but the current group was not marked as "in dungeon" state anymore.
(cherry picked from commit abcad7cda5375478f475bb9624c578169e84c559)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups
Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()
* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups
Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()
* Scripts/Misc: Fix no PCH build
(cherry picked from commit ef694cc251844d34a64ae03f79d28a5c76719f6b)
* Core/Movement: fixed taxi pathings getting finalized earlier than intended
Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended
* apply a missing change
(cherry picked from commit c1e3d79a4fb5b7b1a9bca36ecd16b9bb902ced92)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.
* Update FlightPathMovementGenerator.cpp
(cherry picked from commit cf3277c641bd877b9fa1939da5da7cde1778561b)
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive
(cherry picked from commit 42ab6010f862e530517e2acd347ef6230bcf1c3b)
* Core/Calendar: Add some additional validation when creating events
Allow only 30 player events and 100 guild events to be created.
Don't allow to create guild events if player is not in guild.
Send some more error messages to the client (not blizzlike errors but better than nothing).
* Core/Calendar: Add some additional validation/checks
Add guild id check in GetPlayerEvents().
Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past.
* Core/Calendar: Add some additional validation/checks
Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3.
* Core/Calendar: Add some additional validation/checks
Implement 5 seconds cooldown between the creation of calendar events
* Core/Calendar: Add some additional validation/checks
Don't allow to copy events of a different player/guild
* Core/Calendar: Implement automatic deletion of old events
Implement automatic deletion of events older than 1 month (30 days).
Fix debug assertion triggered when deleting a character with calendar events.
Avoid double std::set lookup when deleting events when deleting a character.
NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits.
(cherry picked from commit fb059722fdb18a94d47b3f44a5b2d7f183bf5a29)
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target.
Fix re-implements 8927a04253 after 2a84562dc85516f432bb1e5de9add23c28b26ce4 partially removed it.
Fix#23724
(cherry picked from commit 215a6cee24896f2def2a5af390c089ac1d947e65)
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground.
(cherry picked from commit 680e1cbd6cf7c52abe104fb87d8fa6dba83fb633)
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03ef204289bbd96e8e1e07117b3bebd9f )
Closes#23754
(cherry picked from commit f8d7b260476c69e09ab0329cb7cd6c277f5473a7)
jackpoz