Commit Graph
787 Commits
Author SHA1 Message Date
Shauren 88d7b58a3d Core/Spells: Rename SpellAttr3 to use official attribute names
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-04-30 16:57:32 +02:00
Shauren dda375b986 Core/Spells: Rename SpellAttr2 to use official attribute names
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-04-28 18:31:26 +02:00
Shauren c88b602a2c Core/Spells: Rename SpellAttr1 to use official attribute names
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-04-25 22:16:56 +02:00
Shauren a31e681944 Core/Spells: Rename SpellAttr0 to use official attribute names 2022-04-24 18:40:10 +02:00
Traesh 87723e32e2 Core/Battlegrounds: Implement mercenary system 2022-04-16 12:15:37 +02:00
Grindelwald a799a10a90 Core/Spells: Add MaxAffectedTargets for Domination (#27541)
(cherry picked from commit 5f0e80bf4385e81d607ea81a9de3c92a11db8de0)
2022-03-24 23:50:03 +01:00
Grindelwald 67954a6991 Core/Spells: Add MaxAffectedTargets to Chains of Naberius(36146) (#27291)
Closes #27289

(cherry picked from commit c3973ff577511773bb6bc94bd738b9014060e060)
2022-03-22 23:18:01 +01:00
Keader 8d841679fc Scripts/ScarletMonastery: Headless Horseman Rewrite (#25614)
(cherry picked from commit a93abcf8031fc3b4dc6db16aa09d92a221bc6a77)
2022-02-28 23:38:36 +01:00
Shauren 02979daf76 Core/Auras: Proc flag updates
* Rename to official names
* Corrected logic selecting flags for each spell cast - determine them by attributes instead of DmgClass
* Implemented new proc flags (PROC_FLAG_CAST_ENDED, PROC_FLAG_LOOTED)
2022-02-10 21:11:07 +01:00
Shauren 68a662ae04 Core/Spells: Add type safety to proc related functions - using enum arguments instead of plain integers 2022-02-10 12:25:27 +01:00
Shauren 3844c79adb Core/Spells: Load entire proc flags array from db2 2022-02-09 23:46:29 +01:00
Shauren b6bc8a50ac Core/Spells: Correct implementation of SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC, SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED and rename them (SPELL_ATTR2_ACTIVE_THREAT, SPELL_ATTR3_NOT_A_PROC, SPELL_ATTR3_CAN_PROC_FROM_PROCS) 2022-02-02 13:56:49 +01:00
RobingadandShauren 3e725e1d25 Scripts/Spells: Fix shaman Earthquake (#27620)
Co-authored-by: Shauren <[email protected]>
2022-01-27 22:18:46 +01:00
Giacomo Pozzoni 864d775280 Core/Misc: Fix static analysis issues (#25194)
(cherry picked from commit 07fd84b679fd6958b7e669a96c78783875e1b949)
2022-01-26 14:06:40 +01:00
Trond B. Krokli fa444aca66 Scripts/Quest: Force of Neltharaku quest credit (#24807)
* Scripts/Quest: Force of Neltharaku quest credit

**Description:**

Suggested solution to resolve the kill credit double cast issue
in the quest "The Force of Neltharaku" (10854).

by Rushor

**Changes proposed:**

- Remove duplicate spell casts in the zone quest script
- Remove commented-out script section
- Set a couple of unit flags (anim/stand/hover)
- Move return new creature script override to end of script
- Move PlayerGUID, FlyTimer, and Tapped to Private
- Add DB flight movement control to Enslaved Netherwing Drake
- Add SpellMgr MaxAffectedTargets = 1 for spell 38762
- Add movement enum POINT_MOVE_UP
- Add missing enum for quest ID

**Target branch(es):** 3.3.5/master

- [X] 3.3.5
- [X] master

**Issues addressed:** Closes #24796

**Tests performed:** (Does it build, tested in-game, etc.)

Pending for now.

**Known issues and TODO list:** (add/remove lines as needed)

- [X] Open PR in draft mode until testing is cleared
- [ ] Compile and create local server
- [ ] Test changes on local server

* Rename 9999_99_99_99_world.sql to 2020_07_29_00_world.sql

Co-authored-by: Rushor <[email protected]>
Co-authored-by: Giacomo Pozzoni <[email protected]>
(cherry picked from commit e0dae8feb6607b5190d14b56ecfc10bbfa667c95)
2022-01-24 13:19:36 +01:00
Peter Keresztes Schmidt ad340466d0 Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs (#25054)
Related: #25006
(cherry picked from commit 85b5b842ca6c05d4e51081e6c3282940a80f3761)
2022-01-23 22:02:03 +01:00
Shauren b4b58c563b Core/Spells: Fixed typo in loading serverside spells 2022-01-11 21:08:22 +01:00
Shauren 415aaae7f2 Core/Spells: Validate spell_proc.AttributesMask on startup 2022-01-11 19:05:35 +01:00
Shauren 241193cd02 Core/Items: Implemented many new enchantment flags 2022-01-09 16:31:12 +01:00
Shauren bd60df2ce0 Scripts/Spells: Fixed mage talent Chrono Shift
Closes #19575
2022-01-07 22:46:00 +01:00
Carbenium 49523a74a4 Battlefields: Move BF scripts out of game
This commit introduces the usual script interface
for battlefields.

(cherry picked from commit f7faf20254a120a90b8ee8eb55a284a6351aabc3)
2022-01-07 00:20:57 +01:00
Keader 4110a06e81 Core/Misc: Fixed resistance calculate for Mutated Transformation and Twilight Bloodbolt (#24717)
Ref: 9f7b464a6aa5b64bf5ec5c0f586853fbc71029c6
- Implemented a new SpellScript hook that allow control Resistance/Absorb amount of a damage spell.

(cherry picked from commit d81a9e5bc3b3e13b47332b3e7817bd0a0b228cbc)
2022-01-06 19:59:50 +01:00
Killyana 6300b096ac DB/Pet: Lil' K.T
Ref #1364

(cherry picked from commit ee5eace3c6d1fa489572c052daef4834e9c7f12c)
2022-01-01 21:49:09 +01:00
Killyana 567b26e0c7 DB/Pet: Toxic Wasteling
Closes #12773

(cherry picked from commit 3f5e0927c3e7e3c0fc471f9d8dd4944b270dc40e)
2022-01-01 21:42:51 +01:00
Killyana ad2e5aabc4 Spell: Move "Dark Conclave Ritualist Channel" outside Ulduar spells
(cherry picked from commit 9e585732728a0b99c6e8f70d30bd7c508de44636)
2022-01-01 20:04:42 +01:00
Killyana b4dd7c642b Spell: Fix "Dark Conclave Ritualist Channel" range and cast
(cherry picked from commit 64878e19fbbb95ee1741aed6013a27f7c6323f41)
2022-01-01 20:02:50 +01:00
NoName 37178ff311 Core/Spells: SPELL_AURA_48 implementation (#24054)
by xvwyh

(cherry picked from commit b3b7f0761d5605d57f9d62ca8e22a8cd9a4df24b)
2021-12-20 22:30:41 +01:00
Killyana ef794af489 Spell: "Fierce Lightning Stike" must hit only one target
(cherry picked from commit 89421422865b0d7743db22bb165bba0a3d8f2cfc)
2021-12-20 22:15:44 +01:00
Keader b9def15aa7 Scritps/ICC: Fixed resistance calculation for Mutated Transformation (Professor Putricide) (#23858)
More Info in: #23837

(cherry picked from commit 9f7b464a6aa5b64bf5ec5c0f586853fbc71029c6)
2021-12-19 15:33:41 +01:00
Trond B. Krokli 3e835a77bb Core/Spells: add spell fix to Trained Rock Falcon (#23896)
fixed by sirikfoll

(cherry picked from commit 42f1861f3023af2eff66dc64e78164f3c480337e)
2021-12-18 23:43:49 +01:00
Keader 03a1b03633 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)
(cherry picked from commit 34ee2effc89dc5bb34b4873dbfed6081ea8cb685)
2021-12-18 22:37:30 +01:00
tarwyn 474d903d79 Fix inconsistent NPC aggro on spell miss (#23816)
(cherry picked from commit c8dc9fdc418d9703893e21603b7593b015f08fea)
2021-12-18 22:23:00 +01:00
AlιAѕѕaѕѕιN e1598fa1d6 [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

* Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

(cherry picked from commit 92d83c3c2eaba3f5b58dc98472318872f3a54706)
2021-12-18 21:31:17 +01:00
Aokromes fc7ea18039 Core/Spells: Survey Sinkholes will now have a bigger range to be able…
… to hit all trigger npcs

By Ovahlord

(cherry picked from commit 028db8432eb220de198123871741fd8c36c52ebe)
2021-12-18 20:31:45 +01:00
Treeston 2b65dbbeab Core/Misc: Kick a Totem error log upstairs one stack frame to give it access to various debug info and make Aokromes happy.
(cherry picked from commit e813200e5ef3eaade089cb0e8382905c80b6130d)
2021-12-17 22:36:55 +01:00
Treeston b8c7260bfd typo fix, duplicate assignment
(cherry picked from commit 7d6896b54141c32c51f49f2c3fcd58cd986f0e02)
2021-12-15 22:41:58 +01:00
Killyana 4378ad98ab DB/Quest: Seeds of the Blacksouled Keepers
(cherry picked from commit 42abf69a27058251b7dd59a59c1f059f834431e4)
2021-12-15 21:51:07 +01:00
Martin Topholm dc0728b9a0 Script/BlackrockDepths: fix Ironhand Guardian's Gout of Flame spell cast. (#21816)
(cherry picked from commit 4529a94e0d093fb01c6ae4a98dade46ce75f82a9)
2021-12-14 21:19:01 +01:00
Wyrserth f31d8f7ffb Script/Acherus: script out of combat event for Frost Death Knight trainer Amal'thazad.
(cherry picked from commit 8fcc82138fee2bbea7b7f82d4b0475e4f53f100c)
2021-12-14 21:11:10 +01:00
ForesterDev 27886c7f5d Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender (#23520)
* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender

* fix merge

* Add virtual methods for Unit class

(cherry picked from commit b47bb59e2a3e42aff3793517ef94f51678b54905)
2021-12-13 00:42:20 +01:00
ccrs 4e6c59dca7 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()

(cherry picked from commit 5c09ff51f7015b775def8d5cc1f678eaef37200f)
2021-12-13 00:42:20 +01:00
Wyrserth 04b02f3672 Core/Spell: Challenge Flag should only hit one target.
(cherry picked from commit 39aa91f9824ce3b3f574931d287753dd8d49581f)
2021-12-13 00:42:19 +01:00
Killyana 2aca19a079 DB/Quest: "Where Kings Walk" and "Warchief's Blessing"
The script was deleted by https://github.com/Aokromes/TrinityCore/commit/5f928f79490b1d73c32ea962c3c720bd16833010 But it wasn't done properly via the spell_area anyway

(cherry picked from commit 8d6295559d72e4d17bce3c03f56f2a8f67c5109d)
2021-12-11 21:34:48 +01:00
Nitair f6048aca9a Scripts/Stratholme: Baron Rivendare rewrite (#22572)
* Adding last state of rivendare rewrite

* Fix aura beeing removed on reset, fix death pact

* Not needed

* SQL: Changed remove/inset into update, fixed delete at conditions part

* Typo

* Remove link spell, fix blank lines, change magic numbers to enum

* Test changes with SpellScript and DoCastSelf

* Revert SpellScript and moved DoCastSelf for the aura into UpdateAI part

* Damn, copyright.

* Fix Unholy Aura

* Fix again (does attack now / does cast if encounter resets)

* Adding handling of the aura to the db

* Rename 2018_99_99_99_world_335.sql to 2019_05_31_02_world_335.sql

(cherry picked from commit ee5101fbf74b0fa924a8467ee766b39c1d06875b)
2021-12-09 00:24:26 +01:00
Killyana c287485a7b Spell/Scripts: Add cooldown for Arcano-Scorp spells
Closes #23287

(cherry picked from commit a0d41c314fcce2b7e941628b3b9b1710cc6acee8)
2021-12-05 22:37:31 +01:00
Wyrserth fd030069f7 Core/Spell: add proper cooldowns to some spells used by vehicles (#23260)
* Core/Spell: add proper cooldowns to some spells used by vehicles, thanks to jackpoz and sirikfoll.

* Add Wing Buffet and Stampy's Stompy-Stomp.

* Add Tag Greater Felfire Diemetradon and Touch of Darkness.

* Rename 9999_99_99_99_world.sql to 2019_05_17_00_world.sql

(cherry picked from commit 4d04344b414adc965bd2760d3f30338bcce70431)
2021-12-05 18:44:59 +01:00
Killyana bdb728a165 Spell/Script: Throw Torch must hit only one target
(cherry picked from commit ce562415ed49d202de172fc2edab84250c494238)
2021-12-04 00:31:32 +01:00
jackpoz 43a41caafb Core/Misc: Fix GCC 8 warnings
(cherry picked from commit 1d04a3b216901671eae0104547715a570b1ff3ab)
2021-11-24 23:40:15 +01:00
Killyana 48c8b650bb Spell/Script: Summon Scourged Captive
Closes #16357

(cherry picked from commit 0959f3071af5f4c2b20c926beb8c78c3454ffb4b)
2021-11-24 20:35:18 +01:00
Keader cfd0e18b81 Core/Misc: Fixed shaman elementals and magister terrace first boss access
(cherry picked from commit 6545cd33b91468de7c1b4beb77cdeb4ecb77f501)
2021-11-23 00:39:59 +01:00