Commit Graph
232 Commits
Author SHA1 Message Date
silinoron 4f112d6a9d Fix Totem of Wrath debuff effect.
Fixes issue #3297
Fixes issue #2276
Patch by Ramus.

--HG--
branch : trunk
2010-09-05 14:34:48 -07:00
Shauren 43e4e1f786 Core/Spells: Bladestorm will now cause the caster to drop flag on battleground
--HG--
branch : trunk
2010-09-05 15:25:33 +02:00
Shauren 77130c910f Core/Spells: Fixed Execute formula, patch by dr.tenma
Closes issue #3478.

--HG--
branch : trunk
2010-09-05 14:28:13 +02:00
Shauren 1863960da8 Core/Spell: Fixed Escape artist, patch by Heisenberg
Closes issue #3536.

--HG--
branch : trunk
2010-09-05 13:59:49 +02:00
Shauren 14c8fa4925 Core/Spells: Fixed Nevermelting Ice Crystal trinket
--HG--
branch : trunk
2010-09-05 13:39:10 +02:00
Shauren 0b743795d6 Core/Spells: Implemented aura type 303 (SPELL_AURA_MOD_DAMAGE_DONE_VERSUS_AURASTATE), patch by Azuritus
Closes issue #3773.

--HG--
branch : trunk
2010-09-05 12:05:49 +02:00
Shauren b39a21b795 Core/Spells: Check correct Attributes field in CanSpellPierceImmuneAura, patch by Maxdestroyer
Closes issue #3785.

--HG--
branch : trunk
2010-09-05 11:33:35 +02:00
silinoron 5179d3149a Core/Game: Fix remaining warnings on windows (and most likely almost all of the ones on *nix)
--HG--
branch : trunk
2010-09-03 21:55:57 -07:00
silinoron 1e1c596dda Core/WorldPacket: Fix the core spamming complaints about CMSG_QUEST_QUERY being sent post-logout
Core/Spells: A little bit of "cleanup"

--HG--
branch : trunk
2010-09-03 20:30:29 -07:00
silinoron d2c259fe76 Core/ScriptSystem: Add a PlayerScript::OnSpellCast(Player *player, Spell *spell, bool skipCheck) function.
Requested by Zor.

--HG--
branch : trunk
2010-09-03 19:58:16 -07:00
azazel 7884fd927a Spell Scripts:
* moved some generic spell dummy effects to scripts
* implemented two spell scripts for quests: 8913 Sacred Cleansing (Quest 55), 44936 Quest - Fel Siphon Dummy (Quest 11515). Closes issue #3040
* did some cleanup in spell scripts and added more comments

--HG--
branch : trunk
2010-09-04 02:33:57 +06:00
Shauren e25846a08e Core/Spells: Fixed crash in EffectFeedPet
Closes issue #3728.
Closes issue #3752.

--HG--
branch : trunk
2010-09-02 22:04:08 +02:00
Shauren 15880d27ea Core/Spells: Fixed Health Leech effect, should not apply healing multiplier to damage done
--HG--
branch : trunk
2010-09-02 15:34:36 +02:00
Shocker c8dfbdac35 Conflagrate direct & DoT damage shouldn't scale with duration increases of Immolate/Shadowflame, fixes issue 3376.
--HG--
branch : trunk
2010-09-02 06:02:51 +03:00
Spp e252b8abe7 Core: Fix more warnings
--HG--
branch : trunk
2010-08-30 23:07:14 +02:00
QAston a8de57559b *Allow channeled spells to be casted on dead target
*Define relted spell attributes

--HG--
branch : trunk
2010-08-30 17:32:51 +02:00
Spp 405f312918 Core: Fix more warnings
--HG--
branch : trunk
2010-08-30 15:25:15 +02:00
Shocker d81864e7f3 Cleansing Totem should no longer pulse at spawn as of patch 3.2.2, thanks SimonDMII/olegoriy for noticing, closes issue #3702.
--HG--
branch : trunk
2010-08-30 10:53:29 +03:00
azazel d952c90754 Spell Scripts:
* add new file spell_item.cpp for spells used by items (but not by quests)
* move some dummy effects of generic spells to scripts
* implement spell for quest 12937 Relief for the Fallen. Closes issue #3070

--HG--
branch : trunk
2010-08-29 22:40:23 +06:00
QAston d81f5facc0 *Allow SPELL_EFFECT_POWER_BURN(64) to proc with damage.
--HG--
branch : trunk
2010-08-29 05:26:32 +02:00
QAston 2d877bbbfd *Allow damage shield hits to miss.
*Send overkill on damage shield hit.
*Correct data order for execute log of power take effects.

--HG--
branch : trunk
2010-08-29 03:38:21 +02:00
QAston 511e8c5acf *Make EffectHealMechanical, EffectHealPct, EffectHealMaxHealth and EffectHealthLeech to use proc system for their dmg/heal (thanks kiper for research)
*Fix some spells with EffectHealMaxHealth with effect value set to 0.
*Fix a typo.

--HG--
branch : trunk
2010-08-28 23:01:04 +02:00
azazel 71de9aa79f DB Scripts: Fix calling of DB scripts from spell_scripts table
--HG--
branch : trunk
2010-08-28 21:01:16 +06:00
Shocker f89a27dc98 Make sure crafting spells with non-random loot are not allowed to be casted if inventory is full. Fixes issue #2791
--HG--
branch : trunk
2010-08-28 02:20:26 +03:00
QAston e85df47749 *Send SMSG_SPELLINSTAKILLLOG on SPELL_EFFECT_INSTAKILL(1), thanks to Zor for base packet info.
--HG--
branch : trunk
2010-08-28 00:30:07 +02:00
QAston 5eb7e80fd5 *Send VICTIMSTATE_INTACT on melee attack miss.
*Rename VICTIMSTATE_NORMAL to VICTIMSTATE_HIT.
*Set default memory allocated in Spell::InitExecuteLogData to 32 bytes.

--HG--
branch : trunk
2010-08-27 23:12:52 +02:00
QAston 91233b9ba8 *Fix size of SMSG_SPELLHEALLOG and build (rage!!!)
--HG--
branch : trunk
2010-08-27 21:07:33 +02:00
QAston 6c3015a7e6 *Fix issues with negative dmg of periodic power burn and periodic power leech effects added recently.
*Minor cleanup.

--HG--
branch : trunk
2010-08-27 20:51:29 +02:00
QAston 36640c263a *Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
--HG--
branch : trunk
2010-08-27 19:36:27 +02:00
Shauren 5fbc8f1de4 Scripts/Icecrown Citadel: Added hacky workaround for teleporting spells because their default target is not supported by current grid system
Scripts/Icecrown Citadel: Mark Gunship event as complete on Lady Deathwhisper's death (temporary, until transport system will fully allow scripting the event)

--HG--
branch : trunk
2010-08-27 18:11:21 +02:00
QAston f1d4933dcb *Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
--HG--
branch : trunk
2010-08-27 17:49:32 +02:00
QAston c1ac063ba1 *Remove m_currentBasePoints from spell class, use m_spellValue instead.
--HG--
branch : trunk
2010-08-27 06:40:23 +02:00
Shocker 35066fdb6a Small cleanup/corrections
--HG--
branch : trunk
2010-08-27 04:55:49 +03:00
QAston 1d3deae555 *Send to client periodic heal absorbtion.
*Heal over time spells are updating healing achievement progress now.

--HG--
branch : trunk
2010-08-27 01:13:27 +02:00
Shocker 23d1267689 Add possibility to ignore instant spells when checking if a spell is currently being casted. Fixes issue #2227
--HG--
branch : trunk
2010-08-26 20:40:18 +03:00
QAston 30d31ca40a *Fix usage of EffectValueMultiplier in spell code.
*Remove some obsolete code from spell class.
*Rename some spellmod and dbc column names to be more accurate.

--HG--
branch : trunk
2010-08-26 19:07:55 +02:00
Shauren 692779f283 Core/Scripts: Added possibility to disable default aura effects for the whole duration of aura (PreventDefaultAction works per script call, PreventDefaultEffect is global)
Scripts/Icecrown Citadel: Corrected aura scripts for new PreventDefaultEffect, thx QAston for pointing it out
SQL: Corrected name for 9599 vehicle accessory
SQL: Fixed import errors in 9600_world_script_texts.sql by Supabad

--HG--
branch : trunk
rename : sql/updates/9599_vehicle_accessory.sql => sql/updates/9599_world_vehicle_accessory.sql
2010-08-26 15:32:08 +02:00
Shauren 73d3f210a9 Scripts/Icecrown Citadel: Add script for Deathbringer Saurfang (only missing alliance outro due to need of spawning and moving a transport)
Scripts/Icecrown Citadel: Corrected Lord Marrowgar, should no longer target tanks with Bone Spike Graveyard, his Coldflame should now spread properly
Core/Scripts: Moved Lady Deathwhisper Mana Barrier handler to scripts
Core/Scripts: Allow AuraScript to prevent default effects by effect index
Core/Scripts: Added Is25ManRaid() method to ScriptedAI, obviously used to check if raid is 25man
Core/Achievements: Pass m_caster to UpdateAchievementCriteria for ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET

--HG--
branch : trunk
2010-08-21 20:50:38 +02:00
azazel 5fa14f58dc Core/Cleanup:
* move repeating code into separate method for storing locale strings in ObjectMgr (copy/paste sucks, you know)
* fix 'signed/unsigned' warnings (at least in VS)
* fix some other warnings and cleanup relative code

--HG--
branch : trunk
2010-08-26 15:54:56 +06:00
azazel 341e6303ef Core:
* add helping methods for manipulating unit's health and use it where applicable
* fix some conversion warnings and cleanup code (formatting, CRLF, tabs to spaces)

--HG--
branch : trunk
2010-08-26 01:20:57 +06:00
Shocker bd2ffab07a * Move Paladin Judgement bonuses to spell_bonus_data, thanks deltapower.inc
* Avoid code duplication by moving spell interrupt code for jump effects to a common function for both EffectJump and EffectJumpDest, thanks devthenecro

--HG--
branch : trunk
2010-08-25 18:24:40 +03:00
Shocker 020211bb31 Fix seal unleash damage for Seal of Wisdom / Light / Justice / Vengeance
--HG--
branch : trunk
2010-08-25 06:17:12 +03:00
Shocker c741163313 Knockback (ex: Thunderstorm) and Jump (ex: Death Grip) effects must instantly interrupt spellcasting on victim. Fixes issue 1973
--HG--
branch : trunk
2010-08-25 05:14:16 +03:00
Shocker 4da71ac657 * Fix a crash in Culling of Stratholme
* Typo fix from previous rev

--HG--
branch : trunk
2010-08-25 03:53:43 +03:00
Shocker d3c6edeb4a Correct usage of basePoints in various locations
--HG--
branch : trunk
2010-08-25 03:21:22 +03:00
click e5337169c8 Core: Fix non-PCH builds - defining SpellScripts before we have the auraApplications defined will not work
--HG--
branch : trunk
2010-08-24 16:07:52 +02:00
Spp 9e4357c9ad Core: Fix more warnings
--HG--
branch : trunk
2010-08-24 14:44:56 +02:00
Shocker c728681422 * Remove some old checks in aura stacking and change default stack rule to true
* Add stacking rules for Mark/Gift of the Wild, Power Word/Prayer of Fortitude, Prayer of/Shadow protection
NOTE: Although highly unlikely, this *might* cause some stacking problems until we properly define rest of the stacking rules in spell_group, so report any stacking issues
* Some missing lads from THANKS file

--HG--
branch : trunk
2010-08-24 14:38:00 +03:00
Shocker 5e92a8e55a Fix accessories for vehicle player mounts (the vendors on Traveler's Tundra Mammoth for example)
--HG--
branch : trunk
2010-08-24 07:19:29 +03:00
silinoron 8649bee17f Replace World::getConfig with World::getFloatConfig, World::getIntConfig, and World::getBoolConfig.
Also fix a warning from a previous commit.

--HG--
branch : trunk
2010-08-23 19:56:47 -07:00