QAston
dfcc94e6c3
Merge pull request #6565 from Vincent-Michael/EffectHealMaxHealth
...
Core/Spell: Fix spell effect SPELL_EFFECT_HEAL_MAX_HEALTH calculation
2012-05-27 06:48:18 -07:00
QAston
e5268ba0b5
Merge pull request #6502 from Vincent-Michael/SPELL_DAMAGE_CLASS_NONE
...
Core/Spell: Fix some problems with spells calculation
2012-05-13 07:52:14 -07:00
QAston
2459305c76
Merge pull request #6499 from joschiwald/dmg_mods
...
Core/Spells: fix damage mods from caster on target
2012-05-12 03:48:52 -07:00
QAston
24308cc80a
Merge pull request #6494 from Chaplain/spells
...
Clean up for 58f63509cd
2012-05-11 03:58:05 -07:00
QAston
58f63509cd
Merge pull request #6314 from Chaplain/spells
...
Core/Spells: Separation of caster/target part damage/heal bonus calculation.
2012-05-09 15:10:33 -07:00
QAston
b53485e053
Fix build and correct minor codestyle issue.
2012-04-28 15:10:52 +02:00
QAston
b899f5fc94
Core/SpellScripts: rename GetTarget*() functions to GetExplTarget*(), so the names reflect better what those functions do. Also update some comments.
2012-04-28 14:55:14 +02:00
QAston
4b5e763d21
Merge pull request #6368 from Vincent-Michael/disengage
...
Core/Spell: Fix not using Disengage while rooted
2012-04-28 04:57:45 -07:00
QAston
06923e21e8
Merge pull request #6239 from The-Game/master
...
Core/Spell: Fix unit tracking to not being limited to the caster of SPELL_AURA_MOD_STALKED.
2012-04-28 04:56:58 -07:00
QAston
a08fe16d69
Core/Spells: Allow spell effects to have multiple destinations. Spells like: 49814, 10869 and similar are now properly selecting destination targets.
2012-03-03 00:19:48 +01:00
QAston
e1b544d129
Core/Spells: Remove some obsolete code
2012-03-02 17:57:26 +01:00
QAston
dc55d9ed13
Fix sql update in 8653016bdd - thanks to RedSonja
2012-02-27 21:07:59 +01:00
QAston
8653016bdd
Merge pull request #5445 from Souler/fix_demonic_circle
...
Move Demonic Circle related code to spell_warlock.cpp
2012-02-27 07:15:39 -08:00
QAston
a0de042efe
Core/Spells: Remove SpellSelectTargetTypes enum - it's not needed anymore.
2012-02-25 14:07:07 +01:00
QAston
b7b37dca29
Core/Spells: send spell error messages on spell cast condition checks.
2012-02-25 11:54:12 +01:00
QAston
ccbe209ded
Merge pull request #5343 from kandera/fix_spell_script_stuff
...
fix a few issues with the spell scripts i made.
2012-02-23 09:35:10 -08:00
QAston
537bec239b
Merge pull request #5389 from kandera/script_vessel
...
Core/Scripts: script despawn for dummy effect of muisek vessels
2012-02-23 09:31:05 -08:00
QAston
fb5d05c198
Core/Spells: Prevent assertion failure in Spell::SelectImplicitDestDestTargets by setting dest to caster if no dest provided.
2012-02-22 21:06:29 +01:00
QAston
7a261ff9b8
Core/Spells: Use right function for obtaining spell target type. Fixes assertion failures.
2012-02-22 10:34:08 +01:00
QAston
2a1ffc1cd9
Core/Spells: Fix a typo in f09b5a6bea - call right function for target dest case.
...
Closes #5357
2012-02-22 10:21:02 +01:00
QAston
18948755ca
Merge.
2012-02-21 20:17:45 +01:00
QAston
f09b5a6bea
Core/Db/Conditions:
...
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required
Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
QAston
9abc47736f
Core/Spells: Changes in code related to spell explicit target redirection (cleanups, added target validation, prevent unexpected behaviour in some cases)
2012-02-19 00:40:55 +01:00
QAston
e212116b1f
Update file names after pull request merge.
2012-02-18 12:15:52 +01:00
QAston
cd3ed111c9
Core/Spells: Fix recently broken feral spirit and force of nature. Closes #5278 .
2012-02-17 11:45:21 +01:00
QAston
0d5ae5784c
Core/Spells: Make channeled auras stackable by default with other auras.
2012-02-16 17:14:32 +01:00
QAston
e47ec04b4d
Core/Db/Conditions: Drop CONDITION_CREATURE_TARGET, CONDITION_TARGET_HEALTH_BELOW_PCT, CONDITION_TARGET_RANGE and 3rd parameter for CONDITION_AURA. Instead of those use other available conditions, which are not limited to player's selection only.
2012-02-16 13:16:43 +01:00
QAston
ad6613261c
Core/Db/Conditions: Drop usage of CONDITION_ITEM_TARGET and CONDITION_SOURCE_TYPE_ITEM_REQUIRED_TARGET and use CONDITION_SOURCE_TYPE_SPELL instead.
2012-02-16 12:09:09 +01:00
QAston
210fa7743d
Scripts/Auras: fix spell_trash_mob_glacial_strike script, original patch by cemak.
...
Closes #5196 .
2012-02-15 23:48:43 +01:00
QAston
de706b3211
Core/Db/Conditions: Add new condition targets for:
...
- CONDITION_SOURCE_TYPE_CREATURE_TEMPLATE_VEHICLE ConditionTarget = 1 - check vehicle
- CONDITION_SOURCE_TYPE_VEHICLE_SPELL ConditionTarget = 1 - check vehicle
- CONDITION_SOURCE_TYPE_GOSSIP_MENU = 1 - check gossip provider
- CONDITION_SOURCE_TYPE_GOSSIP_MENU_OPTION = 1 - check gossip provider
2012-02-15 22:13:27 +01:00
QAston
784d58c023
Core/Db/Conditions: Add new condition types:
...
- CONDITION_OBJECT_ENTRY
- CONDITION_TYPE_MASK
- CONDITION_RELATION_TO
- CONDITION_REACTION_TO
- CONDITION_DISTANCE_TO
- CONDITION_ALIVE
- CONDITION_HP_VAL
- CONDITION_HP_PCT
2012-02-11 15:17:33 +01:00
QAston
9d455c1e6f
Fix build with GCC (it seems like it doesn't allow using references to temporary objects).
2012-02-11 00:15:05 +01:00
QAston
b362377b35
Argh 2.0
2012-02-10 23:54:11 +01:00
QAston
e337790c94
Argh.
2012-02-10 23:52:36 +01:00
QAston
ce4a4ffe50
Core/Db/Conditions: Add ContidionTarget column which allows selection of objects which will be checked by condition, depending on SourceTypeOrReferenceId.
...
So far usable only with CONDITION_SOURCE_TYPE_SPELL:
ContidionTarget = 0 - check caster
ContidionTarget = 1 - check explicit target
2012-02-10 23:42:08 +01:00
QAston
46b9942f97
Core/Db/Conditions: remove ConditionValue2 parameter CONDITION_SPELL which was used for checking if player doesn't have spell and use NegativeCondition parameter instead.
2012-02-10 18:49:40 +01:00
QAston
586a76e3a0
Core/Db/Conditions: Add 3rd parameter to CONDITION_ITEM so it can now perform a check if item exists in bank aswell as in equipment.
2012-02-10 16:47:58 +01:00
QAston
f2f1150761
Fixed build.
2012-02-10 15:43:19 +01:00
QAston
676151f6ac
Core/Db/Conditions: Don't use ConditionValue3 as a reference id for template conditions - ConditionTypeOrReference serves this purpose.
2012-02-10 15:30:33 +01:00
QAston
8713b44ee7
Core/Db/Conditions: Prepare conditions system to work on objects of different type than players.
...
Warning: API has changed a bit:
ConditionScript::OnConditionCheck(Condition* condition, Player* player, Unit* invoker) is now
ConditionScript::OnConditionCheck(Condition* condition, WorldObject* object, WorldObject* invoker)
2012-02-10 14:18:59 +01:00
QAston
e0ad0f0e8d
Minor correction to a7fc2586e7 - load columns from db in the same order they're stored.
2012-02-10 12:54:34 +01:00
QAston
a7fc2586e7
Core/Db/Conditions: Add NegativeCondition column to conditions table which allows to check whenever player does not meet condition specified by ConditionTypeOrReference column (ConditionTypeOrReference and ConditionValue3 set to reference id are not affected by the change)
2012-02-10 12:46:01 +01:00
QAston
5365bd25fa
Core/Spells: remove some workarounds about transform spells in corpse explosion script.
2012-02-09 23:27:59 +01:00
QAston
800cf73750
Core/Spells: Fix some problems with spells summoning to many objects.
2012-02-09 20:27:26 +01:00
QAston
012be16796
Merge pull request #4726 from ille/baa2252bd31718e93ccc3e97aa81afeecb5ec9c3
...
Core/GameObject: implement stealth/invisibility for traps
2012-02-09 09:38:13 -08:00
QAston
b4022acdf3
Core/Spell: move conditions check to Spell::CheckCast.
2012-02-09 18:35:52 +01:00
QAston
0b1da6c0ad
Core/Db/Conditions: update error log.
2012-02-09 18:18:06 +01:00
QAston
e0c699b0f3
Core/Db/Conditions: allow CONDITION_SOURCE_TYPE_ITEM_REQUIRED_TARGET to be used for spells with any spell using unit as explicit target instead of just TARGET_UNIT_TARGET_ANY and TARGET_UNIT_TARGET_ENEMY.
2012-02-09 18:12:47 +01:00
QAston
dc326131a3
Core/Entities: don't save aura caster's guid for pets to db.
2012-02-09 17:19:24 +01:00
QAston
a27758207f
Merge pull request #5096 from devilcoredev/fix_005
...
Core/AI: Fix a bug on some pets introdouced in commit 14bc551862
2012-02-07 23:30:41 -08:00
QAston
84fa96efc6
Once again - a typo fix in 22bd06fc57 - rush is not the best advisor.
2012-02-05 09:18:39 +01:00
QAston
a2494f569e
Merge pull request #5013 from PKX/fix_auras
...
Core/Auras: Fix Pet & Totem aura stacking
2012-02-05 00:14:53 -08:00
QAston
7be73a0667
Merge pull request #5075 from devilcoredev/fix_004
...
Core/AI: Fix pet and other types of minion pet attack on targets with Crowd Controls.
2012-02-05 00:13:56 -08:00
QAston
22bd06fc57
Typofix. Sorry for that :(
2012-02-04 18:28:56 +01:00
QAston
9d185c5d66
Core/Spells: Fix immunity checks on apply aura - original patch by devilcoredev, changed a bit so immunity checks are grouped together instead of being spread.
2012-02-04 15:27:47 +01:00
QAston
6b12f39b35
Merge pull request #4821 from devilcoredev/fix_001
...
Core/AuraScript: Add OnDispel and AfterDispel hook to AuraScript
2012-02-04 06:09:57 -08:00
QAston
92ad375864
Core/Entities: clarify comment added in c7ea952a47
2012-02-03 22:56:42 +01:00
QAston
7e99e5f094
Core/Spells:
...
- rename SpellInfo::IsAOE to SpellInfo::IsTargetingArea due to ambiguity of old name.
- add IsAffectingArea function to check whenever spell or it's effects are affecting objects in area and use new function to fix problems with hunter flares.
Closes #3310 . Thanks to Kaelima and Warpten for research.
2012-02-03 22:24:03 +01:00
QAston
aae833a759
Core/Spells: fix GameObject spell cast on enemies, original patch by Svannon, thanks to horn for research.
2012-02-03 20:07:57 +01:00
QAston
c7ea952a47
Core/Entities: Rename UNIT_FLAG_OOC_NOT_ATTACKABLE and UNIT_FLAG_PASSIVE to UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC respectively. New names tell much more about what those flags do.
2012-02-03 18:46:05 +01:00
QAston
ad4cf93e08
Merge pull request #4785 from Warpten/lastStanding
...
Core/Arenas: Fix achievement [The Last Standing].
2012-01-29 05:50:16 -08:00
QAston
72359b3d11
Db/Quests: fix q13129 quest reward - by Jildor - closes #4633
2012-01-29 14:43:11 +01:00
QAston
1c3064080d
Db/Spells: Correct spell_bonus_data for Empowered Renew - by Wallker, sql formatted by kandera:)
2012-01-29 14:00:05 +01:00
QAston
3b80efe204
Core/Spells: Fix spell Gushing Wound - by kandera - closes #4628 .
2012-01-29 13:52:52 +01:00
QAston
b754f7c91d
Core/Auras: Add some documentation to new proc system code to avoid confusion.
2012-01-17 21:35:27 +01:00
QAston
798677ca54
Merge pull request #4800 from Chaplain/cleanup
...
Core/Spells: Fix issue in CAST_FLAG_ADJUST_MISSILE handling. Thx rsa (R2) for pointing.
2012-01-14 04:43:08 -08:00
QAston
95ad9a992d
Merge pull request #4771 from devilcoredev/fix_001
...
Core/Spells: Fix the 'Trueshot Aura' on pet
2012-01-12 08:33:32 -08:00
QAston
afc18461d7
Core/SpellScripts: Add BeforeCast, OnCast and AfterCast hooks to SpellScripts.
2011-12-31 13:11:12 +01:00
QAston
15bd8f3cd5
Core/Spells: Fix logic in AnyDeadUnitSpellTargetInRangeCheck - spells using this should now correctly check target requirements. This is an alternative fix to #4112 .
2011-12-24 08:40:30 +01:00
QAston
eecc4b58a7
Core/Spells: Use better check for target type in Spell::EffectSendEvent - SpellEffect::GetProvidedTargetMask() is much more accurate than hardcoded dbc index.
2011-12-23 23:52:22 +01:00
QAston
8dd88fa43c
Core/Spells: fix a typo which caused to display unneeded error message (invalid target) during cast of some spells (like warrior charge).
2011-09-28 18:59:55 +02:00
QAston
5f043e6291
Core/Spells: Bring back workaround removed in cd7060c65a - it's needed for compatibility with some scripts.
2011-09-27 22:04:26 +02:00
QAston
7fa2a64290
Merge branch 'master' of https://github.com/Chaplain/TrinityCore
2011-09-27 19:19:25 +02:00
QAston
ee2af420e7
Merge pull request #3235 from Chaplain/cleanup
...
Core/Spell: Hymn of Hope fix.
2011-09-27 10:11:35 -07:00
QAston
23ba776767
Core/Entities: use Unit::GetReactionTo in Unit::IsFriendlyTo and Unit::IsHostileTo
2011-09-27 01:29:20 +02:00
QAston
75aeb15e90
Core/Spells: Allow AOE spells to hit stealthed targets.
2011-09-27 01:13:32 +02:00
QAston
a409cc226c
Core/Spells: Fix Vanish's stealth trigger and Demonic Empowerment's invisibility trigger
...
Those spells were failing to pass default effect trigger spell due to their custom implementation (changing triggered_spell_id instead of adding serverside spells with proper targeting).
2011-09-27 00:36:23 +02:00
QAston
a2633bf7fc
Scripts: fix spell_generic_quest_update_entry script after e949ad3adb.
2011-09-27 00:12:45 +02:00
QAston
210a770958
Core/Spells: Fix totem passive area auras stacking bug.
2011-09-25 19:00:37 +03:00
QAston
e949ad3adb
Core/Spells: spell effect handling improvements
...
* Call spell effect handlers in 4 modes:
- SPELL_EFFECT_HANDLE_LAUNCH - called when spell is launched (cast just finished)
- SPELL_EFFECT_HANDLE_LAUNCH_TARGET - called when spell is launched for each target in spell target map
- SPELL_EFFECT_HANDLE_HIT - called when spell hits its destination
- SPELL_EFFECT_HANDLE_HIT_TARGET - called when spell hits it's target from spell target map
*Correctly implement SPELL_EFFECT_TRIGGER_SPELL, SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL
*Remove spell system hacks which became obsolete with this commit
Core/SpellScripts:
add OnEffectLaunch, OnEffectLaunchTarget, OnEffectHit, OnEffectHitTarget hooks for new effect handle modes and remove OnEffect hook.
A generic rule of thumb how to update your scripts (will work for nearly all cases) for spell system noobs:
if your spell script used GetHitXXXX function, you need to use OnEffectHitTarget, otherwise use
OnEffectHit
2011-09-25 13:29:50 +02:00
QAston
cd7060c65a
Core/Spells: Add more generic overload for Unit::CastSpell function and make all cast functions use it as a base.
2011-09-24 16:41:50 +02:00
QAston
d01a761f53
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:02:39 +02:00
QAston
71bbbaa21b
Merge pull request #3146 from Havenard/fix0001
...
Reimplement WorldObject::IsInBetween() to work as intented.
2011-09-23 06:04:17 -07:00
QAston
413b542cd9
Add a tempfix for trigger missile spell effects after rev 13a1d90130.
2011-09-23 13:09:31 +02:00
QAston
13a1d90130
Core/Spells: Improvements in selecting default targets based on effect type.
2011-09-23 11:58:40 +02:00
QAston
29fef71137
Merge pull request #2915 from idostyle/armorPen
...
Core/Mechanics: Cap armorPen to maxArmorPen - prevents having armor penetration rating greater than 100%.
2011-09-22 02:03:14 -07:00
QAston
a0030ef334
Really fix build (sorry for that:()
2011-09-21 11:06:31 +02:00
QAston
87d9a1d384
Scripts/TwinValkyr: Fix build.
2011-09-21 10:40:11 +02:00
QAston
1881765540
Correct names of todays update SQLs.
2011-09-21 10:37:49 +02:00
QAston
e2e784e7ea
Merge pull request #3086 from LihO/master
...
Core/Groups: Refactored sending of update packets.
Closes #1042 .
2011-09-21 01:05:53 -07:00
QAston
d628145d95
Merge pull request #3143 from megamage/master
...
Threat manager. Fix crashes #2396 and #2992 .
2011-09-21 01:03:53 -07:00
QAston
82bc917265
Merge pull request #2908 from Drethek/TwinsValk
...
Scripts:
Twins Valk - Cleanup / Remove Hardcoded Bullet Spawn (Need DB Support - Stalkers Spawns)
Acidmaw - Use Correct Submerge Spell
Trial Of Crusader - Correct Coordinate Spawn
Trial Of Crusader - Correct Open/Close Main Door Timer
Trial Of Crusader - Open/Close On Boss EnterEvadeMode
2011-09-21 00:27:20 -07:00
QAston
8c2e58d036
Core/Entities: Allow 2 side parties to work.
2011-09-17 13:45:07 +02:00
QAston
a2d9aabbb3
Core/Entities: Allow creatures to attack players while in sanctuary.
2011-09-17 01:50:53 +02:00
QAston
fe25ce4fa3
Core/AI: Replace many Unit::IsHostileTo with Unit::IsValidAttackTarget or Creature::canCreatureAttack.
2011-09-17 00:56:59 +02:00
QAston
580264b5a5
Core/Entities: Remove obsolete function Unit::canAttack.
2011-09-16 23:51:01 +02:00
QAston
c0b1823524
Core/Entities: Replace Unit::canAttack usage with more accurate Unit::IsValidAttackTarget
2011-09-16 23:49:31 +02:00
QAston
3a3f2d927f
Core/Misc: Whitespace and a minor typo fix (thanks Kapoeira)
2011-09-16 22:37:49 +02:00
QAston
9bbb4ef583
Core/Spells: Use Unit::IsValidAttack/AssistTarget functions to validate spell explicit targets.
2011-09-16 22:17:49 +02:00
QAston
31e755c291
Core/Entities: Add Unit::IsValidAssistTarget and Unit::IsValidAttackTarget functions for proper serverside checks of related entity flags.
2011-09-16 22:17:48 +02:00