Commit Graph
100 Commits
Author SHA1 Message Date
leak 3252836f91 Memory leak fixed
--HG--
branch : trunk
2010-12-22 21:53:24 +01:00
Shauren cef7c4d4f3 Core/Spells: Fixed "unprocessed tail data" packet spam for CMSG_CAST_SPELL
--HG--
branch : trunk
2010-12-22 21:32:48 +01:00
click b1ded4bd98 Core/Unit: Check if NPC is on a transport before sending StopMoving() -packet (normally shipped when trying to speak to moving NPCs) - fixes creatures falling off boats etc.
Thanks to Socolin for hunting down and patching this annoying bug.

--HG--
branch : trunk
2010-12-22 21:31:52 +01:00
Shauren 0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren 0948fc5bbe Core: Converted (hopefully) all remaining singletons to use ACE_Singleton class
--HG--
branch : trunk
2010-12-22 20:52:47 +01:00
Shauren 7b4e1c6387 Core/ObjectMgr: Static members are no longer accessed through singleton
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
Shocker 446c300505 Core/Spells: Small cleanup in SpellEffects, spells always have caster
--HG--
branch : trunk
2010-12-22 20:18:34 +02:00
Shocker 42304c0b25 Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
--HG--
branch : trunk
2010-12-22 20:14:30 +02:00
Machiavelli 12c970f5dc Missing DELETE statement in 10765_world_spell_dbc.sql
--HG--
branch : trunk
2010-12-22 18:49:56 +01:00
Machiavelli d9ba90d277 Scripts/Ulduar:
- Fix Rune of Summoning + use correct spell for Lightning Elemental passive + fix a crash
- Fix Rune of Power - thanks to Shauren for spell target help (see DB data)
** Note: Aura system bug causes Rune of Power aura to be reapplied every 0.5 second
- Prevent engaging bosses one by one
- Respawn bosses if encounter failed
- Fix supercharge appliance and stacking
- Add a few missing changes to instance data saving fix from a85e26e211
- Cleanup

--HG--
branch : trunk
2010-12-22 17:40:12 +01:00
Spp 80a5cda77f Core/Dungeon Finder: Fix wrong join result when joining with random dungeons and there are disabled dungeons. If no disabled dungeons players also got the same problem if they have done an heroic dungeon today
Thanks to j4r0d for the help spotting the error and testing

--HG--
branch : trunk
2010-12-22 13:20:18 +01:00
Shocker 09afac2838 Scripts/Ulduar: Typo fix for Gravity Bomb from XT-002 Deconstructor, thanks to georgiosburnham, closes issue #5226
--HG--
branch : trunk
2010-12-22 08:59:11 +02:00
silinoron 82d1a40ed5 Core/Buildsystem: Turn on SFMT by default, as we believe it is fixed. Please do test it for us!
Note: Computers with processors older than Pentium 4 will need to have this turned off.

--HG--
branch : trunk
2010-12-21 20:21:21 -08:00
leak 6115b0bd5f Removing ProgressBars as they are performing badly on startup.
[**************************************************] 100%
R.I.P

--HG--
branch : trunk
2010-12-22 00:12:03 +01:00
Spp a45a039e73 Fix typo in previous commit :S
--HG--
branch : trunk
2010-12-21 23:21:12 +01:00
Spp f33f51c287 Core/Dungeon Finder: Fix problems when joining queue
- Fix Rolechecks
- Fix incorrect dungeon stored when queued as individual:
  * Those that joined as random were only matching with others that joined random
  * Teleport location was incorrect.

Closes issue 5161
Updates issue 5162

--HG--
branch : trunk
2010-12-21 23:16:09 +01:00
Spp 0c44943cd2 Core/Dungeon Finder: Multiple changes
- Simplify lock status calculations by caching player locked dungeons
- Fix incorrect Lfg State loading for groups
- All reference variables that are supposed not to be modified are declared as const
- Use full group guids in rolechecks
- Add some debug msgs
- Fix some warnings

--HG--
branch : trunk
2010-12-21 22:33:17 +01:00
leak 68ed96989a Core/Entities: Include prismatic sockets in gem equipment limitation checking. (Stops equipping more than 3 JC gems)
--HG--
branch : trunk
2010-12-21 23:14:38 +01:00
leak c4b538a1b6 Pdump load fixed once again..
--HG--
branch : trunk
2010-12-21 21:41:07 +01:00
leak 739a3b9165 Core/ObjectMgr: Simplify trainer spell loading. Should decrease loading time on decently sized machines
--HG--
branch : trunk
2010-12-21 20:26:59 +01:00
click 31334b8770 Core/Dependencies: Temporarily fix an RFC-breaking addition in gSoap (upstream developers have been notified)
+ local changes and diff (tc_changes.diff) included for future reference

--HG--
branch : trunk
2010-12-21 18:40:54 +01:00
Machiavelli 186ec40571 Typo, thanks Shauren for spotting
--HG--
branch : trunk
2010-12-21 15:51:51 +01:00
Machiavelli c08d04365d Script/Ulduar:
- Fix instance data loading from DB
- Return correct guid for GetData(TYPE_HODIR)

Thanks to Socolin for reporting the errors

--HG--
branch : trunk
2010-12-21 15:47:09 +01:00
Machiavelli 30c55a4a97 Scripts/Ulduar: Remove a silly coordinate based reset condition in Ignis script
--HG--
branch : trunk
2010-12-21 13:53:29 +01:00
Machiavelli 0d947f260f Scripts/Ulduar: Fix logic error in Tympanic Tantrum timer (XT-002)
--HG--
branch : trunk
2010-12-21 13:40:12 +01:00
Machiavelli 2bacf7ee66 Scripts/Ulduar: Fix slow effect on ¨A Pool of Tar¨ (Flame Leviathan encounter)
--HG--
branch : trunk
2010-12-21 13:29:53 +01:00
Shauren 5809c1fa3b Core/Auras: Fixed auras incorrectly stacking with different item casters introduced in r19f21916a940
Closes issue #5218.

--HG--
branch : trunk
2010-12-21 11:40:20 +01:00
click 5180ed0383 Core/AuthServer: Fix the previous commit (it might help to actually fetch what we want to work on as well)
--HG--
branch : trunk
2010-12-21 05:57:53 +01:00
click 2f80f1b2f8 Core/AuthServer: Allow reauthentication to the authserver on realm logout. Thanks to .. someone (webmaster?)
Fixes issue 4191.

--HG--
branch : trunk
2010-12-21 05:50:19 +01:00
click a22818ae09 Core: Some more updates on the gossipicons from previous commit
--HG--
branch : trunk
2010-12-21 05:26:48 +01:00
click 6c5a50f24d Core: Add support for 20 different chaticons in gossip (mostly copies of GOSSIP_ICON_CHAT)
--HG--
branch : trunk
2010-12-21 03:52:40 +01:00
click c96070e804 Core: Remove some now defunct code and configoptions. Thanks to 4178something...
Closes issue 5213.

--HG--
branch : trunk
2010-12-21 02:44:37 +01:00
Shocker 9fd0caf9a5 Core/WorldSocket: Fix a crash in HandleAuthSession
--HG--
branch : trunk
2010-12-21 01:48:09 +02:00
Shauren 89f2870b97 Core/Auras: Save cast item guids for auras to db
--HG--
branch : trunk
2010-12-20 14:55:36 +01:00
Shauren 834285c86d Oops, fixed compile
--HG--
branch : trunk
2010-12-20 12:06:12 +01:00
Shauren 3fefb13bd4 Scripts/Silithus: Fixed some int -> float casts, should fix invalid coord error
--HG--
branch : trunk
2010-12-20 12:03:23 +01:00
Shauren e3e77aceab Scripts/Temple of Anh'Qiraj: Fixed possible crash in mob_anubisath_sentinel
--HG--
branch : trunk
2010-12-20 11:39:12 +01:00
Shauren 756ee5832b Core/Auras: Allow stacking of auras proced from different items
Closes issue #2296.

--HG--
branch : trunk
2010-12-20 11:04:48 +01:00
azazel 6ec717ed5b Scripts/HoL:
* fix Volkhan script: after losing 20% HP Volkhan is supposed to run back to his Anvil and smack it with his hammer. 3 Golems are supposed to fly out of it and spawn (by LethalInjectionX) Closes issue #3895
* fix instance doors to remain open after use (by msholto) Closes issue #4773
Both fixes tested and approved by Aokromes.

NOTE: Do not forget the DB part of the commit!

--HG--
branch : trunk
2010-12-20 14:59:39 +06:00
click 61d6397559 Core/Buildsystem: Adjust the variable so it works on MSVC9 again (danged MS and renaming variables)
--HG--
branch : trunk
2010-12-20 02:54:04 +01:00
leak 4c9cfa6739 Core/Buildsystem: Resolved quoting problem that caused gcc to spam warnings. Patch by click.
--HG--
branch : trunk
2010-12-20 02:23:55 +01:00
Machiavelli 33808ab567 Core/Spells: Fix Improved Spirit Tap proc from Mind Flay crits.
Author: Dr.Tenma
Fixes issue #2786

--HG--
branch : trunk
2010-12-20 01:58:15 +01:00
Machiavelli f71c97f6c5 Core/Items: Fix ITEM_SPELLTRIGGER_ON_NO_DELAY_USE (5). This trigger should (only) trigger the respective spell when the item is added to the inventory. Aura´s created by this spell will be properly removed when the item is destroyed as well.
--HG--
branch : trunk
2010-12-20 00:46:00 +01:00
Machiavelli baff745be1 Core/Spells: Fix Improved Felhunter mana energize part.
Based on code by Karolis.Rudzevicius
Fixes issue #2125
Fixes issue #2109

--HG--
branch : trunk
2010-12-20 00:35:11 +01:00
Shauren 85d69dc73d Scripts/Spells: Explicitly remove all other auras with the same id when applying Animal Blood (46221)
--HG--
branch : trunk
2010-12-19 20:03:56 +01:00
QAston 251f7f2121 Core/Auras: Add some assertions to make sure that AuraEffects are not added twice to UnitAuraEffect containers.
--HG--
branch : trunk
2010-12-19 19:43:53 +01:00
Machiavelli 60ce3fdbd2 Core/DBLayer: Add MySQL errno´s 1058 and 1062 (related to query-correctness) to handled errno´s (=doesn´t require further actions from the core)
--HG--
branch : trunk
2010-12-19 18:01:06 +01:00
Machiavelli 5e826806ba Core/Aura´s: Remove a redundant NULL check, because QAston saideth so.
--HG--
branch : trunk
2010-12-19 17:50:50 +01:00
Machiavelli cbbcfa03f3 Core/DBLayer: Minor padding/alignment optimization in struct Field::data (16b->10b)
--HG--
branch : trunk
2010-12-19 17:48:47 +01:00
leak ff3dc410ed Typo in recent commit
--HG--
branch : trunk
2010-12-19 17:14:54 +01:00
leak fd694cd232 Streamlining loading functions for server startup
- Added a couple of timer outputs
- Improved code consistency between loading functions
- Progess bars should look and behave similar on all OS now (sLog.outString() is not needed anymore to replace the progress bar in log files)

--HG--
branch : trunk
2010-12-19 17:06:33 +01:00
click 9c35e10444 Core:DBLayer: Fix warning on GCC
--HG--
branch : trunk
2010-12-19 16:29:51 +01:00
Machiavelli dfd82c2fad Core/DBLayer: Use mysql_set_character_set in MySQLConnection::Open instead of explicit string queries
Also possibly fix an absolutely useless warning on GCC

--HG--
branch : trunk
2010-12-19 16:13:45 +01:00
Machiavelli e2a8dfffbe Core/DBLayer:
- Add generic HandleMySQLErrno() method.
- Add the ability to re-execute a certain statement if errorhandler resolved the situation succesfuly.
- Add support for MySQL errno´s 2006, 2013, 2048, 2055 - fixes automatic reconnection behaviour.
- Cleanup in affected code

NOTE: You should still be smart enough to configure your worldserver and authserver´s MaxPingTime to be lower than your MySQL´s wait_time.

--HG--
branch : trunk
2010-12-19 15:48:55 +01:00
Shauren 14a480cb13 Core/Players: Fixed recently introduced crashes in Player::ApplyEnchantment
Closes issue #5193.

--HG--
branch : trunk
2010-12-19 15:22:19 +01:00
Shauren c35947816c Scripts/Trial of the Crusader: Fixed possible crashes in announcer gossip
Closes issue #3850.

--HG--
branch : trunk
2010-12-19 14:46:13 +01:00
Shauren a4f437a523 Core/GameObject: Dismount the player when using spellcaster gameobject
Closes issue #2539.

--HG--
branch : trunk
2010-12-19 11:56:37 +01:00
linencloth 59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
linencloth 22928e23bd Core: Replace spell attribute defines with enums
--HG--
branch : trunk
2010-12-19 04:11:44 +01:00
linencloth 2fbbcc477c Core/InstanceSaveMgr: Cleanup for better readability
--HG--
branch : trunk
2010-12-19 01:23:36 +01:00
linencloth 4193806dba Core/InstanceSaveMgr: Prevent timer underflow by passing resetTime instead of timeLeft
--HG--
branch : trunk
2010-12-19 00:59:04 +01:00
Machiavelli 837e50ea23 Core/Spells: Allow aura´s with SPELL_AURA_MOD_THREAT (10) to properly reduce threat modifiers on death.
Inspired by effort of james.gml
Fixes issue #3444

--HG--
branch : trunk
2010-12-19 00:38:35 +01:00
Shauren 8d76329eff Scripts/Temple of Ahn'Qiraj: Its generally not a good idea to delete stuff before using it; fixed crash
Closes issue #4357.

--HG--
branch : trunk
extra : rebase_source : b829284f60e2b55f8e79db72751252cc6619e59a
2010-12-19 00:27:38 +01:00
linencloth 12e046e45e Core/InstanceSaveMgr: Replace some queries with executes as the result isn't needed
(thanks to Machiavelli for the idea and for spotting these forgotten lines)

--HG--
branch : trunk
2010-12-19 00:04:27 +01:00
Shauren 43377b4daf Core/Players: Remove player from transport before teleporting to graveyard, will fix infinite recursion when trying to access unavailable map
Core/Auras: Removed unneeded typecasting

Closes issue #4862.

--HG--
branch : trunk
2010-12-19 00:01:22 +01:00
linencloth a8214a682a Core/InstanceSaveMgr: Optimize instance packing and cleaning up
--HG--
branch : trunk
2010-12-18 23:43:44 +01:00
linencloth 454444a1af Core/MovementGenerators: Remove evade state when HomeMovementGenerator gets destroyed without finishing the movement
--HG--
branch : trunk
2010-12-18 23:01:42 +01:00
Machiavelli a093408360 Core/Player: Convert _SaveAuras to prepared statement format
--HG--
branch : trunk
2010-12-18 23:25:03 +01:00
Shauren 7196b880d6 Core/Spells: Fixed possible crashes in Shadow's Fate proc (71169) introduced in r91073dc6ace3
Core/AuctionHouse: Removed "using namespace std" and fixed crash in AuctionHouseMgr destructor

Closes issue #5132.
Closes issue #5134.

--HG--
branch : trunk
2010-12-18 23:16:55 +01:00
Shauren 3ad400ad1a Scripts/Obsidian Sanctum: Removed unneeded code causing crashes
Closes issue #5191.

--HG--
branch : trunk
2010-12-18 22:22:25 +01:00
silinoron f339ced1bf merge
--HG--
branch : trunk
2010-12-18 13:07:15 -08:00
silinoron 41a9d3216c Core/Auras: Fix Cold Blood handling on misses and parries.
Patch by dr.tenma.
Fixes issue #2291

--HG--
branch : trunk
2010-12-18 13:06:38 -08:00
Shauren 24193966dd Core/Auras: Fixed crash in AuraEffect::TriggerSpell (dummy effect) and removed some useless code
Scripts/AI: Changed sOnDummyEffect to return bool value

Closes issue #5190.

--HG--
branch : trunk
2010-12-18 22:04:19 +01:00
Supabad 8ce0abbbc8 Scripts/Obsidian Sanctum Add support for when encounter is in progress. thnx to kiper
--HG--
branch : trunk
2010-12-18 18:07:24 +01:00
click e75d16b813 Core/Dependencies: Adjust jemalloc library caching methods - this will fix the startup-crash on linux-based systems.
Note: This is a temporary measure untill we've figured out why this occurs, further testing will be done.

--HG--
branch : trunk
2010-12-18 16:14:08 +01:00
Machiavelli 535d81db4b Core/Social: Really show correct count (matches + displayed) in SMSG_WHO now (switch position of 2 numbers).
--HG--
branch : trunk
2010-12-18 16:09:50 +01:00
leak 525a1e0ff0 Core/Entities: Remove gem bonuses if requirements of prismatic sockets are not met
Closes issue 4949.

--HG--
branch : trunk
2010-12-18 15:56:55 +01:00
leak 04e4561134 Prevent completing quests by packet manipulation
--HG--
branch : trunk
2010-12-18 15:29:11 +01:00
Machiavelli 57132e35b8 Core/Spells: Fix spells 59915 and 59906 / Discerning Eye of the Beast and Swift Hand of Justice (Heirloom trinkets)
Fixes issue #2435
Fixes issue #2529

--HG--
branch : trunk
2010-12-18 12:27:40 +01:00
click 785d5a94a6 Core/Dependencies: Update jemalloc library from v1.0.0 to v2.1.0 (latest stable)
--HG--
branch : trunk
2010-12-18 02:31:10 +01:00
click 0054bd83d8 Buildsystem/Linux: Fix linking of a long lost little child : jemalloc (yes, it has returned, and is now actively linked again)
--HG--
branch : trunk
2010-12-18 01:36:00 +01:00
Shauren 4a067d5095 Fixed build i broke
--HG--
branch : trunk
2010-12-17 20:48:55 +01:00
Shauren ecd2fbb2b1 Scripts/Vault of Archavon: Cleaned and simplified scripts, fixed Toravon's Frozen Orb summon count
Closes issue #2857.

--HG--
branch : trunk
2010-12-17 20:37:20 +01:00
Machiavelli 32d94ed52a Core/Units: Aura´s of type SPELL_AURA_MOD_RESISTANCE_EXCLUSIVE (143) should stack with eachother in the way that only the strongest aura of each magical school applies.
Author: Iskander
Fixes issue #3897

--HG--
branch : trunk
2010-12-17 20:31:46 +01:00
click 97f912fe93 Core/Pets: Use the safer pet level check-method in SynchronizeLevelWithOwner() too (forgotten in previous commit)
--HG--
branch : trunk
2010-12-17 20:27:36 +01:00
click 0785ad465b Core/Pets: Clean up logic/codedesign slightly for XP/levelup-handling, and also fix a possible overflow in the pet level-tests
(Thanks to Vladimir for the discussion regarding the possible overflow!)

--HG--
branch : trunk
2010-12-17 20:08:27 +01:00
Machiavelli e867481ccb Fix a typo in 52d8bc05c3
--HG--
branch : trunk
2010-12-17 19:27:09 +01:00
Shauren 3df2310417 Core/Auras: Fixed Festive Holiday Mount transformation (3.0.8 update)
--HG--
branch : trunk
2010-12-17 19:03:12 +01:00
Shauren 21f6248726 Core/Spells: Fixed diminishing returns for positive/event spells, patch by DrTenma
--HG--
branch : trunk
2010-12-17 18:21:37 +01:00
Shauren b11e5bbf81 Core/Achievements: Prevent ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL updates at login
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL_AT_AREA
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_TEAM_RATING
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_REACH_TEAM_RATING
Core/Achievements: Implemented map id requirement for achievement criterias

Closes issue #4479.
Closes issue #4478.
Closes issue #4473.
Closes issue #4472.
Closes issue #4471.
Closes issue #4480.
Closes issue #2284.
Closes issue #4481.

--HG--
branch : trunk
2010-12-17 18:12:46 +01:00
Machiavelli 1cdeb4d057 Core/Player: Change equipmentset saving to use prepared statements.
Update issue #4550
Please try to re-reproduce

--HG--
branch : trunk
2010-12-17 17:29:16 +01:00
Machiavelli d38b171391 Core/DBLayer: CharacterDB query CHAR_LOAD_PLAYER_ACTIONS_SPEC should be synchronous. Fixes a crash introduced in bd30ad7bd3
--HG--
branch : trunk
2010-12-17 16:54:38 +01:00
Machiavelli 0a8c99e02c Core/Social: Fix SMSG_WHO. Packet should contain number of players matching given criteria + number of players displayed, instead of total number of players online + number of players displayed.
Fixes issue #4886

--HG--
branch : trunk
2010-12-17 16:36:01 +01:00
Machiavelli 8a196ba4b0 DB/Commands: Add some missing entries to commands table.;
Author: svetilo12
Closes issue #5015

--HG--
branch : trunk
2010-12-17 16:06:47 +01:00
Machiavelli 04e5be6276 Core/DBLayer: Add some garbage collection on DatabaseWorkerPool shutdown (deleting SQLOperation objects)
--HG--
branch : trunk
2010-12-17 16:02:09 +01:00
Machiavelli cb08ec0d74 Core/DBLayer: Don´t prepare asynchronous statements on synchronous connections and vice versa. Prevents allocating RAM that will never be used.
--HG--
branch : trunk
2010-12-17 15:55:16 +01:00
Machiavelli 57d72fa708 Core/Scripts: Prevent double call to mob_acolyte_of_shadronAI::Reset() which applies encounter-related aura´s to certain creatures. Reset() was called from AIM_Initialize and prior to that the AI factory selector
Update issue #5152
Please try to re-reproduce

--HG--
branch : trunk
2010-12-17 14:58:23 +01:00
Spp fa6f2ee9d9 Core/Dungeon Finder: Fix typo, debug msg was supposed to be logged to debug (not error)
--HG--
branch : trunk
2010-12-17 13:45:41 +01:00
Shauren 82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
Spp ee3fd3ebeb Core/Vehicles: Fix facing adjustment. Patch by beberlescaraber
closes issue #1810
updates issue #4714

--HG--
branch : trunk
2010-12-17 13:22:17 +01:00