Commit Graph
26318 Commits
Author SHA1 Message Date
Wyrserth 2fea2a1e81 Core/GameObject: do not allow consumable chests to restock while partially looted.
(cherry picked from commit cd73664f53db3daad6c7e17edbcd0212ab383c0d)
2021-12-13 00:42:18 +01:00
Wyrserth f136d3cfe0 Core/GameObject: fix some cases where summoned gameobjects of a type different than chest or goober would behave wrongly.
(cherry picked from commit 9f0ac0c24376ec70b8227a8fb0a1e0e686cb3256)
2021-12-13 00:42:18 +01:00
Wyrserth 575f42089e Core/Spell: fix some issues with taunt spells (#23425)
(cherry picked from commit 5dc2dfd60c4ecd243729e86496d926976e383156)
2021-12-13 00:42:18 +01:00
Wyrserth 9d40a105e6 Core/Mail: include 100g in the mail sent after turning in the quest The Wrath of Neptulon (#23500)
(cherry picked from commit cf223370f3345a7cfa39f8bfb23835391603f985)
2021-12-13 00:42:18 +01:00
Wyrserth 5c5bcba65a Script/ZulGurub: rewrite High Priest Thekal's encounter script (#23429)
(cherry picked from commit 365e2f191efa5576c0045a9ebdffe63e1ea3bac7)
2021-12-13 00:42:18 +01:00
Wyrserth c637260a37 Core/GameObject: implement restock mechanic for non-consumable gameobjects (#23526)
(cherry picked from commit e77c2d55c40bc9d4a15de471de754376f4ec1c49)
2021-12-13 00:42:17 +01:00
Wyrserth d197a7ce9b Core/SAI: add param3 to SMART_ACTION_CALL_TIMED_ACTIONLIST to allow it to override a currently running actionlist.
(cherry picked from commit eeba12778b330f799eab1530da14bcd8a01b8269)
2021-12-13 00:42:17 +01:00
Wyrserth 7c7bb95da5 Core/GameObject: restore old behavior for non-consumable chests with restock timer (make them despawn).
(cherry picked from commit 50c5d30d13fe12af2a2028baf845fb6eab329a57)
2021-12-13 00:42:17 +01:00
Wyrserth 836a1bc622 Core/GameObject: don't allow non-consumable goobers to despawn on use (#23469)
Closes #15730.

(cherry picked from commit 2b1e8d135bd3f3a3ddf7f29471cf6116da223175)
2021-12-13 00:42:17 +01:00
Wyrserth 09e849bb69 Core/Spell: allow damage from binary spells to go through elemental resistance's damage reduction. (#23479)
(cherry picked from commit efc999227d87398b25e04a3fba881c27de8135f3)
2021-12-13 00:42:17 +01:00
Wyrserth 83a9222c39 Core/SAI: allow creatures to handle gameobject spellhit SAI events. (#23492)
(cherry picked from commit 7a71127da92bd833caf4188aee2d5e88c61ae772)
2021-12-13 00:42:17 +01:00
Wyrserth 62f5d9b46b Core/SAI: do not pass old creatureData to UpdateEntry() and keep current health when changing a NPC's entry. (#23493)
(cherry picked from commit 8967cc96df4c1c5c7465e9fd1fa66400f3e992b3)
2021-12-13 00:42:17 +01:00
Keader adc16ffbdc Script/FoS: prevent Wailing Souls from becoming desynched in the Devourer of Souls encounter.
(cherry picked from commit 079b77b5fc466f806cb64206881f0034cce61670)
2021-12-13 00:42:17 +01:00
Wyrserth 902a6f17dc Script/CoS: fix DB error and remove wrong on-death text for Chrono-Lord Epoch.
(cherry picked from commit 22b222b44e2f26900568af2ebdb92bf19185cfb9)
2021-12-13 00:42:17 +01:00
Aokromes 30cec73c61 Coding standards (#23514)
* Coding standards

* revert part

(cherry picked from commit fe744977c917957e112704ccd66e228b826b3f7a)
2021-12-13 00:42:17 +01:00
Treeston c9d52c9547 Core/AI: Actually accurately reproduce the logic from before 8499434 that determines what summons start following on appearance. Third time's the charm?
Closes #23513.

(cherry picked from commit 3cdf27494ffe18d674a37561a2c573517a2cb533)
(cherry picked from commit 63383da36e27657734cba6ad23c1bd3d68039d90)
2021-12-13 00:42:16 +01:00
ccrs eda6e5c316 Script/CoS: full instance rewrite (#23388)
(cherry picked from commit ca6228067507f19db230d415a1d088e5c0b5b808)
2021-12-13 00:42:16 +01:00
Wyrserth e8c1adcf8f Core/SAI: silence wrong SAI error when using SMART_ACTION_SET_DATA on a creature using CreatureAI.
This behavior is fully allowed and should not report any kind of error.

(cherry picked from commit c95531595e666c64829499d2bc920cf5b848bbe2)
2021-12-13 00:42:16 +01:00
Shauren 54f607641a Core/Spells: Moved SpellVisual functions from Unit to WorldObject 2021-12-12 19:34:00 +01:00
Shauren f61de627e5 Core/Commands: Fixed crash in .npc showloot 2021-12-12 19:19:29 +01:00
Shauren 9951b53808 Core/Misc: Fixed some gcc warnings 2021-12-12 19:19:15 +01:00
Meji 1a84641549 Core/BattlePets: Added default cooldown to revive battle pets (#27383)
* Added SpellHistory function to retrieve remaining category cooldown
* Changed SpellHistory::ModifySpellCooldown to allow adjusting only regular spell cooldown without touching category
2021-12-12 18:35:15 +01:00
Shauren 1c00109756 Core/Creatures: Fixed crash in CreatureAI::JustAppeared caused by scripted summons without SummonProperties
Closes #23507

(cherry picked from commit c0b25c9a83126bfd26da8245a31ea684008d804d)
2021-12-12 02:20:42 +01:00
ccrs 4747debed1 Core/Player: 72fc79a followup
safer approach, please report any returning issue

(cherry picked from commit 337de2b61e9df6a8d8b3ff2d0076f35345c33907)
2021-12-12 02:16:42 +01:00
ccrs a4da12119e Scripts/Misc: couple corrections to the recent PRs
(cherry picked from commit 4a8736b82924acf109970d317aa493b19914cea1)
2021-12-12 02:16:01 +01:00
ccrs f4a71ea9aa Core/AI: remove extra empty line
(cherry picked from commit 3c77c04b052f721efb96bdaaceeca8de09926f12)
2021-12-12 02:15:10 +01:00
ccrs d7e544e816 Core/AI: minimize further undesired behaviours (e3e4b97 followup)
Those Category checks come from checking all Spell::SummonGuardian uses

(cherry picked from commit ebd438883e31de4482617631ff9939f2246fda69)
2021-12-12 02:15:00 +01:00
Treeston 007eb8c931 AI/TotemAI: Tell Shaman Totems to stay put and stop moving. Closes #23498.
(cherry picked from commit e3e4b975ce1a7a4aa75d61aff7ab3da287b3ceff)
2021-12-12 02:13:19 +01:00
Treeston 743d022cee AI/SmartAI: Properly forward to inherited CreatureAI::JustAppeared in SmartAI::JustAppeared. Fixes #23491.
(cherry picked from commit 854a113fc7b6610873b77355aed88900ce3b5bc0)
2021-12-12 02:11:15 +01:00
Treeston 38d7c1530a Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490.
(cherry picked from commit 1158f267df22c0782fb5f20f7de31f5643ac0b58)
2021-12-12 02:09:15 +01:00
Treeston e398bb1664 AI/SmartAI: Move SMART_EVENT_RESPAWN invocation from ::InitializeAI() to ::JustAppeared(). Closes #23313.
(cherry picked from commit 37fc38b91701c3e699b20f3ed8de8da3b5c42063)
2021-12-12 01:27:04 +01:00
Treeston 9f7d3ebd6a Core/AI: Remove EnterEvadeMode calls from Guardian/Summon spell handlers. Add follow logic to CreatureAI::JustAppeared. Closes #23270.
(cherry picked from commit 8499434340919902b5aefe58f812c3f24d37310d)
2021-12-12 01:27:04 +01:00
Treeston f9b8fe686d Entities/Unit: Adjust an overzealous assert to not catch self references, and add the inverse assert too. 396f87c follow-up.
(cherry picked from commit aeed616c22868e2c5759c01d2c0feb52a7c3bc97)
2021-12-12 01:27:04 +01:00
Treeston d10554da14 Entities/Unit: Fix an issue where Unit pointers could be left dangling if a channeled Charm was interrupted by a control aura application. Closes #23440.
(cherry picked from commit f4b06fd0b7ead843bba8f5215a09abf7976e012c)
2021-12-12 01:27:04 +01:00
Treeston edc7583119 Entities/Unit: Cleanup all the direct accesses to m_unitMovedByMe. Refactor the field to be protected. Add assertions to catch dangling pointers.
(cherry picked from commit 396f87c30dff1b50f1eb0d924778a7fbab7e8d11)
2021-12-12 01:26:41 +01:00
Treeston 06823f19cd Core/Misc: Add static versions of GetGUID and ToX methods to Object. The static versions return Empty/nullptr for null objects.
(cherry picked from commit b3ee407707db01a5bc49f544a56b1db381687f65)
2021-12-12 00:46:03 +01:00
Treeston f29644efd5 some more cleanup, a5f8c0d follow-up
(cherry picked from commit 00728cef1565a78b39541fbaea5923dcfc243743)
2021-12-12 00:33:36 +01:00
Treeston e3411b4740 Core/Creature: Attach out-of-combat health regen to the Engaged system, not the Combat flag. Closes #21571.
(cherry picked from commit a5f8c0d30ca8793a0d1f97a16ab0e0a9f066dab4)
2021-12-12 00:33:23 +01:00
Treeston dabdad3b47 Core/Misc: Rename Unit::AttackedTarget to Unit::AtTargetAttacked to match naming scheme for these notifiers
(cherry picked from commit 632a300dd20aad9663392c2f21a8ed29ffee1ef7)
2021-12-12 00:33:18 +01:00
Treeston 35e55f1089 Core/Entities: Kick engagement logic upstairs to Unit (from ThreatManager), since all Units with AI need it (not just those with threat list). Fixes #17981.
(cherry picked from commit dbe3bbefe734f8824e8f07c302e256f0d446b974)
2021-12-12 00:31:15 +01:00
jackpoz dd22c6fe67 Core/Misc: Code cleanup
(cherry picked from commit eeced9ae158640de67ed0cb59d01ae92570bfa77)
2021-12-11 23:20:05 +01:00
zartech22 1c3c59d7fa Core/Instance : Fix instance resetting exploit (#23263)
* Push offline players out of instance

Push offline players out of instance when reseting dungeon with a raid mode group

* Add SQL request to character

Add a SQL request to update the position of a player in a specified map

* Teleport to graveyard instead

(cherry picked from commit 678e0e606aa38e18fd361c33bc91833fdae76735)
2021-12-11 23:12:27 +01:00
Sorikoff 799fba7fd1 Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind (#23463)
* Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind

* Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind"

This reverts commit a8055960

* Revert "Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind""

This reverts commit a5be792b

* Fix NoPCH

* Clean up

* Clean up

* fixup! Clean up

* Caster -> Target

* Rename 9999_99_99_99_world.sql to 2019_06_22_01_world.sql

(cherry picked from commit ac7c72d63392cc246d2cd4ab64f558f2bf0970bf)
2021-12-11 23:01:46 +01:00
Sorikoff aa407adf3e Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster (#23456)
* Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster

* Fix NoPCH

* Correct header

* fixup! Clean up

* Rename 9999_99_99_99_world.sql to 2019_06_22_00_world.sql

(cherry picked from commit 40b09e3df144304562a63f33d16e25bbde5079fd)
2021-12-11 22:58:16 +01:00
Wyrserth b709ea9a8d Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts (#23459)
* Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts.

* Kill evil spaces.

* Rename 9999_99_99_99_auth.sql to 2019_06_21_00_auth.sql

* Update auth_database.sql

(cherry picked from commit 8163ea60c8d517ebe3a88f595dd8291df8338811)
2021-12-11 22:47:08 +01:00
Sorikoff 8fc52bc5e5 Scripts/Spells: Migrate Teleporting to Script (#23458)
* Scripts/Spells: Migrate Teleporting to Script

* Rename 9999_99_99_99_world.sql to 2019_06_21_02_world.sql

(cherry picked from commit e9d803ccee2fb5d229babbf6c2c4a17b1986edb0)
2021-12-11 22:28:55 +01:00
Shauren 4595e63dd7 Core/Spells: Deleted old script (partial port of a4cd4d8b872bcbd9e28e9ae76f5220b30494a996) 2021-12-11 21:40:30 +01:00
Keader ba606753bd Scripts/Icecrown Citadel: Fixed some bugs on Blood Orb object and trash mobs around him
Followup: 394b119664bc16dc5376f1404925b6d0b5a26876
(cherry picked from commit 3b0743ea67687937a1e6ba75ae9ef5e7fb996355)
(cherry picked from commit f9a366628a17263852634a1095edcdb79a8b383e)
2021-12-11 21:37:53 +01:00
Killyana 2aca19a079 DB/Quest: "Where Kings Walk" and "Warchief's Blessing"
The script was deleted by https://github.com/Aokromes/TrinityCore/commit/5f928f79490b1d73c32ea962c3c720bd16833010 But it wasn't done properly via the spell_area anyway

(cherry picked from commit 8d6295559d72e4d17bce3c03f56f2a8f67c5109d)
2021-12-11 21:34:48 +01:00
Killyana 0993b491dd DB/Quest: A Visit With The Ancestors
Closes #23284

(cherry picked from commit a3dec9068bda1a3145e526eaa69c1e38fa3f2fe3)
2021-12-11 16:32:05 +01:00