* Split Spell::CheckRange() into 2 methods since that method had more than one responsibility.
* Moved melee range logic into its own function
* Moved melee range logic method GetMeleeRange from Spell to Unit class. Unit::IsWithinMeleeRange() and Spell::GetMinMaxRange() both use that method.
(cherry picked from commit d7600f1126d2780fecdfcdfc66a598a48cee0136)
# Conflicts:
# src/server/game/Entities/Unit/Unit.cpp
# src/server/game/Entities/Unit/Unit.h
# src/server/game/Spells/Spell.cpp
SQL content based on issue 14719 by Killyana,
conditions output from Malcrom's Condition Creator
- remove hardcoded #define gossip options
- enum gossip menu IDs from DB
- remove outdated SD comments at the top of the file
Closes#14719
(cherry picked from commit 03bafe334c178f5731f6eee3de402294017c8ddd)
1) Update to conditions for Zombiefest as previous conditions appear to have stopped working correctly
2) Update for Dark Subjugator to prevent these becoming bugged, also correct unit flags for the sentrys to prevent these from agroing player if too close and dropping immune subjugator if killed
3) Conditions to prevent console spam from Bone Warrior closes#17655
(cherry picked from commit c515cdc636beefa83bb1a022a18f34ca053dcd53)
The core script `npc_timothy_daniels` is no longer needed,
all the gossip handling is already present in the database.
- remove core script npc_timothy_daniels
- remove ScriptName from c_t entry in DB
(cherry picked from commit e2f395863a7fb1a85dc7d09f2692198faae16f46)
Rename 2016_08_14_01_world.txt to 2016_08_14_01_world.sql
(cherry picked from commit 6d66adbdf158fbce0bc2cdf796d9987261f6033f)
Move core script npc_mortog_steamhead to database
- script contains gossip handling + 1 condition
- both actions can be handled in DB settings
(cherry picked from commit 0c6eeb3abc54dbc0f147e5098619e8e19e27accd)
(cherry picked from commit fdcea5c7efd58c929e5d653af955f524dc543034)
Rename 2016_08_04_05_world.sql to 2016_08_11_00_world.sql
(cherry picked from commit d4f2f5968aadc5145e9a8c58dc7a4e0bd48c87e8)
These scripts are no longer in use:
- generic_creature
- trigger_death
(cherry picked from commit 2507b9f8af15b79b6825d620b2b5d86d5b3c3f40)
# Conflicts:
# src/server/scripts/World/mob_generic_creature.cpp
(cherry picked from commit fdd78d20772701b3e0fd7caf0da2cd5a2e6b6354)
Entities/Creature: Fix spawn health, fdd78d2 follow-up. Fixes and closes#17757.
(cherry picked from commit 5b6eb29b74bbc9e62f12c449b1896a075bdd25a2)
Entity/Creature: Fix spawn health, for real this time. Closes#17757. Also for real this time.
(cherry picked from commit ac35f93c2d6d5436054be474da06c9483e311c36)
And move others to more logical appenders
(cherry picked from commit b65d26b5b450ec60dfe2ac1b923289eafb6946c6)
# Conflicts:
# src/server/game/Handlers/PetHandler.cpp
- New error message if a shutdown is delayed due to force threshold.
- New status message indicating that a server shutdown was successfully cancelled.
(cherry picked from commit d7602190623153c8f211ad120e22c6e63371f3db)
- NULL -> nullptr
- Rename "AssistPlayerInCombat(who)" to "AssistPlayerInCombatAgainst(who)" to reflect what the method actually does
- Code style
No functionality was changed.
(cherry picked from commit 152b3ad5b997f4be06c5bb55ddb15c57a8e28c3b)
# Conflicts:
# src/server/game/AI/SmartScripts/SmartAI.cpp
# src/server/game/AI/SmartScripts/SmartScript.cpp
Change "server shutdown 0" behavior to delay the shutdown by the force threshold specified in configs if there are still players connected, set to 30 by default
(cherry picked from commit b37c7101de272d1b3d599f26d6b5077cfacfb121)
This PR affects the following 2 quests:
Quest ID 4001 "What Is Going On?" - part 2 (Horde)
Quest ID 4342 "Kharan's Tale" (Alliance)
Target of this PR:
Move core script npc_kharan_mighthammer to DB/SAI
(thereby removing 10 lines of hardcoded text).
* DB/conditions: extra gossip conditions
- added conditions for gossip before quest taken and after quest completed.
- removed redundant core script SAY_GET_ME_OUT_OF_HERE comment
* DB/creature: add more text to Kharan
- add all missing creature_text lines to entry 9021 Kharan Mighthammer
- add SAI duration to wait before TEXT_OVER is triggered (3000 ms)
(cherry picked from commit 2125c126097812fd6682db8edfd543c0d5583abf)
Change "server shutdown" behavior to always include [force] optional parameter when issued from local or remote console.
(cherry picked from commit 884736b3b279737c44b0954ca3fe0f193085fbb3)
1) http://www.wowhead.com/quest=11631/vision-of-air so there is actually visual rather than quest been immedietly completed when quest item used
2) Event for turn in of http://www.wowhead.com/quest=11695/the-horn-of-elemental-fury
3) A small fix for Subjugated Iskalder so this npc has to be taken back the the bone witch rather than credit been given on spawn and npc not moving (due to bad follow action),
(cherry picked from commit e7cfb08cb5dce8c99d2e4f70d287a76deba70a98)
- Add a workaround in BattleGround correcting for bad rotations in BG scripts
- Calculate rotation from rotation in Wintergrasp, this function hasn't a rotation parameter and should be added in the future.
- Also removed an ugly hardcode in Battlefield::SpawnGameObject
Closes#17711
(cherry picked from commit 33fbc453d236d943c24fb10522ac0720c3174c3d)
# Conflicts:
# src/server/game/Battlefield/Battlefield.cpp
# src/server/game/Battlegrounds/Battleground.cpp
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix#17664
(cherry picked from commit bcfa47c0514b51690a5dd222b3b1ac5f20379232)
(cherry picked from commit afaaedad2def50ef32ed76ce390efa9523cb80ba)
Rename 9955_22_55_world.sql to 2016_08_01_01_world.sql
(cherry picked from commit 1f8c55d1d67ce0192f8277a7429a5dc5be0b77b1)
ariel-