73 Commits
Author SHA1 Message Date
sirikfoll 03e03f3fc6 Core/Scripts: Fix Skadi dismount issue
Closes #23005

(cherry picked from commit fe3bf57aba9a5009e7e17922391a0d9374915ab5)
2021-12-02 23:51:51 +01:00
Gustavo b86a66c5be Core/Scripts: Fix Blood summon position (#23088)
* Core/Scripts: Fix Blood summon position

Updates #13162

(cherry picked from commit cc3293c0023b36434747190103a1f0ffee0f8488)
2021-11-26 11:21:24 +01:00
Gustavo 6aaf9aaf3b Core/Misc: Warning fixes (/W4) (#23149)
* Core/Misc: Warning fixes (/W4)

(cherry picked from commit 50f122de778bca324d0f4c81f1e8eb30b90a7314)
2021-11-26 11:18:15 +01:00
sirikfoll dc5cab3bf4 Core/GameObject: Properly dismount players on GameObject Use
Closes #23124

(cherry picked from commit dbfc6ce773afad4b5a4db77cbb76e64755d3ef94)
2021-11-24 23:34:48 +01:00
Gustavo 80421d7cac Core/Players: Fix logic in CanSeeSpellClickOn (#23090)
Block SpellClick for the npc if there is no entry

(cherry picked from commit 0eacccc2cd614aaef790ad0ce9df3d57212e9b58)
2021-11-24 20:35:18 +01:00
sirikfoll 61baf4009d DB/Spawns: Add some missing spawns in Aldur'thar: The Desolation Gate (Alliance)
Ref #3202

(cherry picked from commit 0b6b96eea0a55c03fc329d7b9eeaea5a5769a2ae)
2021-11-24 20:35:18 +01:00
sirikfoll 74114b45a6 DB/Quest: Tails Up
Closes #16363

(cherry picked from commit 82c532dc239d7bbb4cb449421969349253bc620e)
2021-11-24 14:49:26 +01:00
sirikfoll 402e63427e Scripts/Ulduar: Mimiron improvements
Closes #23043

Fix Aerial hover
Some visual issues

(cherry picked from commit a8033420299d75bbcfd6efec610ec7f34f01bf75)
2021-11-24 00:02:13 +01:00
Gustavo 10c915dd34 Core/Units: Only update height in SetHover if unit is bellow HoverHeight (#23061)
(cherry picked from commit 2dfea54533830b326ce9ac29d59de01d3fee503b)
2021-11-23 23:18:58 +01:00
sirikfoll f507737ecf Scripts/TheSlavePens: Boss Ahune fixes and updates
Fixes some visual problems
Fixes encounter start
Updated codestyle

Closes #22071

(cherry picked from commit 35ba5aa138edc84dfdeb48ace88b12d521d31fa3)
2021-09-29 21:01:25 +02:00
sirikfoll 7c63a99bab Scripts/Spells: Quest King of the Mountain
Added missing jump jets and battle standard visuals
Added allowed area conditions for the vehicle
Fixed Jumpbot's attack spell (thanks @keader for fixing the proc)

(cherry picked from commit e7e46b2a822cd0179b30ba5b0fa7c6fe7cea8774)
2021-09-05 22:19:03 +02:00
sirikfoll 74101eaf7c Scripts/Icecrown Citadel: Prevent Lady Deathwhisper movement during first phase.
(cherry picked from commit 076bd11002c0fe7ed893497e582a40b7f46320e6)
2021-08-08 21:21:34 +02:00
sirikfoll 9573987775 Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor
Closes #20727

(cherry picked from commit cfaa4e6caf8f26eb850a714994b533a77e92a92f)
2021-06-19 23:33:24 +02:00
sirikfoll e2c72cc02e Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" target selection (Boss Kalecgos)
(cherry picked from commit 14b6e3bbb36e4b5ec5212ed2a3bf5eb0012e095f)
2021-06-19 23:33:24 +02:00
sirikfoll bd7fbce592 Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on heroic mode (Lich King)
Movement was being prevented by spell cast

(cherry picked from commit a217c0be922f7a14bf78acb87aaaef5bc99afe95)
2021-06-19 01:35:41 +02:00
sirikfoll 3ff61beafa Core/CombatAI: Npcs with TurretAI will be able to attack again
Needed after the new Threat system

(cherry picked from commit e12e0ad5827d7e794baa630724069680d7e07cfb)
2021-06-16 11:26:22 +02:00
sirikfoll 78577afa49 Core/Player: Pass correct Zone ID to HandlePlayerLeaveZone
This will fix some issues with Wintergrasp, like phasing auras getting stuck and missing group invites for the battle, among others

(cherry picked from commit ed9e220991e2aa3fa2d50359608fd27057cafbbc)
2021-06-16 11:23:01 +02:00
sirikfoll 5b5bc4c5c7 Scripts/Scarlet Enclave: Quest The Endless Hunger will work correctly after Unworthy Initiate Respawn
Due to dynamic spawns, we need to be able to update the Npc GUID after the respawn, otherwise the quest can only be completed by the first player

(cherry picked from commit 72ff2e30c30d4d1b9bf22695b6a097eb82e3c76a)
2021-06-15 23:43:17 +02:00
Gustavo 044110d423 Core/Entities: add extra use of UPDATETYPE_CREATE_OBJECT2 (#20955)
(cherry picked from commit 51c4196acf9d670601c0bba999498c8e7bb863dd)
2021-03-15 20:17:31 +01:00
Gustavo 56cd9de144 Core/Spells: Don't save channeled auras (#20923)
(cherry picked from commit 5b7e4efcc4db8c4f1fb25bbdf7cfca60dfb776dc)
2021-02-15 19:13:25 +01:00
sirikfoll da76a0db5b Core/Scripts Fix issues with Midsummer's Ribbon Pole
Closes #6876

Fixed achievement Burning Hot Pole Dance
Update scripts for quest Torch Tossing, using all correct spells and timers
Updated script register model

(cherry picked from commit 6e7e43172ecd73fcc43872b75917f16a876f47c7)
2021-02-15 19:13:25 +01:00
sirikfoll e83c0b07d1 Core/Scripts: Fixed typo in spell_pilgrims_bounty_a_serving_of
(cherry picked from commit 1a638b39e374fd4733be7d13bd9e4d4052412596)
2021-01-29 19:23:53 +01:00
Gustavo f34ee9b737 Core/Scripts: Update boss Toravon the Ice Watcher (#20395)
* Core/Scripts: Update boss Toravon the Ice Watcher

Frozen Orbs: Fixed summon delay, removed old hack, aggro behavior implemented(every 10sec they reset threat and change target)
Remove no longer needed script for the orb stalker
All timers adjusted
Update instance model
Update script register model
Fix Frostbite proc

(cherry picked from commit 5a90251ea28bb9b0be376d7b6110b4e93458cbea)
2021-01-08 21:12:11 +01:00
Gustavo 5e5ca6c84a Core/Scripts: Boss Amanitar rewrite (#20283)
* Core/Scripts: Boss Amanitar rewrite

Fixes mushrooms behavior, correct and script his spell, size, spawn positions, despawn and respawn, and everything else
Fixes Mini spell cast(only re-cast if there is at least one person without the debuff)
Corrects boss initial position
Updates script register model

(cherry picked from commit 0b766db6a41a4db0d631e36fcc753c658b746328)
2020-09-12 00:17:29 +02:00
Gustavo e531beeb83 Core/Scripts: Boss Jedoga Shadowseeker rewrite (#20279)
* Core/Scripts: Boss Jedoga Shadowseeker rewrite

Added all missing spells and visuals
Added Twilight volunteers in the fight
Fixed Jedoga Controller's behavior, mostly moved to boss_prince_taldaram, where they belong
Updated script register model
Misc updates and improvements
Updated instance model

(cherry picked from commit f1ff7e642f8feb027d668a53adc39ecaa7488cc2)
2020-09-12 00:13:32 +02:00
sirikfoll 82764a71fc Core/Scripts: Minor fixes in boss Coren Direbrew
Update script register model
Fix number os Mole Machine spell targets
Fix Mole Machine timer
Fix minions summon

(cherry picked from commit 05a101881cc58cd10483002f8ba0576c4b09f57d)
2020-09-06 21:40:44 +02:00
sirikfoll aefaff36ec DB/Creature: Fix Lord Marrowgar coldflame npc
Closes #17668

(cherry picked from commit 369c13f353454d129860d73b072768462af62b06)
2020-09-06 21:35:53 +02:00
Gustavo e5963fda0e Core/Scripts: More fixes in boss Lich King (#20147)
* Core/Scripts: More fixes in boss Lich King

Fix Valkyr charge spell, they will no longer ignore Z position and become unreachable.
Correct height of Spirit Bomb and added the 3 seconds delay on his explosion.
Set the Trigger inside frostmourne room as active, to avoid problems with reseting the room, e.g: Spirit Bombs not despawning and Wicked Spirits stuck in evade.
Use correct InhabitType for Wicked and Vile Spirits, this avoid a situation where they could spawn falling.

(cherry picked from commit 22a7956069c293a3f8eab8adcd84a9f4703f364a)
2020-08-23 01:20:27 +02:00
sirikfoll 7586daad62 Core/Misc: Remove Whitespaces
(cherry picked from commit e2565c2597a72ea7868eef3156014dc3a83c058f)
2020-08-23 00:48:19 +02:00
Gustavo 6135ee20a9 Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau) (#19897)
* Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau)

Scripted all spells
Corrected behavior of Spectral Blast and Curse of Boundless Agony
Removed wrong wipe behavior
Fix problem where bosses would be stuck with banish
Added Boundaries
Corrected texts
Removed old hacks
Other minor fixes

(cherry picked from commit e9cd7af2dfcb7948f27e83e73398da0086190aab)
2020-08-22 21:13:01 +02:00
Gustavo 111b65e10f Core/Vehicles: Do not call InstallAllAccessories for dead Vehicles (#20033)
(cherry picked from commit 551d0559aac663e9485b0eaffac5326536180c27)
2020-08-19 00:18:55 +02:00
Gustavo d50611c108 Core/Auras: Implement SPELL_AURA_DETECT_AMORE (#19955)
Based on https://github.com/mangos/mangos/commit/b58b29c9581327129daaf43b9c368810db850771

(cherry picked from commit a27a3e0457e3f6c2dd6955ce86b51888c5590ffc)
2020-08-18 18:53:13 +02:00
Gustavo 23a113756e Core/Spells Allow bosses to receive KnockBack under certain conditions (#19312)
Conditions: Not player, not controlled by player and not hunter's pet

(cherry picked from commit 3bfe67792dbf66f83eae0cfbaff0cff3c14b4d0b)
2020-07-16 22:00:29 +02:00
sirikfoll 1d99860757 Core/Scripts: Updated Sunwell Plateau instance model
(cherry picked from commit 2984def452b2106fc3409ccdcc411028efaceb01)
2020-07-16 21:47:27 +02:00
sirikfoll c99963b023 Core/Scripts Properly set Freya's BossState do DONE and avoid some loot exploits
Closes #19823

(cherry picked from commit 1cc0458b114490238ff9cfed78b1932df67def29)
2020-06-14 23:49:04 +02:00
Gustavo 53f79acda9 Core/Battlegrounds: disable health regen for battleground vehicles (#19183)
Updates issue #950

(cherry picked from commit 85af0a06305e6f771482da973244737e47bcf34c)
2020-04-24 17:18:51 +02:00
Gustavo 6f523b4fb6 Core/Scripts: minor fixes in boss_the_lich_king (#19311)
Closes #4427
Closes #7091

(cherry picked from commit 2792046dc7a229180d27dfdc4ce37ccfb84c8a27)
2020-04-24 17:18:49 +02:00
Gustavo 1b85f62b96 Core/Scripts: implement boss Apothecary Hummel ("Love is in the Air" event boss) (#19076)
Closes #5114

(cherrypicked from 8c6fa411e8118752ddbefe8dc022514602859fb9)
2019-08-17 20:04:14 +02:00
Gustavo 1d2f20d59a Core/Unit: Correct speed calculus when affected by SPELL_AURA_MOD_MINIMUM_SPEED (#18136)
(cherrypicked from 4224259d83c336ef46fa627a8ba0015200a788eb)
2019-08-17 20:04:14 +02:00
Gustavo c860522ecf Core/Scripts Update boss Skadi the Ruthless (#19114)
(cherrypicked from 4536846d7d30508a046f394d1f561a2c3fdcf5f0)
2019-07-21 21:06:54 +02:00
sirikfoll 529ab71f0f DB/Creature: Fixed Valkyr Shadowguard immunities
(cherrypicked from d61daf23cc130c42691ed4a510742502fb834183)
2019-07-21 21:06:54 +02:00
Gustavo 7fbae7530d Core/Scripts Rework boss Terestian Illhoof (Karazhan) (#19057)
(cherrypicked from 87f2cb04cada92590e163d60c729c9e6c1c270f5)
2019-06-15 18:41:09 +02:00
Gustavo c53df2adb0 Core/Scripts Update boss Maiden of Virtue (#19058)
(cherrypicked from d06391d0628ffbf43da471c83653853b0926b4ab)
2019-06-15 18:41:09 +02:00
Gustavo 384f2d636c Core/Scripts: boss The Curator (Karazhan) rework (#19040)
Closes #16099
(cherrypicked from 169e150628913a84d44cac2cc4a70976de0a025a)
2019-06-15 18:41:09 +02:00
Gustavo 2dcc2d0f05 Core/Scripts: boss Nightbane rework (Karazhan) (#18899)
Closes #10017
(cherrypicked from ad8a71c0848e9746922bb2b6b90574032ffc1db8)
2019-06-15 18:41:09 +02:00
Gustavo 1ddb9515eb Core/Scripts Fix issue with Lady Deathwhisper's door
(cherrypicked from f57132b795a097a2c4c863a8153b0c1be5e008c0)
2019-06-15 18:41:09 +02:00
sirikfoll e64cd5669d Core/Scripting: Fixed hotswap calling evade mode for dead creatures
(cherry-picked from afa8527338f8d07531cf2cf8a59195321dfb257e)
2018-12-09 14:18:42 +01:00
Gustavo bff89d9886 Core/Scripts: Implement Boss Coren Direbrew (#18137)
(cherry picked from commit d6a5477407968e2a9a8be33a2ce1ed835f3a1919)
2018-03-18 00:19:53 +01:00
sirikfoll ab3a4bde4e Core/Ruby: Minor fixes in Halion encounter
* Some codestyle fixes
* Fixed wrong Halion summon with Hotswap system
* Fixed evade issue
* Fixed emblem frost exploit

(cherry picked from commit 0b33a8281f6be3458ef3698349f00a1f6aabb0b5)
2018-03-18 00:19:32 +01:00
sirikfoll 2378266acd Scripts/Events Implement Pilgrim's Bounty Bountiful Table
(cherry picked from commit 75df296bb6f8d30a65f669dab6af3d1b2d6046f7)

Rename SQL file
(cherry picked from commit 13031f300ff8ef05f2d937d7ce250e6e3cb41531)
2018-03-12 16:39:45 +01:00
Gustavo bc87d3a2b3 Core/Misc Remove WhiteSpaces (#18379)
(cherry picked from commit 7e0a6166576304b98fac246192cf1ce23c74f915)
2018-03-12 10:32:05 +01:00
Gustavo d4fa2cf43f Core/Scripts Boss Lady DeathWhisper improvements (#17389)
(cherry picked from commit 8e82d8a9e79ba95fbd780fa093416ebe7431a1c0)

Rename 2016_99_99_99_world.sql to 2016_10_14_05_world.sql
(cherry picked from commit b4b8a7477bcab15cb25a15bd3271279ae3220c94)
2017-10-03 15:28:39 +02:00
Gustavo cc39c11d7f Whitespace clean-up
(cherry picked from commit 6ee35734e42a97696056fcb0bf684a11ea4e524c)
2017-02-18 17:25:36 +01:00
Gustavo c4f2012ef5 Core/Spells Make credit for quests "The Grand Melee" and "Among the Champions" a triggered cast (#17870)
Fix a problem where the credit wasn't casted due to CGD
(cherry picked from commit e1761a24ceab167909a71be8d38dda9dc4792932)
2017-02-18 17:23:20 +01:00
Gustavo accbb587b8 Core/Scripts Boss Skadi the Ruthless rework
(cherry picked from commit 40114cacd37675a9cbe7d2eef15445340d87e814)

Rename 2016_99_99_00_world.sql to 2016_08_25_06_world.sql
(cherry picked from commit 738e3cf0020c16d85e7fdeca55128e71ba3d2aed)

travis is lazy
(cherry picked from commit 92876278fe163ffd8ecf9561f5b0044225559c48)
2017-02-18 16:44:24 +01:00
Gustavo a4fc7d9d2d Core/Scripts Implement Pit of Saron Cavern event
(cherry picked from commit b459c6607f80701945cb822d8c7519998cad205f)

Rename 2016_99_99_99_world.sql to 2016_08_25_01_world.sql
(cherry picked from commit 05df3cc98813688247dc2ec0ce3899a1369ec0d5)
2017-02-18 16:16:00 +01:00
Gustavo e8df5babe6 Scripts/Pet Implemented Argent Squire/Gruntling and Argent Pony Bridle
(cherry picked from commit 989aaaa8b5284bc707c94c62e6c50e9df3cbfc84)

Rename 2016_08_15_17779_world.sql to 2016_08_25_00_world.sql
(cherry picked from commit 526dfca8643d3afb9976eb099281547003dffbb1)
2017-02-18 16:00:52 +01:00
Gustavo 7e57e9a91b Improve scripts for quests Breakfast Of Champions and A Bear of an Appetite (#17780)
Properly despawn the related GameObjects after use of the quest item, avoiding multiple use and summon
(cherry picked from commit 5661b4686bf7a1d2147d9fdb47115883a4d11ecf)

Rename 2016_08_99_99_world.sql to 2016_08_23_03_world.sql
(cherry picked from commit 831975fa3426bdec9f9c0647d690e6c9664d5f72)
2017-02-18 14:40:14 +01:00
Gustavo accaee579e Core/AI Prevent bosses respawn when BossState is set to DONE (#17616)
(cherry picked from commit f826ecb4b2e8cc1fa54419947dff041a580d9c03)
2017-02-05 21:09:43 +01:00
Gustavo 4a21e8158f Core/Spells GameObjects needs to be spawned in order to be acceptable as a SpellFocus (#17594)
(cherry picked from commit 23e89b8aef1999bbbd52248c40d7b76c0a67cafb)

# Conflicts:
#	src/server/game/Grids/Notifiers/GridNotifiers.h
2017-02-05 20:00:55 +01:00
Gustavo e55420af86 Core/Scripts Corrections on Halion's Encounter (#16725)
Core/Scripts: Updates to Halion

* Fixed Combustion and Consumption.
* Fixed Living Embers and Blazing Auras.
* Timer changes.
(cherry picked from commit dfe278459d79ade500a66356a98b4065c0722572)

# Conflicts:
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp

Fix sql for merged PR
(cherry picked from commit 7f944695ddad14cec021ff5a0527a5a92fb4cf81)

Derp.

github editor is bad.
(cherry picked from commit 182904946174cd635b7478bd38507235d0d45aa2)
2017-02-04 23:33:26 +01:00
Gustavo e336272ec2 Core/Scripts Boss Ahune Clean-up (#17320)
Remove use of flags UNIT_FLAG_NON_ATTACKABLE and UNIT_FLAG_REMOVE_CLIENT_CONTROL
Replace with correct one, UNIT_FLAG_UNK_31, imunity part now is fully handled by auras
Fix a problem with bugged orientation while casting SPELL_SYNCH_HEALTH
Use std::crono notations
Remove unneeded code

Move one spell_linked_spell to SpellScript
Fix Loot issue
Fix Possible Crash
(cherry picked from commit f1639a30ba1f52370c128585d1670af18e48e799)

Rename 2016_99_99_99_world.sql to 2016_06_26_00_world.sql
(cherry picked from commit fdf0092ac24a27f1e95ffeb4f0257404998980ee)
2017-02-04 17:56:05 +01:00
sirikfoll 04ff2e195f Core/Achievement A-bomb-inable and A-bomb-ination
(cherry picked from commit e016bf8d06c8236c160ecaf63c6a4f26f7d4467b)

DB: SQL rename
(cherry picked from commit 71081c2576571a6e6d5a16179e6729843094a882)
2017-01-09 21:36:03 +01:00
sirikfoll 31e08b9722 Core/Unit Do not allow addition of threat to units in evade mode
(cherry picked from commit 7d769006aa1e014d6f01ef4c7fa450e827fc32fc)
2017-01-09 21:33:32 +01:00
Sirikfoll 5993f91630 Script/SWP Full Rework on M'uru Encounter
(cherry picked from commit 6002acf376556eb413a6b514f14b8a07f8de5099)

Another sql fix
(cherry picked from commit 204acbb5b72d9706cdcf26aede62c2eeec11c6a2)
2017-01-08 02:21:10 +01:00
sirikfoll 037e9053d3 Implement Quest Riding the Red Rocket
(cherry picked from commit 20b3feb5594b1047303509defb8f0aa9df6a0ab9)

Fix SQL name
(cherry picked from commit 2329648cadaa83be0950d6abd4133b37f34d53e8)
2017-01-08 01:33:48 +01:00
sirikfoll c66d3714f1 Core/Scripts: Fixed Yogg-Saron Portals
Closes #16390
Closes #16708

(cherry picked from commit c4e4ee3ae10b1276b214c8b1da1281aba23ae57a)
2016-04-08 23:57:12 +02:00
sirikfoll 7031090dc3 Fix Achievement Defense of the Ancients
The spell that trigger the achievement check, needs to be cast before setting up the variables used for the second round, otherwise the achievement will be granted to the wrong team.
Also, SPELL_END_OF_ROUND needs to be casted on the end of the second round too, this was confirmed in retail.

(cherry picked from commit 5cf794b3797c5c8b911e335fc29ae1e88de3ffea)
2016-04-02 19:30:57 +02:00
sirikfoll a962db8b3c Core/Scripts Script npc needed for Quest Torch Tossing part2
Script for Npc Torch Tossing Target_Bunny_Controller, responsable for handle the targets rotation for Midsummer Fire Festival quest, Torch Tossing.

(cherry picked from commit 8b74038531ffec2d809083fa73ad29ec693d7c1a)
2016-04-02 18:32:38 +02:00
sirikfoll 5ba2e2dd8e Core/AI Remove Reset() call from JustRespawned() hook
* Not needed, and causes trouble when using _DespawnAtEvade()
* Closes #16786

(cherry picked from commit acf66813537385c34b620fc5f970d2df35a73d60)
2016-03-24 15:04:03 +01:00
sirikfoll d4b3b1d1d2 DB/CORE Minor change in quest Kick, What Kick? and some codestyle
Remove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480

(cherry picked from commit 22f1d269865a5980dabadab1f469e60a701e9de1)
2015-11-06 11:11:16 +01:00
sirikfoll 59742469fb Core/Scripts: Friend or Fowl Achievement
Change AURA_EFFECT_HANDLE_REAL to AURA_EFFECT_HANDLE_REAL_OR_REAPPLY_MASK, the hook needs to be called on every apply/reapply to keep tracking the stack amount.

(cherry picked from commit f877b6af0a48a216aad9078900763dadb2221d24)
2015-10-16 12:50:51 +02:00
sirikfoll b0e580eb4c Spell Script for quests Among the Champions and The Grand Melee
Solves issues with the credit spells hitting the mount instead of the player itself.

(cherry picked from commit 5bbd7cff4c98b59673d03416e6fff83d7db4d950)

Conflicts:
	sql/updates/world/2015_07_11_00_world.sql
2015-07-12 18:38:35 +01:00