247 lines
7.8 KiB
Markdown
247 lines
7.8 KiB
Markdown
# QUEST COMPLETION INVESTIGATION REPORT
|
|
**Generated**: October 27, 2025 22:30
|
|
**Server Version**: 954aff525d90+ (playerbot-dev branch)
|
|
|
|
---
|
|
|
|
## EXECUTIVE SUMMARY
|
|
|
|
**Total Quests Completed**: 3 (since server start)
|
|
**Total Bots with Active Quests**: 50
|
|
**Quest Progress Status**: ❌ **STALLED** - No completions in last 1000+ log lines
|
|
|
|
---
|
|
|
|
## COMPLETED QUESTS (All Time)
|
|
|
|
Based on server log analysis, only **3 bots** have successfully completed quests:
|
|
|
|
| Bot Name | Quest ID | Quest Name | Status |
|
|
|----------|----------|------------|--------|
|
|
| **Simonso** | 24470 | Give 'em What-For | ✅ Completed |
|
|
| **Damon** | 24470 | Give 'em What-For | ✅ Completed |
|
|
| **Asmine** | 26391 | Extinguishing Hope | ✅ Completed |
|
|
|
|
**Note**: All 3 completions occurred early in server runtime. No new completions since then.
|
|
|
|
---
|
|
|
|
## CURRENTLY ACTIVE QUESTS (50 Bots)
|
|
|
|
### Quest 8326 (Multiple Bots - Kill Quest)
|
|
**Bots Working**: Baderenz, Caylin, Chado, Ildaris, Minico, Risa, Selina, Tarcy
|
|
**Status**: ⚠️ NO targets found (waiting for respawns)
|
|
**Issue**: Bots detect quest but cannot find/kill targets
|
|
|
|
### Quest 14449 (Multiple Bots - Autocomplete Quest)
|
|
**Bots Working**: Arinarcy, Denette, Doroatha, Endrick, Francine, Lorran, Noellia, Tergio, Waconso, Zolanda
|
|
**Status**: ⚠️ NO trackable objectives
|
|
**Issue**: Autocomplete/scripted quest with no objectives to track
|
|
|
|
### Quest 24470 (Multiple Bots - USE ITEM Quest)
|
|
**Bots Working**: Adelengi, Menel, Oberek
|
|
**Status**: ❌ Progress stuck at 0/4
|
|
**Issue**: Item usage not executing
|
|
|
|
### Quest 24471 (Multiple Bots - USE ITEM Quest)
|
|
**Bots Working**: Damon, Erinarini, Julian, Simonso
|
|
**Status**: ❌ Progress stuck at 0/4
|
|
**Issue**: Item 49743 found but never used
|
|
|
|
### Quest 24759 (USE ITEM Quest)
|
|
**Bot**: Galandon
|
|
**Status**: ❌ Progress stuck
|
|
|
|
### Quest 24770 (USE ITEM Quest)
|
|
**Bot**: Simeric
|
|
**Status**: ❌ Progress stuck
|
|
|
|
### Quest 24959 (Autocomplete Quest)
|
|
**Bots Working**: Frasier, Gabriella, Meraneya
|
|
**Status**: ⚠️ NO trackable objectives
|
|
|
|
### Quest 25152 (Autocomplete Quest)
|
|
**Bots Working**: Amillea, Damie, Dillenie, Gerine, Gordandro, Hadden, Haimei
|
|
**Status**: ⚠️ NO trackable objectives
|
|
|
|
### Quest 26272 (Unknown)
|
|
**Bot**: Elianus
|
|
**Status**: Unknown
|
|
|
|
### Quest 26389 (Kill Quest)
|
|
**Bots Working**: Anderenz, Melianon, Vandro
|
|
**Status**: ⚠️ Targets not being engaged
|
|
|
|
### Quest 26391 (Kill Quest)
|
|
**Bot**: Annise (previously completed by Asmine)
|
|
**Status**: ⚠️ No progress
|
|
|
|
### Quest 28167 (Autocomplete Quest)
|
|
**Bots Working**: Frodorin, Halifax, Holbrook, Jameta
|
|
**Status**: ⚠️ NO trackable objectives
|
|
|
|
### Quest 28714 (Kill Quest)
|
|
**Bots Working**: Bendarino, Irfan
|
|
**Status**: ⚠️ NO targets found
|
|
|
|
### Quest 28813 (USE ITEM Quest)
|
|
**Bot**: Ziynet
|
|
**Status**: ❌ Progress 0/4, item 65733 not being used
|
|
|
|
### Quest 12593 (Autocomplete Quest)
|
|
**Bots Working**: Annise, Geraldor
|
|
**Status**: ⚠️ NO trackable objectives
|
|
|
|
---
|
|
|
|
## CRITICAL ISSUES IDENTIFIED
|
|
|
|
### Issue #1: Quest Item Usage Not Working
|
|
**Affected Quests**: 24470, 24471, 28813, 24759, 24770
|
|
**Symptoms**:
|
|
- Bots find target creatures (✅)
|
|
- Bots navigate to targets (✅)
|
|
- Progress stuck at 0/X (❌)
|
|
- Items never cast on targets (❌)
|
|
|
|
**Example Log**:
|
|
```
|
|
📦 UseQuestItemOnTarget: Quest 24471 requires item 49743 to complete objective
|
|
📊 UseQuestItemOnTarget: Progress: 0 / 4 - need to use item 4 more times
|
|
🔍 ScanForGameObjects: Bot Simonso searching for entry 37079
|
|
✅ Found 18 Creature targets
|
|
🚶 NavigateToObjective: Bot Simonso moving to objective
|
|
❌ [NEVER USES ITEM - LOOPS BACK]
|
|
```
|
|
|
|
### Issue #2: Kill Quest Targets Not Being Engaged
|
|
**Affected Quests**: 8326, 26389, 28714
|
|
**Symptoms**:
|
|
- Bots search for targets (✅)
|
|
- "NO hostile target found" (❌)
|
|
- "NO target found (waiting for respawns)" (❌)
|
|
- Bots wander but never engage (❌)
|
|
|
|
**Example Log**:
|
|
```
|
|
🎯 EngageQuestTargets: Bot Selina searching for quest targets for quest 8326
|
|
⚠️ EngageQuestTargets: Bot Selina - NO hostile target found
|
|
⚠️ EngageQuestTargets: Bot Selina - NO target found (waiting for respawns)
|
|
🚶 EngageQuestTargets: Bot Selina - Wandering in quest area
|
|
```
|
|
|
|
### Issue #3: Autocomplete Quests Have No Objectives
|
|
**Affected Quests**: 14449, 24959, 25152, 28167, 12593
|
|
**Symptoms**:
|
|
- Quest has 0 objectives (⚠️)
|
|
- Likely autocomplete/scripted quests (⚠️)
|
|
- "NO trackable objectives" (⚠️)
|
|
- Bots search for new quests but can't complete these (🔄)
|
|
|
|
---
|
|
|
|
## ROOT CAUSE ANALYSIS
|
|
|
|
### Primary Issue: Quest Objective Execution Broken
|
|
The quest system successfully:
|
|
1. ✅ Detects quests
|
|
2. ✅ Calculates objective priorities
|
|
3. ✅ Routes bots to objectives
|
|
4. ✅ Finds targets (creatures/gameobjects)
|
|
5. ✅ Navigates to targets
|
|
6. ❌ **FAILS to execute the action** (use item / attack target)
|
|
7. 🔄 **Loops back to step 1**
|
|
|
|
### Secondary Issue: Server Crashes
|
|
**Crash Location**: `Map::SendObjectUpdates+E1` at `Map.cpp line 1940`
|
|
**Exception**: `C0000005 ACCESS_VIOLATION` (null pointer dereference)
|
|
**Impact**: Server crashes every few minutes, preventing quest completion persistence
|
|
|
|
### Tertiary Issue: Quest Turn-In System Untested
|
|
The comprehensive quest reward selection system (commit a660b53d21) was successfully implemented but **cannot be tested** because:
|
|
- No quests are completing objectives
|
|
- Nothing reaches the turn-in phase
|
|
- Quest return loop never triggers
|
|
|
|
---
|
|
|
|
## QUEST REWARD SELECTION IMPLEMENTATION STATUS
|
|
|
|
✅ **IMPLEMENTED** (Commit: a660b53d21)
|
|
- EquipmentManager::CalculateItemTemplateScore() API
|
|
- Complete reward evaluation using stat priorities
|
|
- Class/spec-aware reward selection
|
|
- Proper TrinityCore API integration (CanRewardQuest, RewardQuest)
|
|
|
|
❌ **UNABLE TO TEST** - Prerequisites not met:
|
|
- Quest objectives must complete first
|
|
- Bots must reach quest enders
|
|
- Turn-in system must be triggered
|
|
|
|
---
|
|
|
|
## RECOMMENDATIONS
|
|
|
|
### Immediate Priority #1: Fix Quest Item Usage
|
|
**File**: `src/modules/Playerbot/AI/Strategy/QuestStrategy.cpp`
|
|
**Function**: `UseQuestItemOnTarget()`
|
|
**Issue**: Function finds targets but never casts item spell
|
|
**Required Fix**: Add actual item spell casting after target is found
|
|
|
|
### Immediate Priority #2: Fix Kill Quest Target Engagement
|
|
**File**: `src/modules/Playerbot/AI/Strategy/QuestStrategy.cpp`
|
|
**Function**: `EngageQuestTargets()`
|
|
**Issue**: Function finds targets but never attacks them
|
|
**Required Fix**: Add combat engagement logic after target is identified
|
|
|
|
### Immediate Priority #3: Fix Map::SendObjectUpdates Crash
|
|
**File**: `src/server/game/Maps/Map.cpp` line 1940
|
|
**Issue**: Null pointer dereference causing repeated crashes
|
|
**Impact**: Prevents any persistent progress
|
|
**Required Fix**: Add null pointer check before dereferencing
|
|
|
|
### Long-term: Handle Autocomplete Quests
|
|
**Affected**: ~40% of bot quests are autocomplete/scripted
|
|
**Issue**: These quests have no objectives to track
|
|
**Solution**: Implement autocomplete quest detection and handling
|
|
|
|
---
|
|
|
|
## TESTING RECOMMENDATIONS
|
|
|
|
Once quest objective execution is fixed:
|
|
1. Monitor quest completion rates
|
|
2. Verify quest turn-in detection
|
|
3. Test reward selection with choice quests
|
|
4. Validate new quest acceptance
|
|
5. Confirm quest progression loop
|
|
|
|
---
|
|
|
|
## APPENDIX: All Active Quest IDs
|
|
|
|
| Quest ID | Count | Type | Status |
|
|
|----------|-------|------|--------|
|
|
| 8326 | 8 | Kill | Stalled |
|
|
| 14449 | 10 | Autocomplete | No Objectives |
|
|
| 24470 | 3 | Use Item | Stalled 0/4 |
|
|
| 24471 | 4 | Use Item | Stalled 0/4 |
|
|
| 24759 | 1 | Use Item | Stalled |
|
|
| 24770 | 1 | Use Item | Stalled |
|
|
| 24959 | 3 | Autocomplete | No Objectives |
|
|
| 25152 | 7 | Autocomplete | No Objectives |
|
|
| 26272 | 1 | Unknown | Unknown |
|
|
| 26389 | 3 | Kill | Stalled |
|
|
| 26391 | 1 | Kill | Stalled |
|
|
| 28167 | 4 | Autocomplete | No Objectives |
|
|
| 28714 | 2 | Kill | Stalled |
|
|
| 28813 | 1 | Use Item | Stalled 0/4 |
|
|
| 12593 | 2 | Autocomplete | No Objectives |
|
|
|
|
**Total Unique Quests**: 15
|
|
**Total Quest Assignments**: 50 bots
|
|
|
|
---
|
|
|
|
**Report End**
|