When SearchForQuestGivers found a quest giver at 0yd distance, it
deferred to the pending system which required another UpdateBehavior
tick. With the 150ms throttle and only ~6 calls per session, the
follow-up never happened.
Now resolves the creature and calls ProcessQuestGiver immediately
when the bot is already within interaction distance, instead of
deferring to the next tick.
Signed-off-by: luis <[email protected]>
- Abandon quests with no ender in DB immediately on first attempt
instead of waiting for 3 failures (fixes quest 55660 blocking)
- Loot strategy only activates on game objects within INTERACTION_DISTANCE
preventing distant spatial grid objects from blocking quest strategy
- Rest threshold lowered to 15-25% for no-consumable resting
(was 30-50%, causing bots at 50% health to idle without food)
- Downgrade 275 TC_LOG_ERROR calls to TC_LOG_DEBUG in QuestStrategy
- Downgrade STRAT-SELECT diagnostic to TRACE
- Downgrade target scanner evaluation log to TRACE
- Downgrade auto-accept check diagnostic to DEBUG
Signed-off-by: luis <[email protected]>
bot->GetPositionX/Y/Z() is only updated on the main thread during
Player::Update(). Worker threads reading it mid-spline get stale data.
BotAI now caches the current position at the start of each UpdateAI():
- If a movespline is active: uses FinalDestination() as effective position
- If idle: uses last known server position
GetCurrentPosition() provides this cached value for any worker thread
code that needs accurate bot location. Quest strategy's pending quest
giver distance check now uses this instead of bot->GetPositionX/Y/Z().
Also re-added navmesh reachability check to spatial grid quest giver
scan to skip unreachable NPCs (towers, cliffs) before selection.
Signed-off-by: luis <[email protected]>
bot->GetPositionX/Y() returns the server-side position which lags behind
the client during active spline movement. The bot visually stands at the
NPC but GetExactDist2d reports 77yd because the position hasn't been
updated by the main thread yet.
Now uses movespline->FinalDestination() as the bot's effective position
when a spline is active. This matches where the client renders the bot.
Also re-added navmesh reachability check to the spatial grid scan to
skip unreachable NPCs (towers, cliffs) before selection.
Signed-off-by: luis <[email protected]>
SafeGridOperations::GetCreatureListSafe accessed the live grid which
returned stale creatures from the old map after teleports (worker thread
data race on m_currMap). The bot searched for quest givers on the wrong
continent.
Now uses DoubleBufferedSpatialGrid which provides lock-free atomic
snapshots updated by the main thread. Worker threads always read current
map data. The scan uses creature snapshot fields (hasQuestGiver, entry,
position, isDead) and quest relation DB lookups (thread-safe static data)
to find quest givers without touching any live creature pointers.
Quest acceptance still uses live creature pointers but only in the
pending quest giver arrival phase, when the bot is physically at the NPC
and the data is guaranteed current.
Signed-off-by: luis <[email protected]>
Worker thread reads stale map/grid data after TeleportTo, causing quest
giver searches to return creatures from the old map. Added 5-second
cooldown after each teleport to let the main thread process the map
change before the quest strategy runs again.
Also added diagnostic logging to ProcessQuestGiver auto-accept phase
to trace why quests aren't being accepted (alreadyHas, blacklisted,
canTake, canAdd checks).
Added navmesh reachability check to quest giver selection and position
diagnostic for pending quest giver distance debugging.
Signed-off-by: luis <[email protected]>
Bots walked to quest givers on unreachable terrain (towers, cliffs)
because SearchForQuestGivers selected by straight-line distance without
checking if the navmesh could path there. The bot stopped at the
closest navmesh point, 77+ yards from the NPC.
Now uses PathGenerator to verify navmesh reachability before selecting
a quest giver. Unreachable NPCs are skipped in favor of reachable ones.
Also allows interaction when the NPC is found via grid scan (within
50yd) even if the stored position distance is larger, handling cases
where navmesh pathing ends at a different point than the stored coords.
Signed-off-by: luis <[email protected]>
CastSpell(8690) failed silently for bots without a hearthstone item in
inventory (gear application failed at creation). Bots stood idle in
wrong zones because the hearthstone cast did nothing.
Use Player::TeleportTo(m_homebind) directly — no item required, no
cooldown, no cast time. This is already used elsewhere in the module
(AdvancedBehaviorManager, PlayerbotCommands, TravelRouteManager).
Signed-off-by: luis <[email protected]>
The 2-minute timeout incorrectly killed routes where the bot was
waiting for a ship, riding a transport, or on later legs. Now only
fires when stuck in WALKING_TO_TRANSPORT state on leg 0 — the specific
case caused by worker thread GetMapId() staleness after teleport.
Signed-off-by: luis <[email protected]>
bot->GetMapId() returns stale data on worker threads after a teleport
because m_mapId is updated on the main thread only. The existing map
comparison check fails — the worker still sees the old map ID.
Added a 2-minute timeout: if the travel route has been active for over
2 minutes without completing the first leg, it's considered stale and
cleared. This handles the case where the bot hearthstoned to a
different map but the worker thread can't detect the map change.
Signed-off-by: luis <[email protected]>
Bots stopped 30+ yards from quest givers because 3D distance included
Z-height difference (stairs, ramps, platforms). The bot was visually
at the NPC but the 3D dist of 31yd > INTERACTION_DISTANCE of 5yd.
Switched all pending quest giver distance checks to 2D, matching how
WoW's gossip interaction works. Also widened grid scan to 50yd for
finding NPCs when ObjectAccessor fails.
Signed-off-by: luis <[email protected]>
IsOnGround() returned false when GroundValidator::GetGroundHeight
returned INVALID_HEIGHT (map data not loaded), causing the state
machine to set MOVEMENTFLAG_FALLING. This permanently blocked
MovePoint from generating splines — bots stood idle despite movement
commands being issued every tick.
Changed INVALID_HEIGHT to assume on-ground (safe default). A bot at
a spawn point is never falling.
Also added INFO diagnostic to HandleOnTransport for travel visibility.
Signed-off-by: luis <[email protected]>
Fixture System:
- Use MeshObject GUIDs (HighGuid 56) for FHousingFixture_C Guid and
AttachParentGUID fields instead of Housing GUIDs. The client's fixture
manager searches the frame tree using AttachParentGUID as key, and frames
are indexed by MeshObject entity GUIDs. This fixes fixture hookpoints
showing "None" despite fixtures being spawned.
- Force-send AT entity CREATE/VALUES to player before ENTER_PLOT packet,
matching the retail pattern where UPDATE_OBJECT and ENTER_PLOT arrive at
the same timestamp.
- Set MAX_VISIBILITY_DISTANCE on HousingMap and HouseInteriorMap so all
entities are visible map-wide, eliminating entity streaming race conditions.
- Add PreloadHousingMaps at server startup with LoadAllCells for
neighborhood maps (validates map type before loading).
Fixture Placement:
- Door (entrance) replacement: placing a new door auto-removes any existing
door at a different hook and despawns/respawns the clickable door GO.
- Hook exclusivity: placing a fixture removes any existing fixture at that
hook first.
- Fix DELETE_FIXTURE handler: pass original hookID to RemoveFixture instead
of resolved parent componentID. Fixtures are keyed by hookID.
- Remove default fixture respawn on delete (was causing flicker loop).
Door GO Management:
- Add RespawnDoorGOAtHook/DespawnDoorGO methods for targeted door GO
updates without full house rebuild.
- Door GO positioned at fixture MeshObject location (exact hookpoint).
- Force-send CREATE to player immediately after spawning door GO.
- Auto-create missing door GO templates from ExteriorComponent DB2 at
startup (EnsureDoorGameObjectTemplates) with retail values:
Lock=4296, autoClose=3000, startOpen=1.
Interior Exit:
- Use ExteriorComponentExitPoint position for interior→exterior teleport,
placing player in front of the door they entered through.
Other:
- Add MeshObject::AddRoomDoor for HousingRoomData Doors array population.
- Rename HousingPackets PlotAreaTriggerGuid to NeighborhoodEntityGuid.
Cross-referenced BattlePetState.db2 via wago.tools/WoWDBDefs and fixed
wrong state IDs: Stat_Accuracy is 41 (was 22=Mechanic_IsStunned),
Mod_HealingDealtPercent is 65 (was 26=Ramping_DamageID),
Mod_HealingTakenPercent is 66 (was 27=Ramping_DamageUses).
Added per-type weather damage bonus using the 3-state mechanism from
DB2: Mod_PetTypeDamageDealtPercent(87) + Mod_PetType_ID(89) restricts
damage bonuses to matching ability types (e.g. Rain = +25% Aquatic
only, not all damage). Also added Add_FlatDamageTaken(71) for
Sandstorm-style damage shields.
Expanded enum to 43 states covering weather markers (53-63, 316),
mechanics, cosmetics, and combat modifiers — all verified against
BattlePetState.db2 LuaName field.
Replace dead hardcoded PetBattleWeatherType enum with a data-driven
weather system that reads BattlePetAbilityState entries from DB2.
The old system had SetWeather/GetWeatherDamageModifier/GetWeatherHealingModifier
functions but SetWeather was never called, so weather abilities fired
visually (aura icon appeared) but had zero gameplay effect.
Now weather modifiers (damage %, healing %, accuracy, speed) are loaded
from BattlePetAbilityState DB2 onto the environment slot when a weather
aura is applied, and read back during combat calculations. Elemental
pets remain immune to all weather effects.
The stale route check only compared origin map, missing cases where
the bot spawned on the destination map (e.g. quest ender on same
continent). Route to Ratchet dock (Kalimdor) blocked a bot in
Northshire (Eastern Kingdoms) because originMapId matched.
Now also clears the route when the bot is already on the destination
map — no cross-map travel needed, just walk directly.
Added diagnostic logging to travel check for visibility.
Signed-off-by: luis <[email protected]>
After hearthstoning to a new map, the travel manager's route (planned
for the old map) stayed active and blocked all quest processing. The
bot stood idle forever because UpdateBehavior returned early every tick.
Now detects when the bot's current map differs from the route's origin
map and clears the stale travel manager, allowing quest processing to
resume on the new map.
Also added INFO-level diagnostic to HandleOnTransport for travel
movement visibility.
Signed-off-by: luis <[email protected]>
Starting zone quests like Reclaiming Sunstrider Isle use the auto-accept
flag (0x80000) which bypasses the normal gossip menu. PrepareQuestMenu
doesn't include them, so bots stood idle at quest givers like Magistrix
Erona without accepting anything.
SearchForQuestGivers now also checks quest relations for auto-accept
quests when evaluating NPCs. ProcessQuestGiver runs auto-accept quests
first via AddQuestAndCheckCompletion before processing the gossip menu
for normal quests.
Signed-off-by: luis <[email protected]>
ObjectAccessor::GetCreature fails for some NPCs even when the bot is
standing next to them. Added grid scan fallback using creature entry
from the GUID to find the actual NPC within interaction range.
Also switched to 2D distance for position-based checks to prevent
Z-height differences from causing false "too far" results.
Signed-off-by: luis <[email protected]>
QuestHubDatabase::IsAppropriateFor no longer restricts to same map,
so bots stranded on a continent with no level-appropriate content can
find hubs on other maps. Cross-map hubs get a 0.5x scoring penalty to
prefer same-map when available.
When no quest hubs or quest givers are found nearby, bots now:
1. Search QuestHubDatabase across all maps
2. If best hub is cross-map and hearthstone goes there, cast hearthstone
3. If best hub needs multi-leg travel, use TravelRouteManager
4. If no hubs at all, use hearthstone as last resort
Signed-off-by: luis <[email protected]>
CanTakeQuest returned true for quests that weren't actually available
in-game because ContentTuning data was missing, making GetQuestMinLevel
return 0. Bots walked to NPCs that had no quests to offer.
Replace manual quest relation iteration + CanTakeQuest with
Player::PrepareQuestMenu which is TrinityCore's authoritative check
for quest availability. This is the same system that renders quest
exclamation marks for real players and properly handles ContentTuning,
phase visibility, conditions, and all edge cases.
Applied to both SearchForQuestGivers (scan phase) and ProcessQuestGiver
(acceptance phase).
Signed-off-by: luis <[email protected]>
The pending quest giver check used ObjectAccessor::GetCreature which
can fail for phased/special NPCs like Image of Archmage Xylem, causing
the GUID to be cleared and the bot to stop walking mid-path.
Now stores the NPC position alongside the GUID. The bot walks to the
stored position even if creature lookup fails, and attempts grid scan
for quest givers on arrival. Also logs at INFO level for diagnosis.
Signed-off-by: luis <[email protected]>
The critical rest threshold (no consumables path) was calling frand()
on every IsActive() check, producing a different threshold each tick.
Bots at moderate health (49-53%) would flicker between rest and other
strategies because the random threshold kept changing.
Moved to a per-bot threshold assigned once at construction (30-50%)
so each bot has a stable, unique resting personality.
Signed-off-by: luis <[email protected]>
Add SendLootRelease() after looting all items from a corpse. Without
this, the corpse stayed "lootable" forever and FindLootableCorpses kept
returning it, causing loot strategy to permanently block quest strategy.
Signed-off-by: luis <[email protected]>
luis