"Safely" goes through all combat references validating if in fact the unit should remain in combat or not Any edge case that may get affected by this, are scenarios in which the charmed unit must keep the combat and threat references prior to their charm.... I can't think of any. -> And honestly if there was any such case... imo it should be handled script wise, not core wise. closes #31747 updates #30169 (cherry picked from commit 04ab833acd7e4a5e7025bb826106283c1c7c680b)
TrinityCore (master)
- Build Status
- Introduction
- Requirements
- Install
- Reporting issues
- Submitting fixes
- Copyright
- Authors & Contributors
- Links
Build Status
| master | 3.3.5 | cata_classic |
|---|---|---|
Introduction
TrinityCore is a MMORPG Framework based mostly in C++.
It is derived from MaNGOS, the Massive Network Game Object Server, and is based on the code of that project with extensive changes over time to optimize, improve and cleanup the codebase at the same time as improving the in-game mechanics and functionality.
It is completely open source; community involvement is highly encouraged.
If you wish to contribute ideas or code, please visit our site linked below or make pull requests to our Github repository.
For further information on the TrinityCore project, please visit our project website at TrinityCore.org.
Requirements
Software requirements are available in the wiki for Windows, Linux and macOS.
Install
Detailed installation guides are available in the wiki for Windows, Linux and macOS.
Reporting issues
Issues can be reported via the Github issue tracker.
Please take the time to review existing issues before submitting your own to prevent duplicates.
In addition, thoroughly read through the issue tracker guide to ensure your report contains the required information. Incorrect or poorly formed reports are wasteful and are subject to deletion.
Submitting fixes
C++ fixes are submitted as pull requests via Github. For more information on how to properly submit a pull request, read the how-to: maintain a remote fork. For SQL only fixes, open a ticket; if a bug report exists for the bug, post on an existing ticket.
Copyright
License: GPL 2.0
Read file COPYING.
Authors & Contributors
Read file AUTHORS.