Machiavelli
33808ab567
Core/Spells: Fix Improved Spirit Tap proc from Mind Flay crits.
...
Author: Dr.Tenma
Fixes issue #2786
--HG--
branch : trunk
2010-12-20 01:58:15 +01:00
Machiavelli
f71c97f6c5
Core/Items: Fix ITEM_SPELLTRIGGER_ON_NO_DELAY_USE (5). This trigger should (only) trigger the respective spell when the item is added to the inventory. Aura´s created by this spell will be properly removed when the item is destroyed as well.
...
--HG--
branch : trunk
2010-12-20 00:46:00 +01:00
leak
fd694cd232
Streamlining loading functions for server startup
...
- Added a couple of timer outputs
- Improved code consistency between loading functions
- Progess bars should look and behave similar on all OS now (sLog.outString() is not needed anymore to replace the progress bar in log files)
--HG--
branch : trunk
2010-12-19 17:06:33 +01:00
Shauren
14a480cb13
Core/Players: Fixed recently introduced crashes in Player::ApplyEnchantment
...
Closes issue #5193 .
--HG--
branch : trunk
2010-12-19 15:22:19 +01:00
Shauren
a4f437a523
Core/GameObject: Dismount the player when using spellcaster gameobject
...
Closes issue #2539 .
--HG--
branch : trunk
2010-12-19 11:56:37 +01:00
linencloth
59da698189
Core: Rename spell attributes, use more general names
...
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Shauren
43377b4daf
Core/Players: Remove player from transport before teleporting to graveyard, will fix infinite recursion when trying to access unavailable map
...
Core/Auras: Removed unneeded typecasting
Closes issue #4862 .
--HG--
branch : trunk
2010-12-19 00:01:22 +01:00
Machiavelli
a093408360
Core/Player: Convert _SaveAuras to prepared statement format
...
--HG--
branch : trunk
2010-12-18 23:25:03 +01:00
Shauren
7196b880d6
Core/Spells: Fixed possible crashes in Shadow's Fate proc (71169) introduced in r91073dc6ace3
...
Core/AuctionHouse: Removed "using namespace std" and fixed crash in AuctionHouseMgr destructor
Closes issue #5132 .
Closes issue #5134 .
--HG--
branch : trunk
2010-12-18 23:16:55 +01:00
silinoron
41a9d3216c
Core/Auras: Fix Cold Blood handling on misses and parries.
...
Patch by dr.tenma.
Fixes issue #2291
--HG--
branch : trunk
2010-12-18 13:06:38 -08:00
leak
525a1e0ff0
Core/Entities: Remove gem bonuses if requirements of prismatic sockets are not met
...
Closes issue 4949.
--HG--
branch : trunk
2010-12-18 15:56:55 +01:00
Machiavelli
57132e35b8
Core/Spells: Fix spells 59915 and 59906 / Discerning Eye of the Beast and Swift Hand of Justice (Heirloom trinkets)
...
Fixes issue #2435
Fixes issue #2529
--HG--
branch : trunk
2010-12-18 12:27:40 +01:00
Machiavelli
32d94ed52a
Core/Units: Aura´s of type SPELL_AURA_MOD_RESISTANCE_EXCLUSIVE (143) should stack with eachother in the way that only the strongest aura of each magical school applies.
...
Author: Iskander
Fixes issue #3897
--HG--
branch : trunk
2010-12-17 20:31:46 +01:00
click
97f912fe93
Core/Pets: Use the safer pet level check-method in SynchronizeLevelWithOwner() too (forgotten in previous commit)
...
--HG--
branch : trunk
2010-12-17 20:27:36 +01:00
click
0785ad465b
Core/Pets: Clean up logic/codedesign slightly for XP/levelup-handling, and also fix a possible overflow in the pet level-tests
...
(Thanks to Vladimir for the discussion regarding the possible overflow!)
--HG--
branch : trunk
2010-12-17 20:08:27 +01:00
Shauren
b11e5bbf81
Core/Achievements: Prevent ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL updates at login
...
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL_AT_AREA
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_TEAM_RATING
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_REACH_TEAM_RATING
Core/Achievements: Implemented map id requirement for achievement criterias
Closes issue #4479 .
Closes issue #4478 .
Closes issue #4473 .
Closes issue #4472 .
Closes issue #4471 .
Closes issue #4480 .
Closes issue #2284 .
Closes issue #4481 .
--HG--
branch : trunk
2010-12-17 18:12:46 +01:00
Machiavelli
1cdeb4d057
Core/Player: Change equipmentset saving to use prepared statements.
...
Update issue #4550
Please try to re-reproduce
--HG--
branch : trunk
2010-12-17 17:29:16 +01:00
Shauren
82f45966fc
Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
...
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)
--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
Spp
ee3fd3ebeb
Core/Vehicles: Fix facing adjustment. Patch by beberlescaraber
...
closes issue #1810
updates issue #4714
--HG--
branch : trunk
2010-12-17 13:22:17 +01:00
click
0c6750dd52
Core: Fix a memoryleak in LoadCreatureFormations() - thanks to ge0rg (again)
...
--HG--
branch : trunk
2010-12-17 05:05:17 +01:00
click
a6df53bbe2
Core/Spells: Fix erraneous behaviour on hunter spell Lock and Load (disable charge-drop) - thanks to Dr. Tenma
...
Closes issue 3307
--HG--
branch : trunk
2010-12-17 04:52:17 +01:00
Anubisss
942dadc6a9
Correctly fix my change (r10666 / 672c38da05).
...
Kudos go to QAston.
--HG--
branch : trunk
2010-12-16 19:23:58 +01:00
Anubisss
6d9029c12e
Make some cleanup.
...
My thank goes to Az@zel for the code analysis.
--HG--
branch : trunk
2010-12-16 18:08:23 +01:00
Spp
4671500172
Core/Dungeon Finder: Move all LFG data from Player and Group classes to internal LFG data classes.
...
--HG--
branch : trunk
2010-12-16 10:53:21 +01:00
Machiavelli
ad13cd89b5
Core/Items: Fix item duration saving (and loading at a later stage).
...
--HG--
branch : trunk
2010-12-15 15:00:52 +01:00
Spp
382fef1958
Core: Some warning fixes
...
--HG--
branch : trunk
2010-12-15 10:44:06 +01:00
azazel
ddf06c086e
Core/Social: properly remove deleted character from social list of online players (by Emtec)
...
--HG--
branch : trunk
2010-12-15 14:44:41 +06:00
azazel
0fdea34a8a
Core/Items: fix error in saving item's enchantments introduced in rev 022f3858fc (thanks Shauren for spotting the problem)
...
--HG--
branch : trunk
2010-12-15 14:44:02 +06:00
azazel
b39b8fdd0d
DB Schema/Characters: removed columns auctionhouse.item_template, character_inventory.item_template, guild_bank_item.item_entry and mail_items.item_template and created item_instance.itemEntry column instead of them.
...
As a side effect moved related queries to prepared statements.
As one more side effect fixed not shown and lost mail items in returned expired mail (patch by Quriq14).
--HG--
branch : trunk
2010-12-15 14:08:12 +06:00
Shauren
58a9b15443
Core: Fixes some warnings
...
Core/SmartAI: Fixed DamageTaken and DamageDealt hooks
--HG--
branch : trunk
extra : rebase_source : 062f1c68cd1d318d192b294a493db17a1943bee2
2010-12-14 22:45:23 +01:00
Shauren
f4581f67b8
Core: Fixed uninitialized variable warnings
...
--HG--
branch : trunk
2010-12-14 15:58:45 +01:00
Liberate
6be8446053
Core/Gameobjects: Fix fishing and looting specific chests which were bugged because of revision 044e466d75.
...
Fixes issue #5116 .
--HG--
branch : trunk
2010-12-14 15:02:42 +01:00
Liberate
09f4eb9e1c
Core/Gameobjects: Make a chest not lootable when it still has a respawn time, to avoid cheating using third-party software.
...
--HG--
branch : trunk
2010-12-14 03:58:59 +01:00
click
2642894342
Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
...
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.
--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
azazel
d2d62eab50
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
...
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.
--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
click
81db111ffd
Core/Spells: Fix mage talent Frost Warding (and a little cleanup on CalcAbsorbResist) - patch by DrTenma
...
Fixes issue 2715.
Closes issue 3770.
--HG--
branch : trunk
2010-12-11 12:00:57 +01:00
azazel
e7eb4e22e2
Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
...
--HG--
branch : trunk
2010-12-09 17:03:42 +06:00
azazel
8c2ce7f86d
Core/Auras: fix AuraType 138 to not affect ranged haste, and rename to SPELL_AURA_MOD_MELEE_HASTE (by michalpolko)
...
--HG--
branch : trunk
2010-12-09 14:40:59 +06:00
Shauren
611dc153b0
Core/Units: Corrected PLAYER_FIELD_BYTES2 invisibility/stealth flags, by VladimirMangos
...
--HG--
branch : trunk
2010-12-08 14:51:50 +01:00
Shauren
703835ee94
Core/Quests: Fixed Unholy Infusion (24749), Blood Infusion (24756) and added partial support for Frost Infusion (24757)
...
--HG--
branch : trunk
2010-12-06 22:54:19 +01:00
leak
59d12e3b4a
Core/Entities: Fixed a crash by accessing the GameObjectAI of a GameObject before the next Update cycle. Patch by Rat. Thanks to Visagalis for testing.
...
Fixes issue 4863
--HG--
branch : trunk
2010-12-06 04:52:33 +01:00
Spp
408fce1de6
Core: Some optimizations
...
- Declare some functions const
- Fix some mem leak
- Fix some resource leak
- Remove unused variables and functions
- Remove duplicate functions
- Reduce the scope of some variables
- Remove unused file
--HG--
branch : trunk
2010-12-06 02:07:53 +01:00
leak
6fe19b5a86
Core/Scripts: Split OnCreatureCreate() and OnGameObjectCreate() into two virtual functions each.
...
Note to scripters: be aware that you will need to hook into the Remove functions if you want to do stuff at GO/creature removal.
Closes issue 5011.
--HG--
branch : trunk
2010-12-05 18:04:10 +01:00
Spp
e621f5fe98
Core/Dungeon Finder: Code cleanup and minor optimizations
...
- Extend LfgState to keep control of the state of group and players using LFG
- Move scripts to its own class and initialize only if Dungeon finder is enabled
- Updated comments to doxygen format
- Use constructor initialization list
- All variables are declared in the inner most scope
- Fix some mem leaks
- Remove no longer needed code (Cleaner)
- Normalize handler function names
--HG--
branch : trunk
2010-12-05 17:50:26 +01:00
silinoron
3661ed8231
Core/Auras: Fix wrong durations on certain reflected spells.
...
Patch by dr.tenma.
Fixes issue #3611 .
--HG--
branch : trunk
2010-12-04 10:51:46 -08:00
_manuel_
ada9c4ae98
Core/CreatureAI: Implemented SummonedCreatureDies function for scripting, it is called when the summoner's summon dies.
...
--HG--
branch : trunk
2010-12-03 14:23:49 -03:00
Shauren
e0c992a8ba
Scripts/Icecrown Citadel: Added script for Blood Queen Lana'Thel
...
Scripts/Icecrown Citadel: Fixed Invocation of Blood announcement emote for Blood Prince Council
Scripts/Icecrown Citadel: Fixed intro for Lady Deathwhisper
Scripts/Icecrown Citadel: Fixed Bone Spike for Lord Marrowgar
--HG--
branch : trunk
2010-12-03 17:47:33 +01:00
click
28c2e270db
Core/Battlegrounds: Implement power resets on arena-fight preparations (first 60 seconds before arena-fight kicks off) (Thanks to Kaelima)
...
Restores all player powers every 5 seconds untill arena starts (fixes possible exploit with entering arena battle with full rage or runic power)
(The 5 second timer is not 100% confirmed, as official pages only states that the power is reset after prep-time - needs feedback)
Closes issue 4805
--HG--
branch : trunk
2010-12-02 22:50:30 +01:00
Spp
25ac835507
Core/Groups: Move all function definition from .h to .cpp
...
Core/Groups: Remove Group.h dependency from any .h file
--HG--
branch : trunk
2010-11-29 07:50:31 +01:00
click
0fde30f185
Core: Adjust packetsize for SMSG_RESYNC_RUNES - thanks to False.Genesis ( and to Svetilo12 for the heads up )
...
Closes issue 4943.
--HG--
branch : trunk
2010-11-28 00:40:20 +01:00