Machiavelli
f7ffd77123
Do not use hard coded index in SMSG_QUEST_POI_QUERY_RESPONSE. May be the resolution for some client crashes.
...
--HG--
branch : trunk
2010-03-20 21:26:29 +01:00
Xanadu
830062779e
Improved the kill proc slightly.
...
--HG--
branch : trunk
2010-03-20 18:49:50 +01:00
Machiavelli
b651b592ef
Fix arena point calculation. If the configured arena season is >= 5, teams below 1500 rating should get a fixed amount of points, equal to the amount of points a person with 1500 rating would get.
...
--HG--
branch : trunk
2010-03-20 17:51:23 +01:00
Machiavelli
d21f0c3ce8
Make sure a to be traded item ends up in the item update queue for the correct player.
...
--HG--
branch : trunk
2010-03-20 16:42:22 +01:00
Machiavelli
a0d8b0be48
Item system update
...
- Set ITEM_FIELD_CREATE_PLAYED_TIME to 0 in Item::Create, should fix crash described in issue 1199
- Change some function calls so on Player::_saveInventory the core doesn't have to check for existance of item anymore when iterating over m_refundableItems. The loop will now only update played time, removal of items from this set is done in other functions.
- Cleanup in affected functions.
--HG--
branch : trunk
2010-03-20 16:26:16 +01:00
Tartalo
10417f1e6d
Fix few typos on last commits
...
--HG--
branch : trunk
2010-03-20 13:22:02 +01:00
Tartalo
3ddaedf88c
Gundrak, Slad'Ran: Despawn adds on wipe
...
--HG--
branch : trunk
2010-03-20 13:20:35 +01:00
Tartalo
830e55cfcb
Azjol Nerub, Anub'Arak: Despawn adds on wipes
...
--HG--
branch : trunk
2010-03-20 13:18:48 +01:00
Tartalo
617c94c9da
Halls of Stone: Implement achievement Brann's Spankin' New
...
--HG--
branch : trunk
2010-03-20 13:15:44 +01:00
Tartalo
3c2d7a4bba
Merge
...
--HG--
branch : trunk
2010-03-20 13:07:24 +01:00
Tartalo
5bd575b974
Halls of Stone: Allow to loot Brann's chest when encounter ends (without waiting all the event). Blizzlike change
...
--HG--
branch : trunk
2010-03-20 13:06:21 +01:00
Trazom62
feeb3f564c
Restore RewardPlayerAndGroupAtKill call from previous commit. This is the xp or honor reward for the tapping player/group.
...
--HG--
branch : trunk
2010-03-20 13:02:34 +01:00
Xanadu
34fb5df569
Fixed KILL proc to occur for the unit that lands the killing blow, not for the loot recipient.
...
--HG--
branch : trunk
2010-03-20 04:18:08 +01:00
Trazom62
7a8dff70ed
Fix Object::IsInMap to check instanceId.
...
Fig group loot distance checks to also check map instanceId.
Fixes issue #1172 .
--HG--
branch : trunk
2010-03-19 22:28:00 +01:00
Machiavelli
b6258cf1cf
Fix SQL yet again, thanks Trazom. (My apologies)
...
--HG--
branch : trunk
2010-03-19 22:06:38 +01:00
Machiavelli
86a33aa538
Fix SQL's, thanks Aokromes.
...
--HG--
branch : trunk
2010-03-19 22:00:52 +01:00
Machiavelli
3ae5a4094e
Implement instance script for Zul'Farrak and prevent Gahz'Rilla from being summoned multiple times.
...
--HG--
branch : trunk
2010-03-19 21:38:07 +01:00
Machiavelli
0c6368bd39
Fix hunter pet talent reset feature.
...
Thanks to Xanadu and nalimleinad for aiding research.
--HG--
branch : trunk
2010-03-19 20:20:42 +01:00
XTZGZoReX
2b55eb2efe
* Fix a typo that broke guild creation times...
...
--HG--
branch : trunk
2010-03-19 18:27:53 +01:00
XTZGZoReX
bb99135e40
* Minor cleanups/comments in regards to SMSG_GUILD_INFO.
...
--HG--
branch : trunk
2010-03-19 17:24:23 +01:00
Xanadu
31608cfb72
Merge
...
--HG--
branch : trunk
2010-03-19 16:32:50 +01:00
Xanadu
64066da223
Fixed a crash. Closes issue #1182 .
...
--HG--
branch : trunk
2010-03-19 16:30:07 +01:00
Machiavelli
01dc7aeb08
Fix heirloom armor proficiency downgrading for warriors.
...
--HG--
branch : trunk
2010-03-19 16:26:46 +01:00
Machiavelli
a77ba0bf56
Fix SMSG_GUILD_INFO (/guildinfo command)
...
--HG--
branch : trunk
2010-03-19 14:47:08 +01:00
teacher
9d5049da94
Little sql improvement.
...
--HG--
branch : trunk
2010-03-19 14:21:21 +01:00
Machiavelli
1146c59f66
Fix crash in Player::_saveInventory().
...
Fixes issue #1175
--HG--
branch : trunk
2010-03-19 13:36:54 +01:00
thenecromancer
34d7e1fed9
Missing part of previous commit (Periodic Leech is DoT as well)
...
Fix talents Improved Rend and Gag Order not increasing whole damage of affected spells
(applying effect modifiers - spellmod_effectx should be however done for every static damage added to already calculated damage, we can't just apply all spellmods after effects are processed...)
--HG--
branch : trunk
2010-03-19 08:47:03 +01:00
thenecromancer
f1266ebec3
Update player damage reduction by resilience combat rating
...
Apply crit damage reduction to periodic crit damage
--HG--
branch : trunk
2010-03-19 08:30:39 +01:00
thenecromancer
e67274392e
Fix issues with NPC that have nonphysical melee damage
...
Remove Ranged attack from attackerstateupdate() children function (Ranged attacks are always done using spells)
--HG--
branch : trunk
2010-03-19 08:26:44 +01:00
Xanadu
812874a55b
Fixed broken missile visuals in certain DST and SRC type spells (Void Reaver's Arcane Orb and many others). Achieved by fixing wildly incorrect SMSG_SPELL_GO target mask data handling.
...
--HG--
branch : trunk
2010-03-19 00:21:57 +01:00
Machiavelli
35a7f4849e
Store alternate currency spent on an item by Item ExtendedCost entry instead of honorPts/arenaPts/items seperately. Thanks to Opterman for the idea.
...
--HG--
branch : trunk
2010-03-18 22:56:48 +01:00
Rat
ef57a96cce
*fix quest Bury Those Cockroaches!(11608)
...
--HG--
branch : trunk
2010-03-18 22:34:14 +01:00
Rat
d08567965a
*fix Merciless Totem of the Third Wind proc
...
*fix in world.sql
--HG--
branch : trunk
2010-03-18 21:32:16 +01:00
Xanadu
06d4918163
Added unit targets for TARGET_TYPE_DEST_TARGET and TARGET_TYPE_DEST_CASTER to tackle the cases where unit targets are required but there is no other implicit target to produce them (like in 53, 0 combination).
...
This works in conjunction with my next commit.
--HG--
branch : trunk
2010-03-18 20:41:38 +01:00
silverice
aca2d26bc5
remove unused player's class member,cleanup
...
--HG--
branch : trunk
2010-03-18 20:21:42 +02:00
Xanadu
59e0d42260
Added (blizzlike) packet broadcast to near teleport. Thanks to Zor and nalimleinad (AKA anonymous colleague #1 ) for research.
...
--HG--
branch : trunk
2010-03-18 17:58:27 +01:00
Machiavelli
302af79bc2
Implement vendor item refund system.
...
For info about this system, see: hxxp://us.blizzard.com/support/article.xml?locale=en_US&articleId=27351
Thanks to:
- Opterman, Malcrom, Xanadu + anonymous colleagues for aiding research on packet structure
- Aokromes and Svannon for testing
--HG--
branch : trunk
2010-03-18 17:27:40 +01:00
Xanadu
72833e1584
Identified a new spell attribute forbidding some spells to use caster's done dmg mods (spellpower etc).
...
--HG--
branch : trunk
2010-03-18 17:22:11 +01:00
XTZGZoReX
793a226692
* Remove typeid check and fix cast target for Improved Fear. Patch by jesper.vortex.
...
* Closes #946 .
--HG--
branch : trunk
2010-03-18 14:57:39 +01:00
XTZGZoReX
1a6f216e91
* Cleanups and comments in Player::SendInitWorldStates.
...
--HG--
branch : trunk
2010-03-18 14:48:33 +01:00
Rat
2b096c478a
*always remove UNIT_FLAG_OOC_NOT_ATTACKABLE if crature enters combat and reset on leave combat
...
-Please post feedback if it breaks any script!
--HG--
branch : trunk
2010-03-18 00:01:39 +01:00
Rat
4f948651df
*Fix possible exploits with flying paths. by QAston
...
--HG--
branch : trunk
2010-03-17 23:16:35 +01:00
[email protected]
bef85de621
Add script for Amberpine Woodsmen Grizzly Hills
...
--HG--
branch : trunk
2010-03-17 18:27:17 -02:30
Xanadu
5603de6048
Argent Tournament Post script by Malcrom
...
--HG--
branch : trunk
2010-03-17 21:20:21 +01:00
Xanadu
6f6c7a85af
Merge
...
--HG--
branch : trunk
2010-03-17 21:17:02 +01:00
Xanadu
2c605ee482
Upgraded SCRIPT_COMMAND_EMOTE to do state emotes, too, based on datalong2 value. By Malcrom.
...
--HG--
branch : trunk
2010-03-17 21:00:44 +01:00
silverice
4177b876f3
Added hack that was removed in [7443]
...
Closes issue #979
--HG--
branch : trunk
2010-03-17 21:34:42 +02:00
Xanadu
48d7ae707d
Fixed players not being able to resurrect after core crash.
...
--HG--
branch : trunk
2010-03-17 20:34:02 +01:00
Xanadu
a73b9b0f1e
Cleanup
...
--HG--
branch : trunk
2010-03-17 17:43:28 +01:00
Xanadu
e5cbe017f4
Fixed Drain Soul increased damage for targets below 25% HP. Closes issue #394 . Closes issue #748 . Closes issue #938 . Rejoice, new era of server-side spells has begun!
...
--HG--
branch : trunk
2010-03-17 16:38:31 +01:00
Rat
4fb7bf3664
*fix Feral Spirit's healing (Spirit Hunt)
...
--HG--
branch : trunk
2010-03-17 08:07:14 +01:00
Anubisss
fe67a3bc6e
Fix some possible crashes.
...
--HG--
branch : trunk
2010-03-16 23:46:20 +01:00
Trazom62
6d63c432e6
Fix Hunter's spell Snake Trap.
...
Fixes issue #896 .
--HG--
branch : trunk
2010-03-16 21:32:01 +01:00
Trazom62
b00c745455
Update Halls of Stones script text entries to correct range.
...
Fixes issue #607 .
--HG--
branch : trunk
2010-03-16 21:24:00 +01:00
Machiavelli
53bfd0934a
Remove some files that were accidentaly added to last changeset.
...
--HG--
branch : trunk
2010-03-16 08:11:33 +01:00
Machiavelli
bbfdc117c8
Overload Item::SetState correctly in Item::SetItemRandomProperties.
...
Fixes issue #1126
--HG--
branch : trunk
2010-03-16 08:05:09 +01:00
reno
e65dfc6a31
attempt to stop mobs casting and fleeing while stunned or confused
...
--HG--
branch : trunk
2010-03-15 14:38:30 -05:00
Machiavelli
b0b17e56de
- Overload Item::SetState with player argument where possible to ensure updated data is saved to DB properly.
...
- Alter Item::SetEnchantmentDuration function, add parameter Player* because GetOwner() cannot be called in the function due to hashtable locking in the SaveAllPlayers process.
- Remove a sanity check prior to Item::AddToUpdateQueueOf, so assertions can detect whenever a higher level function was not called properly. Please report any crashes related to these assertions to get them resolved asap.
--HG--
branch : trunk
2010-03-16 01:05:56 +01:00
teacher
5b277b11a7
Moved sql update files to 3.3.2_old directory.
...
Fixed my typo in world.sql.
--HG--
branch : trunk
2010-03-15 23:43:20 +01:00
thenecromancer
a81ad6986c
Remove Hack detecting spell 61988 in HasAura()
...
Correctly cast 61988/61987 after casting Avenging Wrath/Divine Shield respectively
(This will correctly show both spells disabled state)
Don't allow casting Lay on Hands on self when aura 61988 is present (ie. after using Avenging Wrath)
--HG--
branch : trunk
2010-03-15 18:03:43 +01:00
Machiavelli
3ba0862926
Fix guild bank money log display.
...
--HG--
branch : trunk
2010-03-15 17:17:19 +01:00
Machiavelli
f9a3aedc14
Don't call Item::AddToUpdateQueueOf if no player is specified as parameter for Item::SetState, since in this case, only data stored in the item_instance table is altered, not that of character_inventory.
...
--HG--
branch : trunk
2010-03-15 14:52:02 +01:00
Machiavelli
c47b8a89c1
Fix issue with .save or .saveall where either the core would freeze, or items would not be saved to the DB properly.
...
Fixes issue #381
Fixes issue #477
--HG--
branch : trunk
2010-03-15 14:03:13 +01:00
Machiavelli
ce51f24ff3
Change field crc in characters.addons to int(32) to support proper values.
...
--HG--
branch : trunk
2010-03-15 13:24:45 +01:00
Xanadu
f9566e08ac
Properly implemented CONDITION_ACHIEVEMENT for the DB gossip system.
...
--HG--
branch : trunk
2010-03-15 04:37:28 +01:00
Xanadu
8cc3d2ad7f
Fixed Drain Soul and Shadowburn Soul Shard on target death. Closes issue 1058.
...
--HG--
branch : trunk
2010-03-15 02:59:21 +01:00
Trazom62
1845a9588d
Fix lootable check in Player::isAllowedToLoot.
...
--HG--
branch : trunk
2010-03-15 00:21:37 +01:00
Rat
c8fd37a9dc
*small tweaks to Utgarde keep bosses
...
--HG--
branch : trunk
2010-03-14 23:44:27 +01:00
Spp
f1696c42c9
Send SMSG_DESTRUCTIBLE_BUILDING_DAMAGE when a destructible building takes damage
...
Thanks to Opterman for the packet structure.
--HG--
branch : trunk
2010-03-14 21:10:21 +01:00
Trazom62
8d51d23cc5
Fix Master's call. Thanks Gyullo.
...
Fixes issue #1059 .
--HG--
branch : trunk
2010-03-14 13:46:15 +01:00
Trazom62
6fdaf225f3
Fix creature tapped and lootable dynamic flags => fix creature not lootable.
...
Fixes issue #1067 .
--HG--
branch : trunk
2010-03-14 00:22:53 +01:00
teacher
274268a686
Random sql cleanup.
...
--HG--
branch : trunk
2010-03-13 20:51:59 +01:00
Trazom62
7ff698b505
Fix SQL errors in world_script_texts.
...
--HG--
branch : trunk
2010-03-13 18:28:19 +01:00
Machiavelli
f56d65dc2a
Fix display of item enchantments in mailbox
...
--HG--
branch : trunk
2010-03-13 17:22:42 +01:00
XTZGZoReX
f8c5b9a4a7
** Cleanup in ObjectAccessor/HashMapHolder:
...
* Correctly lock the HashMapHolder on access.
* Use ObjectAccessor wrappers (GetPlayers, GetCreatures, GetGameObjects) instead of raw HashMapHolder<Type>::GetContainer.
* General code style cleanup.
--HG--
branch : trunk
2010-03-13 16:17:25 +01:00
Trazom62
76afec204d
Yet another crash fix due to invalid cast.
...
Fixes issue #1079 .
--HG--
branch : trunk
2010-03-13 12:51:37 +01:00
Trazom62
75a63297ca
Fix ScriptedAI::SelectUnit to support SELECT_TARGET_NEAREST and SELECT_TARGET_FARTHEST.
...
Remove duplicate select target function CreatureEventAI::SelectUnit.
--HG--
branch : trunk
2010-03-13 12:15:32 +01:00
Trazom62
4c9a9a02b0
Fix crash in boss_svala script + some cleanup.
...
Fixes issue #880 .
--HG--
branch : trunk
2010-03-13 11:48:43 +01:00
Spp
eb96718b5f
Add missing file in previous commit.
...
--HG--
branch : trunk
2010-03-13 07:12:20 +01:00
Spp
ff89bad0fe
Allow Battlegrounds and arenas to be disabled by DB.
...
wtlk arenas disabled by default.
- Player will continue to see all bgs using UI, but won't be able to join disabled bg's
- Gossip menu not shown for disabled Bgs/arenas
- Id 6 disabled = all arenas disabled.
- Only id 6 arena enabled = Gossip shown but unable to join any arena
--HG--
branch : trunk
2010-03-13 00:47:24 +01:00
Spp
e1a8e1b2c9
Fix compile after 7548.
...
Also reorder the columns of account onlinelist command
--HG--
branch : trunk
2010-03-12 20:43:46 +01:00
Anubisss
cb72277769
Fix a typo in a SQL.
...
--HG--
branch : trunk
2010-03-12 19:28:48 +01:00
Spp
673ab0019c
Some Ticket text formating changes to help addons to parse data
...
Linked issue 466
--HG--
branch : trunk
2010-03-12 19:20:11 +01:00
Spp
2cac9671ca
Add map and zone to account onlinelist command.
...
Closes issue 466
--HG--
branch : trunk
2010-03-12 18:55:41 +01:00
Spp
d2a3f9670f
Move vehicle accesories to DB.
...
Credit to Malcrom and Manuel for the idea and original patch
--HG--
branch : trunk
2010-03-12 18:19:50 +01:00
Machiavelli
19b646cdff
Typo (sorry)
...
--HG--
branch : trunk
2010-03-12 14:28:43 +01:00
Machiavelli
b085d8eadc
Fix faulty debug logging and a crash caused by improper typecasting. Fixes issue #1068
...
--HG--
branch : trunk
2010-03-12 14:25:43 +01:00
raczman
b23a85e810
Correct faction of Titan Relic in SOTA.
...
author: maxdestroyer
--HG--
branch : trunk
2010-03-12 11:53:30 +01:00
Xanadu
9f81a8ba5c
Fixed crash on player kill and cleaned up the code a bit. Closes issue 1062. Closes issue 1064.
...
--HG--
branch : trunk
2010-03-12 05:46:32 +01:00
Trazom62
8210a97e73
Fix achievement title check at startup.
...
--HG--
branch : trunk
2010-03-11 23:25:04 +01:00
Trazom62
856d41a7b5
Fix Val'anyr, Hammer of Ancient Kings. Thanks sombre88.
...
Fixe issue #910 .
--HG--
branch : trunk
2010-03-11 23:18:05 +01:00
Trazom62
8947cfd41c
Fix crash in getFactionTemplateEntry.
...
Fixe issues #1050 .
--HG--
branch : trunk
2010-03-11 23:12:44 +01:00
Trazom62
ed8c5ef6ff
Implement group loot for chest having GroupLootRules (go type=3, data15=1).
...
Implement round robin loot.
Implement round robin for underthreshold items (group loot and need befor greed).
Fix "all players pass" bug on creature.
Add SMSG_LOOT_LIST message to indicate looter (round robin or master).
And some other minor loot bugs.
Fixes issue #167 .
Fixes issue #247 .
--HG--
branch : trunk
2010-03-11 22:55:02 +01:00
Machiavelli
d9f257a18c
Allow spellid_x fields in item_template to be signed integers. Thanks to Svannon and RedSonja for testing.
...
--HG--
branch : trunk
2010-03-11 21:40:42 +01:00
thenecromancer
e1542df90c
Convert some C style casts to new functions
...
--HG--
branch : trunk
2010-03-11 20:51:31 +01:00
thenecromancer
01ee5399a7
Remove some Debug logs nobody needed anymore
...
they've also contained wrong typecast function, therfore this'll fix issue 1054
--HG--
branch : trunk
2010-03-11 19:57:23 +01:00
Xanadu
d2dfe54916
Merge
...
--HG--
branch : trunk
2010-03-11 16:56:07 +01:00
Xanadu
ebee705452
Fixed SCRIPT_COMMAND_ORIENTATION, orientation needs to be float. Credit to Malcrom.
...
--HG--
branch : trunk
2010-03-11 16:54:25 +01:00
n0n4m3
d8db56ec48
Add report unknown packets in the error log and close this packets.
...
--HG--
branch : trunk
2010-03-11 15:09:51 +03:00
Xanadu
4c7e599802
Fixed ACTION_T_COMBAT_MOVEMENT preventing waypoint movement in OOC state.
...
--HG--
branch : trunk
2010-03-11 01:56:47 +01:00