josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
33,352 Commits 1 Branch 0 Tags
ed4788190d52f8739b89fe2e4ef1a5e991631077
Commit Graph
33352 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Aokromes ed4788190d Revert permision change 
(cherry picked from commit 92359de5ef1aea170f7f7ead0da092a8cb1b1fbc)
 2020-08-22 13:59:28 +02:00
tkrokli c053cc1b04 DB/Quests: Terokkar Forest quest text typos 
Fixed the following typos:
- 'Clues in the Thicket' (9971) RewardText typo (Is it was/Is it what)
- `An Unseen Hand` (10013) RewardText typo (duplicated words "it to me")
- 'Evil Draws Near' (10923) Progress typo (ben/been)

(cherry picked from commit 446ea121271c77407429368e5491a84eef7fc19b)
 2020-08-22 13:59:09 +02:00
Necropola 885e172f4d [3.3.5] Core/Pet: Make pet action bar autocast persist properly (#20110) 
Partial revert of of 6c21ddd9b98d372cb802c9abf034e2aa3ecc70b9.
Closes #16211.

(cherry picked from commit 906498e9f4d80ff10094cd3f365b310d9dec4521)
 2020-08-22 13:55:11 +02:00
Treeston d5a9461e26 DB/InstanceSpawn: More low-hanging fruit - Ruby and Obsidian Sanctum. 
(cherry picked from commit 70a48ff182aa3c01152dad6302aa043b5555558a)
 2020-08-22 13:54:38 +02:00
Treeston a7baefeadb DB/InstanceSpawn: The easy ones. Gruul's Lair, Magtheridon's Lair, Onyxia's Lair, Eye of Eternity. 
(cherry picked from commit fd9a93b45e9839e8f22b3572c16b16c32fcd771e)
 2020-08-22 13:52:45 +02:00
Treeston 608c9aaabf Scripts/InstanceScript: Implement database framework for managing spawn groups based on boss state. (#20103) 
(cherry picked from commit 84590be26d6b3c56b95a804cbe889826186dd8a2)
 2020-08-22 13:48:44 +02:00
Treeston acb4934f76 Core/Unit: Don't apply liquid effects to game masters. 
(cherry picked from commit 2644fa703a6b20b6f1d62360fb47bc719cf43933)
 2020-08-22 13:35:46 +02:00
Shauren 50a64ccd1e Core/Misc: Revert back to using boost::regex, std::wregex doesn't work for name validation 
Closes #20094

(cherry picked from commit 6691e41873f255c0f303229b0bd2e5db77a3c879)
 2020-08-22 13:21:55 +02:00
Treeston f15b4f5043 Scripts/Commands: Fix some quirkiness and potential crashes with live DB modification commands (npc move and npc delete), which are horrible and should be deleted anyway. 
Fixes #20104.

(cherry picked from commit 759357049cdbe9a2f97bbab6e61299cd65ba1bec)
 2020-08-22 13:16:34 +02:00
Treeston 703910d71b Scripts/Commands: New utility command: .list spawnpoints. 
(I just needed it for dynspawn follow-up work, really.)

(cherry picked from commit fcd6fe0aac0b906e2cf8e2379d94a7d73384c160)
 2020-08-22 13:11:34 +02:00
r00ty-tc 03b125e6d1 Dynamic Creature/Go spawning: 
- True blizzlike creature spawn/respawn behavior - new creature = new object
 - Toggleable spawn groups (with C++/SAI/command options to use them)
 - Custom feature: dynamic spawn rate scaling. Accelerates respawn rate based on players in the zone.
 - Backward compatibility mode (set via group and for summons)
   to support creatures/gos that currently don't work well with this
   (this should be removed once the exceptions are fixed)

Fixes and closes #2858
Tags #8661 as fixable.
Fixes and closes #13787
Fixes #15222.

(cherry picked from commit 59db2eeea0a35028779fd76372ae06cc98c8086f)
 2020-08-22 12:59:57 +02:00
jackpoz bf5be28396 Core/Misc: Fix static analysis issues 
Fix various coverity reported issues

(cherry picked from commit 925557d1c097cd45311b38dc3a9c715579456980)
 2020-08-21 23:13:13 +02:00
Treeston 42c65c3bc2 Core/Chat: Provide a fully-formed protocol for addons to interact with GM commands (#20074) 
Send success/fail state, allow interleaving, and indicate end of output. Add framework for supporting non-human-readable output in commands.

(cherry picked from commit 508c9d2fc1b20dc2cb40df533e823e1dfe2becc3)
 2020-08-20 00:49:52 +02:00
Treeston e69b5d8fcc Scripts/IcecrownCitadel: Prevent players from becoming inaccessible when killed by Lord Marrowgar's Impale spell (the initial damage, not the DoT). Also fix the underlying bug in vehicle logic. 
(cherry picked from commit 7cbb6c101e975a046b95aeb5dd68d75d016f67a5)
 2020-08-20 00:21:37 +02:00
ccrs 9757a2992a Core/AI: correct Permit level for trigger flagged creatures 
This broke several mechanics such as LK hc Frostmourne Room or Rotface's slime, how come no one noticed it? Like really, no one?
ref ce3787f190d28c1e981598eef2cd24c622a2cbae

(cherry picked from commit 1de89579c75f7b5d5028b162334fa496832a093c)
 2020-08-20 00:20:03 +02:00
Treeston e5836dcc1a Core/Unit: No code change, just updating a comment with insights gleaned from sniffs. 
(cherry picked from commit f2f45765e408cbba49e15ea642a1ed052c751bcf)
 2020-08-20 00:19:23 +02:00
Treeston e6be53d141 Core/WorldObject: Properly initialize position data for all types when initially creating them. Fixes some issues with PvP objectives not having the correct area ID set on initialization. Closes #20028. 
(cherry picked from commit 28b3469e89f89a8c87fad06bad27800939abf0f5)
 2020-08-20 00:18:48 +02:00
Shauren b630e9a485 Warning fix 2020-08-20 00:12:20 +02:00
Treeston e51960ea45 Core/PlayerAI: Some adjustments: 
- Add a 2 second delay before the AI begins using spells. This should provide opportunity for counterplay before that rogue activates cloak and goes on an unstoppable rampage among your healers. (Sorry, guys.)
- Stopped the AI from attacking invalid targets under some conditions. It should now properly leash back and follow the charmer if we try to select an invalid target.
- Stopped the AI from constantly re-creating the follow movement generator (and thus spamming movesplines).

(cherry picked from commit 331e463de83e4ea13935773f992b32733272d263)
 2020-08-20 00:11:18 +02:00
Treeston 2c92e09230 Scripts/Auchindoun: Last one, hopefully. Remove reliance on large grid searchers by integrating with instance script. 
(cherry picked from commit d80d7c6685b8a52d5ff7c2a3fade728b91c17eb4)
 2020-08-20 00:08:04 +02:00
Treeston 6599dab1e1 Scripts/Auchindoun: Blackheart the Inciter fully fixed now. I had way too much fun with this one. 
Two points of note:
1) Spawning 5 invisible triggers with 5 distinct factions which then MC one target each? Biggest. Hack. Ever. Best part? It's blizzlike.
2) For over ten years, I thought it was spelled "Auchinodoun". It's not. It's spelled "Auchindoun". TIL.

(cherry picked from commit 04dc47e7e28a26cf027a5bb5c1a3ebf685861325)
 2020-08-19 23:50:31 +02:00
Treeston 8a1739d15e Scripts/Auchindoun: Replace the Blackheart the Inciter hack-filled script with a slightly less hack-filled script that actually mostly works. This should at least make the boss encounter possible to complete. No claims to correctness, of course. 
(cherry picked from commit a38141fd6c3a5cc40732af82edd22605e3f67a71)
 2020-08-19 23:47:25 +02:00
Treeston b1d2e4e906 Scripts/Spell: Port spell_generic.cpp to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 
(cherry picked from commit 49aa8a2e59b8873da109638cd7dbe24ef359f0ce)
 2020-08-19 23:42:29 +02:00
Treeston 4f676221b8 Scripts/Item: Port spell_item.cpp scripts to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 
(cherry picked from commit 37f59f8850d678b8c44710415e7431492c8526f2)
 2020-08-19 21:38:47 +02:00
treeston 89006f621e Scripts/Item: Change Nitro -> Boosts <- to use the correct knockup effect for their backfire. Also, script that knockup effect to work properly ("usually" deploy a rescue parachute). 
(cherry picked from commit 02b1d8bb484ed82be055438cd2bac1db5f18a101)
 2020-08-19 20:51:03 +02:00
treeston cc9889a3d4 Core/Taxi: Properly send taxi node status on login, as well as if the taxi master is out of range. Closes #20035. 
(cherry picked from commit 24ec3ad3409e66f523f533ec1d9d573000a5807f)
 2020-08-19 20:45:58 +02:00
treeston 0f741c4a7f Scripits/Item: Nitro. BOOSTS. 
(cherry picked from commit 125127ea73a68b6da8d1ba631539a9ebffd2c471)
 2020-08-19 20:18:44 +02:00
treeston ba7d8e9ace Scripts/Item: Fix Nitro Boosts to only fail in flyable areas. Also, it's called nitro _boosts_. Not _boots_. Nitro _boosts_. 
(cherry picked from commit f953d8596091cf70aab308a2c80ebdfa443b4723)
 2020-08-19 20:18:24 +02:00
jackpoz 32832fa9cb Core/Misc: Fix static analysis issues 
(cherry picked from commit 832a114196c7e9405d0569eac1d44de6c7dd83dc)
 2020-08-19 00:21:48 +02:00
Gustavo 111b65e10f Core/Vehicles: Do not call InstallAllAccessories for dead Vehicles (#20033) 
(cherry picked from commit 551d0559aac663e9485b0eaffac5326536180c27)
 2020-08-19 00:18:55 +02:00
jackpoz 77e6355fba Core/Misc: Fix static analysis issues 
(cherry picked from commit 9cf4dd7345b7f05db834fd48a9f0a135f1884d70)
 2020-08-19 00:14:06 +02:00
Killyana 1019fc5801 DB/Creature: Add some missing spawns in Deathforge 
(cherry picked from commit abf38f9b8fe151273853be61b738323fd6f1c936)
 2020-08-18 22:39:55 +02:00
jackpoz 76bd0adaa4 Core/Misc: Fix static analysis issues 
(cherry picked from commit 41f4a80f3097b41d19592bcbe99b9a8444eacb19)
 2020-08-18 19:46:12 +02:00
jackpoz 31654a2295 Core/Misc: Fix static analysis issues 
(cherry picked from commit b2a341df6efc099c35b436e1ec8eedd1632433d7)
 2020-08-18 19:42:54 +02:00
Regigicas e43d81cd68 Scripts/Commands: Fix a crash on summon when no group is avaible (#20029) 
Closes #20027

(cherry picked from commit d9c83a6c0143b17286f853f8b81e3dc6fd86642d)
 2020-08-18 19:16:04 +02:00
Killyana af5c195e7f DB: Use the correct ID for Hagash The blind 
Updates #18930

(cherry picked from commit 1f834d3cd195de5af8e5bf7f6410ffe3af65e497)
 2020-08-18 19:04:19 +02:00
Killyana 65c594d86e DB/SAI: Fix Thrallmar Grunt event text 
Closes #18930
By dr-j

(cherry picked from commit f9f15250a5b82f2d497f98887fe058e06dc36b39)
 2020-08-18 19:03:22 +02:00
Golrag c46aa9d5b5 Core/VMaps: Fix no collision triangles 
(cherry picked from commit 89d641f1e68d11359a2398ff51d3d6eee1470ae8)
 2020-08-18 18:53:13 +02:00
Weyrath 35bf146969 Core/Quests: Fixed order of RewardChoiceItems and reputation reward. (#19904) 
(cherry picked from commit 8b2bd9a5f204fe02c1110d5e851647ee96302880)
 2020-08-18 18:53:13 +02:00
Treeston 5f59be31b0 Core/AI: UnitAI::SelectTarget now applies offset BEFORE filtering by predicate (to match expected behavior). (#19975) 
* Also some major code deduplication (SelectTarget now calls SelectTargetList).

(cherry picked from commit 8d0633c842d474a843ec9f4bd45dcec3013bfd5d)
 2020-08-18 18:53:13 +02:00
Killyana 6e0be8b469 DB/Quest: Celestial Planetarium access heroic requirements 
Updates #19981

(cherry picked from commit 432dd7c25d1bfb83fe267e6aa5239eb4a5c23c1f)
 2020-08-18 18:53:13 +02:00
Killyana 4b6b59931a DB/Quest: Celestial Planetarium access quests 
Closes #19981

(cherry picked from commit 1008536ce487e5ec8a88c6d01ce68d7d3c138aa1)
 2020-08-18 18:53:13 +02:00
Killyana 1a1fe1847d DB/Creature: Overseer Faedris 
Remove Dup spawn
Closes #20020

(cherry picked from commit 13edbd9e317d47e6233503e80453e79540243e58)
 2020-08-18 18:53:13 +02:00
Killyana 842c120fda DB/Quest: Finish Me! 
Fix Quest requirements
Closes #20019
by meji46

(cherry picked from commit d50794a33ea7efeea8d7a7cec093168796fad28a)
 2020-08-18 18:53:13 +02:00
treeston 814f7e45fb Some more script adjustments ported from #19930. 
(cherry picked from commit 3f8c0cb446327061c4d5ba06e72044fb8308f694)
 2020-08-18 18:53:13 +02:00
Treeston 2c3a107bee Prevent an issue that stopped Aura AfterEffect handlers being called on default handler prevention. (#20001) 
Fixes #19996.

(cherry picked from commit ed241a2fd6c8fd419d350210aa61eb1ad05b27bb)
 2020-08-18 18:53:13 +02:00
treeston 1e6480ee35 Woopsie. Fix an oversight causing the main tank flag in SelectTarget to be inverted. 
(cherry picked from commit 9bacaf15b60dc455ae913062b05a5adb2b8bdcf9)
 2020-08-18 18:53:13 +02:00
treeston 2dfafa69eb Hi, I'm Treeston, and welcome to Combat PR Prep Refactors. 
Today, we're moving UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC to higher-level abstraction so combat manager can react to it.
New methods on Unit:
- void SetImmuneTo<All/PC/NPC>(apply, keepCombat = false);
- bool IsImmuneTo<All/PC/NPC>() const;

(cherry picked from commit 74af880217fc567c9949d7557408718af889402f)
 2020-08-18 18:53:13 +02:00
Killyana befbfbb655 DB/Creature: Tivax the Breaker 
(cherry picked from commit c6d799444572a6d3023a560d7d1c24b0d7a8d050)
 2020-08-18 18:53:13 +02:00
Keader db80892a41 Build fix 
(cherry picked from commit 3aadb72eaad2d0316365a39b5c448718052d6e36)
 2020-08-18 18:53:13 +02:00