Commit Graph
38188 Commits
Author SHA1 Message Date
Peter Keresztes Schmidt ec44c8296d Scripts/Commands: Use enum type arg for HandleDebugAnimCommand (PR #25256)
* Core/Shared: Make Emote enum smart
* Scripts/Commands: Use enum type arg for HandleDebugAnimCommand

(cherry picked from commit 86dc58974a46b554042f33df674e3e40ef0cec1e)
2022-01-26 22:16:05 +01:00
Treeston d297f65df2 Core/DB: Move every gameobject that uses the spawntimesecs < 0 hack into the legacy spawn group
(cherry picked from commit b74dc4754d8c1edb81e9564beea1783bdd39d87c)
2022-01-26 22:14:24 +01:00
scizzydo 1429237144 Core/Warden: Fix for LUA_STR_CHECK (#25247)
The check above is what I use to actually get a real result for LUA_STR_CHECK, which when I used variables that would have a string to them it actually fails the check. When checking for items like a function if it exists of course it won't work... In addition, fixing the Unk2 to Unk3 causes people to be able to adjust the address of the check to the address 0x00419210 to make warden perform the FrameScript__Execute to run lua on the client. This seems to be the big request like in https://github.com/TrinityCore/TrinityCore/issues/23035

(cherry picked from commit 4125a81bb132c8d108f5bb07787f00a9fadf5838)
2022-01-26 22:13:25 +01:00
Peter Keresztes Schmidt 3923650aeb Core/ChatCommands: Add support for enum type arguments (PR #25242)
(cherry picked from commit 5e40eb20e2789b86d4786d86b4bbb8ae83de5e1e)
2022-01-26 22:13:06 +01:00
Peter Keresztes Schmidt 2e3c612c80 Core/Unit: Make HandleEmoteCommand typesafe (#25249)
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter

* Scripts/HoR: Fix wrong emote during escape event

* Core/Unit: Make improve type safety of HandleEmoteCommand

Change argument type to the expected enum type Emote

* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE

UNIT_NPC_EMOTESTATE is no flag field

(cherry picked from commit 6c7837f947ff4eb5110a116a371daa6f9e2b3bbe)
2022-01-26 21:46:51 +01:00
Peter Keresztes Schmidt 595e89e02b Core/Spells: Mark constructors of Spell/AuraScript handlers as explicit (#25248)
Mostly to make clang-tidy happier

(cherry picked from commit 34d403e83f42304332f89ffc73549f6f2c695ccd)
2022-01-26 20:57:27 +01:00
Shauren b87f56d070 Core/Quests: Sync comments/log with 3.3.5 2022-01-26 20:46:42 +01:00
Aokromes e538d42f12 Script/Quest: The Light of Dawn (#25243)
remove incorrect check, source:
https://www.wowhead.com/spell=53606/the-light-of-dawn
Flags
Can be used while dead

https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=1495830
https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=374127
(cherry picked from commit 681c738c61cdf64728fcd86d7598666ab2fd8199)
2022-01-26 20:44:35 +01:00
Rushor 7f9986a8a8 DB/Creature: Add script & waypoints to Warden Treelos
Closes #13055

(cherry picked from commit 40e47778316b492e2e51f6b82d82420faf82259b)
2022-01-26 20:43:34 +01:00
offl 255adc9350 DB/Creature: Add CREATURE_FLAG_EXTRA_NO_COMBAT to Toxic Tunnel (Naxxramas)
Closes #16490

(cherry picked from commit 9d11c25e18286df9f3c21ac5bbe6b369b75da0cf)
2022-01-26 20:42:41 +01:00
Cerveciento b40c928d2a DB/Locale/esES+esMX Texts missing in quests (Part 19)
Closes #25245

(cherry picked from commit afd2146ad2336e853aa88f8283dedbfbf0ae8710)
2022-01-26 20:41:34 +01:00
Cerveciento f14d636a24 DB/Locale/esES+esMX Texts missing in quests (Part 18)
Closes #25241

(cherry picked from commit e9a1f747fc6c3a1f9d3988dc85ecaceb9dff50db)
2022-01-26 20:41:09 +01:00
Giacomo Pozzoni 7d548c34a9 Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units (#25229)
* Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units

* Update PassiveAI.cpp

Restored logic that removes loot flag while being possessed

* Restored logic that removes loot flag while being possessed

(cherry picked from commit 298d7994850dfc777c56a7672042d78074b67f3d)
2022-01-26 20:40:24 +01:00
offl bf1d04e3f4 DB/Quest: Update support for 'The Plains of Nasam' (11652)
Closes #23695

(cherry picked from commit dc7691a54913fc6fbd6c77e241662e00f441c33b)
2022-01-26 20:39:50 +01:00
offl 0184ea625c DB/Creature: Remove some wrong spawns
Ref #23791

(cherry picked from commit 2b8f314183c52958a4ad7c9cc7affec18ec39852)
2022-01-26 20:39:02 +01:00
offl 14f696f9fe DB/Creature: Fix gold value for world bosses
Source https://github.com/cmangos/tbc-db/commit/d10a189755188633a6c9c3a2fc45d8d2729dfee1

(cherry picked from commit 4c4e3b956fb3872e7327827311766e8063b413ed)
2022-01-26 20:38:24 +01:00
Cerveciento d4cbe4c6cb DB/Locale/esES+esMX Texts missing in quests (Part 17)
Closes #25240

(cherry picked from commit 5188f723b4c9c2a32badbd5bdb7e315fcd2de37f)
2022-01-26 20:37:42 +01:00
Cerveciento 5a48662abc DB/Locale/esES+esMX Texts missing in quests (Part 16)
Closes #25237

(cherry picked from commit 870e7549986d22f3e55cf70239672ccac0b700d6)
2022-01-26 20:36:57 +01:00
offl 4a21e54cc5 DB/Creature: Fix gold value for TBC raid bosses
Closes #19262

(cherry picked from commit 8ed3efd820d6a3dc63bafa59f2f6352774784648)
2022-01-26 20:36:01 +01:00
Gildor 27c70ca728 Scripts/Naxxramas: Adjust Frogger event timer (#25214)
* Scripts/Naxxramas: Adjust Frogger event timer

Co-authored-by: Carbenium <[email protected]>
(cherry picked from commit 7035a9caf12c72d6710bfec71dc2641eccf82eaf)
2022-01-26 19:51:48 +01:00
Rothend 6f10847512 Script/Quest: fix (More) Torch Catching (#24907)
* Script/Quest: fix (More) Torch Catching.

Closes #24893

Co-authored-by: Carbenium <[email protected]>
(cherry picked from commit a375f15ae26472202daf02c88d292f2ce6a1470f)
2022-01-26 19:50:50 +01:00
Treeston 319ddd9bcd Core/Warden: Warden refactors (PR #25235)
(cherry picked from commit 6116e5b38522ccfb00f6c941c75482e05b4c0799)
2022-01-26 19:42:11 +01:00
offl cf369301c4 DB/Locale: Add missing esMX quest locales
Copied from already added esES locales since they're almost always similar

(cherry picked from commit cce1ccdd5cb59070a48562504a0d4d476fd9aad2)
2022-01-26 19:27:08 +01:00
Cerveciento ac6e50f90e DB/Locale/esES+esMX Texts missing in quests (Part 15)
Closes #25234

(cherry picked from commit ca9ce8a70bfa565576436f73fdc2b564e7c8d083)
2022-01-26 19:26:37 +01:00
dr-j a7f4e50097 DB/Creature: Sindragosa's Fall Wyrm Reanimator/Frost Brood Spawn events
Closes #25231

(cherry picked from commit be8affa5be04fb5cc2dc00919f208908345ea220)
2022-01-26 19:26:09 +01:00
Cerveciento 70342659e5 DB/Locale/esES+esMX Texts missing in quests (Part 14)
Closes #25228

(cherry picked from commit b8f21d4540425137704f05a0acdd8f8773d168eb)
2022-01-26 19:24:46 +01:00
offl 7afcd3f4a2 DB/SAI: Rework support for corrupted & cleansed plants from Felwood
Closes #4960

(cherry picked from commit 2ff51396c008a7eeffa6ed596e84b2f3cd616b1d)
2022-01-26 19:24:12 +01:00
Giacomo Pozzoni e11e1938b5 Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure) (#25226)
* Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure)

* Core/SAI: Retry casting after 500ms if a cast failed

Fixes #24914

(cherry picked from commit 63a6e1e0480df659e773a3df5e1acc2027ebcf15)
2022-01-26 19:21:10 +01:00
jackpoz 26894508ef Core/Misc: Code cleanup
(cherry picked from commit dd28cecda36ed3912be39d0c3caefef910db707d)
2022-01-26 19:18:46 +01:00
offl 92f17bf40f DB/Texts: Add correct BroadcastTextId and comments to some creature texts
(cherry picked from commit 39f2d2d1cf4d79ec9f34f92ac999332d10b04e90)
2022-01-26 19:18:32 +01:00
offl 6fbef47eff DB/Texts: Add correct BroadcastTextId and comments to some creature texts, reoder some texts and add missing
(cherry picked from commit cf57ea2045af37f044a31be34ded8851bd670cea)
2022-01-26 19:17:53 +01:00
jackpoz b3f0d92b81 Scripts/Command: Fix .mmap loc always printing command usage
(cherry picked from commit 0eb49a3cc91a11ca98cce819dd189f1519684c5f)
2022-01-26 19:16:55 +01:00
offl 2350c20385 DB/Texts: Add BroadcastTextId to one of Molthor's texts & remove useless locales
(cherry picked from commit 08dd9ebf780e6133a4d3a0421aba00a0e43892d0)
2022-01-26 19:16:32 +01:00
Cerveciento c4e2ae4603 DB/Locale/esES Texts missing in quests (Part 13)
Closes #25225

(cherry picked from commit 769d47c61717851b5eb4d4a58dd99b5ff3854f8b)
2022-01-26 19:15:55 +01:00
jackpoz d8cdbac670 Core/Warden: Fix Warden reporting false positive checks
Issue introduced in 210176fd915cf4ba16f428d3c1a249a71f4aa7a7

(cherry picked from commit c04f53b886ec27dd8cf100524fe93a71dc4e1aa1)
2022-01-26 19:15:22 +01:00
Cerveciento 00a6f6f705 DB/Locale/esES Texts missing in quests (Part 12)
Closes #25221

(cherry picked from commit b0734f81bd2ca81e833e7119679e4938dd040d11)
2022-01-26 18:58:55 +01:00
offl 1503c84d3a DB/SAI: Remove useless param inside SMART_ACTION_CALL_TIMED_ACTIONLIST for gameobject scripts
(cherry picked from commit 6ca6a540831a29ded8bd569e395ccdff0ab3e336)
2022-01-26 18:58:29 +01:00
offl f16608d986 DB/SAI: Change orientation to home position instead of calling evade to restore orientation
(cherry picked from commit a4ab8116c3f6ddc3b9d318ab95d548ab15994104)
2022-01-26 18:57:57 +01:00
offl bb64f441f7 DB/Creature: Change respawn time of Lordaeron Footsoldier to correct
(cherry picked from commit 6779a92cbae06d515097817890c7b35af15ffadf)
2022-01-26 18:57:24 +01:00
Jinnaix 169b0296e1 Scripts/BlackwingLair: Suppression Device Room (PR #25199)
Co-authored-by: offl <[email protected]>
Co-authored-by: Giacomo Pozzoni <[email protected]>
Co-authored-by: Treeston <[email protected]>
(cherry picked from commit de56ed87368104780ddfb2e9c082076c9c83d575)
2022-01-26 18:51:07 +01:00
jackpoz 35755ba343 Core/Misc: Fix Windows 32 bits build
Close #25789

(cherry picked from commit 1cafd4ef74350cb3656917e8e033a5e21dcce193)
2022-01-26 18:48:08 +01:00
Shauren fbcf269207 Core/CrashHandler: Skip logging stack trace of the thread writing the crash log, it was launched by windows with same context as crashing thread
(cherry picked from commit dd34651f4d42ca598b2f1b2ed32e27b4742f4be7)
2022-01-26 18:47:44 +01:00
Shauren cc0affa523 Core/CrashHandler: Remove logging function variation depending on crash reason and print directly to file, not to temporary buffer
(cherry picked from commit c5e1b49e8c02386a0e9edf682692dc6d46cc862f)
2022-01-26 18:47:16 +01:00
Shauren 259bbf1e04 Core/CrashHandler: NULL -> nullptr
(cherry picked from commit 68fdfcaa507d06ce8e823e7848f4c58ef1e62732)
2022-01-26 18:46:56 +01:00
Shauren 473f3db0ab Core/CrashHandler: #ifdef cleanup to make VS not choke when parsing, fixed file being all red in editor
(cherry picked from commit 39c5e03b749d44df346b8f37aed3eb898526365a)
2022-01-26 18:46:43 +01:00
Shauren 7893ac94a0 Core/CrashHandler: Attempt to extract C++ exception object in uncaught exception hander
(cherry picked from commit 83ed35fe62c16f5697f253a9a44bba7dcb83e80d)
2022-01-26 18:43:31 +01:00
Ovah 2819951dce Core/Units: add new functionality for units to block or enable combat interactions (#25168)
* Core/Units: add new functionality for units to block or enable combat entirely via helper to reflect what CREATURE_DIFFICULTYFLAGS_IGNORE_COMBAT and client AI functions imply

* yeah...

* Nuke Creature::IsCombatDisallowed helper as its unused by now

* no combat extra flag may now be changed on transforms if the transformed entry does not have the flag

(cherry picked from commit 764f22fc9157ad184baa38995ee4e2d821299935)
2022-01-26 18:41:41 +01:00
Carbenium d6c998a1a8 Core/Updater: Fix detection of the mysql binary when a directory is given as path
This ensures that we never pass a directory path StartProcess which results in a crash.

Closes #25216

(cherry picked from commit 98b1b20d6beea5e2fdea7e404e8d880953d4b2fb)
2022-01-26 18:41:14 +01:00
dr-j cd392970e3 DB/Quest: Add outro event for 'Guided by Honor' (11289)
Closes #16855

(cherry picked from commit 23886881b4c527d1b4b5a3de4f95855a62142edf)
2022-01-26 18:40:33 +01:00
illfated 59e920d624 DB/Texts: Fix CompletionText for quest 'Proof of Deed'
Closes #25218

(cherry picked from commit a677c6c55d75db12a8c0c8622039a3dad5a9c9a9)
2022-01-26 18:39:51 +01:00