Commit Graph
34699 Commits
Author SHA1 Message Date
Keader eb3a93b93f DB/Spells: Fixed Alchemy stones procs with potions like endless mana potion
(cherry picked from commit 19cb62c0bf442bd402428a8cb775225896cd5c06)
2021-08-08 21:21:34 +02:00
Killyana fba5a22aa8 DB/Creature: assign SmartAI to Apothecary Keever's test subjects + typo fix
- missing row number in one of the DELETE FROM queries in commit 20a0d27b5bcbc2c3a334edef37f6a05e653ca401

Closes #21488

(cherry picked from commit 4c791ec376fdf5c7717a6249604502ec15656902)
2021-08-08 21:21:34 +02:00
ZenoX92 37f0927deb DB/Creature: Deathguard Elite & Stormwind City Guard use Crossbow on ranged attack
- also add some missing emote responses to Stormwind City Guard

Closes #21470

(cherry picked from commit 20a0d27b5bcbc2c3a334edef37f6a05e653ca401)
2021-08-08 21:21:34 +02:00
ariel- ffa359c21c Core/Auras: check conditions against referer caster, just as spells do
Closes #21492

(cherry picked from commit 83292cd983474753393017c4f7ac3ba509fc4c83)
2021-08-08 21:21:34 +02:00
Treeston 32997a5989 Core/SmartScripts: Rename SMART_ACTION_RESPAWN_TARGET -> SMART_ACTION_ENABLE_TEMP_GOBJ, since that's the only thing it still does in the dynspawn model. Adjust body accordingly to warn on misuse.
(cherry picked from commit 0850b5ff39b187d8a1adb032dfd7900d4474cfaf)
2021-08-08 21:21:34 +02:00
Treeston 65b8dafb53 Core/GameObject: Force compatibility mode for stupid ridiculous junk legacy hack gameobjects, ref 27e7906.
(cherry picked from commit 9f92896c52dfdaaad3a7eb66a780a7415dc12546)
2021-08-08 21:21:34 +02:00
Treeston de3eb7b298 Core/GameObject: fix stupid ridiculous junk legacy hack code with negative gobj respawn time to work again
(cherry picked from commit 27e7906814f2696863f5ab0488c59ffa347d8cc9)
2021-08-08 21:21:34 +02:00
ariel- 181c671924 Core/Scripts: remove hack that caused aura to not be applied and saved twice on owned auras, causing an error on save
- This is handled by group stack rules actually
- Also reset removed aura counter when cleaning removed auras

Closes #21486

(cherry picked from commit 1074a9b053c7d1fbff1321bf95b15d7be1ee669f)
2021-08-08 21:21:34 +02:00
Treeston 61baf6704c AI/SmartAI: New SMART_ACTION_RESPAWN_BY_SPAWNID (hi kilyana)
(cherry picked from commit 691c67f0be09095a34421043baf245fdf28e5d04)
2021-08-08 21:21:34 +02:00
Treeston 5c80f50734 Core/Spawning: Actually check spawn group state before processing a respawn. It feels like that is something that should've been noticed at some point.
Also remove CreatureScript::CanSpawn since nobody uses it, and spawn groups do the same thing.

(cherry picked from commit 94b5d9bfa1195ad7c32cf51a665b55514dac0938)
2021-08-08 21:21:34 +02:00
ariel- 5e7a11f88d Core/Scripts: apply resilience on Vampiric Touch and Unstable Affliction dispel effect
- Spell with SPELL_ATTR4_FIXED_DAMAGE won't do it by itself to avoid applying resilience twice, but because those are triggered from a periodic aura, those apply resilience on tick, not saved to amount.
- This is one of the cases where you have to call Unit::SpellDamageBonusTaken directly

Closes #21393

(cherry picked from commit 3753ec56476d597b180968eb673cb20776785f31)
2021-08-08 21:21:34 +02:00
ariel- 8e7a12a87a Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load
Closes #21472

(cherry picked from commit 7cff1b540c96d9e2cf82b244cc0d1618bf5b090f)
2021-08-08 21:21:34 +02:00
ariel- b1a76fc756 Core/Unit: clear charmed/possessed state before returning client control. Works like a charm
Closes #21471

(cherry picked from commit fc678bb3c21d6c5a87a840c7bbf596eaea1cffc3)
2021-08-08 21:21:34 +02:00
Treeston 8418017188 DB/SpawnGroup: Reserve group IDs 52 through 56 for Culling of Stratholme rewrite
(cherry picked from commit b197529f1e89dbde283d22b0eb53cc83bd1f353a)
2021-08-08 21:21:34 +02:00
ariel- 489b111a8a Core/Vehicles: fix crash
- Aura could be removed in Unit::SetCharmedBy (StopMoving->Relocate->ProcessTerrainStatusUpdate->RemoveAurasWithInterruptFlags)
- By not passing AuraApplication parameter execution continued with a removed application leaving vehicle in a invalid state (m_sharedVision not empty)

Closes #18281

(cherry picked from commit eb7d22d23eedb0d1b5374f80518cd7994d7c7b3a)
2021-08-08 21:21:34 +02:00
ariel- 70c26d53cb Core/Entities: unit states cleanup
- Added new UNIT_STATE_FOCUSING for creature focus system, this will stop creatures adding/clearing the UNIT_STATE_CANNOT_TURN mask (eg UNIT_STATE_STUNNED if stunned while focusing a spell)
- Added UNIT_STATE_CHARMED that gets set/removed on any charm type (UNIT_STATE_POSSESSED is only for possess as it's name suggests)
- The new states are checked against mask to know whenever client needs to regain character control

Closes and fixes #21460

(cherry picked from commit ba27711145d1b015578aedb48ea8532b4f0bec75)
2021-08-08 21:21:34 +02:00
Teppic 47e41be515 DB/Loot: Reference template 24048 & 24050 corrections
Closes #21457

(cherry picked from commit 1cc3d33cfe7e51d66925d5df536a952165a88094)
2021-08-08 21:21:34 +02:00
Wilcalaf e3941e4199 Scripts/Nexus: Fixed a rare bug when sometimes Magus telestra managed to die while invisible preventing players from looting. (#21436)
(cherry picked from commit 2dd5735bd9c4212e0009c9d4db0da34cc1541862)
2021-08-08 21:21:34 +02:00
jackpoz 89a232de3a Core/Misc: Add PERFORMANCE_PROFILING CMake option
Add a new CMake option called PERFORMANCE_PROFILING that should be used only when profiling the performance.
This option is unsupported, do not report any issue happening when enabling this option.

(cherry picked from commit db5c9867e2ffde3657f53bc155b474c5d46884dd)
2021-08-08 21:21:34 +02:00
jackpoz b7aef385e8 Core/Misc: ASSERT() cleanup
Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect.

(cherry picked from commit 572eab1c355d9298ee640ebd7439f55366224fb8)
2021-08-08 21:21:34 +02:00
Killyana cb0a889177 DB/SAI: Fix text target related to Sasha quests
(cherry picked from commit 76b57eeba837130a44e31c9eac8225d96a7b5809)
2021-08-08 21:21:34 +02:00
sirikfoll 74101eaf7c Scripts/Icecrown Citadel: Prevent Lady Deathwhisper movement during first phase.
(cherry picked from commit 076bd11002c0fe7ed893497e582a40b7f46320e6)
2021-08-08 21:21:34 +02:00
Killyana 642807a83a DB/SAI: Fix text target related to The Amphitheater of Anguish quests
(cherry picked from commit 645627e652a63614edd9c9b6ff465ee472972631)
2021-08-08 21:21:34 +02:00
Killyana 0570d86699 DB/SAI: Fix text target related to The Ring of Blood quests
(cherry picked from commit fdadecc806fe907d166a34b7996b849a0d4921fe)
2021-08-08 21:21:34 +02:00
Killyana 1c1c5868eb DB/SAI: Fix text target related to Battle at Valhalas quests
(cherry picked from commit ec9bf9afe7d6bd732947cf207b24aef14d3b36a1)
2021-08-08 21:21:34 +02:00
ariel- 64399f58a3 Core/Auras: fixed Drain Mana breaking early if caster has Mana Feed talent but no active pet
(cherry picked from commit 1ac87b6c6024b06c361d550795d041ea4b7e5a6c)
2021-08-08 21:21:34 +02:00
Teppic1 9252fe89fe DB/Loot: Reference template 24066 corrections
Closes #21409

(cherry picked from commit b71b3c66724e18fe8a19e01cae2582678a459dc1)
2021-08-08 21:21:34 +02:00
Teppic1 463ffb69c4 DB/Loot: Reference template 24068 corrections
Closes #21416

(cherry picked from commit d38031715d3f9494bbc07f45f768f2151c9d9cf0)
2021-08-08 21:21:34 +02:00
Cannix 64234b35ed Core/Spells: Execute item casts immediately instead (#21396)
(cherry picked from commit 7e71b4535a0e927ecdee30489e5a3c0b6f247559)
2021-08-08 21:21:34 +02:00
Wyreth 8713a62328 Core/Entities: remove grid-wide visibility from setActive and implement another method for it (#20725)
(cherry picked from commit 56874b44f0625f80442ea906f487e3253bdd16eb)
2021-08-08 21:21:34 +02:00
jackpoz efce8ca379 Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity

(cherry picked from commit d3d0640a8d61e9a216876b7f1b114673893b2bc8)
2021-08-08 21:21:34 +02:00
Jeremy 69edf282fa Partial: Core/Entities: Reduce the probability of units dropping under the map (#21322)
Reduce the probabilty of going under the map

(cherry picked from commit 9e0faace9a5114fc2324c2c601ba943272e0d6ff)

Revert "Core/Entities: Reduce the probability of units dropping under the map (#21322)"

(cherry picked from commit 2dadbda24ac1c2e6ff3dad650c7e25f4b3322342)
2021-08-08 21:21:34 +02:00
Shauren fcead0b4ea Core/Spells: Use caster as chat source in Spell::EffectSendChatMessage 2021-08-08 18:15:00 +02:00
Jeremy 58be6007fb Core/Battlegrounds: Remove duplicate info from GroupQueueInfo (#26759)
- BgTypeId
- ArenaType
- IsRated

Those are fields that are already present in the field m_queueId
2021-08-08 18:06:29 +02:00
Shauren 193233286d Core/Misc: ASSERT() cleanup - followup of cherry pick 572eab1c355d9298ee640ebd7439f55366224fb8 2021-08-08 15:22:55 +02:00
Shauren 9067eb22ce Core/Units: Fixed crash in Unit::CalcArmorReducedDamage when called from periodic aura tick if caster is no longer in world
Closes #26776
2021-08-08 13:03:57 +02:00
Shauren 6c005fadfa Core: Updated allowed build to 9.1.0.39653 2021-08-08 00:18:10 +02:00
Shauren 262ee285db Core/Misc: Updated SpellCastResult, GameError and HotfixStatus enums 2021-08-08 00:18:10 +02:00
Shauren ce1046a8fd Core/DataStores: 9.1.0 db2 structures 2021-08-08 00:18:10 +02:00
Shauren cd5357dc18 Core/PacketIO: 9.1.0 opcodes and packet structures 2021-08-08 00:18:05 +02:00
Shauren 07f51437fc Core/Auras: Fix incorrect use of GetUnitOwner() in DynObjAura::FillTargetMap
Closes #26735
2021-07-22 10:38:23 +02:00
Shauren 515d3da181 Core/Auras: Skip estimated points calculation for SPELL_EFFECT_PERSISTENT_AREA_AURA
Closes #26731
2021-07-21 16:19:14 +02:00
offl 3aaab1f878 CI/GitHub: Update basic guideline in issue form for SQL fixes 2021-07-05 16:45:29 +03:00
TDB Release 6b8bb270a8 TDB 905.21071 - 2021/07/04 2021-07-04 22:30:16 +00:00
jackpoz c9a97ea895 CI/CircleCI: Fix typo 2021-07-04 11:52:54 +02:00
jackpoz 91153e8b64 CI/CircleCI: Try to avoid timeout when checking sql updates 2021-07-04 11:48:23 +02:00
jackpoz 0f26daafbf GitHub: Update link to create new issues 2021-07-04 11:43:02 +02:00
jackpoz ed43294e2d GitHub: Restore old issue template as backup/fallback 2021-07-04 11:40:35 +02:00
Giacomo Pozzoni 142306e883 CI/GitHub: Add issue form for SQL fixes (#26651) 2021-07-03 22:13:14 +02:00
Giacomo Pozzoni 24636e5627 CI/GitHub: Use issue form and add contact links (#26639) 2021-06-30 18:58:57 +02:00