Machiavelli
3d58165dbd
Core/Items: Proper money refund fix for 0ad2c90d22. Thanks to Destalker
2011-01-25 13:36:40 +01:00
Machiavelli
17971acddb
Core/Players: Implement generic SendClearFocus instead of magic SMSG_BREAK_PACKET randomly in the middle of code. Also preallocate correct size for packed guid.
2011-01-25 08:04:47 +01:00
Machiavelli
0ad2c90d22
Core/Items: Fix money refund amount. Also fix a possible exploit possibility of redeeming both vendor sellprice and money refund price in one go.
2011-01-24 23:10:08 +01:00
Machiavelli
0796889c21
Core/Vehicles: Hotfix for client freeze on vehicle enter by reverting certain changes to SMSG_MONSTER_MOVE_TRANSPORT. Still have to figure out the correct structure in the future.
2011-01-22 19:55:50 +01:00
Machiavelli
920b3b0b37
Core/SQL: Add unique table key for (guid, bag, slot) in character_inventory to prevent storing different item entities in the same slot.
...
NOTE: If you get import errors it's YOUR OWN RESPONSIBILITY to fix current data inconsistencies your database might have.
2011-01-22 19:05:23 +01:00
Machiavelli
7f3375b8f9
Core/DBLayer: Fix another possible crash on shutdown. This should be the last of them caused by this area of the core.
2011-01-16 13:33:47 +01:00
Machiavelli
deed0d0781
Core/General: Fix some comment style. //* to // *. Fixes certain code display errors on nano. Thanks to Aokromes for pointing out.
2011-01-16 12:23:17 +01:00
Machiavelli
542a89b150
Scripts/Sholazar Basin: Fix logic in npc_jungle_punch_target. Allows quest credit from NPC_TAMARA
2011-01-16 00:54:13 +01:00
Machiavelli
09f2a48227
Core/Spells: Add unittarget check for spell 54798
2011-01-16 00:50:57 +01:00
Machiavelli
52cd2cbd7e
Core/Maps: Unload transports in MapManager::UnloadAll instead of singleton destructor.
...
Core/Transports: Properly delink units from transports on transport desutruction. - Thanks to Shauren for help.
Core/ObjectAccessor: Unload corpse 'storage' in added UnloadAll method called in WorldRunnable postservice hook.
Core/Master: Change some postservice queries to syncrhonous (direct) execution to ensure execution on shutdown
Core/Master: Remove redundant calls to ACE::init and ACE::fini
These changes were made to fix crash/freeze issues on shutdown.
2011-01-16 00:08:52 +01:00
Machiavelli
29a8b5407a
Core/DBLayer: Use default parameters for DatabaseWorker::activate. Fixes a possible desyncrhonisation issue when DatabaseWorkerPool calls wait() on the workers.
2011-01-15 20:59:37 +01:00
Machiavelli
38816cb1df
Core/Spells: Implement SPELL_ATTR6_IGNORE_CROWD_CONTROL_TARGETS (0x00000100). Spells with this attribute flag (Avenger's Shield, Hammer of Righteousness, Shield of Righteousness, Felguard Cleave, Fel Iron Bomb) will ignore secondary targets that are under the effect of crowd control aura's.
...
Thanks to Shauren for advices.
2011-01-15 19:40:06 +01:00
Machiavelli
de8d5a9236
Scripts/Borean Tundra: Add Support for areatrigger conditions for Quest: Breaking Through (11898). Thanks to Svannon for original code and joint brainstorming session.
...
Closes issue #194
2011-01-14 00:59:52 +01:00
Machiavelli
d399daab59
Core/Quests: Resolve ambiguity between QUEST_STATUS_COMPLETED and rewarded state by implementing QUEST_STATUS_REWARDED. The latter is not used in the database explicitly, only in the core. This is to prevent overhead by iterating over the rewarded quests storage multiple times.
...
All relevant upper level code has been updated accordingly to the best of my ability.
2011-01-13 23:06:59 +01:00
Machiavelli
57ee357c02
Core/Maps: Fix a possible crash in ObjectGridStoper:Visit
...
Dump found here: http://pastebin.com/2GZ3t5v4
2011-01-13 21:33:56 +01:00
Machiavelli
bd85914d92
Core/DBLayer: Properly manage mysql library initialization and shutdown in authserver and worldserver. Prevent multiple calls and make it more elegant.
2011-01-13 21:30:37 +01:00
Machiavelli
4c15ebe09d
Core/DBLayer: Properly deallocate SQLOperation objects from Databaseworkerpool queue.
2011-01-13 20:28:40 +01:00
Machiavelli
cf9250c29f
Core/DBLayer:
...
- Implement DatabaseWorkerPool::DirectCommitTransaction for synchronous transaction execution (as opposed to asynchronous/enqueued).
- Add MySQL errno 1213 "Deadlock found when trying to get lock; try restarting transaction" handler. If 1213 is called the core will retry to directly execute the transaction a maximum of 5 times.
2011-01-13 20:07:09 +01:00
Machiavelli
52499b03ea
Core/Guilds: Don't allow more than 25 and 100 log events to be sent to the client for bank eventlog and regular eventlog respectively. Higher values will result in client crashes.
2011-01-12 19:38:47 +01:00
Machiavelli
fa8e5047a6
Core/Guilds: Fix a possible client crash in MSG_GUILD_BANK_LOG_QUERY
2011-01-10 20:57:58 +01:00
Machiavelli
01d4080b4d
Core/Units: Send proper orientation in SMSG_MONSTER_MOVE_TRANSPORT
...
Also get rid of the 100 constant in moveticks segment and use getMSTime() for consistency sake
2011-01-09 16:22:04 +01:00
Machiavelli
4ec6ec66c4
Core/SQL: Fix world_scripts_full.sql import
2011-01-09 13:43:35 +01:00
Machiavelli
cb5a943f10
Core/DBLayer: CHAR_DEL_AUCTION should be defined as asynchronous. Fixes a crash caused by assertion failure.
...
("Could not fetch prepared statement 54 on database `characters`, connection type: asynchronous.")
2011-01-09 13:30:14 +01:00
Machiavelli
57173df80f
Core/SQL: Move spell_script_names from world_database.sql to world_scripts_full.sql (they're called scripts for a reason)
2011-01-08 22:49:44 +01:00
Machiavelli
a5cabb0705
Scripts/Ulduar: Some work on Kologarn:
...
- Get rid of UNIT_FLAG_STUNNED hack
- Use proper spells instead of vehicle hacks
- AI scripts for both arms instead of everything being defined in Kologarn's AI script
- Proper support for detecting when to release players (Right Arm)
Still todo:
- Eyebeams
- Rubbles
- Achievements
- Post-encounter doors/GO's toggling
2011-01-08 22:21:24 +01:00
Machiavelli
58f795d171
Core/Vehicles: Logic fix for AddPassenger seat validity check, thanks to Tassader
2011-01-08 21:13:18 +01:00
Machiavelli
aa87c61cfb
Remove unintended change from previous rev's copypaste work.
2011-01-08 19:11:18 +01:00
Machiavelli
c4cac049b4
Core/DBLayer: Define prepared statements in an array per database instead of explicit calls to MySQL::PrepareStatement. Now the core will show the raw query (without bound arguments) in related log entries instead of PreparedStatement id: X on database Y.
2011-01-08 19:07:13 +01:00
Machiavelli
dc3d6a2f23
Remove redundant code from 1487ebedaa
2011-01-07 19:13:19 +01:00
Machiavelli
efe0ed3194
Core/Entities: Fix a silly typo in Object::AddExtraMovementFlag
2011-01-06 22:54:33 +01:00
Machiavelli
c65e3822a2
Fix build from 06314c9387
...
closes #99
2011-01-06 22:45:07 +01:00
Machiavelli
afcff32e64
Core/DBLayer: Add MySQL errno 1054 to ignored error messages.
2011-01-06 22:32:30 +01:00
Machiavelli
7ac9ffd587
Scripts/Naxxramas: Patchwerk's hateful strike can, however, hit the main tank if no other targets are in melee range.
...
Thanks to Tassader for pointing out
2011-01-06 22:24:32 +01:00
Machiavelli
f832990678
Scripts/Molten Core: Remove a redundant health-check in majordomo executus script.
...
Thanks to Lopin for pointing out.
2011-01-06 20:59:58 +01:00
Machiavelli
26c91be2d3
Core/Quests: Better way to fix the problem affected in previous commit
...
closes #36
2011-01-06 17:33:40 +01:00
Machiavelli
c617f1f85c
Core/Quests: Fix certain issues with repeatable quests.
...
closes #36
Signed-off-by: Machiavelli <[email protected] >
2011-01-06 16:49:04 +01:00
Machiavelli
eac259f75f
Core/Units: Call Unit::InterruptNonMeleeSpells before RemoveFromWorld to make GetCaster() return a valid pointer on AuraEffect unapply methods.
...
Fixes a crash in VisitorHelper related to Mind Vision.
closes #43
2011-01-04 23:43:20 +01:00
Machiavelli
09a0860717
Core/Pets: Fix crash added in a3feae6b6f
2011-01-04 19:30:51 +01:00
Machiavelli
9f4881310f
Core/Vehicles: Fix a crash in EjectPassenger
...
Closes #20
2011-01-03 17:02:26 +01:00
Machiavelli
ce76f10bc8
Core/Vehicles: Fix a typo in AddPassenger.
...
Thanks to cyberbrest
2011-01-01 23:20:08 +01:00
Machiavelli
957c69de83
Update copyright note for 2011.
...
Happy new year.
2011-01-01 15:01:13 +01:00
Machiavelli
8ab453b465
Missing changes from 72a115f242
2010-12-31 18:24:35 +01:00
Machiavelli
72a115f242
Core/Vehicles: Store guids in vehicleseat structures instead of pointers. Fixes a crash with vendor-carrying Mammoth mounts.
2010-12-31 17:23:51 +01:00
Machiavelli
4b0341c167
Core/Vehicles: Add an assert to trace down crash in Vehicle::RelocatePassengers
2010-12-31 01:40:31 +01:00
Machiavelli
9c7c62cc5e
Core/Vehicles: Send transport X,Y,Z offsets as floats instead of uint32, fixes a possible client crash.
...
Thanks to j4r0d
2010-12-30 23:40:20 +01:00
Machiavelli
11cc3eac7a
Core/Vehicles: Implement VEHICLE_SEAT_FLAG_B_CANSWITCH restriction, and do some cleanup.
2010-12-30 19:57:50 +01:00
Machiavelli
fe8c893273
Merge branch 'master' of github.com:TrinityCore/TrinityCore
2010-12-30 19:11:36 +01:00
Machiavelli
948a2136c4
Core/Vehicles: - Redefine VEHICLE_SEAT_FLAG_USABLE as VEHICLE_SEAT_FLAG_CAN_ENTER_OR_EXIT. This flag determines whether or not the player has control over entering/exiting a vehicleseat. Thanks to linencloth for help with research.
...
- Implement VEHICLE_SEAT_FLAG_CAN_ENTER_OR_EXIT exit restriction
- Remove MOVEMENTFLAG_ROOT on vehicle exit
2010-12-30 19:10:46 +01:00
Machiavelli
71e959837b
Core/Vehicles: - Prevent client ejecting passengers from non-ejectable seats.
...
- Chart some more VehicleSeatFlags and VehicleSeatFlagsB. Research by linencloth
2010-12-30 17:59:55 +01:00
Machiavelli
8c8f4a828b
Core/Vehicles: - Prevent client ejecting passengers from non-ejectable seats.
...
- Chart some more VehicleSeatFlags and VehicleSeatFlagsB. Research by linencloth
2010-12-30 17:33:51 +01:00
Machiavelli
92460b4aab
DVCS: Add .mailmap to gitignore too
2010-12-29 12:56:53 +01:00
Machiavelli
6f00a22a12
Core/DVCS: Add .bak extension to .gitignore (used to backup files in UltraEdit)
2010-12-29 12:13:54 +01:00
Machiavelli
6b12ec1f3e
Fix build from 68c6189201
2010-12-29 12:09:57 +01:00
Machiavelli
e26294db56
Scripts: Correct function registration of spell_dru_moonkin_form_passive_AuraScript, fix intendation in world_database.sql
...
Author: QAston
2010-12-29 11:58:09 +01:00
Machiavelli
68c6189201
Core/Vehicles:
...
- Set MovementFlagsExtra (2) correctly depending on vehicle 'template' flags. This makes certain vehicles such as demolishers unable to jump/strafe (as intended)
- Fix SMSG_MONSTER_MOVE_TRANSPORT stucture, prevents a client crash when entering certain vehicles, as well as *properly* broadcast position relative to the vehicle.
- Send SMSG_BREAK_TARGET to player when entering vehicle.
- Set MOVEMENTFLAG_ROOT on passenger when entering vehicle
- Cleanup in affected code
2010-12-29 05:45:38 +01:00