* Docker/Readme: codestyle cleanup
Changes proposed:
- Simplify MD back tick usage in stand-alone horizontal strings.
- Sentence grammar improvements/adjustments (might->may etc.)
- Punctuation: Add a period dot at the end of proper sentences.
- Punctuation: Add Oxford commas for natural readability.
- Punctuation: Add colon at the end of sentence introducing command examples.
- Reduce indentation level for bullet point annotation from second level to first level.
- Spell Linux with a capital L (proper noun, from "Linus + UNIX").
- UNIX is a proper noun with all its letters in uppercase.
- Remove a stray double quote character from the start of a command.
- Replace HTML entity . with its ASCII representation, a period dot.
Whitespace changes:
- add editorial blank line below H1 (page title) and H2 headings
- add editorial blank line below MD code block fences (codestyle)
* Lowercase 'pch' job name
- "PCH" -> pch
* Revert HTML entity change in README dot md
- Revert README.md to its original `README.md` spelling to avoid coding issues.
* Update contrib/Docker/README.md
Co-authored-by: Trond B. Krokli <[email protected]>
Co-authored-by: Giacomo Pozzoni <[email protected]>
(cherry picked from commit 3a61fe3c31b3fc61d3b881196319ccd96d69c7e4)
* Scripts/Quest: Force of Neltharaku quest credit
**Description:**
Suggested solution to resolve the kill credit double cast issue
in the quest "The Force of Neltharaku" (10854).
by Rushor
**Changes proposed:**
- Remove duplicate spell casts in the zone quest script
- Remove commented-out script section
- Set a couple of unit flags (anim/stand/hover)
- Move return new creature script override to end of script
- Move PlayerGUID, FlyTimer, and Tapped to Private
- Add DB flight movement control to Enslaved Netherwing Drake
- Add SpellMgr MaxAffectedTargets = 1 for spell 38762
- Add movement enum POINT_MOVE_UP
- Add missing enum for quest ID
**Target branch(es):** 3.3.5/master
- [X] 3.3.5
- [X] master
**Issues addressed:** Closes#24796
**Tests performed:** (Does it build, tested in-game, etc.)
Pending for now.
**Known issues and TODO list:** (add/remove lines as needed)
- [X] Open PR in draft mode until testing is cleared
- [ ] Compile and create local server
- [ ] Test changes on local server
* Rename 9999_99_99_99_world.sql to 2020_07_29_00_world.sql
Co-authored-by: Rushor <[email protected]>
Co-authored-by: Giacomo Pozzoni <[email protected]>
(cherry picked from commit e0dae8feb6607b5190d14b56ecfc10bbfa667c95)
- Typo and spelling corrections
- Grammar corrections, English grammar
- Minor adjustments in example code readability
- Capitalization adjustments to keep consistency
with existing idioms, phrases and concepts
(cherry picked from commit f9b1e4a03259c39af0d24e63f877455944b8af2e)
* Scripts/Wailing Caverns: make Disciple of Naralex say Mutanus the Devourer
Disciple of Naralex should say
"This Mutanus the Devourer is a minion from Naralex's nightmare no doubt!"
instead of using $n caused by a missing target in the Talk() script command.
(cherry picked from commit a040d484437b2f12ce88dc4372bfacc18204c8fc)
- remove hardcoded text (deprecated method)
- add already existing DB gossip content to enum
- correct spell enum from spell_creature_ to spell_create_
- replace case switch with if statement (only one boolean case)
Extra script file update:
- remove SD comment line 22 (outdated info, replaced by SAI)
(cherry picked from commit 7cb31aa4820d02fa5779483bec9455a00954902c)
- split the quest status check, the quest gossips are different
- remove old hardcoded text (deprecated method)
- enumerate already existing DB gossip menu option items
(cherry picked from commit a8558c4361a7e3560c094886ef3072d46c64de44)
Quest 12288: Overwhelmed!
- Upon casting the healing quest spell, Wounded Skirmisher (npc_wounded_skirmisher)
shows $r and $c in their reply talk text because of the missing target argument,
hence not targeting the player on the quest (or the specific caster, in this case).
Text used by the NPC Wounded Skirmisher:
0 Ahh.... better.
1 Whoa - I nearly died there. Thank you, $r!
2 Thank you, $c.
Solution: add the missing target name, caster, to the Talk() script line.
(cherry picked from commit 95398fadf958d40ba6755a6c2f7b374f0a36b7c7)
High Justice Grimstone's movement script timers improvement in Ring of the Law.
case 6 & case 7 modifications:
- Event_Timer = 5000; // originally 0
Closes#20499 (High Justice Grimstone issue)
(cherry picked from commit 48eba61e90e3958613ceca05bb6a550fce8816ad)
* Atal'Alarion will now despawn as a regular Elite mob
(5 minutes unlooted or 2.5 minutes when fully looted)
instead of 7200 (ms) (7.2 seconds) before this change.
Closes#22531
(cherry picked from commit d24b46139600c74f5e200d9ab1592d7128245113)
Apply general writing codestyle for GitHub Pull Requests:
- move the "Closes #" text down to its own line, as GitHub prefers to read the git command without preceding text.
- move the text "(Does it build, tested in-game, etc.)" down to a new line to indicate where we want the info inserted.
Trond B. Krokli