Commit Graph
36664 Commits
Author SHA1 Message Date
Treeston d5e58cef69 Core/Spawns: Exterminate CONFIG_SAVE_RESPAWN_TIME_IMMEDIATELY with extreme prejudice. (It didn't work anyway.)
(cherry picked from commit 26440857c1a74031ea0a0234ca0b0fcb09b6bcb0)
2021-12-16 01:18:15 +01:00
Treeston be05590a12 Core/DB: Unify creature_respawn and gameobject_respawn into a single respawn table
(cherry picked from commit 374597c8e96c886f1e3647d405bf3160c8b98bf8)
2021-12-16 01:10:06 +01:00
Shauren 58fb2ef631 Core/DB: Improved terrible assertion message
(cherry picked from commit eed92676858c9c10b1bd570894d562b21e72a905)
2021-12-16 00:54:53 +01:00
jackpoz e7b94603f2 Core/Commands: Add .debug guidlimits <optional map id> chat command
Add .debug guidlimits <optional map id> chat command to show the highest low guid counter for Creature and GameObject, useful when reaching Respawn.GuidWarnLevel

(cherry picked from commit 7421ccaf7eb134f549ad3734a815397216d020ed)
2021-12-16 00:53:58 +01:00
ccrs 1e84edde39 Core/Spells: Port refactors from d1dc0e2dc1fbd692eeda90ae2ab82ae07e2cae0e
(cherry picked from commit d1dc0e2dc1fbd692eeda90ae2ab82ae07e2cae0e)
2021-12-16 00:42:21 +01:00
Treeston ea753efb93 Core/Chat: Rewrite some custom channel handling. Channel creation now properly saves passwords. Closes #23589.
(cherry picked from commit 8c16f318fe072709fc40c61987570dba8f5b6483)
2021-12-16 00:37:01 +01:00
jackpoz 71b2f8c6ab Core/Calendar: Fix issue with invite status being set to the wrong invite
Consider the case of Player A inviting Player B to a Calendar Event. After Player B clicks on Accepts/Tentative/Reject, the calendar shows that status for Player A instead.

(cherry picked from commit 7f3d8c99bb14c7b093a5c2419f3e931fef11004e)
2021-12-16 00:15:48 +01:00
Wyrserth 1b7a1c51ae Core/Player: prevent trade system from getting stuck in an invalid state when the LevelReq.Trade config is used.
(cherry picked from commit a54af39e29f87735ce2bc9774e664b543c9dff02)
2021-12-16 00:14:52 +01:00
ccrs 49bc6533fd Scripts/ScarletEnclave: 4ee84bb followup
(cherry picked from commit 81475f709f067eea0437361e7098b7a6b9cf3a26)
2021-12-16 00:11:25 +01:00
ccrs 8c35206bb5 Scripts/ScarletEnclave: 4ee84bb followup
(cherry picked from commit fa9a4ee20d6a63f2e99e9feb45cd0ecf83ccc7f5)
2021-12-16 00:10:25 +01:00
ccrs ef6a5d3c3c Core/Unit: movement related corrections prior to getting Charmed
(cherry picked from commit 294a3a2789582e05a7847620173d533bd07e44e9)
2021-12-15 23:42:06 +01:00
Wyrserth 3bb61af113 Script/ScarletEnclave: use spline movement for the lauch phase of the Eye of Acherus.
Closes #22802.

(cherry picked from commit 4ee84bbecbccee2adb093d4c30172edc22ef8499)
2021-12-15 23:39:51 +01:00
Killyana f175cd38af DB/Misc: Vengeance Landing
(cherry picked from commit f9e0cac32e4614dba621d770ec1a8807c423ae6e)
2021-12-15 23:38:31 +01:00
Treeston a69a061d76 Battleground/Arena: Properly check RBAC arena join permission before allowing queue. Closes #23000.
(cherry picked from commit af082664ca8ff76cc8ef1947d6ce76310d65b58b)
2021-12-15 23:31:31 +01:00
Treeston b4b581de1b Scripts/Commands: .account ban no longer fails if an account containing the specified account name is already banned (f.ex. attempting to ban 'test' if 'test2' is already banned) - closes #22990
(cherry picked from commit daf423a6c3c0fdd13e421f02ccd791103f7bdd5b)
2021-12-15 22:48:03 +01:00
Treeston b8c7260bfd typo fix, duplicate assignment
(cherry picked from commit 7d6896b54141c32c51f49f2c3fcd58cd986f0e02)
2021-12-15 22:41:58 +01:00
Killyana 074b0513af DB/Condition: Bladespire Clan Banner
Ref #23262

(cherry picked from commit 8c55e0ff06cde708a96f98a24b22ba56d3f8d04f)
2021-12-15 22:41:39 +01:00
Treeston 6de4c3cd72 Entities/GO: FindNearestGameObject no longer incorrectly returns despawned gameobjects. Closes #23262.
(cherry picked from commit 4423ca99e7f8c38ff83196134038a7790313ed7a)
2021-12-15 22:40:39 +01:00
Killyana a3727f4409 DB/Quest: Fix cosmetics for the quest Report to Anselm
(cherry picked from commit 680e2e611954e6dee3060a45a4d1b9551069fd2c)
2021-12-15 22:16:05 +01:00
offl 8648ba2b4a DB/Creature: Make 1 default sheath state to prevent further addon tables corruption
(cherry picked from commit d19c0dfd1b8b5a5f2d2f87beb5099e3fc1c41786)
2021-12-15 21:54:43 +01:00
Killyana cc952fa43b DB/Creature: Blacksouled Keeper & Keeper Witherleaf
From https://github.com/cmangos/wotlk-db/commit/b2783ef80959aedd75bf26d1e7cfbd2657544405 by Grz3s

(cherry picked from commit 69a17a1751d3fb40282f412c0c8a3c8b9c8b20bc)
2021-12-15 21:52:35 +01:00
Killyana 4378ad98ab DB/Quest: Seeds of the Blacksouled Keepers
(cherry picked from commit 42abf69a27058251b7dd59a59c1f059f834431e4)
2021-12-15 21:51:07 +01:00
Wyrserth ee4388a651 DB/SAI: fix issue with quest "A Suitable Disguise".
Closes #23584.

(cherry picked from commit 446f8b0b71b1756a32e817375b79fa8d025d6c74)
2021-12-15 21:49:51 +01:00
ccrs 16bbc015e7 Core/Weather: 6eecb68 followup
missing IntervalTimer::Update call

(cherry picked from commit 965ec9a57180062aa8dad3b929146c7692186262)
2021-12-15 00:17:33 +01:00
Giacomo Pozzoni ebe436d2c2 Core/ChatCommands: Fix .wp reload crash
(cherry picked from commit e4c2bb4f1411f2db724a7cfcdc014013a63b37a5)
2021-12-15 00:17:32 +01:00
Wyrserth c77f57edbc DB/Quest: restore ExclusiveGroup data for breadcrumb quests, as they're mutually exclusive.
Also restore PrevQuestId/NextQuestId error logs involving breadcrumb quests. Special cases must be handled via conditions.

(cherry picked from commit 7f63c504d5cf5a9ad2f3d77ff2c67ca9d7586dd5)
2021-12-15 00:17:32 +01:00
Wyrserth a24de1378f DB/Quest: fix some more breadcrumbs and some offer_reward emotes.
(cherry picked from commit 4dbdc22b3b5770ff8252ea057bf7a7a92dcb31cb)
2021-12-15 00:17:32 +01:00
Wyrserth 755a83f634 Core/Quest: remove arbitrary error logs related to breadcrumb quest chaining.
There are complex cases where breadcrumb quests are mutually exclusive with other breadcrumbs leading to other quests, chaining them shouldn't generate log errors.

(cherry picked from commit e6080116f9acb41b1c3d26468a679ff7e4b7c106)
2021-12-15 00:17:32 +01:00
Wyrserth a878e843d7 DB/Quest: fix some breadcrumb quests.
(cherry picked from commit 2a9c038fc8bf87b968a94b23bd0ddb79fecf8b17)
2021-12-15 00:17:32 +01:00
Treeston 2799cdc522 Scripts/World: Rewrite air force trigger bots script, add hostility check along the way. Closes #23307.
(cherry picked from commit 0ae2afe307595463df8f4a16fdd1ee9740a11c9e)
2021-12-15 00:17:32 +01:00
Wyrserth 6f45e88396 DB/Creature: add out of combat events and fix pathing for Conjurer Tyren.
(cherry picked from commit b9d1e665075ffbd94f3ec96a3e8819615bd3d24a)
2021-12-15 00:17:32 +01:00
ccrs 6ae0a6ba22 Core/Movement: add missing parenthesis on MotionMaster::Size
pretty sure this can cause unexpected behaviour

(cherry picked from commit bec52dba3d7e4acb0b78c6a1093fe33da8205781)
2021-12-15 00:17:32 +01:00
Wyrserth 89a1954602 DB/Quest: improvements for quest Hampering Their Escape:
- Add missing flames on item use.
- Prevent trigger creatures from wandering around and falling off the platform
- Add conditions to the item Gnomish Grenade

(cherry picked from commit 76beda3768ebbcbf42f96e2f8596c95b24327dfe)
2021-12-15 00:17:32 +01:00
Wyrserth f2245d602f DB/SAI: add waypoints and out-of-combat texts for Ambassador Kelemar, Dela Runetotem, Cheneta, Kristine Denny and Tatai.
Closes #14485.

(cherry picked from commit 90a04adb408726c66d115b0053aad54e51d934d1)
2021-12-15 00:17:32 +01:00
Treeston fc9908d163 warning fix f2cd721 follow-up
(cherry picked from commit be96d8242c0b8abf909862a577d04a9f8e18560a)
2021-12-15 00:17:32 +01:00
Treeston 925aaecbc0 Core/Quest: Do not allow quests to be turned in if the player no longer satisfies level/skill/reputation requirements. Fixes #226. Yes, you read that issue tag right.
(cherry picked from commit a1fd404b64fe46925cf5ab3e3af267ce9ba1badd)
2021-12-15 00:17:32 +01:00
Treeston 9491650401 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026.
(cherry picked from commit f2cd721d5358f7febf36dc757f5e3e9693a6a7b6)
2021-12-15 00:17:32 +01:00
Ianislav Vasilev fa9683fc68 Scripts/Blood Furnace: Broggok improvements (#23300)
* 23285 Fixed lever respawn and future encounters after it respawns.

* Removed unnecessary additional container.
Made lever not to despawn and respawn but rather change flags only.

* Made one conditional branch easier to debug.

(cherry picked from commit c71e36acaea9c04e63dcba9a39b5a6a76e3cac75)
2021-12-15 00:17:32 +01:00
Treeston fdb43e41a8 Scripts/Outland: Rewrite the Watch Commander Leonus event so it no longer starts exponentially more often if the grid remains loaded for over an hour. Closes #23348.
(cherry picked from commit a3c35262692e2f059785c22f92fce39ffe4dc6ac)
2021-12-15 00:17:32 +01:00
Sorikoff a947a0e85e Scripts/Spells: Brittle Armor & Mercurial Shield (#23576)
(cherry picked from commit a64d7df6623d90c529fab76dc6b41e2db5a3abd4)
2021-12-15 00:17:32 +01:00
ForesterDev 61cc88731c Scripts/Commands: update .wp commands to use orientation field from DB (PR #23566)
Closes #23330

(cherry picked from commit e71773140c8efbea4abe612a71d4a65f041d450c)
2021-12-15 00:17:13 +01:00
Treeston a5d8807af8 Entities/Player: Properly restore PvP-enabled state on login
(cherry picked from commit 671052575a36624b06379ee5e13a7fea26870194)
2021-12-14 23:31:56 +01:00
Aokromes 3ad5bc1e15 Core/Misc: More coding standards (#23519)
* Core/Misc: More coding standards

* revert part

* "void  " or more to "void "

* fix? reject

* remove more double whitespaces

* remove more double whitespaces

* more standards

* more coding standards

* More standards

* more coding

* more coding standards

* more coding standards

* And more standards

(cherry picked from commit 574a7c8d3d5f5a5660295deb70e905cf4dd756c4)
2021-12-14 23:04:29 +01:00
Treeston 2532de6acb Entities/Unit: Nuke Map::ForceRespawn from orbit, with the following implications:
- .npc respawn no longer causes stupid things to happen (Fixes #23014)
- ::DeleteFromDB methods on Creature and GameObject rewritten to be as sensible as such a colossally stupid method can ever be. They're static now.
- .npc delete and .gobj delete ported to new argument handling, and rewritten as per above. They can no longer crash the server when used in instances, too. Yay for that.
- Adjusted various dusty cobwebbed hacks around the core (why does waypoint visualization use permanent spawns *shudder*) to still work too.

(cherry picked from commit 84b7b2e08ea55575cbe62d795383d4a5341ffd4d)
2021-12-14 22:42:22 +01:00
ccrs 8be3d33eae Build: fix linking error
/home/circleci/project/src/server/game/Movement/MovementGenerators/RandomMovementGenerator.cpp:50:9: fatal error: use of undeclared identifier 'AddFlag'
        AddFlag(MOVEMENTGENERATOR_FLAG_TIMED_PAUSED);
        ^

(cherry picked from commit ec1a77bca20487f86765620485db9b13bb03aee8)
2021-12-14 22:24:34 +01:00
Treeston 2225cb1201 Entities/Creature: Some asserts are now LOG_ERRORs that block spawning. Fix a group spawning bug exposed by the CoS merge. Improve some command output.
(cherry picked from commit ded18a2690063991d5440df7d3e5d526b884ec16)
2021-12-14 22:24:24 +01:00
ccrs f21599dc5d Core/Movement: handle Resume/Pause on RandomMovementGenerator
(cherry picked from commit b8c0aeaf14dfabc9940203aec21ef29111e755cc)
2021-12-14 22:19:40 +01:00
ccrs ff11e95071 Core/Unit: f869c49 followup
Movement Pause/Clear is already handled in Unit::SetCharmedBy and Unit::RemoveCharmedBy, respectively

TODO: missing PAUSE handling in RandomMovementGenerator
(cherry picked from commit 4fa3c04b7263c0038b96e50c29f8ba52a4802995)
2021-12-14 22:19:13 +01:00
Wyrserth 24c07367f1 Core/Vehicle: prevent creature vehicles from following their old movement generator when a player enters them in some cases.
Closes #21731 and #22368.

(cherry picked from commit f869c4969ebd573da2742dcee0dfbe688e7896e0)
2021-12-14 22:19:01 +01:00
Wyrserth 004602f3e4 Core/Quest: fix icon in gossip window for repeatable, non-autocomplete quests.
Closes #23572.

(cherry picked from commit 9f6d3e93f95ea126512e5eb52e46dbaefccf54d6)
2021-12-14 22:17:47 +01:00