Commit Graph
100 Commits
Author SHA1 Message Date
megamage bd0dbcc9ad *Add script lock for ScriptsProcess() because some bad scripts may cause dead loop.
--HG--
branch : trunk
2009-08-19 17:42:56 -05:00
megamage 44830d9d99 [8393] Fixed format CMSG_FORCE_MOVE_UNROOT_ACK and CMSG_FORCE_MOVE_ROOT_ACK. Author: VladimirMangos
Also avoid packet tail warnings spam at rejected movement packets.

--HG--
branch : trunk
2009-08-19 17:19:50 -05:00
megamage f5aeb3e5f7 *Check proc chance of "improved shadowform". By Den
--HG--
branch : trunk
2009-08-19 17:18:05 -05:00
megamage 34a95e7fa8 [8390] Fixed log output work after recent replace UTF8PRINT macro. Author: VladimirMangos
--HG--
branch : trunk
2009-08-19 17:14:18 -05:00
megamage c911772125 [8389] Implement check really read received packet size and warning it not all data read. Author: VladimirMangos
* This let more easy catch packet structure chnages at client switch.
    * Fixed structure CMSG_GUILD_BANK_SWAP_ITEMS
    * Fixed structure CMSG_SPLIT_ITEM, CMSG_SELL_ITEM
    * Added read data amount fixes for some other packets.

    Thanks to TOM_RUS in help check correct packets structure.

    Note: not all packets possible fixed. Please report for not fixed cases at errors:
    "opcode %s (0x%.4X) have unprocessed tail data (read stop at %u from %u)"

--HG--
branch : trunk
2009-08-19 17:07:21 -05:00
megamage f5085b2f39 [8388] Replaced UTF8PRINT macro by a function
Should also fix possible color leak on Windows CLI.

    Signed-off-by: freghar <[email protected]>

--HG--
branch : trunk
2009-08-19 17:02:29 -05:00
megamage d7e4392f79 [8387] Fixed error output at creature_template check Author: arrai
--HG--
branch : trunk
2009-08-19 16:59:07 -05:00
megamage 49bd3dc381 [8386] Fixed areatrigger distance check Author: arrai
Old check caused false positives for trigger #4853

--HG--
branch : trunk
2009-08-19 16:58:26 -05:00
megamage a55c618af6 [8385] Use 3D coordinates for checking corpse distance at reclaiming Author: arrai
--HG--
branch : trunk
2009-08-19 16:57:53 -05:00
megamage a7e297434a [8384] Restore build mangos at Unix/Linux. Author: VladimirMangos
* Also fixed wrong read_skip<char*>() code.
    * Also fixed some warnings in related code.

--HG--
branch : trunk
2009-08-19 16:56:57 -05:00
megamage 051b383254 [8383] Implement WorldSession::HandleCancelChanneling. Author: VladimirMangos
--HG--
branch : trunk
2009-08-19 16:55:35 -05:00
megamage edc05f2c19 [8382] Implement ByteArray functions for skip read of fields not needed for server in received packets. Author: VladimirMangos
* Use this fucntions in some case.
    * Change some packets to form: read fields first check later for better control recieved packets structure.
    * Fix CMSG_STAND_STATE_CHANGE packet structure to more correct.

--HG--
branch : trunk
2009-08-19 16:54:52 -05:00
megamage 012d6fa865 [8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
* Restrict access, use enum args, move some repeated code parts to function.
    * Make m_selfContainer set only part of Unit::SetCurrentCastedSpell

--HG--
branch : trunk
2009-08-19 16:52:51 -05:00
megamage 6181620520 [8380] Use CastSpell instead create triggered channaled spell in Spell::EffectTriggerRitualOfSummoning. Author: VladimirMangos
--HG--
branch : trunk
2009-08-19 16:28:25 -05:00
megamage e954904e6d [8378] Use exceptions instead of explicit size checking for each packet Author: arrai
CHECK_PACKET_SIZE was pretty error prone; once it was forgotten mangosd
    could crash due to the asserts in ByteBuffer.h. That was exploitable by
    malicious players.
    Furthermore, there were duplicate checks: Additionally to
    CHECK_PACKET_SIZE, the ByteBuffer assertions keept an eye
    on not exceeding the packet boundaries - just to crash the server for
    sure in such a case.
    To prevent memory leaks or other undesirable states, please read in
    every handler all variables _before_ doing any concrete handling.

--HG--
branch : trunk
2009-08-19 16:26:22 -05:00
megamage d9ed49749d *Fix a crash caused by ~Player
--HG--
branch : trunk
2009-08-19 16:10:25 -05:00
Machiavelli c9eee8e524 *Use the pre-dual spec way of unlearning talents on top of the current one, to ensure that talents don't end up in the spell storage causing unexpected behaviour in game when trying to learn a talent.
Note: If your players have trouble learning specific talents, or they have an abnormal amount of talent points, force a talent reset on them after this rev and it should be resolved.

--HG--
branch : trunk
2009-08-19 22:38:08 +02:00
megamage 69c3abfc0b *Fix the bug that alliance players cannot use some dk flight nodes.
--HG--
branch : trunk
2009-08-18 21:58:44 -05:00
megamage 9bd8f09978 *Summon GO dawn of light instead of changing db.
--HG--
branch : trunk
2009-08-18 19:10:58 -05:00
megamage cfd24129d3 *Fix a crash by looting player's corpse when the bg is unloaded.
--HG--
branch : trunk
2009-08-18 17:44:17 -05:00
megamage 0ca7275043 *more area flags for Dalaran By raven_coda
--HG--
branch : trunk
2009-08-18 17:18:24 -05:00
maximius a3a9bf2622 *Deleting some missed talents that need cleaning up for dual spec to work fully.
--HG--
branch : trunk
2009-08-18 15:00:57 -07:00
Rat 37cb12a761 *fix Kalecgos immunities
--HG--
branch : trunk
2009-08-18 21:24:31 +02:00
QAston 5ffa85c858 *Fix server startup error from 5184.
--HG--
branch : trunk
2009-08-18 20:17:06 +02:00
Nevan d3d2eb91bb *Fix Pet movement speed at combar reset. Thanks BlackYoghurt.
--HG--
branch : trunk
2009-08-18 19:37:31 +02:00
megamage 483f40cbd8 *Script of quest The Light of Dawn. By ckegg.
*I have reduced the number of mobs because they may make the server laggy if the server is not good.

--HG--
branch : trunk
2009-08-18 12:09:03 -05:00
QAston ea98699187 *Fix a typo in xp bonus auras.
--HG--
branch : trunk
2009-08-18 18:47:20 +02:00
megamage 84bb5022f5 *Fix a crash when creature release charmed unit. Thanks to Visagalis.
--HG--
branch : trunk
2009-08-18 09:18:32 -05:00
Machiavelli d549ed1f8a Changes in Al'ar script:
* Don't wipe threat in transition from phase 1 to phase 2
* Correctly cast flame patches in phase 2 if no target in melee range instead of resetting
* Fix crash in dive bomb

--HG--
branch : trunk
2009-08-18 16:07:08 +02:00
megamage a690f5239c *Fix the bug that .start always send dk back to start zone.
--HG--
branch : trunk
2009-08-17 23:51:08 -05:00
megamage 98f58a0f0a *Fix quest "endless hunger" in some machines. Thanks to McLovin.
--HG--
branch : trunk
2009-08-17 23:20:50 -05:00
megamage 648413ae0d *Set summontype 647 as type_totem for spell 52893
--HG--
branch : trunk
2009-08-17 23:09:17 -05:00
megamage 1992df8e89 *Add file chapter5 for dk quest.
--HG--
branch : trunk
2009-08-17 22:59:35 -05:00
megamage 6701d3d24f *Script for quest "An End To All Things..."
--HG--
branch : trunk
2009-08-17 22:34:18 -05:00
Nevan 7c2db4f2a9 *Fix Glyph of Rune Tap. (To not heal caster)
--HG--
branch : trunk
2009-08-18 05:17:19 +02:00
megamage c84d37c2c2 *Fix the bug that Reset is not called for some scripts. This should fix the bug of quest "death's challenge". Thanks to Kudlaty
--HG--
branch : trunk
2009-08-17 20:00:28 -05:00
Nevan 14022b619f *Fix Glyph of Typhoon
*Fix Glyph of Thunderstorm

--HG--
branch : trunk
2009-08-18 00:35:32 +02:00
megamage b91be086f0 *Fix a typo in spell 58039.
--HG--
branch : trunk
2009-08-17 17:23:53 -05:00
megamage d205ff9e06 [8377] Resolve some spell_area problems in GM and non-GM mode. Author: VladimirMangos
* Make spell 40216 and 42016 casted/remove at aura 40214 apply/remove.
      And drop related spell_area possible existed data.
    * In general restore apply area limitations to spell casting in GM mode.

--HG--
branch : trunk
2009-08-17 16:34:02 -05:00
Kudlaty d118ef5d08 Fix issue that duel is not triggered in quest Death's Challange
--HG--
branch : trunk
2009-08-17 23:29:01 +02:00
megamage a2bc73c255 [8375] Update start fall height at lost SPELL_AURA_FEATHER_FALL. Author: Lutik
--HG--
branch : trunk
2009-08-17 16:23:26 -05:00
megamage 077849c7fd [8374] Implement glyph 43379. Author: VladimirMangos
--HG--
branch : trunk
2009-08-17 16:21:50 -05:00
megamage a984c3a1d9 [8373] Correctly set bgInstanceID to 0 when log in into alredy ended BG.
This should fix problem that players who logged off during BG are after every
    next login into game teleported to BG entry position.

    Signed-off-by: ApoC <[email protected]>

--HG--
branch : trunk
2009-08-17 16:07:46 -05:00
megamage c31a744771 [8372] Prevent remove triggered spell auras by later applied parent spell auras. Author: VladimirMangos
--HG--
branch : trunk
2009-08-17 16:07:37 -05:00
megamage 83b1cd857f [8371] Updated comments for enum CreatureTypeFlags.
Thanks Hunuza for additional research.

    Signed-off-by: NoFantasy <[email protected]>

--HG--
branch : trunk
2009-08-17 16:00:12 -05:00
megamage 1aa4fb84d0 [8370] Implement dummy auras for spell 36730 and 44191.
Signed-off-by: NoFantasy <[email protected]>

--HG--
branch : trunk
2009-08-17 15:59:39 -05:00
megamage 6a9693a1e4 [8369] Some step back in triggered effect caster selection. Author: VladimirMangos
(I do not know what spells this will fix)

--HG--
branch : trunk
2009-08-17 15:54:39 -05:00
Kudlaty 168a986950 Fix typo in Death's Challange.
--HG--
branch : trunk
2009-08-17 22:25:44 +02:00
Machiavelli 977e655e2a Channel system update:
* Fix bug that player does not have moderator priveliges when ownership was passed on to him after previous owner left the channel.
* Comment out code + alter DB field that are responsible for storing ownerGUID in the database, making it no longer possible for an ex-owner to instantly regain ownership by rejoining the channel as this is not blizzlike.
The code is commented out in case someone wants to make a configurable option out of it.
* Cleanup some other code in affected files.

--HG--
branch : trunk
2009-08-17 22:06:37 +02:00
QAston 97f0f98ec4 *Implement aura type SPELL_AURA_LINKED(284).
--HG--
branch : trunk
2009-08-17 21:06:01 +02:00
QAston e27576ab45 *Implement aura SPELL_AURA_IGNORE_HIT_DIRECTION(288).
--HG--
branch : trunk
2009-08-17 20:38:36 +02:00
megamage 596c0cd5f7 *Fix dk quest chain until "The Scarlet Apocalypse"
--HG--
branch : trunk
2009-08-17 13:09:42 -05:00
Kudlaty 6dc27d432b Fix spellclick typo
--HG--
branch : trunk
2009-08-17 19:29:33 +02:00
Nevan 5c285e93b9 *Fix Glyph of Rake
--HG--
branch : trunk
2009-08-17 19:23:17 +02:00
megamage 937fd6d632 *Add script of quest "Bloody Breakout". Original patch by ckegg.
--HG--
branch : trunk
2009-08-17 11:25:38 -05:00
QAston 5047eb7a62 *Implement aura type SPELL_AURA_PREVENT_REGENERATE_POWER(294).
--HG--
branch : trunk
2009-08-17 16:57:36 +02:00
QAston b8993423b5 *Implement aura type SPELL_AURA_MOD_CRIT_PCT(290).
--HG--
branch : trunk
2009-08-17 16:30:14 +02:00
Kudlaty b568a9cc4a Fix sql
--HG--
branch : trunk
2009-08-17 16:03:26 +02:00
Machiavelli 7158fc3ef4 * Fix hunter pet talent 'Last Stand'
--HG--
branch : trunk
2009-08-17 15:17:20 +02:00
QAston 445b8236a1 *Implement aura type SPELL_AURA_MOD_XP_QUEST_PCT (291) and fix SPELL_AURA_MOD_XP_PCT(200) handler.
*Correct structure stored in world.sql for npc_spellclick_spells and fix world_script_text application.

--HG--
branch : trunk
2009-08-17 14:55:50 +02:00
Machiavelli 798ff48c59 * Correctly set SPELLMOD_COOLDOWN for pet cooldowns. By pasdVn.
--HG--
branch : trunk
2009-08-17 14:36:36 +02:00
QAston d8554f60be Fix negative spawntimesecs handling in gameobjects - they now start off unspawned and disappear correctly upon despawn (even if PCs aren't moving)
Quest 308 changed to not require completion of 403 (offi does not have 403 as quest, just a gossip)
Quest 308 finish script changed to show unguarded barrel earlier (as it does in offi)
Author of all of these: totoro.

--HG--
branch : trunk
2009-08-17 13:58:43 +02:00
QAston 44c100ae15 *Remove duplicate entries for lightwell from world_spell_full - thanks to Darkshines.
--HG--
branch : trunk
2009-08-17 13:13:02 +02:00
QAston 46277fa552 *Fix for spell used by cooking pot for quest Super Hot Stew(43723) - by simon.
--HG--
branch : trunk
2009-08-17 12:52:11 +02:00
Anubisss 609b134996 *Fix this part of Frozen Power: "when used on targets at or further than 15 yards from you".
--HG--
branch : trunk
2009-08-17 12:02:33 +02:00
Anubisss 69c7ba7255 *Merge TrinityCore r1636.
--HG--
branch : trunk
2009-08-17 11:25:58 +02:00
Machiavelli bd48f76760 * Allow partial blocs to proc PROC_EX_NORMAL_HIT, by nos4r2zod
--HG--
branch : trunk
2009-08-17 11:12:31 +02:00
Machiavelli b043e5bd94 * Set mana to 0 in addition to active power when character swaps talent specs.
--HG--
branch : trunk
2009-08-17 09:56:42 +02:00
Machiavelli a96c31c95d * Correct some calculation in Unit::CalcAbsorb resist, prevents players being killed because absorbed value was negative.
--HG--
branch : trunk
2009-08-17 08:41:20 +02:00
megamage c5287ba58e *Add script of quest "Ambush At The Overlook". Original patch by ckegg.
--HG--
branch : trunk
2009-08-16 23:57:23 -05:00
Machiavelli 0a08fe9bbc * Add changes to trinitycore.conf.dist from rev 5124, somehow HG missed it.
--HG--
branch : trunk
2009-08-17 06:21:16 +02:00
Machiavelli 43dc0c97d1 * Fix bug that player cannot receive credit for killing a creature if damage done to the creature by spell reflect >=49% of the creatures HP.
--HG--
branch : trunk
2009-08-17 06:02:01 +02:00
megamage 7fb33c8bf5 *Add some debug info in "endless hunger" script.
--HG--
branch : trunk
2009-08-16 22:44:53 -05:00
megamage d42bb416a2 *Add script of quest "How to win friends and influence enemies". Author ckegg. With some modifications.
*Fix the bug that persuader can be used on other creatures.

--HG--
branch : trunk
2009-08-16 22:23:08 -05:00
Kudlaty 39b4b704ec Correct one gossip in npc_taxi and use for it Spell instead of function ActivateTaxiPathTo
--HG--
branch : trunk
2009-08-17 05:05:49 +02:00
Machiavelli 445c8722fe *Merge
--HG--
branch : trunk
2009-08-17 04:46:26 +02:00
Machiavelli b59f554690 * Fix visual bug that makes client believe that his recently tamed pet has no talent points.
--HG--
branch : trunk
2009-08-17 04:45:34 +02:00
Nevan 94a8d65903 *Typo
--HG--
branch : trunk
2009-08-17 03:31:23 +02:00
Nevan 19ebe75d41 *Fix Frozen Power Talent
--HG--
branch : trunk
2009-08-17 03:28:52 +02:00
Machiavelli 05f2f1911a *Merge
--HG--
branch : trunk
2009-08-17 03:18:44 +02:00
Machiavelli 6b6963c66d * Change CONFIG_OFFHAND_CHECK_AT_TALENTS_RESET to CONFIG_OFFHAND_CHECK_AT_SPELL_UNLEARN, and change behaviour related to the value.
Note: Update your configuration file.

--HG--
branch : trunk
2009-08-17 03:17:14 +02:00
Kudlaty 898efd78b3 Fix typo
--HG--
branch : trunk
2009-08-17 03:12:37 +02:00
QAston a5f7cc1341 *Backout unintentional change in world_spell_full from prev rev.
--HG--
branch : trunk
2009-08-17 03:02:58 +02:00
Machiavelli b9f1f9232d *Merge
--HG--
branch : trunk
2009-08-17 02:58:57 +02:00
Machiavelli 6a68c5cb6f * Correctly remove two-handed weapon in off-hand slot when intended. (Talent reset if configured, switch talent spec)
--HG--
branch : trunk
2009-08-17 02:58:06 +02:00
QAston 41c12d173b *Add spell_bonus_data for lightwell - by Elron
*Add aura_required, aura_forbidden, user_type columns to npc_spellclick_spells table for additional requirement checks
*Remove workarounds from lightwell code and use new npc_spellclick_spells fields instead.

--HG--
branch : trunk
2009-08-17 02:53:39 +02:00
Kudlaty 6359bfb27a Merge [SD2]
r1341 Use same text for all OOX-scripts. Minor adjustments in addition. Patch by Meldanor
r1342 Fix typo in scriptdev2_script_full.sql - skip
r1343 Some cleanup and corrections for Windows project files.
r1344 Clean more files of trailing whitespace.

--HG--
branch : trunk
2009-08-17 02:06:52 +02:00
Machiavelli 82c233de58 *Send correct gossip icons for unlearn talent, unlearn pet talent and purchase dual talent. Dual talent still needs some changes to gossip to make blizzlike.
--HG--
branch : trunk
2009-08-17 02:03:23 +02:00
Machiavelli 6f889c690b *Yet another merge.
--HG--
branch : trunk
2009-08-17 01:44:35 +02:00
Machiavelli ef9a1985e9 *Merge
--HG--
branch : trunk
2009-08-17 01:43:26 +02:00
Machiavelli fa20274a91 *Merge
--HG--
branch : trunk
2009-08-17 01:42:33 +02:00
Kudlaty 423778ca26 Add missing sql file
--HG--
branch : trunk
2009-08-17 01:42:19 +02:00
Kudlaty 55087b5e72 Merge [SD2]
r1331 Delete old .patch files no longer needed. - skip
r1332 Clean up script for end boss in TK and apply SD2 code style. Patch by Abim - skip
r1333 Remove workaround ai's and correct spells to be casted for Flame Strike - skip
r1334 Add misc gossip for npc_timothy_daniels and npc_trollbane. Patch by hoshie
r1335 Correct order of dwarf attack for BRD seven event. Also add missing text and remove wrong gossip. Patch by jotapdiez - skip
r1336 Add support for quest 12573. Patch by Azuritus
r1337 Set eol-style where missing, since i have no fantasy to do other changes for a l33t revision. - skip
r1338 Trim trailing whitespace in files. - skip
r1339 Fix my mistake in rev 1336 and add script where it should be.
r1340 Correct inconsistent use of line endings and set eol-style to custom patch. - skip

--HG--
branch : trunk
2009-08-17 01:41:39 +02:00
Machiavelli 60c0acfae6 * Fix a bug; prevent server from deleting action button of the talent spec that was just switched to, caused by clients response when spells are being unlearned.
--HG--
branch : trunk
2009-08-17 01:40:35 +02:00
Anubisss 5764feb2cf *Fix a typo. By Necroo.
--HG--
branch : trunk
2009-08-17 01:14:30 +02:00
Kudlaty 48e6997453 Revert last rev and fix in correct way. Also some clean up after merge
--HG--
branch : trunk
2009-08-17 01:10:34 +02:00
megamage 418b161bdc *Fix build.
--HG--
branch : trunk
2009-08-16 18:03:26 -05:00
Kudlaty bf13d2d5aa Apply one more time rev 5104 cos its removed by merge
--HG--
branch : trunk
2009-08-17 00:37:32 +02:00
Kudlaty b08bd25bc5 merge
--HG--
branch : trunk
2009-08-17 00:34:14 +02:00
Kudlaty cad925e31d Merge [SD2]
r1326 Correct waypoints and details for quest 863
r1327 Add function GetPlayerForEscort to escortAI (not used by escortAI yet)
r1328 Updated 0.12 patch and redesigned Karathress for better maintenance. Fixed an issue with Karathres's speech and a little casting bug. - skip
r1329 Remove use of old uint64 variable for player guid in escortAI and use function to retrieve pointer to player instead.
r1330 Restore compile and use FailQuest instead of no longer existing FailTimedQuest (ref Mangos 8355).

Move all waypoints to db

--HG--
branch : trunk
2009-08-17 00:29:53 +02:00