Commit Graph
91 Commits
Author SHA1 Message Date
treeston a92bfb5505 Scripts/Commands: Small QoL adjustments
- .debug hostil now shows spawn ID (DBGUID) in addition to current GUID (so you can .go creature to it)
- .npc temp now takes an additional argument before the creature entry that determines whether the spawned creature instantly despawns upon death. Default is instant despawn (current behavior).
- Add .npc evade command.
- Add .pet level command.
- .server shutdown and .server restart now fail with an error message if time is below a config var (GM.ForceShutdownThreshold, default 30s) as long as another player is connected.
    - New commands .server shutdown force and .server restart force bypass this limitation.

(cherry picked from commit 0e1eb460d687e545f95caf0f38a16c3feb7132a3)
2016-09-03 13:46:33 +02:00
treeston 051d403624 Entities/Unit: Fix speed update packets if player is being moved by something else.
Closes #17184
Closes #17254

(cherry picked from commit 19fa504ff5a51ded47f516640fc57deb6793547a)
2016-06-10 19:33:12 +02:00
treeston 213c6b73c8 Entities/Unit: Fix aggression checks when testing player pets vs neutral creatures. Pets will no longer be able to attack unattackable creatures in some situations. Fixes and closes #16659.
(cherry picked from commit bf4d8ad310e41fd365246f52f5eef06b3106d930)

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
2016-04-16 01:54:40 +01:00
treeston 6dfe9d34f3 Merge branch '3.3.5-naxxcleanup' into 3.3.5. (PR #16524)
(cherry picked from commit f37682b7edd0d711e1120cbdd9d627fb5b9dbde1)
2016-04-10 15:27:49 +02:00
treeston dc07c24c0c Scripts/Naxxramas: Fix an edge case crash in Gothik. Closes #16575.
(cherry picked from commit a23ccc1b83ded39501d690e288be49be8f32b539)
2016-04-10 14:39:32 +02:00
treeston c344feed96 Merge branch '3.3.5-horsemen' into 3.3.5-base (PR #16194)
(cherry picked from commit e8a79737a530fe9b605fa6d62a84c1531d56965b)
2016-04-10 14:32:51 +02:00
treeston 43c3b1b2e0 Merge branch '3.3.5-gothik' into 3.3.5-base (PR #16142)
(cherry picked from commit d23ef5d6d073ecc9a0a401875f216449e031998e)
2016-04-10 14:01:37 +02:00
treeston 88268a9dbd DB/Gameobject: Fix respawn time for quest GO "Daggerfen Poison Manual"
(cherry picked from commit 476eb19f21803f1a624e8100288de90827f8d255)
2016-04-09 17:54:21 +02:00
treeston dbf97bbfbf DB/Creature: Remove a duplicate spawn
(cherry picked from commit a189da71081d2ee2b0fc7c46e2cc464cee9ce388)
2016-04-09 17:52:03 +02:00
treeston 181da2a65c - Clean up spell facing behavior a bit. Visual target behavior should now be a lot smoother.
- Clean up Creature.cpp. NULL -> nullptr, gotta love it.
- Renamed some recently added members of Creature to match code style.

(cherry picked from commit 1cf1d4a1eafb3a31bf87a615d9d947eed6eb0f62)
2016-04-09 17:47:45 +02:00
treeston d25ba64b4c Scripts/Karazhan: Hackfix the Opera event script to make Wizard of Oz actually completable.
Doing it in script instead of removing the flags from DB because I'm pretty sure that the DB flags are correct and there's some RP event missing before she becomes attackable.

(cherry picked from commit dc39de01416cfd9a7c0416ed38964b753098ca8e)
2016-04-09 17:35:45 +02:00
treeston f1b3c9f40c No, Travis, I do not intend to handle SPELL_GROUP_STACK_RULE_MAX. It is not a value that should ever be actually used. Go away.
(cherry picked from commit f8a6ab8ac5420fafb2036a7ab8ccbb8f230ab49b)
2016-04-09 17:32:37 +02:00
treeston 7d8bab240b Entities/Pet: Finally fix pets spamming Blood Pact/Fel Intelligence in some scenarios. Your eardrums will thank me.
(cherry picked from commit 21cfacfba79312febf018b8924c359170569421b)
2016-04-09 17:32:24 +02:00
treeston d5ec4ce97b Entities/Creature: Fix bugs with pets not properly reacquiring target after spell cast. Closes #16824.
(cherry picked from commit accad00567f96b9c8173d680034953a54bdb6462)
2016-04-09 17:28:11 +02:00
treeston 6eb49e4bb2 Unit/PlayerAI: Yeah, we allow charmer to be null now, should probably check for that.
Fixes and closes #16728.

(cherry picked from commit 49de12b1cfaca7f089a1ba2660de4a8644a72e2c)
2016-04-08 23:58:45 +02:00
treeston c23a6085c3 Core/AI: Fix an edge case crash with PlayerAI. Again. Sheesh.
(cherry picked from commit fe707db96f711f94a461306748274fa0bffa0226)
2016-04-08 23:38:49 +02:00
Treeston 9476726edc Merge pull request #16676 from ccrs/summonsinit
Core/TempSummons: avoid use MoveInLineOfSight before InitSummon
(cherry picked from commit 472e78d682cb5d5abf4d60111f238744c07096ac)
2016-04-08 22:58:28 +02:00
treeston cf7436b644 Util/Random: Add randtime(Milliseconds const&, Milliseconds const&) to supersede urandms(uint32,uint32) for scripts being ported to std::chrono.
(cherry picked from commit 224b42c53a6ae212f2d1d550903e019ab8a741d6)
2016-04-08 22:57:01 +02:00
treeston 3b67e57e0e Core/Creature: Prevent friendly vehicles from trying to attack their rider after dismounting.
(cherry picked from commit 89e2afb8f9f3766c6ca0e780371f5421c79064b1)
2016-04-08 22:48:06 +02:00
treeston caa1b82b88 Unit/AI: Making Nayd happy.
(cherry picked from commit 59d02322a78b9f58c51930e085ad6cad9dd95eb0)
2016-04-08 20:39:53 +02:00
treeston 3f6b215fca Fix some behavioral weirdness resulting from 79a945d5 - thanks ccrs.
(cherry picked from commit bfac62c5c914efe1576d39504d5dd75f11f41237)
2016-04-08 20:39:42 +02:00
treeston f4baf7c180 Unit/AI: Move CharmedPlayerAI logic from the SetCharmedBy/RemoveCharmedBy hooks to Player::Update -> Unit::UpdateCharmAI to guarantee thread safety and prevent race condition crashes.
(cherry picked from commit 5354b585e3d8eb89b77b932986a3fbf3b53706c4)
2016-04-08 20:39:30 +02:00
treeston 4726116dbc Core/Threat: Prevent bosses (and other stuff using DoZoneInCombat) from switching off of the person pulling if they are pulled without generating threat.
(cherry picked from commit b5b7ce44cfeb98bf47eb6c9e0c926994ad53ede8)
2016-04-08 20:38:22 +02:00
treeston 430698d203 DB/Spells: "Val'anyr, Hammer of Ancient Kings" now properly shields targets healed by Glyph of Holy Light, Earth Shield and others.
Fixes & closes #16478.

(cherry picked from commit 8267e493d10ce2322d13ab30e6944673000425d4)
2016-04-08 20:37:36 +02:00
treeston c25222c428 Merge remote-tracking branch 'tkrokli/redemption_tirions_tale' into 3.3.5 (PR #16680)
(cherry picked from commit d1a9d7765c3874b0ad9a692fea808b857e734dc6)
2016-04-08 20:32:01 +02:00
Treeston 42a01d62e6 Merge pull request #16457 from Treeston/3.3.5-standstatecondition
[3.3.5] Add condition for unit sitting/standing
(cherry picked from commit b6720af4cb59ea056f423011bae2e0ca5a3952d9)
2016-04-08 20:28:55 +02:00
treeston 604d08db52 build fix
(cherry picked from commit d10c698430af0380bffe2c2e050db2ee741ec96d)
2016-04-08 20:18:07 +02:00
treeston e394cd298b Core/PlayerAI: Some more helper methods added. Also, charmed players no longer break crowd control.
(cherry picked from commit a8f760b69213514f16f24f7af85449c5929f2032)
2016-04-08 20:17:56 +02:00
treeston f5a1b75fbd Core/PlayerAI: More follow-up. Helper functions and some internal cleanup.
(cherry picked from commit 5a3a21c2d02a2e3527ef61641c62d6ad6a44926b)
2016-04-08 20:17:40 +02:00
Treeston adc7ee0c51 Merge pull request #16644 from Treeston/3.3.5-customcharmai
Core/UnitAI: Rework creature-controlled player behavior.
(cherry picked from commit 4e4b2b9a138650ebe6087e18dc392f08dafe4e37)
2016-04-08 20:16:15 +02:00
treeston 745b771a4f Fix Baron Geddon and Ragnaros in Molten Core to do pure fire elemental damage with their melee attacks.
(cherry picked from commit 9c0deaaebbbd2861e10a365e283000008a2a188f)
2016-04-08 20:02:33 +02:00
treeston 9e07adccf4 I don't like drycoding. It's coarse and rough and irritating and it gets everywhere.
(cherry picked from commit d4184065b6d51b250ab08f35e88868cef631ed4b)
2016-04-08 18:43:18 +02:00
treeston b2e4a962d9 Incorrect AI aggression as a consequence of the LineOfSight change, episode three, revenge of the special AIs. Also, hopefully the last. No original trilogy please.
(cherry picked from commit ab194d5ae3b9812ebd5c8f56559e85f1441cf857)
2016-04-08 18:43:03 +02:00
Treeston aca9efc47a Merge pull request #16633 from Treeston/3.3.5-talentinspect
Core/Packets: Adjust 'TalentsInspecting' option
(cherry picked from commit 3e250fe4e80205e7b2d0203aa170bef579be5038)
2016-04-08 18:42:59 +02:00
Treeston a931c7c906 Merge pull request #16637 from P-Kito/lfg_quest
[3.3.5/6.x] Core/Player: Fix dungeonfinder quests not rewarding
(cherry picked from commit 59e59e412fa41d6753b370bbfe8c969eb747b329)
2016-04-08 18:22:37 +02:00
treeston c9b24515a5 Merge remote-tracking branch 'sirikfoll/despawnAtEvade' into 3.3.5 (PR #16528)
(cherry picked from commit c70e3e31a7a0714b92a2a25f27fe3006f1e36caa)
2016-04-08 18:07:34 +02:00
treeston 0654b3b816 Check to make sure we aren't dispelling a buff for _all_ dispel types, not just magic. Closes #15321.
(cherry picked from commit 98860911e237e147c6ffb544c730a8c37de000eb)
2016-04-05 22:14:45 +02:00
treeston 60b98ecc27 Revert "Merge pull request #16483 from Treeston/3.3.5-debuffimmunity" to fix #16589 while I investigate the retail behavior of SPELL_ATTR_0_UNAFFECTED_BY_INVULERABILITY further.
This reverts commit d67e87733b2e258dc4f5613ee7fa40445e3b215f, reversing
changes made to cfed2d7a3ddf4f8121d3359f9888e6116fc82e62.

(cherry picked from commit 26bbba4b8d5fab1a1ccb1c164694f790864ec8e1)
2016-04-05 22:12:11 +02:00
treeston 845f81daa5 Core/AI: Fully move react state check from CreatureUnitRelocationWorker to CreatureAI::MoveInLineOfSight. This means that AI for passive/defensive creatures can now once again use MoveInLineOfSight (and fixes that weird thing where triggers decided it would be funny to attack players).
(cherry picked from commit 8e6fb3b1c50f62d95284cf0cc6c25819622e62f3)
2016-04-05 21:51:17 +02:00
Treeston ac034a51da Merge pull request #16483 from Treeston/3.3.5-debuffimmunity
[3.3.5] Make Web Wrap / Mutating Injection (and others) properly cancel on immunity (Divine Shield/Ice Block)
(cherry picked from commit d67e87733b2e258dc4f5613ee7fa40445e3b215f)
2016-04-05 19:56:26 +02:00
treeston 73b917e122 Merge remote-tracking branch 'Eliminationzx/FixJumpDestOrientation' into 3.3.5 (PR #16450) with some minor CS adjustments
(cherry picked from commit cfed2d7a3ddf4f8121d3359f9888e6116fc82e62)
2016-04-05 19:02:11 +02:00
treeston 53722a81a2 AI/BossAI: Make creature never chase targets that are out of bounds
- Add missing const attribute on CheckBoundary arg.
- Prevent AI from attacking a target that is out of bounds. This prevents exploids such as killing Gluth/Deathbringer from out of bounds.

(cherry picked from commit 19ed18c8816e9bd495dcc03eb0e208006a17bab0)
2016-04-05 18:37:20 +02:00
treeston 92381950ee Merge remote-tracking branch 'sirikfoll/npcMyranda' into 3.3.5 (PR #16438)
(cherry picked from commit e5e97bedc06f61aa9430d5506adbdde1cf3b79d8)
2016-04-05 18:08:34 +02:00
treeston 2bde6e2a10 Grids/Notifiers: Notify triggers of units moving within their LoS.
(cherry picked from commit e31743f68246749fdc947d0e547b0d82f4888141)
2016-04-05 18:03:20 +02:00
Treeston 7135a23d33 Merge pull request #16467 from Treeston/3.3.5-FixEvadeMode
[3.3.5] Creature/AI: Fix incorrect evade logic
(cherry picked from commit 8eabbb0427fff559592545f9336909882369b820)
2016-04-05 18:02:46 +02:00
treeston 1d843364e6 DB/Creature: Add CREATURE_FLAGS_EXTRA_NO_PLAYER_DAMAGE_REQ to Garhal (30147), adjust respawn time to 60 seconds. Fixes & closes #16084.
(cherry picked from commit 93718e5b3d504c2a64acf5b04cd0cdc9aac74624)
2016-04-02 20:47:01 +02:00
treeston ca1239af9f Code style, urand -> urandms.
(cherry picked from commit e064000a355005f596557c2ad10d5d189996f426)
2016-04-02 19:26:59 +02:00
treeston 9873800207 Item/Misc: Implement Toy Train Set and Wind-Up Train Wrecker.
(cherry picked from commit 8c7cd03d08b70ca97ae9a524410ad5c9c99cce3d)
2016-04-02 19:20:17 +02:00
treeston 02c9a66b88 fix crash
(cherry picked from commit bf31f26e8c467536456f5ce896274c9c20766eaf)
2016-04-02 17:49:38 +02:00
treeston 870a76ad10 DB/Creature: Add a new extra_flag CREATURE_FLAG_EXTRA_NO_PLAYER_DAMAGE_REQ (0x00200000) that awards players credit for killing the creature even if less than 50% of damage was dealt by players.
This can be used to fix quests such as "Heated Battle" or "If Valgarde Falls..." that are currently very hard to complete at the appropriate level due to "friendly" NPCs killing off the required targets too quickly for players to get 50% of damage in.

(cherry picked from commit d240ccb38c05e394b181a09d42f5e55d3222603a)
2016-04-02 17:33:31 +02:00
treeston 55c364b9c0 DB/ModelInfo: Fix the hitbox on Cyanigosa's dragon form.
(cherry picked from commit bba182428dc532236bcbf17a53f9919b9a8b28cb)
2016-04-02 16:46:56 +02:00
treeston 677309743a Scripts/UtgardeKeep: Bonus Ingvar the Plunderer fixes to reset behavior. There should no longer be weirdness if a reset happens during the RP phase.
(cherry picked from commit 815f43be7a0e1b5086184fcd2a4a2c6f69faa9de)
2016-04-02 16:46:13 +02:00
treeston 61d216593c Scripts/UtgardeKeep: Ingvar updates:
- Roar at start of phase two
- Ingvar no longer does a weird move-jump towards his target when resurrecting
- Fixed a duplicate yell on phase one end

(cherry picked from commit c829fc7de406728f9f089d586d6bdccf7bf14748)
2016-04-02 16:46:01 +02:00
treeston 9f237e745a Fix warning.
(cherry picked from commit f0b9ee157bf459f34d5b069046a17f39cb318fb8)
2016-04-02 15:37:10 +02:00
treeston 76d15c906e Player/Quest: Credit group for gameobject activation if they are in proximity.
(cherry picked from commit cd625a12e21fdb8c5c9d172f901540c8744eedcd)
2016-04-02 15:31:00 +02:00
treeston 3211f639e8 Looting/Group: Do not display looter in tooltip when FFA loot is enabled.
(cherry picked from commit 10482419b79c1aeb546548f845645727d8bdbf6d)
2016-04-02 15:00:59 +02:00
treeston d9c99acebb Spell facing follow-up: Fix an issue with creatures' channeled spells not cancelling properly in certain conditions
(cherry picked from commit 17f924a031e5ebbbc07a54acd61e738bf234867a)
2016-03-29 20:08:01 +02:00
treeston 009cabb4b9 Merge branch '3.3.5-spellfacing' into 3.3.5-base (PR #15641)
(cherry picked from commit 233297c5c8619af96e2aab4fa5ef6d205b5dc18a)
2016-03-29 19:36:05 +02:00
treeston 5f6da87269 Merge remote-tracking branch 'velinath/sai-migrations' into 3.3.5-base
(cherry picked from commit e203d78d2a6daa2dc28fc41769e416753a10c08c)
2016-03-29 19:22:02 +02:00
treeston ada3693608 DB/Creature: Vyragosa/TLPD
- Fix linked pool spawn
- Fix respawn time to be 6h (instead of current 25sec)
Closes #7683.

(cherry picked from commit d412f2d6d3e4a517de5cdb7ed5a7e33d0575d77f)
2016-03-29 19:13:01 +02:00
treeston 5fb88c7121 Merge branch '3.3.5-boundaryagain' into 3.3.5-base (PR #16270)
(cherry picked from commit 1050b68899c661ea09da9e36edb82e8648393673)
2016-03-22 23:37:02 +01:00
treeston 9a24c7175d Fix stuff™.
(cherry picked from commit 0316dff24530da83ef3466500ee8bd4e1af548ba)
2016-03-22 22:57:51 +01:00
treeston e2f2c70ba4 Merge branch '3.3.5-bossboundary' into 3.3.5-base (PR #16089)
(cherry picked from commit 5b8b8c653039ec2add0b3a66468abb85e6f35054)
2016-03-22 22:56:43 +01:00
treeston a254bdff59 Merge remote-tracking branch 'tkrokli/gossip_accept_duel' into 3.3.5-base
(cherry picked from commit 90914518184061d06c7bfba0aebc4ac03b23104f)
2016-03-22 22:06:54 +01:00
treeston dd3ac6eaa8 Fix a spawndist start-up warning.
(cherry picked from commit 91fa2154e892c1cc6d7769e39c50afce74c836fc)
2016-03-22 21:35:42 +01:00
treeston 68c3af4166 Merge remote-tracking branch 'velinath/sai-migrations-3' into 3.3.5-base
(cherry picked from commit 5084b17308c3441e1ca7f455aad17b4a3de2da72)
2016-03-21 23:22:03 +01:00
treeston 40ea130f5a Merge remote-tracking branch 'velinath/sai-migrations-2' into 3.3.5-base
(cherry picked from commit 1d9d03b2891b5481eff6541a8563599ccc60c48d)
2016-03-21 23:21:18 +01:00
treeston c9fdb6af59 Merge remote-tracking branch 'velinath/sai-migrations' into 3.3.5-base
(cherry picked from commit c7459327b2c8565e7cb101826f5059e3cf0628c4)
2016-03-21 23:20:26 +01:00
Treeston 8225fb09c2 Merge pull request #16156 from Treeston/3.3.5-instancerevive2
Game/Maps: Instance handling bug-fix follow-up
(cherry picked from commit ae4fcc3685079e1c24cd46545dae169d5be12046)
2016-03-21 22:41:02 +01:00
Treeston e6ab6b4b0b Merge pull request #16182 from velinath/sai-migrations
Core/Scripts: remove unused npc_taxi scripts
(cherry picked from commit 48d0fd276dad6bbf1de364f692243c78814efbfa)
2016-03-21 22:35:20 +01:00
treeston 0b9269cdad DB/Quests: Betrayal (12713) by @dr-j:
- Fix "Blight Fog" cast behavior
- Fix "Throw Blight Crystal" cast timing

(cherry picked from commit 19462efb4ef04d7b988ec55369dd10f00dd1e895)
2016-03-21 21:55:21 +01:00
treeston 4f6d25d616 DB/Creature: Correct Orbaz Bloodbane creature text (#16168)
(cherry picked from commit 3af1d9196784759bb69dd59ce26599afdfd277a0)
2016-03-21 21:55:05 +01:00
treeston d68b809f9b Merge remote-tracking branch 'tkrokli/move_wyrmrest_temple_taxi_to_sai' into 3.3.5
(cherry picked from commit e0ffc2921b71e8822ac267399c468f2b4a449745)
2016-03-21 21:46:04 +01:00
treeston 94b7e562e2 Merge pull request #16126 from velinath/taxi-to-sai
(partially cherry picked from commit b6ed3d3fc2b8447059ff0aa0e5b6de36947fd006)
2016-03-21 21:29:53 +01:00
Treeston 7422557d03 Merge pull request #16110 from Treeston/3.3.5-instancerevive
Game/Maps: Clean up instance zone-in handling
(cherry picked from commit eb3dc8a4f064d89b78248a511bcf67f805ea3314)
2016-03-21 19:41:28 +01:00
treeston e1fae18417 Spells/Penance: If hostile target is not in front, now fails in the initial cast rather than the triggered cast, thus not erroneously causing a cooldown.
(cherry picked from commit 403ff2132490c7e785bb0ae5373d2c7a34d73e14)
2016-01-16 13:16:57 +01:00
treeston 8d428e4b6b Scripts/Naxxramas: Instructor Razuvious rework:
- Fix missing yells
- Rearrange existing yells to match live
- Sniffed positions for adds
- Improve add respawn handling
- Make adds not fight the player for control (don't use their spells on their own etc.)
- Update adds' hotbar keys to match live (this will affect other creatures with nonsequential possess keys as well)
- Fix adds' movement when mind controlled, they no longer move automatically when right-clicking (this affects all mind-controlled creatures)
- Blizzlike timers

(cherry picked from commit 54d583b0fbb7ecfb97a731be21218bbb72d80b4d)

# Conflicts:
#	src/server/game/Spells/SpellMgr.cpp
2016-01-16 12:26:13 +01:00
treeston d3ea8c5750 Scripts/Naxxramas: Maexxna cleanup:
- Improved Web Wrap target selection
- Added missing text
- Cleanup of web wrap positioning - two players will never be flung to the same position (25-man)
- Further improvement to web wrap spawn behavior - targetable web wrap now only spawns after the player has finished being flung to the respective position (blizzlike)
- Add additional web wrap positions (sniff)

(cherry picked from commit 5dd61633872fc40d83dfa13aa58a1c7de717c012)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_maexxna.cpp
2016-01-15 21:09:46 +01:00
treeston bac8c4376f Scripts/Naxxramas: Thaddius follow-up:
- Reduce initial spawn timer on the encounter from 30 seconds to 5 seconds
- Rearrange respawn logic to fix the "petrified" visual from not showing properly
- Fix a potential infinite respawn loop that could prevent the encounter from initializing properly (fixes and closes #15898)

(cherry picked from commit bf9963039906f4b4df218ecc1818f5b01bcc714d)
2016-01-15 19:54:49 +01:00
treeston 43ae580a47 Scripts/Naxxramas: Complete rewrite of the Thaddius encounter.
(cherry picked from commit 29feae5901c049ef2204d956e83cf20507bed37a)
2016-01-15 19:43:42 +01:00
treeston 6d14c4871f Scripts/Naxxramas: Anub'rekhan encounter cleanup.
- Cleaned up events behavior to use phases instead of weird checks for auras.
- Cleaned up Crypt Guard despawn behavior, they should no longer despawn instantly upon death.
- Moved initial greeting from MoveInLineOfSight hack to proper areatrigger script.
- Fixed Crypt Guard respawn behaviour to prevent pulling them before Anub'rekhan has fully reset.
- Fixed Crypt Guard aggro behaviour to call for help on aggro. This prevents pulling the initial pair of Crypt Guards without engaging the boss.
- Added missing boss emotes.
- Code style cleanup.

(cherry picked from commit 91de0322bba3ef071338ce5a71f512369486eb1f)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_anubrekhan.cpp
2015-11-06 11:07:31 +01:00
treeston b6ac8c577c Scripts/Naxxramas: Faerlina cleanup:
- Move greeting to areatrigger instead of MoveInLineOfSight hack
- Clean up add spawn handling to prevent various glitching with combinations of evade state and add aggro
- Ensure all adds are always pulled alongside the boss and vice versa
- Add missing texts.
- Fix a bug in the core that prevents castable-while-dead spells (such as Widow's Embrace) from appearing on possess bars.

(cherry picked from commit 577fcf356e9cd54fb0490069d7aa26894e9b5db3)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_faerlina.cpp
2015-11-06 10:59:34 +01:00
treeston a37e6e20c8 Scripts/Naxxramas: Loatheb follow-up:
- Fix Deathbloom (for real this time)

(cherry picked from commit 17fdb1e091796933a2028778e4ea5f3b53186b4f)
2015-11-06 09:54:40 +01:00
treeston 7886fafbdc Heigan cleanup:
- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs

(cherry picked from commit 3e2014a958c2295c175b359dbeed48f36befce98)
2015-10-30 12:24:26 +01:00
treeston f3b5bdc0b3 Scripts/Naxxramas: Bugfixes to the Noth encounter.
- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy

(cherry picked from commit 3fc1bb1abf0d4ae7b37507c62a3b57175477ce2f)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_noth.cpp
2015-10-30 11:46:37 +01:00
treeston dba753b0ef Scripts/Naxxramas: Adjustments to the Loatheb encounter
- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats

(cherry picked from commit ea1c783b84d4fa489436531667f3c121631b25d4)
2015-10-30 11:42:19 +01:00
treeston 12e90350e4 Script/BoreanTundra: Fix dialog and final waypoint for quest 11570: "Escape from the Winterfin Caverns"
This fixes the following bugs:

Escortee NPC quotes are out of order (see #15396 (comment))
Final escort waypoint is located incorrectly and causes the escorted NPC to drop all the way to the bottom of the ocean before quest completion is awarded.

Closes #15396

Signed-off-by: DDuarte <[email protected]>
(cherry picked from commit a83437af3dd03cc2227947ff229da3bf2d5421f0)
2015-10-20 15:39:42 +02:00
treeston 0bf78d5761 Custom logic for putting people in combat instead of relying on CreatureAI or Creature methods.
(cherry picked from commit 6a8524c068d418092c193a3419b65818f3fd3443)
2015-10-16 12:45:53 +02:00
treeston 89357f5425 Core/Creature: Add facilities to the Creature class to allow setting an automated, periodic pulse that puts every player in the zone in combat and on the creature's threat list.
Scripts/BossAI: Set the BossAI parent class to make use of this in its _EnterCombat and _Reset methods. Combat pulses happen every 5 seconds.

(cherry picked from commit d57193df444b719757ae1da4a5f19e204074f6ae)

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedCreature.cpp
#	src/server/game/Entities/Creature/Creature.cpp
2015-10-16 12:44:17 +02:00
treeston c64b71d01e Clean up SmartAI::MoveInLineOfSight. Remove tons of duplicate logic and forward to CreatureAI::MoveInLineOfSight instead of using its own (incorrect) implementation.
Move the removal of the 'distracted' state from SmartAI to UnitAI.cpp.

Fixes and closes #7197 and #15482.

(cherry picked from commit f446538cb16dad3dcd04e79aebc944feefc16275)
2015-10-16 12:37:42 +02:00
treeston 888c4c07b6 Scripts/Naxxramas:
Fixed bugs with Sapphiron encounter:
- Sapphiron will now properly re-engage if the previous attempt ended while he was in flight.
- Sapphiron will now properly be hovering while in the air phase instead of standing idly on the ground.
- Move Frost Resistance achievement check from custom script to spell 60539 (Sapphiron Achievement Check), thanks to @Shauren for the heads up.

(cherry picked from commit a90ae075c9de330b40d570aa172708486c0566c4)
2015-09-25 00:07:34 +02:00