josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
34,551 Commits 1 Branch 0 Tags
b9159407e0d224423e2084dc15bcd28c3b402e24
Commit Graph
34551 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jackpoz b9159407e0 Core/AI: Fix assertion triggered with PetAI derived scripts (#21254) 
* Core/AI: Fix assertion triggered with PetAI derived scripts

Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.

(cherry picked from commit 95a76a83fcbad0e52c6013697544e3c5691e7e24)
 2021-06-19 23:33:21 +02:00
Treeston d7542dc3e8 Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version. 
Closes #21265.

(cherry picked from commit b3e0c892385c7f75a061feef08c3ac05b53b4e2e)
 2021-06-19 01:57:55 +02:00
Treeston 7695784fd2 AI/SmartAI: Remove a silly incorrect piece of code that was breaking react state swaps on SAI creatures. Fixes #21353. 
(cherry picked from commit 6e0df9fce1e1f4de3ffa97bf9ef711f13f2b9a55)
 2021-06-19 01:55:18 +02:00
Treeston a8307e60a3 Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn. 
Closes #21286.

(cherry picked from commit aefc25482f79e07e1237cc0a6c01e7064fd745be)
 2021-06-19 01:35:41 +02:00
sirikfoll bd7fbce592 Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on heroic mode (Lich King) 
Movement was being prevented by spell cast

(cherry picked from commit a217c0be922f7a14bf78acb87aaaef5bc99afe95)
 2021-06-19 01:35:41 +02:00
Killyana 7987afc0e8 DB/Misc: Death knights area rework part 9 
Original work done by Grz3s on Cmangos

(cherry picked from commit 5376aa3483ae1492e4954b19953bdfc751a93bb6)
 2021-06-19 01:35:41 +02:00
Killyana 854abdbfb6 Spell/Script: Torch 52953 and 58121 must hit only one target 
(cherry picked from commit 8f71307e5619c8ef1801488812e20d07714fd733)
 2021-06-19 01:35:41 +02:00
Treeston 95fb6fe075 Core/Creature: Adjust SelectVictim behavior: (PR #21324) 
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits.
- Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished.

(cherry picked from commit 1acfefb973895b0e3df3c8d9b43b920d2a1b5392)
 2021-06-19 01:35:41 +02:00
Treeston 39dff738e1 Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. (PR #19818) 
(cherry picked from commit 03ef79f3d9e323030c771e97863398c43f6cb3a4)
 2021-06-19 01:35:41 +02:00
Treeston f5ecb30413 DB/Spell: Un-Rubik's-cubed Poisoned Spear (for Ymirheim Defender) 
(cherry picked from commit bd3e624fcaaee0b388e0486a5ebc95c88295acd2)
 2021-06-19 01:35:41 +02:00
Treeston fdc1c5b6c9 Combat/Threat: Now set engaged state for all units on offline reference registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade. 
This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you.

(cherry picked from commit 24024062280e6963f713348baba2b8c69437891a)
 2021-06-19 01:35:40 +02:00
Treeston 75a3b2f122 Game/AI: Remove some unused old logic. 
(cherry picked from commit c69584a9673ac2edb95b930c024fbd15374cb185)
 2021-06-19 01:35:40 +02:00
Shauren 428bf60f7f Scripts/Icecrown Citadel: Added missing cosmetic colors and emotes to Big Ooze (Rotface) 
(cherry picked from commit aaab7ba9f4e08ba5b7d7ac2f4e37e07d80c8f339)
 2021-06-19 01:35:40 +02:00
Killyana 2d43b8aaa3 Quest/script: Freedom to Ruul 
Follows https://github.com/TrinityCore/TrinityCore/commit/4dc91429dd2158c75679d07c34a18a2e12b4ef7a

(cherry picked from commit 52fc5a572b037a9aee084be7f5bcc9bb7d84c0e9)
 2021-06-19 01:35:38 +02:00
Killyana 30feaa06e8 DB/Quest: Freedom to Ruul 
Closes #7262

(cherry picked from commit 4dc91429dd2158c75679d07c34a18a2e12b4ef7a)
 2021-06-19 00:14:06 +02:00
Dr-J c5870aed83 DB/SAI: Wildlord Antelarion 
Updating original script which was posted for this npc at 54cb925f8bea76ddbb364208df/sql/old/3.3.5a/TDB49_to_TDB50_updates/world/2012_09_26_00_world_misc.sql#L7

so that it also replaces http://www.wowhead.com/item=31763/druid-signal as well as the felsworn gas mask

(cherry picked from commit 6dd8e2beef61d44635ec9e38fe120e33c8a968b2)
(cherry picked from commit ffbaf80aebce981ac026a69ef96cc89c480ba2f4)
 2021-06-18 21:24:21 +02:00
Treeston cb3a041482 Core/Creature: add an assertion to guard against infinite loops 
(cherry picked from commit 320306554c2240c74d991f459e7bad5eef39ec5a)
 2021-06-18 21:20:41 +02:00
Aokromes 3758fa5862 Core/Misc: Sort string 
(cherry picked from commit 4130647bf6bb278c655c5d90569dfa322d0322f9)
 2021-06-18 21:19:07 +02:00
Killyana e88648b6ef DB/Quest: Territorial Trespass 
Ref #20771

(cherry picked from commit de49ba1d7c20dd139c84e6fde68e07adda799285)
 2021-06-18 21:18:18 +02:00
ZenoX92 7fbb295392 DB/Gossip: Fallen Hero of the Horde 
Closes #21301

(cherry picked from commit 18553de3b4c230ebd8f7e10de7921d2129b32a16)
 2021-06-17 00:06:09 +02:00
ZenoX92 b106f2cfab DB/Gossip: Primal Torntusk 
Closes #21300

(cherry picked from commit 4d635a7a3ec3d0a74aef84f017739ccc994561a2)
 2021-06-16 23:54:33 +02:00
ZenoX92 88f1fece23 DB/Conditions: Master Smith Burninate 
Closes #21298

(cherry picked from commit 1d6ba4182840edb29abed87f8ae0a67fce59da68)
 2021-06-16 23:52:05 +02:00
ZenoX92 412f061ea3 DB/Quest: The End of the Deserters (11134) - fix quest credit cast 
by ZenoX92

Closes #21293

(cherry picked from commit 74f3c08e584007220bb97bc52b5b220a5a196878)
 2021-06-16 23:48:48 +02:00
Treeston 7db3f7ca96 DB/SpawnGroup: Instance spawn group data for Tempest Keep: The Eye and Hellfire Citadel: Ramparts. 
(also some minor adjustments to command output for convenience)

(cherry picked from commit 51e28ae76a40bb40bdd6f163773d2e3bd8f76ec4)
 2021-06-16 23:01:48 +02:00
Treeston 7c0ac5b959 Misc: assert -> ASSERT 
(cherry picked from commit 6c3c200cc52397b4b32ed76e676830e9f1d67d4c)
 2021-06-16 22:51:16 +02:00
Treeston 386ec58233 Scripts/Commands: new command '.debug instancespawn' 
(cherry picked from commit 6ce078d8e885f61ebdff3eb905e4cf6a2911da90)
 2021-06-16 22:50:04 +02:00
Treeston e9d77fdcff DB/SpawnGroup: Forge of Souls + Pit of Saron 
(cherry picked from commit b4572e7b0b5e12d731d4f4ade5af00f108e3b715)
 2021-06-16 22:00:31 +02:00
Dr-J 9e25da51a8 DB/Creature: Apothecary Keever 
Updating my previous script for this as my prior work was no longer working as intended, was no longer in sync with spawn of caged human and when this changed to squirrel, toad, rabbit, sheep only the name of the npc changed the the appearance never changed,
deleting the permament spawn of caged human Apothecary Keever after he casts the teleport spell

(cherry picked from commit 833b5b9e16eb32b56d056448ba0aaf83cab557d8)
 2021-06-16 21:53:44 +02:00
ariel- c43f61df3d Core/Spell: killed deprecated code which randomly changed powercost for missed spells 
Added in 80d3cd43f6

Closes #5954

(cherry picked from commit b1072faa50493e287b5353056753d65ddcc445f3)
 2021-06-16 21:40:33 +02:00
ariel- 570b2b4ce0 Core/Scripts: reverted Auriaya spell script logic 
Thanks Shauren for spotting it

(cherry picked from commit 6dd465c4414b95c3540f38ed67eae2f6bc71a3c3)
 2021-06-16 21:36:30 +02:00
Treeston 4080f341d4 DB/SpawnGroup: Spawn group data for VoA and Gundrak 
(cherry picked from commit 178b530ab6f2a77b980d9c4c4d8df6d3bfffff98)
 2021-06-16 21:36:00 +02:00
ariel- 905112b2a6 Core/Player: only call _ApplyWeaponDamage for actual weapons 
Closes #21308

(cherry picked from commit 8e0af1b93bed87753e89aebefba3fbb085f40565)
 2021-06-16 21:32:53 +02:00
ariel- d0f4310c44 Core/Entities: don't allow client control if player is still affected by any lose of control state 
(cherry picked from commit e315e41d36061fc88dfa09bfa0da1fbc0c00826f)
 2021-06-16 21:26:57 +02:00
ariel- c77925da4a Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version 
Closes #12108 (again)

(cherry picked from commit 7c9722a4ae08b5f283f6a085a411e37604a7da9f)
 2021-06-16 21:03:06 +02:00
ariel- 29bfa32fc3 Core/Entities: don't allow client control if player is still affected by any lose of control state 
(cherry picked from commit e315e41d36061fc88dfa09bfa0da1fbc0c00826f)
 2021-06-16 20:38:56 +02:00
ariel- b46d899ef1 Core/PlayerAI: perform cast checks on auto ranged attack 
Closes #19928

(cherry picked from commit 590d2518820d45e54a4a31cc554af18c0695bcd0)
 2021-06-16 19:49:57 +02:00
ariel- df585571f1 Core/Unit: fixed Global cooldown cancelation on spell interrupt 
Thanks to Nyeriah for the heads up

(cherry picked from commit 514c847881a9fff504e90f1186a1209c0b8a3674)
 2021-06-16 19:43:20 +02:00
ariel- 861cf261c5 Core/Formations: update codestyle and fix crash 
Closes #21288

(cherry picked from commit 73cc613dc86d7d72d78f22affe2faba6786bccc5)
 2021-06-16 19:26:32 +02:00
ariel- 0c56ec914f Core/Spells: fix Spirit of Redemption 
- Who would have suspected GetAuraEffect (iconId override) did a check against null spellfamilyflags?
- Remove mirror timers hack (triggered spell already allows underwater breathing)

(cherry picked from commit 4402f71eb7d17e5cf6b768a452baa00555eff7e4)
 2021-06-16 18:36:21 +02:00
tkrokli 2acaa6fb4a Core/Misc: corrections and indentations in Language.h 
- corrected the comment "1205-2002 - free" to "1205-1999 - free"
- increased the main indent by 2 spaces to get more lines aligned
- corrected the enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT from 1999 to 1199

Ref. commit 5f541491074765a346c7d0a83edb5f1fbf9240b1

(cherry picked from commit ba5f6a861652f522dd10fbe31f5e25272a3cd237)
 2021-06-16 16:25:40 +02:00
Treeston 14bda72751 Core/Unit: Remove a superfluous threat state update in SetPhaseMask. 
(cherry picked from commit 2c86c78f04f7cb95c201592b8d3002525eb6a46f)
 2021-06-16 14:37:58 +02:00
Kittnz cd3425f6a6 Scripts/Outland: Fix logical error in Hellfire event in Honor Hold 
(cherry picked from commit 8f64612cb12d2ceabf610a436e7b514acdc1b181)
 2021-06-16 14:32:07 +02:00
Treeston 73bf0e3a0b Core/Threat: Assistance threat (healing, buffs, etc.) is now properly split (instead of copied) between all creatures threatened by the action. Thanks to Foereaper for help with testing, and my apologies to healers everywhere. 
(No apologies for charm AI though. You deserve that one.)

(cherry picked from commit 013d4560c784b1deced9cd2ea11606eaf6b44f2d)
 2021-06-16 14:29:45 +02:00
Treeston 9f91cf23ab Core/Threat: Passive creatures now properly become engaged when adding an offline threat entry. Fixes RoS and Thaddius, maybe more. Closes #21269. 
(cherry picked from commit a3732756121be6d5621fb42bc7a71882a28f03a6)
 2021-06-16 14:26:10 +02:00
ariel- 85ffcd9826 Core/Scripts: fix wrong uses of SetHitDamage hook. 
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.

- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power

Closes #9560

(cherry picked from commit 9f5d1e2b10013e5fecf35fdd5af70921c96d07d1)
 2021-06-16 14:26:09 +02:00
tje3d d4359bb560 DB/Quest: A Rough Ride & The Black Knight's Orders 
Closes #21248
Closes #21249

(cherry picked from commit 946856258cf004e35b9150c60b3bc7de859a72b7)
 2021-06-16 12:56:20 +02:00
Keader 18b0135bf7 Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (again) 
Closes #21264

(cherry picked from commit 96983fc6bb0bf0793d9a8da970009f346d8cdb62)
 2021-06-16 12:45:57 +02:00
ariel- 2ef2fee3e7 Core/Auras: fixed EquippedItemClass check 
follow-up to 29c3b7d8f60c18e52ec22fec6de9abc3dc468166

(cherry picked from commit f1896144c00e9dc8f37590207feb8d7714e7132f)
 2021-06-16 12:45:18 +02:00
ariel- d0a766f14f Core/Auras: Don't remove shield only dependant auras on disarm 
Closes #19782

(cherry picked from commit b8c281f497d5da2251b11ab09f182a23a5721a1c)
 2021-06-16 12:34:40 +02:00
ariel- b27e741096 Core/Auras: define and implement attribute SPELL_ATTR3_NO_PROC_EQUIP_REQUIREMENT 
Closes #20148

(cherry picked from commit 29c3b7d8f60c18e52ec22fec6de9abc3dc468166)
 2021-06-16 12:20:14 +02:00